Re: sparse: __pure declaration only

2019-10-19 Thread Luc Van Oostenryck
On Fri, Oct 18, 2019 at 08:31:48AM -0700, Linus Torvalds wrote: > On Fri, Oct 18, 2019 at 4:15 AM Ben Dooks wrote: > > > > is this a valid warning? if not, should sparse be ignoring these. > > It's technically valid, but maybe it's not useful. > > If we make sure that any pure bits from a

Re: sparse: __pure declaration only

2019-10-18 Thread Linus Torvalds
On Fri, Oct 18, 2019 at 4:15 AM Ben Dooks wrote: > > is this a valid warning? if not, should sparse be ignoring these. It's technically valid, but maybe it's not useful. If we make sure that any pure bits from a declaration always make it into the definition, then I suspect that the "was not

sparse: __pure declaration only

2019-10-18 Thread Ben Dooks
I'm seeing the following sparse warnings where the declaration has __pure but the implementation does not. lib/bitmap.c:62:6: error: symbol '__bitmap_or_equal' redeclared with different type (originally declared at ./include/linux/bitmap.h:123) - different modifiers is this a valid warning?