Re: sparse chokes on arch/i386/kernel/i8253.c (was: 2.6.20-mm1)

2007-02-15 Thread Andrew Morton
On Thu, 15 Feb 2007 19:37:39 -0500 Mathieu Desnoyers <[EMAIL PROTECTED]> wrote: > > For what reason was that change made? > > > > It was made so that we can use the markers in C code without actually > including marker.h everywhere. I am sure someone has a better way to do > it : I would be

Re: sparse chokes on arch/i386/kernel/i8253.c (was: 2.6.20-mm1)

2007-02-15 Thread Mathieu Desnoyers
* Andrew Morton ([EMAIL PROTECTED]) wrote: > On Thu, 15 Feb 2007 17:46:56 -0500 > Mathieu Desnoyers <[EMAIL PROTECTED]> wrote: > > > > Me too. It's due to the linux-kernel-markers patches. Mathieu, can you > > > take a look please? > > > > I will give a deeper look in sparse, but I should say

Re: sparse chokes on arch/i386/kernel/i8253.c (was: 2.6.20-mm1)

2007-02-15 Thread Andrew Morton
On Thu, 15 Feb 2007 17:46:56 -0500 Mathieu Desnoyers <[EMAIL PROTECTED]> wrote: > > Me too. It's due to the linux-kernel-markers patches. Mathieu, can you > > take a look please? > > I will give a deeper look in sparse, but I should say up front that I > add this to the root build tree

Re: sparse chokes on arch/i386/kernel/i8253.c (was: 2.6.20-mm1)

2007-02-15 Thread Mathieu Desnoyers
* Andrew Morton ([EMAIL PROTECTED]) wrote: > On Thu, 15 Feb 2007 17:01:27 +0100 > Tilman Schmidt <[EMAIL PROTECTED]> wrote: > > > Trying to build 2.6.20-mm1 on i386 with C=1, sparse 0.2 chokes > > on arch/i386/kernel/i8253.c: > > > > CHECK arch/i386/kernel/i8253.c > > linux/marker.h: No such

Re: sparse chokes on arch/i386/kernel/i8253.c (was: 2.6.20-mm1)

2007-02-15 Thread Andrew Morton
On Thu, 15 Feb 2007 17:01:27 +0100 Tilman Schmidt <[EMAIL PROTECTED]> wrote: > Trying to build 2.6.20-mm1 on i386 with C=1, sparse 0.2 chokes > on arch/i386/kernel/i8253.c: > > CHECK arch/i386/kernel/i8253.c > linux/marker.h: No such file or directory > include/linux/jiffies.h:18:5: warning:

sparse chokes on arch/i386/kernel/i8253.c (was: 2.6.20-mm1)

2007-02-15 Thread Tilman Schmidt
Trying to build 2.6.20-mm1 on i386 with C=1, sparse 0.2 chokes on arch/i386/kernel/i8253.c: CHECK arch/i386/kernel/i8253.c linux/marker.h: No such file or directory include/linux/jiffies.h:18:5: warning: undefined preprocessor identifier 'CONFIG_HZ' include/linux/jiffies.h:20:7: warning:

sparse chokes on arch/i386/kernel/i8253.c (was: 2.6.20-mm1)

2007-02-15 Thread Tilman Schmidt
Trying to build 2.6.20-mm1 on i386 with C=1, sparse 0.2 chokes on arch/i386/kernel/i8253.c: CHECK arch/i386/kernel/i8253.c linux/marker.h: No such file or directory include/linux/jiffies.h:18:5: warning: undefined preprocessor identifier 'CONFIG_HZ' include/linux/jiffies.h:20:7: warning:

Re: sparse chokes on arch/i386/kernel/i8253.c (was: 2.6.20-mm1)

2007-02-15 Thread Andrew Morton
On Thu, 15 Feb 2007 17:01:27 +0100 Tilman Schmidt [EMAIL PROTECTED] wrote: Trying to build 2.6.20-mm1 on i386 with C=1, sparse 0.2 chokes on arch/i386/kernel/i8253.c: CHECK arch/i386/kernel/i8253.c linux/marker.h: No such file or directory include/linux/jiffies.h:18:5: warning:

Re: sparse chokes on arch/i386/kernel/i8253.c (was: 2.6.20-mm1)

2007-02-15 Thread Mathieu Desnoyers
* Andrew Morton ([EMAIL PROTECTED]) wrote: On Thu, 15 Feb 2007 17:01:27 +0100 Tilman Schmidt [EMAIL PROTECTED] wrote: Trying to build 2.6.20-mm1 on i386 with C=1, sparse 0.2 chokes on arch/i386/kernel/i8253.c: CHECK arch/i386/kernel/i8253.c linux/marker.h: No such file or

Re: sparse chokes on arch/i386/kernel/i8253.c (was: 2.6.20-mm1)

2007-02-15 Thread Andrew Morton
On Thu, 15 Feb 2007 17:46:56 -0500 Mathieu Desnoyers [EMAIL PROTECTED] wrote: Me too. It's due to the linux-kernel-markers patches. Mathieu, can you take a look please? I will give a deeper look in sparse, but I should say up front that I add this to the root build tree Makefile :

Re: sparse chokes on arch/i386/kernel/i8253.c (was: 2.6.20-mm1)

2007-02-15 Thread Mathieu Desnoyers
* Andrew Morton ([EMAIL PROTECTED]) wrote: On Thu, 15 Feb 2007 17:46:56 -0500 Mathieu Desnoyers [EMAIL PROTECTED] wrote: Me too. It's due to the linux-kernel-markers patches. Mathieu, can you take a look please? I will give a deeper look in sparse, but I should say up front that I

Re: sparse chokes on arch/i386/kernel/i8253.c (was: 2.6.20-mm1)

2007-02-15 Thread Andrew Morton
On Thu, 15 Feb 2007 19:37:39 -0500 Mathieu Desnoyers [EMAIL PROTECTED] wrote: For what reason was that change made? It was made so that we can use the markers in C code without actually including marker.h everywhere. I am sure someone has a better way to do it : I would be happy to use