Re: usb serial: pl2303 driver TxD "break" stays after close() bug

2015-02-23 Thread Johan Hovold
On Fri, Feb 20, 2015 at 03:11:12PM +0200, Jari Ruusu wrote: > On 2/20/15, Johan Hovold wrote: > > On Thu, Feb 19, 2015 at 03:38:39PM +0200, Jari Ruusu wrote: > >> To clear it, you need to poke it with ioctl(fd, TIOCCBRK, 0) > >> or disconnect the device. > > > > That's definitely a bug. > > > >

Re: usb serial: pl2303 driver TxD break stays after close() bug

2015-02-23 Thread Johan Hovold
On Fri, Feb 20, 2015 at 03:11:12PM +0200, Jari Ruusu wrote: On 2/20/15, Johan Hovold jo...@kernel.org wrote: On Thu, Feb 19, 2015 at 03:38:39PM +0200, Jari Ruusu wrote: To clear it, you need to poke it with ioctl(fd, TIOCCBRK, 0) or disconnect the device. That's definitely a bug.

Re: usb serial: pl2303 driver TxD "break" stays after close() bug

2015-02-20 Thread Jari Ruusu
On 2/20/15, Johan Hovold wrote: > On Thu, Feb 19, 2015 at 03:38:39PM +0200, Jari Ruusu wrote: >> To clear it, you need to poke it with ioctl(fd, TIOCCBRK, 0) >> or disconnect the device. > > That's definitely a bug. > > Care to test the patch below? Your patch fixes the bug. Thanks. -- Jari

Re: usb serial: pl2303 driver TxD break stays after close() bug

2015-02-20 Thread Jari Ruusu
On 2/20/15, Johan Hovold jo...@kernel.org wrote: On Thu, Feb 19, 2015 at 03:38:39PM +0200, Jari Ruusu wrote: To clear it, you need to poke it with ioctl(fd, TIOCCBRK, 0) or disconnect the device. That's definitely a bug. Care to test the patch below? Your patch fixes the bug. Thanks. --

Re: usb serial: pl2303 driver TxD "break" stays after close() bug

2015-02-19 Thread Johan Hovold
On Thu, Feb 19, 2015 at 03:38:39PM +0200, Jari Ruusu wrote: > On 2/19/15, Johan Hovold wrote: > > What happens when you reopen the port? Is the break state cleared then? > > Stuck "break" signal is not cleared on re-open. > > To clear it, you need to poke it with ioctl(fd, TIOCCBRK, 0) > or

Re: usb serial: pl2303 driver TxD "break" stays after close() bug

2015-02-19 Thread Jari Ruusu
On 2/19/15, Johan Hovold wrote: > What happens when you reopen the port? Is the break state cleared then? Stuck "break" signal is not cleared on re-open. To clear it, you need to poke it with ioctl(fd, TIOCCBRK, 0) or disconnect the device. -- Jari Ruusu 4096R/8132F189 12D6 4C3A DCDA 0AA4

Re: usb serial: pl2303 driver TxD break stays after close() bug

2015-02-19 Thread Jari Ruusu
On 2/19/15, Johan Hovold jo...@kernel.org wrote: What happens when you reopen the port? Is the break state cleared then? Stuck break signal is not cleared on re-open. To clear it, you need to poke it with ioctl(fd, TIOCCBRK, 0) or disconnect the device. -- Jari Ruusu 4096R/8132F189 12D6 4C3A

Re: usb serial: pl2303 driver TxD break stays after close() bug

2015-02-19 Thread Johan Hovold
On Thu, Feb 19, 2015 at 03:38:39PM +0200, Jari Ruusu wrote: On 2/19/15, Johan Hovold jo...@kernel.org wrote: What happens when you reopen the port? Is the break state cleared then? Stuck break signal is not cleared on re-open. To clear it, you need to poke it with ioctl(fd, TIOCCBRK, 0)

Re: usb serial: pl2303 driver TxD "break" stays after close() bug

2015-02-18 Thread Johan Hovold
On Thu, Feb 05, 2015 at 12:56:20PM +0200, Jari Ruusu wrote: > Tested on 3.10.67 and 3.18.5 kernels with ATEN UC-232A usb-serial adapter. > No patch, sorry. To actually see the stuck "break" signal on TxD line, you > need either some sort of LED or voltmeter connected to the data transmit > line.

Re: usb serial: pl2303 driver TxD break stays after close() bug

2015-02-18 Thread Johan Hovold
On Thu, Feb 05, 2015 at 12:56:20PM +0200, Jari Ruusu wrote: Tested on 3.10.67 and 3.18.5 kernels with ATEN UC-232A usb-serial adapter. No patch, sorry. To actually see the stuck break signal on TxD line, you need either some sort of LED or voltmeter connected to the data transmit line. Other

usb serial: pl2303 driver TxD "break" stays after close() bug

2015-02-05 Thread Jari Ruusu
Tested on 3.10.67 and 3.18.5 kernels with ATEN UC-232A usb-serial adapter. No patch, sorry. To actually see the stuck "break" signal on TxD line, you need either some sort of LED or voltmeter connected to the data transmit line. Other RS-232 serial ports that I have access to (normal PC hardware

usb serial: pl2303 driver TxD break stays after close() bug

2015-02-05 Thread Jari Ruusu
Tested on 3.10.67 and 3.18.5 kernels with ATEN UC-232A usb-serial adapter. No patch, sorry. To actually see the stuck break signal on TxD line, you need either some sort of LED or voltmeter connected to the data transmit line. Other RS-232 serial ports that I have access to (normal PC hardware