Re: [PATCH 19/23] sysctl: Call sysctl_head_finish on error

2020-07-02 Thread Al Viro
On Thu, Jul 02, 2020 at 07:15:12AM +0200, Christoph Hellwig wrote: > On Thu, Jul 02, 2020 at 01:32:40AM +0100, Matthew Wilcox wrote: > > On Wed, Jul 01, 2020 at 10:09:47PM +0200, Christoph Hellwig wrote: > > > From: "Matthew Wilcox (Oracle)" > > > > > > This error path returned directly instead

Re: [f2fs-dev] [PATCH v3] f2fs: avoid readahead race condition

2020-07-02 Thread Chao Yu
On 2020/7/2 0:14, Jaegeuk Kim wrote: > How about v4? It looks good to me. Thanks,

Re: [PATCH] mm: define pte_add_end for consistency

2020-07-02 Thread Wei Yang
On Thu, Jul 02, 2020 at 06:28:19PM +0200, David Hildenbrand wrote: >On 01.07.20 13:54, Wei Yang wrote: >> On Wed, Jul 01, 2020 at 10:29:08AM +0200, David Hildenbrand wrote: >>> On 01.07.20 04:11, Wei Yang wrote: On Tue, Jun 30, 2020 at 02:44:00PM +0200, David Hildenbrand wrote: > On

Re: objtool clac/stac handling change..

2020-07-02 Thread Al Viro
On Thu, Jul 02, 2020 at 02:55:19PM -0700, Linus Torvalds wrote: > And while XSTATE_OP() is still disgusting, it's > > (a) slightly less disgusting than it used to be > > (b) now easily fixable if we do the "exceptions clear AC" thing. > > so it's an improvement all around. > > If it works,

RE: [RESEND PATCH v10 2/2] phy: samsung-ufs: add UFS PHY driver for samsung SoC

2020-07-02 Thread Alim Akhtar
Hi Vinod > -Original Message- > From: Vinod Koul > Sent: 01 July 2020 12:23 > To: Alim Akhtar > Cc: robh...@kernel.org; k...@kernel.org; kwmad@samsung.com; > devicet...@vger.kernel.org; linux-arm-ker...@lists.infradead.org; linux- > ker...@vger.kernel.org;

[PATCH v2] pinctrl: nsp: Set irq handler based on trig type

2020-07-02 Thread Mark Tomlinson
Rather than always using handle_simple_irq() as the gpio_irq_chip handler, set a more appropriate handler based on the IRQ trigger type requested. This is important for level triggered interrupts which need to be masked during handling. Also, fix the interrupt acknowledge so that it clears only

Re: [PATCH] ARM: at91: pm: add missing put_device() call in at91_pm_sram_init()

2020-07-02 Thread yukuai (C)
On 2020/7/3 4:09, Alexandre Belloni wrote: Hi, On 04/06/2020 20:33:01+0800, yu kuai wrote: if of_find_device_by_node() succeed, at91_pm_sram_init() doesn't have a corresponding put_device(). Thus add a jump target to fix the exception handling for this function implementation. Fixes:

[PATCH] Bluetooth: btusb: add Realtek 8822CE to blacklist_table

2020-07-02 Thread Joseph Hwang
This patch adds the Realtek 8822CE controller to the blacklist_table to support the wideband speech capability. Signed-off-by: Joseph Hwang --- drivers/bluetooth/btusb.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c index

Re: [PATCH v4] selftests: tpm: upgrade TPM2 tests from Python 2 to Python 3

2020-07-02 Thread Pengfei Xu
Thanks a lot Jarkko and Shuah! BR. Thanks! On 2020-07-02 at 15:32:49 -0600, Shuah Khan wrote: > On 7/2/20 1:44 PM, Jarkko Sakkinen wrote: > > On Fri, Jun 26, 2020 at 11:40:52AM +0800, Pengfei Xu wrote: > > > Python 2 is no longer supported by the Python upstream project, so > > > upgrade TPM2

Re: [PATCH v5] xfs: Fix false positive lockdep warning with sb_internal & fs_reclaim

2020-07-02 Thread Dave Chinner
On Wed, Jul 01, 2020 at 08:59:23PM -0400, Waiman Long wrote: > Suggested-by: Dave Chinner > Signed-off-by: Waiman Long > --- > fs/xfs/xfs_super.c | 12 +++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c > index

Re: [PATCH] hwmon:max6697: Allow max6581 to create tempX_offset attributes

2020-07-02 Thread Guenter Roeck
On Thu, Jul 02, 2020 at 01:42:23AM +, Chu Lin wrote: > Per max6581, reg 4d and reg 4e is used for temperature read offset. > This patch will let the user specify the temperature read offset for > max6581. This patch is tested on max6581 and only applies to max6581. > > Testing: > echo 16250 >

[PATCH] timer: Prevent base->clk from moving backward

2020-07-02 Thread Frederic Weisbecker
When a timer is enqueued with a negative delta (ie: expiry is below base->clk), it gets added to the wheel as expiring now (base->clk). Yet the value that gets stored in base->next_expiry, while calling trigger_dyntick_cpu(), is the initial timer->expires value. The resulting state becomes:

Re: [PATCH 4/5] kprobes: Do not expose probe addresses to non-CAP_SYSLOG

2020-07-02 Thread Linus Torvalds
On Thu, Jul 2, 2020 at 4:26 PM Kees Cook wrote: > > The kprobe show() functions were using "current"'s creds instead > of the file opener's creds for kallsyms visibility. Fix to use > seq_file->file->f_cred. Side note: I have a distinct - but despite that possibly quite incorrect - memory that

Re: [PATCH] perf report TUI: Fix segmentation fault in perf_evsel__hists_browse()

2020-07-02 Thread liwei (GF)
Ping... On 2020/6/12 23:19, Namhyung Kim wrote: > Hello, > > On Fri, Jun 12, 2020 at 6:58 PM Wei Li wrote: >> >> The segmentation fault can be reproduced as following steps: >> 1) Executing perf report in tui. >> 2) Typing '/x' to filter the symbol to get nothing matched. >> 3) Pressing

Re: [PATCH v9 2/4] fs: Add standard casefolding support

2020-07-02 Thread Daniel Rosenberg
On Tue, Jun 23, 2020 at 10:57 PM Eric Biggers wrote: > > Note that the '!IS_ENCRYPTED(dir) || fscrypt_has_encryption_key(dir)' check > can > be racy, because a process can be looking up a no-key token in a directory > while > concurrently another process initializes the directory's

Re: [PATCH] cpufreq: Record stats when fast switching is enabled

2020-07-02 Thread Danny Lin
On Thu, Jan 31, 2019 at 2:14 AM, Rafael J. Wysocki wrote: > On Thu, Jan 31, 2019 at 11:07 AM Viresh Kumar wrote: > > > > On 31-01-19, 11:03, Rafael J. Wysocki wrote: > > > On Thu, Jan 31, 2019 at 9:30 AM Viresh Kumar > > > wrote: > > > > > > > > The only problem that I can think of (or recall)

Re: arch/x86/kvm/../../../virt/kvm/kvm_main.c:4326:17: sparse: struct kvm_vcpu Documentation Kbuild Makefile crypto include sound usr kvm_get_running_vcpus( ... )

2020-07-02 Thread Peter Xu
On Thu, Jul 02, 2020 at 05:18:48PM +0800, kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > master > head: cd77006e01b3198c75fb7819b3d0ff89709539bb > commit: 7495e22bb165e7030bae4d9c6e84addb5ea17b29 KVM: Move running VCPU from > ARM to

Re: [PATCH v9 5/5] kdump: update Documentation about crashkernel on arm64

2020-07-02 Thread chenzhou
Hi Dave, On 2020/7/2 10:59, Dave Young wrote: > Hi Chen, > On 06/28/20 at 04:34pm, Chen Zhou wrote: >> Now we support crashkernel=X,[low] on arm64, update the Documentation. >> We could use parameters "crashkernel=X crashkernel=Y,low" to reserve >> memory above 4G. >> >> Signed-off-by: Chen Zhou

Re: [PATCH v3 3/8] mm/hugetlb: unify migration callbacks

2020-07-02 Thread Joonsoo Kim
2020년 7월 3일 (금) 오전 1:13, Vlastimil Babka 님이 작성: > > On 6/26/20 6:02 AM, Joonsoo Kim wrote: > > 2020년 6월 25일 (목) 오후 8:26, Michal Hocko 님이 작성: > >> > >> On Tue 23-06-20 15:13:43, Joonsoo Kim wrote: > >> > From: Joonsoo Kim > >> > > >> > There is no difference between two migration callback

Re: [PATCH v6 6/6] mm/vmscan: restore active/inactive ratio for anonymous LRU

2020-07-02 Thread Joonsoo Kim
2020년 7월 2일 (목) 오후 10:45, Vlastimil Babka 님이 작성: > > On 6/17/20 7:26 AM, js1...@gmail.com wrote: > > From: Joonsoo Kim > > > > Now, workingset detection is implemented for anonymous LRU. > > We don't have to worry about the misfound for workingset due to > > the ratio of active/inactive. Let's

Re: linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s390x (bisected)

2020-07-02 Thread Tetsuo Handa
On 2020/07/03 4:46, Luis Chamberlain wrote: > On Thu, Jul 02, 2020 at 01:26:53PM +0900, Tetsuo Handa wrote: >> On 2020/07/02 0:38, Luis Chamberlain wrote: >>> @@ -156,6 +156,18 @@ static void call_usermodehelper_exec_sync(struct >>> subprocess_info *sub_info) >>> */ >>>

Re: [PATCH v4 26/26] mm/gup: Remove task_struct pointer for all gup code

2020-07-02 Thread Peter Xu
On Wed, Jul 01, 2020 at 02:55:40PM -0700, John Hubbard wrote: > On 2020-06-30 13:46, Peter Xu wrote: > > After the cleanup of page fault accounting, gup does not need to pass > > task_struct around any more. Remove that parameter in the whole gup stack. > > > > Signed-off-by: Peter Xu > > --- >

Re: [PATCH v6 5/6] mm/swap: implement workingset detection for anonymous LRU

2020-07-02 Thread Joonsoo Kim
2020년 7월 2일 (목) 오후 10:37, Vlastimil Babka 님이 작성: > > On 6/17/20 7:26 AM, js1...@gmail.com wrote: > > From: Joonsoo Kim > > > > This patch implements workingset detection for anonymous LRU. > > All the infrastructure is implemented by the previous patches so this patch > > just activates the

Re: [PATCH v6 3/6] mm/workingset: extend the workingset detection for anon LRU

2020-07-02 Thread Joonsoo Kim
2020년 7월 2일 (목) 오전 6:25, Vlastimil Babka 님이 작성: > > On 6/17/20 7:26 AM, js1...@gmail.com wrote: > > From: Joonsoo Kim > > Hi, > > I would adjust the subject, as it sounds like the patch does the whole > workingset detection, not just preparation. > How about: > > mm/workingset: prepare the

Re: [PATCH v5 3/3] ARM: imx6plus: optionally enable internal routing of clk_enet_ref

2020-07-02 Thread Sven Van Asbroeck
Hi Fabio, On Thu, Jul 2, 2020 at 6:29 PM Fabio Estevam wrote: > > With the device tree approach, I think that a better place to touch > GPR5 would be inside the fec driver. > Cool idea. I notice that the latest FEC driver (v5.8-rc3) accesses individual bits inside the gpr (via fsl,stop-mode).

Re: [PATCH v6 2/6] mm/vmscan: protect the workingset on anonymous LRU

2020-07-02 Thread Joonsoo Kim
2020년 7월 2일 (목) 오전 3:02, Vlastimil Babka 님이 작성: > > On 6/17/20 7:26 AM, js1...@gmail.com wrote: > > From: Joonsoo Kim > > Hi, how about a more descriptive subject, such as Hello, > mm/vmscan: add new anonymous pages to inactive LRU list This patch does two things to implement workingset

Re: [PATCH v4 23/26] mm/x86: Use general page fault accounting

2020-07-02 Thread Peter Xu
Hi, Dave, On Wed, Jul 01, 2020 at 08:35:40AM -0700, Dave Hansen wrote: > On 6/30/20 1:46 PM, Peter Xu wrote: > > Use the general page fault accounting by passing regs into > > handle_mm_fault(). > ... > > - /* > > -* Major/minor page fault accounting. If any of the events > > -*

Re: [PATCH] hwmon: (pmbus) fix a typo in Kconfig SENSORS_IR35221 option

2020-07-02 Thread Guenter Roeck
On Thu, Jul 02, 2020 at 03:13:49PM -0700, rentao.b...@gmail.com wrote: > From: Tao Ren > > Fix a typo in SENSORS_IR35221 option: module name should be "ir35221" > instead of "ir35521". > > Fixes: 8991ebd9c9a6 ("hwmon: (pmbus) Add client driver for IR35221") > > Cc: Samuel Mendoza-Jonas >

[PATCH] perf evsel: Don't set sample_regs_intr/sample_regs_user for dummy event

2020-07-02 Thread Jin Yao
Since commit 0a892c1c9472 ("perf record: Add dummy event during system wide synthesis"), a dummy event is added to capture mmaps. But if we run perf-record as, # perf record -e cycles:p -IXMM0 -a -- sleep 1 Error: dummy:HG: PMU Hardware doesn't support sampling/overflow-interrupts. Try 'perf

Re: [PATCH RFC v6 1/6] dt-bindings: exynos-bus: Add documentation for interconnect properties

2020-07-02 Thread Chanwoo Choi
Hi Sylwester, On 7/3/20 1:37 AM, Sylwester Nawrocki wrote: > Add documentation for new optional properties in the exynos bus nodes: > samsung,interconnect-parent, #interconnect-cells, bus-width. > These properties allow to specify the SoC interconnect structure which > then allows the

Re: [PATCH 6/8] powerpc/pseries: implement paravirt qspinlocks for SPLPAR

2020-07-02 Thread Waiman Long
On 7/2/20 12:15 PM, kernel test robot wrote: Hi Nicholas, I love your patch! Yet something to improve: [auto build test ERROR on powerpc/next] [also build test ERROR on tip/locking/core v5.8-rc3 next-20200702] [If your patch is applied to the wrong git tree, kindly drop us a note. And when

Re: [PATCH v2] PM / devfreq: tegra: Add Dmitry as a maintainer

2020-07-02 Thread Chanwoo Choi
Dear all, On 5/8/20 1:04 PM, Chanwoo Choi wrote: > Hi Rafael, > > Could you please apply it to linux-pm directly? > > I think that it is better to be applied directly > for preventing the possible merge conflict of MAINTAINERS file. > > Best Regards, > Chanwoo Choi > > On 4/3/20 7:17 AM,

Re: [PATCH 12/17] drivers: devfreq: Fix trivial spelling

2020-07-02 Thread Chanwoo Choi
On 6/9/20 9:46 PM, Kieran Bingham wrote: > The word 'descriptor' is misspelled throughout the tree. > > Fix it up accordingly: > decriptors -> descriptors > > Signed-off-by: Kieran Bingham > --- > drivers/devfreq/devfreq-event.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >

Re: [PATCH v3] x86/speculation/l1tf: Add KConfig for setting the L1D cache flush mode

2020-07-02 Thread Waiman Long
On 7/2/20 6:12 PM, Abhishek Bhardwaj wrote: This change adds a new kernel configuration that sets the l1d cache flush setting at compile time rather than at run time. Signed-off-by: Abhishek Bhardwaj Can you explain in the commit log why you need a compile time option whereas the desired

Re: [PATCH v2 4/4] mm/vmalloc: Hugepage vmalloc mappings

2020-07-02 Thread Nicholas Piggin
Excerpts from Zefan Li's message of July 1, 2020 5:10 pm: >> static void *__vmalloc_node(unsigned long size, unsigned long align, >> -gfp_t gfp_mask, pgprot_t prot, >> -int node, const void *caller); >> +gfp_t gfp_mask, pgprot_t

[PATCH] editorconfig: Add automatic editor configuration file

2020-07-02 Thread Danny Lin
EditorConfig is a standard for defining basic editor configuration in projects. There is support available for 47 code editors as of writing, including both built-in and extension support. Many notable projects have adopted the standard already, including zsh, htop, and qemu. While this isn't a

Re: [PATCH v4 1/2] gpio: add GPO driver for PCA9570

2020-07-02 Thread Sungbo Eo
On 2020-07-02 21:36, Andy Shevchenko wrote: + gpio->chip.ngpio = i2c_match_id(pca9570_id_table, client)->driver_data; Oh, avoid direct access to the table like this. And you may simply use device_get_match_data(). I'm not sure if it really does the same thing, but I'll try following

Re: [RFC PATCH 10/10] timer: Lower base clock forwarding threshold

2020-07-02 Thread Frederic Weisbecker
On Thu, Jul 02, 2020 at 05:14:23PM +0200, Thomas Gleixner wrote: > Frederic Weisbecker writes: > > On Thu, Jul 02, 2020 at 03:21:35PM +0200, Thomas Gleixner wrote: > > The following part: > > > >> > * Also while executing timers, base->clk is 1 offset ahead > >> > * of jiffies to avoid

Re: [PATCH v10 03/14] KVM: X86: Don't track dirty for KVM_SET_[TSS_ADDR|IDENTITY_MAP_ADDR]

2020-07-02 Thread Sean Christopherson
On Mon, Jun 01, 2020 at 07:59:46AM -0400, Peter Xu wrote: > Originally, we have three code paths that can dirty a page without > vcpu context for X86: > > - init_rmode_identity_map > - init_rmode_tss > - kvmgt_rw_gpa > > init_rmode_identity_map and init_rmode_tss will be setup on >

Re: [PATCH 00/14] tidy-up options / reorganize lib.c

2020-07-02 Thread Luc Van Oostenryck
Deepest apologies, I've sent this to the wrong ML. -- Luc

My Dear in the lord

2020-07-02 Thread Mrs. Mina A. Brunel
My Dear in the lord My name is Mrs. Mina A. Brunel I am a Norway Citizen who is living in Burkina Faso, I am married to Mr. Brunel Patrice, a politician who owns a small gold company in Burkina Faso; He died of Leprosy and Radesyge, in the year February 2010, During his lifetime he

Re: [PATCH] tpm: Require that all digests are present in TCG_PCR_EVENT2 structures

2020-07-02 Thread Jarkko Sakkinen
On Tue, Jun 30, 2020 at 01:33:21PM -0500, Tyler Hicks wrote: > Jarkko, is this an ack from you? > > Is there anything I can do to help along this fix? > > I've spoke with two others that have poured through these specs to > implement firmware event log parsers and they thought the change made >

Re: [PATCH] tpm: Define TPM2_SPACE_BUFFER_SIZE to replace the use of PAGE_SIZE

2020-07-02 Thread Jerry Snitselaar
On Fri Jul 03 20, Jarkko Sakkinen wrote: The size of the buffers for storing context's and sessions can vary from arch to arch as PAGE_SIZE can be anything between 4 kB and 256 kB (the maximum for PPC64). Define a fixed buffer size set to 16 kB. This should be enough for most use with three

Re: [PATCH v3 00/16] Make the user mode driver code a better citizen

2020-07-02 Thread Tetsuo Handa
On 2020/07/03 1:40, Eric W. Biederman wrote: > > This is the third round of my changeset to split the user mode driver > code from the user mode helper code, and to make the code use common > facilities to get things done instead of recreating them just > for the user mode driver code. I won't

[PATCH] testsuite: add new flag '-p' to subcommand 'format'

2020-07-02 Thread Luc Van Oostenryck
This flag facilitate the creation of testcases for preprocessing. Signed-off-by: Luc Van Oostenryck --- validation/test-suite | 4 1 file changed, 4 insertions(+) diff --git a/validation/test-suite b/validation/test-suite index d351ebf3c428..f7d992dc7c8c 100755 --- a/validation/test-suite

[PATCH] kbuild: Allow Clang global merging if !MODULES

2020-07-02 Thread Danny Lin
The old reasoning for disabling Clang's global merging optimization is that it breaks modpost by coalescing many symbols into _MergedGlobals. However, modpost is only used in builds with dynamic modules; vmlinux.symvers is still created during standalone builds, but it's effectively just an empty

Re: [PATCH v2] tpm_tis: Remove the HID IFX0102

2020-07-02 Thread Jarkko Sakkinen
On Tue, Jun 30, 2020 at 12:15:15PM -0700, Jerry Snitselaar wrote: > On Fri Jun 26 20, Jarkko Sakkinen wrote: > > On Thu, Jun 25, 2020 at 02:19:23PM -0700, Jerry Snitselaar wrote: > > > On Fri Jun 26 20, Jarkko Sakkinen wrote: > > > > On Wed, Jun 24, 2020 at 11:21:50PM -0700, Jerry Snitselaar

Re: [PATCH v2] tpm_tis: Remove the HID IFX0102

2020-07-02 Thread Jarkko Sakkinen
On Fri, Jun 26, 2020 at 07:36:31AM -0700, James Bottomley wrote: > On Fri, 2020-06-26 at 16:15 +0300, Jarkko Sakkinen wrote: > > I have an obstacle with that. > > > > I lost my previous PGP key a year ago and created a new one, which is > > not trusted yet by anyone [*]. I've backed this up now

[PATCH v5 5/5] scsi: ufs: Prepare HPB read for cached sub-region

2020-07-02 Thread Daejun Park
This patch changes the read I/O to the HPB read I/O. If the logical address of the read I/O belongs to active sub-region, the HPB driver modifies the read I/O command to HPB read. It modifies the upiu command of UFS instead of modifying the existing SCSI command. In the HPB version 1.0, the

[PATCH v5 4/5] scsi: ufs: L2P map management for HPB read

2020-07-02 Thread Daejun Park
This is a patch for managing L2P map in HPB module. The HPB divides logical addresses into several regions. A region consists of several sub-regions. The sub-region is a basic unit where L2P mapping is managed. The driver loads L2P mapping data of each sub-region. The loaded sub-region is called

[PATCH v5 3/5] scsi: ufs: Introduce HPB module

2020-07-02 Thread Daejun Park
This is a patch for the HPB module. The HPB module queries UFS for device information during initialization. We added the export symbol to two functions in ufshcd.c to initialize the HPB module. The HPB module can be loaded or built-in as needed. The mininum size of the memory pool used in the

[PATCH v5 2/5] scsi: ufs: Add UFS-feature layer

2020-07-02 Thread Daejun Park
This patch is adding UFS feature layer to UFS core driver. UFS Driver data structure (struct ufs_hba) │ ┌--┐ │ UFS feature │ <-- HPB module │layer │ <-- other extended feature module └--┘ Each extended UFS-Feature module has a bus of ufs-ext feature type.

[PATCH 0/5] Refactor kallsyms_show_value() users for correct cred

2020-07-02 Thread Kees Cook
Hi, I'm not sure who should carry this tree (me? Greg? akpm? Linus?), but it fixes a kernel address exposure bug reported by Dominik Czarnota, where /sys/modules/*/sections/* contents were visible to uid-0 without CAP_SYSLOG (e.g. in containers): This is correct, with CAP_SYSLOG: # cat

[PATCH 1/5] kallsyms: Refactor kallsyms_show_value() to take cred

2020-07-02 Thread Kees Cook
In order to perform future tests against the cred saved during open(), switch kallsyms_show_value() to operate on a cred, and have all current callers pass current_cred(). This makes it very obvious where callers are checking the wrong credential in their "read" contexts. These will be fixed in

[PATCH v2] vmlinux.lds.h: Coalesce transient LLVM dead code elimination sections

2020-07-02 Thread Danny Lin
A recent LLVM 11 commit [1] made LLD stop implicitly coalescing some temporary LLVM sections, namely .{data,bss}..compoundliteral.XXX: [30] .data..compoundli PROGBITS 9ac9a000 19e9a000 cea0 WA 0 0 32 [31] .rela.data..compo

Re: [PATCH v2 1/4] x86/xen: remove 32-bit Xen PV guest support

2020-07-02 Thread Boris Ostrovsky
On 7/2/20 7:24 PM, Andrew Cooper wrote: > On 02/07/2020 23:59, Boris Ostrovsky wrote: >> On 7/1/20 7:06 AM, Juergen Gross wrote: >>> >>> -#ifdef CONFIG_X86_PAE >>> -static void xen_set_pte_atomic(pte_t *ptep, pte_t pte) >>> -{ >>> - trace_xen_mmu_set_pte_atomic(ptep, pte); >>> -

[PATCH 3/5] module: Do not expose section addresses to non-CAP_SYSLOG

2020-07-02 Thread Kees Cook
The printing of section addresses in /sys/module/*/sections/* was not using the correct credentials to evaluate visibility. Before: # cat /sys/module/*/sections/.*text 0xc0458000 ... # capsh --drop=CAP_SYSLOG -- -c "cat /sys/module/*/sections/.*text" 0xc0458000 ... After:

[PATCH 2/5] module: Refactor section attr into bin attribute

2020-07-02 Thread Kees Cook
In order to gain access to the open file's f_cred for kallsym visibility permission checks, refactor the module section attributes to use the bin_attribute instead of attribute interface. Additionally removes the redundant "name" struct member. Cc: sta...@vger.kernel.org Signed-off-by: Kees Cook

[PATCH 4/5] kprobes: Do not expose probe addresses to non-CAP_SYSLOG

2020-07-02 Thread Kees Cook
The kprobe show() functions were using "current"'s creds instead of the file opener's creds for kallsyms visibility. Fix to use seq_file->file->f_cred. Cc: sta...@vger.kernel.org Fixes: 81365a947de4 ("kprobes: Show address of kprobes if kallsyms does") Fixes: ffb9bd68ebdb ("kprobes: Show

[PATCH 5/5] bpf: Check correct cred for CAP_SYSLOG in bpf_dump_raw_ok()

2020-07-02 Thread Kees Cook
When evaluating access control over kallsyms visibility, credentials at open() time need to be used, not the "current" creds (though in BPF's case, this has likely always been the same). Plumb access to associated file->f_cred down through bpf_dump_raw_ok() and its callers now that

Re: [PATCH 01/16] init: remove the bstat helper

2020-07-02 Thread Song Liu
Hi Christoph, On Mon, Jun 15, 2020 at 5:53 AM Christoph Hellwig wrote: > > The only caller of the bstat function becomes cleaner and simpler when > open coding the function. > > Signed-off-by: Christoph Hellwig Thanks for the set. md parts of the set look good to me. How should we route this

[PATCH v5 1/5] scsi: ufs: Add UFS feature related parameter

2020-07-02 Thread Daejun Park
This is a patch for parameters to be used for UFS features layer and HPB module. Signed-off-by: Daejun Park --- drivers/scsi/ufs/ufs.h | 12 1 file changed, 12 insertions(+) diff --git a/drivers/scsi/ufs/ufs.h b/drivers/scsi/ufs/ufs.h index f8ab16f30fdc..ae557b8d3eba 100644 ---

Re: [PATCH v2 1/4] x86/xen: remove 32-bit Xen PV guest support

2020-07-02 Thread Andrew Cooper
On 02/07/2020 23:59, Boris Ostrovsky wrote: > On 7/1/20 7:06 AM, Juergen Gross wrote: >> >> -#ifdef CONFIG_X86_PAE >> -static void xen_set_pte_atomic(pte_t *ptep, pte_t pte) >> -{ >> -trace_xen_mmu_set_pte_atomic(ptep, pte); >> -__xen_set_pte(ptep, pte); > > Probably not for this series

Re: weird loadavg on idle machine post 5.7

2020-07-02 Thread Dave Jones
On Thu, Jul 02, 2020 at 10:36:27PM +0100, Mel Gorman wrote: > I'm thinking that the !!task_contributes_to_load(p) should still happen > after smp_cond_load_acquire() when on_cpu is stable and the pi_lock is > held to stabilised p->state against a parallel wakeup or updating the > task rq. I

[PATCH v5 0/5] scsi: ufs: Add Host Performance Booster Support

2020-07-02 Thread Daejun Park
Changelog: v4 -> v5 Delete unused macro define. v3 -> v4 1. Cleanup. v2 -> v3 1. Add checking input module parameter value. 2. Change base commit from 5.8/scsi-queue to 5.9/scsi-queue. 3. Cleanup for unused variables and label. v1 -> v2 1. Change the full boilerplate text to SPDX style. 2.

Re: [PATCH v3] x86/speculation/l1tf: Add KConfig for setting the L1D cache flush mode

2020-07-02 Thread Randy Dunlap
On 7/2/20 3:12 PM, Abhishek Bhardwaj wrote: > This change adds a new kernel configuration that sets the l1d cache > flush setting at compile time rather than at run time. > > Signed-off-by: Abhishek Bhardwaj > > --- > > Changes in v3: > - Change depends on to only x86_64. > - Remove copy paste

[PATCH 06/15] options: move helpers up

2020-07-02 Thread Luc Van Oostenryck
The helpers for parsing the options are often situated just above the first function using them. As result, these helpers can be found a bit everywhere in the code, it's messy and doesn't help to reuse these helpers. So, move all these helpers to the top. Signed-off-by: Luc Van Oostenryck ---

[PATCH 05/15] options: handle_onoff_switch() can handle any flags, not only warnings

2020-07-02 Thread Luc Van Oostenryck
So, use 'flag' instead of 'warning' for variable and function names. Signed-off-by: Luc Van Oostenryck --- lib.c | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/lib.c b/lib.c index 9acdc60fc416..c27773097127 100644 --- a/lib.c +++

[PATCH 08/15] options: avoid spaces between function name and arguments list

2020-07-02 Thread Luc Van Oostenryck
It's a stylistic detail but a lot of the strcmp() calls used for the processing of the options are written 'strcmp (...)'. Two other functions calls are also in the case. Reformat them to the usual style for function calls: without the space between the function name and the arguments.

[PATCH 13/15] cleanup: move predefines in a separate file

2020-07-02 Thread Luc Van Oostenryck
Now that option parsing have moved to a separate file, move everything related to predefined macros to a separate file too. Signed-off-by: Luc Van Oostenryck --- Makefile| 1 + lib.c | 221 --- lib.h | 1 + predefine.c | 225

[PATCH 14/15] cleanup: move parsing helpers to parse.c

2020-07-02 Thread Luc Van Oostenryck
lib.c contains 2-3 helpers fro parsing. Move these to parse.c. Signed-off-by: Luc Van Oostenryck --- lib.c | 38 -- parse.c | 38 ++ 2 files changed, 38 insertions(+), 38 deletions(-) diff --git a/lib.c b/lib.c index

[PATCH 15/15] cleanup: move hexval() to utils.c

2020-07-02 Thread Luc Van Oostenryck
Now lib.c contains almost nothing else than library entrypoints. Move a small utility, hexval(), to utils.c to complete this cleanup. Signed-off-by: Luc Van Oostenryck --- lib.c | 17 - lib.h | 2 -- utils.c | 17 + utils.h | 4 4 files changed, 21

[PATCH 10/15] options: add a small helper: handle_switch_finalize()

2020-07-02 Thread Luc Van Oostenryck
This is just to isolate the details about which switch need an extra 'finalization' in a separate function in preparation to moving all the parsing code in a separate file. Signed-off-by: Luc Van Oostenryck --- lib.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git

[PATCH 12/15] options: keep the options sorted

2020-07-02 Thread Luc Van Oostenryck
The declarations and definitions of the variables corresponding to the options half-sorted half-unsorted. Sort them a little more. Signed-off-by: Luc Van Oostenryck --- options.c | 98 +++--- options.h | 137

[PATCH 04/15] options: make Wsparse_error less special

2020-07-02 Thread Luc Van Oostenryck
-Wsparse-error should not be enabled with -Wsparse-all, this is special cased in the condition in loop handling -Wsparse-all. However, the condition already handle warnings forced to off. So instead of explicitly checking for _error, it's enough to force Wsparse_error off. Signed-off-by: Luc Van

Re: weird loadavg on idle machine post 5.7

2020-07-02 Thread Michal Kubecek
On Thu, Jul 02, 2020 at 10:36:27PM +0100, Mel Gorman wrote: > > It builds, not booted, it's for discussion but maybe Dave is feeling brave! > > diff --git a/kernel/sched/core.c b/kernel/sched/core.c > index ca5db40392d4..52c73598b18a 100644 > --- a/kernel/sched/core.c > +++ b/kernel/sched/core.c

[PATCH 11/15] options: move option parsing in a separate file

2020-07-02 Thread Luc Van Oostenryck
lib.c contains to much things and is too hard to keep tidy. So, move everything related to option parsing in it's own file. Signed-off-by: Luc Van Oostenryck --- Makefile | 1 + lib.c | 982 + lib.h | 117 +-- options.c | 998

[PATCH 03/15] options: move on top the definition of warning type enums

2020-07-02 Thread Luc Van Oostenryck
This allows to reuse these enums in earlier helpers. Signed-off-by: Luc Van Oostenryck --- lib.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/lib.c b/lib.c index 5128a5b64e9e..43d55a0648ee 100644 --- a/lib.c +++ b/lib.c @@ -250,6 +250,12 @@ void die(const

[PATCH 07/15] options: alphasort the handle_switch_[a-zA_Z]()

2020-07-02 Thread Luc Van Oostenryck
These function have probably been added in 'historical order' and as result it's not easy to quickly see where they're defined. Change this arranging them in asciibetical order. Signed-off-by: Luc Van Oostenryck --- lib.c | 656 +- 1 file

[PATCH 02/15] options: move -Wsparse-all's processing out of handle_onoff_switch()

2020-07-02 Thread Luc Van Oostenryck
Since handle_onoff_switch() can be used for other flags than the warnings, the processing of -Wsparse-all should move elsewhere. So move it into handle_switch_W(). Signed-off-by: Luc Van Oostenryck --- lib.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git

[PATCH 09/15] options: move declaration of tabstop out of "token.h"

2020-07-02 Thread Luc Van Oostenryck
'tabstop' is unusual in the sense that it's one the few (the only?) variable defined via an option flag which is not declared in "lib.h" but in "token.h". This for to have to include "token.h" in the code doing the parsing of the options ... Move this declaration to "lib.h". Signed-off-by: Luc

[PATCH 00/14] tidy-up options / reorganize lib.c

2020-07-02 Thread Luc Van Oostenryck
A lot of content in lib.c have been added by just appending at the bottom of what was already present. As consequence, things are now not well organized at all, especially when related to the options. So, reorganize things a little bit here: *) move all helpers on top *) keep things alphabetically

[PATCH 01/15] options: let handle_onoff_switch() use null terminated arrays

2020-07-02 Thread Luc Van Oostenryck
This makes things slightly easier to use. Signed-off-by: Luc Van Oostenryck --- lib.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/lib.c b/lib.c index e56788260cb7..709dd5176112 100644 --- a/lib.c +++ b/lib.c @@ -529,14 +529,14 @@ enum {

Re: [PATCH v10 02/14] KVM: Cache as_id in kvm_memory_slot

2020-07-02 Thread Sean Christopherson
On Mon, Jun 01, 2020 at 07:59:45AM -0400, Peter Xu wrote: > Cache the address space ID just like the slot ID. It will be used in > order to fill in the dirty ring entries. > > Suggested-by: Paolo Bonzini > Suggested-by: Sean Christopherson > Signed-off-by: Peter Xu > --- >

Re: [PATCH 0/3] selftests: tpm: fixes

2020-07-02 Thread Jarkko Sakkinen
On Mon, Jun 29, 2020 at 02:21:47PM -0600, Shuah Khan wrote: > On 6/22/20 3:20 PM, Jarkko Sakkinen wrote: > > A few fixes for tools/testing/selftests/tpm. > > > > Jarkko Sakkinen (3): > >Revert "tpm: selftest: cleanup after unseal with wrong auth/policy > > test" > >selftests: tpm:

Re: [RFC PATCH 4/7] crypto: remove ARC4 support from the skcipher API

2020-07-02 Thread Ard Biesheuvel
On Thu, 2 Jul 2020 at 20:21, Ard Biesheuvel wrote: > > On Thu, 2 Jul 2020 at 19:50, Eric Biggers wrote: > > > > [+linux-wireless, Marcel Holtmann, and Denis Kenzior] > > > > On Thu, Jul 02, 2020 at 12:19:44PM +0200, Ard Biesheuvel wrote: > > > Remove the generic ecb(arc4) skcipher, which is

Re: [PATCH 2/2] perf tools: Fix record failure when mixed with ARM SPE event

2020-07-02 Thread Mathieu Poirier
Hi Li, On Tue, Jun 23, 2020 at 08:31:41PM +0800, Wei Li wrote: > When recording with cache-misses and arm_spe_x event, i found that > it will just fail without showing any error info if i put cache-misses > after arm_spe_x event. > > [root@localhost 0620]# perf record -e cache-misses -e \ >

Re: [PATCH v2 1/4] x86/xen: remove 32-bit Xen PV guest support

2020-07-02 Thread Boris Ostrovsky
On 7/1/20 7:06 AM, Juergen Gross wrote: > Xen is requiring 64-bit machines today and since Xen 4.14 it can be > built without 32-bit PV guest support. There is no need to carry the > burden of 32-bit PV guest support in the kernel any longer, as new > guests can be either HVM or PVH, or they can

[PATCH] tpm: Define TPM2_SPACE_BUFFER_SIZE to replace the use of PAGE_SIZE

2020-07-02 Thread Jarkko Sakkinen
The size of the buffers for storing context's and sessions can vary from arch to arch as PAGE_SIZE can be anything between 4 kB and 256 kB (the maximum for PPC64). Define a fixed buffer size set to 16 kB. This should be enough for most use with three handles (that is how many we allow at the

[PATCH v4] drivers/nvme: Add support for ACPI StorageD3Enable property

2020-07-02 Thread David E. Box
This patch implements a solution for a BIOS hack used on some currently shipping Intel systems to change driver power management policy for PCIe NVMe drives. Some newer Intel platforms, like some Comet Lake systems, require that PCIe devices use D3 when doing suspend-to-idle in order to allow the

Re: [PATCH 0/5] RFC: connector: Add network namespace awareness

2020-07-02 Thread Aleksa Sarai
On 2020-07-02, Christian Brauner wrote: > On Thu, Jul 02, 2020 at 08:17:38AM -0500, Eric W. Biederman wrote: > > Matt Bennett writes: > > > > > Previously the connector functionality could only be used by processes > > > running in the > > > default network namespace. This meant that any

Re: [PATCH v5 03/10] dmaengine: Actions: Add support for S700 DMA engine

2020-07-02 Thread kernel test robot
Hi Amit, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on robh/for-next] [also build test WARNING on clk/clk-next pza/reset/next linus/master v5.8-rc3 next-20200702] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting

Re: [PATCH 1/2] perf tools: ARM SPE code cleanup

2020-07-02 Thread Mathieu Poirier
On Tue, Jun 23, 2020 at 08:31:40PM +0800, Wei Li wrote: > Remove the useless check code to make it clear. > > Signed-off-by: Wei Li > --- > tools/perf/arch/arm/util/auxtrace.c | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/tools/perf/arch/arm/util/auxtrace.c >

[PATCH v2] igb: reinit_locked() should be called with rtnl_lock

2020-07-02 Thread Francesco Ruggeri
We observed two panics involving races with igb_reset_task. The first panic is caused by this race condition: kworker reboot -f igb_reset_task igb_reinit_locked igb_down napi_synchronize __igb_shutdown

Re: [PATCH v2 7/7] KVM: X86: Move kvm_apic_set_version() to kvm_update_vcpu_model()

2020-07-02 Thread Xiaoyao Li
On 7/3/2020 3:00 AM, Sean Christopherson wrote: On Tue, Jun 23, 2020 at 07:58:16PM +0800, Xiaoyao Li wrote: Obviously, kvm_apic_set_version() fits well in kvm_update_vcpu_model(). Same as the last patch, it would be nice to explicitly document that there are no dependencies between

Re: [GIT PULL] io_uring fixes for 5.8-rc4

2020-07-02 Thread pr-tracker-bot
The pull request you sent on Wed, 1 Jul 2020 22:30:24 -0600: > git://git.kernel.dk/linux-block.git tags/io_uring-5.8-2020-07-01 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/c93493b7cd40c20708e3373a7cc8e8049460d7ce Thank you! -- Deet-doot-dot, I am a bot.

Re: [PATCH v5 3/3] ARM: imx6plus: optionally enable internal routing of clk_enet_ref

2020-07-02 Thread Fabio Estevam
Hi Sven, On Thu, Jul 2, 2020 at 2:53 PM Sven Van Asbroeck wrote: > + /* > +* On imx6 plus, enet_ref from ANATOP/CCM can be internally routed to > +* be the PTP clock source, instead of having to be routed through > +* pads. > +*/ > + if

Re: [PATCH v2 6/7] KVM: X86: Move kvm_x86_ops.update_vcpu_model() into kvm_update_vcpu_model()

2020-07-02 Thread Xiaoyao Li
On 7/3/2020 2:59 AM, Sean Christopherson wrote: On Tue, Jun 23, 2020 at 07:58:15PM +0800, Xiaoyao Li wrote: kvm_x86_ops.update_vcpu_model() is used to update vmx/svm vcpu settings based on updated CPUID settings. So it's supposed to be called after CPUIDs are fully updated, i.e.,

Re: [PATCH v2 2/7] KVM: X86: Go on updating other CPUID leaves when leaf 1 is absent

2020-07-02 Thread Xiaoyao Li
On 7/3/2020 3:02 AM, Sean Christopherson wrote: On Thu, Jul 02, 2020 at 11:54:03AM -0700, Sean Christopherson wrote: On Tue, Jun 23, 2020 at 07:58:11PM +0800, Xiaoyao Li wrote: As handling of bits other leaf 1 added over time, kvm_update_cpuid() should not return directly if leaf 1 is absent,

Re: [PATCH 4.19 114/131] ocfs2: avoid inode removal while nfsd is accessing it

2020-07-02 Thread Linus Torvalds
On Thu, Jul 2, 2020 at 2:17 PM Pavel Machek wrote: > > > > commit 4cd9973f9ff69e37dd0ba2bd6e6423f8179c329a upstream. > > > > Patch series "ocfs2: fix nfsd over ocfs2 issues", v2. > > This causes locking imbalance: This sems to be true upstream too. > When ocfs2_nfs_sync_lock() returns error,

<    1   2   3   4   5   6   7   8   9   10   >