Re: [PATCH] scsi: docs: Remove obsolete scsi typedef text from scsi_mid_low_api

2020-09-08 Thread Martin K. Petersen
Nícolas, > Commit 91ebc1facd77 ("scsi: core: remove Scsi_Cmnd typedef") removed > the Scsi_cmnd typedef but it was still mentioned in a paragraph in the > "SCSI mid_level - lower_level driver interface" documentation page. > Remove this obsolete paragraph. Applied to my 5.10 staging tree.

Re: [PATCH V2 4/5] iommu/vt-d: Convert intel iommu driver to the iommu ops

2020-09-08 Thread Lu Baolu
On 9/4/20 4:18 AM, Tom Murphy wrote: +static int intel_iommu_needs_bounce_buffer(struct device *d) +{ + return !intel_no_bounce && dev_is_pci(d) && to_pci_dev(d)->untrusted; +} + + static void intel_iommu_probe_finalize(struct device *dev) { - struct iommu_domain *domain; +

Re: [PATCH] scsi: qla2xxx: Fix the return value

2020-09-08 Thread Martin K. Petersen
On Sat, 29 Aug 2020 15:57:46 +0800, Xianting Tian wrote: > A negative error code should be returned. Applied to 5.10/scsi-queue, thanks! [1/1] scsi: qla2xxx: Fix the return value https://git.kernel.org/mkp/scsi/c/e5f48ac42cc9 -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: mptscsih: remove set but not used 'timeleft'

2020-09-08 Thread Martin K. Petersen
On Thu, 27 Aug 2020 20:59:25 +0800, Jason Yan wrote: > This addresses the following gcc warning with "make W=1": > > drivers/message/fusion/mptscsih.c: In function ‘mptscsih_IssueTaskMgmt’: > drivers/message/fusion/mptscsih.c:1519:17: warning: variable ‘timeleft’ > set but not used

Re: [PATCH] scsi: isci: remove set but not used 'index'

2020-09-08 Thread Martin K. Petersen
On Thu, 27 Aug 2020 20:58:51 +0800, Jason Yan wrote: > This addresses the following gcc warning with "make W=1": > > drivers/scsi/isci/host.c: In function ‘sci_controller_complete_io’: > drivers/scsi/isci/host.c:2674:6: warning: variable ‘index’ set but not > used [-Wunused-but-set-variable] >

Re: [PATCH] scsi: qedi: Remove redundant null check

2020-09-08 Thread Martin K. Petersen
On Thu, 27 Aug 2020 09:26:06 +, Xu Wang wrote: > Because kfree_skb already checked NULL skb parameter, > so the additional check is unnecessary, just remove it. Applied to 5.10/scsi-queue, thanks! [1/1] scsi: qedi: Remove redundant NULL check

Re: [PATCH] scsi: libsas: Fix error path in sas_notify_lldd_dev_found()

2020-09-08 Thread Martin K. Petersen
On Sat, 5 Sep 2020 15:58:36 +0300, Dan Carpenter wrote: > In sas_notify_lldd_dev_found(), if we can't find a device, then it seems > like the wrong thing to mark the device as found and to increment the > reference count. None of the callers ever drop the reference in that > situation. Applied

RE: [PATCH] Revert "block: revert back to synchronous request_queue removal"

2020-09-08 Thread Zhao, Haifeng
Ming, Christoph, Could you point out the patch aimed to fix this issue ? I would like to try it. This issue blocked my other PCI patch developing and verification work, I am not a BLOCK/NVMe expert, wouldn't to be trapped into other sub-system bugs, so just reported it for other expert's

Re: [PATCH 0/8] hisi_sas: Misc patches

2020-09-08 Thread Martin K. Petersen
On Tue, 1 Sep 2020 19:13:02 +0800, John Garry wrote: > This series contains some minor feature updates and general tidying: > - Some new BIST features > - Stop modifying previously unused fields in programmable link rate reg > - Stop accessing some SSP task fields for SMP tasks > - General minor

Re: [PATCH] scsi: dpt_i2o: remove set but not used 'pHba'

2020-09-08 Thread Martin K. Petersen
On Thu, 27 Aug 2020 20:58:12 +0800, Jason Yan wrote: > This addresses the following gcc warning with "make W=1": > > drivers/scsi/dpt_i2o.c: In function ‘adpt_slave_configure’: > drivers/scsi/dpt_i2o.c:411:12: warning: variable ‘pHba’ set but not used > [-Wunused-but-set-variable] > 411 |

drivers/spi/spi-rspi.c:1128:29: warning: unused variable 'rspi_rz_ops'

2020-09-08 Thread kernel test robot
Hi Geert, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 34d4ddd359dbcdf6c5fb3f85a179243d7a1cb7f8 commit: 851c902fd2d09b2ed85181e74b43477b7a3882be spi: rspi: Remove obsolete platform_device_id entries date: 9

Re: [PATCH 00/29] treewide: Convert comma separated statements

2020-09-08 Thread Martin K. Petersen
On Mon, 24 Aug 2020 21:55:57 -0700, Joe Perches wrote: > There are many comma separated statements in the kernel. > See:https://lore.kernel.org/lkml/alpine.DEB.2.22.394.2008201856110.2524@hadrien/ > > Convert the comma separated statements that are in if/do/while blocks > to use braces and

Re: [PATCH v2] scsi: libcxgbi: use kvzalloc instead of opencoded kzalloc/vzalloc

2020-09-08 Thread Martin K. Petersen
On Sat, 1 Aug 2020 16:31:23 +0300, Denis Efremov wrote: > Remove cxgbi_alloc_big_mem(), cxgbi_free_big_mem() functions > and use kvzalloc/kvfree instead. __GFP_NOWARN added to kvzalloc() > call because we already print a warning in case of allocation fail. Applied to 5.10/scsi-queue, thanks!

Re: [PATCH -next] scsi: Remove unneeded cast from memory allocation

2020-09-08 Thread Martin K. Petersen
On Wed, 29 Jul 2020 17:19:50 +0800, Li Heng wrote: > Remove casting the values returned by memory allocation function. > > Coccinelle emits WARNING: > > ./drivers/message/fusion/mptctl.c:2596:14-31: WARNING: casting value returned > by memory allocation function to (SCSIDevicePage0_t *) is

Re: [PATCH] scsi: ufs-mediatek: Modify the minimum RX/TX lane count to 2

2020-09-08 Thread Martin K. Petersen
On Wed, 19 Aug 2020 16:43:40 +0800, Stanley Chu wrote: > MediaTek UFS host starts to support 2 lanes, thus modify the > minimum lane count to 2. > > This modification shall not impact old 1-lane host because > PA_CONNECTEDRXDATALANES and PA_CONNECTEDTXDATALANES will limit the > target lanes

Re: [PATCH -next 0/3] scsi: Remove superfluous memset()

2020-09-08 Thread Martin K. Petersen
On Thu, 30 Jul 2020 11:31:55 +0800, Li Heng wrote: > *** BLURB HERE *** > > Li Heng (3): > scsi: Remove superfluous memset() > scsi: Remove superfluous memset() > scsi: Remove superfluous memset() > > [...] Applied to 5.10/scsi-queue, thanks! [1/3] scsi: pmcraid: Remove superfluous

Re: [PATCH v2] scsi: ufs: Remove an unpaired ufshcd_scsi_unblock_requests() in err_handler()

2020-09-08 Thread Martin K. Petersen
On Tue, 18 Aug 2020 18:02:29 -0700, Can Guo wrote: > Commit 5586dd8ea250 ("scsi: ufs: Fix a race condition between error handler > and runtime PM ops") moves the ufshcd_scsi_block_requests() inside > err_handler(), but forgets to remove the ufshcd_scsi_unblock_requests() in > the early return

Re: [PATCH v2 1/1] samples/seccomp: eliminate two compile warnings in user-trap.c

2020-09-08 Thread Leizhen (ThunderTown)
On 2020/9/9 7:42, Kees Cook wrote: > On Wed, Sep 02, 2020 at 09:33:06AM +0800, Leizhen (ThunderTown) wrote: >> On 2020/9/1 16:39, Zhen Lei wrote: >>> samples/seccomp/user-trap.c is compiled with $(userccflags), and the >>> latter does not contain -fno-strict-aliasing, so the warnings reported

Re: [PATCH v18 00/32] per memcg lru_lock: reviews

2020-09-08 Thread Wei Yang
On Tue, Sep 08, 2020 at 04:41:00PM -0700, Hugh Dickins wrote: [...] >[PATCH v18 06/32] mm/thp: narrow lru locking >Why? What part does this play in the series? "narrow lru locking" can >also be described as "widen page cache locking": you are changing the >lock ordering, and not giving any reason

Re: [PATCH] mm/mmap: leave adjust_next as virtual address instead of page frame number

2020-09-08 Thread Wei Yang
On Tue, Sep 08, 2020 at 05:31:22PM +0200, Vlastimil Babka wrote: >On 8/28/20 10:10 AM, Wei Yang wrote: >> Instead of convert adjust_next between virtual address and page frame >> number, let's just store the virtual address into adjust_next. > >IMHO more precisely/less confusing it's "bytes" and

Re: [PATCH net-next v2 2/9] net: ethernet: ti: ale: add static configuration

2020-09-08 Thread David Miller
From: Grygorii Strashko Date: Mon, 7 Sep 2020 17:31:36 +0300 > + ale_dev_id = cpsw_ale_match_id(cpsw_ale_id_match, params->dev_id); > + if (ale_dev_id) { > + params->ale_entries = ale_dev_id->tbl_entries; > + params->major_ver_mask = ale_dev_id->major_ver_mask;

Re: [PATCH] net: sched: skip an unnecessay check

2020-09-08 Thread David Miller
From: t...@redhat.com Date: Mon, 7 Sep 2020 11:04:38 -0700 > From: Tom Rix > > Reviewing the error handling in tcf_action_init_1() > most of the early handling uses > > err_out: > if (cookie) { > kfree(cookie->data); > kfree(cookie); > } > > before

[PATCH] f2fs: clean up vm_map_ram() call

2020-09-08 Thread Daeho Jeong
From: Daeho Jeong Made f2fs_vmap() wrapper to handle vm_map_ram() stuff. Signed-off-by: Daeho Jeong --- fs/f2fs/compress.c | 42 ++ 1 file changed, 18 insertions(+), 24 deletions(-) diff --git a/fs/f2fs/compress.c b/fs/f2fs/compress.c index

linux-next: build warning after merge of the pci tree

2020-09-08 Thread Stephen Rothwell
Hi all, After merging the pci tree, today's linux-next build (arm multi_v7_defconfig) produced this warning: drivers/pci/controller/dwc/pci-dra7xx.c: In function 'dra7xx_pcie_establish_link': drivers/pci/controller/dwc/pci-dra7xx.c:142:6: warning: unused variable 'exp_cap_off'

linux-next: build warning after merge of the pci tree

2020-09-08 Thread Stephen Rothwell
Hi all, After merging the pci tree, today's linux-next build (arm multi_v7_defconfig) produced this warning: WARNING: modpost: "dw_pcie_link_set_max_speed" [vmlinux] is a static EXPORT_SYMBOL_GPL Introduced by commit 3af45d34d30c ("PCI: dwc: Centralize link gen setting") -- Cheers,

Re: [PATCH] Revert "block: revert back to synchronous request_queue removal"

2020-09-08 Thread Ming Lei
Hello Haifeng, On Wed, Sep 09, 2020 at 02:11:20AM +, Zhao, Haifeng wrote: > Ming, Christoph, > Could you point out the patch aimed to fix this issue ? I would like to > try it. This issue blocked my other PCI patch developing and verification > work, > I am not a BLOCK/NVMe expert,

Re: v5.9-rc3-rt3 boot time networking lockdep splat

2020-09-08 Thread Mike Galbraith
On Tue, 2020-09-08 at 17:06 +0200, Sebastian Andrzej Siewior wrote: > > This should cure it: It did. -Mike

RE: [PATCH] Revert "block: revert back to synchronous request_queue removal"

2020-09-08 Thread Zhao, Haifeng
Ming, Got it, will try and give you feedback. Thanks, -Original Message- From: Ming Lei Sent: Wednesday, September 9, 2020 10:39 AM To: Zhao, Haifeng Cc: Christoph Hellwig ; ax...@kernel.dk; bhelg...@google.com; linux-bl...@vger.kernel.org; linux-kernel@vger.kernel.org;

Re: [PATCH next v2 0/3] soc: ti: k3: ringacc: add am65x sr2.0 support

2020-09-08 Thread santosh . shilimkar
On 9/8/20 3:09 PM, Suman Anna wrote: Hi Santosh, On 8/31/20 1:34 PM, santosh.shilim...@oracle.com wrote: On 8/29/20 11:41 AM, Grygorii Strashko wrote: Hi Santosh, I've rebased on top of  linux-next and identified merge conflict of patch 3 with commit 6da45875fa17 ("arm64: dts: k3-am65:

Re: [PATCH v2 1/2] dt-bindings: spmi: document binding for the Mediatek SPMI controller

2020-09-08 Thread Hsin-Hsiung Wang
Hi, On Tue, 2020-09-08 at 14:49 -0600, Rob Herring wrote: > On Fri, Aug 21, 2020 at 06:44:36PM +0800, Hsin-Hsiung Wang wrote: > > This adds documentation for the SPMI controller found on Mediatek SoCs. > > > > Signed-off-by: Hsin-Hsiung Wang > > --- > >

Re: [PATCH v18 00/32] per memcg lru_lock

2020-09-08 Thread Aaron Lu
On Thu, Aug 27, 2020 at 09:40:22PM -0400, Daniel Jordan wrote: > I went back to your v1 post to see what motivated you originally, and you had > some results from aim9 but nothing about where this reared its head in the > first place. How did you discover the bottleneck? I'm just curious about

Re: [PATCH net-next 0/7] net: hns3: misc updates

2020-09-08 Thread David Miller
From: Jakub Kicinski Date: Tue, 8 Sep 2020 12:05:38 -0700 > On Tue, 8 Sep 2020 10:59:47 +0800 Huazhong Tan wrote: >> There are some misc updates for the HNS3 ethernet driver. >> >> #1 narrows two local variable range in hclgevf_reset_prepare_wait(). >> #2 adds reset failure check in periodic

Re: [PATCH 0/4] scsi: ufs-mediatek: Fixes for kernel v5.10

2020-09-08 Thread Martin K. Petersen
Stanley, > This series fix some defects and introduce host reset mechanism in > MediaTek UFS platforms. Please consider this patch series for kernel > v5.10. Applied to the 5.10 SCSI staging tree. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [net-next] net: smsc911x: Remove unused variables

2020-09-08 Thread David Miller
From: Wei Xu Date: Tue, 8 Sep 2020 11:49:25 +0800 > Fixes the following W=1 kernel build warning(s): > > drivers/net/ethernet/smsc/smsc911x.c: In function ‘smsc911x_rx_fastforward’: > drivers/net/ethernet/smsc/smsc911x.c:1199:16: warning: variable ‘temp’ set > but not used

[PATCH 1/3] KVM: SVM: Get rid of handle_fastpath_set_msr_irqoff()

2020-09-08 Thread Wanpeng Li
From: Wanpeng Li Analysis from Sean: | svm->next_rip is reset in svm_vcpu_run() only after calling | svm_exit_handlers_fastpath(), which will cause SVM's | skip_emulated_instruction() to write a stale RIP. Let's get rid of handle_fastpath_set_msr_irqoff() in svm_exit_handlers_fastpath()

Re: [PATCH v9 00/24] coresight: allow to build coresight as modules

2020-09-08 Thread Tingwei Zhang
On Wed, Sep 09, 2020 at 01:53:51AM +0800, Mathieu Poirier wrote: > Hi Tingwei, > > Apologies for the untimely response to this set, I am hoping to get to > it in the next two weeks. > It's fine, Mathieu. Please let me know your comments once you have time. I'm targeting to get these set merged

[PATCH 2/3] KVM: SVM: Move svm_complete_interrupts() into svm_vcpu_run()

2020-09-08 Thread Wanpeng Li
From: Wanpeng Li Moving svm_complete_interrupts() into svm_vcpu_run() which can align VMX and SVM with respect to completing interrupts. Suggested-by: Sean Christopherson Cc: Paul K. Signed-off-by: Wanpeng Li --- arch/x86/kvm/svm/svm.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH 3/3] KVM: SVM: Reenable handle_fastpath_set_msr_irqoff() after complete_interrupts()

2020-09-08 Thread Wanpeng Li
From: Wanpeng Li Moving the call to svm_exit_handlers_fastpath() after svm_complete_interrupts() since svm_complete_interrupts() consumes rip and reenable the function handle_fastpath_set_msr_irqoff() call in svm_exit_handlers_fastpath(). Suggested-by: Sean Christopherson Cc: Paul K.

[PATCH v4] usb-serial:cp210x: add support to software flow control

2020-09-08 Thread Sheng Long Wang
From: Wang Sheng Long When data is transmitted between two serial ports, the phenomenon of data loss often occurs. The two kinds of flow control commonly used in serial communication are hardware flow control and software flow control. In serial communication, If you only use RX/TX/GND Pins,

[PATCH RESEND 1/3] KVM: SVM: Get rid of handle_fastpath_set_msr_irqoff()

2020-09-08 Thread Wanpeng Li
From: Wanpeng Li Analysis from Sean: | svm->next_rip is reset in svm_vcpu_run() only after calling | svm_exit_handlers_fastpath(), which will cause SVM's | skip_emulated_instruction() to write a stale RIP. Let's get rid of handle_fastpath_set_msr_irqoff() in svm_exit_handlers_fastpath()

[PATCH RESEND 3/3] KVM: SVM: Reenable handle_fastpath_set_msr_irqoff() after complete_interrupts()

2020-09-08 Thread Wanpeng Li
From: Wanpeng Li Moving the call to svm_exit_handlers_fastpath() after svm_complete_interrupts() since svm_complete_interrupts() consumes rip and reenable the function handle_fastpath_set_msr_irqoff() call in svm_exit_handlers_fastpath(). Suggested-by: Sean Christopherson Cc: Paul K.

[PATCH RESEND 2/3] KVM: SVM: Move svm_complete_interrupts() into svm_vcpu_run()

2020-09-08 Thread Wanpeng Li
From: Wanpeng Li Moving svm_complete_interrupts() into svm_vcpu_run() which can align VMX and SVM with respect to completing interrupts. Suggested-by: Sean Christopherson Cc: Paul K. Signed-off-by: Wanpeng Li --- arch/x86/kvm/svm/svm.c | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [PATCH v2 3/5] i2c: aspeed: Mask IRQ status to relevant bits

2020-09-08 Thread Tao Ren
On Tue, Sep 08, 2020 at 03:00:59PM -0500, Eddie James wrote: > Mask the IRQ status to only the bits that the driver checks. This > prevents excessive driver warnings when operating in slave mode > when additional bits are set that the driver doesn't handle. > > Signed-off-by: Eddie James

Re: [v4,3/4] reset-controller: ti: introduce a new reset handler

2020-09-08 Thread Crystal Guo
On Thu, 2020-09-03 at 07:40 +0800, Suman Anna wrote: > Hi Crystal, > > On 8/16/20 10:03 PM, Crystal Guo wrote: > > Introduce ti_syscon_reset() to integrate assert and deassert together. > > If some modules need do serialized assert and deassert operations > > to reset itself, reset_control_reset

Re: [PATCH 2/2] kunit: ubsan integration

2020-09-08 Thread Stephen Rothwell
Hi Qian, On Thu, 3 Sep 2020 08:38:25 -0400 Qian Cai wrote: > > On Wed, Sep 02, 2020 at 08:52:24AM -0400, Qian Cai wrote: > > On Thu, Aug 06, 2020 at 05:43:26PM +, Uriel Guajardo wrote: > > > Integrates UBSAN into the KUnit testing framework. It fails KUnit tests > > > whenever it reports

[MPTCP][PATCH net] mptcp: fix kmalloc flag in mptcp_pm_nl_get_local_id

2020-09-08 Thread Geliang Tang
mptcp_pm_nl_get_local_id may be called in interrupt context, so we need to use GFP_ATOMIC flag to allocate memory to avoid sleeping in atomic context. [ 280.209809] BUG: sleeping function called from invalid context at mm/slab.h:498 [ 280.209812] in_atomic(): 1, irqs_disabled(): 0, non_block:

Re: [PATCH net-next] cipso: fix 'audit_secid' kernel-doc warning in cipso_ipv4.c

2020-09-08 Thread David Miller
From: Wang Hai Date: Tue, 8 Sep 2020 21:59:15 +0800 > Fixes the following W=1 kernel build warning(s): > > net/ipv4/cipso_ipv4.c:510: warning: Excess function parameter 'audit_secid' > description in 'cipso_v4_doi_remove' > > Reported-by: Hulk Robot > Signed-off-by: Wang Hai Applied.

Re: [PATCH net-next] netlabel: Fix some kernel-doc warnings

2020-09-08 Thread David Miller
From: Wang Hai Date: Tue, 8 Sep 2020 22:05:43 +0800 > Fixes the following W=1 kernel build warning(s): > > net/netlabel/netlabel_calipso.c:438: warning: Excess function parameter > 'audit_secid' description in 'calipso_doi_remove' > net/netlabel/netlabel_calipso.c:605: warning: Excess function

Re: [PATCH net-next] bnx2x: Fix some kernel-doc warnings

2020-09-08 Thread David Miller
From: Wang Hai Date: Tue, 8 Sep 2020 22:01:58 +0800 > Fixes the following W=1 kernel build warning(s): > > drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c:4238: warning: Excess > function parameter 'netdev' description in 'bnx2x_setup_tc' > drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c:4238:

Re: [PATCH net-next] net: wimax: i2400m: fix 'msg_skb' kernel-doc warning in i2400m_msg_to_dev()

2020-09-08 Thread David Miller
From: Wang Hai Date: Tue, 8 Sep 2020 22:03:33 +0800 > Fixes the following W=1 kernel build warning(s): > > drivers/net/wimax/i2400m/control.c:709: warning: Excess function parameter > 'msg_skb' description in 'i2400m_msg_to_dev' > > This parameter is not in use. Remove it. > > Reported-by:

Re: [PATCH stable 4.19 v2 0/2] arm64: entry: Place an SB sequence following an ERET instruction

2020-09-08 Thread Florian Fainelli
On 8/24/2020 11:35 AM, Florian Fainelli wrote: Changes in v2: - included missing preliminary patch to define the SB barrier instruction Will Deacon (2): arm64: Add support for SB barrier and patch in over DSB; ISB sequences arm64: entry: Place an SB sequence following an ERET

Re: [RFC V2 0/9] x86/mmu:Introduce parallel memory virtualization to boost performance

2020-09-08 Thread Wanpeng Li
Any comments? guys! On Tue, 1 Sep 2020 at 19:52, wrote: > > From: Yulei Zhang > > Currently in KVM memory virtulization we relay on mmu_lock to > synchronize the memory mapping update, which make vCPUs work > in serialize mode and slow down the execution, especially after > migration to do

Re: [PATCH] fib: fix fib_rule_ops indirect call wrappers when CONFIG_IPV6=m

2020-09-08 Thread David Miller
From: Brian Vazquez Date: Tue, 8 Sep 2020 09:18:12 -0700 > If CONFIG_IPV6=m, the IPV6 functions won't be found by the linker: > > ld: net/core/fib_rules.o: in function `fib_rules_lookup': > fib_rules.c:(.text+0x606): undefined reference to `fib6_rule_match' > ld: fib_rules.c:(.text+0x611):

Re: [v1,1/3] dt-bindings: Add YAML schemas for Gen3 PCIe controller

2020-09-08 Thread Jianjun Wang
On Tue, 2020-09-08 at 13:50 -0600, Rob Herring wrote: > On Mon, 07 Sep 2020 20:08:50 +0800, Jianjun Wang wrote: > > Add YAML schemas documentation for Gen3 PCIe controller on > > MediaTek SoCs. > > > > Acked-by: Ryder Lee > > Signed-off-by: Jianjun Wang > > --- > >

Re: [PATCH v2 2/3] soc: sifive: Add SiFive specific Cadence DDR controller driver

2020-09-08 Thread Palmer Dabbelt
On Sun, 06 Sep 2020 23:11:26 PDT (-0700), Christoph Hellwig wrote: On Mon, Sep 07, 2020 at 11:17:58AM +0530, Yash Shah wrote: Add a driver to manage the Cadence DDR controller present on SiFive SoCs At present the driver manages the EDAC feature of the DDR controller. Additional features may be

Re: [PATCH net-next] rcu: prevent RCU_LOCKDEP_WARN() from swallowing the condition

2020-09-08 Thread David Miller
From: Jakub Kicinski Date: Tue, 8 Sep 2020 10:36:24 -0700 > We run into a unused variable warning in bridge code when > variable is only used inside the condition of > rcu_dereference_protected(). > > #define mlock_dereference(X, br) \ > rcu_dereference_protected(X,

Re: [ANNOUNCE] v5.9-rc3-rt3

2020-09-08 Thread Mike Galbraith
On Wed, 2020-09-02 at 17:55 +0200, Sebastian Andrzej Siewior wrote: > > Known issues > - It has been pointed out that due to changes to the printk code the >internal buffer representation changed. This is only an issue if tools >like `crash' are used to extract the printk

[RESEND PATCH 1/1] block: Set same_page to false in __bio_try_merge_page if ret is false

2020-09-08 Thread Ritesh Harjani
If we hit the UINT_MAX limit of bio->bi_iter.bi_size and so we are anyway not merging this page in this bio, then it make sense to make same_page also as false before returning. Without this patch, we hit below WARNING in iomap. This mostly happens with very large memory system and / or after

Re: [PATCH 4.19 41/88] net: ethernet: mlx4: Fix memory allocation in mlx4_buddy_init()

2020-09-08 Thread Shung-Hsi Yu
On Tue, Sep 08, 2020 at 09:53:11PM +0200, Pavel Machek wrote: > Hi! > > > On machines with much memory (> 2 TByte) and log_mtts_per_seg == 0, a > > max_order of 31 will be passed to mlx_buddy_init(), which results in > > s = BITS_TO_LONGS(1 << 31) becoming a negative value, leading to > >

Re: [v1,1/3] dt-bindings: Add YAML schemas for Gen3 PCIe controller

2020-09-08 Thread Jianjun Wang
On Tue, 2020-09-08 at 15:04 -0500, Bjorn Helgaas wrote: > On Mon, Sep 07, 2020 at 08:08:50PM +0800, Jianjun Wang wrote: > > Add YAML schemas documentation for Gen3 PCIe controller on > > MediaTek SoCs. > > Please mention "mediatek" in the subject line so "git log --oneline" > is more useful. > >

Re: [PATCH] hippi: switch from 'pci_' to 'dma_' API

2020-09-08 Thread David Miller
From: Christophe JAILLET Date: Tue, 8 Sep 2020 22:08:39 +0200 > The wrappers in include/linux/pci-dma-compat.h should go away. > > The patch has been generated with the coccinelle script below and has been > hand modified to replace GFP_ with a correct flag. > It has been compile tested. > >

Re: [PATCH] net: tc35815: switch from 'pci_' to 'dma_' API

2020-09-08 Thread David Miller
From: Christophe JAILLET Date: Tue, 8 Sep 2020 22:27:47 +0200 > The wrappers in include/linux/pci-dma-compat.h should go away. > > The patch has been generated with the coccinelle script below and has been > hand modified to replace GFP_ with a correct flag. > It has been compile tested. > >

Re: [PATCH net-next 0/3] rxrpc: Allow more calls to same peer

2020-09-08 Thread David Miller
t; accounted separately. > > The patches are tagged here: > > git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git > rxrpc-next-20200908 Pulled, thanks David.

Re: [f2fs-dev] [PATCH] f2fs: clean up vm_map_ram() call

2020-09-08 Thread Chao Yu
On 2020/9/9 10:36, Daeho Jeong wrote: From: Daeho Jeong Made f2fs_vmap() wrapper to handle vm_map_ram() stuff. Signed-off-by: Daeho Jeong LGTM, I think it should be merged into original patch. :) Maybe Jaeguek could help to do that. Thanks, --- fs/f2fs/compress.c | 42

Re: [RFC] dt-bindings: mailbox: add doorbell support to ARM MHU

2020-09-08 Thread Jassi Brar
On Tue, Sep 8, 2020 at 4:15 AM Arnd Bergmann wrote: > > Picking up the old thread again after and getting pinged by multiple > colleagues about it (thanks!) reading through the history. > > On Fri, Jun 12, 2020 at 7:29 AM Viresh Kumar wrote: > > > > On 11-06-20, 19:34, Jassi Brar wrote: > > > In

Re: [f2fs-dev] [PATCH] f2fs: clean up vm_map_ram() call

2020-09-08 Thread Jaegeuk Kim
On 09/09, Chao Yu wrote: > On 2020/9/9 10:36, Daeho Jeong wrote: > > From: Daeho Jeong > > > > Made f2fs_vmap() wrapper to handle vm_map_ram() stuff. > > > > Signed-off-by: Daeho Jeong > > LGTM, > > I think it should be merged into original patch. :) > > Maybe Jaeguek could help to do that.

Re: [PATCH net-next 1/5] net: ipa: use atomic exchange for suspend reference

2020-09-08 Thread David Miller
From: Alex Elder Date: Tue, 8 Sep 2020 19:21:23 -0500 > We take a single IPA clock reference to keep the clock running > until we get a system suspend operation. When a system suspend > request arrives, we drop that reference, and if that's the last > reference (likely) we'll proceed with

Re: [RESEND PATCH 1/1] block: Set same_page to false in __bio_try_merge_page if ret is false

2020-09-08 Thread Ming Lei
On Wed, Sep 9, 2020 at 11:16 AM Ritesh Harjani wrote: > > If we hit the UINT_MAX limit of bio->bi_iter.bi_size and so we are anyway > not merging this page in this bio, then it make sense to make same_page > also as false before returning. > > Without this patch, we hit below WARNING in iomap. >

Re: [v1,1/3] dt-bindings: Add YAML schemas for Gen3 PCIe controller

2020-09-08 Thread Jianjun Wang
On Tue, 2020-09-08 at 14:21 -0600, Rob Herring wrote: > On Mon, Sep 07, 2020 at 08:08:50PM +0800, Jianjun Wang wrote: > > Add YAML schemas documentation for Gen3 PCIe controller on > > MediaTek SoCs. > > dt-bindings: PCI: mediatek: ... for the subject. > > > > > Acked-by: Ryder Lee > >

Re: Question: Why is there no notification when a file is opened using filp_open()?

2020-09-08 Thread Amir Goldstein
On Tue, Sep 8, 2020 at 8:19 PM Matthew Wilcox wrote: > > On Tue, Sep 08, 2020 at 04:18:29PM +0300, Amir Goldstein wrote: > > On Tue, Sep 8, 2020 at 3:53 PM Xiaoming Ni wrote: > > > For example, in fs/coredump.c, do_coredump() calls filp_open() to > > > generate core files. > > > In this

RE: [PATCH v2 2/3] soc: sifive: Add SiFive specific Cadence DDR controller driver

2020-09-08 Thread Yash Shah
> -Original Message- > From: Palmer Dabbelt > Sent: 09 September 2020 08:42 > To: Christoph Hellwig ; dkang...@cadence.com > Cc: Yash Shah ; robh...@kernel.org; Paul > Walmsley ( Sifive) ; b...@alien8.de; > mche...@kernel.org; tony.l...@intel.com; devicet...@vger.kernel.org; >

[PATCH] usb: ohci: Default to per-port over-current protection

2020-09-08 Thread Hamish Martin
Some integrated OHCI controller hubs do not expose all ports of the hub to pins on the SoC. In some cases the unconnected ports generate spurious over-current events. For example the Broadcom 56060/Ranger 2 SoC contains a nominally 3 port hub but only the first port is wired. Default behaviour

Re: [RFC PATCH 00/16] 1GB THP support on x86_64

2020-09-08 Thread John Hubbard
On 9/8/20 12:58 PM, Roman Gushchin wrote: On Tue, Sep 08, 2020 at 11:09:25AM -0400, Zi Yan wrote: On 7 Sep 2020, at 3:20, Michal Hocko wrote: On Fri 04-09-20 14:10:45, Roman Gushchin wrote: On Fri, Sep 04, 2020 at 09:42:07AM +0200, Michal Hocko wrote: [...] Something like

[PATCH] platform/chrome: cros_ec_debugfs: Support pd_info v2 format

2020-09-08 Thread Stephen Boyd
Let's try to read more information out of more modern cros_ec devices by using the v2 format first and then fall back to the v1 format. This gives us more information about things such as DP mode of the typec pins and the CC state, along with some more things. Cc: Gwendal Grignou Cc: Prashant

Re: [Nouveau] [PATCH] drm/nouveau: Add fine-grain temperature reporting

2020-09-08 Thread Ben Skeggs
On Thu, 13 Aug 2020 at 06:50, Jeremy Cline wrote: > > Commit d32656373857 ("drm/nouveau/therm/gp100: initial implementation of > new gp1xx temperature sensor") added support for reading finer-grain > temperatures, but continued to report temperatures in 1 degree Celsius > increments via

[PATCH net 1/2] hv_netvsc: Switch the data path at the right time during hibernation

2020-09-08 Thread Dexuan Cui
When netvsc_resume() is called, the mlx5 VF NIC has not been resumed yet, so in the future the host might sliently fail the call netvsc_vf_changed() -> netvsc_switch_datapath() there, even if the call works now. Call netvsc_vf_changed() in the NETDEV_CHANGE event handler: at that time the mlx5 VF

[PATCH net 2/2] hv_netvsc: Cache the current data path to avoid duplicate call and message

2020-09-08 Thread Dexuan Cui
The previous change "hv_netvsc: Switch the data path at the right time during hibernation" adds the call of netvsc_vf_changed() upon NETDEV_CHANGE, so it's necessary to avoid the duplicate call and message when the VF is brought UP or DOWN. Signed-off-by: Dexuan Cui ---

Re: [PATCH 0/2] scsi: lpfc: Reduce logging object code size

2020-09-08 Thread Joe Perches
On Mon, 2020-08-10 at 15:59 -0700, Joe Perches wrote: > The logging macros are pretty heavyweight and can be consolidated > to reduce overall object size. > > Joe Perches (2): > scsi: lpfc: Neaten logging macro #defines > scsi: lpfc: Add logging functions to reduce object size > >

Re: [External] Re: [PATCH] mm/vmscan: fix infinite loop in drop_slab_node

2020-09-08 Thread Muchun Song
Hi Chris, On Tue, Sep 8, 2020 at 11:09 PM Chris Down wrote: > > drop_caches by its very nature can be extremely performance intensive -- if > someone wants to abort after trying too long, they can just send a > TASK_KILLABLE signal, no? If exiting the loop and returning to usermode > doesn't >

WARNING: suspicious RCU usage: include/trace/events/tlb.h:57 suspicious rcu_dereference_check() usage!

2020-09-08 Thread Naresh Kamboju
While booting i386 with Linux next 20200908 tag kernel this warning noticed. metadata: git branch: master git repo: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git git commit: dff9f829e5b0181d4ed9d35aa62d695292399b54 git describe: next-20200908 kernel-config: http

Re: [PATCH v2] kbuild: preprocess module linker script

2020-09-08 Thread Palmer Dabbelt
On Mon, 07 Sep 2020 21:27:08 PDT (-0700), masahi...@kernel.org wrote: There was a request to preprocess the module linker script like we do for the vmlinux one. (https://lkml.org/lkml/2020/8/21/512) The difference between vmlinux.lds and module.lds is that the latter is needed for external

[PATCH net-next] net: dsa: b53: Report VLAN table occupancy via devlink

2020-09-08 Thread Florian Fainelli
We already maintain an array of VLANs used by the switch so we can simply iterate over it to report the occupancy via devlink. Signed-off-by: Florian Fainelli --- drivers/net/dsa/b53/b53_common.c | 59 ++-- drivers/net/dsa/b53/b53_priv.h | 1 +

Re: [PATCH 5/7] cpufreq: qcom-hw: Use regmap for accessing hardware registers

2020-09-08 Thread Viresh Kumar
On 08-09-20, 17:38, Amit Kucheria wrote: > On Tue, Sep 8, 2020 at 5:18 PM Amit Kucheria wrote: > > > > On Tue, Sep 8, 2020 at 4:48 PM Viresh Kumar wrote: > > > > > > On 08-09-20, 16:41, Manivannan Sadhasivam wrote: > > > > On 0908, Viresh Kumar wrote: > > > > > On 08-09-20, 13:27, Manivannan

WARNING: suspicious RCU usage: race/events/tlb.h:57 suspicious rcu_dereference_check() usage!

2020-09-08 Thread Naresh Kamboju
While booting x86_64 with Linux next 20200908 tag kernel this warning was noticed. metadata: git branch: master git repo: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git git commit: dff9f829e5b0181d4ed9d35aa62d695292399b54 git describe: next-20200908 kernel-config

Question about STEP_DECOMPRESS_NOWQ

2020-09-08 Thread Daeho Jeong
Hi Chao, I have a question about the below flag for decompression. STEP_DECOMPRESS_NOWQ, /* handle normal cluster data inplace */ According to the comment, you added this for using inplace decompression but inplace decompression mode is not being activated now, since we are setting

Re: [RFC] dt-bindings: mailbox: add doorbell support to ARM MHU

2020-09-08 Thread Viresh Kumar
On 08-09-20, 22:23, Jassi Brar wrote: > From the test case Sudeep last shared, the scmi usage on mhu doesn't > not even hit any bottleneck ... the test "failed" because of the too > small hardcoded timeout value. Otherwise the current code actually > shows better numbers. Its not important on why

Re: KASAN: use-after-free Read in delete_partition

2020-09-08 Thread Harley
I am having difficulty actually reproducing the bug from the supplied C repro and .config. Perhaps it is some sort of race condition?

[PATCH V2 0/2] arm64/mm: Enable THP migration

2020-09-08 Thread Anshuman Khandual
This series enables THP migration on arm64 via ARCH_ENABLE_THP_MIGRATION. But first this modifies all existing THP helpers like pmd_present() and pmd_trans_huge() etc per expected generic memory semantics as concluded from a previous discussion here. https://lkml.org/lkml/2018/10/9/220 This

[PATCH V2 2/2] arm64/mm: Enable THP migration

2020-09-08 Thread Anshuman Khandual
In certain page migration situations, a THP page can be migrated without being split into it's constituent subpages. This saves time required to split a THP and put it back together when required. But it also saves an wider address range translation covered by a single TLB entry, reducing future

[PATCH V2 1/2] arm64/mm: Change THP helpers to comply with generic MM semantics

2020-09-08 Thread Anshuman Khandual
pmd_present() and pmd_trans_huge() are expected to behave in the following manner during various phases of a given PMD. It is derived from a previous detailed discussion on this topic [1] and present THP documentation [2]. pmd_present(pmd): - Returns true if pmd refers to system RAM with a valid

kernel BUG at /usr/src/kernel/lib/dynamic_debug.c:267!

2020-09-08 Thread Naresh Kamboju
While testing livepatch test cases on x86_64 with Linux next 20200908 tag kernel this kernel BUG noticed several times. metadata: git branch: master git repo: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git git commit: dff9f829e5b0181d4ed9d35aa62d695292399b54 git

Re: [PATCH 5/8] riscv: use memcpy based uaccess for nommu again

2020-09-08 Thread Palmer Dabbelt
On Sun, 06 Sep 2020 22:58:22 PDT (-0700), Christoph Hellwig wrote: This reverts commit adccfb1a805ea84d2db38eb53032533279bdaa97. Now that the generic uaccess by mempcy code handles unaligned addresses the generic code can be used for all RISC-V CPUs. Signed-off-by: Christoph Hellwig ---

Re: remove set_fs for riscv v2

2020-09-08 Thread Palmer Dabbelt
On Sun, 06 Sep 2020 22:58:17 PDT (-0700), Christoph Hellwig wrote: Hi all, this series converts riscv to the new set_fs less world and is on top of this branch: https://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git/log/?h=base.set_fs The first four patches are general improvements

Re: [PATCH 8/8] riscv: remove address space overrides using set_fs()

2020-09-08 Thread Palmer Dabbelt
On Sun, 06 Sep 2020 22:58:25 PDT (-0700), Christoph Hellwig wrote: Stop providing the possibility to override the address space using set_fs() now that there is no need for that any more. Signed-off-by: Christoph Hellwig --- arch/riscv/Kconfig | 1 -

Re: [PATCH 7/8] riscv: implement __get_kernel_nofault and __put_user_nofault

2020-09-08 Thread Palmer Dabbelt
On Sun, 06 Sep 2020 22:58:24 PDT (-0700), Christoph Hellwig wrote: Implement the non-faulting kernel access helpers directly instead of abusing the uaccess routines under set_fs(KERNEL_DS). Signed-off-by: Christoph Hellwig --- arch/riscv/include/asm/uaccess.h | 20 1 file

Re: [PATCH 6/8] riscv: refactor __get_user and __put_user

2020-09-08 Thread Palmer Dabbelt
On Sun, 06 Sep 2020 22:58:23 PDT (-0700), Christoph Hellwig wrote: Add new __get_user_nocheck and __put_user_nocheck that switch on the size and call the actual inline assembly helpers, and move the uaccess enable / disable into the actual __get_user and __put_user. This prepares for natively

Re: [PATCH v2 1/2] scsi: ufs: Abort tasks before clear them from doorbell

2020-09-08 Thread James Bottomley
I can't reconcile this hunk: On Wed, 2020-09-02 at 19:24 -0700, Can Guo wrote: > @@ -6504,6 +6505,80 @@ static void ufshcd_set_req_abort_skip(struct > ufs_hba *hba, unsigned long bitmap) > * issued. To avoid that, first issue UFS_QUERY_TASK to check if the > command is > * really issued and

Re: [ANNOUNCE] v5.9-rc3-rt3

2020-09-08 Thread Mike Galbraith
On Wed, 2020-09-09 at 05:12 +0200, Mike Galbraith wrote: > On Wed, 2020-09-02 at 17:55 +0200, Sebastian Andrzej Siewior wrote: > > > > Known issues > > - It has been pointed out that due to changes to the printk code the > >internal buffer representation changed. This is only an issue

[PATCH v3 0/2] use SPDX also for GFDL documents

2020-09-08 Thread Mauro Carvalho Chehab
There are 438 document files that were licensed under the free versions of GNU Free Document License. The free versions are the one that doesn't contain invariant parts. The first patch adds the license files. As newer documents aren't supposed to use them without being dual-licensed with

[PATCH v3 2/2] docs: trace: ring-buffer-design.rst: use the new SPDX tag

2020-09-08 Thread Mauro Carvalho Chehab
SPDX v3.10 gained support for GFDL-1.2 with no invariant sections: https://spdx.org/licenses/GFDL-1.2-no-invariants-only.html Let's use it, instead of keeping a license text for this file. Signed-off-by: Mauro Carvalho Chehab --- Documentation/trace/ring-buffer-design.rst | 26

<    5   6   7   8   9   10   11   12   13   14   >