[PATCH] sound/usb generate midi streaming substream names from jack names

2021-02-21 Thread George Harker
A number of devices have named substreams which are hard to remember / decypher from MIDI n names. Eg. Korg puts a pass through on one substream and iConnectivity devices name the connections. This makes it easier to connect to the correct device. Devices which handle naming through quirks are

[PATCH 1/2] kconfig: clean up nested if-conditionals in check_conf()

2021-02-21 Thread Masahiro Yamada
Unify the outer two if-conditionals into one. This decreases the indent level by one. Also, change the if-else blocks: if (input_mode == listnewconfig) { ... } else if (input_mode == helpnewconfig) { ... } else { ... } into the switch

[PATCH 2/2] kconfig: remove dead code in conf_askvalue()

2021-02-21 Thread Masahiro Yamada
conf_askvalue() is only called for oldconfig, syncconfig, and oldaskconfig. If it is called for other cases, it is a bug. So, the code after the switch statement is unreachable. Remove the dead code, and clean up the switch statement. Signed-off-by: Masahiro Yamada --- scripts/kconfig/conf.c

[PATCH] sound/usb generate midi streaming substream names from jack names

2021-02-21 Thread George Harker
A number of devices have named substreams which are hard to remember / decypher from MIDI n names. Eg. Korg puts a pass through on one substream and iConnectivity devices name the connections. This makes it easier to connect to the correct device. Devices which handle naming through quirks are

Re: [PATCH v2 3/3] security: Add LSMs dependencies to CONFIG_LSM

2021-02-21 Thread Mickaël Salaün
On 21/02/2021 09:50, Masahiro Yamada wrote: > On Tue, Feb 16, 2021 at 4:03 AM Ondrej Mosnacek wrote: >> >> On Mon, Feb 15, 2021 at 7:17 PM Mickaël Salaün wrote: >>> From: Mickaël Salaün >>> >>> Thanks to the previous commit, this gives the opportunity to users, when >>> running make

Re: [PATCH v2 2/3] kconfig: Ask user if string needs to be changed when dependency changed

2021-02-21 Thread Mickaël Salaün
On 21/02/2021 09:47, Masahiro Yamada wrote: > On Tue, Feb 16, 2021 at 3:14 AM Mickaël Salaün wrote: >> >> From: Mickaël Salaün >> >> Content of string configuration may depend on related kernel >> configurations. Modify oldconfig and syncconfig to inform users about >> possible required

Re: [PATCH v2 2/4] leds: Add driver for QCOM SPMI Flash LEDs

2021-02-21 Thread Jacek Anaszewski
On 2/19/21 12:02 PM, Pavel Machek wrote: Hi! + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include Please sort includes alphabetically. No need to do that. Keeping the includes

Re: [PATCH] virtio-mmio: Use to_virtio_mmio_device() to simply code

2021-02-21 Thread Michael S. Tsirkin
On Thu, Feb 18, 2021 at 09:34:08AM +0800, Tang Bin wrote: > Dear Jason: > >   Sorry for the late reply this email. > > 在 2021/2/10 16:09, Jason Wang 写道: > > > > On 2021/2/10 上午11:04, Tang Bin wrote: > > > The file virtio_mmio.c has defined the function to_virtio_mmio_device, > > > so use it

Re: [PATCH] staging: wimax/i2400m: fix byte-order type issue

2021-02-21 Thread Greg Kroah-Hartman
On Sat, Feb 20, 2021 at 06:22:31PM +0530, karthik alapati wrote: > fix sparse type warning by converting le32 types to > host byte-order types before comparison > > Signed-off-by: karthik alapati > --- > drivers/staging/wimax/i2400m/fw.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >

Re: 5.10 LTS Kernel: 2 or 6 years?

2021-02-21 Thread Jari Ruusu
On Saturday, February 20, 2021 6:05 PM, Greg Kroah-Hartman wrote: > On Sat, Feb 20, 2021 at 01:29:21PM +, Jari Ruusu wrote: > > I have been able to narrow the beginning of the problem to these kernels: > > 4.14.188 ... 4.14.202 > > Same "fix" that went info 4.14.y is also bugging 4.19.y

Re: NFS Caching broken in 4.19.37

2021-02-21 Thread Anton Ivanov
On 21/02/2021 09:13, Salvatore Bonaccorso wrote: Hi, On Sat, Feb 20, 2021 at 08:16:26PM +, Chuck Lever wrote: On Feb 20, 2021, at 3:13 PM, Anton Ivanov wrote: On 20/02/2021 20:04, Salvatore Bonaccorso wrote: Hi, On Mon, Jul 08, 2019 at 07:19:54PM +0100, Anton Ivanov wrote: Hi

Re: [PATCH] staging: hikey9xx: Fix space tab style warnings

2021-02-21 Thread Greg KH
On Fri, Feb 19, 2021 at 02:38:51PM +, Lee Gibson wrote: > This patch fixes the checkpatch warnings such as: > > hi6421-spmi-pmic.c:51: WARNING: please, no space before tabs > > Signed-off-by: Lee Gibson > --- > drivers/staging/hikey9xx/hi6421-spmi-pmic.c | 8 > 1 file changed, 4

Re: [PATCH v3 01/02] staging: kpc2000: code style: fix alignment issues

2021-02-21 Thread Greg KH
On Fri, Feb 19, 2021 at 07:34:11PM +0300, Nikolay Kyx wrote: > This patch fixes the following checkpatch.pl check: > > CHECK: Alignment should match open parenthesis > > in files kpc2000_i2c.c kpc2000_spi.c > > Signed-off-by: Nikolay Kyx > --- > > Additionally some style warnings remain valid

[PATCH 2/3] kconfig: omit --oldaskconfig option for 'make config'

2021-02-21 Thread Masahiro Yamada
scripts/kconfig/conf.c line 39 defines the default of input_mode as oldaskconfig. Hence, 'make config' works in the same way even without the --oldaskconfig option given. Note this in the help message. This will be helpful to unify build rules in Makefile in the next commit. Signed-off-by:

[PATCH 3/3] kconfig: unify rule of config, menuconfig, nconfig, gconfig, xconfig

2021-02-21 Thread Masahiro Yamada
Unify the similar build rules. This supports 'make build_config', which builds scripts/kconfig/conf but does not invoke it. Signed-off-by: Masahiro Yamada --- scripts/kconfig/Makefile | 35 +-- 1 file changed, 13 insertions(+), 22 deletions(-) diff --git

[PATCH 1/3] kconfig: fix 'invalid option' for help option

2021-02-21 Thread Masahiro Yamada
scripts/kconfig/conf supports -? option to show the help message. This is not wired up to Makefile, so nobody would notice this, but it also shows 'invalid option' message. $ ./scripts/kconfig/conf -? ./scripts/kconfig/conf: invalid option -- '?' Usage: ./scripts/kconfig/conf [-s] [option]

Re: [PATCH v2 1/4] drivers: phy: add support for Armada CP110 UTMI PHY

2021-02-21 Thread kernel test robot
/linux/kernel/git/robh/linux.git for-next config: parisc-randconfig-r034-20210221 (attached as .config) compiler: hppa-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x

Re: [PATCH v2 1/1] riscv/kasan: add KASAN_VMALLOC support

2021-02-21 Thread Alex Ghiti
Le 2/13/21 à 5:52 AM, Alex Ghiti a écrit : Hi Nylon, Palmer, Le 2/8/21 à 1:28 AM, Alex Ghiti a écrit : Hi Nylon, Le 1/22/21 à 10:56 PM, Palmer Dabbelt a écrit : On Fri, 15 Jan 2021 21:58:35 PST (-0800), nyl...@andestech.com wrote: It references to x86/s390 architecture. >> So, it doesn't

Re: [PATCH v8 10/22] counter: Standardize to ERANGE for limit exceeded errors

2021-02-21 Thread Jonathan Cameron
On Tue, 16 Feb 2021 10:26:52 +0900 William Breathitt Gray wrote: > On Sun, Feb 14, 2021 at 05:10:21PM +, Jonathan Cameron wrote: > > On Fri, 12 Feb 2021 21:13:34 +0900 > > William Breathitt Gray wrote: > > > > > ERANGE is a semantically better error code to return when an argument > > >

[PATCH 1/3] staging: wimax/i2400m: fix byte-order issue

2021-02-21 Thread karthik alapati
fix sparse byte-order warnings by converting host byte-order type to __le16 byte-order types before assigning to hdr.length Signed-off-by: karthik alapati --- drivers/staging/wimax/i2400m/op-rfkill.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 0/3] fix sparse warnings

2021-02-21 Thread karthik alapati
the following patches fixes two byte-order issues and a Makefile issue and fixes these sparse warnings drivers/staging//wimax/i2400m/op-rfkill.c:89:25: warning: incorrect type in assignment (different base types) drivers/staging//wimax/i2400m/op-rfkill.c:89:25:expected restricted __le16

[PATCH 2/3] staging: wimax/i2400m: convert __le32 type to host byte-order

2021-02-21 Thread karthik alapati
fix sparse type warning by converting __le32 types to host byte-order types before comparison Signed-off-by: karthik alapati --- drivers/staging/wimax/i2400m/fw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wimax/i2400m/fw.c

Re: [PATCH v2 25/25] arm64: apple: Add initial Mac Mini 2020 (M1) devicetree

2021-02-21 Thread Hector Martin
On 16/02/2021 04.29, Krzysztof Kozlowski wrote: On Mon, Feb 15, 2021 at 09:17:13PM +0900, Hector Martin wrote: + memory@8 { + device_type = "memory"; + reg = <0 0 0 0>; /* To be filled by loader */ dtc and dtschema might complain, so could you set

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

2021-02-21 Thread Eli Cohen
On Fri, Feb 19, 2021 at 06:54:58AM -0500, Si-Wei Liu wrote: > Commit 452639a64ad8 ("vdpa: make sure set_features is invoked > for legacy") made an exception for legacy guests to reset > features to 0, when config space is accessed before features > are set. We should relieve the

Re: [PATCH 2/2] dt-bindings: vcnl3020: add proximity rate in hz

2021-02-21 Thread Jonathan Cameron
On Tue, 16 Feb 2021 17:53:46 +0300 Ivan Mikhaylov wrote: > Describe the possible proximity values in herzes for vcnl3020. Hertz Why does this belong in DT? DT bindings should reflect physical characteristics of the device, so how is wired up, whether there are plastic windows over it that

Re: [PATCH v2 25/25] arm64: apple: Add initial Mac Mini 2020 (M1) devicetree

2021-02-21 Thread Krzysztof Kozlowski
On Sun, Feb 21, 2021 at 11:43:52PM +0900, Hector Martin wrote: > On 16/02/2021 04.29, Krzysztof Kozlowski wrote: > > On Mon, Feb 15, 2021 at 09:17:13PM +0900, Hector Martin wrote: > > > + memory@8 { > > > + device_type = "memory"; > > > + reg = <0 0 0 0>; /* To be filled by

[PATCH] staging: media/atomisp: don't compile unused code

2021-02-21 Thread karthik alapati
currently the functions defined in ibuf_ctrl_rmgr.c file are only used by isys_init.c when CONFIG_VIDEO_ATOMISP_ISP2401 is selected so dont't compile it when not needed, also fixes some sparse warnings Signed-off-by: karthik alapati --- drivers/staging/media/atomisp/Makefile | 5 +++-- 1 file

[PATCH] staging/greybus: eliminate use of NAME_SIZE for strings

2021-02-21 Thread Kumar Kartikeya Dwivedi
Instead, depend on the size of the destination buffer for easier refactoring. Signed-off-by: Kumar Kartikeya Dwivedi --- Hopefully, this is more thorough. The only cases left now are where the destination string is represented by a pointer, otherwise all call sites with a fixed sized buffer have

Re: [RFC 15/19] arm64: dts: imx8mq: Add all pl301 nodes

2021-02-21 Thread Krzysztof Kozlowski
On Fri, 19 Feb 2021 at 17:04, Abel Vesa wrote: > > Add all the pl301s found on i.MX8MQ, according to the bus diagram. > Each pl301 has its own clock, icc id and opp table. They are probed > by the imx-bus driver. > > Signed-off-by: Abel Vesa > --- > arch/arm64/boot/dts/freescale/imx8mq.dtsi |

[PATCH v1 1/6] arm64: dts: librem5-devkit: Use a less generic codec name

2021-02-21 Thread Guido Günther
The codec is currently named after the chip but it should be named like the device itself since otherwise it's impossible to distinguish it from other devices using the same codec (e.g. in alsa's UCM). Signed-off-by: Guido Günther --- arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts | 2

[PATCH v1 2/6] arm64: dts: librem5-devkit: Add speaker amplifier

2021-02-21 Thread Guido Günther
Wire up the amplifier that drives the builtin speaker. Signed-off-by: Guido Günther --- .../dts/freescale/imx8mq-librem5-devkit.dts | 21 +-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts

[PATCH v1 0/6] arm64: dts: librem5-devkit: Improve audio support

2021-02-21 Thread Guido Günther
So far only headphone output worked. Thesse patches add support for the built in speaker and mic, allow a headset microphone to work and wire up jack detection so audio output can switch to headphones automatically. They also adjust the card name to match the board not the codec, similar what's

[PATCH v1 6/6] arm64: dts: librem5-devkit: Move headphone detection to sound card

2021-02-21 Thread Guido Günther
This allows for automatic output source switching in userspace. Enable the pullup on the GPIO to actually make it trigger and mark it as active-high since detection is reversed otherwise. Signed-off-by: Guido Günther --- .../dts/freescale/imx8mq-librem5-devkit.dts | 21 ++- 1

[PATCH v1 5/6] arm64: dts: librem5-devkit: Add mux for built-in vs headset mic

2021-02-21 Thread Guido Günther
Add mux so we can select either headset or built-in microphone input. Signed-off-by: Guido Günther --- .../dts/freescale/imx8mq-librem5-devkit.dts | 25 --- 1 file changed, 21 insertions(+), 4 deletions(-) diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts

[PATCH v1 3/6] arm64: dts: librem5-devkit: "Drop Line In Jack"

2021-02-21 Thread Guido Günther
The SGTL500s LINEINL and LINEINR are N/C. Signed-off-by: Guido Günther --- arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts

[PATCH v1 4/6] arm64: defconfig: Enable asoc simple mux

2021-02-21 Thread Guido Günther
This is needed to model the mic input mux on the Librem 5 devkit. Signed-off-by: Guido Günther --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index e830d1be6f27..762fb6a132df 100644 ---

[PATCH] virtio: remove export for virtio_config_{enable, disable}

2021-02-21 Thread Xianting Tian
virtio_config_enable(), virtio_config_disable() are only used inside drivers/virtio/virtio.c, so it doesn't need export the symbols. Signed-off-by: Xianting Tian --- drivers/virtio/virtio.c | 6 ++ include/linux/virtio.h | 2 -- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git

Re: [PATCH 01/20] net: phy: realtek: Fix events detection failure in LPI mode

2021-02-21 Thread Serge Semin
On Sat, Feb 20, 2021 at 04:49:22PM +0100, Andrew Lunn wrote: > > If in doubt, leaving the patch as is would be fine with me. > > The patch is O.K. as is, no need to export something so simple for a > single users. When the next user come along, we can reconsider. Ok. Thanks for clarification. I

Re: [PATCH v6 1/1] iio/scmi: Adding support for IIO SCMI Based Sensors

2021-02-21 Thread Jonathan Cameron
On Fri, 12 Feb 2021 17:22:35 + Jyoti Bhayana wrote: > This change provides ARM SCMI Protocol based IIO device. > This driver provides support for Accelerometer and Gyroscope using > SCMI Sensor Protocol extensions added in the SCMIv3.0 ARM specification Hi Joyti A few things inline but

Re: [PATCH v2 3/3] security: Add LSMs dependencies to CONFIG_LSM

2021-02-21 Thread Masahiro Yamada
On Sun, Feb 21, 2021 at 8:11 PM Mickaël Salaün wrote: > > > On 21/02/2021 09:50, Masahiro Yamada wrote: > > On Tue, Feb 16, 2021 at 4:03 AM Ondrej Mosnacek wrote: > >> > >> On Mon, Feb 15, 2021 at 7:17 PM Mickaël Salaün wrote: > >>> From: Mickaël Salaün > >>> > >>> Thanks to the previous

Re: [PATCH v2 20/25] tty: serial: samsung_tty: Use devm_ioremap_resource

2021-02-21 Thread Marc Zyngier
On Sun, 21 Feb 2021 14:38:16 +, Hector Martin wrote: > > On 21/02/2021 04.17, Marc Zyngier wrote: > > On 2021-02-20 19:13, Krzysztof Kozlowski wrote: > >> On Thu, Feb 18, 2021 at 11:01:21PM +0900, Hector Martin wrote: > >>> On 16/02/2021 03.51, Krzysztof Kozlowski wrote: > > Also fix a

Re: [PATCH v6 2/2] counter: add IRQ or GPIO based event counter

2021-02-21 Thread Jonathan Cameron
On Tue, 16 Feb 2021 09:13:56 +0100 Oleksij Rempel wrote: > Add simple IRQ or GPIO base event counter. This device is used to measure > rotation speed of some agricultural devices, so no high frequency on the > counter pin is expected. > > The maximal measurement frequency depends on the CPU and

[PATCH v3 0/8] Fork brute force attack mitigation

2021-02-21 Thread John Wood
Attacks against vulnerable userspace applications with the purpose to break ASLR or bypass canaries traditionally use some level of brute force with the help of the fork system call. This is possible since when creating a new process using fork its memory contents are the same as those of the

Re: [PATCH v6] tpm: fix reference counting for struct tpm_chip

2021-02-21 Thread Lino Sanfilippo
Hi, On 19.02.21 at 10:13, Jarkko Sakkinen wrote: >> +rc = cdev_device_add(>cdevs, >devs); >> +if (rc) { >> +dev_err(>devs, >> +"unable to cdev_device_add() %s, major %d, minor %d, >> err=%d\n", >> +dev_name(>devs),

Re: [PATCH 2/2] staging: media: ipu3: code style fix - missing a blank line after declarations

2021-02-21 Thread Nikolay K.
I can't find any change in struct imgu_fw_info layout after this patch. But warning is strange, because declarations don't actually end here. So I think this warning should be suppressed to reduce noise in checkpatch.pl output.

Re: [PATCH] usbnet: ipheth: fix connectivity with iOS 14

2021-02-21 Thread Sam Bingner
There seems to be a problem with this patch: Whenever the iPhone sends a packet to the tethered device that is 1500 bytes long, it gets the error "ipheth 1-1:4.2: ipheth_rcvbulk_callback: urb status: -79" on the connected device and stops passing traffic. I am able to bring it back up by

Re: [PATCH v6 0/5] Enable root to update the blacklist keyring

2021-02-21 Thread Mickaël Salaün
David, Eric, what is the status of this patch series? On 10/02/2021 13:04, Mickaël Salaün wrote: > This new patch series is a rebase on David Howells's keys-misc branch. > This mainly fixes UEFI DBX and the new Eric Snowberg's feature to import > asymmetric keys to the blacklist keyring. > I

arch/mips/loongson64/cop2-ex.c:97:29: error: 'struct thread_struct' has no member named 'fpu'

2021-02-21 Thread kernel test robot
: 10 months ago config: mips-randconfig-r005-20210221 (attached as .config) compiler: mips64el-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross

Re: [PATCH] net/qrtr: restrict length in qrtr_tun_write_iter()

2021-02-21 Thread Sabyrzhan Tasbolatov
> Do we really expect to accept huge lengths here ? Sorry for late response but I couldnt find any reference to the max length of incoming data for qrtr TUN interface. > qrtr_endpoint_post() will later attempt a netdev_alloc_skb() which will need > some extra space (for struct skb_shared_info)

[PATCH] perf annotate: improve --stdio mode

2021-02-21 Thread Martin Liška
The patch changes the output format in 2 ways: - line number is displayed for all source lines (matching TUI mode) - source locations for the hottest lines are printed at the line end in order to preserve layout Before: 0.00 : 405ef1: inc%r15 :tmpsd * (TD +

Re: [PATCH] staging: wimax: Fix block comment style issue in stack.c

2021-02-21 Thread Greg KH
On Sat, Feb 20, 2021 at 01:55:25AM +0530, Amrit Khera wrote: > This change fixes a checkpatch warning for "Block comments > use * on subsequent lines". > > Signed-off-by: Amrit Khera > --- > drivers/staging/wimax/stack.c | 11 ++- > 1 file changed, 6 insertions(+), 5 deletions(-) > >

Re: [PATCH v1] Staging: rtl8192e: fix kconfig dependency on CRYPTO

2021-02-21 Thread Greg KH
On Sat, Feb 20, 2021 at 12:22:43PM -0500, Julian Braha wrote: > >From fd949b204eeb6b685bbf5dc9a329c931fcf8b0da Mon Sep 17 00:00:00 2001 > From: Julian Braha > Date: Sat, 20 Feb 2021 12:07:30 -0500 > Subject: [PATCH] staging: rtl8192e: fix kconfig dependency on CRYPTO Why is this all in the body

Re: [PATCH v2] staging: wimax: i2400m: add space before open parenthesis

2021-02-21 Thread Greg KH
On Sat, Feb 20, 2021 at 05:46:52AM -0800, Rajesh Kumbhakar wrote: > netdev.c > > fixing style ERROR: space required before the open parenthesis '(' > > Signed-off-by: Rajesh Kumbhakar > --- > Changes in v2: > - Removed filename from commit message. filename is still in commit message :(

Re: [PATCH] virt: acrn: Use vfs_poll() instead of f_op->poll()

2021-02-21 Thread Shuo A Liu
On Sun 21.Feb'21 at 8:54:06 +0100, Greg Kroah-Hartman wrote: On Sun, Feb 21, 2021 at 09:50:42AM +0800, Liu, Shuo A wrote: On 2/20/2021 22:53, Yejune Deng wrote: > Use vfs_poll() is a more advanced function in acrn_irqfd_assign(). > as the same time, modify the definition of events. > >

[PATCH v4 02/02] staging: kpc2000: code style: fix line length issue

2021-02-21 Thread Nikolay Kyx
This patch fixes the following checkpatch.pl warning: WARNING: line length of 124 exceeds 100 columns in file kpc2000_i2c.c Signed-off-by: Nikolay Kyx --- Additionally some style warnings remain valid here and could be fixed by another patch. v2: Edited changelog, as suggested by Greg KH

Re: [PATCH v2 1/4] drivers: phy: add support for Armada CP110 UTMI PHY

2021-02-21 Thread kernel test robot
://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next config: riscv-randconfig-r021-20210221 (attached as .config) compiler: riscv32-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross

Re: [PATCH v6] tpm: fix reference counting for struct tpm_chip

2021-02-21 Thread Jarkko Sakkinen
On Sun, Feb 21, 2021 at 11:19:28AM +0100, Lino Sanfilippo wrote: > > Hi, > > On 19.02.21 at 10:13, Jarkko Sakkinen wrote: > > >> + rc = cdev_device_add(>cdevs, >devs); > >> + if (rc) { > >> + dev_err(>devs, > >> + "unable to cdev_device_add() %s, major %d, minor %d,

[PATCH RESEND v2 1/2] cpu/hotplug: Fix build error of using {add,remove}_cpu() with !CONFIG_SMP

2021-02-21 Thread shuo . a . liu
From: Shuo Liu 279dcf693ac7 ("virt: acrn: Introduce an interface for Service VM to control vCPU") introduced {add,remove}_cpu() usage and it hit below error with !CONFIG_SMP: ../drivers/virt/acrn/hsm.c: In function ‘remove_cpu_store’: ../drivers/virt/acrn/hsm.c:389:3: error: implicit

[PATCH RESEND v2 2/2] virt: acrn: Make remove_cpu sysfs invisible with !CONFIG_HOTPLUG_CPU

2021-02-21 Thread shuo . a . liu
From: Shuo Liu Without cpu hotplug support, vCPU cannot be removed from a Service VM. Don't expose remove_cpu sysfs when CONFIG_HOTPLUG_CPU disabled. Signed-off-by: Shuo Liu Acked-by: Randy Dunlap # build-tested Cc: Stephen Rothwell Cc: Thomas Gleixner Cc: Greg Kroah-Hartman Cc: Qais

Re: [PATCH v2 19/25] tty: serial: samsung_tty: IRQ rework

2021-02-21 Thread Hector Martin
On 21/02/2021 04.11, Krzysztof Kozlowski wrote: On Thu, Feb 18, 2021 at 10:53:10PM +0900, Hector Martin wrote: This should've gone in the next patch. A previous reviewer told me to put declarations at the top of the file, so I put it there and moved this one along with it, but I'll keep it to

Re: [PATCH] iommu/amd: Fix event counter availability check

2021-02-21 Thread Paul Menzel
Dear Alexander, Am 01.06.20 um 04:48 schrieb Paul Menzel: […] Am 31.05.20 um 09:22 schrieb Alexander Monakov: Adding Shuah Khan to Cc: I've noticed you've seen this issue on Ryzen 2400GE; can you have a look at the patch? Would be nice to know if it fixes the problem for you too. On

Re: [PATCH v8 19/22] counter: Implement extension*_name sysfs attributes

2021-02-21 Thread Jonathan Cameron
On Fri, 19 Feb 2021 17:51:37 +0900 William Breathitt Gray wrote: > On Sun, Feb 14, 2021 at 06:09:13PM +, Jonathan Cameron wrote: > > On Fri, 12 Feb 2021 21:13:43 +0900 > > William Breathitt Gray wrote: > > > > > The Generic Counter chrdev interface expects users to supply extension > > >

[PATCH 3/3] staging: media/atomisp: don't compile unused code

2021-02-21 Thread karthik alapati
currently the functions defined in ibuf_ctrl_rmgr.c file are only used by isys_init.c when CONFIG_VIDEO_ATOMISP_ISP2401 is selected so dont't compile it when not needed, also fixes some sparse warnings Signed-off-by: karthik alapati --- drivers/staging/media/atomisp/Makefile | 5 +++-- 1 file

[PATCH] riscv: Get rid of MAX_EARLY_MAPPING_SIZE

2021-02-21 Thread Alexandre Ghiti
At early boot stage, we have a whole PGDIR to map the kernel, so there is no need to restrict the early mapping size to 128MB. Removing this define also allows us to simplify some compile time logic. This fixes large kernel mappings with a size greater than 128MB, as it is the case for syzbot

[PATCH] net/mlx4_core: Add missed mlx4_free_cmd_mailbox()

2021-02-21 Thread Chuhong Yuan
mlx4_do_mirror_rule() forgets to call mlx4_free_cmd_mailbox() to free the memory region allocated by mlx4_alloc_cmd_mailbox() before an exit. Add the missed call to fix it. Fixes: 78efed275117 ("net/mlx4_core: Support mirroring VF DMFS rules on both ports") Signed-off-by: Chuhong Yuan ---

Re: [PATCH v2 20/25] tty: serial: samsung_tty: Use devm_ioremap_resource

2021-02-21 Thread Hector Martin
On 21/02/2021 04.17, Marc Zyngier wrote: On 2021-02-20 19:13, Krzysztof Kozlowski wrote: On Thu, Feb 18, 2021 at 11:01:21PM +0900, Hector Martin wrote: On 16/02/2021 03.51, Krzysztof Kozlowski wrote: Also fix a bug checking the return value, which should use IS_ERR(). No, no, no. We never,

Re: NFS Caching broken in 4.19.37

2021-02-21 Thread Bruce Fields
On Sun, Feb 21, 2021 at 11:38:51AM +, Anton Ivanov wrote: > On 21/02/2021 09:13, Salvatore Bonaccorso wrote: > >On Sat, Feb 20, 2021 at 08:16:26PM +, Chuck Lever wrote: > >>Confirming you are varying client-side kernels. Should the Linux > >>NFS client maintainers be Cc'd? > > > >Ok,

Re: [PATCH V3 XRT Alveo 18/18] fpga: xrt: Kconfig and Makefile updates for XRT drivers

2021-02-21 Thread Tom Rix
As I am looking through the files, I have this comment. fpga/ is currently a single directory, while files could be organized in subdirectories like dfl/pci.c instead have the possible subdir name as a prefix to the filename. dfl-pci.c For consistency, xrt/metadata/metadata.c should be

Re: [PATCH v2 00/25] Apple M1 SoC platform bring-up

2021-02-21 Thread Hector Martin
On 18/02/2021 23.36, Mark Rutland wrote: IIUC, the CPUs in these parts have some IMP-DEF instructions that can be used at EL0 which might have some IMP-DEF state. Our general expectation is that FW should configure such things to trap, but I don't know whether the M1 FW does that, and I fear

Re: [PATCH 1/2] iio: proximity: vcnl3020: add proximity rate

2021-02-21 Thread Jonathan Cameron
On Tue, 16 Feb 2021 17:53:45 +0300 Ivan Mikhaylov wrote: > Add the proximity rate optional option and handling of it for > vishay vcnl3020. > > Signed-off-by: Ivan Mikhaylov Hi Ivan, Other than dropping the dt part this mostly looks fine. Please also implement the read_avail callback to let

Re: [PATCH] iio: adis16400: Fix an error code in adis16400_initial_setup()

2021-02-21 Thread Jonathan Cameron
On Tue, 16 Feb 2021 22:42:13 +0300 Dan Carpenter wrote: > This is to silence a new Smatch warning: > > drivers/iio/imu/adis16400.c:492 adis16400_initial_setup() > warn: sscanf doesn't return error codes > > If the condition "if (st->variant->flags & ADIS16400_HAS_SLOW_MODE) {" > is

Re: KMSAN: uninit-value in __crypto_memneq (2)

2021-02-21 Thread Dmitry Vyukov
On Sat, Jan 9, 2021 at 6:33 PM Dmitry Vyukov wrote: > > On Sat, Jan 9, 2021 at 6:14 PM Eric Biggers wrote: > > > > +Jason, since this looks WireGuard-related. > > I suspect that the uninit was created by geneve or batadv and then > just handed off to wireguard, which couldn't deal with it at

[PATCH] doc: use KCFLAGS instead of EXTRA_CFLAGS to pass flags from command line

2021-02-21 Thread Masahiro Yamada
You should use KCFLAGS to pass additional compiler flags from the command line. Using EXTRA_CFLAGS is wrong. EXTRA_CFLAGS is supposed to specify flags applied only to the current Makefile (and now deprecated in favor of ccflags-y). It is still used in arch/mips/kvm/Makefile (and possibly in

RE: [PATCH v21 2/4] scsi: ufs: L2P map management for HPB read

2021-02-21 Thread Avri Altman
> +static bool ufshpb_is_hpb_rsp_valid(struct ufs_hba *hba, > +struct ufshcd_lrb *lrbp, > +struct utp_hpb_rsp *rsp_field) > +{ > + if (be16_to_cpu(rsp_field->sense_data_len) != DEV_SENSE_SEG_LEN || > +

Re: [PATCH 0/2] iio: core,buffer-dma: 2 fixes for the recent IIO buffer series

2021-02-21 Thread Jonathan Cameron
On Fri, 19 Feb 2021 10:58:24 +0200 Alexandru Ardelean wrote: > Patchset contains 2 fixes for some patches that are present in the > iio/testing branch. > > No idea what's best now, either to re-send the series or to just send these > fixes on their own. > For now I chose to send the fixes on

Re: [PATCH v3 0/6] iio: Add output buffer support

2021-02-21 Thread Jonathan Cameron
On Fri, 19 Feb 2021 14:40:06 +0200 Alexandru Ardelean wrote: > Changelog v2 -> v3: > * > https://lore.kernel.org/linux-iio/20210217083438.37865-4-alexandru.ardel...@analog.com/T/#m396545e0c6cc9d58e17f4d79b6fc707fd0373d89 > * adding only infrastructure pieces for output DAC buffers,

Re: [PATCH v3 6/6] iio: buffer-dma: add support for cyclic DMA transfers

2021-02-21 Thread Jonathan Cameron
On Fri, 19 Feb 2021 14:40:12 +0200 Alexandru Ardelean wrote: > From: Lars-Peter Clausen > > This change adds support for cyclic DMA transfers using the IIO buffer DMA > infrastructure. > To do this, userspace must set the IIO_BUFFER_BLOCK_FLAG_CYCLIC flag on the > block when enqueueing them

Re: [PATCH 2/2] arm64: dts: fsl: add support for Kontron pitx-imx8m board

2021-02-21 Thread Krzysztof Kozlowski
On Thu, Feb 18, 2021 at 01:33:29PM +0100, Heiko Thiery wrote: > The Kontron pitx-imx8m board is based on an i.MX8MQ soc. > > Signed-off-by: Heiko Thiery > --- > arch/arm64/boot/dts/freescale/Makefile| 1 + > .../freescale/imx8mq-kontron-pitx-imx8m.dts | 675 ++ > 2

RE: [PATCH v21 2/4] scsi: ufs: L2P map management for HPB read

2021-02-21 Thread Avri Altman
> +void ufshpb_rsp_upiu(struct ufs_hba *hba, struct ufshcd_lrb *lrbp) > +{ > + struct ufshpb_lu *hpb = ufshpb_get_hpb_data(lrbp->cmd->device); > + struct utp_hpb_rsp *rsp_field; > + int data_seg_len; > + > + if (!hpb) > + return; > + > + if

Re: [PATCH v2] staging: wimax: i2400m: add space before open parenthesis

2021-02-21 Thread Rajesh Kumbhakar
On 21-02-2021 18:36, Greg KH wrote: On Sat, Feb 20, 2021 at 05:46:52AM -0800, Rajesh Kumbhakar wrote: netdev.c fixing style ERROR: space required before the open parenthesis '(' Signed-off-by: Rajesh Kumbhakar --- Changes in v2: - Removed filename from commit message. filename is

[PATCH v4 01/02] staging: kpc2000: code style: match alignment with open parenthesis

2021-02-21 Thread Nikolay Kyx
This patch fixes the following checkpatch.pl check: CHECK: Alignment should match open parenthesis in files kpc2000_i2c.c kpc2000_spi.c Signed-off-by: Nikolay Kyx --- Additionally some style warnings remain valid here and could be fixed by another patch. v2: Edited changelog, as suggested by

[PATCH RESEND] virt: acrn: Use vfs_poll() instead of f_op->poll()

2021-02-21 Thread shuo . a . liu
From: Yejune Deng Use a more advanced function vfs_poll() in acrn_irqfd_assign(). At the same time, modify the definition of events. Signed-off-by: Yejune Deng Signed-off-by: Shuo Liu --- drivers/virt/acrn/irqfd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH 0/4] Kasan improvements and fixes

2021-02-21 Thread Alex Ghiti
Hi, Le 2/8/21 à 2:30 PM, Alexandre Ghiti a écrit : This small series contains some improvements for the riscv KASAN code: - it brings a better readability of the code (patch 1/2) - it fixes oversight regarding page table population which I uncovered while working on my sv48 patchset (patch

[PATCH v3] staging: wimax: i2400m: add space before open parenthesis

2021-02-21 Thread Rajesh Kumbhakar
fixing ERROR: space required before the open parenthesis '(' Signed-off-by: Rajesh Kumbhakar --- Changes in v3: - Fixed commit message (removed filename). Changes in v2: - Removed filename from commit message. drivers/staging/wimax/i2400m/netdev.c | 2 +- 1 file changed, 1

Re: [PATCH 3/3] staging: media/atomisp: don't compile unused code

2021-02-21 Thread Greg Kroah-Hartman
On Sun, Feb 21, 2021 at 07:34:57PM +0530, karthik alapati wrote: > currently the functions defined in ibuf_ctrl_rmgr.c file are only > used by isys_init.c when CONFIG_VIDEO_ATOMISP_ISP2401 is selected > so dont't compile it when not needed, also fixes some sparse warnings > > Signed-off-by:

Re: [PATCH] net/mlx4_core: Add missed mlx4_free_cmd_mailbox()

2021-02-21 Thread Tariq Toukan
On 2/21/2021 4:35 PM, Chuhong Yuan wrote: mlx4_do_mirror_rule() forgets to call mlx4_free_cmd_mailbox() to free the memory region allocated by mlx4_alloc_cmd_mailbox() before an exit. Add the missed call to fix it. Fixes: 78efed275117 ("net/mlx4_core: Support mirroring VF DMFS rules on both

Re: [PATCH v8 20/22] counter: Implement events_queue_size sysfs attribute

2021-02-21 Thread Jonathan Cameron
On Thu, 18 Feb 2021 19:32:16 +0900 William Breathitt Gray wrote: > On Sun, Feb 14, 2021 at 06:11:46PM +, Jonathan Cameron wrote: > > On Fri, 12 Feb 2021 21:13:44 +0900 > > William Breathitt Gray wrote: > > > > > The events_queue_size sysfs attribute provides a way for users to > > >

Re: [PATCH v6 3/3] iio: proximity: Add a ChromeOS EC MKBP proximity driver

2021-02-21 Thread Jonathan Cameron
On Sun, 14 Feb 2021 12:39:58 -0800 Stephen Boyd wrote: > Quoting Jonathan Cameron (2021-02-14 04:48:09) > > On Wed, 10 Feb 2021 18:46:01 -0800 > > Stephen Boyd wrote: > > > > > Add support for a ChromeOS EC proximity driver that exposes a "front" > > > proximity sensor via the IIO subsystem.

Re: NFS Caching broken in 4.19.37

2021-02-21 Thread Anton Ivanov
On 21/02/2021 14:37, Bruce Fields wrote: On Sun, Feb 21, 2021 at 11:38:51AM +, Anton Ivanov wrote: On 21/02/2021 09:13, Salvatore Bonaccorso wrote: On Sat, Feb 20, 2021 at 08:16:26PM +, Chuck Lever wrote: Confirming you are varying client-side kernels. Should the Linux NFS client

Re: [PATCH v4] ARM: Implement SLS mitigation

2021-02-21 Thread Russell King - ARM Linux admin
On Fri, Feb 19, 2021 at 03:08:13PM -0800, Jian Cai wrote: > diff --git a/security/Kconfig.hardening b/security/Kconfig.hardening > index 269967c4fc1b..146b75a79d9e 100644 > --- a/security/Kconfig.hardening > +++ b/security/Kconfig.hardening > @@ -121,6 +121,16 @@ choice > > endchoice > >

Re: [PATCH] iio: adc: adi-axi-adc: fix typo in doc-string

2021-02-21 Thread Jonathan Cameron
On Fri, 19 Feb 2021 11:01:34 +0200 Alexandru Ardelean wrote: > The channels are of type iio_chan_spec, not axi_adc_chan_spec. They were in > some earlier version, but forgot to rename in the doc-string. > > Fixes: ef04070692a21 ("iio: adc: adi-axi-adc: add support for AXI ADC IP > core") >

[PATCH v6 1/2] checkpatch: add verbose mode

2021-02-21 Thread Dwaipayan Ray
Add a new verbose mode to checkpatch.pl to emit additional verbose test descriptions. The verbose mode is optional and can be enabled by the flag -v or --verbose. The test descriptions are parsed from the checkpatch documentation file at `Documentation/dev-tools/checkpatch.rst`. The test

[PATCH v6 0/2] checkpatch: add verbose mode

2021-02-21 Thread Dwaipayan Ray
Add a new verbose mode to checkpatch. The verbose test descriptions are read from the checkpatch documentation file at `Documentation/dev-tools/checkpatch.rst`. The verbose mode is optional and can be enabled by the flag -v or --verbose. The documentation file is only parsed by checkpatch.pl if

[PATCH v6 2/2] docs: add documentation for checkpatch

2021-02-21 Thread Dwaipayan Ray
Add documentation for kernel script checkpatch.pl. This documentation is also parsed by checkpatch to enable a verbose mode. The checkpatch message types are grouped by usage. Under each group the types are described briefly. 34 of such types are documented. Signed-off-by: Dwaipayan Ray ---

[PATCH v2] staging: media: ipu3: code style fix - avoid multiple line dereference

2021-02-21 Thread Nikolay Kyx
This patch fixes the following checkpatch.pl warning: WARNING: Avoid multiple line dereference in file ipu3-css.c Signed-off-by: Nikolay Kyx --- Additionally some style warnings remain valid here and could be fixed by another patch. v2: Removed second part of patch which fixes non-existent

Re: [PATCH 2/2] staging: rtl8192e: Change state information from u16 to u8

2021-02-21 Thread Greg KH
On Sat, Feb 20, 2021 at 11:51:55PM +0530, Atul Gopinathan wrote: > The "CcxRmState" field in struct "rtllib_network" is defined > as a u16 array of size 2 (so, 4 bytes in total). > > But the operations performed on this array throughout the code > base (in rtl8192e/) are all in byte size 2

Re: [PATCH] ia64: fix ptrace(PTRACE_SYSCALL_INFO_EXIT) sign

2021-02-21 Thread Sergei Trofimovich
On Sun, 21 Feb 2021 10:21:56 +0100 John Paul Adrian Glaubitz wrote: > Hi Sergei! > > On 2/21/21 1:25 AM, Sergei Trofimovich wrote: > > In https://bugs.gentoo.org/769614 Dmitry noticed that > > `ptrace(PTRACE_GET_SYSCALL_INFO)` does not return error sign properly. > > (...) > > Do these two

Re: [PATCH] iommu/amd: Fix event counter availability check

2021-02-21 Thread Paul Menzel
Dear Suravee, Am 17.09.20 um 19:55 schrieb Alexander Monakov: On Tue, 16 Jun 2020, Suravee Suthikulpanit wrote: Instead of blindly moving the code around to a spot that would just work, I am trying to understand what might be required here. In this case, the init_device_table_dma()should not

[PATCH v4 2/9] ALSA: virtio: add virtio sound driver

2021-02-21 Thread Anton Yakovlev
Introduce skeleton of the virtio sound driver. The driver implements the virtio sound device specification, which has become part of the virtio standard. Initial initialization of the device, virtqueues and creation of an empty ALSA sound device. Also, handling DEVICE_NEEDS_RESET device status.

[PATCH v4 5/9] ALSA: virtio: handling control and I/O messages for the PCM device

2021-02-21 Thread Anton Yakovlev
The driver implements a message-based transport for I/O substream operations. Before the start of the substream, the hardware buffer is sliced into I/O messages, the number of which is equal to the current number of periods. The size of each message is equal to the current size of one period. I/O

  1   2   3   4   5   6   >