Re: [PATCH v5 1/6] mm: rmap: fix cache flush on THP pages

2022-03-22 Thread Christoph Hellwig
On Fri, Mar 18, 2022 at 03:45:24PM +0800, Muchun Song wrote: > The flush_cache_page() only remove a PAGE_SIZE sized range from the cache. > However, it does not cover the full pages in a THP except a head page. > Replace it with flush_cache_range() to fix this issue. At least, no > problems were fo

Re: [PATCH v5 2/6] dax: fix cache flush on PMD-mapped pages

2022-03-22 Thread Christoph Hellwig
On Fri, Mar 18, 2022 at 03:45:25PM +0800, Muchun Song wrote: > The flush_cache_page() only remove a PAGE_SIZE sized range from the cache. > However, it does not cover the full pages in a THP except a head page. > Replace it with flush_cache_range() to fix this issue. This is just a > documentation

Re: [PATCH v5 6/6] mm: simplify follow_invalidate_pte()

2022-03-22 Thread Christoph Hellwig
Looks good: Reviewed-by: Christoph Hellwig

Re: [PATCH v5 5/6] dax: fix missing writeprotect the pte entry

2022-03-22 Thread Christoph Hellwig
> +static void dax_entry_mkclean(struct address_space *mapping, unsigned long > pfn, > + unsigned long npfn, pgoff_t start) > { > struct vm_area_struct *vma; > + pgoff_t end = start + npfn - 1; > > i_mmap_lock_read(mapping); > + vma_interval_tree_fo

Re: [PATCH v5 5/6] dax: fix missing writeprotect the pte entry

2022-03-22 Thread Muchun Song
On Tue, Mar 22, 2022 at 4:37 PM Christoph Hellwig wrote: > > > +static void dax_entry_mkclean(struct address_space *mapping, unsigned long > > pfn, > > + unsigned long npfn, pgoff_t start) > > { > > struct vm_area_struct *vma; > > + pgoff_t end = start + npfn

Re: [PATCH 2/2] powerpc/papr_scm: Fix build failure when CONFIG_PERF_EVENTS is not set

2022-03-22 Thread kajoljain
On 3/22/22 03:09, Dan Williams wrote: > On Fri, Mar 18, 2022 at 4:42 AM Kajol Jain wrote: >> >> The following build failure occures when CONFIG_PERF_EVENTS is not set >> as generic pmu functions are not visible in that scenario. >> >> arch/powerpc/platforms/pseries/papr_scm.c:372:35: error: ‘st

Re: [PATCH 2/2] powerpc/papr_scm: Fix build failure when CONFIG_PERF_EVENTS is not set

2022-03-22 Thread kajoljain
On 3/22/22 07:15, Dan Williams wrote: > On Mon, Mar 21, 2022 at 2:39 PM Dan Williams wrote: >> >> On Fri, Mar 18, 2022 at 4:42 AM Kajol Jain wrote: >>> >>> The following build failure occures when CONFIG_PERF_EVENTS is not set >>> as generic pmu functions are not visible in that scenario. >>>

Re: [PATCH 2/2] powerpc/papr_scm: Fix build failure when CONFIG_PERF_EVENTS is not set

2022-03-22 Thread Dan Williams
On Tue, Mar 22, 2022 at 7:30 AM kajoljain wrote: > > > > On 3/22/22 03:09, Dan Williams wrote: > > On Fri, Mar 18, 2022 at 4:42 AM Kajol Jain wrote: > >> > >> The following build failure occures when CONFIG_PERF_EVENTS is not set > >> as generic pmu functions are not visible in that scenario. > >

[GIT PULL] DAX update for 5.18

2022-03-22 Thread Dan Williams
Hi Linus, please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm tags/dax-for-5.18 ...to receive a small collection of dax fixes for 5.18. Andrew has been shepherding major dax features that touch the core -mm through his tree, but I still collect the dax updates that are

Re: [PATCH v1] device-dax: Adding match parameter to select which driver to match dax devices

2022-03-22 Thread Dan Williams
On Mon, Feb 28, 2022 at 1:50 AM Zhenguo Yao wrote: > > device_dax driver always match dax devices by default. The other > drivers only match devices by dax_id. There are situations which > need kmem drvier match all the dax device at boot time. So > adding a parameter to support this function. Wh

Re: [PATCH v1] device-dax: Adding match parameter to select which driver to match dax devices

2022-03-22 Thread Zhenguo Yao
I thought about it carefully. Indeed, in my scenario(virtual machine which use optane as DRAM), device assignment can be performed in userspace at very early time after the system is started. This patch is not needed in my scenario. Thank you for your reply. Dan Williams 于2022年3月23日周三 10:01写道: >