Re: [LinuxBIOS] [linux-usb-devel] [RFC][PATCH 0/2] x86_64 Early usb debug port support.

2006-12-07 Thread Eric W. Biederman
"Lu, Yinghai" <[EMAIL PROTECTED]> writes: > -Original Message- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] On Behalf Of > [EMAIL PROTECTED] > > >>Ok due to popular demands here is the slightly fixed patch that works >>on both i386 and x86_64. For the i386 version you must not

Re: vmlist_lock locking

2006-12-07 Thread Eric Dumazet
kernel list a écrit : My understanding is that get_vm_area_node etc. can't be called in interrupt context because vmlist_lock is obtained with read_lock / write_lock. I am wondering if it makes sense to use read_lock_bh / write_lock_bh so that get_vm_area_node can be called in soft interrupt

[patch 2.6.19-git] watchdog: at91_wdt build fix

2006-12-07 Thread David Brownell
Recent miscdev changes broke various drivers, so they won't build. This fixes another one. Signed-off-by: David Brownell <[EMAIL PROTECTED]> Index: at91/drivers/char/watchdog/at91rm9200_wdt.c === ---

Re: [LinuxBIOS] [linux-usb-devel] [RFC][PATCH 0/2] x86_64 Early usb debug port support.

2006-12-07 Thread Greg KH
On Thu, Dec 07, 2006 at 07:48:17PM -0800, Lu, Yinghai wrote: > With Greg's USB Debug, host and target can talk. > target with console=ttyUSB0,115200n8 Ugh, no, never use the usb-serial driver as a console device. That was a bad hack done as a bet many years ago. For many obvious reasons it does

vmlist_lock locking

2006-12-07 Thread kernel list
My understanding is that get_vm_area_node etc. can't be called in interrupt context because vmlist_lock is obtained with read_lock / write_lock. I am wondering if it makes sense to use read_lock_bh / write_lock_bh so that get_vm_area_node can be called in soft interrupt context. All the code

[RFC] [PATCH] virtual memmap on sparsemem v3 [4/4] ia64 support

2006-12-07 Thread KAMEZAWA Hiroyuki
ia64 support for sparsemem/vmem_map. * defines mem_map[] and set its value (by static way). * changes definitions of VMALLOC_START. * adds CONFIGS. Signed-Off-By: KAMEZAWA Hiroyuki <[EMAIL PROTECTED]> Index: devel-2.6.19/arch/ia64/Kconfig

[RFC] [PATCH] virtual memmap on sparsemem v3 [3/4] static virtual mem_map

2006-12-07 Thread KAMEZAWA Hiroyuki
This patch adds support for statically allocated virtual mem_map. (means virtual address of mem_map array is defined statically.) This removes reference to *(_map). Signed-Off-By: KAMEZAWA Hiroyuki <[EMAIL PROTECTED]> Index: devel-2.6.19/include/linux/mmzone.h

[RFC] [PATCH] virtual memmap on sparsemem v3 [2/4] generic virtual mem_map on sparsemem

2006-12-07 Thread KAMEZAWA Hiroyuki
This patch implements of virtual mem_map on sparsemem. This includes only arch independent part and depends on generic map/unmap in the kernel function in this patch series. Usual sparsemem(_extreme) have to do global table look up in pfn_to_page()/page_to_pfn(), this seems a bit costly. If an

[RFC] [PATCH] virtual memmap on sparsemem v3 [1/4] map and unmap

2006-12-07 Thread KAMEZAWA Hiroyuki
When we want to map pages into the kernel space by vmalloc()'s routine, we always need 'struct page' to do that. There are cases where there is no page struct to use (bootstrap, etc..). This function is designed to help map any memory to anywhere, anytime. Users should manage their

[git pull] Input patches for 2.6.19

2006-12-07 Thread Dmitry Torokhov
Hi Linus, Please pull from:         git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git or         master.kernel.org:/pub/scm/linux/kernel/git/dtor/input.git to receive updates for input subsystem. Changelog: -- Akinobu Mita (2): Input: lightning - return proper error

[RFC] [PATCH] virtual memmap on sparsemem v3 [0/4] introduction

2006-12-07 Thread KAMEZAWA Hiroyuki
Hi, virtual mem_map on sparsemem/generic patch version 3. I myself likes this patch. But someone may feels this patch is intrusive and scattered. please pointing out. Changes v2 -> v3 - make map/unmap function for general purpose. (for my purpose ;) - drop memory hotplug support. will be posted

Re: new procfs memory analysis feature

2006-12-07 Thread Paul Cameron Davies
On Thu, 7 Dec 2006, Andrew Morton wrote: I think that's our eighth open-coded pagetable walker. Apparently they are all slightly different. Perhaps we shouild do something about that one day. At UNSW we have abstracted the page table into its own layer, and are running an alternate page

Re: [patch] lockdep: fix possible races while disabling lock-debugging

2006-12-07 Thread Jarek Poplawski
On Thu, Dec 07, 2006 at 02:29:03PM +0100, Ingo Molnar wrote: > Subject: [patch] lockdep: fix possible races while disabling lock-debugging > From: Ingo Molnar <[EMAIL PROTECTED]> ... > (also note that as we all know the Linux kernel is, by definition, > bug-free and perfect, so this code never

[PATCH] freezer.h uses task_struct fields

2006-12-07 Thread Randy Dunlap
From: Randy Dunlap <[EMAIL PROTECTED]> freezer.h uses task_struct fields so it should include sched.h. CC [M] fs/jfs/jfs_txnmgr.o In file included from fs/jfs/jfs_txnmgr.c:49: include/linux/freezer.h: In function 'frozen': include/linux/freezer.h:9: error: dereferencing pointer to incomplete

[PATCH 001/001] crypto: add sha384 hmac and sha512 hmac tests to tcrypt in 2.6.19 kernel

2006-12-07 Thread Andrew Donofrio
This patch adds tests for SHA384 HMAC and SHA512 HMAC to the tcrypt module. Test data was taken from RFC4231. This patch is a follow-up to the discovery (bug 7646) that the kernel SHA384 HMAC implementation was not generating proper SHA384 HMACs. Signed-off-by: Andrew Donofrio <[EMAIL

[PATCH] geode crypto is PCI device

2006-12-07 Thread Randy Dunlap
From: Randy Dunlap <[EMAIL PROTECTED]> This driver seems to be for a PCI device. drivers/crypto/geode-aes.c:384: warning: implicit declaration of function 'pci_release_regions' drivers/crypto/geode-aes.c:397: warning: implicit declaration of function 'pci_request_regions' Signed-off-by: Randy

Re: [PATCH 2/3] ensure unique i_ino in filesystems without permanent inode numbers (libfs superblock cleanup)

2006-12-07 Thread Josef Sipek
On Thu, Dec 07, 2006 at 05:13:08PM -0500, Jeff Layton wrote: > This patch ensures that the inodes allocated by the functions get_sb_pseudo > and simple_fill_super are unique, provided of course, that the filesystems > calling them play by the rules. Currently that isn't the case, but will be > as

Re: [PATCH] Add __GFP_MOVABLE for callers to flag allocations that may be migrated

2006-12-07 Thread Jeremy Fitzhardinge
Christoph Lameter wrote: > The same can be done using the virtual->physical mappings that exist on > many platforms for the kernel address space (ia64 dynamically calculates > those, x86_64 uses a page table with 2M pages for mapping the kernel). Yes, that's basically what Xen does - there's a

Re: Kernel 2.6 SMP very slow with ServerWorks LE Chipset

2006-12-07 Thread Bob
Arjan van de Ven wrote: in UP config everything is OK in SMP the system slows right down, I've been searching and recompiling my kernel for days looking for the problem option without success, please help. does the linux-ready firmware kit work on this machine? (see url in sig), it might be

Re: [PATCH 35/35] Unionfs: Extended Attributes support

2006-12-07 Thread Josef Sipek
On Thu, Dec 07, 2006 at 12:04:43PM +0100, Jan Engelhardt wrote: > > On Dec 4 2006 07:31, Josef 'Jeff' Sipek wrote: > > If the makefile contains > > >--- a/fs/unionfs/Makefile > >+++ b/fs/unionfs/Makefile > >@@ -3,3 +3,5 @@ obj-$(CONFIG_UNION_FS) += unionfs.o > > unionfs-y := subr.o dentry.o

Re: Kernel 2.6 SMP very slow with ServerWorks LE Chipset

2006-12-07 Thread Bob
Alan wrote: As a test of raw CPU power I've been decompressing the kernel tree, with a UP 2.6 kernel this takes about 1m 15s, I don't know if bz2 is multithreaded but even if it's not I would expect a slight speed increase but in fact with a SMP 2.6 kernel it take 13 ~ 26m, with a SMP 2.4

Re: [PATCH 16/35] Unionfs: Copyup Functionality

2006-12-07 Thread Josef Sipek
On Tue, Dec 05, 2006 at 10:09:19PM +0100, Jan Engelhardt wrote: > > On Dec 4 2006 07:30, Josef 'Jeff' Sipek wrote: > >+/* Determine the mode based on the copyup flags, and the existing dentry. */ > >+static int copyup_permissions(struct super_block *sb, > >+ struct dentry

Re: workqueue deadlock

2006-12-07 Thread Andrew Morton
On Fri, 8 Dec 2006 08:23:01 +0530 Srivatsa Vaddagiri <[EMAIL PROTECTED]> wrote: > On Thu, Dec 07, 2006 at 11:37:00AM -0800, Andrew Morton wrote: > > -static void flush_cpu_workqueue(struct cpu_workqueue_struct *cwq) > > +/* > > + * If cpu == -1 it's a single-threaded workqueue and the caller does

Re: [patch] Document how to decode an IOCTL number

2006-12-07 Thread Randy Dunlap
On Thu, 7 Dec 2006 23:02:04 -0500 Chuck Ebbert wrote: > Document how to decode a binary IOCTL number. > > Signed-off-by: Chuck Ebbert <[EMAIL PROTECTED]> > --- > Documentation/ioctl/ioctl-decoding.txt | 24 > 1 file changed, 24 insertions(+) Thanks... could this be

Re: [patch] speed up single bio_vec allocation

2006-12-07 Thread Andi Kleen
On Friday 08 December 2006 05:23, Chen, Kenneth W wrote: > Andi Kleen wrote on Thursday, December 07, 2006 6:28 PM > > "Chen, Kenneth W" <[EMAIL PROTECTED]> writes: > > > I tried to use cache_line_size() to find out the alignment of struct bio, > > > but > > > stumbled on that it is a runtime

RE: [patch 2.6.19-rc6] Stop gcc 4.1.0 optimizing wait_hpet_tick away

2006-12-07 Thread David Schwartz
> In that case it specifies that any evaluation of "*foo" in an rvalue > context specifies a read (with a few exceptions for G++ where the C++ > language generally confuses things). Specifically it mentions the > statement "*src;" and discusses the statement as providing "a void > context". In

RE: [patch] speed up single bio_vec allocation

2006-12-07 Thread Chen, Kenneth W
Andi Kleen wrote on Thursday, December 07, 2006 6:28 PM > "Chen, Kenneth W" <[EMAIL PROTECTED]> writes: > > I tried to use cache_line_size() to find out the alignment of struct bio, > > but > > stumbled on that it is a runtime function for x86_64. > > It's a single global variable access: > >

Re: [parisc-linux] Re: [2.6 patch] arch/parisc/Makefile: remove GCC_VERSION

2006-12-07 Thread Kyle McMartin
On Fri, Dec 01, 2006 at 11:23:55AM -0700, Grant Grundler wrote: > I've committed a variant of this to > git://git.parisc-linux.org/git/linux-2.6.git > I didn't test the failure case - only that it doesn't trigger with > my current gcc 4.x compilers. > > I expect Kyle will push parisc tree to

Re: [PATCH 15/35] Unionfs: Common file operations

2006-12-07 Thread Josef Sipek
On Tue, Dec 05, 2006 at 10:02:10PM +0100, Jan Engelhardt wrote: > On Dec 4 2006 07:30, Josef 'Jeff' Sipek wrote: > >+long unionfs_ioctl(struct file *file, unsigned int cmd, unsigned long arg) > >+{ > >+long err; > >+ > >+if ((err = unionfs_file_revalidate(file, 1))) > >+goto

Re: 2.6 tmpfs/swap performance oddity

2006-12-07 Thread Chuck Ebbert
In-Reply-To: <[EMAIL PROTECTED]> On Wed, 06 Dec 2006 19:07:07 +0100, Magnus Naeslund wrote: > Is there any secret knobs that I can use to > tune swap performance? You might try changing /proc/sys/vm/page-cluster to 5. -- Chuck "Even supernovas have their duller moments." - To unsubscribe

[patch] Document how to decode an IOCTL number

2006-12-07 Thread Chuck Ebbert
Document how to decode a binary IOCTL number. Signed-off-by: Chuck Ebbert <[EMAIL PROTECTED]> --- Documentation/ioctl/ioctl-decoding.txt | 24 1 file changed, 24 insertions(+) --- /dev/null +++ 2.6.19.0.5-32smp/Documentation/ioctl/ioctl-decoding.txt @@ -0,0 +1,24 @@

RE: [LinuxBIOS] [linux-usb-devel] [RFC][PATCH 0/2] x86_64 Early usb debug port support.

2006-12-07 Thread Lu, Yinghai
-Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of [EMAIL PROTECTED] >Ok due to popular demands here is the slightly fixed patch that works >on both i386 and x86_64. For the i386 version you must not have >HIGHMEM64G enabled. >I just rolled it all into

[PATCH 10/10] cxgb3 - build files and versioning

2006-12-07 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> This patch implements build files and versioning for the Chelsio T3 network adapter's driver. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/Kconfig | 18 ++ drivers/net/Makefile|1 +

Re: [PATCH 1/3] WorkStruct: Fix up some PA-RISC work items

2006-12-07 Thread Kyle McMartin
On Thu, Dec 07, 2006 at 03:31:38PM +, David Howells wrote: > Fix up some PA-RISC work items broken by the workstruct reduction. > > Signed-Off-By: David Howells <[EMAIL PROTECTED]> applied, thanks. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a

Re: Let's get rid of those annoying "VFS is out of sync with lock manager" messages (includes proposed patch)

2006-12-07 Thread Neil Brown
On Thursday December 7, [EMAIL PROTECTED] wrote: > > So I took Neils patch, made the change Trond suggested and the result is > below. > > Comments? Ok to merge? Yes, except that you need a changelog comment at the top. Possibly based very heavily on the text I wrote, but written to

[PATCH 9/10] cxgb3 - register definitions

2006-12-07 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> This patch implements the registers definitions for the Chelsio network adapter's driver. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/regs.h | 2177 ++ 1 files changed, 2177

[PATCH 7/10] cxgb3 - offload header files

2006-12-07 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> This patch implements the offload operations header files for the Chelsio T3 network adapter's driver. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/cxgb3_ctl_defs.h | 142 drivers/net/cxgb3/cxgb3_defs.h | 99 ++

Re: Status of buffered write path (deadlock fixes)

2006-12-07 Thread Nick Piggin
Mark Fasheh wrote: Hi Nick, On Tue, Dec 05, 2006 at 05:52:02PM +1100, Nick Piggin wrote: Hi, I'd like to try to state where we are WRT the buffered write patches, and ask for comments. Sorry for the wide cc list, but this is an important issue which hasn't had enough review. I pulled

[PATCH 1/10] cxgb3 - main header files

2006-12-07 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> This patch implements the main header files of the Chelsio T3 network driver. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/adapter.h | 255 drivers/net/cxgb3/common.h | 710

[PATCH 8/10] cxgb3 - offload capabilities

2006-12-07 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> This patch implements the offload capabilities of the Chelsio network adapter's driver. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/cxgb3_offload.c | 1221 + drivers/net/cxgb3/l2t.c |

[PATCH 4/10] cxgb3 - HW access routines - part 2

2006-12-07 Thread divy
From: Divy Le Ray <[EMAIL PROTECTED]> This patch implements the HW access routines for the Chelsio T3 network adapter's driver. This patch is split. This is the second part. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> -- +/** + * t3_sge_write_context - write an SGE context + *

[PATCH 0/10] cxgb3: Chelsio T3 1G/10G ethernet device driver

2006-12-07 Thread Divy Le Ray
Hi, I resubmit the patch supporting the latest Chelsio T3 adapter. It incorporates feedbacks from Stephen: - per port data accessed through netdev_priv() - remove locking in netpoll() method It also adapts to the new workqueue rules. This patch adds support for the latest Chelsio adapter, T3.

[PATCH 3/10] cxgb3 - HW access routines - part 1

2006-12-07 Thread divy
From: Divy Le Ray <[EMAIL PROTECTED]> This patch implements the HW access routines for the Chelsio T3 network adapter's driver. This patch is split. This is the first part. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/t3_hw.c | 3352

[PATCH 6/10] cxgb3 - on board memory, MAC and PHY

2006-12-07 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> This patch implements on board memory, MAC and PHY management for the Chelsio T3 network adapter's driver. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/ael1002.c | 231 ++ drivers/net/cxgb3/mc5.c | 456

Re: single bit errors on files stored on USB-HDDs via USB2/usb_storage

2006-12-07 Thread Robert Hancock
Matthias Schniedermeyer wrote: Hmmm. That's the only thing that i currently may be doing wrong. I have a 1,5 Meter and a 4,5 Meter cable connected to the USB-Controller and i only use of them depending on where the HDD is placed in my room, the other one is dangling unconnected. Then i will

Re: [git patch] improve INTx toggle for PCI MSI

2006-12-07 Thread Takashi Iwai
2006/12/8, Linus Torvalds <[EMAIL PROTECTED]>: On Thu, 7 Dec 2006, Jeff Garzik wrote: > > "it boots" on ICH7 at least. Ok. Pulled, pushed out. There was some noise saying that this may actually fix the problems with the NVidia "Intel HDA" sound situation? Can people who saw that issue try it

Re: workqueue deadlock

2006-12-07 Thread Srivatsa Vaddagiri
On Thu, Dec 07, 2006 at 11:37:00AM -0800, Andrew Morton wrote: > -static void flush_cpu_workqueue(struct cpu_workqueue_struct *cwq) > +/* > + * If cpu == -1 it's a single-threaded workqueue and the caller does not hold > + * workqueue_mutex > + */ > +static void flush_cpu_workqueue(struct

Re: [parisc-linux] [PATCH] parisc: pdcpat remove extra brackets

2006-12-07 Thread Kyle McMartin
On Thu, Nov 30, 2006 at 10:20:50AM +0100, Mariusz Kozlowski wrote: > Hello, > > This patch removes extra brackets. > > Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> > > include/asm-parisc/pdcpat.h |4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > applied, thanks.

Re: [patch] speed up single bio_vec allocation

2006-12-07 Thread Andi Kleen
"Chen, Kenneth W" <[EMAIL PROTECTED]> writes: > > I tried to use cache_line_size() to find out the alignment of struct bio, but > stumbled on that it is a runtime function for x86_64. It's a single global variable access: #define cache_line_size() (boot_cpu_data.x86_cache_alignment) Or do you

What was in the x86 merge for .20

2006-12-07 Thread Andi Kleen
[The merge already made it to Linus' tree. Sorry for sending this message late] Most of this is for both i386 and x86-64, unless when noted These are just some high lights. As usual there are more smaller optimizations, cleanups etc - paravirt support for i386: the basic hooks for replacing

Re: [patch][rfc] rwsem: generic rwsem

2006-12-07 Thread Nick Piggin
On Tue, Dec 05, 2006 at 08:36:22PM +, David Howells wrote: > Nick Piggin <[EMAIL PROTECTED]> wrote: > > > Either approach works, and one is better than the current two approaches. > > >From one point of view that's true. But from other points of view, it isn't. > > > > have be implemented

Re: [PATCH 26/35] Unionfs: Privileged operations workqueue

2006-12-07 Thread Josef Sipek
On Wed, Dec 06, 2006 at 07:46:50PM +0100, Jan Engelhardt wrote: > I smell a big conspiracy! So yet again it's mixed mixed > > fs$ grep __init */*.c | grep -v ' init_' > sysfs/mount.c:int __init sysfs_init(void) > sysv/inode.c:int __init sysv_init_icache(void) > proc/vmcore.c:static int __init

Re: [PATCH] Add __GFP_MOVABLE for callers to flag allocations that may be migrated

2006-12-07 Thread Christoph Lameter
On Thu, 7 Dec 2006, Jeremy Fitzhardinge wrote: > You can also deal with memory hotplug by adding a Xen-style > pseudo-physical vs machine address abstraction. This doesn't help with > making space for contiguous allocations, but it does allow you to move > "physical" pages from one machine page

Re: data corruption with nvidia chipsets and IDE/SATA drives // memory hole mapping related bug?!

2006-12-07 Thread Christoph Anton Mitterer
Ville Herva wrote: > I saw something very similar with Via KT133 years ago. Then the culprit was > botched PCI implementation that sometimes corrupted PCI transfers when there > was heavy PCI I/O going on. Usually than meant running two disk transfers at > the same time. Doing heavy network I/O at

Re: [PATCH] drivers/net/tulip/: fix for Lite-On 82c168 PNIC (2.6.11)

2006-12-07 Thread Valerie Henson
Hi there, Guido, Jeff resurrected this patch from the misty depths of the past. I double-checked the docs and the first bug fix is definitely correct. The second part isn't in the docs, but seems reasonable. Is this still the patch you are using? Any comments you want to add? -VAL > From:

Re: new procfs memory analysis feature

2006-12-07 Thread david singleton
On Dec 7, 2006, at 5:46 PM, Andrew Morton wrote: On Thu, 7 Dec 2006 17:07:22 -0800 david singleton <[EMAIL PROTECTED]> wrote: Attached is the 2.6.19 patch. It still has the overflow bug. + do { + ptent = *pte; + if (pte_present(ptent)) { +

Re: new procfs memory analysis feature

2006-12-07 Thread Andrew Morton
On Thu, 7 Dec 2006 17:07:22 -0800 david singleton <[EMAIL PROTECTED]> wrote: > Attached is the 2.6.19 patch. It still has the overflow bug. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: 2.6.19 file content corruption on ext3

2006-12-07 Thread Fernando Luis Vázquez Cao
On Thu, 2006-12-07 at 11:50 -0500, Phillip Susi wrote: > Marc Haber wrote: > > I went back to 2.6.18.3 to debug this, and the system ran for three > > days without problems and without corrupting > > /var/cache/apt/pkgcache.bin. After booting 2.6.19 again, it took three > > hours for the file

Re: I/O statistics per process

2006-12-07 Thread Fengguang Wu
Hi, On Fri, Dec 08, 2006 at 01:09:01AM +0100, roland wrote: > > didn`t discover that there is anything new about this (andrew? jay?) or if > some other person sent a patch , but i`d like to report that i came across > a really nice tool which would immediately benefit from per-process i/o >

Re: 2.6.19-rc6-mm2

2006-12-07 Thread Neil Brown
On Tuesday December 5, [EMAIL PROTECTED] wrote: > On Tue, 5 Dec 2006, Jiri Kosina wrote: > > > It seemed to be 100% reproducible - happened on every boot of FC6 > > system, so it was probably triggered by some raid/lvm command executed > > from init scripts after boot, but I didn't examine it

[PATCH 007 of 18] knfsd: nfsd: don't drop silently on upcall deferral

2006-12-07 Thread NeilBrown
From: J.Bruce Fields <[EMAIL PROTECTED]> To avoid tying up server threads when nfsd makes an upcall (to mountd, to get export options, to idmapd, for nfsv4 name<->id mapping, etc.), we temporarily "drop" the request and save enough information so that we can revisit it later. Certain failures

Re: [PATCH] Add __GFP_MOVABLE for callers to flag allocations that may be migrated

2006-12-07 Thread Jeremy Fitzhardinge
Christoph Lameter wrote: > On Wed, 6 Dec 2006, Mel Gorman wrote: > >> Objective: Get contiguous block of free pages >> Required: Pages that can move >> Move means: Migrating them or reclaiming >> How we do it for high-order allocations: Take a page from the LRU, move >> the pages within

[PATCH 011 of 18] knfsd: nfsd4: move replay_owner to cstate

2006-12-07 Thread NeilBrown
From: J.Bruce Fields <[EMAIL PROTECTED]> Tuck away the replay_owner in the cstate while we're at it. Signed-off-by: J. Bruce Fields <[EMAIL PROTECTED]> Signed-off-by: Neil Brown <[EMAIL PROTECTED]> ### Diffstat output ./fs/nfsd/nfs4proc.c| 31 ++-

[PATCH 006 of 18] knfsd: nfsd4: handling more nfsd_cross_mnt errors in nfsd4 readdir

2006-12-07 Thread NeilBrown
From: J.Bruce Fields <[EMAIL PROTECTED]> This patch on its own causes no change in behavior, since nfsd_cross_mnt() only returns -EAGAIN; but in the future I'd like it to also be able to return -ETIMEDOUT, so we may as well handle any possible error here. Signed-off-by: J. Bruce Fields <[EMAIL

[PATCH 013 of 18] knfsd: nfsd4: make verify and nverify wrappers

2006-12-07 Thread NeilBrown
From: J.Bruce Fields <[EMAIL PROTECTED]> Make wrappers for verify and nverify, for consistency with other ops. Signed-off-by: J. Bruce Fields <[EMAIL PROTECTED]> Signed-off-by: Neil Brown <[EMAIL PROTECTED]> ### Diffstat output ./fs/nfsd/nfs4proc.c | 28 ++-- 1 file

[PATCH 003 of 18] knfsd: nfsd4: clarify units of COMPOUND_SLACK_SPACE

2006-12-07 Thread NeilBrown
From: J.Bruce Fields <[EMAIL PROTECTED]> A comment here incorrectly states that "slack_space" is measured in words, not bytes. Remove the comment, and adjust a variable name and a few comments to clarify the situation. This is pure cleanup; there should be no change in functionality.

[PATCH 016 of 18] knfsd: nfsd4: simplify filehandle check

2006-12-07 Thread NeilBrown
From: J.Bruce Fields <[EMAIL PROTECTED]> Kill another big "if" clause. Signed-off-by: J. Bruce Fields <[EMAIL PROTECTED]> Signed-off-by: Neil Brown <[EMAIL PROTECTED]> ### Diffstat output ./fs/nfsd/nfs4proc.c | 29 - 1 file changed, 12 insertions(+), 17

[PATCH 014 of 18] knfsd: nfsd4: reorganize compound ops

2006-12-07 Thread NeilBrown
From: J.Bruce Fields <[EMAIL PROTECTED]> Define an op descriptor struct, use it to simplify nfsd4_proc_compound(). Signed-off-by: J. Bruce Fields <[EMAIL PROTECTED]> Signed-off-by: Neil Brown <[EMAIL PROTECTED]> ### Diffstat output ./fs/nfsd/nfs4proc.c | 254

[PATCH 015 of 18] knfsd: nfsd4: simplify migration op check

2006-12-07 Thread NeilBrown
From: J.Bruce Fields <[EMAIL PROTECTED]> I'm not too fond of these big if conditions. Replace them by checks of a flag in the operation descriptor. To my eye this makes the code a bit more self-documenting, and makes the complicated part of the code (proc_compound) a little more compact.

Re: [PATCH] WorkStruct: Implement generic UP cmpxchg() where an arch doesn't support it

2006-12-07 Thread Nick Piggin
Russell King wrote: On Thu, Dec 07, 2006 at 08:31:08PM +1100, Nick Piggin wrote: Implementing ll/sc based accessor macros allows both ll/sc _and_ cmpxchg architectures to produce optimal code. Implementing an cmpxchg based accessor macro allows cmpxchg architectures to produce optimal code

[PATCH 009 of 18] knfsd: nfsd4: pass saved and current fh together into nfsd4 operations.

2006-12-07 Thread NeilBrown
From: J.Bruce Fields <[EMAIL PROTECTED]> Pass the saved and current filehandles together into all the nfsd4 compound operations. I want a unified interface to these operations so we can just call them by pointer and throw out the huge switch statement. Also I'll eventually want a structure

[PATCH 004 of 18] knfsd: nfsd: make exp_rootfh handle exp_parent errors

2006-12-07 Thread NeilBrown
From: J.Bruce Fields <[EMAIL PROTECTED]> Since exp_parent can fail by returning an error (-EAGAIN) in addition to by returning NULL, we should check for that case in exp_rootfh. (TODO: we should check that userland handles these errors too.) Signed-off-by: J. Bruce Fields <[EMAIL PROTECTED]>

[PATCH 005 of 18] knfsd: nfsd: simplify exp_pseudoroot

2006-12-07 Thread NeilBrown
From: J.Bruce Fields <[EMAIL PROTECTED]> Note there's no need for special handling of -EAGAIN here; nfserrno() does what we want already. So this is a pure cleanup with no change in functionality. Signed-off-by: J. Bruce Fields <[EMAIL PROTECTED]> Signed-off-by: Neil Brown <[EMAIL PROTECTED]>

[PATCH 010 of 18] knfsd: nfsd4: remove spurious replay_owner check

2006-12-07 Thread NeilBrown
From: J.Bruce Fields <[EMAIL PROTECTED]> OK, this is embarassing--I've even looked back at the history, and cannot for the life of me figure out why I added this check. Signed-off-by: J. Bruce Fields <[EMAIL PROTECTED]> Signed-off-by: Neil Brown <[EMAIL PROTECTED]> ### Diffstat output

[PATCH 001 of 18] knfsd: nfsd4: remove a dprink from nfsd4_lock

2006-12-07 Thread NeilBrown
From: J.Bruce Fields <[EMAIL PROTECTED]> This dprintk is printing the wrong error now, but it's probably an unnecessary dprintk anyway; just remove it. Signed-off-by: J. Bruce Fields <[EMAIL PROTECTED]> Signed-off-by: Neil Brown <[EMAIL PROTECTED]> ### Diffstat output ./fs/nfsd/nfs4state.c |

[PATCH 018 of 18] knfsd: Fix up some bit-rot in exp_export

2006-12-07 Thread NeilBrown
The nfsservctl systemcall isn't used but recent nfs-utils releases for exporting filesystems, and consequently the code that is uses - exp_export - has suffered some bitrot. Particular: - some newly added fields in 'struct svc_export' are being initialised properly. - the return value is

[PATCH 012 of 18] knfsd: nfsd4: don't inline nfsd4 compound op functions

2006-12-07 Thread NeilBrown
From: J.Bruce Fields <[EMAIL PROTECTED]> The inlining contributes to bloating the stack of nfsd4_compound, and I want to change the compound op functions to function pointers anyway. Signed-off-by: J. Bruce Fields <[EMAIL PROTECTED]> Signed-off-by: Neil Brown <[EMAIL PROTECTED]> ### Diffstat

[PATCH 008 of 18] knfsd: svcrpc: remove another silent drop from deferral code

2006-12-07 Thread NeilBrown
From: J.Bruce Fields <[EMAIL PROTECTED]> There's no point deferring something just to immediately fail the deferral, especially now that we can do something more useful in the failure case by returning an error. Signed-off-by: J. Bruce Fields <[EMAIL PROTECTED]> Signed-off-by: Neil Brown

[PATCH 000 of 18] knfsd: Introduction - NFSv4 updates and more

2006-12-07 Thread NeilBrown
Following are 18 patches against 2.6.19-rc6-mm2 which are suitable for 2.6.20. First 16 are from the NFSv4 team at umich (thanks Bruce). Mostly fixing minor bugs and tidying-up code. Last 2 from me. We haven't been testing against old versions of nfs-utils and bit-rot has set in. Some of that

[PATCH 002 of 18] knfsd: svcrpc: fix gss krb5i memory leak

2006-12-07 Thread NeilBrown
From: J.Bruce Fields <[EMAIL PROTECTED]> The memory leak here is embarassingly obvious. This fixes a problem that causes the kernel to leak a small amount of memory every time it receives a integrity-protected request. Thanks to Aimé Le Rouzic for the bug report. Signed-off-by: J. Bruce

[PATCH 017 of 18] knfsd: Don't ignore kstrdup failure in rpc caches.

2006-12-07 Thread NeilBrown
Signed-off-by: Neil Brown <[EMAIL PROTECTED]> ### Diffstat output ./net/sunrpc/svcauth_unix.c |4 1 file changed, 4 insertions(+) diff .prev/net/sunrpc/svcauth_unix.c ./net/sunrpc/svcauth_unix.c --- .prev/net/sunrpc/svcauth_unix.c 2006-12-08 12:08:37.0 +1100 +++

[PATCH 005 of 5] md: Allow mddevs to live a bit longer to avoid a loop with udev.

2006-12-07 Thread NeilBrown
As md devices a automatically created on first open, and automatically destroyed on last close if they have no significant state, a loop can be caused with udev. If you open/close an md device that will generate add and remove events to udev. udev will open the device, notice nothing is there

[PATCH 000 of 5] md: Assorted minor fixes for mainline

2006-12-07 Thread NeilBrown
Following are 5 patches for md in 2.6.19-rc6-mm2 that are suitable for 2.6.20. Patch 4 might fix an outstanding bug against md which manifests as an oops early in boot, but I don't have test results yet. NeilBrown [PATCH 001 of 5] md: Remove some old ifdefed-out code from raid5.c [PATCH 002

[PATCH 004 of 5] md: Close a race between destroying and recreating an md device.

2006-12-07 Thread NeilBrown
For each md device, we need a gendisk. As that gendisk has a name that gets registered in sysfs, we need to make sure that when an md device is shut down, we don't create it again until the shutdown is complete and the gendisk has been deleted. This patches utilises the disks_mutex to ensure

[PATCH 003 of 5] md: Assorted md and raid1 one-liners

2006-12-07 Thread NeilBrown
Fix few bugs that meant that: - superblocks weren't alway written at exactly the right time (this could show up if the array was not written to - writting to the array causes lots of superblock updates and so hides these errors). - restarting device recovery after a clean shutdown

[PATCH 001 of 5] md: Remove some old ifdefed-out code from raid5.c

2006-12-07 Thread NeilBrown
There are some vestiges of old code that was used for bypassing the stripe cache on reads in raid5.c. This was never updated after the change from buffer_heads to bios, but was left as a reminder. That functionality has nowe been implemented in a completely different way, so the old code can

Re: new procfs memory analysis feature

2006-12-07 Thread david singleton
Attached is the 2.6.19 patch. pagemaps.patch Description: Binary data On Dec 7, 2006, at 2:36 PM, Andrew Morton wrote: On Thu, 07 Dec 2006 14:09:40 -0800 David Singleton <[EMAIL PROTECTED]> wrote: Andrew, this implements a feature for memory analysis tools to go along with

[PATCH 002 of 5] md: Return a non-zero error to bi_end_io as appropriate in raid5.

2006-12-07 Thread NeilBrown
Currently raid5 depends on clearing the BIO_UPTODATE flag to signal an error to higher levels. While this should be sufficient, it is safer to explicitly set the error code as well - less room for confusion. Signed-off-by: Neil Brown <[EMAIL PROTECTED]> ### Diffstat output

[PATCH] Remove useless wmb() memory barrier

2006-12-07 Thread Ralf Baechle
wake_up's implementation does an implicit memory barrier and I think that's the only sane semantics as the caller shouldn't have to worry. So this write memory barrier is useless. Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]> diff --git a/fs/xfs/linux-2.6/xfs_super.c

[PATCH/v2] CodingStyle updates

2006-12-07 Thread Randy Dunlap
From: Randy Dunlap <[EMAIL PROTECTED]> Add some kernel coding style comments, mostly pulled from emails by Andrew Morton, Jesper Juhl, and Randy Dunlap. - add paragraph on switch/case indentation (with fixes) - add paragraph on multiple-assignments - add more on Braces - add section on Spaces;

[PATCH] Remove useless memory barrier.

2006-12-07 Thread Ralf Baechle
I don't see why there is a memory barrier in copy_from_read_buf() at all. Even if it was useful spin_unlock_irqrestore implies a barrier. Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]> diff --git a/drivers/char/n_tty.c b/drivers/char/n_tty.c index 603b9ad..8df7ff3 100644 ---

Re: [PATCH 2.6.19] drivers/media/video/cpia2/cpia2_usb.c: Free previously allocated memory (in array elements) if kmalloc() returns NULL.

2006-12-07 Thread David Rientjes
On Fri, 8 Dec 2006, Mariusz Kozlowski wrote: > > > Just for future. Shorter and more readable version of your for(...) thing: > > > > > > while (i--) { > > > ... > > > } > > > > > > > No, that is not equivalent. > > > > You want > > while (i-- >= 0) { > > ... > >

Re: new procfs memory analysis feature

2006-12-07 Thread david singleton
On Dec 7, 2006, at 2:36 PM, Andrew Morton wrote: On Thu, 07 Dec 2006 14:09:40 -0800 David Singleton <[EMAIL PROTECTED]> wrote: Andrew, this implements a feature for memory analysis tools to go along with smaps. It shows reference counts for individual pages instead of aggregate

[PATCH] Add not_critical_when_idle mode for workqueues and use it in ondemand governor

2006-12-07 Thread Venkatesh Pallipadi
Add a new not_critical_when_idle parameter to queue_delayed_work_on(). This parameter can be used to schedule work that are 'unimportant' when CPU is idle and can be called later, when CPU eventually comes out of idle. Use this parameter in cpufreq ondemand governor. Signed-off-by: Venkatesh

[PATCH] Add not_critical_when_idle mode for generic timers

2006-12-07 Thread Venkatesh Pallipadi
Introduce a new mode for timers - not_critical_when_idle mode: Timers that work normally when system is busy. But, will not cause CPU to come out of idle (just to service this timer), when CPU is idle. Instead, this timer will be serviced when CPU eventually wakes up with a subsequent

[GIT PULL] ieee1394 updates post 2.6.19

2006-12-07 Thread Stefan Richter
Linus, please pull from the for-linus branch at git://git.kernel.org/pub/scm/linux/kernel/git/ieee1394/linux1394-2.6.git for-linus to receive IEEE 1394 subsystem updates as listed further below. What's in there: Alas not as many bug fixes as in previous submissions... - partial support

CodingStyle: "kzalloc()" versus "kcalloc(1,...)"

2006-12-07 Thread Robert P. J. Day
i just noticed that there are numerous invocations of kcalloc() where the hard-coded first arg of # elements is "1", which seems like an inappropriate use of kcalloc(). the only rationale i can see is that kcalloc() guarantees that the memory will be set to zero, so i'm guessing that this

Re: [PATCH 2.6.19] drivers/media/video/cpia2/cpia2_usb.c: Free previously allocated memory (in array elements) if kmalloc() returns NULL.

2006-12-07 Thread Mariusz Kozlowski
Hello, > > Just for future. Shorter and more readable version of your for(...) thing: > > > > while (i--) { > > ... > > } > > > > No, that is not equivalent. > > You want > while (i-- >= 0) { > ... > } > Not really. That will stop at -1 not 0.

Re: I/O statistics per process

2006-12-07 Thread roland
hi! didn`t discover that there is anything new about this (andrew? jay?) or if some other person sent a patch , but i`d like to report that i came across a really nice tool which would immediately benefit from per-process i/o statistics feature. please - this mail is not meant to clamor for

cfq performance gap

2006-12-07 Thread Avantika Mathur
Hi Jens, I've noticed a performance gap between the cfq scheduler and other io schedulers when running the rawio benchmark. Results from rawio on 2.6.19, cfq and noop schedulers: CFQ: procs devicenum read KB/sec I/O Ops/sec - --- -- ---

  1   2   3   4   5   6   7   8   >