Re: [PATCH] mm: swap prefetch improvements

2007-05-11 Thread Paul Jackson
Con wrote: > Hmm I'm not really sure what it takes to make it cpuset aware; > ... > It is numa aware to some degree. It stores the node id and when it starts > prefetching it only prefetches to nodes that are suitable for prefetching to > ... > It would be absolutely trivial to add a check for

Re: 2.6.21-mm2: HDAPS? BUG: at kernel/mutex.c:311

2007-05-11 Thread Satyam Sharma
Hi Dmitry, On 5/12/07, Dmitry Torokhov <[EMAIL PROTECTED]> wrote: On Friday 11 May 2007 20:53, Andrew Morton wrote: > Ho hum. I suppose a suitable workaround would be to convert hdaps_mtx back > into a semaphore. ug. Actually I was looking for victimes^Wvolunteers to test the patch below. It

Re: [PATCH] "volatile considered harmful", take 3

2007-05-11 Thread H. Peter Anvin
H. Peter Anvin wrote: > > I don't see why Alan's way is necessarily better; it should work but is > more heavy-handed as it's disabling *all* optimization such as loop > invariants across the barrier. > To expand on this further: the way this probably *should* be handled, Linux-style, is with

Re: [PATCH] "volatile considered harmful", take 3

2007-05-11 Thread H. Peter Anvin
Satyam Sharma wrote: > >> + - Pointers to data structures in coherent memory which might be >> modified >> +by I/O devices can, sometimes, legitimately be volatile. A ring >> buffer >> +used by a network adapter, where that adapter changes pointers to >> +indicate which descriptors

Re: [PATCH] "volatile considered harmful", take 2

2007-05-11 Thread H. Peter Anvin
pradeep singh wrote: > > Sorry, for my misunderstanding but i hope Jonathan actually means > volatile harmful only in C and not while using extended asm with gcc? Or > does you all consider volatile while using extended asm as harmful too? > Incidentally i came to know that using volatile in such

Re: [patch 05/10] Linux Kernel Markers - i386 optimized version

2007-05-11 Thread Suparna Bhattacharya
On Fri, May 11, 2007 at 10:27:29AM +0530, Ananth N Mavinakayanahalli wrote: > On Thu, May 10, 2007 at 12:59:18PM -0400, Mathieu Desnoyers wrote: > > * Alan Cox ([EMAIL PROTECTED]) wrote: > > ... > > > > * Third issue : Scalability. Changing code will stop every CPU on the > > > > system for a

Re: [PATCH] mm: swap prefetch improvements

2007-05-11 Thread Con Kolivas
On Saturday 12 May 2007 15:03, Paul Jackson wrote: > > Swap prefetch is not cpuset aware so make the config option depend on > > !CPUSETS. > > Ok. > > Could you explain what it means to say "swap prefetch is not cpuset aware", > or could you give a rough idea of what it would take to make it

Re: 2.6.21-mm2: HDAPS? BUG: at kernel/mutex.c:311

2007-05-11 Thread Dmitry Torokhov
On Friday 11 May 2007 20:53, Andrew Morton wrote: > Ho hum.  I suppose a suitable workaround would be to convert hdaps_mtx back > into a semaphore.  ug. Actually I was looking for victimes^Wvolunteers to test the patch below. It gets rid of _trylock business. -- Dmitry HWMON: hdaps - convert

Re: Is this a preempt issue in drivers/input/evdev.c

2007-05-11 Thread Dmitry Torokhov
Hi, On Friday 11 May 2007 23:18, Yin,Fengwei wrote: > > So if the evdev_release() is preempted at the point marked by another > process which will open the evdev, which will make operation sequence > like: > >--evdev->open in evdev_release() > -> preempted >

Re: [PATCH] mm: swap prefetch improvements

2007-05-11 Thread Paul Jackson
> Swap prefetch is not cpuset aware so make the config option depend on > !CPUSETS. Ok. Could you explain what it means to say "swap prefetch is not cpuset aware", or could you give a rough idea of what it would take to make it cpuset aware? I wouldn't go so far as to say that no one would

[PATCH] mm: swap prefetch improvements

2007-05-11 Thread Con Kolivas
It turns out that fixing swap prefetch was not that hard to fix and improve upon, and since Andrew hasn't dropped swap prefetch, instead here are a swag of fixes and improvements, including making it depend on !CPUSETS as Nick requested. These changes lead to dramatic improvements. Eg on a

Re: [PATCH] "volatile considered harmful", take 3

2007-05-11 Thread Jeff Garzik
Satyam Sharma wrote: On 5/11/07, Jonathan Corbet <[EMAIL PROTECTED]> wrote: + - Pointers to data structures in coherent memory which might be modified +by I/O devices can, sometimes, legitimately be volatile. A ring buffer +used by a network adapter, where that adapter changes

Re: Re: Re: [announce] Intel announces the PowerTOP utility for Linux

2007-05-11 Thread Jose Celestino
Words by Matt Mackall [Fri, May 11, 2007 at 09:39:05PM -0500]: > On Sat, May 12, 2007 at 02:40:52AM +0100, Jose Celestino wrote: > > Words by Matt Mackall [Fri, May 11, 2007 at 07:17:19PM -0500]: > > > On Fri, May 11, 2007 at 04:07:18PM -0700, Arjan van de Ven wrote: > > > > > > > > What's eating

Re: [PATCH 1/2] leds:arch/sh/boards/landisk LEDs supports

2007-05-11 Thread kogiidena
To: Richard-san I'm sorry. The patch sent yesterday is corrected. Only the ledtrig_bitpat_default function was changed. The patch of "Custom triggers support, which are might not supported by all LEDs" is necessary. LED driver of I-O DATA LANDISK and USL-5P Signed-off-by: kogiidena <[EMAIL

Re: [PATCH 2/2] leds:arch/sh/boards/landisk LEDs supports

2007-05-11 Thread kogiidena
To: Richard-san I'm sorry. The patch sent yesterday is corrected, too. Because the source had not been read easily, it cleaned it. There is no change for the basic function. Add Bitpattern Trigger. Bitpattern continuously turns LED on and off according to the value directed "bitdata". "bitdata"

Re: [PATCH] swsusp: Use platform mode by default

2007-05-11 Thread Len Brown
I agree that we should keep the "platform" default, as it went in 2 releases ago (nearly 6 months) without any reported failures until this one -- and it fixed a longstanding issue documented on many machines. We should debug Qi's failure like any other. We are actually in better shape on this

Re: libata reset-seq merge broke sata_sil on sh

2007-05-11 Thread Paul Mundt
On Fri, May 11, 2007 at 11:39:20AM +0200, Tejun Heo wrote: > Paul Mundt wrote: > > Bumping the hardreset delay up does indeed fix it, I've had to bump it up > > to 1200 before it started working (at 600 it still fails): > > > > [0.967379] scsi0 : sata_sil > > [0.970425] scsi1 : sata_sil >

Re: APIC error on 32-bit kernel

2007-05-11 Thread Len Brown
> > We're trying to track down the source of a problem that occurs > > whenever the atl1 network driver is activated on a 32-bit 2.6.21-rc4 > > and -rc5, -rc6, 2.6.20.x, 2.6.19.3, and probably others. > > > We can load the driver just fine, but whenever we activate the > > network, we see APIC

Re: [PATCH] "volatile considered harmful", take 3

2007-05-11 Thread Satyam Sharma
On 5/11/07, Jonathan Corbet <[EMAIL PROTECTED]> wrote: Here's another version of the volatile document. Once again, I've tried to address all of the comments. There haven't really been any recent comments addressing the correctness of the document; people have been more concerned with how it's

Is this a preempt issue in drivers/input/evdev.c

2007-05-11 Thread Yin,Fengwei
Hi, When open/close evdev, the code is as following to handle multi-client operation: static int evdev_release(...) { ... if (!--evdev->open) { exist) input_close_device(...);

Re: [patch] ip_local_port_range sysctl has annoying default

2007-05-11 Thread Bernd Eckenfels
In article <[EMAIL PROTECTED]> you wrote: > However, there are a large number of applications which have registered > ports in this range. And some application who request random listening ports actually query the /etc/services file to ensure it is a "unnamed" port. Gruss Bernd - To unsubscribe

Re: [PATCH] spelling fixes: init/

2007-05-11 Thread Satyam Sharma
On 5/12/07, Simon Arlott <[EMAIL PROTECTED]> wrote: Spelling fix in init/. Signed-off-by: Simon Arlott <[EMAIL PROTECTED]> --- init/main.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/init/main.c b/init/main.c index e8d080c..7ee2031 100644 --- a/init/main.c +++

Re: [RFC PATCH] kbuild: silence section mismatch warnings

2007-05-11 Thread Satyam Sharma
Hi Sam, On May 11, 2007, at 4:08 PM, Sam Ravnborg wrote: > Following patch allow us in specific places to silence section > mismatch warnings. Well, I had spelled out my reservations about this earlier, but I don't feel too strongly. Most people probably do not want / prefer to see warnings

Re: Re: [announce] Intel announces the PowerTOP utility for Linux

2007-05-11 Thread Matt Mackall
On Sat, May 12, 2007 at 02:40:52AM +0100, Jose Celestino wrote: > Words by Matt Mackall [Fri, May 11, 2007 at 07:17:19PM -0500]: > > On Fri, May 11, 2007 at 04:07:18PM -0700, Arjan van de Ven wrote: > > > > > > What's eating the battery life of my laptop? Why isn't it many more > > > hours?

Re: [PATCH 1/12] crypto: don't pollute the global namespace with sg_next()

2007-05-11 Thread Herbert Xu
Benny Halevy <[EMAIL PROTECTED]> wrote: > > I was trying to say that the methods should be compatible, otherwise > bugs can happen, and that your scheme is better since it can > handle sglists with zero length entries that aren't the last. > A case that might be valid after dma mapping and

[patch 2/2] epoll locks changes and cleanups ...

2007-05-11 Thread Davide Libenzi
Changes the rwlock to a spinlock, and drops the use-count variable. Operations are always bound by the mutex now, so the use-count is no more needed. For the same reason, the rwlock can become a simple spinlock. Signed-off-by: Davide Libenzi <[EMAIL PROTECTED]> - Davide Index:

Re: [PATCH]: Fix assertion failure with MSI on sparc64

2007-05-11 Thread Michael Ellerman
On Fri, 2007-05-11 at 13:26 -0700, David Miller wrote: > Hi Michael, I'm still working through the various regressions on > sparc64 added by your MSI changes :-) Hi Dave, Guilty as charged - I did CC you on the patches though ;) > The one I fixed the other day was a missed switch over to >

[patch 1/2] fix epoll single pass code and add wait-exclusive flag ...

2007-05-11 Thread Davide Libenzi
Fixes the epoll single pass code. During the unlocked event delivery (to userspace) code, the poll callback can re-issue new events, and we must receive them correctly. Since we loop in a lockless fashion, we want to be O(nready), and we don't want to flash on/off the spinlock for every event, we

Re: [PATCH] MAINTAINERS: remove invalid list address for TPM

2007-05-11 Thread Stephen Rothwell
On Fri, 11 May 2007 09:19:32 -0700 Randy Dunlap <[EMAIL PROTECTED]> wrote: > > On Fri, 11 May 2007 16:42:07 +1000 Stephen Rothwell wrote: > > > This address bounces with "550 Unknown user". > > > > Signed-off-by: Stephen Rothwell <[EMAIL PROTECTED]> > > --- > > MAINTAINERS |1 - > > 1 files

Re: [PATCH] update sysfs kset initialisation in PPC64 DLPAR IO driver

2007-05-11 Thread Michael Ellerman
On Fri, 2007-05-11 at 11:40 +0100, Andy Whitcroft wrote: > Michael Ellerman wrote: > > On Fri, 2007-05-11 at 00:16 -0700, Greg KH wrote: > >> On Thu, May 10, 2007 at 04:54:41PM +0100, Andy Whitcroft wrote: > >>> Greg KH wrote: > On Thu, May 10, 2007 at 03:00:50PM +0100, Andy Whitcroft wrote:

Re: [patch] ip_local_port_range sysctl has annoying default

2007-05-11 Thread H. Peter Anvin
David Miller wrote: > > All ports above and including 1024 are non-privileged and available to > anyone. > > Applications which have some requirements in this area need to work > those things out themselves. However, there are a large number of applications which have registered ports in this

[PATCH] 2.6.21-git15 - Kconfig Cleanup

2007-05-11 Thread Matt LaPlante
Fix misc small issues/typos/grammar in Kconfigs for 2.6.21-git15. Signed-off-by: Matt LaPlante <[EMAIL PROTECTED]> -- diff -ru a/arch/arm/plat-s3c24xx/Kconfig b/arch/arm/plat-s3c24xx/Kconfig --- a/arch/arm/plat-s3c24xx/Kconfig 2007-04-25 23:08:32.0 -0400 +++

Re: [patch] ip_local_port_range sysctl has annoying default

2007-05-11 Thread H. Peter Anvin
Mark Glines wrote: > > By a one-in-a-million coincidence, this machine has a default port > range starting with 2048, and this breaks things for me. I'm trying to > run both klive and nfs on this box, but klive starts first (probably > because of the filename sort order), and claims UDP port

Re: [patch 1/2] From: Paul Mundt <[EMAIL PROTECTED]>

2007-05-11 Thread Andrew Morton
On Sat, 12 May 2007 10:33:00 +0900 Paul Mundt <[EMAIL PROTECTED]> wrote: > On Fri, May 11, 2007 at 11:39:15AM -0700, Andrew Morton wrote: > > On Fri, 11 May 2007 09:57:50 -0700 > > [EMAIL PROTECTED] wrote: > > > > > > I'll take a look at tidying up the PMB slab, getting rid of the dtor > > > >

Re: Re: [announce] Intel announces the PowerTOP utility for Linux

2007-05-11 Thread Jose Celestino
Words by Matt Mackall [Fri, May 11, 2007 at 07:17:19PM -0500]: > On Fri, May 11, 2007 at 04:07:18PM -0700, Arjan van de Ven wrote: > > > > What's eating the battery life of my laptop? Why isn't it many more > > hours? Which software component causes the most power to be burned? > > These are

Re: [PATCH] spelling fixes: arch/sh/

2007-05-11 Thread Paul Mundt
On Fri, May 11, 2007 at 08:43:12PM +0100, Simon Arlott wrote: > Spelling fixes in arch/sh/. > > Signed-off-by: Simon Arlott <[EMAIL PROTECTED]> Applied, thanks. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo

Re: [PATCH] spelling fixes: arch/sh64/

2007-05-11 Thread Paul Mundt
On Fri, May 11, 2007 at 08:43:19PM +0100, Simon Arlott wrote: > Spelling fixes in arch/sh64/. > > Signed-off-by: Simon Arlott <[EMAIL PROTECTED]> Applied, thanks. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More

Re: [patch 1/2] From: Paul Mundt <[EMAIL PROTECTED]>

2007-05-11 Thread Paul Mundt
On Fri, May 11, 2007 at 11:39:15AM -0700, Andrew Morton wrote: > On Fri, 11 May 2007 09:57:50 -0700 > [EMAIL PROTECTED] wrote: > > > > I'll take a look at tidying up the PMB slab, getting rid of the dtor > > > shouldn't be terribly painful. I simply opted to do the list management > > > there

Re: [patch 2/2] Slab allocators: Drop support for destructors

2007-05-11 Thread Paul Mundt
On Fri, May 11, 2007 at 09:57:51AM -0700, [EMAIL PROTECTED] wrote: > There is no user of destructors left. There is no reason why we should > keep checking for destructors calls in the slab allocators. > > The RFC for this patch was discussed at >

Re: [Bugme-new] [Bug 8462] New: applications under wine freezes

2007-05-11 Thread Charles Gagalac
--- Davide Libenzi wrote: > Charles, would you mind trying the patch below > against -git13 on your > machine. I tested it with wine and firefox on a 32 > bit P4 with HT and it's > working fine. i applied the patch against git13. starcraft, pokerstars, and firefox under wine have not frozen.

Re: [PATCH 1/7] Freezer: Read PF_BORROWED_MM in a nonracy way

2007-05-11 Thread Linus Torvalds
On Sat, 12 May 2007, Oleg Nesterov wrote: > > However, in my opininon THAT PATCH has nothing to do with this problem. > It just improves the code that we already have. Sure. However, I think it does it THE WRONG WAY, and doesn't actually fix the much deeper problems with the freezer, as

Re: 2.6.21-mm2: HDAPS? BUG: at kernel/mutex.c:311

2007-05-11 Thread Andrew Morton
On Fri, 11 May 2007 17:53:35 -0700 Andrew Morton <[EMAIL PROTECTED]> wrote: > And indeed that's buggy - the non-debug version of spin_lock_mutex() is not > irq-safe. > > I'd say that's pretty dumb of the mutex interface, really. Doing a > mutex_trylock() should be OK from all contexts. We can

Re: [PATCH 1/7] Freezer: Read PF_BORROWED_MM in a nonracy way

2007-05-11 Thread Rafael J. Wysocki
On Saturday, 12 May 2007 02:08, Linus Torvalds wrote: > > On Sat, 12 May 2007, Oleg Nesterov wrote: > > > > things change, ->mm is not stable if the kernel thread does use_mm/unuse_mm. > > ->mm is not stable *regardless*! > > Trivial examples: > - kernel thread does execve() > - user thread

Re: [patch] ip_local_port_range sysctl has annoying default

2007-05-11 Thread Mark Glines
On Sat, 12 May 2007 00:06:45 UTC David Miller <[EMAIL PROTECTED]> wrote: > All ports above and including 1024 are non-privileged and available to > anyone. > > Applications which have some requirements in this area need to work > those things out themselves. Hi David, I agree completely. My

Re: [PATCH] spelling fixes: arch/m68knommu/

2007-05-11 Thread Finn Thain
On Fri, 11 May 2007, Simon Arlott wrote: > - * Local routines to interrcept the standard I/O and vector handling > - * code. Don't include this 'till now - initialization code above needs > + * Local routines to intercept the standard I/O and vector handling > + * code. Don't include

Re: [PATCH 1/7] Freezer: Read PF_BORROWED_MM in a nonracy way

2007-05-11 Thread Oleg Nesterov
On 05/12, Oleg Nesterov wrote: > > Do we need freezer? Should we freeze kernel threads? I can't judge. I tried > to read a long thread about suspend, and failed to understand it. > > I personally think we can simplify things if CPU-hotplug use freezer, at > least. Just a small example,

Re: 2.6.21-mm2: HDAPS? BUG: at kernel/mutex.c:311

2007-05-11 Thread Andrew Morton
On Fri, 11 May 2007 19:21:15 -0500 Matt Mackall <[EMAIL PROTECTED]> wrote: > This just hit: > > [7.856000] usbcore: registered new interface driver usbhid > [7.86] BUG: at kernel/mutex.c:311 __mutex_trylock_slowpath() > [7.868000] [] show_trace_log_lvl+0x1a/0x30 > [7.872000]

Re: [patch] Refine SCREEN_INFO sanity check for vgacon initialization.

2007-05-11 Thread Eric W. Biederman
Gerd Hoffmann <[EMAIL PROTECTED]> writes: > Hi, > > Checking video mode field only to see whenever SCREEN_INFO is > initialized is not enougth, in some cases it is zero although > a vga card is present. Lets additionally check cols and lines. Acked-by: "Eric W. Biederman" <[EMAIL PROTECTED]>

Re: [PATCH 1/7] Freezer: Read PF_BORROWED_MM in a nonracy way

2007-05-11 Thread Oleg Nesterov
On 05/11, Linus Torvalds wrote: > > On Sat, 12 May 2007, Oleg Nesterov wrote: > > > > things change, ->mm is not stable if the kernel thread does use_mm/unuse_mm. > > ->mm is not stable *regardless*! > > Trivial examples: > - kernel thread does execve() > - user thread does exit(). Yes

Re: SLUB under lguest on i386

2007-05-11 Thread Christoph Lameter
On Fri, 11 May 2007, Oliver Xymoron wrote: > And no sign of further progress. SLAB worked fine. Add slub_debug to the command line. Any changes or any additional diagnostic output? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL

Re: x86 setup rewrite tree ready for flamage^W review

2007-05-11 Thread H. Peter Anvin
Kevin Winchester wrote: > Not sure if you were looking for testing, but I fuzzed it to apply to > 2.6.21-git and gave it a spin. Worked just like a normal boot (which I > assume was the point). That would be the point, yes :) Looking for breakage in video mode detection, memory detection, and

Re: [patch 1/2] From: Paul Mundt <[EMAIL PROTECTED]>

2007-05-11 Thread Christoph Lameter
On Fri, 11 May 2007, Andrew Morton wrote: > However I think we've done enough slab work for 2.6.22 now so I'm inclined > to queue these changes for 2.6.23. That would mean that the slab changes in > -mm have a dependency on the sh git tree which I am sure to forget about. > If I end up merging

2.6.21-mm2: HDAPS? BUG: at kernel/mutex.c:311

2007-05-11 Thread Matt Mackall
This just hit: [7.856000] usbcore: registered new interface driver usbhid [7.86] BUG: at kernel/mutex.c:311 __mutex_trylock_slowpath() [7.868000] [] show_trace_log_lvl+0x1a/0x30 [7.872000] [] show_trace+0x12/0x14 [7.876000] [] dump_stack+0x15/0x17 [7.88] []

Re: [announce] Intel announces the PowerTOP utility for Linux

2007-05-11 Thread Matt Mackall
On Fri, May 11, 2007 at 04:07:18PM -0700, Arjan van de Ven wrote: > > What's eating the battery life of my laptop? Why isn't it many more > hours? Which software component causes the most power to be burned? > These are important questions without a good answer... until now. I get: No

Re: [PATCH 1/7] Freezer: Read PF_BORROWED_MM in a nonracy way

2007-05-11 Thread Rafael J. Wysocki
On Saturday, 12 May 2007 01:25, Andrew Morton wrote: > On Sat, 12 May 2007 01:22:06 +0200 > "Rafael J. Wysocki" <[EMAIL PROTECTED]> wrote: > > > On Saturday, 12 May 2007 00:56, Linus Torvalds wrote: > > > > > > On Fri, 11 May 2007, Rafael J. Wysocki wrote: > > > > > > > > For user space

Re: [PATCH 1/7] Freezer: Read PF_BORROWED_MM in a nonracy way

2007-05-11 Thread Linus Torvalds
On Sat, 12 May 2007, Oleg Nesterov wrote: > > things change, ->mm is not stable if the kernel thread does use_mm/unuse_mm. ->mm is not stable *regardless*! Trivial examples: - kernel thread does execve() - user thread does exit(). The use "use_mm()" and "unuse_mm()" things are total red

Re: [PATCH] spelling fixes: arch/powerpc/

2007-05-11 Thread Paul Mackerras
Simon Arlott writes: > Spelling fixes in arch/powerpc/. > - /* Retreive CPU related informations from the flat tree > + /* Retreive CPU related information from the flat tree ^^ You missed one. :) > - /* Clear the freeze bit, and reenable the interrupt. > + /*

Re: [patch] ip_local_port_range sysctl has annoying default

2007-05-11 Thread David Miller
From: Mark Glines <[EMAIL PROTECTED]> Date: Fri, 11 May 2007 17:01:35 -0700 > Following the principle of least astonishment, I think it seems better > to use high, out-of-the-way port numbers regardless of how much RAM the > system has. So, the following patch changes this behavior slightly. >

Re: [PATCH 1/7] Freezer: Read PF_BORROWED_MM in a nonracy way

2007-05-11 Thread Oleg Nesterov
I hope Rafael will correct me if I am wrong, On 05/12, Oleg Nesterov wrote: > > On 05/11, Linus Torvalds wrote: > > > > On Sat, 12 May 2007, Oleg Nesterov wrote: > > > > > > without task_lock() we can see "p->mm != NULL" but not PF_BORROWED_MM. > > > > Let me explain it one more time: > > -

[patch] ip_local_port_range sysctl has annoying default

2007-05-11 Thread Mark Glines
On a powerpc machine (kurobox) I have here with 128M of RAM, the default value of /proc/sys/net/ipv4/ip_local_port_range is: 20484999 This setting affects the port assigned to an application by default when the application doesn't specify a port to use, like, for instance, an outgoing

Re: x86 setup rewrite tree ready for flamage^W review

2007-05-11 Thread Kevin Winchester
H. Peter Anvin wrote: > Hello all, > > I believe the x86 setup tree is now finished. I will turn it into a > "clean patchset" later this week, but I wanted to get flamed^W feedback > on it first. > > The git tree is at: > >

Re: [PATCH 1/7] Freezer: Read PF_BORROWED_MM in a nonracy way

2007-05-11 Thread Rafael J. Wysocki
On Saturday, 12 May 2007 01:29, Linus Torvalds wrote: > > On Sat, 12 May 2007, Rafael J. Wysocki wrote: > > > > We use this function (ie. kernel/power/process.c:is_user_space()) to > > distinguish kernel threads from user space processes. Therefore we make it > > always return true for user

Re: [PATCH 1/7] Freezer: Read PF_BORROWED_MM in a nonracy way

2007-05-11 Thread Oleg Nesterov
On 05/11, Linus Torvalds wrote: > > On Sat, 12 May 2007, Oleg Nesterov wrote: > > > > without task_lock() we can see "p->mm != NULL" but not PF_BORROWED_MM. > > Let me explain it one more time: > - shouldn't the *caller* protect this? > > Afaik, there's two situations: > - either things don't

Re: [PATCH][RESEND] PIE randomization

2007-05-11 Thread Jiri Kosina
On Fri, 11 May 2007, Andrew Morton wrote: > I could reverse-engineer that info from the patch, I guess, but I'd > prefer to go in the opposite direction: you tell us what the patch is > trying to do, then we look at it and see if we agree that it is in fact > doing that. I've just quickly

Re: [PATCH] Use boot based time for process start time and boot time in /proc

2007-05-11 Thread Tomas Janousek
Hi, On Fri, May 11, 2007 at 12:51:32PM -0700, Andrew Morton wrote: > On Fri, 11 May 2007 10:45:31 +0200 > Tomas Janousek <[EMAIL PROTECTED]> wrote: > > > Hello, > > > > On Thu, May 10, 2007 at 04:40:47PM -0700, Andrew Morton wrote: > > > Tomas Janousek <[EMAIL PROTECTED]> wrote: > > > > @@

Re: [PATCH 1/7] Freezer: Read PF_BORROWED_MM in a nonracy way

2007-05-11 Thread Linus Torvalds
On Sat, 12 May 2007, Oleg Nesterov wrote: > > without task_lock() we can see "p->mm != NULL" but not PF_BORROWED_MM. Let me explain it one more time: - shouldn't the *caller* protect this? Afaik, there's two situations: - either things don't change (in which case you don't need locking at

Re: [PATCH 1/7] Freezer: Read PF_BORROWED_MM in a nonracy way

2007-05-11 Thread Linus Torvalds
On Sat, 12 May 2007, Rafael J. Wysocki wrote: > > We use this function (ie. kernel/power/process.c:is_user_space()) to > distinguish kernel threads from user space processes. Therefore we make it > always return true for user space processes and always return false for kernel > threads. In the

Re: [PATCH 1/7] Freezer: Read PF_BORROWED_MM in a nonracy way

2007-05-11 Thread Andrew Morton
On Sat, 12 May 2007 01:22:06 +0200 "Rafael J. Wysocki" <[EMAIL PROTECTED]> wrote: > On Saturday, 12 May 2007 00:56, Linus Torvalds wrote: > > > > On Fri, 11 May 2007, Rafael J. Wysocki wrote: > > > > > > For user space processes this condition is always true. > > > > > > For kernel threads: >

Re: [PATCH] module_author: don't advice putting in an email address

2007-05-11 Thread Krzysztof Halasa
Rene Herman <[EMAIL PROTECTED]> writes: > /* Author, ideally of form NAME [, NAME ]*[ and NAME ] > > After my trivial patch, it says: > > /* Author, ideally of form NAME[, NAME]*[ and NAME] */ I think I would put something like this: /* Author, of form NAME[, NAME]*[ and NAME] * If you have a

Re: [PATCH] swsusp: Use platform mode by default

2007-05-11 Thread Pavel Machek
Hi! > > Just to clarify, the change in question isn't new. It was introduced by the > > commit 9185cfa92507d07ac787bc73d06c4eec7239 before 2.6.20, at Seife's > > request and with Pavel's acceptance. > > Ok, if it's that old, we migt as leave it in. Clearly there weren't many > regressions,

Re: [PATCH] libata: add human-readable error value decoding

2007-05-11 Thread Jeff Garzik
Robert Hancock wrote: The ATA ones are more of a pain in that regard than SCSI though - SCSI has all distinct error codes for different errors, whereas ATA has bitmasks for everything.. That should not affect implementation. Either way, a table-driven approach can easily work. I favor

Re: [PATCH 1/7] Freezer: Read PF_BORROWED_MM in a nonracy way

2007-05-11 Thread Oleg Nesterov
On 05/11, Linus Torvalds wrote: > > On Fri, 11 May 2007, Rafael J. Wysocki wrote: > > > > Therefore, by taking the task_lock() here we make sure that the condition > > is alyways false when we check it for kernel threads. > > Why *test* it then and return anything? > > Why not just doa

Re: [PATCH 1/7] Freezer: Read PF_BORROWED_MM in a nonracy way

2007-05-11 Thread Rafael J. Wysocki
On Saturday, 12 May 2007 00:56, Linus Torvalds wrote: > > On Fri, 11 May 2007, Rafael J. Wysocki wrote: > > > > For user space processes this condition is always true. > > > > For kernel threads: > > (1) the change of tsk->mm from NULL to a nonzero value is only made in > > fs/aio.c:use_mm()

Re: [PATCH] libata: add human-readable error value decoding

2007-05-11 Thread Robert Hancock
Tejun Heo wrote: Chuck Ebbert wrote: Robert Hancock wrote: + ehc->i.serror & SERR_TRANS_ST_ERROR ? "TransStatTransErr " : "", + ehc->i.serror & SERR_UNRECOG_FIS ? "UnrecogFIS " : "", + ehc->i.serror & SERR_DEV_XCHG ? "DevExchanged " : "" ); I'm not really convinced

[announce] Intel announces the PowerTOP utility for Linux

2007-05-11 Thread Arjan van de Ven
What's eating the battery life of my laptop? Why isn't it many more hours? Which software component causes the most power to be burned? These are important questions without a good answer... until now. The Linux 2.6.21 kernel introduces the so called tickless-idle feature. This feature

-mm git tree

2007-05-11 Thread J. Bruce Fields
The git tree at git://git.kernel.org/pub/scm/linux/kernel/git/smurf/linux-trees.git could be set up in a simpler way: $ git ls-remote git://git.kernel.org/pub/scm/linux/kernel/git/smurf/linux-trees.git fc4b5be9e651d3e71b54541e0315fc82211b42b5refs/heads/option_export

[patch] x86_64: use signalfd and timerfd compat syscalls

2007-05-11 Thread Heiko Carstens
From: Heiko Carstens <[EMAIL PROTECTED]> Looks like these two are wired up in a wrong way. Cc: Davide Libenzi <[EMAIL PROTECTED]> Cc: Andi Kleen <[EMAIL PROTECTED]> Signed-off-by: Heiko Carstens <[EMAIL PROTECTED]> --- arch/x86_64/ia32/ia32entry.S |6 +++--- 1 file changed, 3 insertions(+),

[patch] compat signalfd and timerfd are cond syscalls.

2007-05-11 Thread Heiko Carstens
From: Heiko Carstens <[EMAIL PROTECTED]> Add missing cond_syscall statements for compat_sys_signalfd and compat_sys_timerfd. Cc: Davide Libenzi <[EMAIL PROTECTED]> Signed-off-by: Heiko Carstens <[EMAIL PROTECTED]> --- Index: linux-2.6/kernel/sys_ni.c

Re: [PATCH 1/2] scalable rw_mutex

2007-05-11 Thread Oleg Nesterov
On 05/11, Peter Zijlstra wrote: > > +static inline int __rw_mutex_read_trylock(struct rw_mutex *rw_mutex) > +{ > + preempt_disable(); > + if (likely(!__rw_mutex_reader_slow(rw_mutex))) { --- WINDOW --- > + percpu_counter_mod(_mutex->readers, 1); > +

Re: [PATCH 1/7] Freezer: Read PF_BORROWED_MM in a nonracy way

2007-05-11 Thread Linus Torvalds
On Fri, 11 May 2007, Rafael J. Wysocki wrote: > > For user space processes this condition is always true. > > For kernel threads: > (1) the change of tsk->mm from NULL to a nonzero value is only made in > fs/aio.c:use_mm() along with the setting of PF_BORROWED_MM under > the task_lock(), > (2)

Re: [patch 6/7] Add common orderly_poweroff()

2007-05-11 Thread Randy Dunlap
On Thu, 10 May 2007 16:57:14 -0700 Jeremy Fitzhardinge wrote: > --- a/kernel/sys.c > +++ b/kernel/sys.c > @@ -2208,3 +2208,61 @@ asmlinkage long sys_getcpu(unsigned __us > + > +/** > + * Trigger an orderly system poweroff * orderly_poweroff - Trigger an orderly system poweroff > + * @force:

Re: [patch 4/7] add argv_split()

2007-05-11 Thread Randy Dunlap
On Thu, 10 May 2007 16:57:12 -0700 Jeremy Fitzhardinge wrote: > --- /dev/null > +++ b/lib/argv_split.c > @@ -0,0 +1,159 @@ > + > +/** > + * argv_free - free an argv > + * extra "blank" line. > + * @argv - the argument vector to be freed > + * > + * Frees an argv and the strings it points to. >

Re: [bisect] NFS regression breaks X

2007-05-11 Thread Jeff Garzik
ACK -- this regression was fixed by Trond's recent NFS bugfix push upstream. Jeff - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the

Re: [PATCH] swsusp: Use platform mode by default

2007-05-11 Thread Linus Torvalds
On Fri, 11 May 2007, Rafael J. Wysocki wrote: > > Just to clarify, the change in question isn't new. It was introduced by the > commit 9185cfa92507d07ac787bc73d06c4eec7239 before 2.6.20, at Seife's > request and with Pavel's acceptance. Ok, if it's that old, we migt as leave it in.

Re: [PATCH][RESEND] PIE randomization

2007-05-11 Thread Ulrich Drepper
On 5/11/07, Andrew Morton <[EMAIL PROTECTED]> wrote: erm, I was being funny. If you randomize a binary it won't run any more. cp /dev/random /bin/login. Oh well. My point is, we're not being told what is being randomized here. Is it the virtual starting address of the main executable mmap?

NFS spews warnings on x86-64

2007-05-11 Thread Jeff Garzik
Current git, on Fedora 6/x86-64: fs/nfs/read.c: In function ‘nfs_return_empty_page’: fs/nfs/read.c:82: warning: ‘memclear_highpage_flush’ is deprecated (declared at include/linux/highmem.h:115) fs/nfs/read.c: In function ‘nfs_readpage_truncate_uninitialised_page’: fs/nfs/read.c:106: warning:

Re: [PATCH] libata: fallback to the other IDENTIFY on device error, take#2

2007-05-11 Thread Jeff Garzik
Tejun Heo wrote: + if (class == ATA_DEV_ATA) + class = ATA_DEV_ATAPI; + else + class = ATA_DEV_ATA; the 'else' branch is obviously redundant - To unsubscribe from this list: send the line

Re: [PATCH] libata: fallback to the other IDENTIFY on device error, take#2

2007-05-11 Thread Jeff Garzik
Tejun Heo wrote: It seems the world isn't as frank as we thought and some devices lie about who they are. Fallback to the other IDENTIFY if IDENTIFY is aborted by the device. As this is the strategy used by IDE for a long time, it shouldn't cause too much problem. Signed-off-by: Tejun Heo

[patch 0/2] [PATCH] input: correctly handle keys without hardware release event

2007-05-11 Thread Giel de Nijs
Hi, This patch adds a soft release key mask to input_dev, to enable keyboard drivers to determine which keys never generate a hardware release event and hence add a release event after every press event of such keys. The mask is controlled by ioctls. The Fn+F? key combinations of Dell Latitude

Re: [patch 05/10] Linux Kernel Markers - i386 optimized version

2007-05-11 Thread Alan Cox
> The IPI might be fast, but I have seen interrupts being disabled for > quite a long time in some kernel code paths. Having interrupts disabled > on _each cpu_ while running an IPI handler waiting to be synchronized > with other CPUs has this side-effect. Therefore, if I understand well, This

Re: [PATCH] "volatile considered harmful", take 2

2007-05-11 Thread H. Peter Anvin
Jan Engelhardt wrote: >>> >>> turns up no less than 1106+2 hits. >> You forgot to exclude instances with "asm" in them. > > You can do that. > I can. 54.2% of those hits were "asm", and therefore require the "register" keyword. -hpa - To unsubscribe from this list: send the line

Re: [PATCH] "volatile considered harmful", take 2

2007-05-11 Thread Jan Engelhardt
On May 10 2007 14:45, H. Peter Anvin wrote: >Jan Engelhardt wrote: >> On May 10 2007 14:20, Jonathan Corbet wrote: >>> Who knew a documentation patch would get so many reviews? I like it... >> >> And the next thing is register-considered-harmful.txt. Running >> >> grep -Pr

Re: [PATCH] spelling fixes: arch/s390/

2007-05-11 Thread Alan Cox
> - * Implementers MUST reject keys that exhibit this property. > + * Implementors MUST reject keys that exhibit this property. Implementations ? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH] module_author: don't advice putting in an email address

2007-05-11 Thread Alan Cox
> This still wouldn't solve the following problems: > - I doubt it will be kept up to date for all > 2800 modules in the kernel > - the 3 year old kernel of your distribution would contain 3 year old > maintainership information > - maintainers sometimes disappear Maintainers sometimes DON'T

SLUB under lguest on i386

2007-05-11 Thread Oliver Xymoron
Tried to boot using SLUB under lguest with 2.6.21-mm2. Got the following: ... [0.388000] NET: Registered protocol family 17 [0.388000] Using IPI Shortcut mode [0.42] EXT2-fs warning: mounting unchecked fs, running e2fsck is recommended [0.42] VFS: Mounted root (ext2

[patch 1/2] input: add soft release key mask to keyboard driver

2007-05-11 Thread Giel de Nijs
Add keysrlmask to input_dev and add soft release handling in atkbd.c Signed-off-by: Giel de Nijs <[EMAIL PROTECTED]> --- Index: linux-2.6.21.1/drivers/input/keyboard/atkbd.c === --- linux-2.6.21.1.orig/drivers/input/keyboard/atkbd.c

[patch 2/2] input: add ioctls to console for soft release mask read/write

2007-05-11 Thread Giel de Nijs
Add KDGETKEYSRL and KDSETKEYSRL to the console to control the soft release key mask in input_dev. Signed-off-by: Giel de Nijs <[EMAIL PROTECTED]> --- Index: linux-2.6.21.1/drivers/char/vt_ioctl.c === ---

Re: [PATCH] "volatile considered harmful", take 3

2007-05-11 Thread Jesper Juhl
On 11/05/07, Jonathan Corbet <[EMAIL PROTECTED]> wrote: Here's another version of the volatile document. Once again, I've tried to address all of the comments. There haven't really been any recent comments addressing the correctness of the document; people have been more concerned with how

Re: [RFC PATCH] kbuild: silence section mismatch warnings

2007-05-11 Thread Kumar Gala
On May 11, 2007, at 4:08 PM, Sam Ravnborg wrote: - Forwarded message from Sam Ravnborg <[EMAIL PROTECTED]> - Forgot lkml in first mail... Sam Subject: [RFC PATCH] kbuild: silence section mismatch warnings From: Sam Ravnborg <[EMAIL PROTECTED]> Date: Fri, 11 May 2007 23:03:46

Re: [patch 3/7] add kstrndup

2007-05-11 Thread Jeremy Fitzhardinge
René Scharfe wrote: >> +len = strlen(s); >> +if (len > max) >> +len = max; >> > > You can avoid to run beyond max and save two lines by using strnlen: > > len = strnlen(s, max); > OK. Didn't know about strnlen. Subject: Use strnlen in kstrndup strnlen prevents

  1   2   3   4   5   6   7   8   9   >