Re: [RFC/RFT 1/5] Input: implement proper locking in input core

2007-07-23 Thread Dmitry Torokhov
Hi Jeff, On Tuesday 24 July 2007 01:35, Jeff Garzik wrote: > > spin_lock_irq() should generally be avoided. > > In cases like the first case -- input_repeat_key() -- you are making > incorrect assumptions about the state of interrupts. The other cases > are probably ok, but in general

Re: [PATCH] Kconfig: Remove top level menu "Code maturity level options"

2007-07-23 Thread Sam Ravnborg
On Mon, Jul 23, 2007 at 04:58:13PM -0700, Andrew Morton wrote: > On Sat, 21 Jul 2007 06:58:28 +0300 > Al Boldi <[EMAIL PROTECTED]> wrote: > > > > > This patch removes the top level menu "Code maturity level options", and > > moves its options into menu "General setup". > > > > This makes

Re: [RFC 0/8]KVM: swap out guest pages

2007-07-23 Thread Avi Kivity
Shaohua Li wrote: > On Mon, 2007-07-23 at 18:27 +0800, Avi Kivity wrote: > >> Shaohua Li wrote: >> >>> This patch series make kvm guest pages be able to be swapped out and >>> dynamically allocated. Without it, all guest memory is allocated at >>> guest start time. >>> >>> patches are

Re: [RFC 7/8]KVM: swap out guest pages

2007-07-23 Thread Avi Kivity
Shaohua Li wrote: >>> >>> >> You're not removing any shadows of the page, in case that page is a >> guest page table. But I don't see anything wrong with it -- the page >> won't change while it's in swap. >> > You are right. Should we? > I don't think so. It's just strange to

Re: [RFC 1/8]KVM: fix bugs in kvm sched integration patch

2007-07-23 Thread Avi Kivity
Shaohua Li wrote: >> >>> 1. vmcs_readl/vmcs_writel are called with preempt enabled >>> >>> >> Why is that bad? >> > 1. raw_smp_processor_id() > 2. migrate to other cpu > 3. current->kvm_vcpu->cpu != the cpu id of step 1. > you will see the warning. > Ah, that code is gone from

Re: [RFC/RFT 1/5] Input: implement proper locking in input core

2007-07-23 Thread Jeff Garzik
Dmitry Torokhov wrote: +static void input_repeat_key(unsigned long data) +{ + struct input_dev *dev = (void *) data; - change_bit(code, dev->key); + spin_lock_irq(>event_lock); [...] +void input_inject_event(struct input_handle *handle, + unsigned int

Re: [kvm-devel] [RFC 0/8]KVM: swap out guest pages

2007-07-23 Thread Avi Kivity
Rusty Russell wrote: > On Mon, 2007-07-23 at 13:27 +0300, Avi Kivity wrote: > >> Having an address_space (like your patch does) is remarkably simple, and >> requires few hooks from the current vm. However using existing vmas >> mapped by the user has many advantages: >> >> - compatible with

Re: [RFC 0/8]KVM: swap out guest pages

2007-07-23 Thread Avi Kivity
Jeff Dike wrote: > On Mon, Jul 23, 2007 at 01:27:40PM +0300, Avi Kivity wrote: > >> Having an address_space (like your patch does) is remarkably simple, and >> requires few hooks from the current vm. However using existing vmas >> mapped by the user has many advantages: >> > > It's also

Re: -mm merge plans for 2.6.23

2007-07-23 Thread Andrew Morton
On Mon, 23 Jul 2007 21:53:38 -0700 "Ray Lee" <[EMAIL PROTECTED]> wrote: > > Since this merge period has appeared particularly frazzling for > Andrew, I've been keeping silent and waiting for him to get to a point > where there's a breather. I didn't feel it would be polite to request > yet more

Re: 2.6.23-rc1: BUG_ON in kmap_atomic_prot()

2007-07-23 Thread Alexey Dobriyan
On Mon, Jul 23, 2007 at 03:27:12PM -0700, Andrew Morton wrote: > On Tue, 24 Jul 2007 02:04:46 +0400 > Alexey Dobriyan <[EMAIL PROTECTED]> wrote: > > > On Mon, Jul 23, 2007 at 02:11:37PM -0700, Andrew Morton wrote: > > > On Tue, 24 Jul 2007 01:01:53 +0400 > > > Alexey Dobriyan <[EMAIL PROTECTED]>

[RFC/RFT 3/5] Input: tsdev - implement proper locking

2007-07-23 Thread Dmitry Torokhov
Input: tsdev - implement proper locking Signed-off-by: Dmitry Torokhov <[EMAIL PROTECTED]> --- drivers/input/tsdev.c | 392 +++--- 1 files changed, 278 insertions(+), 114 deletions(-) Index: work/drivers/input/tsdev.c

[RFC/RFT 5/5] Input: joydev - implement proper locking

2007-07-23 Thread Dmitry Torokhov
Input: joydev - implement proper locking Signed-off-by: Dmitry Torokhov <[EMAIL PROTECTED]> --- drivers/input/joydev.c | 745 - 1 files changed, 493 insertions(+), 252 deletions(-) Index: work/drivers/input/joydev.c

[RFC/RFT 4/5] Input: mousedev - implement proper locking

2007-07-23 Thread Dmitry Torokhov
Input: mousedev - implement proper locking Signed-off-by: Dmitry Torokhov <[EMAIL PROTECTED]> --- drivers/input/mousedev.c | 736 +-- 1 files changed, 464 insertions(+), 272 deletions(-) Index: work/drivers/input/mousedev.c

[RFC/RFT 1/5] Input: implement proper locking in input core

2007-07-23 Thread Dmitry Torokhov
Input: implement proper locking in input core Also add some kerneldoc documentation to input.h Signed-off-by: Dmitry Torokhov <[EMAIL PROTECTED]> --- drivers/input/input.c | 656 -- include/linux/input.h | 112 +++- 2 files changed, 585

[RFC/RFT 2/5] evdev - implement proper locking

2007-07-23 Thread Dmitry Torokhov
Input: evdev - implement proper locking Signed-off-by: Dmitry Torokhov <[EMAIL PROTECTED]> --- drivers/input/evdev.c | 719 +- 1 files changed, 476 insertions(+), 243 deletions(-) Index: work/drivers/input/evdev.c

Re: -mm merge plans for 2.6.23

2007-07-23 Thread Ray Lee
On 7/23/07, Jeremy Fitzhardinge <[EMAIL PROTECTED]> wrote: Ray Lee wrote: > That said, I'm willing to run my day to day life through both a swap > prefetch kernel and a normal one. *However*, before I go through all > the work of instrumenting the damn thing, I'd really like Andrew (or > Linus)

[RFC/RFT 0/5] Input locking patches

2007-07-23 Thread Dmitry Torokhov
Hi everyone, I finally managed to put together some patches implementing locking in input core and main input handles. Please look over them and give them a spin. -- Dmitry - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED]

Re: -mm merge plans for 2.6.23

2007-07-23 Thread Nick Piggin
Ray Lee wrote: On 7/23/07, Nick Piggin <[EMAIL PROTECTED]> wrote: That said, I'm willing to run my day to day life through both a swap prefetch kernel and a normal one. *However*, before I go through all the work of instrumenting the damn thing, I'd really like Andrew (or Linus) to lay out

Re: -mm merge plans for 2.6.23

2007-07-23 Thread Jeremy Fitzhardinge
Ray Lee wrote: > That said, I'm willing to run my day to day life through both a swap > prefetch kernel and a normal one. *However*, before I go through all > the work of instrumenting the damn thing, I'd really like Andrew (or > Linus) to lay out his acceptance criteria on the feature. Exactly

Re: [PATCH 03/10] readahead: combine file_ra_state.prev_index/prev_offset into prev_pos

2007-07-23 Thread Andrew Morton
On Tue, 24 Jul 2007 12:32:15 +0800 Fengguang Wu <[EMAIL PROTECTED]> wrote: > On Mon, Jul 23, 2007 at 08:55:35PM -0700, Andrew Morton wrote: > > On Tue, 24 Jul 2007 10:00:12 +0800 Fengguang Wu <[EMAIL PROTECTED]> wrote: > > > > > @@ -342,11 +342,9 @@ ondemand_readahead(struct address_space > > >

Re: -mm merge plans for 2.6.23

2007-07-23 Thread Ray Lee
On 7/23/07, Nick Piggin <[EMAIL PROTECTED]> wrote: Not talking about swap prefetch itself, but everytime I have asked anyone to instrument or produce some workload where swap prefetch helps, they never do. [...] so for all the people who a whining about merging this and don't want to actually

Re: [PATCH 03/10] readahead: combine file_ra_state.prev_index/prev_offset into prev_pos

2007-07-23 Thread Fengguang Wu
On Tue, Jul 24, 2007 at 12:32:15PM +0800, Fengguang Wu wrote: > On Mon, Jul 23, 2007 at 08:55:35PM -0700, Andrew Morton wrote: > > On Tue, 24 Jul 2007 10:00:12 +0800 Fengguang Wu <[EMAIL PROTECTED]> wrote: > > > > > @@ -342,11 +342,9 @@ ondemand_readahead(struct address_space > > >

Re: [PATCH 03/10] readahead: combine file_ra_state.prev_index/prev_offset into prev_pos

2007-07-23 Thread Fengguang Wu
On Mon, Jul 23, 2007 at 08:55:35PM -0700, Andrew Morton wrote: > On Tue, 24 Jul 2007 10:00:12 +0800 Fengguang Wu <[EMAIL PROTECTED]> wrote: > > > @@ -342,11 +342,9 @@ ondemand_readahead(struct address_space > >bool hit_readahead_marker, pgoff_t offset, > >unsigned

[PATCH] kernel-doc fixes for PCI and drivers/base/

2007-07-23 Thread Randy Dunlap
From: Randy Dunlap <[EMAIL PROTECTED]> Fix undocumented function parameters in PCI and drivers/base. Warning(linux-2.6.23-rc1//drivers/pci/pci.c:1526): No description found for parameter 'rq' Warning(linux-2.6.23-rc1//drivers/base/firmware_class.c:245): No description found for parameter

[PATCH] kernel-doc fix for kmod.c

2007-07-23 Thread Randy Dunlap
From: Randy Dunlap <[EMAIL PROTECTED]> Fix kmod.c: Warning(linux-2.6.23-rc1//kernel/kmod.c:364): No description found for parameter 'envp' Signed-off-by: Randy Dunlap <[EMAIL PROTECTED]> --- kernel/kmod.c |8 1 file changed, 4 insertions(+), 4 deletions(-) ---

Re: [PATCH 0/3] readahead drop behind and size adjustment

2007-07-23 Thread Nick Piggin
Fengguang Wu wrote: On Mon, Jul 23, 2007 at 12:40:09PM -0700, Andrew Morton wrote: This is all fun stuff, but how do we find out that changes like this are good ones, apart from shipping it and seeing who gets hurt 12 months later? One thing I can imagine now is that the first pages may

pxa timer code broken for non-CONFIG_GENERIC_CLOCKEVENTS

2007-07-23 Thread Robert Schwebel
Bill, 7bbb18c9f4783b6fb3bf27af71625b590cf4f00b aka 4507/1 intensively uses stuff from include/linux/clockchips.h which are defined under #ifdef CONFIG_GENERIC_CLOCKEVENTS Unless I'm missing something, all PXA platforms which have CONFIG_GENERIC_CLOCKEVENTS not set are currently broken and don't

Re: [PATCH 4/8] i386: bitops: Kill volatile-casting of memory addresses

2007-07-23 Thread Nick Piggin
Linus Torvalds wrote: On Mon, 23 Jul 2007, Satyam Sharma wrote: [4/8] i386: bitops: Kill volatile-casting of memory addresses This is wrong. The "const volatile" is so that you can pass an arbitrary pointer. The only kind of abritraty pointer is "const volatile". In other words, the

Re: [RFH] Partition table recovery

2007-07-23 Thread Rene Herman
On 07/23/2007 03:58 PM, Theodore Tso wrote: Well, I'm considering this to be a MBR backup scheme, so Minix and BSD slices are legacy systems which are out of scope. If they are busted in the same way as MBR in terms of not having redundant backups of critical data, when they have a lot fewer

[GIT PULL] ext[234] bugfixes/cleanup

2007-07-23 Thread Theodore Ts'o
Hi Linus, Please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git for_linus Many thanks!! - Ted Eric Sandeen (2): Fix fencepost error in ext[234]_check_descriptors Remove unused bh in calls to

Re: -mm merge plans for 2.6.23

2007-07-23 Thread Nick Piggin
Jesper Juhl wrote: On 10/07/07, Con Kolivas <[EMAIL PROTECTED]> wrote: On Tuesday 10 July 2007 18:31, Andrew Morton wrote: > When replying, please rewrite the subject suitably and try to Cc: the > appropriate developer(s). ~swap prefetch Nick's only remaining issue which I could remotely

[PATCH] Doc/sysfs-rules typos

2007-07-23 Thread Randy Dunlap
From: Randy Dunlap <[EMAIL PROTECTED]> Fix typos only (spelling, grammar, duplicate words, etc.). Signed-off-by: Randy Dunlap <[EMAIL PROTECTED]> --- Documentation/sysfs-rules.txt | 72 -- 1 file changed, 35 insertions(+), 37 deletions(-) ---

Re: [PATCH 03/10] readahead: combine file_ra_state.prev_index/prev_offset into prev_pos

2007-07-23 Thread Fengguang Wu
On Mon, Jul 23, 2007 at 08:52:41PM -0700, Andrew Morton wrote: > On Tue, 24 Jul 2007 10:00:12 +0800 Fengguang Wu <[EMAIL PROTECTED]> wrote: > > > - ra->prev_index = page->index; > > + ra->prev_pos = page->index << PAGE_CACHE_SHIFT; > > bug! The rhs will get truncated befire it gets assigned

Re: [PATCH 6/8] i386: bitops: Don't mark memory as clobbered unnecessarily

2007-07-23 Thread Nick Piggin
Satyam Sharma wrote: From: Satyam Sharma <[EMAIL PROTECTED]> [6/8] i386: bitops: Don't mark memory as clobbered unnecessarily The goal is to let gcc generate good, beautiful, optimized code. But test_and_set_bit, test_and_clear_bit, __test_and_change_bit, and test_and_change_bit unnecessarily

Re: [PATCH 03/10] readahead: combine file_ra_state.prev_index/prev_offset into prev_pos

2007-07-23 Thread Andrew Morton
On Tue, 24 Jul 2007 10:00:12 +0800 Fengguang Wu <[EMAIL PROTECTED]> wrote: > @@ -342,11 +342,9 @@ ondemand_readahead(struct address_space > bool hit_readahead_marker, pgoff_t offset, > unsigned long req_size) > { > - int max;/* max readahead pages

Re: [PATCH 8/8] i386: bitops: smp_mb__{before, after}_clear_bit() definitions

2007-07-23 Thread Nick Piggin
Satyam Sharma wrote: From: Satyam Sharma <[EMAIL PROTECTED]> [8/8] i386: bitops: smp_mb__{before, after}_clear_bit() definitions From Documentation/atomic_ops.txt, those archs that require explicit memory barriers around clear_bit() must also implement these two interfaces. However, for

Re: [PATCH 03/10] readahead: combine file_ra_state.prev_index/prev_offset into prev_pos

2007-07-23 Thread Andrew Morton
On Tue, 24 Jul 2007 10:00:12 +0800 Fengguang Wu <[EMAIL PROTECTED]> wrote: > - ra->prev_index = page->index; > + ra->prev_pos = page->index << PAGE_CACHE_SHIFT; bug! The rhs will get truncated befire it gets assigned to the lhs. Need to cast page->index to loff_t. I'll fix this one

Re: [RFH] Partion table recovery

2007-07-23 Thread Rene Herman
On 07/23/2007 10:08 PM, Bill Davidsen wrote: Al Boldi wrote: As always, a good friend of mine managed to scratch my partion table by cat'ing /dev/full into /dev/sda. I was able to push him out of the way, but at least the first 100MB are gone. I can probably live without the first

Re: 2.6.22-git17 boot failure

2007-07-23 Thread Jeremy Fitzhardinge
Tilman Schmidt wrote: > So yes, all of ahci, pata_marvell, aic7xxx, jbd, dm_mod, ext3 are in > fact modules in initrd. Would it help to try a kernel with some or all > of these built in? > Yes, that would be useful. It would help tell whether its a module loading problem or a basic pci

Re: [RFH] Partition table recovery

2007-07-23 Thread Rene Herman
On 07/23/2007 03:48 PM, Theodore Tso wrote: On Mon, Jul 23, 2007 at 09:34:25AM +0200, Rene Herman wrote: That's not quite correct. Logicals have a start field relative to the encompassing extended (ie, for me always 1, for others often always 63) and the encompassing extended are relative

Re: [Cbe-oss-dev] [PATCH][36/37] Clean up duplicate includes in sound/ppc/

2007-07-23 Thread Masakazu Mokuno
On Sat, 21 Jul 2007 17:04:07 +0200 Jesper Juhl <[EMAIL PROTECTED]> wrote: > Hi, > > This patch cleans up duplicate includes in > / > > > Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> > --- > > diff --git a/sound/ppc/snd_ps3.c b/sound/ppc/snd_ps3.c > index 1aa0b46..27b6189 100644 >

Re: [PATCH 1/7] lguest: documentation pt I: Preparation

2007-07-23 Thread Rusty Russell
On Mon, 2007-07-23 at 20:06 -0700, Randy Dunlap wrote: > On Mon, 23 Jul 2007 19:21:13 -0700 Randy Dunlap wrote: > > It's great that Rusty took the time to produce all of this documentation. > > Few people do that today. Thanks Randy, it was something of an experiment. We'll see if it has the

[PATCH] tiny signalfd cleanup

2007-07-23 Thread Ulrich Drepper
This is probably a leftover from a time when the return wasn't there yet. Now the extra assignment is just irritating. Signed-off-by: Ulrich Drepper <[EMAIL PROTECTED]> --- fs/signalfd.c 2007-06-29 10:24:04.0 -0700 +++ fs/signalfd.c-new 2007-07-23 20:17:34.0 -0700 @@

Re: Incompatibilities of kmem_cache_create

2007-07-23 Thread Christoph Lameter
On Sat, 21 Jul 2007, Paul Mundt wrote: > On Sat, Jul 21, 2007 at 02:50:01AM -0300, werner wrote: > > Of the kernel 2.6.22-git15 of this night, kmem_cache_create is not > > compatible and causes compiling errors of some fundamental programs. > > Before, this error didnt occur. > > > Slab

Re: [PATCH 1/7] lguest: documentation pt I: Preparation

2007-07-23 Thread Randy Dunlap
On Mon, 23 Jul 2007 19:21:13 -0700 Randy Dunlap wrote: > On Mon, 23 Jul 2007 17:12:38 -0700 Andrew Morton wrote: > > > On Sat, 21 Jul 2007 11:17:58 +1000 > > Rusty Russell <[EMAIL PROTECTED]> wrote: > > > > > The netfilter code had very good documentation: the Netfilter Hacking > > > HOWTO.

[PATCH] [2.6.22] Fix a potential NULL pointer dereference in mace_interrupt() in drivers/net/pcmcia/nmclan_cs.c

2007-07-23 Thread Micah Gruber
This patch fixes a potential null dereference bug where we dereference DEV before a null check. This patch simply moves the dereferencing after the null check. Signed-off-by: Micah Gruber <[EMAIL PROTECTED]> --- --- a/drivers/net/pcmcia/nmclan_cs.c +++ b/drivers/net/pcmcia/nmclan_cs.c

Re: [PATCH 1/7] lguest: documentation pt I: Preparation

2007-07-23 Thread Rene Herman
On 07/24/2007 03:18 AM, Linus Torvalds wrote: PS. Nothing rhymes with Ballalaba. There once was a woman from Ballalaba who hid kernel bugs in her djellabah. When her husband found out, he objected loud, and got her expelled from the casbah! Rene. - To unsubscribe from this

[PATCH 10/10] filemap: convert some unsigned long to pgoff_t

2007-07-23 Thread Fengguang Wu
Convert some 'unsigned long' to pgoff_t. Signed-off-by: Fengguang Wu <[EMAIL PROTECTED]> --- include/linux/pagemap.h | 23 --- mm/filemap.c| 32 2 files changed, 28 insertions(+), 27 deletions(-) ---

Re: [PATCH 1/7] lguest: documentation pt I: Preparation

2007-07-23 Thread Randy Dunlap
On Mon, 23 Jul 2007 17:12:38 -0700 Andrew Morton wrote: > On Sat, 21 Jul 2007 11:17:58 +1000 > Rusty Russell <[EMAIL PROTECTED]> wrote: > > > The netfilter code had very good documentation: the Netfilter Hacking > > HOWTO. Noone ever read it. > > > > So this time I'm trying something

[PATCH 09/10] filemap: trivial code cleanups

2007-07-23 Thread Fengguang Wu
- remove unused local next_index in do_generic_mapping_read() - wrap a long line - remove a redudant page_cache_read() declaration Signed-off-by: Fengguang Wu <[EMAIL PROTECTED]> --- mm/filemap.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) ---

[PATCH 03/10] readahead: combine file_ra_state.prev_index/prev_offset into prev_pos

2007-07-23 Thread Fengguang Wu
Combine the file_ra_state members unsigned long prev_index unsigned int prev_offset into loff_t prev_pos It is more consistent and better supports huge files. Thanks to Peter for the nice proposal!

[PATCH 01/10] readahead: compacting file_ra_state

2007-07-23 Thread Fengguang Wu
Use 'unsigned int' instead of 'unsigned long' for readahead sizes. This helps reduce memory consumption on 64bit CPU when a lot of files are opened. CC: Andi Kleen <[EMAIL PROTECTED]> Signed-off-by: Fengguang Wu <[EMAIL PROTECTED]> --- include/linux/fs.h |8 mm/filemap.c |

[PATCH 08/10] readahead: remove the limit max_sectors_kb imposed on max_readahead_kb

2007-07-23 Thread Fengguang Wu
Remove the size limit max_sectors_kb imposed on max_readahead_kb. The size restriction is unreasonable. Especially when max_sectors_kb cannot grow larger than max_hw_sectors_kb, which can be rather small for some disk drives. Cc: Jens Axboe <[EMAIL PROTECTED]> Signed-off-by: Fengguang Wu <[EMAIL

[PATCH 05/10] readahead: basic support of interleaved reads

2007-07-23 Thread Fengguang Wu
This is a simplified version of the pagecache context based readahead. It handles the case of multiple threads reading on the same fd and invalidating each others' readahead state. It does the trick by scanning the pagecache and recovering the current read stream's readahead status. The algorithm

[PATCH 06/10] readahead: remove the local copy of ra in do_generic_mapping_read()

2007-07-23 Thread Fengguang Wu
The local copy of ra in do_generic_mapping_read() can now go away. It predates readanead(req_size). In a time when the readahead code was called on *every* single page. Hence a local has to be made to reduce the chance of the readahead state being overwritten by a concurrent reader. More details

[PATCH 07/10] readahead: remove several readahead macros

2007-07-23 Thread Fengguang Wu
Remove VM_MAX_CACHE_HIT, MAX_RA_PAGES and MIN_RA_PAGES. Signed-off-by: Fengguang Wu <[EMAIL PROTECTED]> --- include/linux/mm.h |2 -- mm/readahead.c | 10 +- 2 files changed, 1 insertion(+), 11 deletions(-) --- linux-2.6.22-rc6-mm1.orig/include/linux/mm.h +++

[PATCH 02/10] readahead: mmap read-around simplification

2007-07-23 Thread Fengguang Wu
Fold file_ra_state.mmap_hit into file_ra_state.mmap_miss and make it an int. Signed-off-by: Fengguang Wu <[EMAIL PROTECTED]> --- include/linux/fs.h |3 +-- mm/filemap.c |4 ++-- 2 files changed, 3 insertions(+), 4 deletions(-) --- linux-2.6.22-rc6-mm1.orig/include/linux/fs.h +++

[PATCH 00/10] readahead cleanups and interleaved readahead take 4

2007-07-23 Thread Fengguang Wu
Andrew, Here are some more readahead related cleanups and updates. smaller file_ra_state: [PATCH 01/10] readahead: compacting file_ra_state [PATCH 02/10] readahead: mmap read-around simplification [PATCH 03/10]

[PATCH 04/10] radixtree: introduce radix_tree_scan_hole()

2007-07-23 Thread Fengguang Wu
Introduce radix_tree_scan_hole(root, index, max_scan) to scan radix tree for the first hole. It will be used in interleaved readahead. The implementation is dumb and obviously correct. It can help debug(and document) the possible smart one in future. Cc: Nick Piggin <[EMAIL PROTECTED]>

Re: [PATCH] posix-timer: fix deletion race

2007-07-23 Thread Jeremy Katz
On Fri, 20 Jul 2007, Oleg Nesterov wrote: On 07/18, Jeremy Katz wrote: On Wed, 18 Jul 2007, Oleg Nesterov wrote: Jeremy, I agree with Thomas that your patch should not be right, but it does make a difference. Perhaps this is just the timing, but who knows. Could you add some printk's to be

Re: [kvm-devel] [RFC 0/8]KVM: swap out guest pages

2007-07-23 Thread Shaohua Li
On Mon, 2007-07-23 at 20:34 +0800, Christoph Hellwig wrote: > On Mon, Jul 23, 2007 at 03:29:36PM +0300, Avi Kivity wrote: > > >Actually it requires lots of deep down VM internals symbols that'll > never > > >get exported. > > > > > > > > > > What's "it" here? kvm-specific address space or

Re: [RFC 7/8]KVM: swap out guest pages

2007-07-23 Thread Shaohua Li
On Mon, 2007-07-23 at 19:32 +0800, Avi Kivity wrote: > Shaohua Li wrote: > > Make KVM guest pages be allocated dynamically and able to be swaped > out. > > > > One issue: all inodes returned from anon_inode_getfd are shared, > > if one module changes field of the inode, other moduels might break.

Re: [RFC 6/8]KVM: introduce kvm_mmu_zap_pagetbl

2007-07-23 Thread Shaohua Li
On Mon, 2007-07-23 at 19:16 +0800, Avi Kivity wrote: > Shaohua Li wrote: > > add a routine to zap all shadow pgtble for a gfn. If kvm supports > SMP, > > the API should zap pgtble for all vcpus, but kvm shadow page table > > really should be per-vm, instead of per-vcpu. > > > > > > kvm shadow

Re: [PATCH 1/7] lguest: documentation pt I: Preparation

2007-07-23 Thread Rusty Russell
On Mon, 2007-07-23 at 18:18 -0700, Linus Torvalds wrote: > > On Tue, 24 Jul 2007, Rusty Russell wrote: > > > > Indeed, no code changes, and I feel strongly that it should go into > > 2.6.23 because it's *fun*. And (as often complained) there's not > > enough poetry in the kernel. > > There's

Re: [RFC 1/8]KVM: fix bugs in kvm sched integration patch

2007-07-23 Thread Shaohua Li
On Mon, 2007-07-23 at 18:46 +0800, Avi Kivity wrote: > Shaohua Li wrote: > > fix some bugs in kvm-sch patch. > > > > There is now a 'preempt-hooks' branch on kvm.git with the > preempt-hooks > work. I'll continually update and rebase it against master. > > > 1. vmcs_readl/vmcs_writel are

Re: [RFC 0/8]KVM: swap out guest pages

2007-07-23 Thread Shaohua Li
On Mon, 2007-07-23 at 18:27 +0800, Avi Kivity wrote: > Shaohua Li wrote: > > This patch series make kvm guest pages be able to be swapped out and > > dynamically allocated. Without it, all guest memory is allocated at > > guest start time. > > > > patches are against latest git, and you need first

Re: 2.6.23-rc1: i386 section mismatch warnings

2007-07-23 Thread Al Viro
On Mon, Jul 23, 2007 at 09:18:38PM -0400, Jeff Garzik wrote: > make allmodconfig on i386: > > WARNING: vmlinux(.text+0xc0101183): Section mismatch: reference to Ignore. vmlinux.o ones are interesting; so are ones in modules. vmlinux ones are either duplicates of vmlinux.o or false positives. -

Re: [PATCH 1/7] lguest: documentation pt I: Preparation

2007-07-23 Thread Rusty Russell
On Mon, 2007-07-23 at 18:20 -0700, Andrew Morton wrote: > On Tue, 24 Jul 2007 11:01:48 +1000 Rusty Russell <[EMAIL PROTECTED]> wrote: > > But writing this documentation took *weeks*, to document 5000 lines of > > code. Perhaps this effort, if merged, will inspire others, but I've > > seen little

Re: [PATCH 1/7] lguest: documentation pt I: Preparation

2007-07-23 Thread Andrew Morton
On Tue, 24 Jul 2007 11:01:48 +1000 Rusty Russell <[EMAIL PROTECTED]> wrote: > > But I worry that you're proposing adding what appears to be new > > Documentation-related machinery and infrastructure when there's already > > increased activity in that area from other people and we might all be > >

Re: [PATCH 1/7] lguest: documentation pt I: Preparation

2007-07-23 Thread Linus Torvalds
On Tue, 24 Jul 2007, Rusty Russell wrote: > > Indeed, no code changes, and I feel strongly that it should go into > 2.6.23 because it's *fun*. And (as often complained) there's not > enough poetry in the kernel. There's a reason for that. There once was a lad from Braidwood

2.6.23-rc1: i386 section mismatch warnings

2007-07-23 Thread Jeff Garzik
make allmodconfig on i386: WARNING: vmlinux(.text+0xc0101183): Section mismatch: reference to .init.text:start_kernel (between 'is386' and 'check_x87') WARNING: vmlinux(.text+0xc02cfcdb): Section mismatch: reference to .init.text:kernel_init (between 'rest_init' and 'kthreadd_setup') WARNING:

Re: [PATCH 0/3] readahead drop behind and size adjustment

2007-07-23 Thread Andrew Morton
On Tue, 24 Jul 2007 08:47:28 +0800 Fengguang Wu <[EMAIL PROTECTED]> wrote: > Subject: convert ill defined log2() to ilog2() > > It's *wrong* to have > #define log2(n) ffz(~(n)) > It should be *reversed*: > #define log2(n) flz(~(n)) > or >

[PATCH] sata_qstor, pdc_adma, sata_sx4: convert to new EH

2007-07-23 Thread Jeff Garzik
This is just a refresh of the existing libata-dev.git#new-eh patches that convert all remaining old-EH drivers to new EH, against 2.6.23-rc1. All three conversions are completely untested. pdc_adma and sata_qstor need reviewing by someone with docs, in addition to testing. Even "it still

[PATCH] sata_mv: non-working NCQ support

2007-07-23 Thread Jeff Garzik
This patch adds NCQ support to the sata_mv driver. Currently it does not work: FPDMA commands time out, and eventually EH falls back to non-NCQ, which works. My attention has turned to other things for moment. Anybody interested in sata_mv NCQ is encouraged to pick up where this left off, as

Re: [PATCH 1/7] lguest: documentation pt I: Preparation

2007-07-23 Thread Rusty Russell
On Mon, 2007-07-23 at 17:12 -0700, Andrew Morton wrote: > On Sat, 21 Jul 2007 11:17:58 +1000 > Rusty Russell <[EMAIL PROTECTED]> wrote: > > > The netfilter code had very good documentation: the Netfilter Hacking > > HOWTO. Noone ever read it. > > > > So this time I'm trying something different,

Re: [PATCH 0/3] readahead drop behind and size adjustment

2007-07-23 Thread Fengguang Wu
On Mon, Jul 23, 2007 at 12:40:09PM -0700, Andrew Morton wrote: > On Mon, 23 Jul 2007 22:24:57 +0800 > Fengguang Wu <[EMAIL PROTECTED]> wrote: > > > On Mon, Jul 23, 2007 at 07:00:59PM +1000, Nick Piggin wrote: > > > Rusty Russell wrote: > > > >On Sun, 2007-07-22 at 16:10 +0800, Fengguang Wu wrote:

Re: [DRIVER SUBMISSION] DRBD wants to go mainline

2007-07-23 Thread Kyle Moffett
For the guys on netdev, would you please look at the tcp_recvmsg- threading and TCP_NAGLE_CORK issues below and give opinions on the best way to proceed? One thing to remember, you don't necessarily have to merge every feature right away. As long as the new code is configured "off" by

Re: [PATCH][08/37] Clean up duplicate includes in drivers/input/

2007-07-23 Thread Dmitry Torokhov
On Saturday 21 July 2007 11:02, Jesper Juhl wrote: > Hi, > > This patch cleans up duplicate includes in > drivers/input/ > Applied to for-linus branch of input tree, thank you. -- Dmitry - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message

Re: [patch 1/3] m68k/mac: Make mac_hid_mouse_emulate_buttons() declaration visible

2007-07-23 Thread Dmitry Torokhov
On Sunday 22 July 2007 08:51, Geert Uytterhoeven wrote: > On Sun, 22 Jul 2007, Dmitry Torokhov wrote: > > On Saturday 21 July 2007 04:27, Geert Uytterhoeven wrote: > > > On Fri, 20 Jul 2007, Dmitry Torokhov wrote: > > > > I am OK with adding a new header file. I was just saying that placing > > >

Re: Git tree for old kernels from before the current tree

2007-07-23 Thread Nicolas Pitre
On Mon, 23 Jul 2007, H. Peter Anvin wrote: > Nicolas Pitre wrote: > > > > I have sanitized .tgz files that I use to stuff a Git repo with. I > > recall that some of them were reconstructed through patching an earlier > > or later kernel version because the original ones were corrupted. Some

[PATCH] usbhid: add ASUS LCM to the blacklist

2007-07-23 Thread Christian Lamparter
Some of ASUS' notebooks (e.g G Series) include a tiny oled display, which is attached to an internal USB bus. Unfortunatly the device reports a wrong DeviceDescriptor and is therefore identified as a HID device... Signed-off-by: Christian Lamparter <[EMAIL PROTECTED]> CC: [EMAIL PROTECTED] CC:

Re: [PATCH] compat_ioctl requires CONFIG_BLOCK

2007-07-23 Thread Andrew Morton
On Sat, 21 Jul 2007 01:08:57 +0200 Arnd Bergmann <[EMAIL PROTECTED]> wrote: > On Saturday 21 July 2007, Sebastian Siewior wrote: > > > > Got with randconfig > > include/linux/loop.h:66: error: expected specifier-qualifier-list before > > 'request_queue_t' > > make[1]: *** [fs/compat_ioctl.o]

Re: Git tree for old kernels from before the current tree

2007-07-23 Thread H. Peter Anvin
Nicolas Pitre wrote: > > I have sanitized .tgz files that I use to stuff a Git repo with. I > recall that some of them were reconstructed through patching an earlier > or later kernel version because the original ones were corrupted. Some > patches were retrieved from other archival sites,

Re: 2.6.22-git17 boot failure

2007-07-23 Thread Jeremy Fitzhardinge
Tilman Schmidt wrote: > Am 23.07.2007 22:32 schrieb Jeremy Fitzhardinge: > >> How much of this is modules? Is the initrd probing for scsi/sata? >> Maybe the the vdso change is having an effect. >> > > Pretty much all of it is modules. The base system is openSUSE 10.2, and > SuSE has a

Re: [PATCH 1/7] lguest: documentation pt I: Preparation

2007-07-23 Thread Andrew Morton
On Sat, 21 Jul 2007 11:17:58 +1000 Rusty Russell <[EMAIL PROTECTED]> wrote: > The netfilter code had very good documentation: the Netfilter Hacking > HOWTO. Noone ever read it. > > So this time I'm trying something different, using a bit of > Knuthiness. Start with drivers/lguest/README. um.

Re: Git tree for old kernels from before the current tree

2007-07-23 Thread Nicolas Pitre
On Tue, 24 Jul 2007, Al Viro wrote: > On Mon, Jul 23, 2007 at 03:06:09PM -0400, Nicolas Pitre wrote: > > - v0.96 sources > > > > - v0.99.12 announcement > > > > - sources for v0.99.13{abcdefghij} (got k, don't know where the serie > >ends) as well as announcements for all of them > > >

Re: [PATCH] update checkpatch.pl to version 0.08

2007-07-23 Thread Randy Dunlap
On Mon, 23 Jul 2007 16:08:26 -0700 Kok, Auke wrote: > Andy Whitcroft wrote: > > This version brings a number of new checks, and a number of bug > > fixes. Of note: > > > > - warnings for multiple assignments per line > > > This is bugged. e.g. the following line will hit this exception

Re: [PATCH] spinlock in function hugetlb_fault could be deleted

2007-07-23 Thread Zhang, Yanmin
On Mon, 2007-07-23 at 09:27 -0500, Adam Litke wrote: > Hello. hugetlb_instantiation_mutex is an extremely heavy-weight lock > whose days are numbered (hopefully). It exists primarily to arbitrate > a race condition where n (n > 1) threads of execution race to satisfy > the same page fault for a

Re: [PATCH] Kconfig: Remove top level menu "Code maturity level options"

2007-07-23 Thread Andrew Morton
On Sat, 21 Jul 2007 06:58:28 +0300 Al Boldi <[EMAIL PROTECTED]> wrote: > > This patch removes the top level menu "Code maturity level options", and > moves its options into menu "General setup". > > This makes Kconfig less cluttered and easier to setup. > > > Cc: Andrew Morton <[EMAIL

Re: Git tree for old kernels from before the current tree

2007-07-23 Thread H. Peter Anvin
Al Viro wrote: > On Mon, Jul 23, 2007 at 03:06:09PM -0400, Nicolas Pitre wrote: >> - v0.96 sources >> >> - v0.99.12 announcement >> >> - sources for v0.99.13{abcdefghij} (got k, don't know where the serie >>ends) as well as announcements for all of them >> >> - all announcements for

Re: [PATCH] update checkpatch.pl to version 0.08

2007-07-23 Thread Kok, Auke
Andy Whitcroft wrote: This version brings a number of new checks, and a number of bug fixes. Of note: - warnings for multiple assignments per line - warnings for multiple declarations per line - checks for single statement blocks with braces This patch includes an update for

Re: Git tree for old kernels from before the current tree

2007-07-23 Thread Al Viro
On Mon, Jul 23, 2007 at 03:06:09PM -0400, Nicolas Pitre wrote: > - v0.96 sources > > - v0.99.12 announcement > > - sources for v0.99.13{abcdefghij} (got k, don't know where the serie >ends) as well as announcements for all of them > > - all announcements for v0.99.14{a-z} except for

Re: [RFC] scheduler: improve SMP fairness in CFS

2007-07-23 Thread Chris Snook
Tong Li wrote: This patch extends CFS to achieve better fairness for SMPs. For example, with 10 tasks (same priority) on 8 CPUs, it enables each task to receive equal CPU time (80%). The code works on top of CFS and provides SMP fairness at a coarser time grainularity; local on each CPU, it

Re: __unsafe() usage

2007-07-23 Thread Dan Williams
On 7/23/07, Rusty Russell <[EMAIL PROTECTED]> wrote: On Mon, 2007-07-23 at 19:59 +0200, Adrian Bunk wrote: > On Mon, Jul 23, 2007 at 09:05:54AM -0700, Nelson, Shannon wrote: > > Gabriel C [mailto:[EMAIL PROTECTED] > > > > > >Hi, > > > > > >I got this warning on current git using gcc 4.2.1 : > >

RE: __unsafe() usage

2007-07-23 Thread Nelson, Shannon
Rusty Russell [mailto:[EMAIL PROTECTED] >> If this is true, and since the MOD_INC_USE_COUNT compat code is long >> gone, shouldn't we be able to completely remove __unsafe() and the >> struct member "unsafe"? > >Yes, indeed, something like this: >== >Remove "unsafe" from module struct > >Adrian

Re: [PATCH] update checkpatch.pl to version 0.08

2007-07-23 Thread Kok, Auke
Andy Whitcroft wrote: This version brings a number of new checks, and a number of bug fixes. Of note: - warnings for multiple assignments per line - warnings for multiple declarations per line - checks for single statement blocks with braces This patch includes an update for

Re: Documentation for sysfs, hotplug, and firmware loading.

2007-07-23 Thread Rob Landley
On Friday 20 July 2007 8:43:49 pm Greg KH wrote: > On Fri, Jul 20, 2007 at 08:21:39PM -0400, Rob Landley wrote: > > Ok, back up. /sys/devices does not contain all the information necessary > > to populate /dev, because it hasn't got things like > > ramdisks, /dev/zero, /dev/console which are

Re: [PATCH] add __GFP_ZERO to GFP_LEVEL_MASK

2007-07-23 Thread Christoph Lameter
On Mon, 23 Jul 2007, Peter Zijlstra wrote: > --- > Daniel recently spotted that __GFP_ZERO is not (and has never been) > part of GFP_LEVEL_MASK. I could not find a reason for this in the > original patch: 3977971c7f09ce08ed1b8d7a67b2098eb732e4cd in the -bk > tree. > > This of course is in stark

Re: [patch 4/9] topology: remove topology_dev_map

2007-07-23 Thread Greg KH
On Mon, Jul 23, 2007 at 12:33:16AM +0900, Akinobu Mita wrote: > By previous cpu hotplug notifier change, we don't need to track > topology_dev existence for each cpu by topology_dev_map. > > Cc: Greg Kroah-Hartman <[EMAIL PROTECTED]> > Signed-off-by: Akinobu Mita <[EMAIL PROTECTED]> I'm guessing

Re: __unsafe() usage

2007-07-23 Thread Rusty Russell
On Mon, 2007-07-23 at 19:59 +0200, Adrian Bunk wrote: > On Mon, Jul 23, 2007 at 09:05:54AM -0700, Nelson, Shannon wrote: > > Gabriel C [mailto:[EMAIL PROTECTED] > > > > > >Hi, > > > > > >I got this warning on current git using gcc 4.2.1 : > > > > > >... > > > > > >drivers/dma/ioatdma.c: In

  1   2   3   4   5   6   7   8   9   10   >