From: Chao Xie
Initialize the clocks for pxa168
Signed-off-by: Chao Xie
---
drivers/clk/mmp/Makefile |2 +
drivers/clk/mmp/clk-pxa168.c | 402 ++
2 files changed, 404 insertions(+), 0 deletions(-)
create mode 100644
From: Chao Xie
v1->v2:
replace __raw_xxx with xxx_relax
use ioremap to remap the registers. Finaly it will use device tree to
get the physical address.
do not use macro to register clocks, and directly call the functions.
v2->v3:
pxa910 will have APB extension clock, so some peripharals will
Hi all,
Changes since 20120816:
The v4l-dvb tree gained a build failure so I used the version from
next-20120816.
The infiniband tree lost its build failure.
The regulator tree lost its build failure.
The hid tree lost its build failure.
The tip tree still has its build failure so I used
On 08/13/2012 11:22 PM, Minchan Kim wrote:
> Hi Greg,
>
> On Mon, Aug 13, 2012 at 07:35:30PM -0700, Greg Kroah-Hartman wrote:
>> On Wed, Aug 08, 2012 at 03:12:13PM +0900, Minchan Kim wrote:
>>> This patchset promotes zram/zsmalloc from staging.
>>> Both are very clean and zram is used by many
On Thu, Aug 16, 2012 at 12:13 AM, Kasatkin, Dmitry
wrote:
> On Wed, Aug 15, 2012 at 11:16 PM, Serge Hallyn
> wrote:
>> Quoting Dmitry Kasatkin (dmitry.kasat...@intel.com):
>>> IMA measures/appraises modules when modprobe or insmod opens and read them.
>>> Unfortunately, there are no guarantees
Add the device ID for supporting the Macbook Pro 2012 'MacBookPro10,1'.
The bluetooth device presents itself as:
T: Bus=02 Lev=04 Prnt=04 Port=02 Cnt=03 Dev#= 8 Spd=12 MxCh= 0
D: Ver= 2.00 Cls=ff(vend.) Sub=01 Prot=01 MxPS=64 #Cfgs= 1
P: Vendor=05ac ProdID=8286 Rev=00.86
S:
Remove array in parent's platform data. Use struct regulator_init_data
as regulator device's platform data directly. So a lot of pdata are
added into parent's platform data. And voltage out register offset
is used as IORESOURCE_REG to distinguish different regualtor devices.
Signed-off-by:
Remove the register offset definition. All these register offset
are transfered as IORESOURCE_REG resources.
Signed-off-by: Haojian Zhuang
---
drivers/mfd/max8925-core.c | 31 ++---
drivers/video/backlight/max8925_bl.c | 79 ++
2 files
On 8/17/2012 10:51 AM, Prabhakar Lad wrote:
> Hi Laurent,
>
> Thanks for the review.
>
> On Thursday 16 August 2012 08:43 PM, Laurent Pinchart wrote:
>> Hi Prabhakar,
>>
>> Thanks for the patch.
>>
>> On Thursday 16 August 2012 19:32:00 Prabhakar Lad wrote:
>>> From: Lad, Prabhakar
>>>
>>>
The below checkpatch warnings was fixed,
- WARNING: Prefer pr_debug(... to printk(KERN_DEBUG, ...
- WARNING: Prefer pr_warn(... to printk(KERN_WARNING, ...
- WARNING: Prefer pr_info(... to printk(KERN_INFO, ...
- WARNING: Prefer pr_err(... to printk(KERN_ERR, ...
And added pr_fmt.
On 08/16/2012 12:38 PM, Rakesh Jain wrote:
> Hi Marc,
> Is Skype library available for Xtensa Linux port?
> They are available for ARM.
I'd also like to know more about the Skype library.
-piet
> Thanks.
> -Rakesh
>
> -Original Message-
> From: Marc Gauthier [mailto:m...@tensilica.com]
>
* Peter Zijlstra [2012-08-13 09:51:13]:
> On Fri, 2012-08-10 at 21:54 +0530, Srikar Dronamraju wrote:
>
> > This change worked well on the 2 node machine
> > but on the 8 node machine it hangs with repeated messages
> >
> > Pid: 60935, comm: numa01 Tainted: GW
Hi Laurent,
Thanks for the review.
On Thursday 16 August 2012 08:43 PM, Laurent Pinchart wrote:
> Hi Prabhakar,
>
> Thanks for the patch.
>
> On Thursday 16 August 2012 19:32:00 Prabhakar Lad wrote:
>> From: Lad, Prabhakar
>>
>> Signed-off-by: Lad, Prabhakar
>> Signed-off-by: Manjunath Hadli
On Thu, Aug 16, 2012 at 05:21:12PM +0200, Oleg Nesterov wrote:
...
> > So, the arch agnostic code itself
> > takes care of this case...
>
> Yes. I forgot about install_breakpoint()->is_swbp_insn() check which
> returns -ENOTSUPP, somehow I thought arch_uprobe_analyze_insn() does
> this.
>
> >
The below checkpatch warnings was fixed,
-WARNING: Prefer pr_err(... to printk(KERN_ERR, ...
and added pr_fmt.
Signed-off-by: Toshiaki Yamane
---
drivers/staging/vme/devices/vme_pio2_core.c | 10 +-
drivers/staging/vme/devices/vme_user.c | 14 ++
2 files changed,
The below checkpatch warnings was fixed.
-WARNING: Prefer pr_warn(... to printk(KERN_WARNING, ...
Signed-off-by: Toshiaki Yamane
---
drivers/staging/vme/devices/vme_user.c | 36 +---
1 file changed, 14 insertions(+), 22 deletions(-)
diff --git
The below checkpatch warnings was fixed.
-WARNING: Prefer pr_debug(... to printk(KERN_DEBUG, ...
Signed-off-by: Toshiaki Yamane
---
drivers/staging/vme/devices/vme_user.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/vme/devices/vme_user.c
The below checkpatch warnings was fixed,
-WARNING: Prefer pr_info(... to printk(KERN_INFO, ...
and added pr_fmt.
Signed-off-by: Toshiaki Yamane
---
drivers/staging/vme/devices/vme_user.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git
The below checkpatch error was fixed.
-ERROR: trailing whitespace
Signed-off-by: Toshiaki Yamane
---
drivers/staging/vme/devices/vme_user.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vme/devices/vme_user.c
b/drivers/staging/vme/devices/vme_user.c
Hi Andrew,
Today's linux-next merge of the akpm tree got a conflict in
mm/slab_common.c between commit 77be4b1366c9 ("mm/slab: restructure
kmem_cache_create() debug checks") from the slab tree and commit
"mm/slab_common.c: cleanup" from the akpm tree.
Given that this akpm tree patch was applied
From: Michael Wang
This patch set will replace the list_for_each_continue_rcu with the new
interface list_for_each_entry_continue_rcu, so we could remove the old
one later.
Changed:
raid: in "next_active_rdev"
kmemleak: in "kmemleak_seq_next"
netfilter:
From: Michael Wang
This patch replaces list_for_each_continue_rcu() with
list_for_each_entry_continue_rcu() to allow removing
list_for_each_continue_rcu().
Signed-off-by: Michael Wang
---
net/netfilter/core.c | 11 +++
1 files changed, 7 insertions(+), 4 deletions(-)
diff --git
From: Michael Wang
This patch replaces list_for_each_continue_rcu() with
list_for_each_entry_continue_rcu() to save a few lines
of code and allow removing list_for_each_continue_rcu().
Signed-off-by: Michael Wang
---
mm/kmemleak.c |6 ++
1 files changed, 2 insertions(+), 4
From: Michael Wang
This patch replaces list_for_each_continue_rcu() with
list_for_each_entry_continue_rcu() to save a few lines
of code and allow removing list_for_each_continue_rcu().
Signed-off-by: Michael Wang
---
drivers/md/bitmap.c |9 +++--
1 files changed, 3 insertions(+), 6
dpm_list and its pm lock provide a good way to iterate all
devices in system. Except this way, there is no other easy
way to iterate devices in system.
firmware loader need to cache firmware images for devices
before system sleep, so introduce the function to meet its
demand.
Reported-by:
_pm_unlock" [drivers/base/firmware_class.ko] undefined!
Caused by commit 37276a51f803 ("firmware: introduce
device_cache/uncache_fw_images").
I have used the driver-core tree from next-20120816 for today.
--
Cheers,
Stephen Rothwells...@canb.auug.org.au
pgpK0EQqSrysJ.pgp
Description: PGP signature
On 16 August 2012 17:11, Amit Daniel Kachhap wrote:
> Add necessary default platform data support needed for TMU driver. The
> supplied dt/non-dt values are tested for origen exynos4210 and smdk exynos5250
> platforms and only compile tested for exynos4412.
>
> Signed-off-by: Amit Daniel Kachhap
On Fri, Aug 17, 2012 at 10:00:46AM +0800, Fengguang Wu wrote:
> On Sun, Aug 05, 2012 at 09:58:26AM -0700, Greg KH wrote:
> > On Sun, Aug 05, 2012 at 10:59:38AM +0800, Fengguang Wu wrote:
> > > Hi all,
> > >
> > > This line triggers an oops in kvm boot test:
> > >
> > > usb_match_id():
> > > ==>
On 16 August 2012 20:22, Valentin, Eduardo wrote:
>
> Amit,
>
> Thanks again for keeping this up.
>
> On Thu, Aug 16, 2012 at 2:41 PM, Amit Daniel Kachhap
> wrote:
> > This patchset introduces a new generic cooling device based on cpufreq
> > that can be used on non-ACPI platforms. As a proof
On Fri, Aug 17, 2012 at 09:54:56AM +0800, Ming Lei wrote:
> On Fri, Aug 17, 2012 at 9:45 AM, Ming Lei wrote:
> > diff --git a/include/linux/pm.h b/include/linux/pm.h
> > index 44d1f23..bf86f89 100644
> > --- a/include/linux/pm.h
> > +++ b/include/linux/pm.h
> > @@ -640,6 +640,7 @@ extern void
3.2-stable review patch. If anyone has any objections, please let me know.
--
From: Alan Cox
[ Upstream commit 8b72ff6484fe303e01498b58621810a114f3cf09 ]
gcc really should warn about these !
Signed-off-by: Alan Cox
Signed-off-by: David S. Miller
Signed-off-by: Ben
3.2-stable review patch. If anyone has any objections, please let me know.
--
From: Michael Chan
[ Upstream commit c1f5163de417dab01fa9daaf09a74bbb19303f3c ]
In rare cases, bnx2x_free_tx_skbs() can unmap the wrong DMA address
when it gets to the last entry of the tx ring. We
3.2-stable review patch. If anyone has any objections, please let me know.
--
From: Jiri Kosina
[ Upstream commit 59ea33a68a9083ac98515e4861c00e71efdc49a1 ]
Back in 2006, commit 1a2449a87b ("[I/OAT]: TCP recv offload to I/OAT")
added support for receive offloading to IOAT dma
3.2-stable review patch. If anyone has any objections, please let me know.
--
From: Stefan Bader
Based on commit fee84b079d5ddee2247b5c1f53162c330c622902 upstream.
Intercept RDPMC and forward it to the PMU emulation code.
Newer vmx support will only allow to load the
3.2-stable review patch. If anyone has any objections, please let me know.
--
From: Janne Kalliomäki
commit a6dc8c04218eb752ff79cdc24a995cf51866caed upstream.
The variable io_size was unsigned int, which caused the wrong sector number
to be calculated after aligning it. This
3.2-stable review patch. If anyone has any objections, please let me know.
--
From: Sjur Brændeland
[ Upstream commit 96f80d123eff05c3cd4701463786b87952a6c3ac ]
unregister_netdevice_notifier() must be called before
unregister_pernet_subsys() to avoid accessing already freed
3.2-stable review patch. If anyone has any objections, please let me know.
--
From: Jiri Benc
[ Upstream commit b1beb681cba5358f62e6187340660ade226a5fcc ]
When device flags are set using rtnetlink, IFF_PROMISC and IFF_ALLMULTI
flags are handled specially. Function
3.2-stable review patch. If anyone has any objections, please let me know.
--
From: Daniel Vetter
commit 53d227f282eb9fa4c7cdbfd691fa372b7ca8c4c3 upstream.
Currently we reserve seqnos only when we emit the request to the ring
(by bumping dev_priv->next_seqno), but start using
3.2-stable review patch. If anyone has any objections, please let me know.
--
From: Jerome Glisse
commit 81ee8fb6b52ec69eeed37fe7943446af1dccecc5 upstream.
It seems we can not update the crtc scanout address. After disabling
crtc, update to base address do not take effect
3.2-stable review patch. If anyone has any objections, please let me know.
--
From: Larry Finger
commit 3ce4d85b76010525adedcc2555fa164bf706a2f3 upstream.
In commit a7959c1, the USB part of rtlwifi was switched to convert
_usb_read_sync() to using a preallocated buffer rather
3.2-stable review patch. If anyone has any objections, please let me know.
--
From: Dean Nelson
commit b868179c47e9e8eadcd04c1f3105998e528988a3 upstream.
Commit d5bc77a223b0e9b9dfb002048d2b34a79e7d0b48 broke Wake-on-LAN by
inadvertently dropping the enabling of DMA receives.
3.2-stable review patch. If anyone has any objections, please let me know.
--
From: Paul Moore
[ Upstream commit 89d7ae34cdda4195809a5a987f697a517a2a3177 ]
As reported by Alan Cox, and verified by Lin Ming, when a user
attempts to add a CIPSO option to a socket using the
3.2-stable review patch. If anyone has any objections, please let me know.
--
From: Alex Deucher
commit 5b23c9045a8b61352986270b2d109edf5085e113 upstream.
Handle the 16 bank case.
Signed-off-by: Alex Deucher
[bwh: Backported to 3.2: adjust context, indentation]
3.2-stable review patch. If anyone has any objections, please let me know.
--
From: Alex Deucher
commit c8d15edc17d836686d1f071e564800e1a2724fa6 upstream.
Handle the 16 bank case.
Signed-off-by: Alex Deucher
Signed-off-by: Ben Hutchings
---
3.2-stable review patch. If anyone has any objections, please let me know.
--
From: Dan Carpenter
[ Upstream commit e4c7f259c5be99dcfc3d98f913590663b0305bf8 ]
The problem is that we call this with a spin lock held. The call tree
is:
kaweth_start_xmit() holds
3.2-stable review patch. If anyone has any objections, please let me know.
--
From: Neil Horman
[ Upstream commit 2eebc1e188e9e45886ee00662519849339884d6d ]
A few days ago Dave Jones reported this oops:
[22766.294255] general protection fault: [#1] PREEMPT SMP
3.2-stable review patch. If anyone has any objections, please let me know.
--
From: Daniel Vetter
commit 0d8957c8a90bbb5d34fab9a304459448a5131e06 upstream.
We may only start to set up the new register values after having
confirmed that the ring is truely off. Otherwise the hw
3.2-stable review patch. If anyone has any objections, please let me know.
--
From: Heiko Carstens
commit 82aabdb6f1eb61e0034ec23901480f5dd23db7c4 upstream.
The compat wrappers incorrectly called the non compat versions of
the system process_vm system calls.
Signed-off-by:
3.2-stable review patch. If anyone has any objections, please let me know.
--
From: Heiko Carstens
commit e85871218513c54f7dfdb6009043cb638f2fecbe upstream.
The native 31 bit and the compat behaviour for the mmap system calls differ:
In native 31 bit mode the passed in
3.2-stable review patch. If anyone has any objections, please let me know.
--
From: Arnd Bergmann
commit 4eef6cbfcc03b294d9d334368a851b35b496ce53 upstream.
The EETI touchscreen asserts its IRQ line as soon as it has data in its
internal buffers. The line is automatically
3.2-stable review patch. If anyone has any objections, please let me know.
--
From: David Henningsson
commit 012e7eb1e501d0120e0383b81477f63091f5e365 upstream.
The same ID is twice in the quirk table, so the second one is not used.
Signed-off-by: David Henningsson
3.2-stable review patch. If anyone has any objections, please let me know.
--
From: Stanislav Kinsbursky
commit 66d1b9263a371abd15806c53f486f0645ef31a8f upstream.
This is a fix for bug, introduced in 3.4 kernel by commit
1ab5ecb90cb6a3df1476e052f76a6e8f6511cb3d ("tun: don't
3.2-stable review patch. If anyone has any objections, please let me know.
--
From: Arnd Bergmann
commit 59ee93a528b94ef4e81a08db252b0326feff171f upstream.
The irq_to_gpio function was removed from the pxa platform
in linux-3.2, and this driver has been broken since.
There
3.2-stable review patch. If anyone has any objections, please let me know.
--
From: "Philipp A. Mohrenweiser"
commit 4407be6ba217514b1bc01488f8b56467d309e416 upstream.
Add a model/fixup string "lenovo-dock", for Thinkpad T430s, to allow
sound in docking station.
Tested on
3.2-stable review patch. If anyone has any objections, please let me know.
--
From: David Henningsson
commit e9fc83cb2e5877801a255a37ddbc5be996ea8046 upstream.
This computer is confirmed working with model=auto on kernel 3.2.
Also, parsing fails with hda-emu with the current
3.2-stable review patch. If anyone has any objections, please let me know.
--
From: Johannes Berg
commit dd4c9260e7f23f2e951cbfb2726e468c6d30306c upstream.
The mesh path timer needs to be canceled when
leaving the mesh as otherwise it could fire
after the interface has been
On Thu, Aug 16, 2012 at 11:10 PM, Greg KH wrote:
> On Fri, Aug 10, 2012 at 12:29:43AM -0700, anish kumar wrote:
>> From: anish kumar
>>
>> External connector devices that decides connection information based on
>> ADC values may use adc-jack device driver. The user simply needs to
>> provide a
3.2-stable review patch. If anyone has any objections, please let me know.
--
From: Tushar Dave
commit b7ec70be01a87f2c85df3ae11046e74f9b67e323 upstream.
Found that commit d478eb44 was a bad commit.
If the link partner is transmitting codeword (even if NULL codeword),
then
3.2-stable review patch. If anyone has any objections, please let me know.
--
From: Stanislaw Gruszka
commit deee0214def5d8a32b8112f11d9c2b1696e9c0cb upstream.
We can not pass NULL libconf->conf->channel to rt61pci_config() as it
is dereferenced unconditionally in
3.2-stable review patch. If anyone has any objections, please let me know.
--
From: Johannes Berg
commit 50e2a30cf6fcaeb2d27360ba614dd169a10041c5 upstream.
There's a bug that causes the rate scaling to get stuck
when it has to use single-stream rates with a peer that
can do
3.2-stable review patch. If anyone has any objections, please let me know.
--
From: Mohammed Shafi Shajakhan
commit d4e5979c0da95791aa717c18e162540c7a596360 upstream.
AR is same as AR9485. The h/w
difference between them is quite insignificant,
Felix suggests only very
3.2-stable review patch. If anyone has any objections, please let me know.
--
From: Marek Vasut
commit 3bed491c8d28329e34f8a31e3fe64d03f3a350f1 upstream.
The CONFIG_DEFAULT_MMAP_MIN_ADDR was set to 65536 in mxs_defconfig,
this caused severe breakage of userland applications
3.2-stable review patch. If anyone has any objections, please let me know.
--
From: Daniel Drake
commit 1f6fc43e621167492ed4b7f3b4269c584c3d6ccc upstream.
libertas currently calls cfg80211_disconnected() when it is being
brought down. This causes an event to be allocated, but
3.2-stable review patch. If anyone has any objections, please let me know.
--
From: Felix Kaechele
commit c8415a48fcb7a29889f4405d38c57db351e4b50a upstream.
As with the ThinkPad Models X230 Tablet and T530 the X230 needs a qurik to
correctly set up the pins for the dock port.
3.2-stable review patch. If anyone has any objections, please let me know.
--
From: Hangbin Liu
[ Upstream commit 42493570100b91ef663c4c6f0c0fdab238f9d3c2 ]
TCP_USER_TIMEOUT is a TCP level socket option that takes an unsigned int. But
patch "tcp: Add TCP_USER_TIMEOUT socket
3.2-stable review patch. If anyone has any objections, please let me know.
--
From: Alan Cox
[ Upstream commit c66b9b7d365444b433307ebb18734757cb668a02 ]
Reported-by:
Resolves-bug: http://bugzilla.kernel.org/show_bug?1
Signed-off-by: Alan Cox
Signed-off-by: David S.
3.2-stable review patch. If anyone has any objections, please let me know.
--
From: Mathias Krause
[ Upstream commits a117dacde0288f3ec60b6e5bcedae8fa37ee0dfc
and 8bbb181308bc348e02bfdbebdedd4e4ec9d452ce ]
The tun module leaks up to 36 bytes of memory by not fully
3.2-stable review patch. If anyone has any objections, please let me know.
--
From: Alan Cox
[ Upstream commit 7ac2908e4b2edaec60e9090ddb4d9ceb76c05e7d ]
Resolves-bug: https://bugzilla.kernel.org/show_bug.cgi?id=44461
Signed-off-by: Alan Cox
Acked-by: Eric Dumazet
This is the start of the stable review cycle for the 3.2.28 release.
There are 37 patches in this series, which will be posted as responses
to this one. If anyone has any issues with these being applied, please
let me know.
Responses should be made by Sun Aug 19 10:00:00 UTC 2012.
Anything
On Thu, Aug 16, 2012 at 08:37:21PM -0600, Jim Cromie wrote:
> 2 trivial patches here, suitable for 3.6:
> - fix spelling error in comment s/control/control
That's not for 3.6, that's 3.7, at the earliest.
> - add write size attempted to log warning issued for E2BIG error
Same here.
greg k-h
--
From: Ian Kent
In some cases when an autofs indirect mount is contained in a file
system that is marked as shared (such as when systemd does the
equivalent of "mount --make-rshared /" early in the boot), mounts
stop expiring.
When this happens the first expiry check on a mountpoint dentry in
On Fri, Aug 17, 2012 at 10:44:37AM +0800, Ming Lei wrote:
> On Fri, Aug 17, 2012 at 10:29 AM, Fengguang Wu wrote:
>
> >
> > Something obviously wrong here:
> >
> > env->buflen == 12
> > env->envp_idx == 1627389952
> > env->env[0] == NULL
> >
> > I'm not sure where it
Convert this PCI driver to use the comedi PCI auto config attach
mechanism by adding an 'attach_pci' callback function. Since the
driver does not require any external configuration options, and
the legacy 'attach' callback is now optional, remove it.
Signed-off-by: H Hartley Sweeten
Cc: Ian
This driver uses the 'attach_pci' callback to attach the pci device
to the comedi subsystem. Since the 'attach' callback is now optional
it can be removed from the driver.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/dyna_pci10xx.c
Convert this PCI driver to use the comedi PCI auto config attach
mechanism by adding an 'attach_pci' callback function.
This driver does use an external configuration option to determine
the analog output range which is controlled by a jumper on the board.
In order to remove the legacy 'attach'
Use the register map define to work out the i/o address.
Cleanup the comments about the simultaneous transfer mode for
the analog outputs.
Change the return to 'insn->n', the comedi core expects the return
to be the number of data elements used. Technically the 'i' value
is correct but 'insn->n'
Remove the cut-and-paste comment from the skel driver and for
aesthetic reasons, move the #define out of the struct.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/cb_pcimdda.c | 11 ++-
1 file changed, 2 insertions(+), 9
The attach function only allocated 2 subdevices, an analog output
sundevice (index 0) and the 8255 dio subdevice (index 1). The
detach function is passing the wrong subdevice (index 2) to the
subdev_8255_cleanup function which will result in a bug when
it tries to do the kfree(s->private).
The attached_to_8255 variable in the private data is used as a flag
to indicate that the 8255 subdevice has been initialized. The call
to subdev_8255_cleanup only requires that the dev->subdevices pointer
is valid. Change the test in the detach function and remove the
attached_to_8255 variable.
The boardinfo struct and associated code is no longer needed
by this driver. Remove it.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/cb_pcimdda.c | 38 ++---
1 file changed, 8 insertions(+), 30 deletions(-)
This board always has 6, 16-bit analog outputs. There is no need to carry
this information in the boardinfo. Remove it.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/cb_pcimdda.c | 8 ++--
1 file changed, 2 insertions(+), 6
The base address of the card is always found in pci resource 3. There is
no need to carry this information in the boardinfo. The reg_sz is not
used in the driver. Remove them.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
The 8255 device is located at a fixed offset from the base
address of the card. There is not need to carry this offset
in the boardinfo. Remove it.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/cb_pcimdda.c | 5 +
1 file changed,
Add defines for the register map of the card.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/cb_pcimdda.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/staging/comedi/drivers/cb_pcimdda.c
The cards supported by this driver always have 8255 compatible
device. Remove the dio_chans variable from the private data and
always initialize the 8255 subdevice.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/cb_pcimdda.c | 16
The digital i/o on this card is handled by an 8255 compatible
device. There are not other options. Remove the DIO_METHODS
enum as well as the dio_method variable in the boardinfo and
the code dealing with it.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
The dio_registers variable in the private data is only used to
pass the base address to the 8255 subdevice. Remove the variable
from the private data and pass the value directly to the
subdev_8255_init() function.
Make sure to check the return from subdev_8255_init(). That
function can fail. For
Use the hw_dev pointer in the comed_device struct to hold the
pci_dev instead of carrying it in the private data.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/cb_pcimdda.c | 18 --
1 file changed, 8 insertions(+), 10
Make cb_pcimdda_probe() return the pointer to the found pci_dev
and move the comedi_pci_enable() call into the 'attach' function.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/cb_pcimdda.c | 62 -
1 file
Use dev->iobase for the pci i/o address instead of carrying it
in the private data.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/cb_pcimdda.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git
The structs, static data, and functions in this driver have
pretty generic names. Add namespace to everything to prevent
any problems.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/cb_pcimdda.c | 66 ++---
1
Move a couple of the functions in order to remove the need for
the forward declarations.
Also, remove the unnecessary comments.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/cb_pcimdda.c | 241 +++-
1 file
These macros rely on a local variable having a specific name.
Remove them and use the comedi_board() helper to get the thisboard
pointer.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/cb_pcimdda.c | 33 -
The REG_SZ macro isn't being use. Both macros use the 'thisboard'
macro which relys on a local variable having a specific name.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/cb_pcimdda.c | 5 +
1 file changed, 1 insertion(+), 4
Convert this PCI driver to use the comedi PCI auto config attach
mechanism by adding an 'attach_pci' callback function. Since the
driver does not require any external configuration options, and
the legacy 'attach' callback is now optional, remove it.
Signed-off-by: H Hartley Sweeten
Cc: Ian
Move a couple of the functions in order to remove the need for
the forward declarations.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/cb_pcimdas.c | 240 +---
1 file changed, 112 insertions(+), 128
These macros rely on a local variable having a specific name.
Remove them and use the comedi_board() helper to get the thisboard
pointer.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/cb_pcimdas.c | 27 +++
1
Convert this PCI driver to use the comedi PCI auto config attach
mechanism by adding an 'attach_pci' callback function. Since the
driver does not require any external configuration options, and
the legacy 'attach' callback is now optional, remove it.
Signed-off-by: H Hartley Sweeten
Cc: Ian
Move a couple of the functions in order to remove the need for
the forward declarations.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/cb_pcidda.c | 389 ++---
1 file changed, 184 insertions(+), 205
These macros rely on a local variable having a specific name.
Remove them and use the comedi_board() helper to get the thisboard
pointer.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/cb_pcidda.c | 29 +
1
1 - 100 of 1574 matches
Mail list logo
