Re: [PATCH] staging: sm750fb: braces, indents, spaces fix

2015-03-12 Thread Sudip Mukherjee
On Thu, Mar 12, 2015 at 10:14:36PM -0700, Ragavendra BN wrote: > This patch removes the braces for the single line if statement. It fixes > the indent positions correctly. It fixes the spaces appropriately making the > code give no > warnings by the checpath.pl script check. your From: is still

Re: [PATCH v5] media: i2c: add support for omnivision's ov2659 sensor

2015-03-12 Thread Lad, Prabhakar
Hi Sakari, Thanks for the review. On Fri, Mar 13, 2015 at 12:04 AM, Sakari Ailus wrote: > Hi Prabhakar, > > On Thu, Mar 12, 2015 at 11:22:36PM +, Lad Prabhakar wrote: > ... >> +static int ov2659_probe(struct i2c_client *client, >> + const struct i2c_device_id *id) >> +{

Re: FW: [PATCH v2] mtd:spi-nor: Add Altera EPCQ Driver

2015-03-12 Thread Rafał Miłecki
On 11 March 2015 at 09:41, Viet Nga Dao wrote: > On Tue, Mar 10, 2015 at 4:09 PM, Viet Nga Dao wrote: >> Ok. I will modify the code the way you suggest. > > I just realize that the opcode for RDID is handled by hardware in my > case, therefore i dont really need to worry about 0xab opcode. Nice

[LKP] [locking/rwsem] b3fd4f03ca0: -11.1% vm-scalability.throughput

2015-03-12 Thread Huang Ying
Sorry for duplicated email. Forget to send to the patch author. FYI, we noticed the below changes on git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master commit b3fd4f03ca0b9952221f39ae6790e698bf4b39e7 ("locking/rwsem: Avoid deceiving lock spinners")

Re: linux-next: build warning after merge of the virtio tree

2015-03-12 Thread Rusty Russell
Stephen Rothwell writes: > Hi Rusty, > > After merging the virtio tree, today's linux-next build (x86_64 > allmodconfig) produced this warning: > > net/9p/trans_virtio.c: In function 'p9_virtio_remove': > net/9p/trans_virtio.c:662:7: warning: unused variable 'inuse' > [-Wunused-variable] >

[LKP] [locking/rwsem] b3fd4f03ca0: -11.1% vm-scalability.throughput

2015-03-12 Thread Huang Ying
FYI, we noticed the below changes on git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master commit b3fd4f03ca0b9952221f39ae6790e698bf4b39e7 ("locking/rwsem: Avoid deceiving lock spinners") testbox/testcase/testparams: brickland3/vm-scalability/performance-300s-small-allocs

linux-next: manual merge of the akpm-current tree with the vfs tree

2015-03-12 Thread Stephen Rothwell
Hi Andrew, Today's linux-next merge of the akpm-current tree got a conflict in lib/Makefile between commit d879cb83417a ("move iov_iter.c from mm/ to lib/") from the vfs tree and commits 2e731a72801a ("lib: move find_last_bit to lib/find_next_bit.c") and 2bbf16381c7a ("lib: rename

linux-next: manual merge of the akpm-current tree with the vfs tree

2015-03-12 Thread Stephen Rothwell
Hi Andrew, Today's linux-next merge of the akpm-current tree got a conflict in fs/fat/inode.c between commit 3737c63e1fb0 ("fs: move struct kiocb to fs.h") from the vfs tree and commit be33247df543 ("fs/fat: remove unnecessary includes") from the akpm-current tree. I fixed it up (see below) and

[PATCH v3] perf probe: Find compilation directory path for lazy matching

2015-03-12 Thread Naohiro Aota
If we use lazy matching, it failed to open a souce file if perf command is invoked outside of compilation directory: $ perf probe -a '__schedule;clear_*' Failed to open kernel/sched/core.c: No such file or directory Error: Failed to add events. (-2) OTOH, other commands like "probe -L" can

Re: Re: [PATCH v2] perf probe: Find compilation directory path for lazy matching

2015-03-12 Thread Naohiro Aota
On Thu, Mar 12, 2015 at 10:42 AM, Masami Hiramatsu wrote: > (2015/03/11 22:30), Arnaldo Carvalho de Melo wrote: >> Em Wed, Mar 04, 2015 at 09:34:38PM +0900, Masami Hiramatsu escreveu: >>> (2015/03/04 16:52), Naohiro Aota wrote: If we use lazy matching, it failed to open a souce file if perf

Re: [RFC PATCH] Don't reset timestamps in include/generated if not needed

2015-03-12 Thread Masahiro Yamada
Hi. 2015-03-11 19:01 GMT+09:00 Michal Marek : > On Sun, Mar 08, 2015 at 04:08:06PM -0700, Linus Torvalds wrote: >> On Tue, Mar 3, 2015 at 5:07 PM, Valdis Kletnieks >> wrote: >> > >> > Kbuild regenerates bounds.h and asm-offsets.h, resetting the timestamps >> > and forcing rebuilds even if the

Re: [PATCH] staging: sm750fb: braces, indents, spaces fix

2015-03-12 Thread Sudip Mukherjee
On Thu, Mar 12, 2015 at 08:43:33PM -0700, Ragavendra BN wrote: > Signed-off-by: Ragavendra BN > > This patch removes the braces for the single line if statement. It fixes > the indent positions correctly. It fixes the spaces appropriately making the > code give no > warnings by the checkpath.pl

Re: [RFC PATCH] PCI: Disable MSI/MSI-X only if device is shutdown

2015-03-12 Thread Fam Zheng
On Thu, 03/12 22:13, Alex Williamson wrote: > On Thu, 2015-03-12 at 23:09 -0400, Bandan Das wrote: > > Ccing Alex, he can probably confirm if my understanding is indeed correct. > > > > Fam Zheng writes: > > > > > On Thu, 03/12 19:56, Bandan Das wrote: > > >> Hi Fam, > > >> > > >> Fam Zheng

[rfc patch v2] rt,nohz_full: fix nohz_full for PREEMPT_RT_FULL

2015-03-12 Thread Mike Galbraith
First of all, a task being ticked and trying to shut the tick down will fail to do so due to having just awakened ksoftirqd, so let ksoftirqd try to do that after SOFTIRQ_TIMER processing. Secondly, should the tick be shut down, we may livelock in hrtimer-cancel() because in -rt a callback may

Re: [PATCH] perf: fix put_event() ctx leak

2015-03-12 Thread Leon Yu
On Thu, Feb 26, 2015 at 8:43 PM, Leon Yu wrote: > > Commit a83fe28e2e45 ("perf: Fix put_event() ctx lock") changed lock logic in > put_event() by replacing mutex_lock_nested() with > perf_event_ctx_lock_nested(), > but didn't fix subsequent mutex_unlock() with correct counterpart, >

Re: [PATCH 01/16] staging: rtl8723au: Reformat whitespace to increase readability

2015-03-12 Thread Sudip Mukherjee
On Thu, Mar 12, 2015 at 11:15:17PM -0400, M. Vefa Bicakci wrote: > Adjust the whitespace in the local variable declaration and initialization > part of a number of functions to increase readability in rtl8723au's > rtw_security.c. > > Signed-off-by: M. Vefa Bicakci you have not added the

Re: linux-next: manual merge of the net-next tree with the vfs tree

2015-03-12 Thread David Miller
From: Al Viro Date: Fri, 13 Mar 2015 03:56:09 + > On Thu, Mar 12, 2015 at 11:24:26PM -0400, David Miller wrote: >> From: Stephen Rothwell >> Date: Fri, 13 Mar 2015 13:15:43 +1100 >> >> > Today's linux-next merge of the net-next tree got a conflict in >> > net/socket.c between commits

Re: vvar, gup && coredump

2015-03-12 Thread Sergio Durigan Junior
On Thursday, March 12 2015, Oleg Nesterov wrote: >> If I understood this discussion correctly (and thanks Andy and Oleg for, >> *ahem*, dumping all this useful information for us!), GDB will not need >> modifications in the Linux kernel in this area. In fact, my patch >> already implements the

Re: [PATCH RT 00/39] Linux 3.14.34-rt32-rc1

2015-03-12 Thread Mike Galbraith
On Thu, 2015-03-12 at 15:13 -0400, Steven Rostedt wrote: > Dear RT Folks, > > This is the RT stable review cycle of patch 3.14.34-rt32-rc1. > > Please scream at me if I messed something up. Hm, in both 12/14 series, 21/N went on a walkabout. -- To unsubscribe from this list: send the line

Re: [PATCH v6 3/3] ARM: dts: vf610: add Miscellaneous System Control Module (MSCM)

2015-03-12 Thread Shawn Guo
On Thu, Mar 12, 2015 at 10:03:08AM +0100, Stefan Agner wrote: > On 2015-03-11 01:48, Shawn Guo wrote: > > On Sun, Mar 01, 2015 at 11:41:29PM +0100, Stefan Agner wrote: > >> Add the Miscellaneous System Control Module (MSCM) to the base > >> device tree for Vybrid SoC's. This module contains

Re: [PATCH] arm64: Enable CONFIG_COMPAT also for 64k page size

2015-03-12 Thread Jon Masters
On 12/05/2014 06:14 AM, Catalin Marinas wrote: > On Thu, Dec 04, 2014 at 09:15:12PM +, Olof Johansson wrote: >> On Thu, Dec 4, 2014 at 7:46 AM, Alexander Graf wrote: >>> With binutils 2.25 the default alignment for 32bit arm sections changed to >>> have everything 64k aligned. Armv7 binaries

Re: linux-next: manual merge of the net-next tree with the vfs tree

2015-03-12 Thread Stephen Rothwell
Hi Al, On Fri, 13 Mar 2015 03:56:09 + Al Viro wrote: > > On Thu, Mar 12, 2015 at 11:24:26PM -0400, David Miller wrote: > > From: Stephen Rothwell > > Date: Fri, 13 Mar 2015 13:15:43 +1100 > > > > > Today's linux-next merge of the net-next tree got a conflict in > > > net/socket.c between

linux-next: build warning after merge of the virtio tree

2015-03-12 Thread Stephen Rothwell
Hi Rusty, After merging the virtio tree, today's linux-next build (x86_64 allmodconfig) produced this warning: net/9p/trans_virtio.c: In function 'p9_virtio_remove': net/9p/trans_virtio.c:662:7: warning: unused variable 'inuse' [-Wunused-variable] bool inuse; ^ Introduced by commit

Re: [RFC PATCH] PCI: Disable MSI/MSI-X only if device is shutdown

2015-03-12 Thread Alex Williamson
On Thu, 2015-03-12 at 23:09 -0400, Bandan Das wrote: > Ccing Alex, he can probably confirm if my understanding is indeed correct. > > Fam Zheng writes: > > > On Thu, 03/12 19:56, Bandan Das wrote: > >> Hi Fam, > >> > >> Fam Zheng writes: > >> > >> > If the device doesn't support shutdown,

Re: [PATCH 1/4 V2] ocfs2: use retval instead of status for checking error

2015-03-12 Thread DaeSeok Youn
Hi, This patch have been pending for 2 weeks. Do I need to check other things? please, check for me. Thanks! regards, Daeseok Youn 2015-02-28 8:48 GMT+09:00 Daeseok Youn : > The use of 'status' in __ocfs2_add_entry() can return wrong > status when some functions are failed. > > If

Re: linux-next: manual merge of the net-next tree with the vfs tree

2015-03-12 Thread Al Viro
On Thu, Mar 12, 2015 at 11:24:26PM -0400, David Miller wrote: > From: Stephen Rothwell > Date: Fri, 13 Mar 2015 13:15:43 +1100 > > > Today's linux-next merge of the net-next tree got a conflict in > > net/socket.c between commits 005139a14660 ("fs: remove ki_nbytes") and > > e9eab93cc2dc ("fs:

[PATCH 2/7 v3] blk-mq: add blk_mq_init_allocated_queue and export blk_mq_register_disk

2015-03-12 Thread Mike Snitzer
Add a variant of blk_mq_init_queue that allows a previously allocated queue to be initialized. blk_mq_init_allocated_queue models blk_init_allocated_queue -- which was also created for DM's use. DM's approach to device creation requires a placeholder request_queue be allocated for use with

[PATCH 1/7 v3] blk-mq: fix use of incorrect goto label in blk_mq_init_queue error path

2015-03-12 Thread Mike Snitzer
If percpu_ref_init() fails the allocated q and hctxs must get cleaned up; using 'err_map' doesn't allow that to happen. Signed-off-by: Mike Snitzer Reviewed-by: Ming Lei --- block/blk-mq.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/block/blk-mq.c b/block/blk-mq.c

[PATCH] staging: sm750fb: braces, indents, spaces fix

2015-03-12 Thread Ragavendra BN
Signed-off-by: Ragavendra BN This patch removes the braces for the single line if statement. It fixes the indent positions correctly. It fixes the spaces appropriately making the code give no warnings by the checkpath.pl script check. --- drivers/staging/sm750fb/ddk750_chip.c | 22

[PATCH 09/16] staging: rtl8723au: trailing statements should be on next line

2015-03-12 Thread M. Vefa Bicakci
Correct a number of checkpatch.pl errors in rtl8723au's rtw_security.c related to trailing statements: ERROR: trailing statements should be on next line Signed-off-by: M. Vefa Bicakci --- drivers/staging/rtl8723au/core/rtw_security.c | 25 + 1 file changed, 17

[PATCH 06/16] staging: rtl8723au: Do not initialize a static to 0

2015-03-12 Thread M. Vefa Bicakci
Prior to this commit, a static integer named bcrc32initialized in rtl8723au's rtw_security.c was explicitly initialized to zero, even though this is not necessary. Remove the unneeded initialization. Signed-off-by: M. Vefa Bicakci --- drivers/staging/rtl8723au/core/rtw_security.c | 2 +- 1 file

[PATCH 11/16] staging: rtl8723au: No spaces at the start of a line

2015-03-12 Thread M. Vefa Bicakci
Prior to this commit, a large block of constants used to represent an AES S-box table were indented with spaces in rtl8723au's rtw_security.c. Correct the checkpatch.pl warnings indicating that spaces should not be used to indent lines: WARNING: please, no spaces at the start of a line

[PATCH 00/16] checkpatch clean-up of rtl8723au's rtw_security.c

2015-03-12 Thread M. Vefa Bicakci
These commits address a number of checkpatch.pl warnings and errors in rtl8723au's rtw_security.c. Prior to this set of commits, checkpatch.pl reported the following: total: 77 errors, 138 warnings, 1621 lines checked After applying this set of commits, checkpatch.pl reports the

[PATCH 04/16] staging: rtl8723au: Fix the indentation of two lines

2015-03-12 Thread M. Vefa Bicakci
Correct the indentation of two lines in rtw_tkip_encrypt23a function in rtl8723au's rtw_security.c. Signed-off-by: M. Vefa Bicakci --- drivers/staging/rtl8723au/core/rtw_security.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 16/16] staging: rtl8723au: Remove unneeded comments

2015-03-12 Thread M. Vefa Bicakci
This commit removes a number of unneeded comments. Two of the aforementioned comments were most likely meant to aid with version control, whereas the remaining two comments relate to (now unused) local variable names. Signed-off-by: M. Vefa Bicakci ---

[PATCH 15/16] staging: rtl8723au: Correct a typo in a trace log line

2015-03-12 Thread M. Vefa Bicakci
Correct a typo in rtl8723au's rtw_security.c which was most likely caused by a copy and paste mistake. Prior to this commit, the TKIP decryption function referred to WEP in its trace log output. Signed-off-by: M. Vefa Bicakci --- drivers/staging/rtl8723au/core/rtw_security.c | 2 +- 1 file

[PATCH 08/16] staging: rtl8723au: Remove unneeded curly braces

2015-03-12 Thread M. Vefa Bicakci
Correct a number of checkpatch.pl warnings in rtl8723au's rtw_security.c related to the existence of unnecessary curly braces around single statement blocks: WARNING: braces {} are not necessary for single statement blocks Signed-off-by: M. Vefa Bicakci ---

[PATCH 12/16] staging: rtl8723au: Adjust whitespace in and around comments

2015-03-12 Thread M. Vefa Bicakci
As the subject indicates, adjust whitespace in and around comments in rtl8723au's rtw_security.c. Signed-off-by: M. Vefa Bicakci --- drivers/staging/rtl8723au/core/rtw_security.c | 114 +- 1 file changed, 57 insertions(+), 57 deletions(-) diff --git

[PATCH 02/16] staging: rtl8723au: Fix "before/around/after" whitespace issues

2015-03-12 Thread M. Vefa Bicakci
Correct a number of "space(s) required before/around/after" checkpatch.pl issues in a number of functions in rtl8723au's rtw_security.c. Signed-off-by: M. Vefa Bicakci --- drivers/staging/rtl8723au/core/rtw_security.c | 173 +- 1 file changed, 86 insertions(+), 87

[PATCH 07/16] staging: rtl8723au: else is not generally useful after a return

2015-03-12 Thread M. Vefa Bicakci
Correct a checkpatch.pl warning regarding rtl8723au's rtw_security.c::crc32_init pointing out that having an else statement after a break or a return is not useful. drivers/staging/rtl8723au/core/rtw_security.c:105: WARNING: else is not generally useful after a break or return

[PATCH 14/16] staging: rtl8723au: Improve readability of two very long lines

2015-03-12 Thread M. Vefa Bicakci
Improve the readability of an if statement and its very long trace output line in rtl8723au's rtw_security.c. Signed-off-by: M. Vefa Bicakci --- drivers/staging/rtl8723au/core/rtw_security.c | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git

[PATCH 03/16] staging: rtl8723au: else should follow close brace

2015-03-12 Thread M. Vefa Bicakci
Correct checkpatch.pl errors in rtl8723au's rtw_security.c indicating that an else statement should follow the closing brace of the previous if/else if code block: ERROR: else should follow close brace '}' Signed-off-by: M. Vefa Bicakci --- drivers/staging/rtl8723au/core/rtw_security.c

[PATCH 10/16] staging: rtl8723au: that open brace should be on the previous line

2015-03-12 Thread M. Vefa Bicakci
Correct two instances of the checkpatch.pl error indicating that the opening curly braces should not be on new lines: ERROR: that open brace { should be on the previous line Signed-off-by: M. Vefa Bicakci --- drivers/staging/rtl8723au/core/rtw_security.c | 6 ++ 1 file changed, 2

[PATCH 13/16] staging: rtl8723au: suspect code indent for conditional statements

2015-03-12 Thread M. Vefa Bicakci
Correct a number of indentation-with-spaces-and-tabs issues in rtl8723au's rtw_security.c, according to checkpatch.pl: WARNING: suspect code indent for conditional statements Signed-off-by: M. Vefa Bicakci --- drivers/staging/rtl8723au/core/rtw_security.c | 36

[PATCH 05/16] staging: rtl8723au: Reorganize a few functions to remove indentation

2015-03-12 Thread M. Vefa Bicakci
Prior to this commit, functions rtw_tkip_encrypt23a and rtw_tkip_decrypt23a had large if blocks which contained the majority of the logic in the functions. Rework these functions so that if the negated version of the aforementioned if blocks' conditions are true, we return from the function with

[PATCH 01/16] staging: rtl8723au: Reformat whitespace to increase readability

2015-03-12 Thread M. Vefa Bicakci
Adjust the whitespace in the local variable declaration and initialization part of a number of functions to increase readability in rtl8723au's rtw_security.c. Signed-off-by: M. Vefa Bicakci --- drivers/staging/rtl8723au/core/rtw_security.c | 79 +-- 1 file changed, 38

Re: [RFC PATCH] PCI: Disable MSI/MSI-X only if device is shutdown

2015-03-12 Thread Bandan Das
Fam Zheng writes: > On Thu, 03/12 23:09, Bandan Das wrote: >> Ccing Alex, he can probably confirm if my understanding is indeed correct. >> >> Fam Zheng writes: >> >> > On Thu, 03/12 19:56, Bandan Das wrote: >> >> Hi Fam, >> >> >> >> Fam Zheng writes: >> >> >> >> > If the device doesn't

Re: [PATCH v10 06/21] ACPI / sleep: Introduce CONFIG_ACPI_GENERIC_SLEEP

2015-03-12 Thread Hanjun Guo
On 2015/3/13 6:57, Rafael J. Wysocki wrote: > On Wednesday, March 11, 2015 08:39:32 PM Hanjun Guo wrote: >> From: Graeme Gregory >> >> ACPI 5.1 does not currently support S states for ARM64 hardware but >> ACPI code will call acpi_target_system_state() and acpi_sleep_init() >> for device power

Re: [PATCH v6 00/30] Refine PCI scan interfaces and make generic pci host bridge

2015-03-12 Thread Yijing Wang
On 2015/3/13 5:23, Bjorn Helgaas wrote: > On Mon, Mar 09, 2015 at 10:33:57AM +0800, Yijing Wang wrote: >> ... >> Yijing Wang (29): >> PCI: Rip out pci_bus_add_devices() from pci_scan_bus() >> PCI: Rip out pci_bus_add_devices() from pci_scan_root_bus() >> sparc/PCI: Claim bus resources before

Re: [Cocci] [PATCH v13 3/6] clk: Make clk API return per-user struct clk instances

2015-03-12 Thread Shawn Guo
On Thu, Mar 12, 2015 at 12:43:40PM -0700, Stephen Boyd wrote: > On 03/12/15 10:20, Sebastian Andrzej Siewior wrote: > > On 2015-02-17 14:01:04 [-0800], Stephen Boyd wrote: > >> diff = > >> --- arch/arm/mach-imx/mach-imx6q.c > >> +++ /tmp/cocci-output-11792-b62223-mach-imx6q.c > >> @@ -211,7

Re: [PATCH v10 18/21] ARM64 / ACPI: Select ACPI_REDUCED_HARDWARE_ONLY if ACPI is enabled on ARM64

2015-03-12 Thread Hanjun Guo
On 2015/3/13 2:21, Lorenzo Pieralisi wrote: > On Wed, Mar 11, 2015 at 12:39:44PM +, Hanjun Guo wrote: >> From: Al Stone >> >> ACPI reduced hardware mode is disabled by default, but ARM64 >> can only run properly in ACPI hardware reduced mode, so select >> ACPI_REDUCED_HARDWARE_ONLY if ACPI is

Re: [PATCH 1/7] blk-mq: fix use of incorrect goto label in blk_mq_init_queue error path

2015-03-12 Thread Mike Snitzer
On Thu, Mar 12 2015 at 9:51am -0400, Mike Snitzer wrote: > On Thu, Mar 12 2015 at 3:48am -0400, > Ming Lei wrote: > > > On Thu, Mar 12, 2015 at 11:56 AM, Mike Snitzer wrote: > > > If percpu_ref_init() fails the 'err_hctxs' label should be used instead > > > of 'err_map'. > > > > > >

Re: [PATCH v6 10/30] PCI: Introduce pci_host_bridge_list to manage host bridges

2015-03-12 Thread Yijing Wang
>>> It's a nice idea to move this test into the core. While you're at it, why >>> don't you check for any overlap with the bus ranges of existing host >>> bridges? For example, if we're trying to create a new host bridge to >>> [bus 40-7f], it should conflict with existing bridges to [bus 00-7f]

Re: linux-next: manual merge of the net-next tree with the vfs tree

2015-03-12 Thread David Miller
From: Stephen Rothwell Date: Fri, 13 Mar 2015 13:15:43 +1100 > Today's linux-next merge of the net-next tree got a conflict in > net/socket.c between commits 005139a14660 ("fs: remove ki_nbytes") and > e9eab93cc2dc ("fs: don't allow to complete sync iocbs through > aio_complete") from the vfs

Re: [PATCH v6 06/30] PCI: Combine PCI domain and bus number in u32 arg

2015-03-12 Thread Yijing Wang
>> struct pci_scan_info { >> int bus; >> struct device *parent; >> struct pci_ops *ops; >> void *sysdata; >> struct list_head *resource; >> int domain; >> struct pci_host_bridge_ops; >> } >> >> Do you like this one or keep it like now ? >> >>

Re: [RFC PATCH] PCI: Disable MSI/MSI-X only if device is shutdown

2015-03-12 Thread Fam Zheng
On Thu, 03/12 23:09, Bandan Das wrote: > Ccing Alex, he can probably confirm if my understanding is indeed correct. > > Fam Zheng writes: > > > On Thu, 03/12 19:56, Bandan Das wrote: > >> Hi Fam, > >> > >> Fam Zheng writes: > >> > >> > If the device doesn't support shutdown, disabling

Re: [RFC PATCH] PCI: Disable MSI/MSI-X only if device is shutdown

2015-03-12 Thread Bandan Das
Ccing Alex, he can probably confirm if my understanding is indeed correct. Fam Zheng writes: > On Thu, 03/12 19:56, Bandan Das wrote: >> Hi Fam, >> >> Fam Zheng writes: >> >> > If the device doesn't support shutdown, disabling interrupts may cause >> > trouble. For example, virtio-scsi-pci

Re: [PATCH v2 01/17] reset: add of_reset_control_get_by_index()

2015-03-12 Thread Vince Hsu
Hi Philipp, On 03/12/2015 11:01 PM, Philipp Zabel wrote: Hi Vince, Am Donnerstag, den 12.03.2015, 20:15 +0800 schrieb Vince Hsu: Add of_reset_control_get_by_index() to allow the drivers to get reset device without knowing its name. I see this is useful in the case of PM domain drivers that

Re: [PATCH] net/macb: Only adjust tx_clk on link change

2015-03-12 Thread David Miller
From: Jaeden Amero Date: Thu, 12 Mar 2015 18:07:54 -0500 > The PHY state machine (in drivers/net/phy/phy.c) will unconditionally > call phydev->adjust_link (macb_handle_link_change) when polling in the > PHY_CHANGELINK state. As currently written, macb always ends up > requesting a new tx_clk

Re: [rfc patch] rt,nohz_full: fix nohz_full for PREEMPT_RT_FULL

2015-03-12 Thread Steven Rostedt
On Fri, 13 Mar 2015 03:13:15 +0100 Mike Galbraith wrote: > > > + int softirqd = IS_ENABLED(CONFIG_PREEMPT_RT_FULL); > > > + > > > + softirqd &= current == this_cpu_ksoftirqd(); > > > > Ug, binary and logical ANDs should not be combined. Just looks nasty. > > What about: > > > > softirqd =

[PATCH] iio: si7020: Fix endianness for I2C reads

2015-03-12 Thread Andrey Smirnov
Si7020 outputs most significant byte of the measurement result first and least significant byte last. As a result the data returned by i2c_smbus_read_word_data appears as big endian. Fix this by making a call to an approbriate byte conversion routine. Signed-off-by: Andrey Smirnov ---

[PATCHv2 1/5] Drivers: Staging: ft1000: Single line if-statement changes

2015-03-12 Thread Janakarajan Natarajan
Minor change to remove {} for single line if statements Signed-off-by: Janakarajan Natarajan --- drivers/staging/ft1000/ft1000-usb/ft1000_debug.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/ft1000/ft1000-usb/ft1000_debug.c

[PATCHv2 2/5] Drivers: Staging: ft1000: Fix extra parenthesis warnings

2015-03-12 Thread Janakarajan Natarajan
Minor changes to remove extra parenthesis Signed-off-by: Janakarajan Natarajan --- drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c | 2 +- drivers/staging/ft1000/ft1000-usb/ft1000_debug.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCHv2 5/5] Drivers: Staging: ft1000: checkpatch.pl header file warning fix

2015-03-12 Thread Janakarajan Natarajan
Replaces and with and Signed-off-by: Janakarajan Natarajan --- drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c b/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c index

[PATCHv2 3/5] Drivers: Staging: ft1000: Refactoring if-else statement

2015-03-12 Thread Janakarajan Natarajan
Minor change to convert if-else to if statement Signed-off-by: Janakarajan Natarajan --- drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c

[PATCHv2 4/5] Drivers: Staging: ft1000: Fix blank line warning

2015-03-12 Thread Janakarajan Natarajan
Merges variable declaration and definition. Signed-off-by: Janakarajan Natarajan --- drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c

[PATCHv2 0/5] ft1000 driver checkpatch.pl fixes

2015-03-12 Thread Janakarajan Natarajan
Minor changes to fix ft1000 driver checkpatch.pl warnings Janakarajan Natarajan (5): Drivers: Staging: ft1000: Single line if-statement changes Drivers: Staging: ft1000: Fix extra parenthesis warnings Drivers: Staging: ft1000: Refactoring if-else statement Drivers: Staging: ft1000: Fix

Re: [PATCH v2] mtd:spi-nor: Add Altera EPCQ Driver

2015-03-12 Thread Viet Nga Dao
Hi, Could anyone please help me review the lock, unlock modification part i did in spi-nor? Thanks, Viet Nga On Mon, Feb 23, 2015 at 9:30 AM, Viet Nga Dao wrote: > Hi, > It has been nearly 2 weeks since i submitted this patch. Could you > please help to review? > Thanks, > > On Tue, Feb 17,

Re: [PATCH v6 04/30] xen/PCI: Don't use deprecated function pci_scan_bus_parented()

2015-03-12 Thread Yijing Wang
+ pci_add_resource(, _resource); + pci_add_resource(, _resource); + pci_add_resource(, _resource); >>> >>> Since I don't want to export busn_resource, you might have to allocate your >>> own struct resource for it here. And, of course, figure out the details of >>> which PCI

Re: [PATCH] rtlwifi: get buffer_desc before trying to alloc new skb

2015-03-12 Thread Yang Bai
On Fri, Mar 13, 2015 at 1:29 AM, Larry Finger wrote: > On 03/12/2015 06:33 AM, Yang Bai wrote: >> >> if rtlpriv->use_new_trx_flow == true and we run out of memory >> to alloc a new skb, we will directly jump to no_new tag with >> buffer_desc == NULL. Then we will dereference this NULL pointer >>

[blk-mq] BUG: unable to handle kernel NULL pointer dereference at 00000000000009d8

2015-03-12 Thread Fengguang Wu
x-next specific files for 20150312 Thanks, Fengguang early console in setup code [0.00] Initializing cgroup subsys cpuset [0.00] Initializing cgroup subsys cpu [0.00] Linux version 4.0.0-rc1-00023-gc9e8c91 (kbuild@lkp-nhm1) (gcc version 4.9.1 (Debian 4.9.1-19) ) #6 Fri Mar

[PATCH net-next 2/2] samples: bpf: add skb->field examples and tests

2015-03-12 Thread Alexei Starovoitov
- modify sockex1 example to count number of bytes in outgoing packets - modify sockex2 example to count number of bytes and packets per flow - add 4 stress tests that exercise 'skb->field' code path of verifier Signed-off-by: Alexei Starovoitov --- samples/bpf/sockex1_kern.c |8 +++--

[PATCH net-next 1/2] bpf: allow extended BPF programs access skb fields

2015-03-12 Thread Alexei Starovoitov
introduce user accessible mirror of in-kernel 'struct sk_buff': struct __sk_buff { __u32 len; __u32 pkt_type; __u32 mark; __u32 ifindex; __u32 queue_mapping; }; bpf programs can do: struct __sk_buff *ptr; var = ptr->pkt_type; which will be compiled to bpf assembler as:

[PATCH net-next 0/2] bpf: allow extended BPF programs access skb fields

2015-03-12 Thread Alexei Starovoitov
Hi All, classic BPF has a way to access skb fields, whereas extended BPF didn't. This patch introduces this ability. Classic BPF can access fields via negative SKF_AD_OFF offset. Positive bpf_ld_abs N is treated as load from packet, whereas bpf_ld_abs -0x1000 + N is treated as skb fields access.

linux-next: manual merge of the net-next tree with the vfs tree

2015-03-12 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in net/socket.c between commits 005139a14660 ("fs: remove ki_nbytes") and e9eab93cc2dc ("fs: don't allow to complete sync iocbs through aio_complete") from the vfs tree and commit 1b784140474e ("net: Remove iocb argument from

[PATCH] x86, boot: Move z_extract_offset calculation to header.S

2015-03-12 Thread Yinghai Lu
At that point, we have exact decompressor size, so we don't need to guess that size in mkpiggy.c We use 8 pages less in final init_size with this patch. input: [0x13f2b33b4-0x13fe44346], output: [0x13e00-0x13fe61fff], heap: [0x13fe4f080-0x13fe5707f] before patch input:

Re: [rfc patch] rt,nohz_full: fix nohz_full for PREEMPT_RT_FULL

2015-03-12 Thread Mike Galbraith
On Thu, 2015-03-12 at 11:09 -0400, Steven Rostedt wrote: > On Thu, 12 Mar 2015 10:38:13 +0100 > Mike Galbraith wrote: > > > --- a/kernel/sched/core.c > > +++ b/kernel/sched/core.c > > @@ -783,12 +783,16 @@ static inline bool got_nohz_idle_kick(vo > > #ifdef CONFIG_NO_HZ_FULL > > bool

Re: [RFC PATCH] PCI: Disable MSI/MSI-X only if device is shutdown

2015-03-12 Thread Fam Zheng
On Thu, 03/12 19:56, Bandan Das wrote: > Hi Fam, > > Fam Zheng writes: > > > If the device doesn't support shutdown, disabling interrupts may cause > > trouble. For example, virtio-scsi-pci doesn't implement shutdown, and > > after we disable MSI-X, futher notifications from device will be > >

Re: [PATCH 0/6] CLONE_FD: Task exit notification via file descriptor

2015-03-12 Thread Thiago Macieira
On Thursday 12 March 2015 18:40:03 Josh Triplett wrote: > This patch series introduces a new clone flag, CLONE_FD, which lets the > caller handle child process exit notification via a file descriptor rather > than SIGCHLD. CLONE_FD makes it possible for libraries to safely launch > and manage

[Bugfix] x86/PCI: Release PCI IRQ resource only if PCI device is disabled when unbinding

2015-03-12 Thread Jiang Liu
To support IOAPIC hot-removal, we need to release PCI interrupt resource when unbinding PCI device driver. But due to historical reason, /* * We would love to complain here if pci_dev->is_enabled is set, that * the driver should have called pci_disable_device(), but the * unfortunate fact is

Re: [PATCHv2 2/8] perf probe: Improve detection of file/function name in the probe pattern

2015-03-12 Thread Ananth N Mavinakayanahalli
On Thu, Mar 12, 2015 at 05:24:14PM -0300, Arnaldo Carvalho de Melo wrote: > Em Mon, Dec 15, 2014 at 08:20:32PM +0530, Naveen N. Rao escreveu: > > Currently, perf probe considers patterns including a '.' to be a file. > > However, this causes problems on powerpc ABIv1 where all functions have > > a

[PATCH 1/2] serial: 8250_pci: remove non-used var for F81504

2015-03-12 Thread Peter Hung
Remove pci_fintek_setup() non-used var with calculation ciobase Signed-off-by: Peter Hung --- drivers/tty/serial/8250/8250_pci.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/drivers/tty/serial/8250/8250_pci.c b/drivers/tty/serial/8250/8250_pci.c index

[PATCH 0/2] serial: 8250_pci: Fintek products patches

2015-03-12 Thread Peter Hung
These series patches works for Fintek F81504/F81508/F81512 PCI to Serial Port. and patch 0002 is following with patch 0001. patch 0001 is just cleanup non-used source code. patch 0002 is major patch. The serial port of our product will failed after wakeup from S3(STR). It's due to when the

Re: [PATCH] x86: improve algorithm in clflush_cache_range

2015-03-12 Thread Ross Zwisler
On Thu, 2015-03-12 at 12:09 +0100, Ingo Molnar wrote: > * Ross Zwisler wrote: > > > The current algorithm used in clflush_cache_range() can cause the last > > cache line of the buffer to be flushed twice. > > > > Fix that algorithm so that each cache line will only be flushed once, > > and

[PATCH 2/2] serial: 8250_pci: port failed after wakeup from S3

2015-03-12 Thread Peter Hung
Serial ports of F81504/F81508/F81512 will failed when wakeup from S3(STR). It's due to when the system wakeup from S3(STR), this PCI device's configuration space from 0x40 to 0x40 + max_port * 0x08 should be re-configured. We move all initialization from pci_fintek_setup() to pci_fintek_init()

Re: [PATCH v6 03/30] PCI: Export busn_resource to drivers/pci

2015-03-12 Thread Yijing Wang
>> Hi Bjorn, busn_resource may would not be shared by multi domains, >> >> We insert bus number resource like: >> >> pci_add_resource(, _resource); >> pci_bus_insert_busn_res(root_bus, start, bus_max); //start is the >> root bus number provided by arch pci host driver, bus max

Re: [PATCH] x86/PCI: Fully disable devices before releasing IRQ resource

2015-03-12 Thread Jiang Liu
On 2015/3/13 0:08, Rafael J. Wysocki wrote: > On Thursday, March 12, 2015 09:41:21 AM Jiang Liu wrote: >> On 2015/3/12 9:17, Rafael J. Wysocki wrote: >>> On Wednesday, March 11, 2015 10:04:42 PM Luck, Tony wrote: >> Unfortunately there's a long standing comment in pci_device_remove(): >>

[PATCH] clone4.2: New manpage documenting clone4(2)

2015-03-12 Thread Josh Triplett
Also includes new cross-reference from clone.2. Signed-off-by: Josh Triplett Signed-off-by: Thiago Macieira --- man2/clone.2 | 1 + man2/clone4.2 | 332 ++ 2 files changed, 333 insertions(+) create mode 100644 man2/clone4.2 diff

[PATCH 6/6] clone4: Introduce new CLONE_FD flag to get task exit notification via fd

2015-03-12 Thread Josh Triplett
When passed CLONE_FD, clone4 will return a file descriptor rather than a PID. When the child process exits, it gets automatically reaped, and the file descriptor becomes readable, producing a structure containing the exit code and user/system time. The file descriptor also works in epoll, poll,

[PATCH 0/6] CLONE_FD: Task exit notification via file descriptor

2015-03-12 Thread Josh Triplett
This patch series introduces a new clone flag, CLONE_FD, which lets the caller handle child process exit notification via a file descriptor rather than SIGCHLD. CLONE_FD makes it possible for libraries to safely launch and manage child processes on behalf of their caller, *without* taking over

[PATCH 1/6] clone: Support passing tls argument via C rather than pt_regs magic

2015-03-12 Thread Josh Triplett
clone with CLONE_SETTLS accepts an argument to set the thread-local storage area for the new thread. sys_clone declares an int argument tls_val in the appropriate point in the argument list (based on the various CLONE_BACKWARDS variants), but doesn't actually use or pass along that argument.

[PATCH 4/6] signal: Factor out a helper function to process task_struct exit_code

2015-03-12 Thread Josh Triplett
do_notify_parent includes the code to convert the exit_code field of struct task_struct to the code and status fields that accompany SIGCHLD. Factor that out into a new helper function task_exit_code_status, to allow other methods of task exit notification to share that code. Signed-off-by: Josh

[PATCH 2/6] x86: Opt into HAVE_COPY_THREAD_TLS, for both 32-bit and 64-bit

2015-03-12 Thread Josh Triplett
For 32-bit userspace on a 64-bit kernel, this requires modifying stub32_clone to actually swap the appropriate arguments to match CONFIG_CLONE_BACKWARDS, rather than just leaving the C argument for tls broken. Signed-off-by: Josh Triplett Signed-off-by: Thiago Macieira --- arch/x86/Kconfig

[PATCH 5/6] fs: Make alloc_fd non-private

2015-03-12 Thread Josh Triplett
This allows callers to allocate a file descriptor with a defined minimum value, without directly calling the lower-level __alloc_fd. Signed-off-by: Josh Triplett Signed-off-by: Thiago Macieira --- fs/file.c| 2 +- include/linux/file.h | 1 + 2 files changed, 2 insertions(+), 1

[PATCH 3/6] Introduce a new clone4 syscall with more flag bits and extensible arguments

2015-03-12 Thread Josh Triplett
clone() has no more usable flags available. It has three now-unused flags (CLONE_PID, CLONE_DETACHED, and CLONE_STOPPED), but current kernels just ignore those flags without returning an error like EINVAL, so reusing those flags would not allow userspace to detect the availability of the new

Re: [PATCH 4/4] workqueue: Allow modifying low level unbound workqueue cpumask

2015-03-12 Thread Lai Jiangshan
On 03/13/2015 01:42 AM, Christoph Lameter wrote: > On Thu, 12 Mar 2015, Lai Jiangshan wrote: > >> The per-nodes' pwqs are mandatorily controlled by the low level cpumask, >> while >> the default pwq ignores the low level cpumask when (and ONLY when) the >> cpumask set >> by the user doesn't

Re: [PATCH] uapi/virtio_scsi: allow overriding CDB/SENSE size

2015-03-12 Thread Rusty Russell
"Michael S. Tsirkin" writes: > On Wed, Mar 11, 2015 at 02:19:03PM +0100, Michael S. Tsirkin wrote: >> QEMU wants to use virtio scsi structures with >> a different VIRTIO_SCSI_CDB_SIZE/VIRTIO_SCSI_SENSE_SIZE, >> let's add ifdefs to allow overriding them. >> >> Keep the old defines under new

Re: [PATCH v2 log fixed] virtio_mmio: fix endian-ness for mmio

2015-03-12 Thread Rusty Russell
"Michael S. Tsirkin" writes: > Subject: [PATCH] virtio_mmio: fix access width for mmio Just for the record: Applied. Thanks, Rusty. > Going over the virtio mmio code, I noticed that it doesn't correctly > access modern device config values using "natural" accessors: it uses > readb to get/set

Re: [PATCH] 9p/trans_virtio: fix hot-unplug

2015-03-12 Thread Rusty Russell
"Michael S. Tsirkin" writes: > On Thu, Mar 12, 2015 at 11:54:10AM +1030, Rusty Russell wrote: >> "Michael S. Tsirkin" writes: >> > On device hot-unplug, 9p/virtio currently will kfree channel while >> > it might still be in use. >> > >> > Of course, it might stay used forever, so it's an

Re: [PATCH] virtio_mmio: fix endian-ness for mmio

2015-03-12 Thread Rusty Russell
"Michael S. Tsirkin" writes: > On Thu, Mar 12, 2015 at 12:33:36PM +1030, Rusty Russell wrote: >> "Michael S. Tsirkin" writes: >> > Going over the virtio mmio code, I noticed that it doesn't correctly >> > return device config values in LE format when using virtio 1.0. >> > Borrow code from

  1   2   3   4   5   6   7   8   9   10   >