Re: [PATCH] staging: rtl8723au: Fixes unnecessary return warning

2016-01-29 Thread Joe Perches
On Sat, 2016-01-30 at 12:23 +0530, Bhakti Priya wrote: > I will be happy to extend checkpatch.pl. As suggested by you, I am > trying to detect such blank lines in a line removal patch by checking > if the line above the deleted line was a blank line and the line > following the deleted line had a

Re: [slab] a1fd55538c: WARNING: CPU: 0 PID: 0 at kernel/locking/lockdep.c:2601 trace_hardirqs_on_caller()

2016-01-29 Thread Valdis . Kletnieks
On Thu, 28 Jan 2016 18:47:49 +0100, Jesper Dangaard Brouer said: > I cannot reproduce below problem... have enabled all kind of debugging > and also lockdep. > > Can I get a version of the .config file used? I'm not the 0day bot, but my laptop hits the same issue at boot. .config follows.. # #

Re: [PATCH 09/12] sparc: move exports to definitions

2016-01-29 Thread David Miller
From: Al Viro Date: Fri, 29 Jan 2016 19:18:31 + > From: Al Viro > > Signed-off-by: Al Viro Acked-by: David S. Miller

Re: [PATCH 11/12] [sparc] unify 32bit and 64bit string.h

2016-01-29 Thread David Miller
From: Al Viro Date: Fri, 29 Jan 2016 19:18:33 + > From: Al Viro > > Signed-off-by: Al Viro Acked-by: David S. Miller

Re: [PATCH 12/12] sparc32: debride memcpy.S a bit

2016-01-29 Thread David Miller
From: Al Viro Date: Fri, 29 Jan 2016 19:18:34 + > From: Al Viro > > unreachable code, unused macros... > > Signed-off-by: Al Viro Acked-by: David S. Miller

Re: [PATCH 2/2] dax: fix bdev NULL pointer dereferences

2016-01-29 Thread Jared Hulbert
On Fri, Jan 29, 2016 at 10:01 PM, Dan Williams wrote: > On Fri, Jan 29, 2016 at 9:28 PM, Matthew Wilcox wrote: >> On Fri, Jan 29, 2016 at 11:28:15AM -0700, Ross Zwisler wrote: >>> I guess I need to go off and understand if we can have DAX mappings on such >>> a >>> device. If we can, we may

Re: [PATCH v2 3/3] input: touchscreen: ad7879: add device tree support

2016-01-29 Thread Julia Lawall
[auto build test WARNING on input/next] > [also build test WARNING on v4.5-rc1 next-20160129] > [if your patch is applied to the wrong git tree, please drop us a note to > help improving the system] > > url: > https://github.com/0day-ci/linux/commits/Stefan-Agner/input-

Re: [PATCH] staging: rtl8723au: Fixes unnecessary return warning

2016-01-29 Thread Bhakti Priya
Hi, Thank you for your reply. I've just sent version 2 of the patch with the blank lines removed. I will be happy to extend checkpatch.pl. As suggested by you, I am trying to detect such blank lines in a line removal patch by checking if the line above the deleted line was a blank line and the

[PATCH] mfd: core: add macro for adding mfd cells

2016-01-29 Thread Laxman Dewangan
Most of MFD drivers add the mfd sub devices cells as follows: static const struct mfd_cell as3722_devs[] = { { .name = "as3722-pinctrl", }, { .name = "as3722-regulator", }, { .name = "as3722-rtc",

Re: PCI device driver broken between 4.2 and 4.3

2016-01-29 Thread Yinghai Lu
On Fri, Jan 29, 2016 at 8:31 AM, Bjorn Helgaas wrote: > > 991de2e59090 is related to IRQs, so I'd start by printing dev->irq in your > driver before and after you call pci_enable_device(). Add some printks in > pcibios_alloc_irq() and pcibios_enable_device() just to confirm that we got > there

[PATCH 4/9] staging: lowmemorykiller: Make default lowmemorykiller debug message useful

2016-01-29 Thread John Stultz
From: Colin Cross lowmemorykiller debug messages are inscrutable and mostly useful for debugging the lowmemorykiller, not explaining why a process was killed. Make the messages more useful by prefixing them with "lowmemorykiller: " and explaining in more readable terms what was killed, who it

[PATCH 3/9] staging: lowmemorykiller: Fix task_struct leak

2016-01-29 Thread John Stultz
From: San Mehat As it turns out, the CONFIG_PROFILING interfaces leak a task struct if the notifier chain returns NOTIFY_OK.. doh. This patch reworks lowmemkiller to use the new generic task free notifier chain. Cc: Android Kernel Team Cc: Greg KH Signed-off-by: San Mehat [jstultz: Commit

[PATCH 5/9] staging: lowmemorykiller: Trace kill events.

2016-01-29 Thread John Stultz
From: Martijn Coenen Allows for capturing lmk kill events and their rationale. Cc: Android Kernel Team Cc: Greg KH Signed-off-by: Martijn Coenen [jstultz: Checkpatch fixups] Signed-off-by: John Stultz --- drivers/staging/android/lowmemorykiller.c | 14 +++--

[PATCH 6/9] staging: ion: Set minimum carveout heap allocation order to PAGE_SHIFT

2016-01-29 Thread John Stultz
From: Rajmal Menariya In carveout heap, change minimum allocation order from 12 to PAGE_SHIFT. After this change each bit in bitmap (genalloc - General purpose special memory pool) represents one page size memory. Cc: sprd-ind-kernel-gr...@googlegroups.com Cc: sanjeev.ya...@spreadtrum.com Cc:

[PATCH 7/9] staging: ion: Handle the memory mapping correctly on x86

2016-01-29 Thread John Stultz
From: Vinil Cheeramvelil This patch modifies the ion page pool code to address limitation in x86 PAT. When one physical page is mapped to multiple virtual pages, the same cache policy should be used. Add set_memory_wc/uc call to avoid aliases. If not, all mappings will be cached(write back).

[PATCH 2/9] staging: ashmem: Add missing include

2016-01-29 Thread John Stultz
From: Rom Lemarchand Include into ashmem.h to ensure referenced types are defined Cc: Android Kernel Team Cc: Greg KH Signed-off-by: Rom Lemarchand [jstultz: Minor commit message tweaks] Signed-off-by: John Stultz --- drivers/staging/android/uapi/ashmem.h | 1 + 1 file changed, 1

[PATCH 9/9] staging: ion: Fix page pool cache policy

2016-01-29 Thread John Stultz
From: Amit Pundir Fix redundant "buffer->private_flags & ION_PRIV_FLAG_SHRINKER_FREE" checks in if(!cached ...) condition block. The previous patch, "ion: Handle the memory mapping correctly on x86", is broken on android-3.18+ kernels. It conflicts with upstream commit commit 53a91c68fa7b

[PATCH 1/9] staging: ashmem: Avoid deadlock with mmap/shrink

2016-01-29 Thread John Stultz
From: Laura Abbott Both ashmem_mmap and ashmem_shrink take the ashmem_lock. It may be possible for ashmem_mmap to invoke ashmem_shrink: -000|mutex_lock(lock = 0x0) -001|ashmem_shrink(?, sc = 0x0) <--- try to take ashmem_mutex again -002|shrink_slab(shrink = 0xDA5F1CC0, nr_pages_scanned = 0,

[PATCH 8/9] staging: ion: Add X86 dependency for ION_POOL_CACHE_POLICY

2016-01-29 Thread John Stultz
From: Daniel Rosenberg ION_POOL_CACHE_POLICY uses x86 specific commands. Only allow it to be used for x86. Cc: Android Kernel Team Cc: Greg KH Cc: Laura Abbott Cc: Sumit Semwal Signed-off-by: Daniel Rosenberg Signed-off-by: John Stultz --- drivers/staging/android/ion/Kconfig | 2 +- 1

[PATCH 0/9] staging: Updates from the Android tree

2016-01-29 Thread John Stultz
In reviewing the experimental/android-4.4 tree from AOSP, I realized there were a handful of patches to code in the staging/android directory. So I wanted to send these along for review, so if there were no objections they could be queued for 4.6. Let me know if there is any comments or feedback

Re: [PATCH 2/2] dax: fix bdev NULL pointer dereferences

2016-01-29 Thread Dan Williams
On Fri, Jan 29, 2016 at 9:28 PM, Matthew Wilcox wrote: > On Fri, Jan 29, 2016 at 11:28:15AM -0700, Ross Zwisler wrote: >> I guess I need to go off and understand if we can have DAX mappings on such a >> device. If we can, we may have a problem - we can get the block_device from >> get_block() in

[PATCH v2] staging: rtl8723au: Fixes unnecessary return warning

2016-01-29 Thread Bhaktipriya Shridhar
This patch fixes checkpatch.pl warning in rtw_mlme_ext.c file. WARNING: void function return statements are not generally useful Signed-off-by: Bhaktipriya Shridhar --- Changes in v2: - Removed the unnecessary blank lines. drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 20

Re: [PATCH V2 1/1] scsi: storvsc: Fix a build issue reported by kbuild test robot

2016-01-29 Thread James Bottomley
On Fri, 2016-01-29 at 19:36 -0800, K. Y. Srinivasan wrote: > tree: https://na01.safelinks.protection.outlook.com/?url=https%3a%2 > f%2fgit.kernel.org%2fpub%2fscm%2flinux%2fkernel%2fgit%2ftorvalds%2fli > nux.git=01%7c01%7ckys%40microsoft.com%7ce2e0622715844b79ad7108d3 >

Re: [PATCH 2/2] dax: fix bdev NULL pointer dereferences

2016-01-29 Thread Matthew Wilcox
On Fri, Jan 29, 2016 at 11:28:15AM -0700, Ross Zwisler wrote: > I guess I need to go off and understand if we can have DAX mappings on such a > device. If we can, we may have a problem - we can get the block_device from > get_block() in I/O path and the various fault paths, but we don't have

Re: [PATCH 1/4] sched,time: remove non-power-of-two divides from __acct_update_integrals

2016-01-29 Thread kbuild test robot
Hi Rik, [auto build test ERROR on tip/sched/core] [also build test ERROR on v4.5-rc1 next-20160129] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits/riel-redhat-com/sched-time-remove-non-power

Re: [PATCH net 5/6] net: mvneta: The mvneta_percpu_elect function should be atomic

2016-01-29 Thread David Miller
From: Gregory CLEMENT Date: Fri, 29 Jan 2016 17:26:06 +0100 > @@ -370,6 +370,8 @@ struct mvneta_port { > struct net_device *dev; > struct notifier_block cpu_notifier; > int rxq_def; > + /* protect */ > + spinlock_t lock; > > /* Core clock */ > struct clk

Re: pull-request: wireless-drivers 2016-01-29

2016-01-29 Thread David Miller
From: Kalle Valo Date: Fri, 29 Jan 2016 10:47:19 +0200 > few fixes for 4.5. Nothing really standing out, see the tag for > more info. Please let me know if you have any problems. Pulled, thanks Kalle.

Re: [PATCH] kernel/Makefile: remove the useless CFLAGS_REMOVE_cgroup-debug.o

2016-01-29 Thread Zefan Li
On 2016/1/30 11:54, Li Bin wrote: > The file cgroup-debug.c had been removed from commit fe6934354f8e > (cgroups: move the cgroup debug subsys into cgroup.c to access internal > state). > Remain the CFLAGS_REMOVE_cgroup-debug.o = $(CC_FLAGS_FTRACE) > useless in kernel/Makefile. > >

Re: [RFC5 PATCH v6 00/21] ILP32 for ARM64

2016-01-29 Thread Zhangjian (Bamvor)
Hi, Yury On 1:09 2016/1/30, Yury Norov wrote: On Fri, Jan 29, 2016 at 05:59:33PM +0800, Zhangjian (Bamvor) wrote: Hi, On 1:22 2016/1/15, Yury Norov wrote: This is still RFC because we have no glibc yet, that correspnds new ABI introduced here. And so we cannot run tests. LP64 and AARCH32

[PATCH] kernel/Makefile: remove the useless CFLAGS_REMOVE_cgroup-debug.o

2016-01-29 Thread Li Bin
The file cgroup-debug.c had been removed from commit fe6934354f8e (cgroups: move the cgroup debug subsys into cgroup.c to access internal state). Remain the CFLAGS_REMOVE_cgroup-debug.o = $(CC_FLAGS_FTRACE) useless in kernel/Makefile. Signed-off-by: Li Bin --- kernel/Makefile |3 +-- 1

Re: [PATCH 1/2] sched,time: remove pointless divides from __acct_update_integrals

2016-01-29 Thread Rik van Riel
On 01/29/2016 10:36 PM, Frederic Weisbecker wrote: > On Sat, Jan 30, 2016 at 12:10:18AM +0100, Peter Zijlstra wrote: >> On Fri, Jan 29, 2016 at 05:22:59PM -0500, r...@redhat.com wrote: >>> From: Rik van Riel >>> >>> When running a microbenchmark calling an invalid syscall number >>> in a loop, on

Re: [PATCH net] net: dsa: mv88e6xxx: fix port VLAN maps

2016-01-29 Thread David Miller
From: Vivien Didelot Date: Thu, 28 Jan 2016 16:54:37 -0500 > Currently the port based VLAN maps should be configured to allow every > port to egress frames on all other ports, except themselves. > > The debugfs interface shows that they are misconfigured. For instance, a > 7-port switch has the

Re: [PATCHv2] net: moxart: use correct accessors for DMA memory

2016-01-29 Thread David Miller
From: Arnd Bergmann Date: Thu, 28 Jan 2016 17:54:33 +0100 > The moxart ethernet driver confuses coherent DMA buffers with > MMIO registers. > > moxart_ether.c: In function 'moxart_mac_setup_desc_ring': > moxart_ether.c:146:428: error: passing argument 1 of '__fswab32' makes > integer from

Re: [PATCHv2] ipv4: ipconfig: avoid unused ic_proto_used symbol

2016-01-29 Thread David Miller
From: Arnd Bergmann Date: Thu, 28 Jan 2016 17:39:24 +0100 > When CONFIG_PROC_FS, CONFIG_IP_PNP_BOOTP, CONFIG_IP_PNP_DHCP and > CONFIG_IP_PNP_RARP are all disabled, we get a warning about the > ic_proto_used variable being unused: > > net/ipv4/ipconfig.c:146:12: error: 'ic_proto_used' defined

[PATCH 3/4] time,acct: drop irq save & restore from __acct_update_integrals

2016-01-29 Thread riel
From: Rik van Riel It looks like all the call paths that lead to __acct_update_integrals already have irqs disabled, and __acct_update_integrals does not need to disable irqs itself. This is very convenient since about half the CPU time left in this function was spent in local_irq_save alone.

Re: [PATCH net v2 0/4] net: add and use rx_nohandler stat counter

2016-01-29 Thread David Miller
From: Jarod Wilson Date: Thu, 28 Jan 2016 10:49:44 -0500 > The network core tries to keep track of dropped packets, but some packets > you wouldn't really call dropped, so much as intentionally ignored, under > certain circumstances. One such case is that of bonding and team device > slaves that

[PATCH 4/4] sched,time: only call account_{user,sys,guest,idle}_time once a jiffy

2016-01-29 Thread riel
From: Rik van Riel After removing __acct_update_integrals from the profile, native_sched_clock remains as the top CPU user. This can be reduced by only calling account_{user,sys,guest,idle}_time once per jiffy for long running tasks on nohz_full CPUs. This will reduce timing accuracy on

Re: [PATCH 1/2] sched,time: remove pointless divides from __acct_update_integrals

2016-01-29 Thread Frederic Weisbecker
On Sat, Jan 30, 2016 at 12:10:18AM +0100, Peter Zijlstra wrote: > On Fri, Jan 29, 2016 at 05:22:59PM -0500, r...@redhat.com wrote: > > From: Rik van Riel > > > > When running a microbenchmark calling an invalid syscall number > > in a loop, on a nohz_full CPU, we spend a full 9% of our CPU > >

[PATCH 2/4] acct,time: change indentation in __acct_update_integrals

2016-01-29 Thread riel
From: Rik van Riel Change the indentation in __acct_update_integrals to make the function a little easier to read. Suggested-by: Peter Zijlstra Signed-off-by: Rik van Riel --- kernel/tsacct.c | 41 + 1 file changed, 21 insertions(+), 20 deletions(-)

[PATCH 1/4] sched,time: remove non-power-of-two divides from __acct_update_integrals

2016-01-29 Thread riel
From: Rik van Riel When running a microbenchmark calling an invalid syscall number in a loop, on a nohz_full CPU, we spend a full 9% of our CPU time in __acct_update_integrals. This function converts cputime_t to jiffies, to a timeval, only to convert the timeval back to microseconds before

[PATCH 0/2] sched,time: reduce nohz_full syscall overhead 40%

2016-01-29 Thread riel
unning with nohz_full introduces a fair amount of overhead. Specifically, various things that are usually done from the timer interrupt are now done at syscall, irq, and guest entry and exit times. However, some of the code that is called every single time has only ever worked at jiffy

Re: [PATCH] staging: rtl8723au: Fixes unnecessary return warning

2016-01-29 Thread Joe Perches
On Sat, 2016-01-30 at 14:09 +1100, Julian Calaby wrote: > Hi Joe, Hello Julian. > On Sat, Jan 30, 2016 at 12:28 PM, Joe Perches > wrote: > > On Sat, 2016-01-30 at 10:17 +1100, Julian Calaby wrote: > > > On Sat, Jan 30, 2016 at 5:00 AM, Jes Sorensen > > t.com> wrote: > > > > Bhaktipriya

Re: [PATCH] staging: rtl8723au: Fixes unnecessary return warning

2016-01-29 Thread Julian Calaby
Hi Joe, On Sat, Jan 30, 2016 at 12:28 PM, Joe Perches wrote: > On Sat, 2016-01-30 at 10:17 +1100, Julian Calaby wrote: >> On Sat, Jan 30, 2016 at 5:00 AM, Jes Sorensen >> wrote: >> > Bhaktipriya Shridhar writes: >> > > This patch fixes checkpatch.pl warning in rtw_mlme_ext.c file. >> > >

[PATCH 2/2] powerpc/perf/hv-24x7: Display change in counter values

2016-01-29 Thread Sukadev Bhattiprolu
>From a1aa992fb25fb8e98a5c5724376ae8cc91463de3 Mon Sep 17 00:00:00 2001 From: Sukadev Bhattiprolu Date: Mon, 25 Jan 2016 23:05:36 -0500 Subject: [PATCH 2/2] powerpc/perf/hv-24x7: Display change in counter values For 24x7 counters, perf displays the raw value of the 24x7 counter, which is a

[PATCH 1/2] powerpc/perf/hv-24x7: Fix usage with chip events

2016-01-29 Thread Sukadev Bhattiprolu
>From 9b5848ce1834a4d82fc251022035d36d9e26b500 Mon Sep 17 00:00:00 2001 From: Sukadev Bhattiprolu Date: Sat, 23 Jan 2016 03:58:12 -0500 Subject: [PATCH 1/2] powerpc/perf/hv-24x7: Fix usage with chip events. 24x7 counters can belong to different domains (core, chip, virtual CPU etc). For events

Re: [PATCH 03/15] mips: use of_platform_default_populate() to populate default bus

2016-01-29 Thread Kefeng Wang
On 2016/1/30 0:00, Joshua Henderson wrote: > On 01/26/2016 09:27 PM, Kefeng Wang wrote: >> Use helper of_platform_default_populate() in linux/of_platform >> when possible, instead of calling of_platform_populate() with >> the default match table. >> >> Cc: Ralf Baechle >> Signed-off-by: Kefeng

Re: [PATCH] arm64: Allow vmalloc regions to be set with set_memory_*

2016-01-29 Thread Xishi Qiu
On 2016/1/29 19:02, Mark Rutland wrote: > On Fri, Jan 29, 2016 at 09:21:40AM +0800, Xishi Qiu wrote: >> On 2016/1/28 22:27, Mark Rutland wrote: >>> On Thu, Jan 28, 2016 at 07:47:09PM +0800, Xishi Qiu wrote: Hi Mark, Is it safe in the following path? alloc the whole linear

Re: [PATCH v2] locktorture: Fix NULL pointer when torture_type is invalid

2016-01-29 Thread Kefeng Wang
Hi Paul, On 2016/1/28 12:25, Kefeng Wang wrote: > Insmod locktorture with torture_type=mutex will lead to crash, > > Unable to handle kernel NULL pointer dereference at virtual address 0008 > pgd = ffc0f6c1 > [0008] *pgd=00013b221003, *pud=00013b221003, >

Re: [PATCH 01/31] Add hard/soft lockup debugger entry points

2016-01-29 Thread Jeffrey Merkey
On 1/29/16, Ingo Molnar wrote: > > * Jeffrey Merkey wrote: > >> On 1/28/16, Thomas Gleixner wrote: >> > On Thu, 28 Jan 2016, Jeffrey Merkey wrote: >> >> On 1/28/16, Thomas Gleixner wrote: >> >> > I'm probably missing something obvious here. >> >> >> >> It's a pain in the butt to grep around

[PATCH] ARM: dts: cros-ec-keyboard: Add LOCK key to keyboard matrix

2016-01-29 Thread Daniel Kurtz
From: James Chao The LOCK key is at KSO9/KSI3 for Chromebook Flip and other devices that use the Chrome OS EC keyboard matrix. Signed-off-by: James Chao Signed-off-by: Daniel Kurtz Signed-off-by: YH Huang --- arch/arm/boot/dts/cros-ec-keyboard.dtsi | 1 + 1 file changed, 1 insertion(+)

RE: [PATCH] cputime: Fix timeval-->cputime conversion

2016-01-29 Thread Zengtao (B)
> -Original Message- > From: Arnd Bergmann [mailto:a...@arndb.de] > Sent: Friday, January 29, 2016 4:46 PM > To: Zengtao (B) > Cc: Thomas Gleixner; LKML; Frederic Weisbecker > Subject: Re: [PATCH] cputime: Fix timeval-->cputime conversion > > On Friday 29 January 2016 03:12:37 Zengtao

Re: [PATCH v5] mtd: spi-nor: add hisilicon spi-nor flash controller driver

2016-01-29 Thread xuejiancheng
Hi Ezequiel, Thank you very much for your comments. I read them carefully. All of your suggestions are very good and helpful. I will correct in next version. Regards, Jiancheng . On 2016/1/29 22:45, Ezequiel Garcia wrote: > Hi Jiancheng, > > Driver looks mostly good. Few comments below. > >

Re: [PATCH] regulator: max77802: Fix DT binding document reference

2016-01-29 Thread Krzysztof Kozlowski
W dniu 30.01.2016 o 01:09, Javier Martinez Canillas pisze: > The DT binding doc references the max77802 clocks header file which makes > no sense since of course it doesn't contain data related to the regulators. > > It's a copy and paste error, so add a reference to the correct header file. > >

[PATCH 1/1] pid: Fix spelling in comments

2016-01-29 Thread Zhen Lei
Accidentally discovered when I study this module. Signed-off-by: Zhen Lei --- kernel/pid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/pid.c b/kernel/pid.c index f4ad91b..7efa5c9 100644 --- a/kernel/pid.c +++ b/kernel/pid.c @@ -588,7 +588,7 @@ void __init

[PATCH V2 1/1] scsi: storvsc: Fix a build issue reported by kbuild test robot

2016-01-29 Thread K. Y. Srinivasan
tree:

Re: [PATCH] ipv6: release idev lock before calling ipv6_ifa_notify()

2016-01-29 Thread David Miller
From: Gregory Herrero Date: Thu, 28 Jan 2016 09:34:52 +0100 > @@ -2302,8 +2302,11 @@ static void manage_tempaddrs(struct inet6_dev *idev, > ift->flags &= ~IFA_F_DEPRECATED; > > spin_unlock(>lock); > - if (!(flags_F_TENTATIVE)) > + if

Re: [PATCH 2/4] dmi: Add a DMI firmware node and handling

2016-01-29 Thread Corey Minyard
Dang, I've been doing too much Python. I've fixed this, but I guess I'll wait for more comments. -corey On 01/29/2016 05:59 PM, kbuild test robot wrote: Hi Corey, [auto build test ERROR on char-misc/char-misc-testing] [also build test ERROR on v4.5-rc1 next-20160129] [if your patch

Re: [PATCH] staging: rtl8723au: Fixes unnecessary return warning

2016-01-29 Thread Joe Perches
On Sat, 2016-01-30 at 10:17 +1100, Julian Calaby wrote: > On Sat, Jan 30, 2016 at 5:00 AM, Jes Sorensen wrote: > > Bhaktipriya Shridhar writes: > > > This patch fixes checkpatch.pl warning in rtw_mlme_ext.c file. > > > WARNING: void function return statements are not generally useful [] > > >

Re: [PATCH] clk: st: avoid uninitialized variable use

2016-01-29 Thread Stephen Boyd
On 01/25, Arnd Bergmann wrote: > My previous patch fixed some warnings about printing a couple > of variables that are always uninitialized in quadfs_pll_fs660c32_set_rate(), > but I now got a warning that only shows up in some configurations (i.e. > without gcc -Os) about the params.ndiv being

Re: [PATCH RFC] locking/mutexes: don't spin on owner when wait list is not NULL.

2016-01-29 Thread Ding Tianhong
On 2016/1/29 17:53, Peter Zijlstra wrote: > On Sun, Jan 24, 2016 at 04:03:50PM +0800, Ding Tianhong wrote: > >> looks good to me, I will try this solution and report the result, thanks >> everyone. > > Did you get a change to run with this? > > . > I backport this patch to 3.10 lts kernel,

[PATCH] recordmcount: arm: Implement make_nop

2016-01-29 Thread Stephen Boyd
In similar spirit to x86 and arm64 support, add a make_nop_arm() to replace calls to mcount with a "nop" in sections that aren't traced. Cc: Russell King Cc: Rabin Vincent Signed-off-by: Stephen Boyd --- scripts/recordmcount.c | 49 +

Re: [PATCH 1/2] clk: imx: do not sleep if IRQ's are still disabled

2016-01-29 Thread Stephen Boyd
On 01/29, Stefan Agner wrote: > If a clock gets enabled early during boot time, it can lead to a PLL > startup. The wait_lock function makes sure that the PLL is really > stareted up before it gets used. However, the function sleeps which > leads to scheduling and an error: > bad: scheduling from

[PATCH] clk: axi-clkgen: Remove sometimes impossible check

2016-01-29 Thread Stephen Boyd
The size of unsigned long on 64-bit architectures is equal to the size of u64, so this check is impossible there. This throws off static checkers: drivers/clk/clk-axi-clkgen.c:331 axi_clkgen_recalc_rate() warn: impossible condition '(tmp > (~0)) => (0-u64max > u64max)' Let's change this code to

Re: [PATCH v2] irqchip: gicv3-its: Fix memory leak in its_free_tables()

2016-01-29 Thread Shanker Donthineni
On 01/29/2016 02:30 AM, Thomas Gleixner wrote: On Thu, 28 Jan 2016, Shanker Donthineni wrote: @@ -807,9 +810,10 @@ static void its_free_tables(struct its_node *its) int i; for (i = 0; i < GITS_BASER_NR_REGS; i++) { - if (its->tables[i]) { -

Re: [PATCH 2/2] clk: axi-clkgen: Add multi-parent support

2016-01-29 Thread Stephen Boyd
On 11/30, Lars-Peter Clausen wrote: > The clock generator has two clock inputs that can be used as the reference > clock. Add support for switching between them at runtime. > > Signed-off-by: Lars-Peter Clausen > --- Applied to clk-next > .../devicetree/bindings/clock/axi-clkgen.txt |

Re: [PATCH 00/13] dtb: amd: Miscelleneous Updates for AMD Seattle DTS

2016-01-29 Thread Frank Rowand
On 1/28/2016 6:43 PM, Olof Johansson wrote: > On Thu, Jan 28, 2016 at 2:20 PM, Suravee Suthikulanit > wrote: >> Hi Olof, >> >> On 1/28/2016 3:39 PM, Olof Johansson wrote: >>> >>> Hi Suravee, >>> >>> On Wed, Jan 27, 2016 at 1:11 PM, Suravee Suthikulpanit >>> wrote: From: Suravee

Re: [PATCH 2/2] clk: palmas: fix a possible NULL dereference

2016-01-29 Thread Stephen Boyd
On 11/25, LABBE Corentin wrote: > of_match_device could return NULL, and so cause a NULL pointer > dereference later. > Even if the probability of this case is very low, fixing it made > static analyzers happy. > > Solving this with of_device_get_match_data made also code simplier. > >

Re: [PATCH 1/2] clk: palmas: constify the palmas_clks_of_match_data structure

2016-01-29 Thread Stephen Boyd
On 11/25, LABBE Corentin wrote: > The palmas_clks_of_match_data structures are never modified. > This patch constify them. > > Signed-off-by: LABBE Corentin > --- Applied to clk-next -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project

Re: [RFC PATCH 00/19] cpufreq locking cleanups and documentation

2016-01-29 Thread Saravana Kannan
On 01/11/2016 09:35 AM, Juri Lelli wrote: Hi all, In the context of the ongoing discussion about introducing a simple platform energy model to guide scheduling decisions (Energy Aware Scheduling [1]) concerns have been expressed by Peter about the component in charge of driving clock frequency

[PATCH 1/3] f2fs: wait on page's writeback in writepages path

2016-01-29 Thread Jaegeuk Kim
Likewise f2fs_write_cache_pages, let's do for node and meta pages too. Especially, for node blocks, we should do this before marking its fsync and dentry flags. Signed-off-by: Jaegeuk Kim --- fs/f2fs/checkpoint.c | 4 +++- fs/f2fs/node.c | 5 +++-- 2 files changed, 6 insertions(+), 3

[PATCH 2/3] f2fs: flush bios to handle cp_error in put_super

2016-01-29 Thread Jaegeuk Kim
Sometimes, if cp_error is set, there remains under-writeback pages, resulting in kernel hang in put_super. Signed-off-by: Jaegeuk Kim --- fs/f2fs/super.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c index 9962021..aa2d3d9 100644 ---

[PATCH 3/3] f2fs: fix conflict on page->private usage

2016-01-29 Thread Jaegeuk Kim
This patch fixes confilct on page->private value between f2fs_trace_pid and atomic page. Signed-off-by: Jaegeuk Kim --- fs/f2fs/segment.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/f2fs/segment.h b/fs/f2fs/segment.h index ee44d34..cd7111b 100644 ---

Re: [PATCH] clk: optimize the divider walk in clk_divider_bestdiv()

2016-01-29 Thread Stephen Boyd
On 01/05, Masahiro Yamada wrote: > Because _next_div() returns a valid divider, there is no need to > consult _is_valid_div() for the validity of the divider in every > iteration. > > Signed-off-by: Masahiro Yamada > --- Applied to clk-next -- Qualcomm Innovation Center, Inc. is a member of

Re: [PATCH v2 14/38] clk: vt8500: fix sign of possible PLL values

2016-01-29 Thread Stephen Boyd
On 10/02, Andrzej Hajda wrote: > With unsigned values underflow in loops can occur resulting in > theoretically infinite loops. > > The problem has been detected using proposed semantic patch > scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. > > [1]:

Re: [PATCH 1/2] clk: add clk_unregister_fixed_factor()

2016-01-29 Thread Stephen Boyd
On 01/06, Masahiro Yamada wrote: > Allow to unregister fixed factor clock. > > Signed-off-by: Masahiro Yamada > --- Applied to clk-next -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project

Re: [PATCH 2/2] clk: add clk_unregister_fixed_rate()

2016-01-29 Thread Stephen Boyd
On 01/06, Masahiro Yamada wrote: > Allow to unregister fixed rate clock. > > Signed-off-by: Masahiro Yamada > --- Applied to clk-next -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project

Re: [PATCH 2/4] dmi: Add a DMI firmware node and handling

2016-01-29 Thread kbuild test robot
Hi Corey, [auto build test WARNING on char-misc/char-misc-testing] [also build test WARNING on v4.5-rc1 next-20160129] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits/minyard-acm-org/dmi

Re: [PATCH RESEND v2 4/4] ARM: dts: enable audio clock support for Cygnus

2016-01-29 Thread Ray Jui
Hi Florian, With Stephen merging the first 3 patches into the clk tree, could you please take this DT patch now? Thanks, Ray On 1/26/2016 5:18 PM, Ray Jui wrote: From: Simran Rai Add audio clock to the existing Broadcom Cygnus clock DT Signed-off-by: Simran Rai Reviewed-by: Ray Jui

CONFIG_UBSAN_ALIGNMENT breaks x86-64 kernel with lockdep enabled

2016-01-29 Thread Mike Krinkin
Hi, option CONFIG_UBSAN_ALIGNMENT breaks x86-64 kernel with lockdep enabled, i. e kernel with CONFIG_UBSAN_ALIGNMENT fails to load without even any error message. The problem is that ubsan callbacks use spinlocks and might be called before lockdep is initialized. Particularly this line in the

Re: [PATCH v2] clk:gcc-msm8916: add missing mss_q6_bimc_axi clock

2016-01-29 Thread Stephen Boyd
On 01/04, Srinivas Kandagatla wrote: > This clock is required for loading the qdsp firmware. > > Signed-off-by: Srinivas Kandagatla > --- Applied to clk-next -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project

Re: [PATCH v8 3/3] x86, mce: Add __mcsafe_copy()

2016-01-29 Thread Tony Luck
On Wed, Jan 13, 2016 at 8:39 PM, Borislav Petkov wrote: > On Wed, Jan 13, 2016 at 03:22:58PM -0800, Tony Luck wrote: >> Are there some examples of synthetic CPUID bits? > > X86_FEATURE_ALWAYS is one. The others got renamed into X86_BUG_* ones, > the remaining mechanism is the same, though. So

Re: [PATCH v3 1/4] clk: s2mps11: merge two for loops in one

2016-01-29 Thread Stephen Boyd
On 01/20, Andi Shyti wrote: > the driver already loops once, there is no reason to loop again > for a different purpose. Merge the second loop into the first. > > Signed-off-by: Andi Shyti > --- Applied to clk-next -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux

Re: [PATCH v3 4/4] clk: s2mps11: remove redundant code

2016-01-29 Thread Stephen Boyd
On 01/20, Andi Shyti wrote: > The definition of s2mps11_name is meant to resolve the name of a > given clock. Remove it because the clocks have the same name we > can get it directly from the s2mps11_clks_init structure. > > While in the probe function the s2mps11_clks is used only to > iterate

Re: [PATCH v3 3/4] clk: s2mps11: remove redundant static variables declaration

2016-01-29 Thread Stephen Boyd
On 01/20, Andi Shyti wrote: > The clk_table and clk_data are declared static. The clk_table > contains the three clock data stractures belonging to the s2mps11 > driver. In the probe function it gets stored into clk_data. > > Remove clk_table and refer directly to clk_data. > > clk_data, itself,

Re: [PATCH v3 2/4] clk: s2mps11: allocate only one structure for clock init

2016-01-29 Thread Stephen Boyd
On 01/20, Andi Shyti wrote: > The driver allocates three structures, s2mpsxx_clk_init, for > three different clock types (s2mps11, s2mps13 and s2mps14). They > are quite similar but they differ only by the name. Only one of > these structures is used, while the others lie unused in the > memory. >

[PATCH v2] block: use DAX for partition table reads

2016-01-29 Thread Dan Williams
Avoid populating pagecache when the block device is in DAX mode. Otherwise these page cache entries collide with the fsync/msync implementation and break data durability guarantees. Cc: Jan Kara Cc: Jeff Moyer Cc: Christoph Hellwig Cc: Dave Chinner Cc: Andrew Morton Reported-by: Ross Zwisler

Re: [PATCH RESEND v2 2/4] clk: iproc: Add support for Cygnus audio clocks

2016-01-29 Thread Stephen Boyd
On 01/26, Ray Jui wrote: > From: Simran Rai > > This patch adds support for Broadcom Cygnus audio PLL and leaf > clocks > > Signed-off-by: Simran Rai > Reviewed-by: Scott Branden > Signed-off-by: Ray Jui > --- Applied to clk-iproc -- Qualcomm Innovation Center, Inc. is a member of Code

Re: [PATCH RESEND v2 3/4] clk: iproc: Remove __init from header

2016-01-29 Thread Stephen Boyd
On 01/26, Ray Jui wrote: > Remove __init macro from all function prototypes in clk-iproc.h > > Signed-off-by: Ray Jui > --- Applied to clk-iproc -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project

Re: [RFC PATCH 11/19] cpufreq: assert policy->rwsem is held in __cpufreq_governor

2016-01-29 Thread Saravana Kannan
On 01/12/2016 02:20 AM, Viresh Kumar wrote: On 11-01-16, 17:35, Juri Lelli wrote: __cpufreq_governor works on policy, so policy->rwsem has to be held. Add assertion for such condition. Cc: "Rafael J. Wysocki" Cc: Viresh Kumar Signed-off-by: Juri Lelli --- drivers/cpufreq/cpufreq.c | 3 +++

Re: [PATCH RESEND v2 1/4] Documentation: dt-bindings: Add DT bindings for Cygnus audio clock

2016-01-29 Thread Stephen Boyd
On 01/26, Ray Jui wrote: > From: Simran Rai > > This patch adds audio clock device tree binding documentation to an > existing Cygnus clock DT bindings document. > > Signed-off-by: Simran Rai > Reviewed-by: Ray Jui > Reviewed-by: Lori Hikichi > Reviewed-by: Scott Branden > --- Applied to

Re: [PATCH] clk: rockchip: fix wrong mmc phase shift for rk3228

2016-01-29 Thread Stephen Boyd
On 01/26, Shawn Lin wrote: > mmc sample shift is 0 for rk3228 refer to user manaul. > So it's broken if we enable mmc tuning for rk3228. > > Fixes: 307a2e9ac ("clk: rockchip: add clock controller for rk3228") > Cc: Xing Zheng > Cc: Jeffy Chen > Signed-off-by: Shawn Lin > --- Acked-by: Stephen

Re: [PATCH v2] clk: Move vendor's Kconfig into CCF menu section

2016-01-29 Thread Stephen Boyd
On 01/28, James Liao wrote: > Move all vendor's Kconfig into CCF menu section to prevent > new drivers putting their Kconfig files in a wrong place. > > Some Kconigs need to modify at the same time to avoid build > warnings. > > Signed-off-by: James Liao > --- Applied to clk-next -- Qualcomm

[PATCH] tpm: fix rollback when adding char dev fails

2016-01-29 Thread Jarkko Sakkinen
Fixed rollback and gave better names to the functions (more self-documenting, less confusing). Fixes: d972b0523f ("tpm: fix call order in tpm-chip.c") Signed-off-by: Jarkko Sakkinen cc: sta...@vger.kernel.org --- drivers/char/tpm/tpm-chip.c | 10 +- 1 file changed, 5 insertions(+), 5

Re: [PATCH 2/2] dax: fix bdev NULL pointer dereferences

2016-01-29 Thread Dan Williams
On Fri, Jan 29, 2016 at 3:34 PM, Ross Zwisler wrote: > On Fri, Jan 29, 2016 at 11:28:15AM -0700, Ross Zwisler wrote: >> On Thu, Jan 28, 2016 at 01:38:58PM -0800, Christoph Hellwig wrote: >> > On Thu, Jan 28, 2016 at 12:35:04PM -0700, Ross Zwisler wrote: >> > > There are a number of places in

[PATCH] ARM: dts: vf610: Add alias for ethernet controller

2016-01-29 Thread Stefan Agner
Add alias for FEC ethernet on Vybrid to allow bootloaders (like U-Boot) patch-in the MAC address using this alias. Signed-off-by: Stefan Agner --- arch/arm/boot/dts/vfxxx.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/boot/dts/vfxxx.dtsi b/arch/arm/boot/dts/vfxxx.dtsi index

Re: [PATCH 00/13] dtb: amd: Miscelleneous Updates for AMD Seattle DTS

2016-01-29 Thread Suravee Suthikulanit
On 1/28/2016 8:43 PM, Olof Johansson wrote: On Thu, Jan 28, 2016 at 2:20 PM, Suravee Suthikulanit wrote: Hi Olof, On 1/28/2016 3:39 PM, Olof Johansson wrote: Hi Suravee, On Wed, Jan 27, 2016 at 1:11 PM, Suravee Suthikulpanit wrote: From: Suravee Suthikulpanit This patch series

Re: livepatch: Implement separate coming and going module notifiers

2016-01-29 Thread Steven Rostedt
On Fri, 29 Jan 2016 17:58:29 -0500 Jessica Yu wrote: > diff --git a/kernel/module.c b/kernel/module.c > index 8358f46..eccd289 100644 > --- a/kernel/module.c > +++ b/kernel/module.c > @@ -979,8 +979,12 @@ SYSCALL_DEFINE2(delete_module, const char __user *, > name_user, > /* Final

Re: [PATCH 2/4] dmi: Add a DMI firmware node and handling

2016-01-29 Thread kbuild test robot
Hi Corey, [auto build test ERROR on char-misc/char-misc-testing] [also build test ERROR on v4.5-rc1 next-20160129] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits/minyard-acm-org/dmi-Rework

Re: [PATCH v5 04/14] clk: clk-pic32: Add PIC32 clock driver

2016-01-29 Thread Stephen Boyd
On 01/13, Joshua Henderson wrote: > diff --git a/drivers/clk/clk-pic32.c b/drivers/clk/clk-pic32.c > new file mode 100644 > index 000..9dc5f78 > --- /dev/null > +++ b/drivers/clk/clk-pic32.c > @@ -0,0 +1,1801 @@ > +/* > + * Purna Chandra Mandal, > + * Copyright (C) 2015 Microchip Technology

[PATCH v2 1/3] input: touchscreen: ad7879: move header to platform_data directory

2016-01-29 Thread Stefan Agner
The header file is used by the SPI and I2C variant of the driver. Therefore, move it to a more generic place under platform_data. Signed-off-by: Stefan Agner --- Changes since v1: - Move to include/linux/platform_data/ arch/blackfin/mach-bf527/boards/ezbrd.c| 2 +-

  1   2   3   4   5   6   7   8   9   10   >