Re: [PATCH v2 3/5] clk: aspeed: Add platform driver and register PLLs

2017-10-02 Thread Joel Stanley
On Tue, Oct 3, 2017 at 6:54 AM, Stephen Boyd wrote: > On 09/21, Joel Stanley wrote: >> @@ -160,6 +191,104 @@ static struct clk_hw *aspeed_calc_pll(const char >> *name, u32 val) >> + /* >> + * Memory controller (M-PLL) PLL. This clock is configured by the >> +

Re: [PATCH v2 3/5] clk: aspeed: Add platform driver and register PLLs

2017-10-02 Thread Joel Stanley
On Tue, Oct 3, 2017 at 6:54 AM, Stephen Boyd wrote: > On 09/21, Joel Stanley wrote: >> @@ -160,6 +191,104 @@ static struct clk_hw *aspeed_calc_pll(const char >> *name, u32 val) >> + /* >> + * Memory controller (M-PLL) PLL. This clock is configured by the >> + * bootloader, and is

Re: [PATCH v2 4/5] clk: aspeed: Register gated clocks

2017-10-02 Thread Joel Stanley
On Tue, Oct 3, 2017 at 7:07 AM, Stephen Boyd wrote: > On 09/21, Joel Stanley wrote: >> The majority of the clocks in the system are gates paired with a reset >> controller that holds the IP in reset. >> >> This borrows from clk_hw_register_gate, but registers two 'gates',

Re: [PATCH v2 4/5] clk: aspeed: Register gated clocks

2017-10-02 Thread Joel Stanley
On Tue, Oct 3, 2017 at 7:07 AM, Stephen Boyd wrote: > On 09/21, Joel Stanley wrote: >> The majority of the clocks in the system are gates paired with a reset >> controller that holds the IP in reset. >> >> This borrows from clk_hw_register_gate, but registers two 'gates', one >> to control the

Re: [PATCH] mm,hugetlb,migration: don't migrate kernelcore hugepages

2017-10-02 Thread Alexandru Moise
On Mon, Oct 02, 2017 at 06:15:00PM +0200, Michal Hocko wrote: > On Mon 02-10-17 17:06:38, Alexandru Moise wrote: > > On Mon, Oct 02, 2017 at 04:27:17PM +0200, Michal Hocko wrote: > > > On Mon 02-10-17 16:06:33, Alexandru Moise wrote: > > > > On Mon, Oct 02, 2017 at 02:54:32PM +0200, Michal Hocko

Re: [PATCH] mm,hugetlb,migration: don't migrate kernelcore hugepages

2017-10-02 Thread Alexandru Moise
On Mon, Oct 02, 2017 at 06:15:00PM +0200, Michal Hocko wrote: > On Mon 02-10-17 17:06:38, Alexandru Moise wrote: > > On Mon, Oct 02, 2017 at 04:27:17PM +0200, Michal Hocko wrote: > > > On Mon 02-10-17 16:06:33, Alexandru Moise wrote: > > > > On Mon, Oct 02, 2017 at 02:54:32PM +0200, Michal Hocko

[PATCH v10] vfio: platform: reset: Add Broadcom FlexRM reset module

2017-10-02 Thread Anup Patel
This patch adds Broadcom FlexRM low-level reset for VFIO platform. It will do the following: 1. Disable/Deactivate each FlexRM ring 2. Flush each FlexRM ring The cleanup sequence for FlexRM rings is adapted from Broadcom FlexRM mailbox driver. Signed-off-by: Anup Patel

[PATCH v10] FlexRM support in VFIO platform

2017-10-02 Thread Anup Patel
This patchset primarily adds Broadcom FlexRM reset module for VFIO platform driver. The patches are based on Linux-4.14-rc3 and can also be found at flexrm-vfio-v10 branch of https://github.com/Broadcom/arm64-linux.git Changes since v9: - Make GPL comment header similar to other Broadcom

[PATCH v10] vfio: platform: reset: Add Broadcom FlexRM reset module

2017-10-02 Thread Anup Patel
This patch adds Broadcom FlexRM low-level reset for VFIO platform. It will do the following: 1. Disable/Deactivate each FlexRM ring 2. Flush each FlexRM ring The cleanup sequence for FlexRM rings is adapted from Broadcom FlexRM mailbox driver. Signed-off-by: Anup Patel Reviewed-by: Oza Oza

[PATCH v10] FlexRM support in VFIO platform

2017-10-02 Thread Anup Patel
This patchset primarily adds Broadcom FlexRM reset module for VFIO platform driver. The patches are based on Linux-4.14-rc3 and can also be found at flexrm-vfio-v10 branch of https://github.com/Broadcom/arm64-linux.git Changes since v9: - Make GPL comment header similar to other Broadcom

[PATCH v4 3/6] mtd: spi-nor: cadence-quadspi: Add new binding to enable loop-back circuit

2017-10-02 Thread Vignesh R
Cadence QSPI IP has a adapted loop-back circuit which can be enabled by setting BYPASS field to 0 in READCAPTURE register. It enables use of QSPI return clock to latch the data rather than the internal QSPI reference clock. For high speed operations, adapted loop-back circuit using QSPI return

RE: [PATCH v2 3/6] staging: fsl-dpaa2/ethsw: Add ethtool support

2017-10-02 Thread Razvan Stefanescu
> -Original Message- > From: Andrew Lunn [mailto:and...@lunn.ch] > Sent: Monday, October 02, 2017 18:37 > To: Razvan Stefanescu > Cc: gre...@linuxfoundation.org; de...@driverdev.osuosl.org; linux- > ker...@vger.kernel.org; net...@vger.kernel.org;

[PATCH v4 3/6] mtd: spi-nor: cadence-quadspi: Add new binding to enable loop-back circuit

2017-10-02 Thread Vignesh R
Cadence QSPI IP has a adapted loop-back circuit which can be enabled by setting BYPASS field to 0 in READCAPTURE register. It enables use of QSPI return clock to latch the data rather than the internal QSPI reference clock. For high speed operations, adapted loop-back circuit using QSPI return

RE: [PATCH v2 3/6] staging: fsl-dpaa2/ethsw: Add ethtool support

2017-10-02 Thread Razvan Stefanescu
> -Original Message- > From: Andrew Lunn [mailto:and...@lunn.ch] > Sent: Monday, October 02, 2017 18:37 > To: Razvan Stefanescu > Cc: gre...@linuxfoundation.org; de...@driverdev.osuosl.org; linux- > ker...@vger.kernel.org; net...@vger.kernel.org; ag...@suse.de; > a...@arndb.de;

[PATCH 0/5] Few more FlexRM driver improvements

2017-10-02 Thread Anup Patel
This patchset does few more improvements to Broadcom FlexRM mailbox driver. The patches are based on Linux-4.14-rc3 and can also be found at flexrm-imp2-v1 branch of: https://github.com/Broadcom/arm64-linux.git Anup Patel (4): mailbox: bcm-flexrm-mailbox: Fix FlexRM ring flush sequence

[PATCH 0/5] Few more FlexRM driver improvements

2017-10-02 Thread Anup Patel
This patchset does few more improvements to Broadcom FlexRM mailbox driver. The patches are based on Linux-4.14-rc3 and can also be found at flexrm-imp2-v1 branch of: https://github.com/Broadcom/arm64-linux.git Anup Patel (4): mailbox: bcm-flexrm-mailbox: Fix FlexRM ring flush sequence

[PATCH 1/5] mailbox: bcm-flexrm-mailbox: Fix FlexRM ring flush sequence

2017-10-02 Thread Anup Patel
As-per suggestion from FlexRM HW folks, we have to first set FlexRM ring flush state and then clear it for FlexRM ring flush to work properly. Currently, the FlexRM driver has incomplete FlexRM ring flush sequence which causes repeated insmod+rmmod of mailbox client drivers to fail. This patch

[PATCH 1/4] dmaengine: bcm-sba-raid: serialize dma_cookie_complete() using reqs_lock

2017-10-02 Thread Anup Patel
As-per documentation in driver/dma/dmaengine.h, the dma_cookie_complete() API should be called with lock held. This patch ensures that Broadcom SBA RAID driver calls the dma_cookie_complete() API with reqs_lock held. Signed-off-by: Anup Patel Reviewed-by: Ray Jui

[PATCH 1/5] mailbox: bcm-flexrm-mailbox: Fix FlexRM ring flush sequence

2017-10-02 Thread Anup Patel
As-per suggestion from FlexRM HW folks, we have to first set FlexRM ring flush state and then clear it for FlexRM ring flush to work properly. Currently, the FlexRM driver has incomplete FlexRM ring flush sequence which causes repeated insmod+rmmod of mailbox client drivers to fail. This patch

[PATCH 1/4] dmaengine: bcm-sba-raid: serialize dma_cookie_complete() using reqs_lock

2017-10-02 Thread Anup Patel
As-per documentation in driver/dma/dmaengine.h, the dma_cookie_complete() API should be called with lock held. This patch ensures that Broadcom SBA RAID driver calls the dma_cookie_complete() API with reqs_lock held. Signed-off-by: Anup Patel Reviewed-by: Ray Jui Reviewed-by: Scott Branden

[PATCH 0/4] Few more SBA RAID driver improvements

2017-10-02 Thread Anup Patel
This patchset does few more improvements to Broadcom SBA RAID driver. The patches are based on Linux-4.14-rc3 and can also be found at sba-raid-imp2-v1 branch of: https://github.com/Broadcom/arm64-linux.git Anup Patel (4): dmaengine: bcm-sba-raid: serialize dma_cookie_complete() using

[PATCH 3/4] dmaengine: bcm-sba-raid: Use common GPL comment header

2017-10-02 Thread Anup Patel
This patch makes the comment header of Broadcom SBA RAID driver similar to the GPL comment header used across Broadcom driver sources. Signed-off-by: Anup Patel --- drivers/dma/bcm-sba-raid.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git

[PATCH 0/4] Few more SBA RAID driver improvements

2017-10-02 Thread Anup Patel
This patchset does few more improvements to Broadcom SBA RAID driver. The patches are based on Linux-4.14-rc3 and can also be found at sba-raid-imp2-v1 branch of: https://github.com/Broadcom/arm64-linux.git Anup Patel (4): dmaengine: bcm-sba-raid: serialize dma_cookie_complete() using

[PATCH 3/4] dmaengine: bcm-sba-raid: Use common GPL comment header

2017-10-02 Thread Anup Patel
This patch makes the comment header of Broadcom SBA RAID driver similar to the GPL comment header used across Broadcom driver sources. Signed-off-by: Anup Patel --- drivers/dma/bcm-sba-raid.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git

[PATCH 2/4] dmaengine: bcm-sba-raid: Use only single mailbox channel

2017-10-02 Thread Anup Patel
Each mailbox channel used by Broadcom SBA RAID driver is a separate HW ring. Currently, Broadcom SBA RAID driver creates one DMA channel using one or more mailbox channels. When we are using more than one mailbox channels for a DMA channel, the sba_request are distributed evenly among multiple

[PATCH 4/4] dmaengine: Build bcm-sba-raid driver as loadable module for iProc SoCs

2017-10-02 Thread Anup Patel
By default, we build Broadcom SBA RAID driver as loadable module for iProc SOCs so that kernel image is little smaller and we load SBA RAID driver only when required. Signed-off-by: Anup Patel Reviewed-by: Scott Branden ---

[PATCH 2/4] dmaengine: bcm-sba-raid: Use only single mailbox channel

2017-10-02 Thread Anup Patel
Each mailbox channel used by Broadcom SBA RAID driver is a separate HW ring. Currently, Broadcom SBA RAID driver creates one DMA channel using one or more mailbox channels. When we are using more than one mailbox channels for a DMA channel, the sba_request are distributed evenly among multiple

[PATCH 4/4] dmaengine: Build bcm-sba-raid driver as loadable module for iProc SoCs

2017-10-02 Thread Anup Patel
By default, we build Broadcom SBA RAID driver as loadable module for iProc SOCs so that kernel image is little smaller and we load SBA RAID driver only when required. Signed-off-by: Anup Patel Reviewed-by: Scott Branden --- drivers/dma/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 2/5] mailbox: bcm-flexrm-mailbox: Print ring number in errors and warnings

2017-10-02 Thread Anup Patel
This patch updates all dev_err() and dev_warn() to print ring number so that we have more info for debugging. Signed-off-by: Anup Patel Reviewed-by: Scott Branden --- drivers/mailbox/bcm-flexrm-mailbox.c | 26 +- 1

[PATCH v4 5/6] mtd: spi-nor: cadence-quadspi: Fix error path in probe

2017-10-02 Thread Vignesh R
Fix the reversed goto labels, so that we disable cqspi controller only if its enabled previously. This is a minor cleanup. Signed-off-by: Vignesh R --- drivers/mtd/spi-nor/cadence-quadspi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 3/5] mailbox: bcm-flexrm-mailbox: add depends on ARCH_BCM_IPROC

2017-10-02 Thread Anup Patel
From: Scott Branden The Broadcom FlexRM Mailbox is only present in the Broadcom IPROC SoCs. Add depends on ARCH_BCM_IPROC to BCM_FLEXRX_MBOX. Signed-off-by: Scott Branden Reviewed-by: Ray Jui ---

[PATCH 2/5] mailbox: bcm-flexrm-mailbox: Print ring number in errors and warnings

2017-10-02 Thread Anup Patel
This patch updates all dev_err() and dev_warn() to print ring number so that we have more info for debugging. Signed-off-by: Anup Patel Reviewed-by: Scott Branden --- drivers/mailbox/bcm-flexrm-mailbox.c | 26 +- 1 file changed, 17 insertions(+), 9 deletions(-) diff

[PATCH v4 5/6] mtd: spi-nor: cadence-quadspi: Fix error path in probe

2017-10-02 Thread Vignesh R
Fix the reversed goto labels, so that we disable cqspi controller only if its enabled previously. This is a minor cleanup. Signed-off-by: Vignesh R --- drivers/mtd/spi-nor/cadence-quadspi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 3/5] mailbox: bcm-flexrm-mailbox: add depends on ARCH_BCM_IPROC

2017-10-02 Thread Anup Patel
From: Scott Branden The Broadcom FlexRM Mailbox is only present in the Broadcom IPROC SoCs. Add depends on ARCH_BCM_IPROC to BCM_FLEXRX_MBOX. Signed-off-by: Scott Branden Reviewed-by: Ray Jui --- drivers/mailbox/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH 5/5] mailbox: Build Broadcom FlexRM driver as loadable module for iProc SOCs

2017-10-02 Thread Anup Patel
By default, we build Broadcom FlexRM driver as loadable module for iProc SOCs so that kernel image is little smaller and we load FlexRM driver only when required. Signed-off-by: Anup Patel Reviewed-by: Scott Branden ---

[PATCH 5/5] mailbox: Build Broadcom FlexRM driver as loadable module for iProc SOCs

2017-10-02 Thread Anup Patel
By default, we build Broadcom FlexRM driver as loadable module for iProc SOCs so that kernel image is little smaller and we load FlexRM driver only when required. Signed-off-by: Anup Patel Reviewed-by: Scott Branden --- drivers/mailbox/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 4/5] mailbox: bcm-flexrm-mailbox: Use common GPL comment header

2017-10-02 Thread Anup Patel
This patch makes the comment header of Broadcom FlexRM driver similar to the GPL comment header used across Broadcom driver sources. Signed-off-by: Anup Patel --- drivers/mailbox/bcm-flexrm-mailbox.c | 18 +- 1 file changed, 13 insertions(+), 5

[PATCH 4/5] mailbox: bcm-flexrm-mailbox: Use common GPL comment header

2017-10-02 Thread Anup Patel
This patch makes the comment header of Broadcom FlexRM driver similar to the GPL comment header used across Broadcom driver sources. Signed-off-by: Anup Patel --- drivers/mailbox/bcm-flexrm-mailbox.c | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git

[PATCH v4 6/6] mtd: spi-nor: cadence-quadspi: Add runtime PM support

2017-10-02 Thread Vignesh R
Add pm_runtime* calls to cadence-quadspi driver. This is required to switch on QSPI power domain on TI 66AK2G SoC during probe. Signed-off-by: Vignesh R --- v4: Disable pm in error path. drivers/mtd/spi-nor/cadence-quadspi.c | 16 +++- 1 file changed, 15

[PATCH v4 6/6] mtd: spi-nor: cadence-quadspi: Add runtime PM support

2017-10-02 Thread Vignesh R
Add pm_runtime* calls to cadence-quadspi driver. This is required to switch on QSPI power domain on TI 66AK2G SoC during probe. Signed-off-by: Vignesh R --- v4: Disable pm in error path. drivers/mtd/spi-nor/cadence-quadspi.c | 16 +++- 1 file changed, 15 insertions(+), 1

[PATCH v4 2/6] mtd: spi-nor: cadence-quadspi: add a delay in write sequence

2017-10-02 Thread Vignesh R
As per 66AK2G02 TRM[1] SPRUHY8F section 11.15.5.3 Indirect Access Controller programming sequence, a delay equal to couple of QSPI master clock(~5ns) is required after setting CQSPI_REG_INDIRECTWR_START bit and writing data to the flash. Introduce a quirk flag CQSPI_NEEDS_WR_DELAY to handle this

[PATCH v4 2/6] mtd: spi-nor: cadence-quadspi: add a delay in write sequence

2017-10-02 Thread Vignesh R
As per 66AK2G02 TRM[1] SPRUHY8F section 11.15.5.3 Indirect Access Controller programming sequence, a delay equal to couple of QSPI master clock(~5ns) is required after setting CQSPI_REG_INDIRECTWR_START bit and writing data to the flash. Introduce a quirk flag CQSPI_NEEDS_WR_DELAY to handle this

[PATCH v4 4/6] mtd: spi-nor: cadence-quadspi: Add support to enable loop-back clock circuit

2017-10-02 Thread Vignesh R
Cadence QSPI IP has a adapted loop-back circuit which can be enabled by setting BYPASS field to 0 in READCAPTURE register. It enables use of QSPI return clock to latch the data rather than the internal QSPI reference clock. For high speed operations, adapted loop-back circuit using QSPI return

[PATCH v4 1/6] mtd: spi-nor: cadence-quadspi: Add TI 66AK2G SoC specific compatible

2017-10-02 Thread Vignesh R
Update binding documentation to add a new compatible for TI 66AK2G SoC, to handle TI SoC specific quirks in the driver. Signed-off-by: Vignesh R Acked-by: Rob Herring --- Documentation/devicetree/bindings/mtd/cadence-quadspi.txt | 4 +++- 1 file changed, 3

[PATCH v4 4/6] mtd: spi-nor: cadence-quadspi: Add support to enable loop-back clock circuit

2017-10-02 Thread Vignesh R
Cadence QSPI IP has a adapted loop-back circuit which can be enabled by setting BYPASS field to 0 in READCAPTURE register. It enables use of QSPI return clock to latch the data rather than the internal QSPI reference clock. For high speed operations, adapted loop-back circuit using QSPI return

[PATCH v4 1/6] mtd: spi-nor: cadence-quadspi: Add TI 66AK2G SoC specific compatible

2017-10-02 Thread Vignesh R
Update binding documentation to add a new compatible for TI 66AK2G SoC, to handle TI SoC specific quirks in the driver. Signed-off-by: Vignesh R Acked-by: Rob Herring --- Documentation/devicetree/bindings/mtd/cadence-quadspi.txt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff

[PATCH v4 0/6] K2G: Add QSPI support

2017-10-02 Thread Vignesh R
This series adds support for Cadence QSPI IP present in TI's 66AK2G SoC. The patches enhance the existing cadence-quadspi driver to support loopback clock circuit, pm_runtime support and tweaks for 66AK2G SoC. Change log: v4: * New patch to fix error handling sequence in probe. v3: * Fix

[PATCH v4 0/6] K2G: Add QSPI support

2017-10-02 Thread Vignesh R
This series adds support for Cadence QSPI IP present in TI's 66AK2G SoC. The patches enhance the existing cadence-quadspi driver to support loopback clock circuit, pm_runtime support and tweaks for 66AK2G SoC. Change log: v4: * New patch to fix error handling sequence in probe. v3: * Fix

Re: regression in 4.14-rc2 caused by apparmor: add base infastructure for socket mediation

2017-10-02 Thread James Bottomley
On Mon, 2017-10-02 at 21:11 -0700, John Johansen wrote: > On 10/02/2017 09:02 PM, James Bottomley wrote: > > > > The specific problem is that dnsmasq refuses to start on openSUSE > > Leap 42.2.  The specific cause is that and attempt to open a > > PF_LOCAL socket gets EACCES.  This means that

Re: regression in 4.14-rc2 caused by apparmor: add base infastructure for socket mediation

2017-10-02 Thread James Bottomley
On Mon, 2017-10-02 at 21:11 -0700, John Johansen wrote: > On 10/02/2017 09:02 PM, James Bottomley wrote: > > > > The specific problem is that dnsmasq refuses to start on openSUSE > > Leap 42.2.  The specific cause is that and attempt to open a > > PF_LOCAL socket gets EACCES.  This means that

Re: [PATCH 2/3] sched/fair: Introduce scaled capacity awareness in select_idle_sibling code path

2017-10-02 Thread Joel Fernandes
Hi Rohit, On Thu, Sep 28, 2017 at 8:09 AM, Rohit Jain wrote: [..] >>> >>> With this case, because we know from the past avg, one of the strands is >>> running low on capacity, I am trying to return a better strand for the >>> thread to start on. >>> >> I know what you're

Re: [PATCH 2/3] sched/fair: Introduce scaled capacity awareness in select_idle_sibling code path

2017-10-02 Thread Joel Fernandes
Hi Rohit, On Thu, Sep 28, 2017 at 8:09 AM, Rohit Jain wrote: [..] >>> >>> With this case, because we know from the past avg, one of the strands is >>> running low on capacity, I am trying to return a better strand for the >>> thread to start on. >>> >> I know what you're trying to do but they

Re: regression in 4.14-rc2 caused by apparmor: add base infastructure for socket mediation

2017-10-02 Thread John Johansen
On 10/02/2017 09:02 PM, James Bottomley wrote: > The specific problem is that dnsmasq refuses to start on openSUSE Leap > 42.2.  The specific cause is that and attempt to open a PF_LOCAL socket > gets EACCES.  This means that networking doesn't function on a system > with a 4.14-rc2 system. > >

Re: regression in 4.14-rc2 caused by apparmor: add base infastructure for socket mediation

2017-10-02 Thread John Johansen
On 10/02/2017 09:02 PM, James Bottomley wrote: > The specific problem is that dnsmasq refuses to start on openSUSE Leap > 42.2.  The specific cause is that and attempt to open a PF_LOCAL socket > gets EACCES.  This means that networking doesn't function on a system > with a 4.14-rc2 system. > >

regression in 4.14-rc2 caused by apparmor: add base infastructure for socket mediation

2017-10-02 Thread James Bottomley
The specific problem is that dnsmasq refuses to start on openSUSE Leap 42.2.  The specific cause is that and attempt to open a PF_LOCAL socket gets EACCES.  This means that networking doesn't function on a system with a 4.14-rc2 system. Reverting commit 651e28c5537abb39076d3949fb7618536f1d242e

regression in 4.14-rc2 caused by apparmor: add base infastructure for socket mediation

2017-10-02 Thread James Bottomley
The specific problem is that dnsmasq refuses to start on openSUSE Leap 42.2.  The specific cause is that and attempt to open a PF_LOCAL socket gets EACCES.  This means that networking doesn't function on a system with a 4.14-rc2 system. Reverting commit 651e28c5537abb39076d3949fb7618536f1d242e

[PATCH 01/12] of: overlay.c: Remove comments that state the obvious, to reduce clutter

2017-10-02 Thread frowand . list
From: Frank Rowand Follows recommendations in Documentation/process/coding-style.rst, section 8, Commenting. Some in function comments are promoted to function header comments. Signed-off-by: Frank Rowand --- drivers/of/overlay.c | 53

[PATCH 01/12] of: overlay.c: Remove comments that state the obvious, to reduce clutter

2017-10-02 Thread frowand . list
From: Frank Rowand Follows recommendations in Documentation/process/coding-style.rst, section 8, Commenting. Some in function comments are promoted to function header comments. Signed-off-by: Frank Rowand --- drivers/of/overlay.c | 53 1

[PATCH 03/12] of: overlay: rename identifiers to more reflect what they do

2017-10-02 Thread frowand . list
From: Frank Rowand This patch is aimed primarily at drivers/of/overlay.c, but those changes also have a small impact in a few other files. overlay.c is difficult to read and maintain. Improve readability: - Rename functions, types and variables to better reflect what

[PATCH 03/12] of: overlay: rename identifiers to more reflect what they do

2017-10-02 Thread frowand . list
From: Frank Rowand This patch is aimed primarily at drivers/of/overlay.c, but those changes also have a small impact in a few other files. overlay.c is difficult to read and maintain. Improve readability: - Rename functions, types and variables to better reflect what they do and to be

[PATCH 00/12] of: overlay: clean up device tree overlay code

2017-10-02 Thread frowand . list
From: Frank Rowand I have found the device tree overlay code to be difficult to read and maintain. This patch series attempts to improve that situation. The cleanup includes some changes visible to users of overlays. The only in kernel user of overlays is fixed up for

[PATCH 00/12] of: overlay: clean up device tree overlay code

2017-10-02 Thread frowand . list
From: Frank Rowand I have found the device tree overlay code to be difficult to read and maintain. This patch series attempts to improve that situation. The cleanup includes some changes visible to users of overlays. The only in kernel user of overlays is fixed up for those changes. The in

[PATCH 04/12] of: overlay: rename identifiers in dup_and_fixup_symbol_prop()

2017-10-02 Thread frowand . list
From: Frank Rowand More renaming of identifiers to better reflect what they do. Signed-off-by: Frank Rowand --- drivers/of/overlay.c | 24 ++-- 1 file changed, 18 insertions(+), 6 deletions(-) diff --git a/drivers/of/overlay.c

[PATCH 04/12] of: overlay: rename identifiers in dup_and_fixup_symbol_prop()

2017-10-02 Thread frowand . list
From: Frank Rowand More renaming of identifiers to better reflect what they do. Signed-off-by: Frank Rowand --- drivers/of/overlay.c | 24 ++-- 1 file changed, 18 insertions(+), 6 deletions(-) diff --git a/drivers/of/overlay.c b/drivers/of/overlay.c index

[PATCH 07/12] of: overlay: expand check of whether overlay changeset can be removed

2017-10-02 Thread frowand . list
From: Frank Rowand The test of whether it is safe to remove an overlay changeset looked at whether any node in the overlay changeset was in a subtree rooted at any more recently applied overlay changeset node. The test failed to determine whether any node in the overlay

[PATCH 06/12] of: overlay: detect cases where device tree may become corrupt

2017-10-02 Thread frowand . list
From: Frank Rowand When an attempt to apply an overlay changeset fails, an effort is made to revert any partial application of the changeset. When an attempt to remove an overlay changeset fails, an effort is made to re-apply any partial reversion of the changeset. The

[PATCH 07/12] of: overlay: expand check of whether overlay changeset can be removed

2017-10-02 Thread frowand . list
From: Frank Rowand The test of whether it is safe to remove an overlay changeset looked at whether any node in the overlay changeset was in a subtree rooted at any more recently applied overlay changeset node. The test failed to determine whether any node in the overlay changeset was the root

[PATCH 06/12] of: overlay: detect cases where device tree may become corrupt

2017-10-02 Thread frowand . list
From: Frank Rowand When an attempt to apply an overlay changeset fails, an effort is made to revert any partial application of the changeset. When an attempt to remove an overlay changeset fails, an effort is made to re-apply any partial reversion of the changeset. The existing code does not

[PATCH 08/12] of: overlay: loosen overly strict phandle clash check

2017-10-02 Thread frowand . list
From: Frank Rowand When an overlay contains a node that already exists in the live device tree, the overlay node is not allowed to change the phandle of the existing node. The existing check refused to allow an overlay node to set the node phandle even when the existing

[PATCH 08/12] of: overlay: loosen overly strict phandle clash check

2017-10-02 Thread frowand . list
From: Frank Rowand When an overlay contains a node that already exists in the live device tree, the overlay node is not allowed to change the phandle of the existing node. The existing check refused to allow an overlay node to set the node phandle even when the existing node did not have a

[PATCH 02/12] of: overlay.c: Convert comparisons to zero or NULL to logical expressions

2017-10-02 Thread frowand . list
From: Frank Rowand Use normal shorthand for comparing a variable to zero. For variable "XXX": convert (XXX == 0) to (!XXX) convert (XXX != 0) to (XXX) Signed-off-by: Frank Rowand --- drivers/of/overlay.c | 36

[PATCH 02/12] of: overlay.c: Convert comparisons to zero or NULL to logical expressions

2017-10-02 Thread frowand . list
From: Frank Rowand Use normal shorthand for comparing a variable to zero. For variable "XXX": convert (XXX == 0) to (!XXX) convert (XXX != 0) to (XXX) Signed-off-by: Frank Rowand --- drivers/of/overlay.c | 36 ++-- 1 file changed, 18 insertions(+), 18

[PATCH 11/12] of: overlay: remove a dependency on device node full_name

2017-10-02 Thread frowand . list
From: Frank Rowand The "%pOF" printf format was recently added to print the full name of a device tree node, with the intent of changing the node full_name field to contain only the node name instead of the full path of the node. dup_and_fixup_symbol_prop() duplicates a

[PATCH 11/12] of: overlay: remove a dependency on device node full_name

2017-10-02 Thread frowand . list
From: Frank Rowand The "%pOF" printf format was recently added to print the full name of a device tree node, with the intent of changing the node full_name field to contain only the node name instead of the full path of the node. dup_and_fixup_symbol_prop() duplicates a property from the

[PATCH 10/12] of: overlay: simplify applying symbols from an overlay

2017-10-02 Thread frowand . list
From: Frank Rowand The code to apply symbols from an overlay to the live device tree was implemented with the intent to be minimally intrusive on the existing code. After recent restructuring of the overlay apply code, it is easier to disintangle the code that applies the

[PATCH 10/12] of: overlay: simplify applying symbols from an overlay

2017-10-02 Thread frowand . list
From: Frank Rowand The code to apply symbols from an overlay to the live device tree was implemented with the intent to be minimally intrusive on the existing code. After recent restructuring of the overlay apply code, it is easier to disintangle the code that applies the symbols, and to make

[PATCH 05/12] of: overlay: minor restructuring

2017-10-02 Thread frowand . list
From: Frank Rowand Continue improving the readability of overlay.c. The previous patches renamed identifiers. This patch is split out from the previous patches to make the previous patches easier to review. Changes are: - minor code restructuring - some

[PATCH 09/12] of: overlay: avoid race condition between applying multiple overlays

2017-10-02 Thread frowand . list
From: Frank Rowand The process of applying an overlay consists of: - unflatten an overlay FDT (flattened device tree) into an EDT (expanded device tree) - fixup the phandle values in the overlay EDT to fit in a range above the phandle values in the live device

[PATCH 12/12] of: overlay: remove unneeded check for NULL kbasename()

2017-10-02 Thread frowand . list
From: Frank Rowand kbasename() will not return NULL if passed a valid string. If the parameter passed to kbasename() in this case is already NULL then the devicetree has been corrupted. Signed-off-by: Frank Rowand --- drivers/of/overlay.c | 2 --

[PATCH 05/12] of: overlay: minor restructuring

2017-10-02 Thread frowand . list
From: Frank Rowand Continue improving the readability of overlay.c. The previous patches renamed identifiers. This patch is split out from the previous patches to make the previous patches easier to review. Changes are: - minor code restructuring - some initialization of an overlay

[PATCH 09/12] of: overlay: avoid race condition between applying multiple overlays

2017-10-02 Thread frowand . list
From: Frank Rowand The process of applying an overlay consists of: - unflatten an overlay FDT (flattened device tree) into an EDT (expanded device tree) - fixup the phandle values in the overlay EDT to fit in a range above the phandle values in the live device tree - create the

[PATCH 12/12] of: overlay: remove unneeded check for NULL kbasename()

2017-10-02 Thread frowand . list
From: Frank Rowand kbasename() will not return NULL if passed a valid string. If the parameter passed to kbasename() in this case is already NULL then the devicetree has been corrupted. Signed-off-by: Frank Rowand --- drivers/of/overlay.c | 2 -- 1 file changed, 2 deletions(-) diff --git

Re: 4879b7ae05 ("Merge tag 'dmaengine-4.12-rc1' of .."): WARNING: kernel stack regs at bd92bc2e in 01-cpu-hotplug:3811 has bad 'bp' value 000001be

2017-10-02 Thread Fengguang Wu
Hi Josh, On Mon, Oct 02, 2017 at 04:31:09PM -0500, Josh Poimboeuf wrote: On Mon, Oct 02, 2017 at 04:26:54PM -0500, Josh Poimboeuf wrote: Fengguang, assuming it's reliably recreatable, any chance you could recreate with the following patch? Sure, I'll try your patch on v4.14-rc3 since it

Re: 4879b7ae05 ("Merge tag 'dmaengine-4.12-rc1' of .."): WARNING: kernel stack regs at bd92bc2e in 01-cpu-hotplug:3811 has bad 'bp' value 000001be

2017-10-02 Thread Fengguang Wu
Hi Josh, On Mon, Oct 02, 2017 at 04:31:09PM -0500, Josh Poimboeuf wrote: On Mon, Oct 02, 2017 at 04:26:54PM -0500, Josh Poimboeuf wrote: Fengguang, assuming it's reliably recreatable, any chance you could recreate with the following patch? Sure, I'll try your patch on v4.14-rc3 since it

Re: [RESEND PATCH] prctl: add PR_[GS]ET_PDEATHSIG_PROC

2017-10-02 Thread Eric W. Biederman
Andrew Morton writes: > On Fri, 29 Sep 2017 14:30:58 +0200 Jürg Billeter wrote: > >> PR_SET_PDEATHSIG sets a parent death signal that the calling process >> will get when its parent thread dies, even when the result of getppid() >> doesn't change

Re: [RESEND PATCH] prctl: add PR_[GS]ET_PDEATHSIG_PROC

2017-10-02 Thread Eric W. Biederman
Andrew Morton writes: > On Fri, 29 Sep 2017 14:30:58 +0200 Jürg Billeter wrote: > >> PR_SET_PDEATHSIG sets a parent death signal that the calling process >> will get when its parent thread dies, even when the result of getppid() >> doesn't change because the calling process is reparented to a

Re: [RFC v2 PATCH] x86/boot: Add the secdata section to the setup header

2017-10-02 Thread Gary Lin
On Fri, Sep 08, 2017 at 01:59:00PM -0700, h...@zytor.com wrote: > On September 8, 2017 2:45:10 AM PDT, Gary Lin wrote: > >On Thu, Sep 07, 2017 at 02:16:21PM -0700, h...@zytor.com wrote: > >> On September 7, 2017 2:44:51 AM PDT, Gary Lin wrote: > >> >On Thu, Jun 01,

Re: [RFC v2 PATCH] x86/boot: Add the secdata section to the setup header

2017-10-02 Thread Gary Lin
On Fri, Sep 08, 2017 at 01:59:00PM -0700, h...@zytor.com wrote: > On September 8, 2017 2:45:10 AM PDT, Gary Lin wrote: > >On Thu, Sep 07, 2017 at 02:16:21PM -0700, h...@zytor.com wrote: > >> On September 7, 2017 2:44:51 AM PDT, Gary Lin wrote: > >> >On Thu, Jun 01, 2017 at 08:46:26AM +, Ard

Re: [PATCH] vfs: hard-ban creating files with control characters in the name

2017-10-02 Thread Adam Borowski
On Tue, Oct 03, 2017 at 03:07:24AM +0100, Al Viro wrote: > On Tue, Oct 03, 2017 at 02:50:42AM +0200, Adam Borowski wrote: > > Anything with bytes 1-31,127 will get -EACCES. > > > > Especially \n is bad: instead of natural file-per-line, you need an > > user-unfriendly feature of -print0 added to

Re: [PATCH] vfs: hard-ban creating files with control characters in the name

2017-10-02 Thread Adam Borowski
On Tue, Oct 03, 2017 at 03:07:24AM +0100, Al Viro wrote: > On Tue, Oct 03, 2017 at 02:50:42AM +0200, Adam Borowski wrote: > > Anything with bytes 1-31,127 will get -EACCES. > > > > Especially \n is bad: instead of natural file-per-line, you need an > > user-unfriendly feature of -print0 added to

Re: [BUG] fs/dcache: might_sleep is called under a spinlock

2017-10-02 Thread Al Viro
On Tue, Oct 03, 2017 at 10:38:25AM +0800, Jia-Ju Bai wrote: > According to fs/dcache.c, might_sleep is called under a spinlock, > and the function call path is: > d_prune_aliases (acquire the spinlock) > dput > might_sleep > > This bug is found by my static analysis tool and my code review.

Re: [BUG] fs/dcache: might_sleep is called under a spinlock

2017-10-02 Thread Al Viro
On Tue, Oct 03, 2017 at 10:38:25AM +0800, Jia-Ju Bai wrote: > According to fs/dcache.c, might_sleep is called under a spinlock, > and the function call path is: > d_prune_aliases (acquire the spinlock) > dput > might_sleep > > This bug is found by my static analysis tool and my code review.

[RFC PATCH v2 07/31] KVM: arm64: Setup vttbr_el2 on each VM entry

2017-10-02 Thread Jintack Lim
From: Christoffer Dall Now that the vttbr value will be different depending on the VM's exception level, we set it on each VM entry. We only have one mmu instance at this point, but there will be multiple of them if we come to run nested VMs. Signed-off-by:

[RFC PATCH v2 07/31] KVM: arm64: Setup vttbr_el2 on each VM entry

2017-10-02 Thread Jintack Lim
From: Christoffer Dall Now that the vttbr value will be different depending on the VM's exception level, we set it on each VM entry. We only have one mmu instance at this point, but there will be multiple of them if we come to run nested VMs. Signed-off-by: Christoffer Dall Signed-off-by:

[RFC PATCH v2 08/31] KVM: arm/arm64: Make mmu functions non-static

2017-10-02 Thread Jintack Lim
From: Christoffer Dall Make mmu functions non-static so that we can reuse those functions to support mmu for the nested VMs. Signed-off-by: Christoffer Dall Signed-off-by: Jintack Lim ---

[RFC PATCH v2 04/31] KVM: arm/arm64: Abstract stage-2 MMU state into a separate structure

2017-10-02 Thread Jintack Lim
From: Christoffer Dall Abstract stage-2 MMU state into a separate structure and change all callers referring to page tables, VMIDs, and the VTTBR to use this new indirection. This is about to become very handy when using shadow stage-2 page tables. Signed-off-by:

[RFC PATCH v2 06/31] KVM: arm64: Invalidate virtual EL2 TLB entries when needed

2017-10-02 Thread Jintack Lim
From: Christoffer Dall Sometimes when we are invalidating the TLB for a certain S2 MMU context, this context can also have EL2 context associated with it and we have to invalidate this too. Signed-off-by: Christoffer Dall Signed-off-by:

[RFC PATCH v2 08/31] KVM: arm/arm64: Make mmu functions non-static

2017-10-02 Thread Jintack Lim
From: Christoffer Dall Make mmu functions non-static so that we can reuse those functions to support mmu for the nested VMs. Signed-off-by: Christoffer Dall Signed-off-by: Jintack Lim --- arch/arm64/include/asm/kvm_mmu.h | 9 virt/kvm/arm/mmu.c | 94

[RFC PATCH v2 04/31] KVM: arm/arm64: Abstract stage-2 MMU state into a separate structure

2017-10-02 Thread Jintack Lim
From: Christoffer Dall Abstract stage-2 MMU state into a separate structure and change all callers referring to page tables, VMIDs, and the VTTBR to use this new indirection. This is about to become very handy when using shadow stage-2 page tables. Signed-off-by: Christoffer Dall

[RFC PATCH v2 06/31] KVM: arm64: Invalidate virtual EL2 TLB entries when needed

2017-10-02 Thread Jintack Lim
From: Christoffer Dall Sometimes when we are invalidating the TLB for a certain S2 MMU context, this context can also have EL2 context associated with it and we have to invalidate this too. Signed-off-by: Christoffer Dall Signed-off-by: Jintack Lim --- virt/kvm/arm/arm.c | 5 +

  1   2   3   4   5   6   7   8   9   10   >