Re: [PATCH] kbuild: run the checker after the compiler

2020-06-22 Thread Masahiro Yamada
On Tue, Jun 23, 2020 at 12:47 AM Luc Van Oostenryck wrote: > > Since the pre-git time the checker is run first, before the compiler. > But if the source file contains some syntax error, the warnings from > the compiler are more useful than those from sparse (and other > checker most probably

drivers/staging/wfx/fwio.c:88:2: note: in expansion of macro 'if'

2020-06-22 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: dd0d718152e4c65b173070d48ea9dfc06894c3e5 commit: 652b4afb240e5dc196995597942309e89e89c767 staging: wfx: load firmware date: 9 months ago config: xtensa-randconfig-m031-20200623 (attached as .config)

Re: [PATCH] docs: f2fs: fix a broken table

2020-06-22 Thread Mauro Carvalho Chehab
Em Mon, 22 Jun 2020 11:22:09 -0600 Jonathan Corbet escreveu: > On Mon, 22 Jun 2020 10:11:06 -0700 > Eric Biggers wrote: > > > Someone already sent out a fix for this: > > https://lkml.kernel.org/linux-doc/52f851cb5c9fd2ecae97deec7e168e66b8c295c3.1591137229.git.mchehab+hua...@kernel.org/ No

KASAN: use-after-free Read in cgroup_throttle_swaprate

2020-06-22 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:7ae77150 Merge tag 'powerpc-5.8-1' of git://git.kernel.org.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=11d6561510 kernel config: https://syzkaller.appspot.com/x/.config?x=be4578b3f1083656

Re: [PATCH] kbuild: Provide way to actually disable stack protector

2020-06-22 Thread Kees Cook
On Tue, Jun 23, 2020 at 11:33:53AM +0900, Masahiro Yamada wrote: > On Tue, Jun 23, 2020 at 4:02 AM Kees Cook wrote: > > > > Some builds of GCC enable stack protector by default. Simply removing > > the arguments is not sufficient to disable stack protector, as the stack > > protector for those

Re: [PATCH] ASoC: fsl_easrc: Fix uninitialized scalar variable in fsl_easrc_set_ctx_format

2020-06-22 Thread Nicolin Chen
On Mon, Jun 22, 2020 at 05:03:31PM +0800, Shengjiu Wang wrote: > The "ret" in fsl_easrc_set_ctx_format is not initialized, then > the unknown value maybe returned by this function. > > Fixes: 955ac624058f ("ASoC: fsl_easrc: Add EASRC ASoC CPU DAI drivers") > Signed-off-by: Shengjiu Wang

Re: [PATCH v7 0/7] Add interrupt support to FPGA DFL drivers

2020-06-22 Thread Xu Yilun
On Mon, Jun 22, 2020 at 05:27:20AM -0700, Tom Rix wrote: > In addition to reviewing, I have run these changes on the pac a10 card and > while i do not have an afu using interrupts, I have exercised some of the new > interfaces. > > The most useful i have submitted to selftests drivers/fpga.  In

Re: kprobe: __blkdev_put probe is missed

2020-06-22 Thread Masami Hiramatsu
On Tue, 23 Jun 2020 09:38:01 +0900 Masami Hiramatsu wrote: > On Tue, 23 Jun 2020 08:47:06 +0900 > Masami Hiramatsu wrote: > > > On Mon, 22 Jun 2020 09:01:48 -0400 > > Steven Rostedt wrote: > > > > > On Mon, 22 Jun 2020 08:27:53 +0800 > > > Ming Lei wrote: > > > > > > > Can you kprobe guys

Re: [PATCH v7 17/19] mm: memcg/slab: use a single set of kmem_caches for all allocations

2020-06-22 Thread Shakeel Butt
On Mon, Jun 22, 2020 at 6:58 PM Roman Gushchin wrote: > > Instead of having two sets of kmem_caches: one for system-wide and > non-accounted allocations and the second one shared by all accounted > allocations, we can use just one. > > The idea is simple: space for obj_cgroup metadata can be

Re: [PATCH] binder: fix null deref of proc->context

2020-06-22 Thread Greg Kroah-Hartman
On Mon, Jun 22, 2020 at 01:59:04PM -0700, Todd Kjos wrote: > On Mon, Jun 22, 2020 at 1:18 PM Todd Kjos wrote: > > > > On Mon, Jun 22, 2020 at 1:09 PM Christian Brauner > > wrote: > > > > > > On Mon, Jun 22, 2020 at 01:07:15PM -0700, Todd Kjos wrote: > > > > The binder driver makes the assumption

Re: [PATCH v2 0/6] kernfs: proposed locking and concurrency improvement

2020-06-22 Thread Greg Kroah-Hartman
On Mon, Jun 22, 2020 at 02:27:38PM -0700, Rick Lindsley wrote: > > On Mon, Jun 22, 2020 at 01:48:45PM -0400, Tejun Heo wrote: > > > It should be obvious that representing each consecutive memory range with a > > separate directory entry is far from an optimal way of representing > > something

Re: [TEGRA194_CPUFREQ Patch v3 3/4] cpufreq: Add Tegra194 cpufreq driver

2020-06-22 Thread Sumit Gupta
Hi Viresh, Thank you for the review. please find my reply inline. +++ b/drivers/cpufreq/tegra194-cpufreq.c @@ -0,0 +1,403 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Copyright (c) 2019, NVIDIA CORPORATION. All rights reserved 2020 + */ + +#include +#include

Re: [PATCH v7 09/19] mm: memcg/slab: charge individual slab objects instead of pages

2020-06-22 Thread Shakeel Butt
On Mon, Jun 22, 2020 at 6:58 PM Roman Gushchin wrote: > > Switch to per-object accounting of non-root slab objects. > > Charging is performed using obj_cgroup API in the pre_alloc hook. > Obj_cgroup is charged with the size of the object and the size of > metadata: as now it's the size of an

[PATCH V2 3/6] dt-bindings: regulator: add MP5496 regulator compatible

2020-06-22 Thread Kathiravan T
IPQ6018 uses the PMIC MP5496. Add the binding for the same. Signed-off-by: Kathiravan T --- Documentation/devicetree/bindings/regulator/qcom,smd-rpm-regulator.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/regulator/qcom,smd-rpm-regulator.txt

[PATCH V2 6/6] dt-bindings: regulator: convert QCOM SMD-RPM regulator document to YAML schema

2020-06-22 Thread Kathiravan T
Convert qcom,smd-rpm-regulator.txt document to YAML schema Signed-off-by: Kathiravan T --- .../bindings/regulator/qcom,smd-rpm-regulator.txt | 321 - .../bindings/regulator/qcom,smd-rpm-regulator.yaml | 106 +++ 2 files changed, 106 insertions(+), 321 deletions(-)

[PATCH V2 4/6] regulator: qcom_smd: Add MP5496 regulators

2020-06-22 Thread Kathiravan T
IPQ6018 SoC uses the PMIC MP5496. SMPA2 and LDOA2 regulator controls the APSS and SDCC voltage scaling respectively. Add support for the same. Signed-off-by: Kathiravan T --- drivers/regulator/qcom_smd-regulator.c | 34 ++ 1 file changed, 34 insertions(+) diff

[PATCH V2 5/6] dt-bindings: soc: qcom: convert the SMD-RPM document to YAML schema

2020-06-22 Thread Kathiravan T
Convert the qcom,smd-rpm.txt document to YAML schema Signed-off-by: Kathiravan T --- .../devicetree/bindings/soc/qcom/qcom,smd-rpm.txt | 63 --- .../devicetree/bindings/soc/qcom/qcom,smd-rpm.yaml | 92 ++ 2 files changed, 92 insertions(+), 63 deletions(-)

[PATCH V2 1/6] dt-bindings: soc: qcom: Add IPQ6018 compatible

2020-06-22 Thread Kathiravan T
This patch adds the dt-binding for the rpm on the Qualcomm IPQ6018 platform. Signed-off-by: Kathiravan T --- Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm.txt

[PATCH V2 2/6] soc: qcom: smd-rpm: Add IPQ6018 compatible

2020-06-22 Thread Kathiravan T
This patch adds a compatible for the rpm on the Qualcomm IPQ6018 platform. Signed-off-by: Kathiravan T --- drivers/soc/qcom/smd-rpm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/soc/qcom/smd-rpm.c b/drivers/soc/qcom/smd-rpm.c index 005dd30..1a5226a 100644 ---

[PATCH V2 0/6] Add frequency / voltage scaling support for IPQ6018 SoC

2020-06-22 Thread Kathiravan T
IPQ6018 SoC uses the PMIC MP5496. SMPA2 and LDOA2 regulator of MP5496 controls the APSS and SDCC voltage scaling respectively. Add support for the same. changes since V1: - Moved YAML conversion to the last as per Mark's comments Kathiravan T (6): dt-bindings: soc: qcom: Add IPQ6018

[PATCH] cpufreq: cppc: Reorder code and remove apply_hisi_workaround variable

2020-06-22 Thread Viresh Kumar
With the current approach we have an extra check in the cppc_cpufreq_get_rate() callback, which checks if hisilicon's get rate implementation should be used instead. While it works fine, the approach isn't very straight forward, over that we have an extra check in the routine. Rearrange code and

Re: [PATCH] ASoC: fsl_mqs: Fix unchecked return value for clk_prepare_enable

2020-06-22 Thread Shengjiu Wang
On Tue, Jun 23, 2020 at 12:08 AM Markus Elfring wrote: > > > Fix unchecked return value for clk_prepare_enable. > > > > And because clk_prepare_enable and clk_disable_unprepare should > > check input clock parameter is NULL or not, then we don't need > > to check it before calling the function. >

[PATCH 2/2] cpufreq: intel_pstate: Allow raw energy performance preference value

2020-06-22 Thread Srinivas Pandruvada
Currently using attribute "energy_performance_preference", user space can write one of the four per-defined preference string. These preference strings gets mapped to a hard-coded Energy-Performance Preference (EPP) or Energy-Performance Bias (EPB) knob. These four values supposed to cover broad

[PATCH 1/2] cpufreq: intel_pstate: Allow enable/disable energy efficiency

2020-06-22 Thread Srinivas Pandruvada
By default intel_pstate driver disables energy efficiency by setting MSR_IA32_POWER_CTL bit 19 for Kaby Lake desktop CPU model in HWP mode. This CPU model is also shared by Coffee Lake desktop CPUs. This allows these systems to reach maximum possible frequency. But this adds power penalty, which

Re: [PATCH v2 0/6] kernfs: proposed locking and concurrency improvement

2020-06-22 Thread Ian Kent
On Mon, 2020-06-22 at 20:03 +0200, Greg Kroah-Hartman wrote: > On Mon, Jun 22, 2020 at 01:48:45PM -0400, Tejun Heo wrote: > > Hello, Ian. > > > > On Sun, Jun 21, 2020 at 12:55:33PM +0800, Ian Kent wrote: > > > > > They are used for hotplugging and partitioning memory. The > > > > > size of > > >

[tip:x86/fsgsbase] BUILD SUCCESS a5d25e01c8146ad8846da4760422e12242fceafe

2020-06-22 Thread kernel test robot
randconfig-a006-20200622 i386 randconfig-a002-20200622 i386 randconfig-a003-20200622 i386 randconfig-a001-20200622 i386 randconfig-a005-20200622 i386 randconfig-a004-20200622 x86_64 randconfig-a012-20200623 x86_64

Re: [PATCH v8] mm: Proactive compaction

2020-06-22 Thread Nathan Chancellor
On Mon, Jun 22, 2020 at 09:32:12PM -0700, Nitin Gupta wrote: > On 6/22/20 7:26 PM, Nathan Chancellor wrote: > > On Tue, Jun 16, 2020 at 01:45:27PM -0700, Nitin Gupta wrote: > >> For some applications, we need to allocate almost all memory as > >> hugepages. However, on a running system,

Re: [PATCH v1 1/3] scsi: ufs: add write booster feature support

2020-06-22 Thread Kyuho Choi
Hi Rob, On 6/22/20, Rob Clark wrote: > On Sun, Jun 21, 2020 at 12:58 AM Bjorn Andersson > wrote: >> >> On Sun 21 Jun 00:40 PDT 2020, Avri Altman wrote: >> >> > >> > > >> > > On Wed, Apr 8, 2020 at 3:00 PM Asutosh Das >> > > wrote: >> > > > >> > > > The write performance of TLC NAND is

Re: [PATCH v8] mm: Proactive compaction

2020-06-22 Thread Nitin Gupta
On 6/22/20 7:26 PM, Nathan Chancellor wrote: > On Tue, Jun 16, 2020 at 01:45:27PM -0700, Nitin Gupta wrote: >> For some applications, we need to allocate almost all memory as >> hugepages. However, on a running system, higher-order allocations can >> fail if the memory is fragmented. Linux kernel

[RFC PATCH v3 5/5] scsi: ufs: Prepare HPB read for cached sub-region

2020-06-22 Thread Daejun Park
This patch changes the read I/O to the HPB read I/O. If the logical address of the read I/O belongs to active sub-region, the HPB driver modifies the read I/O command to HPB read. It modifies the upiu command of UFS instead of modifying the existing SCSI command. In the HPB version 1.0, the

[RFC PATCH v3 4/5] scsi: ufs: L2P map management for HPB read

2020-06-22 Thread Daejun Park
This is a patch for managing L2P map in HPB module. The HPB divides logical addresses into several regions. A region consists of several sub-regions. The sub-region is a basic unit where L2P mapping is managed. The driver loads L2P mapping data of each sub-region. The loaded sub-region is called

Re: [PATCH v8] mm: Proactive compaction

2020-06-22 Thread maobibo
On 06/23/2020 10:26 AM, Nathan Chancellor wrote: > On Tue, Jun 16, 2020 at 01:45:27PM -0700, Nitin Gupta wrote: >> For some applications, we need to allocate almost all memory as >> hugepages. However, on a running system, higher-order allocations can >> fail if the memory is fragmented. Linux

[PATCH v2 2/3] crypto: hisilicon/zip - permit users to specify NUMA node

2020-06-22 Thread Barry Song
If users don't specify NUMA node, the driver will use the ZIP module near the CPU allocating acomp. Otherwise, it uses the ZIP module according to the requirement of users. Cc: Zhou Wang Signed-off-by: Barry Song --- drivers/crypto/hisilicon/zip/zip.h| 2 +-

[PATCH v2 1/3] crypto: permit users to specify numa node of acomp hardware

2020-06-22 Thread Barry Song
For a Linux server with NUMA, there are possibly multiple (de)compressors which are either local or remote to some NUMA node. Some drivers will automatically use the (de)compressor near the CPU calling acomp_alloc(). However, it is not necessarily correct because users who send acomp_req could be

[PATCH v2 0/3] crypto: allow users to specify acomp hardware from a desired NUMA node

2020-06-22 Thread Barry Song
For a typical Linux server, probably there are several hardware modules. For example, numa node0 has a compressor, numa node2 has a same module. Some drivers are automatically using the module near the CPU calling acomp_alloc. But it isn't necessarily correct. Just like memory allocation API like

[PATCH v2 3/3] mm/zswap: allocate acomp on the numa node committing acomp_req

2020-06-22 Thread Barry Song
zswap is allocating acomp on one different cpu with those cpus which will eventually committing acomp_req. this patch specifies the numa node to help compression/decompression done by local (de)compressors hardware. Cc: Seth Jennings Cc: Dan Streetman Cc: Vitaly Wool Cc: Herbert Xu Cc: David

Re: [PATCH v2] GUE: Fix a typo

2020-06-22 Thread David Miller
From: Aiden Leong Date: Mon, 22 Jun 2020 20:04:58 -0700 > Fix a typo in gue.h > > Signed-off-by: Aiden Leong Applied, thank you.

[PATCH 2/4] interconnect: qcom: Only wait for completion in AMC/WAKE by default

2020-06-22 Thread Mike Tipton
Change the default TCS wait behavior to only wait for completion in AMC and WAKE. Waiting isn't necessary in the SLEEP TCS, since votes are only being removed in this case. Resources can be safely disabled asynchronously in parallel with the rest of the power collapse sequence. This reduces the

[PATCH 4/4] interconnect: qcom: Fix small BW votes being truncated to zero

2020-06-22 Thread Mike Tipton
Small BW votes that translate to less than a single BCM unit are currently truncated to zero. Ensure that non-zero BW requests always result in at least a vote of 1 to BCM. Fixes: 976daac4a1c5 ("interconnect: qcom: Consolidate interconnect RPMh support") Signed-off-by: Mike Tipton ---

Re: [PATCH v2 1/3] ALSA: compress: document the compress audio state machine

2020-06-22 Thread Vinod Koul
On 22-06-20, 15:13, Charles Keepax wrote: > On Mon, Jun 22, 2020 at 08:28:48AM -0500, Pierre-Louis Bossart wrote: > > On 6/22/20 1:58 AM, Vinod Koul wrote: +--+ > > a) can you clarify if we can go from running to free directly? is > > this really a legit transition?

Re: [PATCH RESEND] net/cisco: Fix a sleep-in-atomic-context bug in enic_init_affinity_hint()

2020-06-22 Thread David Miller
Networking changes must be submitted with net...@vger.kernel.org Thank you.

[PATCH 3/4] interconnect: qcom: Add support for per-BCM scaling factors

2020-06-22 Thread Mike Tipton
Currently, bcm-voter always assumes requests are made in KBps and that BCM HW always wants them in Bps, so it always scales the requests by 1000. However, certain use cases and BCMs may use different units. Thus, add support for BCM-specific scaling factors. Signed-off-by: Mike Tipton ---

[PATCH 0/4] interconnect: qcom: Misc bcm-voter changes and fixes

2020-06-22 Thread Mike Tipton
These changes are mostly unrelated, but there are some dependencies between them. Mike Tipton (4): interconnect: qcom: Support bcm-voter-specific TCS wait behavior interconnect: qcom: Only wait for completion in AMC/WAKE by default interconnect: qcom: Add support for per-BCM scaling factors

[PATCH 1/4] interconnect: qcom: Support bcm-voter-specific TCS wait behavior

2020-06-22 Thread Mike Tipton
Currently, all bcm-voters set tcs_cmd::wait=true for the last VCD command in each TCS (AMC, WAKE, and SLEEP). However, some bcm-voters don't need the completion and instead need to optimize for latency. For instance, disabling wait-for-completion in the WAKE set can decrease resume latency and

[PATCH] irqchip/riscv-plic: Fix typo in irq-riscv-intc.c

2020-06-22 Thread Greentime Hu
This patch fixes a spelling typo in irq-riscv-intc.c Signed-off-by: Greentime Hu --- drivers/irqchip/irq-riscv-intc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-riscv-intc.c b/drivers/irqchip/irq-riscv-intc.c index a6f97fa6ff69..8017f6d32d52 100644

Re: [PATCH net v2] mptcp: drop sndr_key in mptcp_syn_options

2020-06-22 Thread David Miller
From: Geliang Tang Date: Mon, 22 Jun 2020 19:45:58 +0800 > In RFC 8684, we don't need to send sndr_key in SYN package anymore, so drop > it. > > Fixes: cc7972ea1932 ("mptcp: parse and emit MP_CAPABLE option according to v1 > spec") > Signed-off-by: Geliang Tang Applied and queued up for

[PATCH 2/2] interconnect: qcom: Don't redefine bucket/tag macros

2020-06-22 Thread Mike Tipton
Replace internal bucket/tag macros with those defined in dt-bindings. Signed-off-by: Mike Tipton --- drivers/interconnect/qcom/icc-rpmh.h | 18 ++ 1 file changed, 2 insertions(+), 16 deletions(-) diff --git a/drivers/interconnect/qcom/icc-rpmh.h

[PATCH 1/2] dt-bindings: interconnect: Add generic qcom bindings

2020-06-22 Thread Mike Tipton
Add generic qcom interconnect bindings that are common across platforms. In particular, these include QCOM_ICC_TAG_* macros that clients can use when calling icc_set_tag(). Signed-off-by: Mike Tipton --- include/dt-bindings/interconnect/qcom,icc.h | 26 + 1 file changed, 26

[PATCH 0/2] interconnect: qcom: Add common dt-bindings

2020-06-22 Thread Mike Tipton
Add common dt-bindings to replace internal macros. Mike Tipton (2): dt-bindings: interconnect: Add generic qcom bindings interconnect: qcom: Don't redefine bucket/tag macros drivers/interconnect/qcom/icc-rpmh.h| 18 ++ include/dt-bindings/interconnect/qcom,icc.h | 26

Re: [PATCH v2 1/3] ALSA: compress: document the compress audio state machine

2020-06-22 Thread Vinod Koul
On 22-06-20, 08:28, Pierre-Louis Bossart wrote: > > > On 6/22/20 1:58 AM, Vinod Koul wrote: > > So we had some discussions of the stream states, so I thought it is a > > good idea to document the state transitions, so add it documentation > > > > Signed-off-by: Vinod Koul > > --- > >

[PATCH 18/22] gpiolib: cdev: support setting debounce

2020-06-22 Thread Kent Gibson
Add support for setting debounce on a line via the GPIO uAPI. Where debounce is not supported by hardware, a software debounce is provided. Signed-off-by: Kent Gibson --- The implementation of the software debouncer waits for the line to be stable for the debounce period before determining if

[PATCH 22/22] tools: gpio: support monitoring multiple lines

2020-06-22 Thread Kent Gibson
Extend gpio-event-mon to support monitoring multiple lines. This would require multiple lineevent requests to implement using uAPI V1, but can be performed with a single line request using uAPI V2. Signed-off-by: Kent Gibson --- tools/gpio/gpio-event-mon.c | 41

[PATCH 21/22] tools: gpio: add debounce support to gpio-event-mon

2020-06-22 Thread Kent Gibson
Add support for debouncing monitored lines to gpio-event-mon. Signed-off-by: Kent Gibson --- tools/gpio/gpio-event-mon.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/tools/gpio/gpio-event-mon.c b/tools/gpio/gpio-event-mon.c index d8d692f67b9e..ec90e44389dc

[PATCH 20/22] tools: gpio: switch tools to V2 uAPI

2020-06-22 Thread Kent Gibson
Update all the GPIO tools to use uAPI V2 instead of uAPI V1. The tools command lines and behaviour remain unchanged, although lsgpio now reports additional information not available through V1, specifically the edge detection and debounce configuration. Signed-off-by: Kent Gibson ---

[PATCH 15/22] gpiolib: add build option for CDEV V1 ABI

2020-06-22 Thread Kent Gibson
Add a build option to allow the removal of the CDEV v1 ABI. Suggested-by: Bartosz Golaszewski Signed-off-by: Kent Gibson --- This patch is before the V2 implementation, and is non-functional until that patch, as some parts of that patch would be written slightly differently if removing V1 was

[PATCH 19/22] gpio: uapi: document uAPI V1 as deprecated

2020-06-22 Thread Kent Gibson
Update uAPI documentation to deprecate V1 structs and ioctls. Signed-off-by: Kent Gibson --- include/uapi/linux/gpio.h | 26 ++ 1 file changed, 26 insertions(+) diff --git a/include/uapi/linux/gpio.h b/include/uapi/linux/gpio.h index e4ed6f79e332..752d63f56b0d 100644

[RFC PATCH v3 3/5] scsi: ufs: Introduce HPB module

2020-06-22 Thread Daejun Park
This is a patch for the HPB module. The HPB module queries UFS for device information during initialization. We added the export symbol to two functions in ufshcd.c to initialize the HPB module. The HPB module can be loaded or built-in as needed. The mininum size of the memory pool used in the

[PATCH 17/22] gpiolib: cdev: report edge detection in lineinfo

2020-06-22 Thread Kent Gibson
Report the state of edge detection for a line in the gpioline_info_v2 returned by GPIO_GET_LINEINFO_V2_IOCTL, and indirectly for lines watched by GPIO_GET_LINEINFO_WATCH_V2_IOCTL. Signed-off-by: Kent Gibson --- drivers/gpio/gpiolib-cdev.c | 14 ++ drivers/gpio/gpiolib.c | 2

[PATCH 08/22] gpiolib: cdev: complete the irq/thread timestamp handshake

2020-06-22 Thread Kent Gibson
Reset the timestamp field to 0 after using it in lineevent_irq_thread. The timestamp is set by lineevent_irq_handler and is tested by lineevent_irq_thread to determine if it is called from a nested theaded interrupt. lineevent_irq_thread is assuming that the nested, or otherwise, status of the

[PATCH 12/22] gpio: uapi: define GPIO_MAX_NAME_SIZE for array sizes

2020-06-22 Thread Kent Gibson
Replace constant array sizes with a macro constant to clarify the source of array sizes, provide a place to document any constraints on the size, and to simplify array sizing in userspace if constructing structs from their composite fields. Signed-off-by: Kent Gibson --- This change is not

[PATCH 14/22] gpiolib: make cdev a build option

2020-06-22 Thread Kent Gibson
Make the gpiolib-cdev module a build option. This allows the CDEV interface to be removed from the kernel to reduce kernel size in applications where is it not required, and provides the parent for other other CDEV interface specific build options to follow. Suggested-by: Bartosz Golaszewski

[PATCH 07/22] gpiolib: cdev: remove pointless decrement of i

2020-06-22 Thread Kent Gibson
Remove pointless decrement of variable, and associated comment. While i is used subsequently, it is re-initialized so this decrement serves no purpose. Signed-off-by: Kent Gibson --- drivers/gpio/gpiolib-cdev.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpio/gpiolib-cdev.c

Re: [PATCH v2 2/2] soc: mediatek: devapc: add devapc-mt6873 driver

2020-06-22 Thread Neal Liu
Hi Chun-Kuang, On Sun, 2020-06-21 at 07:36 +0800, Chun-Kuang Hu wrote: > Hi, Neal: > > Neal Liu 於 2020年6月20日 週六 上午11:18寫道: > > > > Hi Chun-Kuang, > > > > Thanks for your quick feedback. > > > > On Sat, 2020-06-20 at 00:25 +0800, Chun-Kuang Hu wrote: > > > Hi, Neal: > > > > > > Neal Liu 於

[PATCH 16/22] gpiolib: cdev: add V2 uAPI implementation to parity with V1

2020-06-22 Thread Kent Gibson
Add implementation of the V2 uAPI up to parity with V1. Signed-off-by: Kent Gibson --- This patch only covers the V2 functionality that is a direct analogue of the V1. New V2 functionality is added in subsequent patches. The core of the implementation is the struct line, which is drawn from

[PATCH 11/22] gpiolib: cdev: remove recalculation of offset

2020-06-22 Thread Kent Gibson
Remove recalculation of offset from desc, where desc itself was calculated from offset. There is no benefit from for the desc -> hwgpio conversion in this context. The only implicit benefit of the offset -> desc -> hwgpio is the range check in the offset -> desc, but where desc is required you

[PATCH 13/22] gpio: uapi: define uAPI V2

2020-06-22 Thread Kent Gibson
Add a new version of the uAPI to address existing 32/64bit alignment issues, add support for debounce and event sequence numbers, and provide some future proofing by adding padding reserved for future use. The alignment issue relates to the gpioevent_data, which packs to different sizes on 32bit

[PATCH 10/22] gpiolib: cdev: fix minor race in GET_LINEINFO_WATCH

2020-06-22 Thread Kent Gibson
Merge separate usage of test_bit/set_bit into test_and_set_bit to remove the possibility of a race between the test and set. Similarly test_bit and clear_bit. In the existing code it is possible for two threads to race past the test_bit and then set or clear the watch bit, and neither return

[PATCH 06/22] gpiolib: cdev: rename numdescs to num_descs

2020-06-22 Thread Kent Gibson
Rename numdescs to num_descs to be more consistent with the naming of other counters and improve readability. Signed-off-by: Kent Gibson --- drivers/gpio/gpiolib-cdev.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/gpio/gpiolib-cdev.c

[PATCH 09/22] gpiolib: cdev: rename priv to gcdev

2020-06-22 Thread Kent Gibson
Rename priv to gcdev to improve readability. The name "priv" indicates that the object is pointed to by file->private_data, not what the object is actually is. It is always used to point to a struct gpio_chardev_data so renaming it to gcdev seemed as good as anything, and certainly clearer than

[PATCH 03/22] gpiolib: cdev: minor indentation fixes

2020-06-22 Thread Kent Gibson
Make indentation consistent with other use to improve readability. Signed-off-by: Kent Gibson --- drivers/gpio/gpiolib-cdev.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/gpio/gpiolib-cdev.c b/drivers/gpio/gpiolib-cdev.c index

[PATCH 04/22] gpiolib: cdev: refactor gpiohandle_flags_to_desc_flags

2020-06-22 Thread Kent Gibson
Refactor the mapping from handle flags to desc flags into a helper function. The assign_bit is overkill where it is replacing the set_bit cases, as is rechecking bits known to be clear in some circumstances, but the DRY simplification more than makes up for any performance degradation, especially

[PATCH 05/22] gpiolib: cdev: rename 'filep' and 'filp' to 'file' to be consistent with other use

2020-06-22 Thread Kent Gibson
Rename 'filep' and 'filp' to 'file' to be consistent with other use and improve readability. Signed-off-by: Kent Gibson --- The code was using both "filep" and "filp" and I flip flopped between which one to change to until looking at code elsewhere in the kernel where "struct file *file" is

[PATCH 02/22] gpiolib: cdev: sort includes

2020-06-22 Thread Kent Gibson
Sort the includes of gpiolib-cdev.c to make it easier to identify if a module is included and to avoid duplication. Signed-off-by: Kent Gibson --- drivers/gpio/gpiolib-cdev.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git

[PATCH 00/22] gpio: cdev: add uAPI V2

2020-06-22 Thread Kent Gibson
This patchset defines and implements adds a new version of the GPIO CDEV uAPI to address existing 32/64bit alignment issues, add support for debounce and event sequence numbers, and provide some future proofing by adding padding reserved for future use. The series can be partitioned into three

[PATCH 01/22] gpiolib: move gpiolib-sysfs function declarations into their own header

2020-06-22 Thread Kent Gibson
Move gpiolib-sysfs function declarations into their own header. These functions are in gpiolib-sysfs.c, and are only required by gpiolib.c, and so should be in a module header, not giolib.h. This brings gpiolib-sysfs into line with gpiolib-cdev, and is another step towards removing the sysfs

Re: [PATCH] [net/sched] tcindex_change: Remove redundant null check

2020-06-22 Thread David Miller
From: Gaurav Singh Date: Sun, 21 Jun 2020 22:24:30 -0400 > arg cannot be NULL since its already being dereferenced > before. Remove the redundant NULL check. > > Signed-off-by: Gaurav Singh Applied, thank you.

Re: linux-next: build failure after merge of the kspp tree

2020-06-22 Thread David Miller
From: Stephen Rothwell Date: Tue, 23 Jun 2020 13:51:34 +1000 > I have added the following merge fix patch. > > From: Stephen Rothwell > Date: Tue, 23 Jun 2020 13:43:06 +1000 > Subject: [PATCH] net/core/devlink.c: remove new uninitialized_var() usage > > Signed-off-by: Stephen Rothwell

Re: [PATCH 2/3] arm64: dts: imx8qxp: add i2c aliases

2020-06-22 Thread Shawn Guo
On Mon, Jun 01, 2020 at 10:06:19AM +0800, peng@nxp.com wrote: > From: Peng Fan > > The devices could be enumerated properly with aliases. > > Signed-off-by: Peng Fan > --- > arch/arm64/boot/dts/freescale/imx8qxp.dtsi | 4 > 1 file changed, 4 insertions(+) > > diff --git

[RFC PATCH v3 2/5] scsi: ufs: Add UFS-feature layer

2020-06-22 Thread Daejun Park
This patch is adding UFS feature layer to UFS core driver. UFS Driver data structure (struct ufs_hba) │ ┌--┐ │ UFS feature │ <-- HPB module │layer │ <-- other extended feature module └--┘ Each extended UFS-Feature module has a bus of ufs-ext feature

Re: [PATCH 0/3] arm64: dts: imx8qxp: dtb aliases fix/update

2020-06-22 Thread Shawn Guo
On Mon, Jun 01, 2020 at 10:06:17AM +0800, peng@nxp.com wrote: > From: Peng Fan > > Minor patchset to fix and update alias for i.MX8QXP > > Peng Fan (3): > arm64: dts: imx8qxp: add alias for lsio MU > arm64: dts: imx8qxp: add i2c aliases > arm64: dts: imx8qxp: Add ethernet alias

[RFC PATCH v3 1/5] scsi: ufs: Add UFS feature related parameter

2020-06-22 Thread Daejun Park
This is a patch for parameters to be used for UFS features layer and HPB module. Signed-off-by: Daejun Park --- drivers/scsi/ufs/ufs.h | 12 1 file changed, 12 insertions(+) diff --git a/drivers/scsi/ufs/ufs.h b/drivers/scsi/ufs/ufs.h index f8ab16f30fdc..ae557b8d3eba 100644 ---

Re: [PATCH 4/4] powerpc/pseries/iommu: Remove default DMA window before creating DDW

2020-06-22 Thread Alexey Kardashevskiy
On 23/06/2020 12:43, Leonardo Bras wrote: > On Tue, 2020-06-23 at 12:35 +1000, Alexey Kardashevskiy wrote: >>> I am not sure if this is true in general, but in this device (SR-IOV >>> VF) I am testing it will return 0 windows if the default DMA window is >>> not deleted, and 1 after it's

linux-next: build failure after merge of the kspp tree

2020-06-22 Thread Stephen Rothwell
Hi all, After merging the kspp tree, today's linux-next build (powerpc ppc64_defconfig) failed like this: net/core/devlink.c: In function 'devlink_nl_port_function_attrs_put': net/core/devlink.c:586:3: warning: parameter names (without types) in function declaration 586 | int

Re: [PATCH v3 12/14] tools/kernel.h: hide noinstr

2020-06-22 Thread kernel test robot
Hi Sasha, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.8-rc2 next-20200622] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use as documented in https://git

Re: [PATCH] Fix check in ethtool_rx_flow_rule_create

2020-06-22 Thread David Miller
From: Gaurav Singh Date: Sun, 21 Jun 2020 11:30:17 -0400 > Fix check in ethtool_rx_flow_rule_create > > Signed-off-by: Gaurav Singh Applied and queued up for -stable with the following Fixes: tag added: Fixes: eca4205f9ec3 ("ethtool: add ethtool_rx_flow_spec to flow_rule structure

Re: [PATCH] ARM: dts: imx6qdl-gw54xx: allow boot firmware to set eth1 MAC

2020-06-22 Thread Shawn Guo
On Thu, May 28, 2020 at 12:53:16PM -0700, Tim Harvey wrote: > The GW54xx has a PCIe based GbE as the 2nd ethernet device. The > boot firmware will populate the local-mac-address field of the > device aliased to ethernet1 thus adding the PCIe device to > dt allows boot firmware to set its MAC

Re: [PATCH] ARM: dts: imx6qdl-gw53xx: allow boot firmware to set eth1 MAC

2020-06-22 Thread Shawn Guo
On Thu, May 28, 2020 at 12:53:03PM -0700, Tim Harvey wrote: > The GW53xx has a PCIe based GbE as the 2nd ethernet device. The > boot firmware will populate the local-mac-address field of the > device aliased to ethernet1 thus adding the PCIe device to > dt allows boot firmware to set its MAC

RE: [PATCH V2 3/9] clk: imx: Support building SCU clock driver as module

2020-06-22 Thread Aisheng Dong
> From: Stephen Boyd > Sent: Saturday, June 20, 2020 11:28 AM > Subject: RE: [PATCH V2 3/9] clk: imx: Support building SCU clock driver as > module > > Quoting Aisheng Dong (2020-06-17 18:58:51) > > > From: Anson Huang > > > > > +obj-$(CONFIG_MXC_CLK_SCU) += mxc-clk-scu.o > > > > > > > > Like

[PATCH] [net/decnet] dn_route_rcv: remove redundant dev null check

2020-06-22 Thread Gaurav Singh
dev cannot be NULL here since its already being accessed before. Remove the redundant null check. Signed-off-by: Gaurav Singh --- net/decnet/dn_route.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/decnet/dn_route.c b/net/decnet/dn_route.c index

Re: [PATCH 2/2] ARM: dts: Change WDOG_ANY signal from push-pull to open-drain

2020-06-22 Thread Shawn Guo
On Thu, May 28, 2020 at 02:43:43PM +, Schrempf Frieder wrote: > From: Frieder Schrempf > > The WDOG_ANY signal is connected to the RESET_IN signal of the SoM > and baseboard. It is currently configured as push-pull, which means > that if some external device like a programmer wants to assert

Re: [PATCH 02/17] sparc64: enable HAVE_COPY_THREAD_TLS

2020-06-22 Thread David Miller
From: Christian Brauner Date: Tue, 23 Jun 2020 01:43:11 +0200 > diff --git a/arch/sparc/kernel/syscalls.S b/arch/sparc/kernel/syscalls.S > index db42b4fb3708..192f3a28a2b7 100644 > --- a/arch/sparc/kernel/syscalls.S > +++ b/arch/sparc/kernel/syscalls.S > @@ -86,19 +86,22 @@ sys32_rt_sigreturn: >

Re: [PATCH v16 00/11] Mediatek MT8183 scpsys support

2020-06-22 Thread Weiyi Lu
On Wed, 2020-06-17 at 15:05 +0800, Weiyi Lu wrote: > This series is based on v5.8-rc1 > Hi Matthias, Gentle ping. Many thanks. > change since v15: > - remove unneeded error log in [PATCH 06/11] > > changes since v14: > - fix commit message typo > - use property name "mediatek,smi" for smi

[PATCH v2] kernel/fork.c: annotate data races for copy_process

2020-06-22 Thread Weilong Chen
KCSAN report there's a data race risk while using nr_threads. But according to the comment above it: ' /* * If multiple threads are within copy_process(), then this check * triggers too late. This doesn't hurt, the check is only there * to stop root fork bombs.

[tip:x86/cleanups] BUILD SUCCESS 99e40204e014e06644072c39001a269d9689e0d1

2020-06-22 Thread kernel test robot
randconfig-a004-20200622 x86_64 randconfig-a002-20200622 x86_64 randconfig-a003-20200622 x86_64 randconfig-a005-20200622 x86_64 randconfig-a001-20200622 x86_64 randconfig-a006-20200622 i386 randconfig-a006-20200622 i386

[PATCH] net: qrtr: free flow in __qrtr_node_release

2020-06-22 Thread Carl Huang
The flow is allocated in qrtr_tx_wait, but not freed when qrtr node is released. (*slot) becomes NULL after radix_tree_iter_delete is called in __qrtr_node_release. The fix is to save (*slot) to a vairable and then free it. This memory leak is catched when kmemleak is enabled in kernel, the

RE: [PATCH 0/3] Use MFD for Dallas/Maxim DS1374 driver series

2020-06-22 Thread 陳昭勳
Hi, > > Hi, > > On 22/06/2020 10:03:25+, Johnson CH Chen (陳昭勳) wrote: > > Hello all, > > > > This patch set uses MFD structure for DS1374 so that RTC and Watchdog > > functions can be separately. Therefore, we can add more Watchdog > > subfunctions here. > > > > A DS1374 MFD core driver

Re: [PATCH v7 8/8] block: create the request_queue debugfs_dir on registration

2020-06-22 Thread Bart Van Assche
On 2020-06-22 05:42, Luis Chamberlain wrote: > On Sat, Jun 20, 2020 at 11:07:43AM -0700, Bart Van Assche wrote: >> On 2020-06-19 13:47, Luis Chamberlain wrote: >>> We were only creating the request_queue debugfs_dir only >>> for make_request block drivers (multiqueue), but never for >>>

Re: [PATCH 5.7] x86/crypto: aesni: Fix build with LLVM_IAS=1

2020-06-22 Thread Sedat Dilek
On Mon, Jun 22, 2020 at 10:33 PM Nick Desaulniers wrote: > > On Mon, Jun 22, 2020 at 8:50 AM Sedat Dilek wrote: > > > > When building with LLVM_IAS=1 means using Clang's Integrated Assembly (IAS) > > from LLVM/Clang >= v10.0.1-rc1+ instead of GNU/as from GNU/binutils > > I see the following

[PATCH 5.7 v3] x86/crypto: aesni: Fix build with LLVM_IAS=1

2020-06-22 Thread Sedat Dilek
When building with LLVM_IAS=1 means using Clang's Integrated Assembly (IAS) from LLVM/Clang >= v10.0.1-rc1+ instead of GNU/as from GNU/binutils I see the following breakage in Debian/testing AMD64: :15:74: error: too many positional arguments PRECOMPUTE 8*3+8(%rsp), %xmm1, %xmm2, %xmm3, %xmm4,

[PATCH v2] GUE: Fix a typo

2020-06-22 Thread Aiden Leong
Fix a typo in gue.h Signed-off-by: Aiden Leong --- include/net/gue.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/net/gue.h b/include/net/gue.h index 3a6595bfa641..e42402f180b7 100644 --- a/include/net/gue.h +++ b/include/net/gue.h @@ -21,7 +21,7 @@ * |

  1   2   3   4   5   6   7   8   9   10   >