[PATCH] PCI: hotplug: fix null-ptr-dereferencd in cpcihp error path

2021-03-20 Thread Tong Zhang
There is an issue in the error path, which cpci_thread may remain NULL. Calling kthread_stop(cpci_thread) will trigger a BUG(). It is better to check whether the thread is really created and started before stop it. [1.292859] BUG: kernel NULL pointer dereference, address: 0028 [

Re: [PATCH] staging: vchiq: Typo fixes

2021-03-20 Thread Randy Dunlap
On Sun, 21 Mar 2021, Bhaskar Chowdhury wrote: s/sepecific/specific/ s/comonent/component/ Signed-off-by: Bhaskar Chowdhury Acked-by: Randy Dunlap --- drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH V2] device_cgroup: A typo fix

2021-03-20 Thread Randy Dunlap
On Sun, 21 Mar 2021, Bhaskar Chowdhury wrote: s/acessed/accessed/ Signed-off-by: Bhaskar Chowdhury Acked-by: Randy Dunlap although I still don't care for the $Subject. --- Changes from V1: Getting rid of unwanted comment delimeter addition Subject line missed propper commit

Re: [PATCH] security: A typo fix

2021-03-20 Thread Randy Dunlap
On Sun, 21 Mar 2021, Bhaskar Chowdhury wrote: s/programers/programmers/ Signed-off-by: Bhaskar Chowdhury Acked-by: Randy Dunlap --- security/lsm_audit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/security/lsm_audit.c b/security/lsm_audit.c index

Re: [PATCH next v1 1/3] printk: track/limit recursion

2021-03-20 Thread Sergey Senozhatsky
On (21/03/17 00:33), John Ogness wrote: [..] > static inline void printk_delay(void) > @@ -2040,11 +2105,13 @@ int vprintk_store(int facility, int level, > struct prb_reserved_entry e; > enum log_flags lflags = 0; > struct printk_record r; > + unsigned long irqflags; >

[PATCH] scsi: sym53c8xx_2: Fix WARN_ON in __sym_mfree_dma

2021-03-20 Thread Tong Zhang
This fix is similar to b36522150e5b. The WARN_ON is triggered due to irq being disabled while dma_free_coherent expect it enabled. [1.501363] WARNING: CPU: 0 PID: 179 at kernel/dma/mapping.c:467 dma_free_attrs+0x38/0x50 [1.503940] RIP: 0010:dma_free_attrs+0x38/0x50 [1.509138] Call

Re: [PATCH next v1 2/3] printk: remove safe buffers

2021-03-20 Thread Sergey Senozhatsky
On (21/03/17 00:33), John Ogness wrote: [..] > void printk_nmi_direct_enter(void) > { > @@ -324,27 +44,8 @@ void printk_nmi_direct_exit(void) > this_cpu_and(printk_context, ~PRINTK_NMI_DIRECT_CONTEXT_MASK); > } > > -#else > - > -static __printf(1, 0) int vprintk_nmi(const char *fmt,

Re: [PATCH v1 2/2] iio: temperature: add driver support for ti tmp117

2021-03-20 Thread Lars-Peter Clausen
On 3/21/21 6:07 AM, Lars-Peter Clausen wrote: On 3/20/21 7:45 AM, Puranjay Mohan wrote: TMP117 is a Digital temperature sensor with integrated NV memory. Add support for tmp117 driver in iio subsystem. Datasheet:-https://www.ti.com/lit/gpn/tmp117 Signed-off-by: Puranjay Mohan This looks

[GIT PULL] Please pull powerpc/linux.git powerpc-5.12-4 tag

2021-03-20 Thread Michael Ellerman
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi Linus, Please pull some more powerpc fixes for 5.12: The following changes since commit 0b736881c8f1a6cd912f7a9162b9e097b28c1c30: powerpc/traps: unrecoverable_exception() is not an interrupt handler (2021-03-12 11:02:12 +1100) are

Re: [PATCH] scsi: iscsi_tcp: Fix use-after-free when do get_host_param

2021-03-20 Thread Wu Bo
On 2021/3/20 17:08, Wu Bo wrote: When logout of iscsi session, to do destroy session process, tcp_sw_host->session is not set to NULL. Get host parameters access to tcp_sw_host->session at the same time, but the session has been released at this time. [29844.848044] sd 2:0:0:1: [sdj]

Re: [PATCH v1 2/2] iio: temperature: add driver support for ti tmp117

2021-03-20 Thread Lars-Peter Clausen
On 3/20/21 7:45 AM, Puranjay Mohan wrote: TMP117 is a Digital temperature sensor with integrated NV memory. Add support for tmp117 driver in iio subsystem. Datasheet:-https://www.ti.com/lit/gpn/tmp117 Signed-off-by: Puranjay Mohan This looks good to me. Just two small bits I overlooked

Re: [PATCH 1/1] x86/microcode: Check for offline CPUs before checking for microcode update

2021-03-20 Thread Raj, Ashok
On Sat, Mar 20, 2021 at 03:55:46PM +0100, Borislav Petkov wrote: [snip] > > microcode : 0x30 > > microcode : 0xde > > microcode : 0x30 > > microcode : 0xde > > Yeah, I'm looking at that check_online_cpus() thing and wondering why we > even need that: > > 0. So you have CPUs 1 and 3 offline. > 1.

Re: ext4: stop inode update before return

2021-03-20 Thread Theodore Ts'o
On Sun, Jan 17, 2021 at 12:57:32AM -0800, Pan Bian wrote: > The inode update should be stopped before returing the error code. > > Signed-off-by: Pan Bian Thanks, applied. - Ted

[PATCH] staging: vchiq: Typo fixes

2021-03-20 Thread Bhaskar Chowdhury
s/sepecific/specific/ s/comonent/component/ Signed-off-by: Bhaskar Chowdhury --- drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c

[PATCH V2] device_cgroup: A typo fix

2021-03-20 Thread Bhaskar Chowdhury
s/acessed/accessed/ Signed-off-by: Bhaskar Chowdhury --- Changes from V1: Getting rid of unwanted comment delimeter addition Subject line missed propper commit subject labeling security/device_cgroup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

arch/riscv/include/asm/page.h:133:62: error: 'max_mapnr' undeclared; did you mean

2021-03-20 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 812da4d39463a060738008a46cfc9f775e4bfcf6 commit: 4f0e8eef772ee4438f304b2178bc28c958b6c13d riscv: Add numa support for riscv64 platform date: 9 weeks ago config: riscv-randconfig-r032-20210321 (attached as

Is s390's new generic-using syscall code actually correct?

2021-03-20 Thread Andy Lutomirski
Hi all- I'm working on my kentry patchset, and I encountered: commit 56e62a73702836017564eaacd5212e4d0fa1c01d Author: Sven Schnelle Date: Sat Nov 21 11:14:56 2020 +0100 s390: convert to generic entry As part of this work, I was cleaning up the generic syscall helpers, and I encountered

[PATCH] security: A typo fix

2021-03-20 Thread Bhaskar Chowdhury
s/acessed/accessed/ Signed-off-by: Bhaskar Chowdhury --- Two comment block delimiter automatically delete themselve and created themselves ..wondering..I hope that won't be problem,is it? security/device_cgroup.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH] security: A typo fix

2021-03-20 Thread Bhaskar Chowdhury
s/programers/programmers/ Signed-off-by: Bhaskar Chowdhury --- security/lsm_audit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/security/lsm_audit.c b/security/lsm_audit.c index 82ce14933513..ddcf572105be 100644 --- a/security/lsm_audit.c +++ b/security/lsm_audit.c @@

[PATCH v2] swiotlb: Make SWIOTLB_NO_FORCE perform no allocation

2021-03-20 Thread Florian Fainelli
When SWIOTLB_NO_FORCE is used, there should really be no allocations of default_nslabs to occur since we are not going to use those slabs. If a platform was somehow setting swiotlb_no_force and a later call to swiotlb_init() was to be made we would still be proceeding with allocating the default

[PATCH v2 0/1] Mediatek pinctrl patch

2021-03-20 Thread Zhiyong Tao
This series includes 1 patches: 1.add lock in mtk_rmw function. Changes in patch v2: 1)add mutex lock init in "pinctrl-moore.c". Zhiyong Tao (1): pinctrl: add lock in mtk_rmw function. drivers/pinctrl/mediatek/pinctrl-moore.c | 2 ++ drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c |

[PATCH] cap: Trivial spelling fixes throughout the file

2021-03-20 Thread Bhaskar Chowdhury
Mundane spelling fixes throughout the file. Signed-off-by: Bhaskar Chowdhury --- security/commoncap.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/security/commoncap.c b/security/commoncap.c index 1c519c875217..d4bb6d619200 100644 ---

[PATCH] pinctrl: add lock in mtk_rmw function.

2021-03-20 Thread Zhiyong Tao
When multiple threads operate on the same register resource which include multiple pin, It will make the register resource wrong to control. So we add lock to avoid the case. Signed-off-by: Zhiyong Tao --- drivers/pinctrl/mediatek/pinctrl-moore.c | 2 ++

[PATCH] RCU: some improvements to comments of tree.c

2021-03-20 Thread Zhouyi Zhou
During my study of RCU, I go through tree.c many times and try to make some improvements to the comments. Thanks a lot. Signed-off-by: Zhouyi Zhou --- kernel/rcu/tree.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/kernel/rcu/tree.c

Bootconfig ..too many deep level of header file

2021-03-20 Thread Bhaskar Chowdhury
Hey, Masami I was wondering why so many level of "deep nesting" of a particualr header file like this one : ✔ ~/git-linux/linux/tools/bootconfig/include/linux [patch L|✔] 08:34 $ cat bootconfig.h /* SPDX-License-Identifier: GPL-2.0 */ #ifndef _BOOTCONFIG_LINUX_BOOTCONFIG_H #define

Re: [PATCH 4.19 0/8] 4.19.182-rc1 review

2021-03-20 Thread Samuel Zou
On 2021/3/19 20:18, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 4.19.182 release. There are 8 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be

Re: [PATCH 5.10 00/13] 5.10.25-rc1 review

2021-03-20 Thread Samuel Zou
On 2021/3/19 20:18, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 5.10.25 release. There are 13 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be

Re: [PATCH 2/6] mfd: Initial commit of sy7636a

2021-03-20 Thread Alistair Francis
On Thu, Feb 4, 2021 at 5:31 AM Lee Jones wrote: > > On Sat, 16 Jan 2021, Alistair Francis wrote: > > > Initial support for the Silergy SY7636A Power Management chip > > driver. > > Please remove "driver", as this is not support for the driver, it *is* > the driver which supports the chip. Sorry

Re: [PATCH v3 net-next 12/12] net: ocelot: replay switchdev events when joining bridge

2021-03-20 Thread kernel test robot
Hi Vladimir, I love your patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Vladimir-Oltean/Better-support-for-sandwiched-LAGs-with-bridge-and-DSA/20210321-063842 base:

Re: [PATCH net-next 0/5] net: ipa: more configuration data updates

2021-03-20 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Sat, 20 Mar 2021 10:57:02 -0500 you wrote: > This series starts with two patches that should have been included > in an earlier series. With these in place, QSB settings are > programmed from information found in the

Re: [PATCH] net: decnet: Fixed multiple coding style issues

2021-03-20 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Sat, 20 Mar 2021 11:45:12 +0530 you wrote: > Made changes to coding style as suggested by checkpatch.pl > changes are of the type: > open brace '{' following struct go on the same line > do not use

Re: [PATCH] perf evlist: Mundane typo fix

2021-03-20 Thread Randy Dunlap
On Sun, 21 Mar 2021, Bhaskar Chowdhury wrote: s/explicitely/explicitly/ Signed-off-by: Bhaskar Chowdhury Acked-by: Randy Dunlap --- tools/perf/builtin-top.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c index

Re: [PATCH] perf tools: Rudimentary typo fix

2021-03-20 Thread Randy Dunlap
On Sun, 21 Mar 2021, Bhaskar Chowdhury wrote: s/archictures/architectures/ Signed-off-by: Bhaskar Chowdhury Acked-by: Randy Dunlap --- tools/perf/builtin-stat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c

Re: [PATCH v4 08/28] netfs: Provide readahead and readpage netfs helpers

2021-03-20 Thread Matthew Wilcox
On Wed, Mar 10, 2021 at 04:56:13PM +, David Howells wrote: > +void netfs_readahead(struct readahead_control *ractl, > + const struct netfs_read_request_ops *ops, > + void *netfs_priv) > +{ > + struct netfs_read_request *rreq; > + struct page *page; > +

Re: [PATCH v5 3/3] ARM: imx7d-remarkable2.dts: Initial device tree for reMarkable2

2021-03-20 Thread Alistair Francis
On Fri, Mar 19, 2021 at 9:06 AM Marco Felsch wrote: > > Hi Alistair, > > the patch looks quite good only a few notes inline. > > PS: It would be cool to have a log to previous patch versions. I'm not sure how I could add that, I will add a changelog for this version though. > > On 21-03-15

Re: [PATCH net-next] dsa: simplify Kconfig symbols and dependencies

2021-03-20 Thread Florian Fainelli
On 3/19/2021 8:46 AM, Alexander Lobakin wrote: > 1. Remove CONFIG_HAVE_NET_DSA. > > CONFIG_HAVE_NET_DSA is a legacy leftover from the times when drivers > should have selected CONFIG_NET_DSA manually. > Currently, all drivers has explicit 'depends on NET_DSA', so this is > no more needed. > >

Re: [PATCH v3 net-next 10/12] net: dsa: replay VLANs installed on port when joining the bridge

2021-03-20 Thread kernel test robot
Hi Vladimir, I love your patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Vladimir-Oltean/Better-support-for-sandwiched-LAGs-with-bridge-and-DSA/20210321-063842 base:

[PATCH] perf evlist: Mundane typo fix

2021-03-20 Thread Bhaskar Chowdhury
s/explicitely/explicitly/ Signed-off-by: Bhaskar Chowdhury --- tools/perf/builtin-top.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c index 3673c04d16b6..173ace43f845 100644 --- a/tools/perf/builtin-top.c +++

Re: [PATCH net-next] dsa: simplify Kconfig symbols and dependencies

2021-03-20 Thread Vladimir Oltean
On Fri, Mar 19, 2021 at 03:46:30PM +, Alexander Lobakin wrote: > 1. Remove CONFIG_HAVE_NET_DSA. > > CONFIG_HAVE_NET_DSA is a legacy leftover from the times when drivers > should have selected CONFIG_NET_DSA manually. > Currently, all drivers has explicit 'depends on NET_DSA', so this is > no

Re: [PATCH v3 net-next 03/12] net: dsa: inherit the actual bridge port flags at join time

2021-03-20 Thread kernel test robot
Hi Vladimir, I love your patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Vladimir-Oltean/Better-support-for-sandwiched-LAGs-with-bridge-and-DSA/20210321-063842 base:

[PATCH] perf tools: Rudimentary typo fix

2021-03-20 Thread Bhaskar Chowdhury
s/archictures/architectures/ Signed-off-by: Bhaskar Chowdhury --- tools/perf/builtin-stat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c index 2e2e4a8345ea..5cc5eeae6ade 100644 --- a/tools/perf/builtin-stat.c +++

Re: [syzbot] WARNING in io_wq_put

2021-03-20 Thread syzbot
syzbot has found a reproducer for the following issue on: HEAD commit:1c273e10 Merge tag 'zonefs-5.12-rc4' of git://git.kernel.o.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=13853506d0 kernel config:

[PATCH] ipv4/raw: support binding to nonlocal addresses

2021-03-20 Thread Riccardo Paolo Bestetti
Add support to inet raw sockets for binding to nonlocal addresses through the IP_FREEBIND and IP_TRANSPARENT socket options, as well as the ipv4.ip_nonlocal_bind kernel parameter. Signed-off-by: Riccardo Paolo Bestetti --- net/ipv4/raw.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)

Re: [PATCH v7 4/4] arm64: dts: mt8192: add spmi node

2021-03-20 Thread kernel test robot
Hi Hsin-Hsiung, Thank you for the patch! Yet something to improve: [auto build test ERROR on robh/for-next] [also build test ERROR on linus/master v5.12-rc3] [cannot apply to mediatek/for-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we

Re: [PATCH v3 net-next 03/12] net: dsa: inherit the actual bridge port flags at join time

2021-03-20 Thread kernel test robot
Hi Vladimir, I love your patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Vladimir-Oltean/Better-support-for-sandwiched-LAGs-with-bridge-and-DSA/20210321-063842 base:

Re: [PATCH 1/2] clk: zynqmp: pll: add set_pll_mode to check condition in zynqmp_pll_enable

2021-03-20 Thread Laurent Pinchart
Hi Quanyang, Thank you for the patch. On Fri, Mar 19, 2021 at 06:07:17PM +0800, quanyang.w...@windriver.com wrote: > From: Quanyang Wang > > If there is a IOCTL_SET_PLL_FRAC_MODE request sent to ATF ever, > we shouldn't skip invoking PM_CLOCK_ENABLE fn even though this > pll has been enabled.

[tip:master] BUILD SUCCESS 2b7cc48df95a36ecb6dfec219ae1e1f1148e6dac

2021-03-20 Thread kernel test robot
randconfig-a002-20210321 i386 randconfig-a006-20210321 i386 randconfig-a005-20210321 i386 randconfig-a004-20210320 i386 randconfig-a003-20210320 i386 randconfig-a001-20210320 i386 randconfig-a002

[tip:x86/cpu] BUILD SUCCESS a331f5fdd36dba1ffb0239a4dfaaf1df91ff1aab

2021-03-20 Thread kernel test robot
randconfig-a002-20210321 i386 randconfig-a006-20210321 i386 randconfig-a005-20210321 i386 randconfig-a004-20210320 i386 randconfig-a003-20210320 i386 randconfig-a001-20210320 i386 randconfig-a002

[PATCH] arch: xtensa: fix kconfig dependency on FUTEX

2021-03-20 Thread Julian Braha
When HAVE_FUTEX_CMPXCHG is enabled, and FUTEX is disabled, Kbuild gives the following warning: WARNING: unmet direct dependencies detected for HAVE_FUTEX_CMPXCHG Depends on [n]: FUTEX [=n] Selected by [y]: - XTENSA [=y] && !MMU [=n] This is because XTENSA selects HAVE_FUTEX_CMPXCHG,

powerpc-linux-ld: warning: orphan section `.init.plt' from `drivers/net/ethernet/micrel/ks8851_common.o' being placed in section `.init.plt'

2021-03-20 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 812da4d39463a060738008a46cfc9f775e4bfcf6 commit: 797047f875b5463719cc70ba213eb691d453c946 net: ks8851: Implement Parallel bus operations date: 10 months ago config: powerpc-randconfig-c024-20210321

[tip: irq/urgent] genirq: Disable interrupts for force threaded handlers

2021-03-20 Thread tip-bot2 for Thomas Gleixner
The following commit has been merged into the irq/urgent branch of tip: Commit-ID: 81e2073c175b887398e5bca6c004efa89983f58d Gitweb: https://git.kernel.org/tip/81e2073c175b887398e5bca6c004efa89983f58d Author:Thomas Gleixner AuthorDate:Wed, 17 Mar 2021 15:38:52 +01:00

Re: [PATCH] watchdog: Fix a typo

2021-03-20 Thread Guenter Roeck
On 3/20/21 2:33 PM, Bhaskar Chowdhury wrote: > s/parmeter/parameter/ > > Signed-off-by: Bhaskar Chowdhury Reviewed-by: Guenter Roeck > --- > drivers/watchdog/sl28cpld_wdt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/watchdog/sl28cpld_wdt.c

Re: [PATCH V4] clk: imx: Fix reparenting of UARTs not associated with stdout

2021-03-20 Thread Adam Ford
On Sun, Mar 14, 2021 at 4:40 AM Ahmad Fatoum wrote: > > On 13.03.21 16:16, Ahmad Fatoum wrote: > >> +/* i.MX boards use device trees now. For build tests without CONFIG_OF, > >> do nothing */ > >> +#ifdef CONFIG_OF > >> if (imx_keep_uart_clocks) { > >> int i; > >> > >> -

Re: [PATCHSET 0/2] PF_IO_WORKER signal tweaks

2021-03-20 Thread Jens Axboe
On 3/20/21 1:18 PM, Linus Torvalds wrote: > On Sat, Mar 20, 2021 at 10:51 AM Linus Torvalds > wrote: >> >> Alternatively, make it not use >> CLONE_SIGHAND|CLONE_THREAD at all, but that would make it >> unnecessarily allocate its own signal state, so that's "cleaner" but >> not great either. > >

Re: [PATCHSET 0/2] PF_IO_WORKER signal tweaks

2021-03-20 Thread Jens Axboe
On 3/20/21 4:08 PM, Eric W. Biederman wrote: > > Added criu because I just realized that io_uring (which can open files > from an io worker thread) looks to require some special handling for > stopping and freezing processes. If not in the SIGSTOP case in the > related cgroup freezer case. > >

Re: [PATCH v4 3/3] mm: fs: Invalidate BH LRU during page migration

2021-03-20 Thread Chris Goldsworthy
On 2021-03-20 12:54, Matthew Wilcox wrote: On Sat, Mar 20, 2021 at 10:20:09AM -0700, Minchan Kim wrote: > > Tested-by: Oliver Sang > > Reported-by: kernel test robot > > Signed-off-by: Chris Goldsworthy > > Signed-off-by: Minchan Kim > > The signoff chain ordering might mean that Chris was

Re: [PATCH 1/2] signal: don't allow sending any signals to PF_IO_WORKER threads

2021-03-20 Thread Jens Axboe
On 3/20/21 3:38 PM, Eric W. Biederman wrote: > Linus Torvalds writes: > >> On Sat, Mar 20, 2021 at 9:19 AM Eric W. Biederman >> wrote: >>> >>> The creds should be reasonably in-sync with the rest of the threads. >> >> It's not about credentials (despite the -EPERM). >> >> It's about the fact

Re: [PATCH] powerpc: epapr: A typo fix

2021-03-20 Thread Randy Dunlap
On Sun, 21 Mar 2021, Bhaskar Chowdhury wrote: s/parmeters/parameters/ Signed-off-by: Bhaskar Chowdhury Acked-by: Randy Dunlap --- arch/powerpc/include/asm/epapr_hcalls.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/include/asm/epapr_hcalls.h

Re: [PATCH] watchdog: Fix a typo

2021-03-20 Thread Randy Dunlap
On Sun, 21 Mar 2021, Bhaskar Chowdhury wrote: s/parmeter/parameter/ Signed-off-by: Bhaskar Chowdhury Acked-by: Randy Dunlap --- drivers/watchdog/sl28cpld_wdt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/watchdog/sl28cpld_wdt.c

Re: [PATCH] drm/vmwgfx: Fix a typo

2021-03-20 Thread Randy Dunlap
On Sun, 21 Mar 2021, Bhaskar Chowdhury wrote: s/particuar/particular/ Signed-off-by: Bhaskar Chowdhury Acked-by: Randy Dunlap --- drivers/gpu/drm/vmwgfx/vmwgfx_so.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_so.c

Re: [PATCH] docs: networking: Fix a typo

2021-03-20 Thread Randy Dunlap
On Sun, 21 Mar 2021, Bhaskar Chowdhury wrote: s/subsytem/subsystem/ Signed-off-by: Bhaskar Chowdhury Acked-by: Randy Dunlap --- Documentation/networking/xfrm_device.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/networking/xfrm_device.rst

Re: [PATCH] nvme-fc: Few trivial spelling fixes

2021-03-20 Thread Randy Dunlap
On Sun, 21 Mar 2021, Bhaskar Chowdhury wrote: s/boundarys/boundaries/ . two different places s/assocated/associated/ s/compeletion/completion/ s/tranferred/transferred/ s/subsytem/subsystem/ Signed-off-by: Bhaskar Chowdhury Acked-by: Randy Dunlap ---

Re: [PATCH] driver core: Trivial typo fix

2021-03-20 Thread Randy Dunlap
On Sun, 21 Mar 2021, Bhaskar Chowdhury wrote: s/subsytem/subsystem/ Signed-off-by: Bhaskar Chowdhury Acked-by: Randy Dunlap --- include/linux/device.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/device.h b/include/linux/device.h index

[PATCH v3 net-next 12/12] net: ocelot: replay switchdev events when joining bridge

2021-03-20 Thread Vladimir Oltean
From: Vladimir Oltean The premise of this change is that the switchdev port attributes and objects offloaded by ocelot might have been missed when we are joining an already existing bridge port, such as a bonding interface. The patch pulls these switchdev attributes and objects from the bridge,

[PATCH v3 net-next 11/12] net: ocelot: call ocelot_netdevice_bridge_join when joining a bridged LAG

2021-03-20 Thread Vladimir Oltean
From: Vladimir Oltean Similar to the DSA situation, ocelot supports LAG offload but treats this scenario improperly: ip link add br0 type bridge ip link add bond0 type bond ip link set bond0 master br0 ip link set swp0 master bond0 We do the same thing as we do there, which is to simulate a

[PATCH v3 net-next 10/12] net: dsa: replay VLANs installed on port when joining the bridge

2021-03-20 Thread Vladimir Oltean
From: Vladimir Oltean Currently this simple setup: ip link add br0 type bridge vlan_filtering 1 ip link add bond0 type bond ip link set bond0 master br0 ip link set swp0 master bond0 will not work because the bridge has created the PVID in br_add_if -> nbp_vlan_init, and it has notified

[PATCH v3 net-next 09/12] net: dsa: replay port and local fdb entries when joining the bridge

2021-03-20 Thread Vladimir Oltean
From: Vladimir Oltean When a DSA port joins a LAG that already had an FDB entry pointing to it: ip link set bond0 master br0 bridge fdb add dev bond0 00:01:02:03:04:05 master static ip link set swp0 master bond0 the DSA port will have no idea that this FDB entry is there, because it missed the

[PATCH v3 net-next 08/12] net: dsa: replay port and host-joined mdb entries when joining the bridge

2021-03-20 Thread Vladimir Oltean
From: Vladimir Oltean I have udhcpcd in my system and this is configured to bring interfaces up as soon as they are created. I create a bridge as follows: ip link add br0 type bridge As soon as I create the bridge and udhcpcd brings it up, I also have avahi which automatically starts sending

[PATCH v3 net-next 07/12] net: dsa: sync ageing time when joining the bridge

2021-03-20 Thread Vladimir Oltean
From: Vladimir Oltean The SWITCHDEV_ATTR_ID_BRIDGE_AGEING_TIME attribute is only emitted from: sysfs/ioctl/netlink -> br_set_ageing_time -> __set_ageing_time therefore not at bridge port creation time, so: (a) drivers had to hardcode the initial value for the address ageing time,

[PATCH v3 net-next 06/12] net: dsa: sync multicast router state when joining the bridge

2021-03-20 Thread Vladimir Oltean
From: Vladimir Oltean Make sure that the multicast router setting of the bridge is picked up correctly by DSA when joining, regardless of whether there are sandwiched interfaces or not. The SWITCHDEV_ATTR_ID_BRIDGE_MROUTER port attribute is only emitted from br_mc_router_state_change.

[PATCH v3 net-next 05/12] net: dsa: sync up VLAN filtering state when joining the bridge

2021-03-20 Thread Vladimir Oltean
From: Vladimir Oltean This is the same situation as for other switchdev port attributes: if we join an already-created bridge port, such as a bond master interface, then we can miss the initial switchdev notification emitted by the bridge for this port. Signed-off-by: Vladimir Oltean

[PATCH v3 net-next 04/12] net: dsa: sync up with bridge port's STP state when joining

2021-03-20 Thread Vladimir Oltean
From: Vladimir Oltean It may happen that we have the following topology: ip link add br0 type bridge stp_state 1 ip link add bond0 type bond ip link set bond0 master br0 ip link set swp0 master bond0 ip link set swp1 master bond0 STP decides that it should put bond0 into the BLOCKING state,

[PATCH v3 net-next 01/12] net: dsa: call dsa_port_bridge_join when joining a LAG that is already in a bridge

2021-03-20 Thread Vladimir Oltean
From: Vladimir Oltean DSA can properly detect and offload this sequence of operations: ip link add br0 type bridge ip link add bond0 type bond ip link set swp0 master bond0 ip link set bond0 master br0 But not this one: ip link add br0 type bridge ip link add bond0 type bond ip link set bond0

[PATCH v3 net-next 03/12] net: dsa: inherit the actual bridge port flags at join time

2021-03-20 Thread Vladimir Oltean
From: Vladimir Oltean DSA currently assumes that the bridge port starts off with this constellation of bridge port flags: - learning on - unicast flooding on - multicast flooding on - broadcast flooding on just by virtue of code copy-pasta from the bridge layer (new_nbp). This was a simple

[PATCH v3 net-next 00/12] Better support for sandwiched LAGs with bridge and DSA

2021-03-20 Thread Vladimir Oltean
From: Vladimir Oltean The objective of this series is to make LAG uppers on top of switchdev ports work regardless of which order we link interfaces to their masters (first make the port join the LAG, then the LAG join the bridge, or the other way around). There was a design decision to be made

[PATCH v3 net-next 02/12] net: dsa: pass extack to dsa_port_{bridge,lag}_join

2021-03-20 Thread Vladimir Oltean
From: Vladimir Oltean This is a pretty noisy change that was broken out of the larger change for replaying switchdev attributes and objects at bridge join time, which is when these extack objects are actually used. Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli --- Changes in

Re: [PATCH] xfs: Rudimentary typo fixes

2021-03-20 Thread Randy Dunlap
On Sun, 21 Mar 2021, Bhaskar Chowdhury wrote: s/filesytem/filesystem/ s/instrumention/instrumentation/ Signed-off-by: Bhaskar Chowdhury Acked-by: Randy Dunlap --- fs/xfs/xfs_log_recover.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/xfs/xfs_log_recover.c

Re: [PATCH v24 09/10] fs/ntfs3: Add NTFS3 in fs/Kconfig and fs/Makefile

2021-03-20 Thread Oleksandr Natalenko
On Fri, Mar 19, 2021 at 09:52:09PM +0300, Konstantin Komarov wrote: > This adds NTFS3 in fs/Kconfig and fs/Makefile > > Signed-off-by: Konstantin Komarov > --- > fs/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/fs/Kconfig b/fs/Kconfig > index a55bda4233bb..f61330e4efc0

[PATCH v2 3/3] ALSA: rme9652: don't disable if not enabled

2021-03-20 Thread Tong Zhang
rme9652 wants to disable a not enabled pci device, which makes kernel throw a warning. Make sure the device is enabled before calling disable. [1.751595] snd_rme9652 :00:03.0: disabling already-disabled device [1.751605] WARNING: CPU: 0 PID: 174 at drivers/pci/pci.c:2146

[PATCH v2 2/3] ALSA: hdspm: don't disable if not enabled

2021-03-20 Thread Tong Zhang
hdspm wants to disable a not enabled pci device, which makes kernel throw a warning. Make sure the device is enabled before calling disable. [1.786391] snd_hdspm :00:03.0: disabling already-disabled device [1.786400] WARNING: CPU: 0 PID: 182 at drivers/pci/pci.c:2146

[PATCH v2 0/3] ALSA: hdsp and hdspm, don't disable device if not enabled

2021-03-20 Thread Tong Zhang
This series fixes issues in hdsp and hdspm. The drivers in question want to disable a device that is not enabled on error path. v2: add fix to rme9652 Tong Zhang (3): ALSA: hdsp: don't disable if not enabled ALSA: hdspm: don't disable if not enabled ALSA: rme9652: don't disable if not

[PATCH v2 1/3] ALSA: hdsp: don't disable if not enabled

2021-03-20 Thread Tong Zhang
hdsp wants to disable a not enabled pci device, which makes kernel throw a warning. Make sure the device is enabled before calling disable. [1.758292] snd_hdsp :00:03.0: disabling already-disabled device [1.758327] WARNING: CPU: 0 PID: 180 at drivers/pci/pci.c:2146

Re: [PATCH v4 14/22] x86/fpu/xstate: Expand the xstate buffer on the first use of dynamic user state

2021-03-20 Thread Andy Lutomirski
On Sat, Mar 20, 2021 at 3:13 PM Thomas Gleixner wrote: > > On Sun, Feb 21 2021 at 10:56, Chang S. Bae wrote: > > + > > +/* Update MSR IA32_XFD with xfirstuse_not_detected() if needed. */ > > +static inline void xdisable_switch(struct fpu *prev, struct fpu *next) > > +{ > > + if

[PATCH] sched/fair: remove redundant test_idle_cores for non-smt

2021-03-20 Thread Barry Song
update_idle_core() is only done for the case of sched_smt_present. but test_idle_cores() is done for all machines even those without smt. this could contribute to up 8%+ hackbench performance loss on a machine like kunpeng 920 which has no smt. this patch removes the redundant test_idle_cores()

[PATCH 2/2] ALSA: hdspm: don't disable if not enabled

2021-03-20 Thread Tong Zhang
hdspm wants to disable a not enabled pci device, which makes kernel throw a warning. Make sure the device is enabled before calling disable. [1.786391] snd_hdspm :00:03.0: disabling already-disabled device [1.786400] WARNING: CPU: 0 PID: 182 at drivers/pci/pci.c:2146

[PATCH 1/2] ALSA: hdsp: don't disable if not enabled

2021-03-20 Thread Tong Zhang
hdsp wants to disable a not enabled pci device, which makes kernel throw a warning. Make sure the device is enabled before calling disable. [1.758292] snd_hdsp :00:03.0: disabling already-disabled device [1.758327] WARNING: CPU: 0 PID: 180 at drivers/pci/pci.c:2146

[PATCH 0/2] ALSA: hdsp and hdspm, don't disable device if not enabled

2021-03-20 Thread Tong Zhang
This series fixes issues in hdsp and hdspm. The drivers in question want to disable a device that is not enabled on error path. Tong Zhang (2): ALSA: hdsp: don't disable if not enabled ALSA: hdspm: don't disable if not enabled sound/pci/rme9652/hdsp.c | 10 ++

Re: [PATCH v4 14/22] x86/fpu/xstate: Expand the xstate buffer on the first use of dynamic user state

2021-03-20 Thread Thomas Gleixner
On Sun, Feb 21 2021 at 10:56, Chang S. Bae wrote: > + > +/* Update MSR IA32_XFD with xfirstuse_not_detected() if needed. */ > +static inline void xdisable_switch(struct fpu *prev, struct fpu *next) > +{ > + if (!static_cpu_has(X86_FEATURE_XFD) || !xfirstuse_enabled()) > + return; >

Re: [PATCH 2/3] clocksource/drivers/timer-ti-dm: Remove extra of_node_put()

2021-03-20 Thread Daniel Lezcano
On 08/03/2021 16:26, Tony Lindgren wrote: > Hi, > > * Tony Lindgren [210305 07:58]: >> * Grygorii Strashko [210304 20:56]: >>> >>> >>> On 04/03/2021 09:21, Tony Lindgren wrote: We have of_translate_address() already do of_node_put() as needed. I probably looked at

[PATCH 1/2] perf daemon: Force waipid for all session on SIGCHLD delivery

2021-03-20 Thread Jiri Olsa
If we don't process SIGCHLD before another comes, we will see just one SIGCHLD as a result. In this case current code will miss exit notification for a session and wait forever. Adding extra waitpid check for all sessions when SIGCHLD is received, to make sure we don't miss any session exit.

[PATCH 2/2] perf daemon: Return from kill functions

2021-03-20 Thread Jiri Olsa
We should return correctly and warn in both daemon_session__kill and daemon__kill functions after we tried everything to kill sessions. Current code will keep on looping and wait. Signed-off-by: Jiri Olsa --- tools/perf/builtin-daemon.c | 7 +-- 1 file changed, 5 insertions(+), 2

Re: [PATCHSET 0/2] PF_IO_WORKER signal tweaks

2021-03-20 Thread Eric W. Biederman
Added criu because I just realized that io_uring (which can open files from an io worker thread) looks to require some special handling for stopping and freezing processes. If not in the SIGSTOP case in the related cgroup freezer case. Linus Torvalds writes: > On Sat, Mar 20, 2021 at 10:51

Re: [PATCH v3][next] xfs: Replace one-element arrays with flexible-array members

2021-03-20 Thread Darrick J. Wong
On Sat, Mar 20, 2021 at 03:20:55PM -0500, Gustavo A. R. Silva wrote: > > > On 3/20/21 15:17, Darrick J. Wong wrote: > Below are the results of running xfstests for groups shutdown and log > with the following configuration in local.config: > > export TEST_DEV=/dev/sda3 >

[PATCH] powerpc: epapr: A typo fix

2021-03-20 Thread Bhaskar Chowdhury
s/parmeters/parameters/ Signed-off-by: Bhaskar Chowdhury --- arch/powerpc/include/asm/epapr_hcalls.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/include/asm/epapr_hcalls.h b/arch/powerpc/include/asm/epapr_hcalls.h index c99ba08a408d..cdf3c6df5123 100644

Re: [PATCH 1/2] signal: don't allow sending any signals to PF_IO_WORKER threads

2021-03-20 Thread Eric W. Biederman
Linus Torvalds writes: > On Sat, Mar 20, 2021 at 9:19 AM Eric W. Biederman > wrote: >> >> The creds should be reasonably in-sync with the rest of the threads. > > It's not about credentials (despite the -EPERM). > > It's about the fact that kernel threads cannot handle signals, and > then get

[PATCH] watchdog: Fix a typo

2021-03-20 Thread Bhaskar Chowdhury
s/parmeter/parameter/ Signed-off-by: Bhaskar Chowdhury --- drivers/watchdog/sl28cpld_wdt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/watchdog/sl28cpld_wdt.c b/drivers/watchdog/sl28cpld_wdt.c index a45047d8d9ab..2de93298475f 100644 ---

Re: Linux 5.10.25

2021-03-20 Thread Jamie Heilman
[ugh, resent with the lkml headers unbroken, sorry about the dupe] Greg Kroah-Hartman wrote: > J. Bruce Fields (2): > Revert "nfsd4: remove check_conflicting_opens warning" > Revert "nfsd4: a client's own opens needn't prevent delegations" Hrm, just got this when I udpated my nfs

Re: [PATCH v4 18/22] x86/fpu/amx: Define AMX state components and have it used for boot-time checks

2021-03-20 Thread Thomas Gleixner
On Sun, Feb 21 2021 at 10:56, Chang S. Bae wrote: > > +static void check_xtile_data_against_struct(int size) > +{ > + u32 max_palid, palid, state_size; > + u32 eax, ebx, ecx, edx; > + u16 max_tile; > + > + /* > + * Check the maximum palette id: > + * eax: the highest

Re: [PATCH v5] coccinelle: misc: add minmax script

2021-03-20 Thread Julia Lawall
On Tue, 9 Mar 2021, Denis Efremov wrote: > Check for opencoded min(), max() implementations. > > Signed-off-by: Denis Efremov Applied, thanks. julia > --- > Changes in v2: > - <... ...> instead of ... when any > - org mode reports fixed > - patch rule to drop excessive () > Changes in

Re: [PATCH v4 19/22] x86/fpu/amx: Enable the AMX feature in 64-bit mode

2021-03-20 Thread Thomas Gleixner
On Sun, Feb 21 2021 at 10:56, Chang S. Bae wrote: > In 64-bit mode, include the AMX state components in > XFEATURE_MASK_USER_SUPPORTED. > > The XFD feature will be used to dynamically expand the xstate per-task > buffer on the first use. This patch touches absolutely nothing XFD related. What's

  1   2   3   4   >