Re: [PATCH v7 7/8] xfs: Implement ->notify_failure() for XFS

2021-10-15 Thread Christoph Hellwig
On Fri, Sep 24, 2021 at 09:09:58PM +0800, Shiyang Ruan wrote: > +void fs_dax_register_holder(struct dax_device *dax_dev, void *holder, > + const struct dax_holder_operations *ops) > +{ > + dax_set_holder(dax_dev, holder, ops); > +} > +EXPORT_SYMBOL_GPL(fs_dax_register_holder); > +

Re: [PATCH v7 8/8] fsdax: add exception for reflinked files

2021-10-15 Thread Christoph Hellwig
On Thu, Oct 14, 2021 at 12:24:50PM -0700, Darrick J. Wong wrote: > It feels a little dangerous to have page->mapping for shared storage > point to an actual address_space when there are really multiple > potential address_spaces out there. If the mm or dax folks are ok with > doing this this way

Re: [PATCH v7 4/8] pagemap,pmem: Introduce ->memory_failure()

2021-10-15 Thread Christoph Hellwig
Except for the error code inversion noticed by Darrick this looks fine to me: Reviewed-by: Christoph Hellwig

Re: [PATCH v7 3/8] mm: factor helpers for memory_failure_dev_pagemap

2021-10-15 Thread Christoph Hellwig
On Fri, Sep 24, 2021 at 09:09:54PM +0800, Shiyang Ruan wrote: > memory_failure_dev_pagemap code is a bit complex before introduce RMAP > feature for fsdax. So it is needed to factor some helper functions to > simplify these code. > > Signed-off-by: Shiyang Ruan > --- > mm/memory-failure.c |

Re: [PATCH v7 1/8] dax: Use rwsem for dax_{read,write}_lock()

2021-10-15 Thread Christoph Hellwig
On Fri, Sep 24, 2021 at 09:09:52PM +0800, Shiyang Ruan wrote: > In order to introduce dax holder registration, we need a write lock for > dax. Because of the rarity of notification failures and the infrequency > of registration events, it would be better to be a global lock rather > than