Re: Re: Re: EEVDF/vhost regression (bisected to 86bfbb7ce4f6 sched/fair: Add lag based placement)

2024-01-31 Thread Tobias Huschle
On Sun, Jan 21, 2024 at 01:44:32PM -0500, Michael S. Tsirkin wrote: > On Mon, Jan 08, 2024 at 02:13:25PM +0100, Tobias Huschle wrote: > > On Thu, Dec 14, 2023 at 02:14:59AM -0500, Michael S. Tsirkin wrote: > > - Along with the wakeup of the kworker, need_resched needs to > > be set, such that

[v1] trace/hwlat: stop worker if !is_percpu_thread due to hotplug event

2024-01-31 Thread Andy Chiu
If the task happens to run after cpu hot-plug offline, then it would not be running in a percpu_thread. Instead, it would be re-queued into a UNBOUND workqueue. This would trigger a warning if we enable kernel preemption. Signed-off-by: Andy Chiu --- kernel/trace/trace_hwlat.c | 11 ++-

[v1] trace/osnoise: prevent osnoise hotplog worker running in UNBOUND workqueue

2024-01-31 Thread Andy Chiu
smp_processor_id() should be called with migration disabled. This mean we may safely call smp_processor_id() in percpu thread. However, this is not the case if the work is (re-)queued into unbound workqueue, during cpu-hotplog. So, detect and return early if this work happens to run on an unbound

Re: [PATCH RFC v3 13/35] mm: memory: Introduce fault-on-access mechanism for pages

2024-01-31 Thread Anshuman Khandual
On 1/25/24 22:12, Alexandru Elisei wrote: > Introduce a mechanism that allows an architecture to trigger a page fault, > and add the infrastructure to handle that fault accordingly. To use make> use > of this, an arch is expected to mark the table entry as PAGE_NONE (which > will cause a fault

Re: [PATCH 0/4] apply page shift to PFN instead of VA in pfn_to_virt

2024-01-31 Thread Arnd Bergmann
On Thu, Feb 1, 2024, at 01:01, Yan Zhao wrote: > On Wed, Jan 31, 2024 at 12:48:38PM +0100, Arnd Bergmann wrote: >> On Wed, Jan 31, 2024, at 06:51, Yan Zhao wrote: >> >> How exactly did you notice the function being wrong, >> did you try to add a user somewhere, or just read through >> the code? >

Re: [PATCH v4] virtio_net: Support RX hash XDP hint

2024-01-31 Thread Jason Wang
On Wed, Jan 31, 2024 at 11:55 AM Liang Chen wrote: > > The RSS hash report is a feature that's part of the virtio specification. > Currently, virtio backends like qemu, vdpa (mlx5), and potentially vhost > (still a work in progress as per [1]) support this feature. While the > capability to

Re: [PATCH v1] module.h: define __symbol_get_gpl() as a regular __symbol_get()

2024-01-31 Thread Christoph Hellwig
On Wed, Jan 31, 2024 at 10:02:52PM +0300, Andrew Kanner wrote: > Prototype for __symbol_get_gpl() was introduced in the initial git > commit 1da177e4c3f4 ("Linux-2.6.12-rc2"), but was not used after that. > > In commit 9011e49d54dc ("modules: only allow symbol_get of > EXPORT_SYMBOL_GPL modules")

Re: [PATCH] lib/test_kmod: fix kernel-doc warnings

2024-01-31 Thread Randy Dunlap
Hi, Any comments on this patch? Thanks. On 11/3/23 21:20, Randy Dunlap wrote: > Fix all kernel-doc warnings in test_kmod.c: > - Mark some enum values as private so that kernel-doc is not needed > for them > - s/thread_mutex/thread_lock/ in a struct's kernel-doc comments > - add kernel-doc

[PATCH v3] tracefs: dentry lookup crapectomy

2024-01-31 Thread Steven Rostedt
From: Linus Torvalds The dentry lookup for eventfs files was very broken, and had lots of signs of the old situation where the filesystem names were all created statically in the dentry tree, rather than being looked up dynamically based on the eventfs data structures. You could see it in the

Re: [PATCH v2 4/7] tracefs: dentry lookup crapectomy

2024-01-31 Thread Steven Rostedt
On Wed, 31 Jan 2024 22:21:27 -0500 Steven Rostedt wrote: > We (Linus and I) got it wrong. It originally had: > > d_add(dentry, NULL); > [..] > return NULL; OK, so I changed that function to this: static struct dentry *eventfs_root_lookup(struct inode *dir,

Re: [PATCH RFC v3 12/35] mm: Call arch_swap_prepare_to_restore() before arch_swap_restore()

2024-01-31 Thread Anshuman Khandual
On 1/25/24 22:12, Alexandru Elisei wrote: > arm64 uses arch_swap_restore() to restore saved tags before the page is > swapped in and it's called in atomic context (with the ptl lock held). > > Introduce arch_swap_prepare_to_restore() that will allow an architecture to > perform extra work

Re: [PATCH v2 4/7] tracefs: dentry lookup crapectomy

2024-01-31 Thread Steven Rostedt
On Thu, 1 Feb 2024 03:02:05 + Al Viro wrote: > > We had a problem here with just returning NULL. It leaves the negative > > dentry around and doesn't get refreshed. > > Why would that dentry stick around? And how would anyone find > it, anyway, when it's not hashed? We (Linus and I) got

[PATCH v4 6/6] LoongArch: Add pv ipi support on LoongArch system

2024-01-31 Thread Bibo Mao
On LoongArch system, ipi hw uses iocsr registers, there is one iocsr register access on ipi sending, and two iocsr access on ipi receiving which is ipi interrupt handler. On VM mode all iocsr registers accessing will cause VM to trap into hypervisor. So with ipi hw notification once there will be

[PATCH v4 5/6] LoongArch: KVM: Add vcpu search support from physical cpuid

2024-01-31 Thread Bibo Mao
Physical cpuid is used for interrupt routing for irqchips such as ipi/msi/extioi interrupt controller. And physical cpuid is stored at CSR register LOONGARCH_CSR_CPUID, it can not be changed once vcpu is created and physical cpuid of two vcpu can not be the same. Since different irqchips have

[PATCH v4 4/6] LoongArch: Add paravirt interface for guest kernel

2024-01-31 Thread Bibo Mao
The patch adds paravirt interface for guest kernel, function pv_guest_initi() firstly checks whether system runs on VM mode. If kernel runs on VM mode, it will call function kvm_para_available() to detect whether current VMM is KVM hypervisor. And the paravirt function can work only if current VMM

[PATCH v4 0/6] LoongArch: Add pv ipi support on LoongArch VM

2024-01-31 Thread Bibo Mao
This patchset adds pv ipi support for VM. On physical machine, ipi HW uses IOCSR registers, however there is trap into hypervisor when vcpu accesses IOCSR registers if system is in VM mode. SWI is a interrupt mechanism like SGI on ARM, software can send interrupt to CPU, only that on LoongArch SWI

[PATCH v4 2/6] LoongArch: KVM: Add hypercall instruction emulation support

2024-01-31 Thread Bibo Mao
On LoongArch system, hypercall instruction is supported when system runs on VM mode. This patch adds dummy function with hypercall instruction emulation, rather than inject EXCCODE_INE invalid instruction exception. Signed-off-by: Bibo Mao --- arch/loongarch/include/asm/Kbuild | 1 -

[PATCH v4 3/6] LoongArch: KVM: Add cpucfg area for kvm hypervisor

2024-01-31 Thread Bibo Mao
VM will trap into hypervisor when executing cpucfg instruction. And hardware only uses the area 0 - 20 for actual usage now, here one specified area 0x4000 -- 0x40ff is used for KVM hypervisor, and the area can be extended to use for other hypervisors in future. Signed-off-by: Bibo Mao

[PATCH v4 1/6] LoongArch/smp: Refine ipi ops on LoongArch platform

2024-01-31 Thread Bibo Mao
This patch refines ipi handling on LoongArch platform, there are three changes with this patch. 1. Add generic get_percpu_irq() api, replace some percpu irq functions such as get_ipi_irq()/get_pmc_irq()/get_timer_irq() with get_percpu_irq(). 2. Change parameter action definition with function

Re: [PATCH v2 4/7] tracefs: dentry lookup crapectomy

2024-01-31 Thread Al Viro
On Wed, Jan 31, 2024 at 09:26:42PM -0500, Steven Rostedt wrote: > > Huh? Just return NULL and be done with that - you'll get an > > unhashed negative dentry and let the caller turn that into > > -ENOENT... > > We had a problem here with just returning NULL. It leaves the negative > dentry

Re: [PATCH v2 4/7] tracefs: dentry lookup crapectomy

2024-01-31 Thread Steven Rostedt
On Thu, 1 Feb 2024 00:27:19 + Al Viro wrote: > On Wed, Jan 31, 2024 at 01:49:22PM -0500, Steven Rostedt wrote: > > > @@ -329,32 +320,29 @@ static struct dentry *create_file(const char *name, > > umode_t mode, > > > > ti = get_tracefs(inode); > > ti->flags |= TRACEFS_EVENT_INODE;

[PATCH] remoteproc: zynqmp: fix lockstep mode memory region

2024-01-31 Thread Tanmay Shah
In lockstep mode, r5 core0 uses TCM of R5 core1. Following is lockstep mode memory region as per hardware reference manual. | *TCM* | *R5 View* | *Linux view* | | R5_0 ATCM (128 KB) | 0x_ | 0xFFE0_ | | R5_0 BTCM (128 KB) | 0x0002_ | 0xFFE2_ |

Re: [PATCH 0/4] apply page shift to PFN instead of VA in pfn_to_virt

2024-01-31 Thread Yan Zhao
On Wed, Jan 31, 2024 at 12:48:38PM +0100, Arnd Bergmann wrote: > On Wed, Jan 31, 2024, at 06:51, Yan Zhao wrote: > > This is a tiny fix to pfn_to_virt() for some platforms. > > > > The original implementaion of pfn_to_virt() takes PFN instead of PA as the > > input to macro __va, with PAGE_SHIFT

Re: [PATCH v2 4/7] tracefs: dentry lookup crapectomy

2024-01-31 Thread Al Viro
On Wed, Jan 31, 2024 at 01:49:22PM -0500, Steven Rostedt wrote: > @@ -329,32 +320,29 @@ static struct dentry *create_file(const char *name, > umode_t mode, > > ti = get_tracefs(inode); > ti->flags |= TRACEFS_EVENT_INODE; > - d_instantiate(dentry, inode); > + > +

[PATCH v3 46/47] filelock: remove temporary compatibility macros

2024-01-31 Thread Jeff Layton
Everything has been converted to access fl_core fields directly, so we can now drop these. Signed-off-by: Jeff Layton --- include/linux/filelock.h | 16 1 file changed, 16 deletions(-) diff --git a/include/linux/filelock.h b/include/linux/filelock.h index

[PATCH v3 38/47] gfs2: adapt to breakup of struct file_lock

2024-01-31 Thread Jeff Layton
Most of the existing APIs have remained the same, but subsystems that access file_lock fields directly need to reach into struct file_lock_core now. Signed-off-by: Jeff Layton --- fs/gfs2/file.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/fs/gfs2/file.c

[PATCH v3 16/47] filelock: drop the IS_* macros

2024-01-31 Thread Jeff Layton
These don't add a lot of value over just open-coding the flag check. Suggested-by: NeilBrown Signed-off-by: Jeff Layton --- fs/locks.c | 32 +++- 1 file changed, 15 insertions(+), 17 deletions(-) diff --git a/fs/locks.c b/fs/locks.c index 149070fd3b66..d685c3fdbea5

Re: [PATCH 6/6] eventfs: clean up dentry ops and add revalidate function

2024-01-31 Thread Steven Rostedt
On Thu, 1 Feb 2024 08:07:15 +0900 Masami Hiramatsu (Google) wrote: > > Then tracefs could be nicely converted over to kernfs, and eventfs would be > > its own entity. > > If so, maybe we can just make symlinks to the 'id' and 'format' from events > under tracefs? :) I don't think that will

[PATCH v3 17/47] filelock: split common fields into struct file_lock_core

2024-01-31 Thread Jeff Layton
In a future patch, we're going to split file leases into their own structure. Since a lot of the underlying machinery uses the same fields move those into a new file_lock_core, and embed that inside struct file_lock. For now, add some macros to ensure that we can continue to build while the

Re: [PATCH 6/6] eventfs: clean up dentry ops and add revalidate function

2024-01-31 Thread Google
On Wed, 31 Jan 2024 13:00:39 -0500 Steven Rostedt wrote: > On Tue, 30 Jan 2024 11:03:55 -0800 > Linus Torvalds wrote: > > > It would probably be cleaner to make eventfs its own filesystem, or at > > least set its own dentry ops when looking up eventfs files. But as it > > is, only eventfs

[PATCH v3 47/47] filelock: split leases out of struct file_lock

2024-01-31 Thread Jeff Layton
Add a new struct file_lease and move the lease-specific fields from struct file_lock to it. Convert the appropriate API calls to take struct file_lease instead, and convert the callers to use them. There is zero overlap between the lock manager operations for file locks and the ones for file

[PATCH v3 43/47] ocfs2: adapt to breakup of struct file_lock

2024-01-31 Thread Jeff Layton
Most of the existing APIs have remained the same, but subsystems that access file_lock fields directly need to reach into struct file_lock_core now. Signed-off-by: Jeff Layton --- fs/ocfs2/locks.c | 9 - fs/ocfs2/stack_user.c | 1 - 2 files changed, 4 insertions(+), 6 deletions(-)

[PATCH v3 45/47] smb/server: adapt to breakup of struct file_lock

2024-01-31 Thread Jeff Layton
Most of the existing APIs have remained the same, but subsystems that access file_lock fields directly need to reach into struct file_lock_core now. Signed-off-by: Jeff Layton --- fs/smb/server/smb2pdu.c | 39 +++ fs/smb/server/vfs.c | 9 - 2

[PATCH v3 44/47] smb/client: adapt to breakup of struct file_lock

2024-01-31 Thread Jeff Layton
Most of the existing APIs have remained the same, but subsystems that access file_lock fields directly need to reach into struct file_lock_core now. Signed-off-by: Jeff Layton --- fs/smb/client/cifsglob.h | 1 - fs/smb/client/cifssmb.c | 9 +++ fs/smb/client/file.c | 67

[PATCH v3 15/47] smb/server: convert to using new filelock helpers

2024-01-31 Thread Jeff Layton
Convert to using the new file locking helper functions. Signed-off-by: Jeff Layton --- fs/smb/server/smb2pdu.c | 6 +++--- fs/smb/server/vfs.c | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/fs/smb/server/smb2pdu.c b/fs/smb/server/smb2pdu.c index

[PATCH v3 42/47] nfsd: adapt to breakup of struct file_lock

2024-01-31 Thread Jeff Layton
Most of the existing APIs have remained the same, but subsystems that access file_lock fields directly need to reach into struct file_lock_core now. Signed-off-by: Jeff Layton --- fs/nfsd/filecache.c| 4 +-- fs/nfsd/netns.h| 1 - fs/nfsd/nfs4callback.c | 2 +-

[PATCH v3 41/47] nfs: adapt to breakup of struct file_lock

2024-01-31 Thread Jeff Layton
Most of the existing APIs have remained the same, but subsystems that access file_lock fields directly need to reach into struct file_lock_core now. Signed-off-by: Jeff Layton --- fs/nfs/delegation.c | 2 +- fs/nfs/file.c | 19 +-- fs/nfs/nfs3proc.c | 2 +-

[PATCH v3 40/47] lockd: adapt to breakup of struct file_lock

2024-01-31 Thread Jeff Layton
Most of the existing APIs have remained the same, but subsystems that access file_lock fields directly need to reach into struct file_lock_core now. Signed-off-by: Jeff Layton --- fs/lockd/clnt4xdr.c | 14 +- fs/lockd/clntlock.c | 2 +- fs/lockd/clntproc.c | 62

[PATCH v3 39/47] fuse: adapt to breakup of struct file_lock

2024-01-31 Thread Jeff Layton
Most of the existing APIs have remained the same, but subsystems that access file_lock fields directly need to reach into struct file_lock_core now. Signed-off-by: Jeff Layton --- fs/fuse/file.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/fs/fuse/file.c

[PATCH v3 37/47] dlm: adapt to breakup of struct file_lock

2024-01-31 Thread Jeff Layton
Most of the existing APIs have remained the same, but subsystems that access file_lock fields directly need to reach into struct file_lock_core now. Signed-off-by: Jeff Layton --- fs/dlm/plock.c | 45 ++--- 1 file changed, 22 insertions(+), 23

[PATCH v3 36/47] ceph: adapt to breakup of struct file_lock

2024-01-31 Thread Jeff Layton
Most of the existing APIs have remained the same, but subsystems that access file_lock fields directly need to reach into struct file_lock_core now. Signed-off-by: Jeff Layton --- fs/ceph/locks.c | 51 ++- 1 file changed, 26 insertions(+), 25

[PATCH v3 35/47] afs: adapt to breakup of struct file_lock

2024-01-31 Thread Jeff Layton
Most of the existing APIs have remained the same, but subsystems that access file_lock fields directly need to reach into struct file_lock_core now. Signed-off-by: Jeff Layton --- fs/afs/flock.c | 38 +++--- fs/afs/internal.h | 1 -

[PATCH v3 34/47] 9p: adapt to breakup of struct file_lock

2024-01-31 Thread Jeff Layton
Most of the existing APIs have remained the same, but subsystems that access file_lock fields directly need to reach into struct file_lock_core now. Signed-off-by: Jeff Layton --- fs/9p/vfs_file.c | 39 +++ 1 file changed, 19 insertions(+), 20 deletions(-)

[PATCH v3 33/47] filelock: convert seqfile handling to use file_lock_core

2024-01-31 Thread Jeff Layton
Reduce some pointer manipulation by just using file_lock_core where we can and only translate to a file_lock when needed. Signed-off-by: Jeff Layton --- fs/locks.c | 72 +++--- 1 file changed, 36 insertions(+), 36 deletions(-) diff --git

[PATCH v3 32/47] filelock: convert locks_translate_pid to take file_lock_core

2024-01-31 Thread Jeff Layton
locks_translate_pid is used on both locks and leases, so have that take struct file_lock_core. Signed-off-by: Jeff Layton --- fs/locks.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/fs/locks.c b/fs/locks.c index 50d02a53ca75..97f6e9163130 100644 ---

[PATCH v3 31/47] filelock: convert locks_insert_lock_ctx and locks_delete_lock_ctx

2024-01-31 Thread Jeff Layton
Have these functions take a file_lock_core pointer instead of a file_lock. Signed-off-by: Jeff Layton --- fs/locks.c | 44 ++-- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/fs/locks.c b/fs/locks.c index 9f3670ba0880..50d02a53ca75 100644

[PATCH v3 30/47] filelock: convert locks_wake_up_blocks to take a file_lock_core pointer

2024-01-31 Thread Jeff Layton
Have locks_wake_up_blocks take a file_lock_core pointer, and fix up the callers to pass one in. Signed-off-by: Jeff Layton --- fs/locks.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/fs/locks.c b/fs/locks.c index 6892511ed89b..9f3670ba0880 100644 ---

[PATCH v3 29/47] filelock: make assign_type helper take a file_lock_core pointer

2024-01-31 Thread Jeff Layton
Have assign_type take struct file_lock_core instead of file_lock. Signed-off-by: Jeff Layton --- fs/locks.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/fs/locks.c b/fs/locks.c index c8fd2964dd98..6892511ed89b 100644 --- a/fs/locks.c +++ b/fs/locks.c @@ -439,13

[PATCH v3 28/47] filelock: reorganize locks_delete_block and __locks_insert_block

2024-01-31 Thread Jeff Layton
Rename the old __locks_delete_block to __locks_unlink_lock. Rename change old locks_delete_block function to __locks_delete_block and have it take a file_lock_core. Make locks_delete_block a simple wrapper around __locks_delete_block. Also, change __locks_insert_block to take struct

[PATCH v3 27/47] filelock: clean up locks_delete_block internals

2024-01-31 Thread Jeff Layton
Rework the internals of locks_delete_block to use struct file_lock_core (mostly just for clarity's sake). The prototype is not changed. Signed-off-by: Jeff Layton --- fs/locks.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/fs/locks.c b/fs/locks.c index

[PATCH v3 26/47] filelock: convert fl_blocker to file_lock_core

2024-01-31 Thread Jeff Layton
Both locks and leases deal with fl_blocker. Switch the fl_blocker pointer in struct file_lock_core to point to the file_lock_core of the blocker instead of a file_lock structure. Signed-off-by: Jeff Layton --- fs/locks.c | 16 include/linux/filelock.h

[PATCH v3 25/47] filelock: convert __locks_insert_block, conflict and deadlock checks to use file_lock_core

2024-01-31 Thread Jeff Layton
Have both __locks_insert_block and the deadlock and conflict checking functions take a struct file_lock_core pointer instead of a struct file_lock one. Also, change posix_locks_deadlock to return bool. Signed-off-by: Jeff Layton --- fs/locks.c | 132

[PATCH v3 24/47] filelock: make __locks_delete_block and __locks_wake_up_blocks take file_lock_core

2024-01-31 Thread Jeff Layton
Convert __locks_delete_block and __locks_wake_up_blocks to take a struct file_lock_core pointer. While we could do this in another way, we're going to need to add a file_lock() helper function later anyway, so introduce and use it now. Signed-off-by: Jeff Layton --- fs/locks.c | 45

[PATCH v3 23/47] filelock: convert locks_{insert,delete}_global_blocked

2024-01-31 Thread Jeff Layton
Have locks_insert_global_blocked and locks_delete_global_blocked take a struct file_lock_core pointer. Signed-off-by: Jeff Layton --- fs/locks.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/fs/locks.c b/fs/locks.c index fa9b2beed0d7..ef67a5a7bae8 100644 ---

[PATCH v3 22/47] filelock: make locks_{insert,delete}_global_locks take file_lock_core arg

2024-01-31 Thread Jeff Layton
Convert these functions to take a file_lock_core instead of a file_lock. Signed-off-by: Jeff Layton --- fs/locks.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/fs/locks.c b/fs/locks.c index 1cfd02562e9f..fa9b2beed0d7 100644 --- a/fs/locks.c +++

[PATCH v3 21/47] filelock: convert posix_owner_key to take file_lock_core arg

2024-01-31 Thread Jeff Layton
Convert posix_owner_key to take struct file_lock_core pointer, and fix up the callers to pass one in. Signed-off-by: Jeff Layton --- fs/locks.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/fs/locks.c b/fs/locks.c index 9ff331b55b7a..1cfd02562e9f 100644 ---

[PATCH v3 20/47] filelock: make posix_same_owner take file_lock_core pointers

2024-01-31 Thread Jeff Layton
Change posix_same_owner to take struct file_lock_core pointers, and convert the callers to pass those in. Signed-off-by: Jeff Layton --- fs/locks.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/fs/locks.c b/fs/locks.c index 5d25a3f53c9d..9ff331b55b7a

[PATCH v3 19/47] filelock: convert more internal functions to use file_lock_core

2024-01-31 Thread Jeff Layton
Convert more internal fs/locks.c functions to take and deal with struct file_lock_core instead of struct file_lock: - locks_dump_ctx_list - locks_check_ctx_file_list - locks_release_private - locks_owner_has_blockers Signed-off-by: Jeff Layton --- fs/locks.c | 51

[PATCH v3 18/47] filelock: have fs/locks.c deal with file_lock_core directly

2024-01-31 Thread Jeff Layton
Convert fs/locks.c to access fl_core fields direcly rather than using the backward-compatibility macros. Most of this was done with coccinelle, with a few by-hand fixups. Signed-off-by: Jeff Layton --- fs/locks.c | 467

[PATCH v3 14/47] smb/client: convert to using new filelock helpers

2024-01-31 Thread Jeff Layton
Convert to using the new file locking helper functions. Signed-off-by: Jeff Layton --- fs/smb/client/file.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/fs/smb/client/file.c b/fs/smb/client/file.c index b75282c204da..27f9ef4e69a8 100644 ---

[PATCH v3 11/47] nfs: convert to using new filelock helpers

2024-01-31 Thread Jeff Layton
Convert to using the new file locking helper functions. Also, in later patches we're going to introduce some temporary macros with names that clash with the variable name in nfs4_proc_unlck. Rename it. Signed-off-by: Jeff Layton --- fs/nfs/delegation.c | 2 +- fs/nfs/file.c | 4 ++--

[PATCH v3 13/47] ocfs2: convert to using new filelock helpers

2024-01-31 Thread Jeff Layton
Convert to using the new file locking helper functions. Signed-off-by: Jeff Layton --- fs/ocfs2/locks.c | 4 ++-- fs/ocfs2/stack_user.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/ocfs2/locks.c b/fs/ocfs2/locks.c index f37174e79fad..ef4fd91b586e 100644 ---

[PATCH v3 12/47] nfsd: convert to using new filelock helpers

2024-01-31 Thread Jeff Layton
Convert to using the new file locking helper functions. Also, in later patches we're going to introduce some macros with names that clash with the variable names in nfsd4_lock. Rename them. Signed-off-by: Jeff Layton --- fs/nfsd/nfs4state.c | 32 1 file changed,

[PATCH v3 10/47] lockd: convert to using new filelock helpers

2024-01-31 Thread Jeff Layton
Convert to using the new file locking helper functions. Also in later patches we're going to introduce some macros with names that clash with the variable names in nlmclnt_lock. Rename them. Signed-off-by: Jeff Layton --- fs/lockd/clntproc.c | 20 ++-- fs/lockd/svcsubs.c | 6

[PATCH v3 09/47] gfs2: convert to using new filelock helpers

2024-01-31 Thread Jeff Layton
Convert to using the new file locking helper functions. Signed-off-by: Jeff Layton --- fs/gfs2/file.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/fs/gfs2/file.c b/fs/gfs2/file.c index 992ca4effb50..6c25aea30f1b 100644 --- a/fs/gfs2/file.c +++ b/fs/gfs2/file.c @@

[PATCH v3 08/47] dlm: convert to using new filelock helpers

2024-01-31 Thread Jeff Layton
Convert to using the new file locking helper functions. Also, in later patches we're going to introduce some temporary macros with names that clash with the variable name in dlm_posix_unlock. Rename it. Signed-off-by: Jeff Layton --- fs/dlm/plock.c | 10 +- 1 file changed, 5

[PATCH v3 06/47] afs: convert to using new filelock helpers

2024-01-31 Thread Jeff Layton
Convert to using the new file locking helper functions. Also, in later patches we're going to introduce macros that conflict with the variable name in afs_next_locker. Rename it. Signed-off-by: Jeff Layton --- fs/afs/flock.c | 26 +- 1 file changed, 13 insertions(+), 13

[PATCH v3 07/47] ceph: convert to using new filelock helpers

2024-01-31 Thread Jeff Layton
Convert to using the new file locking helper functions. Signed-off-by: Jeff Layton --- fs/ceph/locks.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/fs/ceph/locks.c b/fs/ceph/locks.c index e07ad29ff8b9..80ebe1d6c67d 100644 --- a/fs/ceph/locks.c

[PATCH v3 05/47] 9p: rename fl_type variable in v9fs_file_do_lock

2024-01-31 Thread Jeff Layton
In later patches, we're going to introduce some macros that conflict with the variable name here. Rename it. Signed-off-by: Jeff Layton --- fs/9p/vfs_file.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/9p/vfs_file.c b/fs/9p/vfs_file.c index

[PATCH v3 04/47] filelock: add some new helper functions

2024-01-31 Thread Jeff Layton
In later patches we're going to embed some common fields into a new structure inside struct file_lock. Smooth the transition by adding some new helper functions, and converting the core file locking code to use them. Signed-off-by: Jeff Layton --- fs/locks.c | 18

[PATCH v3 03/47] filelock: rename fl_pid variable in lock_get_status

2024-01-31 Thread Jeff Layton
In later patches we're going to introduce some macros that will clash with the variable name here. Rename it. Signed-off-by: Jeff Layton --- fs/locks.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/fs/locks.c b/fs/locks.c index cc7c117ee192..1eceaa56e47f 100644 ---

[PATCH v3 02/47] filelock: rename some fields in tracepoints

2024-01-31 Thread Jeff Layton
In later patches we're going to introduce some macros with names that clash with fields here. To prevent problems building, just rename the fields in the trace entry structures. Signed-off-by: Jeff Layton --- include/trace/events/filelock.h | 76 - 1 file

[PATCH v3 01/47] filelock: fl_pid field should be signed int

2024-01-31 Thread Jeff Layton
This field has been unsigned for a very long time, but most users of the struct file_lock and the file locking internals themselves treat it as a signed value. Change it to be pid_t (which is a signed int). Signed-off-by: Jeff Layton --- include/linux/filelock.h | 2 +- 1 file changed, 1

[PATCH v3 00/47] filelock: split file leases out of struct file_lock

2024-01-31 Thread Jeff Layton
I'm not sure this is much prettier than the last, but contracting "fl_core" to "c", as Neil suggested is a bit easier on the eyes. I also added a few small helpers and converted several users over to them. That reduces the size of the per-fs conversion patches later in the series. I played with

Re: [PATCH 1/3] init: Declare rodata_enabled and mark_rodata_ro() at all time

2024-01-31 Thread Luis Chamberlain
On Wed, Jan 31, 2024 at 06:53:13AM +, Christophe Leroy wrote: > The problem being identified in commit 677bfb9db8a3 ("module: Don't > ignore errors from set_memory_XX()"), you can keep/re-apply the series > [PATCH 1/3] init: Declare rodata_enabled and mark_rodata_ro() at all time. Sure,

Re: [PATCH v2 0/3] modules: few of alignment fixes

2024-01-31 Thread Luis Chamberlain
On Mon, Jan 29, 2024 at 11:26:39AM -0800, Luis Chamberlain wrote: > Masahiro, if there no issues feel free to take this or I can take them in > too via the modules-next tree. Lemme know! I've queued this onto modules-testing to get winder testing [0] [0]

[PATCH] eventfs: Create eventfs_root_inode to store dentry

2024-01-31 Thread Steven Rostedt
From: "Steven Rostedt (Google)" Only the root "events" directory stores a dentry. There's no reason to hold a dentry pointer for every eventfs_inode as it is never set except for the root "events" eventfs_inode. Create a eventfs_root_inode structure that holds the events_dir dentry. The

Re: [PATCH 1/3] init: Declare rodata_enabled and mark_rodata_ro() at all time

2024-01-31 Thread Marek Szyprowski
Hi Christophe, On 31.01.2024 21:07, Christophe Leroy wrote: > Le 31/01/2024 à 16:17, Marek Szyprowski a écrit : >> [Vous ne recevez pas souvent de courriers de m.szyprow...@samsung.com. >> Découvrez pourquoi ceci est important à >> https://aka.ms/LearnAboutSenderIdentification ] >> >> On

[PATCH] eventfs: Warn if an eventfs_inode is freed without is_freed being set

2024-01-31 Thread Steven Rostedt
From: "Steven Rostedt (Google)" There should never be a case where an evenfs_inode is being freed without is_freed being set. Add a WARN_ON_ONCE() if it ever happens. That would mean there was one too many put_ei()s. As put_ei() is also called on failure cases to free the ei, add a free_ei()

Re: [PATCH RFC 0/4] Introduce uts_release

2024-01-31 Thread Greg KH
On Wed, Jan 31, 2024 at 05:16:09PM +, John Garry wrote: > On 31/01/2024 16:22, Greg KH wrote: > > > before: > > > real0m53.591s > > > user1m1.842s > > > sys 0m9.161s > > > > > > after: > > > real0m37.481s > > > user0m46.461s > > > sys 0m7.199s > > > > > > Sending as

Re: [RFC PATCH v2 7/8] Introduce dcache_is_aliasing() across all architectures

2024-01-31 Thread Dave Chinner
On Wed, Jan 31, 2024 at 09:58:21AM -0500, Mathieu Desnoyers wrote: > On 2024-01-30 21:48, Dave Chinner wrote: > > On Tue, Jan 30, 2024 at 11:52:54AM -0500, Mathieu Desnoyers wrote: > > > Introduce a generic way to query whether the dcache is virtually aliased > > > on all architectures. Its

Re: [PATCH 1/3] init: Declare rodata_enabled and mark_rodata_ro() at all time

2024-01-31 Thread Christophe Leroy
Le 31/01/2024 à 16:17, Marek Szyprowski a écrit : > [Vous ne recevez pas souvent de courriers de m.szyprow...@samsung.com. > Découvrez pourquoi ceci est important à > https://aka.ms/LearnAboutSenderIdentification ] > > Hi Christophe, > > On 31.01.2024 12:58, Christophe Leroy wrote: >> Le

[PATCH] eventfs: Restructure eventfs_inode structure to be more condensed

2024-01-31 Thread Steven Rostedt
From: "Steven Rostedt (Google)" Some of the eventfs_inode structure has holes in it. Rework the structure to be a bit more condensed, and also remove the no longer used llist field. Link:

Re: [linus:master] [eventfs] 852e46e239: BUG:unable_to_handle_page_fault_for_address

2024-01-31 Thread Steven Rostedt
On Wed, 31 Jan 2024 11:35:18 -0800 Linus Torvalds wrote: > On Wed, 31 Jan 2024 at 07:58, Steven Rostedt wrote: > > > > BTW, I ran my full test suite on your patches with the below updates and it > > all passed. > > Those patch updates all look sane to me. > > > I can break up and clean up

Re: [linus:master] [eventfs] 852e46e239: BUG:unable_to_handle_page_fault_for_address

2024-01-31 Thread Linus Torvalds
On Wed, 31 Jan 2024 at 07:58, Steven Rostedt wrote: > > BTW, I ran my full test suite on your patches with the below updates and it > all passed. Those patch updates all look sane to me. > I can break up and clean up the patches so that they are bisectable, and if > that passes the bisectable

Re: [PATCH RFC 2/4] tracing: Use uts_release

2024-01-31 Thread Steven Rostedt
On Wed, 31 Jan 2024 10:48:49 + John Garry wrote: > Instead of using UTS_RELEASE, use uts_release, which means that we don't > need to rebuild the code just for the git head commit changing. > > Signed-off-by: John Garry Acked-by: Steven Rostedt (Google) -- Steve > --- >

Re: [PATCH RFC 3/4] net: ethtool: Use uts_release

2024-01-31 Thread Jakub Kicinski
On Wed, 31 Jan 2024 10:48:50 + John Garry wrote: > Instead of using UTS_RELEASE, use uts_release, which means that we don't > need to rebuild the code just for the git head commit changing. > > Signed-off-by: John Garry Yes, please! Acked-by: Jakub Kicinski

Re: [PATCH v2 0/7] eventfs: Rewrite to simplify the code (aka: crapectomy)

2024-01-31 Thread Steven Rostedt
On Wed, 31 Jan 2024 13:49:18 -0500 Steven Rostedt wrote: > I would like to have this entire series go all the way back to 6.6 (after it > is accepted in mainline of course) and replace everything since the creation > of the eventfs code. That is, stable releases may need to add all the >

[PATCH v1] module.h: define __symbol_get_gpl() as a regular __symbol_get()

2024-01-31 Thread Andrew Kanner
Prototype for __symbol_get_gpl() was introduced in the initial git commit 1da177e4c3f4 ("Linux-2.6.12-rc2"), but was not used after that. In commit 9011e49d54dc ("modules: only allow symbol_get of EXPORT_SYMBOL_GPL modules") Christoph Hellwig switched __symbol_get() to process GPL symbols only,

[PATCH v2 7/7] eventfs: Get rid of dentry pointers without refcounts

2024-01-31 Thread Steven Rostedt
From: Linus Torvalds The eventfs inode had pointers to dentries (and child dentries) without actually holding a refcount on said pointer. That is fundamentally broken, and while eventfs tried to then maintain coherence with dentries going away by hooking into the '.d_iput' callback, that

[PATCH v2 5/7] eventfs: Remove unused d_parent pointer field

2024-01-31 Thread Steven Rostedt
From: Linus Torvalds It's never used Link: https://lore.kernel.org/linux-trace-kernel/202401291043.e62e89dc-oliver.s...@intel.com/ Cc: sta...@vger.kernel.org Fixes: c1504e510238 ("eventfs: Implement eventfs dir creation functions") Signed-off-by: Linus Torvalds Signed-off-by: Steven Rostedt

[PATCH v2 4/7] tracefs: dentry lookup crapectomy

2024-01-31 Thread Steven Rostedt
From: Linus Torvalds The dentry lookup for eventfs files was very broken, and had lots of signs of the old situation where the filesystem names were all created statically in the dentry tree, rather than being looked up dynamically based on the eventfs data structures. You could see it in the

[PATCH v2 6/7] eventfs: Clean up dentry ops and add revalidate function

2024-01-31 Thread Steven Rostedt
From: Linus Torvalds In order for the dentries to stay up-to-date with the eventfs changes, just add a 'd_revalidate' function that checks the 'is_freed' bit. Also, clean up the dentry release to actually use d_release() rather than the slightly odd d_iput() function. We don't care about the

[PATCH v2 3/7] tracefs: Avoid using the ei->dentry pointer unnecessarily

2024-01-31 Thread Steven Rostedt
From: Linus Torvalds The eventfs_find_events() code tries to walk up the tree to find the event directory that a dentry belongs to, in order to then find the eventfs inode that is associated with that event directory. However, it uses an odd combination of walking the dentry parent, looking up

[PATCH v2 2/7] eventfs: Initialize the tracefs inode properly

2024-01-31 Thread Steven Rostedt
From: Linus Torvalds The tracefs-specific fields in the inode were not initialized before the inode was exposed to others through the dentry with 'd_instantiate()'. Move the field initializations up to before the d_instantiate. Cc: sta...@vger.kernel.org Fixes: 5790b1fb3d672 ("eventfs: Remove

[PATCH v2 0/7] eventfs: Rewrite to simplify the code (aka: crapectomy)

2024-01-31 Thread Steven Rostedt
Linus took the time to massively clean up the eventfs logic. I took his code and made tweaks to represent some of the feedback from Al Viro and also fix issues that came up in testing. The diff between v1 and this can be found here:

[PATCH v2 1/7] tracefs: Zero out the tracefs_inode when allocating it

2024-01-31 Thread Steven Rostedt
From: "Steven Rostedt (Google)" eventfs uses the tracefs_inode and assumes that it's already initialized to zero. That is, it doesn't set fields to zero (like ti->private) after getting its tracefs_inode. This causes bugs due to stale values. Just initialize the entire structure to zero on

Re: [PATCH v2 4/4] remoteproc: stm32: Add support of an OP-TEE TA to load the firmware

2024-01-31 Thread Mathieu Poirier
On Tue, Jan 30, 2024 at 10:13:48AM +0100, Arnaud POULIQUEN wrote: > > > On 1/26/24 18:11, Mathieu Poirier wrote: > > On Thu, Jan 18, 2024 at 11:04:33AM +0100, Arnaud Pouliquen wrote: > >> The new TEE remoteproc device is used to manage remote firmware in a > >> secure, trusted context. The

Re: [PATCH 5/6] eventfs: get rid of dentry pointers without refcounts

2024-01-31 Thread Steven Rostedt
On Wed, 31 Jan 2024 10:08:37 -0800 Linus Torvalds wrote: > On Wed, 31 Jan 2024 at 05:14, Steven Rostedt wrote: > > > > If you also notice, tracefs only allows mkdir/rmdir to be assigned to > > one directory. Once it is assigned, no other directories can have mkdir > > rmdir functionality. >

Re: [ANNOUNCE] 5.10.204-rt100

2024-01-31 Thread Pavel Machek
Hi! > > We (as in cip project), are trying to do -cip-rt releases > > once a month. Are there any plans for 5.10-rt release any time soon? > > That would help us ;-). > > I already pushed v5.10-rt-next (containing v5.10.209-rt101-rc1) to > kernel.org and kernelci should pick that up for

  1   2   >