Re: [PATCH v2 02/16] fpga: bridge: support getting bridge from device

2017-05-08 Thread Alan Tull
On Mon, May 8, 2017 at 4:11 PM, Moritz Fischer <m...@kernel.org> wrote: > Hi Alan, > > On Mon, May 8, 2017 at 2:02 PM, Alan Tull <at...@kernel.org> wrote: >> On Mon, May 8, 2017 at 3:52 PM, Moritz Fischer <m...@kernel.org> wrote: >>> On Mon, May 8, 20

Re: [PATCH v2 02/16] fpga: bridge: support getting bridge from device

2017-05-04 Thread Alan Tull
On Wed, May 3, 2017 at 3:07 PM, Alan Tull <at...@kernel.org> wrote: > On Wed, May 3, 2017 at 6:58 AM, Wu Hao <hao...@intel.com> wrote: >> On Thu, Apr 20, 2017 at 09:09:47AM -0500, Alan Tull wrote: >>> Add two functions for getting the FPGA bridge from the device &g

[PATCH 06/10] fpga manager: Add altera-ps-spi driver for Altera FPGAs

2017-06-05 Thread Alan Tull
idirectional SPI with lsb first. Signed-off-by: Joshua Clayton <stillcompil...@gmail.com> Signed-off-by: Anatolij Gustschin <ag...@denx.de> Signed-off-by: Alan Tull <at...@kernel.org> --- drivers/fpga/Kconfig | 7 + drivers/fpga/Makefile| 1 +

[PATCH 05/10] doc: dt: document altera-passive-serial binding

2017-06-05 Thread Alan Tull
From: Joshua Clayton <stillcompil...@gmail.com> Describe an altera-passive-serial devicetree entry, required features Signed-off-by: Joshua Clayton <stillcompil...@gmail.com> Acked-by: Rob Herring <r...@kernel.org> Signed-off-by: Alan Tull <at...@kernel.org> --- .../bind

[PATCH 01/10] dt-bindings: fpga: Add bindings document for Xilinx LogiCore PR Decoupler

2017-06-05 Thread Alan Tull
com> Cc: linux-kernel@vger.kernel.org Cc: devicet...@vger.kernel.org Acked-by: Rob Herring <r...@kernel.org> Signed off-by: Alan Tull <at...@kernel.org> --- .../bindings/fpga/xilinx-pr-decoupler.txt | 36 ++ 1 file changed, 36 insertions(+) create mode 10064

[PATCH 02/10] Make FPGA a menuconfig to ease disabling it all

2017-06-05 Thread Alan Tull
From: Vincent Legoll <vincent.leg...@gmail.com> No need to get into the submenu to disable all FPGA-related config entries Signed-off-by: Vincent Legoll <vincent.leg...@gmail.com> Acked-by: Moritz Fischer <m...@kernel.org> Signed-off-by: Alan Tull <at...@kernel.org> ---

[PATCH 03/10] fpga: allow to compile-test Altera FPGA bridge drivers

2017-06-05 Thread Alan Tull
rivers on other architectures to catch compiler errors/warnings, e.g. due to API/header changes earlier on. Signed-off-by: Tobias Klauser <tklau...@distanz.ch> Signed-off-by: Alan Tull <at...@kernel.org> --- drivers/fpga/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) di

[PATCH 00/10] patches for fpga

2017-06-05 Thread Alan Tull
Hi Greg, Please take these patches for FPGA that have been reviewed on the mailing lists. Thanks, Alan Anatolij Gustschin (1): fpga: Add flag to indicate SPI bitstream is bit-reversed Joel Holdsworth (1): of: Add vendor prefix for Lattice Semiconductor Joshua Clayton (5): doc: dt:

[PATCH 04/10] fpga: Add flag to indicate SPI bitstream is bit-reversed

2017-06-05 Thread Alan Tull
atolij Gustschin <ag...@denx.de> Signed-off-by: Joshua Clayton <stillcompil...@gmail.com> Signed-off-by: Alan Tull <at...@kernel.org> --- include/linux/fpga/fpga-mgr.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux/fpga/fpga-mgr.h b/include/linux/fpga/fpga-

[PATCH 07/10] ARM: dts: imx6q-evi: support altera-ps-spi

2017-06-05 Thread Alan Tull
From: Joshua Clayton <stillcompil...@gmail.com> Add support for Altera FPGA connected to an spi port to the evi devicetree file Signed-off-by: Joshua Clayton <stillcompil...@gmail.com> Signed-off-by: Alan Tull <at...@kernel.org> --- arch/arm/boot/dts/imx6q-evi.dts | 16 ++

[PATCH 10/10] of: Add vendor prefix for Lattice Semiconductor

2017-06-05 Thread Alan Tull
: Joel Holdsworth <j...@airwebreathe.org.uk> Acked-by: Rob Herring <r...@kernel.org> Acked-by: Moritz Fischer <moritz.fisc...@ettus.com> Signed-off-by: Alan Tull <at...@kernel.org> --- Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + 1 file changed, 1 insertion(+) diff --

[PATCH 08/10] lib: add bitrev8x4()

2017-06-05 Thread Alan Tull
From: Joshua Clayton <stillcompil...@gmail.com> Add a function to reverse bytes within a 32 bit word. Operate on a u32 rather than individual bytes. Signed-off-by: Joshua Clayton <stillcompil...@gmail.com> Signed-off-by: Alan Tull <at...@kernel.org> --- include/l

[PATCH 09/10] fpga-manager: altera-ps-spi: use bitrev8x4

2017-06-05 Thread Alan Tull
From: Joshua Clayton <stillcompil...@gmail.com> Speed up bit reversal by using hardware bit reversal Add extra code to handle less than 4byte remnants, if any Signed-off-by: Joshua Clayton <stillcompil...@gmail.com> Signed-off-by: Alan Tull <at...@kernel.org> --- drivers/fp

Re: [PATCH v4 01/18] fpga: bridge: support getting bridge from device

2017-09-18 Thread Alan Tull
On Mon, Sep 18, 2017 at 12:59 PM, Moritz Fischer <m...@kernel.org> wrote: > On Wed, Sep 13, 2017 at 03:48:24PM -0500, Alan Tull wrote: >> Add two functions for getting the FPGA bridge from the device >> rather than device tree node. This is to enable writing code >> t

Re: [PATCH v4 04/18] fpga: region: use dev_err instead of pr_err

2017-09-18 Thread Alan Tull
On Mon, Sep 18, 2017 at 1:17 PM, Moritz Fischer <m...@kernel.org> wrote: > On Wed, Sep 13, 2017 at 03:48:27PM -0500, Alan Tull wrote: >> Use dev_err messages instead of pr_err. >> >> Also s/>dev/dev/ in two places where we already >> have dev =

Re: [PATCH 2/2] driver core: remove DRIVER_ATTR

2017-09-18 Thread Alan Tull
TR_WO() instead in >> order to always get the permissions correct. So remove it so that no >> one can use it anymore. >> >> Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> > Reviewed-by: Moritz Fischer <m...@kernel.org> Acked-by: Alan Tull <a

[PATCH] MAINTAINERS: add backup maintainer

2017-09-19 Thread Alan Tull
Add Moritz as a maintainer of the kernel FPGA framework. Signed-off-by: Alan Tull <at...@kernel.org> --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index b87c6989e82d..2d3d855ee6e4 100644 --- a/MAINTAINERS +++ b/MAINT

Re: [PATCH] MAINTAINERS: add backup maintainer

2017-09-19 Thread Alan Tull
On Tue, Sep 19, 2017 at 6:24 PM, Alan Tull <at...@kernel.org> wrote: > Add Moritz as a maintainer of the kernel FGPGA framework. Argh! I fixed this and then didn't do 'git format-patch' to regenerate the patch! Resending... Alan > > Signed-off-by: Alan Tull &l

[PATCH] MAINTAINERS: add backup maintainer

2017-09-19 Thread Alan Tull
Add Moritz as a maintainer of the kernel FGPGA framework. Signed-off-by: Alan Tull <at...@kernel.org> --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index b87c6989e82d..2d3d855ee6e4 100644 --- a/MAINTAINERS +++ b/MAINT

Re: [PATCH v2 03/22] fpga: bridge: remove OF dependency for fpga-bridge

2017-09-22 Thread Alan Tull
On Thu, Sep 21, 2017 at 9:15 PM, Wu Hao <hao...@intel.com> wrote: > On Thu, Sep 21, 2017 at 02:50:07PM -0500, Alan Tull wrote: >> On Thu, Sep 21, 2017 at 2:11 PM, Moritz Fischer <m...@kernel.org> wrote: >> >> Hi Moritz, >> >> > Hi, >> > &g

Re: [PATCH v2 07/22] fpga: intel: pcie: parse feature list and create platform device for features.

2017-09-20 Thread Alan Tull
gned-off-by: Xiao Guangrong <guangrong.x...@linux.intel.com> > Signed-off-by: Wu Hao <hao...@intel.com> > --- > v2: moved the code to drivers/fpga folder as suggested by Alan Tull. > switched to GPLv2 license. > fixed comments from Moritz Fischer. > fixed kbuil

Re: [PATCH] fpga: make xlnx_pr_decoupler_br_ops const

2017-09-21 Thread Alan Tull
ga_bridge_ops xlnx_pr_decoupler_br_ops = { >>> .enable_set = xlnx_pr_decoupler_enable_set, >>> .enable_show = xlnx_pr_decoupler_enable_show, >>> }; > > Must've been a leftover from when I worked on integrating a simple > GPIO based one. > I'll have to

[PATCH 1/1] fpga: make xlnx_pr_decoupler_br_ops const

2017-09-21 Thread Alan Tull
ernel.org> Signed-off-by: Alan Tull <at...@kernel.org> --- drivers/fpga/xilinx-pr-decoupler.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/fpga/xilinx-pr-decoupler.c b/drivers/fpga/xilinx-pr-decoupler.c index e359930bebc8..0d7743089414 100644 --- a/drivers/fp

[PATCH 0/1] patch for fpga

2017-09-21 Thread Alan Tull
Hi Greg, Please take this one small fix for fpga. Thanks! Alan Bhumika Goyal (1): fpga: make xlnx_pr_decoupler_br_ops const drivers/fpga/xilinx-pr-decoupler.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.11.0

[PATCH v4 11/18] fpga: region: add fpga-region.h header

2017-09-13 Thread Alan Tull
* Create fpga-region.h. * Export fpga_region_program_fpga. * Move struct fpga_region and other things to the header. This is a step in separating FPGA region common code from Device Tree support. Signed-off-by: Alan Tull <at...@kernel.org> --- v2: split out from another patch update

[PATCH v4 12/18] fpga: region: rename some functions prior to moving

2017-09-13 Thread Alan Tull
ion. * of_fpga_region_get_bridges change second parameter to FPGA image info. Export of_fpga_region_find as well. Signed-off-by: Alan Tull <at...@kernel.org> --- v2: split out from another patch v3: no changes in patch for this version of patchset v4: no change to this patch in this version of patchset ---

[PATCH v4 02/18] fpga: mgr: API change to replace fpga load functions with single function

2017-09-13 Thread Alan Tull
. API documentation has been updated and a new document for FPGA region has been added. Signed-off-by: Alan Tull <at...@kernel.org> --- v2: add fpga_image_info_alloc/free update copyright and author email v3: fix bisectibility v4: fix return value of fpga_image_info_alloc() save

[PATCH v4 06/18] fpga: region: get mgr early on

2017-09-13 Thread Alan Tull
Get the FPGA manager during region creation. This is a baby step in refactoring the FPGA region code to separate out common FPGA region code from FPGA region Device Tree overlay support. Signed-off-by: Alan Tull <at...@kernel.org> --- v2: split out from another patch v3: no change to this

[PATCH v4 08/18] fpga: region: fix slow warning with more than one overlay

2017-09-13 Thread Alan Tull
ote that overlays that make DT changes without reprogramming the FPGA are exempt from this restriction. Signed-off-by: Alan Tull <at...@kernel.org> --- v2: split out from another patch v3: better explanation in header v4: no change to this patch in this version of patchset --- drivers/fpga/fpga-reg

[PATCH v4 03/18] fpga: mgr: separate getting/locking FPGA manager

2017-09-13 Thread Alan Tull
: * fpga_mgr_lock * fpga_mgr_unlock The following functions no longer lock an FPGA manager's mutex: * of_fpga_mgr_get * fpga_mgr_get * fpga_mgr_put Signed-off-by: Alan Tull <at...@kernel.org> --- v2: add static for __fpga_mgr_get function documentation corrections use dev_err v3: bisecti

[PATCH v4 07/18] fpga: region: check for child regions before allocing image info

2017-09-13 Thread Alan Tull
FPGA region Device Tree overlay support. Signed-off-by: Alan Tull <at...@kernel.org> Acked-by: Moritz Fischer <m...@kernel.org> --- v2: split out from another patch v3: s/dev/>dev/ in one place add Moritz' ack v4: no change to this patch in this version of patchset --- drivers/fpg

[PATCH v4 05/18] fpga: region: remove unneeded of_node_get and put

2017-09-13 Thread Alan Tull
Remove of_node_get/put in fpga_region_get/put. Not needed and will get in the way when I separate out the common FPGA region code from Device Tree support code. Signed-off-by: Alan Tull <at...@kernel.org> Acked-by: Moritz Fischer <m...@kernel.org> --- v2: split out from another p

[PATCH v4 09/18] fpga: region: use image info as parameter for programming region

2017-09-13 Thread Alan Tull
Use FPGA image info (region->info) when region code is programming the FPGA to pass in multiple parameters. This is a baby step in refactoring the FPGA region code to separate out common FPGA region code from FPGA region Device Tree overlay support. Signed-off-by: Alan Tull <at...@kern

[PATCH v4 00/18] Enable upper layers using FPGA region w/o device tree

2017-09-13 Thread Alan Tull
-v4 for reviewing convenience. Alan Tull (18): fpga: bridge: support getting bridge from device fpga: mgr: API change to replace fpga load functions with single function fpga: mgr: separate getting/locking FPGA manager fpga: region: use dev_err instead of pr_err fpga: region: remove

[PATCH v4 04/18] fpga: region: use dev_err instead of pr_err

2017-09-13 Thread Alan Tull
Use dev_err messages instead of pr_err. Also s/>dev/dev/ in two places where we already have dev = >dev. Signed-off-by: Alan Tull <at...@kernel.org> --- v2: new in this version of the patchset v3: for bisectability some changes moved to earlier patches v4: no change to this patch in

[PATCH v4 10/18] fpga: region: separate out code that parses the overlay

2017-09-13 Thread Alan Tull
Tree overlay support. Signed-off-by: Alan Tull <at...@kernel.org> --- v2: split out from another patch v3: update comments minor changes in flow v4: no change to this patch in this version of patchset --- drivers/fpga/fpga-region.c | 122 +++--

[PATCH v4 01/18] fpga: bridge: support getting bridge from device

2017-09-13 Thread Alan Tull
. Signed-off-by: Alan Tull <at...@kernel.org> --- v2: use list_for_each_entry static the bridge_list_lock update copyright and author email v3: no change to this patch in this version of patchset v4: no change to this patch in this version of patchset --- drivers/fpga/fpga-br

[PATCH v4 15/18] fpga: region: move device tree support to of-fpga-region.c

2017-09-13 Thread Alan Tull
* of_fpga_region_notify_post_remove * of_fpga_region_notify * of_fpga_region_probe * of_fpga_region_remove Create two new function with some code from fpga_region_init/exit. * of_fpga_region_init * of_fpga_region_exit Signed-off-by: Alan Tull <at...@kernel.org> --- v2: split out code changes into other patches, only mov

[PATCH v4 14/18] fpga: region: add fpga_region_class_find

2017-09-13 Thread Alan Tull
Add a function for searching the fpga-region class. This will be useful when device tree code is no longer in the same file that declares the fpga-region class. Another step in separating common FPGA region code from device tree support. Signed-off-by: Alan Tull <at...@kernel.org>

[PATCH v4 13/18] fpga: region: add register/unregister functions

2017-09-13 Thread Alan Tull
to the region struct * use region->info in of_fpga_region_get_bridges Signed-off-by: Alan Tull <at...@kernel.org> --- v2: split out from another patch v3: use region->info, remove info param where applicable v4: no change to this patch in this version of patchset --- drivers/fpga/f

[PATCH v4 17/18] fpga: clean up fpga Kconfig

2017-09-13 Thread Alan Tull
<*> Technologic Systems TS-73xx SBC FPGA Manager <*> FPGA Bridge Framework <*> Altera SoCFPGA FPGA Bridges <*> Altera FPGA Freeze Bridge <*> Xilinx LogiCORE PR Decoupler <*> FPGA Region <*> FPGA Reg

[PATCH v4 18/18] fpga: add attribute groups

2017-09-13 Thread Alan Tull
-off-by: Alan Tull <at...@kernel.org> --- v4: Patch added to patchset in v4 --- drivers/fpga/fpga-bridge.c | 1 + drivers/fpga/fpga-mgr.c | 1 + drivers/fpga/fpga-region.c | 1 + include/linux/fpga/fpga-bridge.h | 2 ++ include/linux/fpga/fpga-mgr.h| 2 ++ include/linu

[PATCH v4 16/18] fpga: of-fpga-region: accept overlays that don't program FPGA

2017-09-13 Thread Alan Tull
The FPGA may already have a static image programmed when Linux boots. In that case a DT overlay may be used to add the devices that already exist. This commit allows that by shuffling the order of some checks. Signed-off-by: Alan Tull <at...@kernel.org> --- v4: Patch added to patchset

Re: [PATCH v4 13/18] fpga: region: add register/unregister functions

2017-09-14 Thread Alan Tull
On Thu, Sep 14, 2017 at 4:56 AM, Wu Hao <hao...@intel.com> wrote: > On Thu, Sep 14, 2017 at 04:48:36AM +0800, Alan Tull wrote: >> Another step in separating common code from device tree specific >> code for FPGA regions. >> >> * add FPGA region register/unregister

Re: [PATCH v4 17/18] fpga: clean up fpga Kconfig

2017-09-14 Thread Alan Tull
On Thu, Sep 14, 2017 at 10:56 AM, <matthew.gerl...@linux.intel.com> wrote: Hi Matthew, > > Hi Alan, > > s/mixxed/mixed/ > OK, I'll fix that. Alan > On Wed, 13 Sep 2017, Alan Tull wrote: > >> The fpga menuconfig has gotten messy. The bridges an

Re: [PATCH v4 15/18] fpga: region: move device tree support to of-fpga-region.c

2017-09-14 Thread Alan Tull
On Thu, Sep 14, 2017 at 10:50 AM, <matthew.gerl...@linux.intel.com> wrote: Hi Matthew, Thanks for the review! > > Hi Alan, > > Just a couple of minor nits. > > Matthew Gerlach > > On Wed, 13 Sep 2017, Alan Tull wrote: > >> Create of-fpga-region.c and ove

Re: [PATCH v4 01/18] fpga: bridge: support getting bridge from device

2017-09-14 Thread Alan Tull
On Wed, Sep 13, 2017 at 6:38 PM, <matthew.gerl...@linux.intel.com> wrote: Hi Matthew, > > Hi Alan, > > Two minor nits below. > > Matthew Gerlach > > On Wed, 13 Sep 2017, Alan Tull wrote: > >> Add two functions for getting the FPGA bridge from the

Re: [PATCH v4 11/18] fpga: region: add fpga-region.h header

2017-09-14 Thread Alan Tull
On Thu, Sep 14, 2017 at 4:50 AM, Wu Hao <hao...@intel.com> wrote: Hi Hao, > On Thu, Sep 14, 2017 at 04:48:34AM +0800, Alan Tull wrote: >> * Create fpga-region.h. >> * Export fpga_region_program_fpga. >> * Move struct fpga_region and other things to the header. >>

Re: [PATCH v2 03/22] fpga: bridge: remove OF dependency for fpga-bridge

2017-09-21 Thread Alan Tull
On Thu, Sep 21, 2017 at 2:11 PM, Moritz Fischer wrote: Hi Moritz, > Hi, > > On Mon, Jun 26, 2017 at 09:51:59AM +0800, Wu Hao wrote: >> This patch removes OF dependency of fpga-bridge, it allows drivers >> to use fpga-bridge class without device tree support. >> >>

Re: [PATCH v2 07/22] fpga: intel: pcie: parse feature list and create platform device for features.

2017-09-21 Thread Alan Tull
)On Wed, Sep 20, 2017 at 4:24 PM, Alan Tull <at...@kernel.org> wrote: Hi Hao, A few more minor things below. > a (wh., *()On Sun, Jun 25, 2017 at 8:52 PM, Wu Hao <hao...@intel.com> wrote: > > Hi Hao, > > I'm done with some board bringup so I have time to loo

Re: [PATCH v4 01/18] fpga: bridge: support getting bridge from device

2017-09-19 Thread Alan Tull
On Thu, Sep 14, 2017 at 5:54 PM, Moritz Fischer <m...@kernel.org> wrote: > On Thu, Sep 14, 2017 at 03:29:09PM -0700, matthew.gerl...@linux.intel.com > wrote: >> >> >> On Thu, 14 Sep 2017, Alan Tull wrote: >> >> > On Wed, Sep 13, 2017 at 6:38

Re: [PATCH v4 01/18] fpga: bridge: support getting bridge from device

2017-09-19 Thread Alan Tull
On Mon, Sep 18, 2017 at 5:53 PM, Moritz Fischer <m...@kernel.org> wrote: Hi Moritz, > On Wed, Sep 13, 2017 at 03:48:24PM -0500, Alan Tull wrote: >> Add two functions for getting the FPGA bridge from the device >> rather than device tree node. This is to enable writing code

Re: [PATCH 1/2] fpga: altera-cvp: remove DRIVER_ATTR() usage

2017-09-18 Thread Alan Tull
This is part of a series to drop DRIVER_ATTR() from the tree entirely. >> >> Cc: Alan Tull <at...@kernel.org> >> Cc: Moritz Fischer <m...@kernel.org> >> Cc: linux-f...@vger.kernel.org >> Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> &

Re: [PATCH 2/2] hwmon: add dt binding for max1619

2017-09-19 Thread Alan Tull
On Mon, Sep 18, 2017 at 4:11 PM, Rob Herring <r...@kernel.org> wrote: > On Mon, Sep 11, 2017 at 12:58:57PM -0700, Guenter Roeck wrote: >> On Mon, Sep 11, 2017 at 02:16:49PM -0500, Alan Tull wrote: >> > Add new device tree binding for max1619. >> > >> >

[PATCH] gpio: gpio-dwapb: add optional reset

2017-10-10 Thread Alan Tull
Some platforms require reset to be released to allow register access. Signed-off-by: Alan Tull <at...@kernel.org> --- drivers/gpio/gpio-dwapb.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/gpio/gpio-dwapb.c b/drivers/gpio/gpio-dwapb.c index 5cdb7bc..f7ac625

[PATCH 2/2] arm64: dts: stratix10: enable gpio and leds

2017-10-10 Thread Alan Tull
Enable gpio and leds for socdk OOBE daughtercard. pushbutton PB_SW0 = gpio1.io4 pushbutton PB_SW1 = gpio1.io5 LED HPS_LED0 = gpio1.io20 LED HPS_LED1 = gpio1.io19 LED HPS_LED2 = gpio1.io21 Signed-off-by: Alan Tull <at...@kernel.org> --- .../boot/dts/

[PATCH 1/2] arm64: dts: stratix10: add gpio header

2017-10-10 Thread Alan Tull
Add the gpio header to the base stratix10 dtsi. Signed-off-by: Alan Tull <at...@kernel.org> --- arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi b/arch/arm64/boot/dts/altera/socfpga_str

Re: [PATCH] gpio: gpio-dwapb: add optional reset

2017-10-12 Thread Alan Tull
On Thu, Oct 12, 2017 at 3:26 AM, Linus Walleij <linus.wall...@linaro.org> wrote: Hi Linus, Phillipp, > This v2 version applied with Philipp's review tag, I also added > a blurb to the DT binding as Philipp asked so no need to fix that > separately. > > Yours, > Linus Walleij Thanks! Alan Tull

[PATCH 1/2] dt-bindings: hwmon: add compatible for max1619

2017-09-11 Thread Alan Tull
Add new device tree bindings document for max1619 device including a new compatible string. Signed-off-by: Alan Tull <at...@kernel.org> Cc: Jean Delvare <jdelv...@suse.com> Cc: Guenter Roeck <li...@roeck-us.net> Cc: Rob Herring <robh...@kernel.org> Cc: Mark Rutla

[PATCH 2/2] hwmon: add dt binding for max1619

2017-09-11 Thread Alan Tull
Add new device tree binding for max1619. Signed-off-by: Alan Tull <at...@kernel.org> Cc: Jean Delvare <jdelv...@suse.com> Cc: Guenter Roeck <li...@roeck-us.net> Cc: Rob Herring <robh...@kernel.org> Cc: Mark Rutland <mark.rutl...@arm.com> --- drivers/hwmon/max

Re: [PATCH 2/2] hwmon: add dt binding for max1619

2017-09-11 Thread Alan Tull
On Mon, Sep 11, 2017 at 2:16 PM, Alan Tull <at...@kernel.org> wrote: Add Oleksij Rempel <bug-tr...@fisher-privat.net> > Add new device tree binding for max1619. > > Signed-off-by: Alan Tull <at...@kernel.org> > Cc: Jean Delvare <jdelv...@suse.com> > Cc:

Re: [PATCH 1/2] dt-bindings: hwmon: add compatible for max1619

2017-09-11 Thread Alan Tull
On Mon, Sep 11, 2017 at 2:16 PM, Alan Tull <at...@kernel.org> wrote: Add Oleksij Rempel > Add new device tree bindings document for max1619 device > including a new compatible string. > > Signed-off-by: Alan Tull <at...@kernel.org> > Cc: Jean Delvare <jdelv...@sus

Re: [PATCH 2/2] hwmon: add dt binding for max1619

2017-09-11 Thread Alan Tull
On Mon, Sep 11, 2017 at 2:58 PM, Guenter Roeck <li...@roeck-us.net> wrote: > On Mon, Sep 11, 2017 at 02:16:49PM -0500, Alan Tull wrote: >> Add new device tree binding for max1619. >> >> Signed-off-by: Alan Tull <at...@kernel.org> > > Technically that should

Re: [PATCH 1/2] dt-bindings: hwmon: add compatible for max1619

2017-09-11 Thread Alan Tull
On Mon, Sep 11, 2017 at 2:33 PM, Alan Tull <at...@kernel.org> wrote: Forget this - Guenter has pointed out that this patch is not needed, as the i2c layer handles this without needing the compatible added. Alan > On Mon, Sep 11, 2017 at 2:16 PM, Alan Tull <at...@kernel.org>

Re: [PATCH 2/2] hwmon: add dt binding for max1619

2017-09-28 Thread Alan Tull
On Tue, Sep 19, 2017 at 2:35 PM, Rob Herring <r...@kernel.org> wrote: > On Tue, Sep 19, 2017 at 1:11 PM, Alan Tull <at...@kernel.org> wrote: >> On Mon, Sep 18, 2017 at 4:11 PM, Rob Herring <r...@kernel.org> wrote: >>> On Mon, Sep 11, 2017 at 12:58:57PM -0700, G

Re: [PATCH v2 07/22] fpga: intel: pcie: parse feature list and create platform device for features.

2017-09-27 Thread Alan Tull
On Fri, Sep 22, 2017 at 2:28 AM, Wu Hao <hao...@intel.com> wrote: > On Wed, Sep 20, 2017 at 04:24:10PM -0500, Alan Tull wrote: HI Hao, >> a (wh., *()On Sun, Jun 25, 2017 at 8:52 PM, Wu Hao <hao...@intel.com> wrote: >> >> Hi Hao, >> >> I'm done w

Re: [PATCH 1/1] fpga: region: release bridges in successful path

2017-09-27 Thread Alan Tull
On Wed, Sep 27, 2017 at 11:43 AM, Vyacheslav V. Yurkov wrote: Hi Vyacheslav, Thanks for the patch, but actually this is on purpose to prevent someone disabling the bridges when a region has hardware running in it. The fpga_bridges_put happens when the device tree overlay is

Re: [PATCH v2 15/22] fpga: intel: add fpga manager platform driver for FME

2017-09-27 Thread Alan Tull
On Tue, Sep 26, 2017 at 8:18 PM, Wu Hao wrote: Hi Hao, > On Mon, Sep 25, 2017 at 02:24:57PM -0700, Moritz Fischer wrote: >> Hi Hao, > > Hi Moritz > > Thanks for your review. :) > >> >> On Mon, Jun 26, 2017 at 09:52:11AM +0800, Wu Hao wrote: >> > This patch adds fpga manager

Re: [2/2] hwmon: add dt binding for max1619

2017-10-02 Thread Alan Tull
On Sun, Oct 1, 2017 at 9:13 AM, Guenter Roeck <li...@roeck-us.net> wrote: > On Mon, Sep 11, 2017 at 02:16:49PM -0500, Alan Tull wrote: >> Add new device tree binding for max1619. >> >> Signed-off-by: Alan Tull <at...@kernel.org> >> Cc: Jean Delvare <j

Re: [PATCH 2/2] fpga: altera-cvp: register attribute groups using ops

2017-08-23 Thread Alan Tull
On Tue, Aug 22, 2017 at 3:23 PM, Alan Tull <at...@kernel.org> wrote: > On Tue, Aug 22, 2017 at 10:53 AM, Alan Tull <at...@kernel.org> wrote: On second thought, this patch is probably not really helpful as it changes the path of the existing sysfs file from /sys/bus/pci/drivers/al

Re: [PATCH v13 3/6] fpga manager: Add altera-ps-spi driver for Altera FPGAs

2017-08-23 Thread Alan Tull
On Wed, Aug 23, 2017 at 8:54 AM, Bastian Stender wrote: > On 06/10/2017 12:39 AM, Joshua Clayton wrote: >> >> altera-ps-spi loads FPGA firmware over SPI, using the "passive serial" >> interface on Altera Arria 10, Cyclone V or Stratix V FPGAs. >> >> This is one of the simpler

Re: [PATCH v2 16/22] fpga: intel: add fpga bridge platform driver for FME

2017-08-17 Thread Alan Tull
igned-off-by: Enno Luebbers <enno.luebb...@intel.com> > Signed-off-by: Shiva Rao <shiva@intel.com> > Signed-off-by: Christopher Rauer <christopher.ra...@intel.com> > Signed-off-by: Wu Hao <hao...@intel.com> Acked-by: Alan Tull <at...@kernel.org> > --- &

Re: [PATCH v3 01/16] doc: fpga: update documents for the FPGA API

2017-08-17 Thread Alan Tull
e maintainers), so I could do that. I hope to post the next version in a couple weeks. Alan > > On Thu, Jul 6, 2017 at 11:47 AM, Alan Tull <at...@kernel.org> wrote: >> The FPGA manager has been simplified to have a single >> fpga_mgr_load function which repla

Re: [PATCH] gpio: gpio-dwapb: add optional reset

2017-10-11 Thread Alan Tull
On Wed, Oct 11, 2017 at 5:56 AM, Philipp Zabel <p.za...@pengutronix.de> wrote: Hi Linus, Phillipp, Thanks for the review. > Hi Alan, Linus, > > On Wed, 2017-10-11 at 10:31 +0200, Linus Walleij wrote: >> On Tue, Oct 10, 2017 at 11:26 PM, Alan Tull <at...@kernel.org> wr

[PATCH] gpio: gpio-dwapb: add optional reset

2017-10-11 Thread Alan Tull
Some platforms require reset to be released to allow register access. Signed-off-by: Alan Tull <at...@kernel.org> --- v2: Request shared controller return all errors from reset controller request drop conditions on asserting/deasserting reset --- drivers/gpio/gpio-dwapb

Re: [PATCH] gpio: gpio-dwapb: add optional reset

2017-10-11 Thread Alan Tull
On Wed, Oct 11, 2017 at 11:34 AM, Alan Tull <at...@kernel.org> wrote: Sorry, I forgot to specify PATCH v2 in the subject. Alan > Some platforms require reset to be released to allow register > access. > > Signed-off-by: Alan Tull <at...@kernel.org> > --- >

[PATCH v5 16/18] fpga: of-fpga-region: accept overlays that don't program FPGA

2017-10-17 Thread Alan Tull
The FPGA may already have a static image programmed when Linux boots. In that case a DT overlay may be used to add the devices that already exist. This commit allows that by shuffling the order of some checks. Signed-off-by: Alan Tull <at...@kernel.org> --- v4: Patch added to patchset in

[PATCH v5 11/18] fpga: region: add fpga-region.h header

2017-10-17 Thread Alan Tull
* Create fpga-region.h. * Export fpga_region_program_fpga. * Move struct fpga_region and other things to the header. This is a step in separating FPGA region common code from Device Tree support. Signed-off-by: Alan Tull <at...@kernel.org> --- v2: split out from another patch update

Re: [PATCH v2 5/5] of/fdt: only store the device node basename in full_name

2017-10-17 Thread Alan Tull
On Mon, Aug 21, 2017 at 10:16 AM, Rob Herring wrote: Hi Rob, > With dependencies on a statically allocated full path name converted to > use %pOF format specifier, we can store just the basename of node, and > the unflattening of the FDT can be simplified. > > This commit will

[PATCH v5 15/18] fpga: region: move device tree support to of-fpga-region.c

2017-10-17 Thread Alan Tull
* of_fpga_region_notify_post_remove * of_fpga_region_notify * of_fpga_region_probe * of_fpga_region_remove Create two new functions with some code from fpga_region_init/exit. * of_fpga_region_init * of_fpga_region_exit Signed-off-by: Alan Tull <at...@kernel.org> --- v2: split out code changes into other patches, only mov

[PATCH v5 10/18] fpga: region: separate out code that parses the overlay

2017-10-17 Thread Alan Tull
Tree overlay support. Signed-off-by: Alan Tull <at...@kernel.org> --- v2: split out from another patch v3: update comments minor changes in flow v4: no change to this patch in this version of patchset v5: no change to this patch in this version of patchset --- drivers/fpga/fpga-region.c

[PATCH v5 06/18] fpga: region: get mgr early on

2017-10-17 Thread Alan Tull
Get the FPGA manager during region creation. This is a baby step in refactoring the FPGA region code to separate out common FPGA region code from FPGA region Device Tree overlay support. Signed-off-by: Alan Tull <at...@kernel.org> --- v2: split out from another patch v3: no change to this

[PATCH v5 03/18] fpga: mgr: separate getting/locking FPGA manager

2017-10-17 Thread Alan Tull
: * fpga_mgr_lock * fpga_mgr_unlock The following functions no longer lock an FPGA manager's mutex: * of_fpga_mgr_get * fpga_mgr_get * fpga_mgr_put Signed-off-by: Alan Tull <at...@kernel.org> --- v2: add static for __fpga_mgr_get function documentation corrections use dev_err v3: bisecti

[PATCH v5 12/18] fpga: region: rename some functions prior to moving

2017-10-17 Thread Alan Tull
ion. * of_fpga_region_get_bridges change second parameter to FPGA image info. Export of_fpga_region_find as well. Signed-off-by: Alan Tull <at...@kernel.org> --- v2: split out from another patch v3: no changes in patch for this version of patchset v4: no change to this patch in this version of patchset v5:

[PATCH v5 09/18] fpga: region: use image info as parameter for programming region

2017-10-17 Thread Alan Tull
Use FPGA image info (region->info) when region code is programming the FPGA to pass in multiple parameters. This is a baby step in refactoring the FPGA region code to separate out common FPGA region code from FPGA region Device Tree overlay support. Signed-off-by: Alan Tull <at...@kern

[PATCH v5 14/18] fpga: region: add fpga_region_class_find

2017-10-17 Thread Alan Tull
Add a function for searching the fpga-region class. This will be useful when device tree code is no longer in the same file that declares the fpga-region class. Another step in separating common FPGA region code from device tree support. Signed-off-by: Alan Tull <at...@kernel.org>

[PATCH v5 17/18] fpga: clean up fpga Kconfig

2017-10-17 Thread Alan Tull
<*> Technologic Systems TS-73xx SBC FPGA Manager <*> FPGA Bridge Framework <*> Altera SoCFPGA FPGA Bridges <*> Altera FPGA Freeze Bridge <*> Xilinx LogiCORE PR Decoupler <*> FPGA Region <*> FPGA Reg

[PATCH v5 13/18] fpga: region: add register/unregister functions

2017-10-17 Thread Alan Tull
to the region struct * use region->info in of_fpga_region_get_bridges Signed-off-by: Alan Tull <at...@kernel.org> --- v2: split out from another patch v3: use region->info, remove info param where applicable v4: no change to this patch in this version of patchset v5: add back in

[PATCH v5 18/18] fpga: add attribute groups

2017-10-17 Thread Alan Tull
-off-by: Alan Tull <at...@kernel.org> --- v4: Patch added to patchset in v4 v5: no change to this patch in this version of patchset --- drivers/fpga/fpga-bridge.c | 1 + drivers/fpga/fpga-mgr.c | 1 + drivers/fpga/fpga-region.c | 1 + include/linux/fpga/fpga-bridge

[PATCH v5 08/18] fpga: region: fix slow warning with more than one overlay

2017-10-17 Thread Alan Tull
ote that overlays that make DT changes without reprogramming the FPGA are exempt from this restriction. Signed-off-by: Alan Tull <at...@kernel.org> --- v2: split out from another patch v3: better explanation in header v4: no change to this patch in this version of patchset v5: no change to t

[PATCH v5 07/18] fpga: region: check for child regions before allocing image info

2017-10-17 Thread Alan Tull
FPGA region Device Tree overlay support. Signed-off-by: Alan Tull <at...@kernel.org> Acked-by: Moritz Fischer <m...@kernel.org> --- v2: split out from another patch v3: s/dev/>dev/ in one place add Moritz' ack v4: no change to this patch in this version of patchset v5: no chang

[PATCH v5 02/18] fpga: mgr: API change to replace fpga load functions with single function

2017-10-17 Thread Alan Tull
. API documentation has been updated and a new document for FPGA region has been added. Signed-off-by: Alan Tull <at...@kernel.org> --- v2: add fpga_image_info_alloc/free update copyright and author email v3: fix bisectibility v4: fix return value of fpga_image_info_alloc() save

[PATCH v5 05/18] fpga: region: remove unneeded of_node_get and put

2017-10-17 Thread Alan Tull
Remove of_node_get/put in fpga_region_get/put. Not needed and will get in the way when I separate out the common FPGA region code from Device Tree support code. Signed-off-by: Alan Tull <at...@kernel.org> Acked-by: Moritz Fischer <m...@kernel.org> --- v2: split out from another p

[PATCH v5 01/18] fpga: bridge: support getting bridge from device

2017-10-17 Thread Alan Tull
. Signed-off-by: Alan Tull <at...@kernel.org> --- v2: use list_for_each_entry static the bridge_list_lock update copyright and author email v3: no change to this patch in this version of patchset v4: no change to this patch in this version of patchset v5: fpga-bridge.h - move #ifndef

[PATCH v5 00/18] Enable upper layers using FPGA region w/o device tree

2017-10-17 Thread Alan Tull
#ifndef before #includes in headers * Spelling fixes and other nits Alan Tull (18): fpga: bridge: support getting bridge from device fpga: mgr: API change to replace fpga load functions with single function fpga: mgr: separate getting/locking FPGA manager fpga: region: use dev_err instead

[PATCH v5 04/18] fpga: region: use dev_err instead of pr_err

2017-10-17 Thread Alan Tull
Use dev_err messages instead of pr_err. Also s/>dev/dev/ in two places where we already have dev = >dev. Signed-off-by: Alan Tull <at...@kernel.org> Acked-by: Moritz Fischer <m...@kernel.org> --- v2: new in this version of the patchset v3: for bisectability some changes moved

dtc issue with overlays starting in next-20171009

2017-10-18 Thread Alan Tull
Hi Rob, I've noticed a problem compiling DT overlays and traced it back to beginning in next-20171009 That tag adds the following in scripts/dtc e9480c1 2017-10-09 16:17:32 +0100 : Mark Brown : Merge remote-tracking branch 'devicetree/for-next' 4201d05 2017-10-03 15:03:47 -0500 : Rob Herring :

Re: [PATCH v2 5/5] of/fdt: only store the device node basename in full_name

2017-10-18 Thread Alan Tull
On Tue, Oct 17, 2017 at 6:51 PM, Frank Rowand <frowand.l...@gmail.com> wrote: > On 10/17/17 14:46, Rob Herring wrote: >> On Tue, Oct 17, 2017 at 4:32 PM, Alan Tull <at...@kernel.org> wrote: >>> On Mon, Aug 21, 2017 at 10:16 AM, Rob Herring <r...@

Re: [PATCH v2 5/5] of/fdt: only store the device node basename in full_name

2017-10-18 Thread Alan Tull
On Wed, Oct 18, 2017 at 10:53 AM, Pantelis Antoniou <pantelis.anton...@konsulko.com> wrote: > On Wed, 2017-10-18 at 10:44 -0500, Rob Herring wrote: >> On Wed, Oct 18, 2017 at 10:12 AM, Alan Tull <at...@kernel.org> wrote: >> > On Tue, Oct 17, 2017 at 6:51 PM, Frank

Re: [PATCH v3 06/12] of: overlay: detect cases where device tree may become corrupt

2017-10-19 Thread Alan Tull
On Tue, Oct 17, 2017 at 6:36 PM, wrote: > static int overlay_notify(struct overlay_changeset *ovcs, > enum of_overlay_notify_action action) > { > @@ -86,8 +109,14 @@ static int overlay_notify(struct overlay_changeset *ovcs, > > ret =

<    1   2   3   4   5   6   7   8   9   10   >