In case of handling a bad descriptor the dwc_handle_error() will dump a stack
as well. It's a lot more verbose and more likely to get user's attention.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
---
drivers/dma/dw_dmac.c |6 +++---
1 file changed, 3 insertions(+), 3
heikki.kroge...@linux.intel.com
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
Acked-by: Viresh Kumar viresh.ku...@linaro.org
---
drivers/dma/dw_dmac.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c
index c4b0eb3
The to_dw_desc() macro helps to retrieve the dw_desc node from the
corresponding list_head structure.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
---
drivers/dma/dw_dmac.c |6 ++
drivers/dma/dw_dmac_regs.h |2 ++
2 files changed, 4 insertions(+), 4 deletions
Change printk(KERN_INFO ..., dev_name(...), ...) to dev_info() as well.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
---
drivers/dma/dw_dmac.c | 15 ++-
1 file changed, 6 insertions(+), 9 deletions(-)
diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c
There are few cleanups to the driver which partialy acked and reviewed.
Since v2:
- add one more clean up (patch 6/6)
- make a separate patch to WARN a user in dwc_handle_error (suggested by
Felipe Balbi)
- add a description to patch 4/6
Andy Shevchenko (4):
dw_dmac: change dev_printk
From: Heikki Krogerus heikki.kroge...@linux.intel.com
This driver could be used on different platforms. Thus, the HAVE_CLK dependency
is dropped away.
Signed-off-by: Heikki Krogerus heikki.kroge...@linux.intel.com
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
Reviewed
Use 'u32' for the LLI structure members, which are defined by hardware to be
32-bit. dma_addr_t is much more vague about its actual size.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
---
drivers/dma/dw_dmac.c |7 ++-
drivers/dma/dw_dmac_regs.h |6 +++---
2
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
---
drivers/dma/dw_dmac.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c
index 9151511..db56ef4 100644
--- a/drivers/dma/dw_dmac.c
+++ b/drivers/dma/dw_dmac.c
The default values are filled to support at least mem-to-mem tests provided by
dmatest module. It makes sense to choose the 4 bytes (2 least significant bits)
alignment by the default.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
---
drivers/dma/dw_dmac.c |6 ++
1
addresses and length of the test data aligned. On the other hand we
can't use unaligned address in LLI because of the hardware restriction
(2 bits are used for choosing AHB master).
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body
this patch still in my pool.
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org
On Fri, Jul 13, 2012 at 1:30 PM, viresh kumar viresh.kum...@arm.com wrote:
Sorry, got confused now. What works without this patch? And what doesn't work
without it?
It seems this patch is redundant.
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line
in the API (struct
device, request_irq, ...), but keep reference between driver
and PIC via some object [1].
Third opinion is to forget about the issue and hope the new coming devices will
support either DT, or ACPI 5.
[1] https://lkml.org/lkml/2012/7/5/155
Signed-off-by: Andy Shevchenko andriy.shevche
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
---
drivers/dma/dmaengine.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma/dmaengine.c b/drivers/dma/dmaengine.c
index 26ac0f8..071bd73 100644
--- a/drivers/dma/dmaengine.c
+++ b/drivers/dma
On Wed, Jul 18, 2012 at 7:51 PM, Joe Perches j...@perches.com wrote:
Use a more current logging style.
Add pr_fmt to prefix dmaengine: to messages.
Convert printk(KERN_ERR to pr_err(.
Convert embedded function name use to %s: , __func__
Align arguments.
Original-patch-by: Andy Shevchenko
Will do tomorrow. Thanks!
On Mon, Apr 15, 2013 at 7:36 PM, Vinod Koul vinod.k...@intel.com wrote:
On Tue, Apr 09, 2013 at 02:05:42PM +0300, Andy Shevchenko wrote:
There is a patch series which introduces ACPI DMA helpers in similar way like
we have for DeviceTree.
In addition it applies
On Mon, 2013-04-15 at 22:06 +0530, Vinod Koul wrote:
On Tue, Apr 09, 2013 at 02:05:42PM +0300, Andy Shevchenko wrote:
There is a patch series which introduces ACPI DMA helpers in similar way
like
we have for DeviceTree.
In addition it applies this to the first user, namely dw_dmac
From: Rafael J. Wysocki rafael.j.wyso...@intel.com
The DMA controller in Lynxpoint is enumerated as a regular ACPI device now. To
work properly it is using the LPSS root clock as a functional clock. That's why
we have to register the clock device accordingly to the ACPI ID of the DMA
controller.
On Fri, 2013-04-19 at 21:20 +0800, Eric Miao wrote:
On Fri, Apr 19, 2013 at 8:35 PM, Hein Tibosch hein_tibo...@yahoo.es wrote:
Hi Andy, Mika,
On 8 Feb 2013, Andy Shevchenko wrote:
Some of the platform devices rely on the name of their driver to match
with. In
the current
On Sat, 2013-03-30 at 03:03 +0530, Vinod Koul wrote:
On Wed, Mar 27, 2013 at 10:57:59AM +0200, Andy Shevchenko wrote:
Since we have CSRT only to get additional DMA controller resources, let's
get
rid of drivers/acpi/csrt.c and move its logic inside ACPI DMA helpers code.
Signed-off
There is a patch series which introduces ACPI DMA helpers in similar way like
we have for DeviceTree.
In addition it applies this to the first user, namely dw_dmac driver.
Since v1:
- address one Vinod's comment
- replace 5/6 6/6 by 5/5 from Rafael
- tested on Intel Lynxpoint system
Andy
Since we have proper ACPI DMA helpers implemented, the driver may use it. This
patch introduces custom filter function together with acpi_device_id table.
Signed-off-by: Mika Westerberg mika.westerb...@linux.intel.com
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
---
drivers
Since we have CSRT only to get additional DMA controller resources, let's get
rid of drivers/acpi/csrt.c and move its logic inside ACPI DMA helpers code.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
Signed-off-by: Mika Westerberg mika.westerb...@linux.intel.com
Acked
The slave device could be enumerated by ACPI. In that case the
dma_request_slave_channel should use the acpi_dma_request_slave_channel()
helper.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
Reviewed-by: Mika Westerberg mika.westerb...@linux.intel.com
Acked-by: Rafael J
From: Rafael J. Wysocki r...@sisk.pl
The DMA controller in Lynxpoint is using the LPSS root clock as a functional
clock to work properly. Proposed patch adds support of the shared clock. It
also avoids hardcoding the name of the DMA device in clk-lpt.c and the name of
the root clock in
devm_acpi_dma_controller_register().
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
Reviewed-by: Mika Westerberg mika.westerb...@linux.intel.com
Acked-by: Rafael J. Wysocki rafael.j.wyso...@intel.com
---
Documentation/acpi/enumeration.txt | 77 ++
drivers/dma/Kconfig
From: Rafael J. Wysocki rafael.j.wyso...@intel.com
The DMA controller in Lynxpoint is using the LPSS root clock as a functional
clock to work properly. Proposed patch adds support of the shared clock. It
also avoids hardcoding the name of the DMA device in clk-lpt.c and the name of
the root clock
On Tue, 2013-04-09 at 14:05 +0300, Andy Shevchenko wrote:
There is a patch series which introduces ACPI DMA helpers in similar way like
we have for DeviceTree.
In addition it applies this to the first user, namely dw_dmac driver.
Since v1:
- address one Vinod's comment
- replace 5/6
There is generic implementation of the function to unescape strings.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
Cc: Samuel Thibault samuel.thiba...@ens-lyon.org
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
Cc: spea...@braille.uwo.ca
Cc: de...@driverdev.osuosl.org
There is string_unescape_inplace() function which decodes strings in generic
way. Let's use it.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
Cc: Alexander Viro v...@zeniv.linux.org.uk
Cc: linux-fsde...@vger.kernel.org
---
fs/binfmt_misc.c | 24
1 file
There is kernel function to do the job in generic way. Let's use it.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
Cc: Jason Baron jba...@redhat.com
---
lib/dynamic_debug.c | 48 +---
1 file changed, 5 insertions(+), 43 deletions
There are several places in kernel where modules unescapes input to convert
C-Style Escape Sequences into byte codes.
The patch provides generic implementation of such approach. Test cases are
also included into the patch.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
Cc
__builtin_memcmp
+#define memcmp(a, b, n) __builtin_memcmp(a, b, n)
And in this case:
modprobe test_string_helpers
[ 15.391589] test_string_helpers: Running tests...
What did I miss?
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line unsubscribe linux-kernel
.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
---
drivers/dma/dw_dmac.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c
index 43a5329..43e2e89 100644
--- a/drivers/dma/dw_dmac.c
+++ b/drivers/dma/dw_dmac.c
The commit c30f46bc (drivers/Kconfig: add several missing GENERIC_HARDIRQS
dependencies) introduced a warning on make defconfig stage. This patch fixes a
typo.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
---
drivers/dma/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1
It includes few cleanups when used with DT. Patch 4/4 is a modified version of
the [1].
[1] http://www.spinics.net/lists/arm-kernel/msg225366.html
Andy Shevchenko (3):
dw_dmac: fix style of the comments
dw_dmac: rename DT related methods to reflect their belonging
dw_dmac: make build of DT
instead
and save them in the dw_dma_chan structure directly.
This could be simplified further once all users that today use
dw_dma_slave for configuration get converted to device tree based
setup instead.
Signed-off-by: Arnd Bergmann a...@arndb.de
Signed-off-by: Andy Shevchenko andriy.shevche
Let's use capital letter as a first one in the comments.
There is no functional changes.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
---
drivers/dma/dw_dmac.c | 30 +++---
1 file changed, 15 insertions(+), 15 deletions(-)
diff --git a/drivers/dma
() - dw_dma_of_xlate()
dw_dma_id_table - dw_dma_of_id_table
There is no functional change.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
---
drivers/dma/dw_dmac.c | 24 +---
1 file changed, 13 insertions(+), 11 deletions
return code of fake one when of_dma_controller_register is not
implemented.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
---
drivers/dma/dw_dmac.c | 23 ---
1 file changed, 16 insertions(+), 7 deletions(-)
diff --git a/drivers/dma/dw_dmac.c b/drivers/dma
On Fri, 2013-03-22 at 15:19 +, Arnd Bergmann wrote:
On Friday 22 March 2013, Andy Shevchenko wrote:
There is no reason to build custom filter function and translation function
inside the driver in case we have no DT platform.
This patch introduces new method
It includes few cleanups when used with DT. Patch 4/4 is a modified version of
the [1].
[1] http://www.spinics.net/lists/arm-kernel/msg225366.html
Since v1:
- address Arnd's comments
- apply Acks I got from Viresh
Andy Shevchenko (3):
dw_dmac: fix style of the comments
dw_dmac: rename DT
Let's use capital letter as a first one in the comments.
There is no functional changes.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
Acked-by: Viresh Kumar viresh.ku...@linaro.org
---
drivers/dma/dw_dmac.c | 30 +++---
1 file changed, 15 insertions
instead
and save them in the dw_dma_chan structure directly.
This could be simplified further once all users that today use
dw_dma_slave for configuration get converted to device tree based
setup instead.
Signed-off-by: Arnd Bergmann a...@arndb.de
Signed-off-by: Andy Shevchenko andriy.shevche
This patch introduces new method dw_dma_of_controller_register() and adds
checks of the of_node presence together with CONFIG_OF before calling the
wrapper. It helps to distinguish the real -ENODEV return code of fake one when
of_dma_controller_register is not implemented.
Signed-off-by: Andy
() - dw_dma_of_xlate()
dw_dma_id_table - dw_dma_of_id_table
There is no functional change.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
Acked-by: Viresh Kumar viresh.ku...@linaro.org
---
drivers/dma/dw_dmac.c | 24 +---
1
On Tue, 2013-03-26 at 16:04 +0100, Lars-Peter Clausen wrote:
On 03/26/2013 03:53 PM, Andy Shevchenko wrote:
This patch introduces new method dw_dma_of_controller_register() and adds
checks of the of_node presence together with CONFIG_OF before calling the
wrapper. It helps to distinguish
This patch introduces new method dw_dma_of_controller_register(). The wrapper
is called only when of_node is present.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
Acked-by: Arnd Bergmann a...@arndb.de
---
drivers/dma/dw_dmac.c | 19 ---
1 file changed, 12
On Tue, 2013-03-26 at 22:37 +0530, Viresh Kumar wrote:
On 26 March 2013 22:34, Andy Shevchenko
andriy.shevche...@linux.intel.com wrote:
This patch introduces new method dw_dma_of_controller_register(). The
wrapper
is called only when of_node is present.
Signed-off-by: Andy Shevchenko
If CONFIG_OF is not set the of_node of the device will always be NULL.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
---
drivers/dma/dw_dmac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c
index 274fd7d
devm_acpi_dma_controller_register().
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
Reviewed-by: Mika Westerberg mika.westerb...@linux.intel.com
Acked-by: Rafael J. Wysocki rafael.j.wyso...@intel.com
---
Documentation/acpi/enumeration.txt | 77 ++
drivers/dma/Kconfig
Since we have proper ACPI DMA helpers implemented, the driver may use it. This
patch introduces custom filter function together with acpi_device_id table.
Signed-off-by: Mika Westerberg mika.westerb...@linux.intel.com
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
---
drivers
The slave device could be enumerated by ACPI. In that case the
dma_request_slave_channel should use the acpi_dma_request_slave_channel()
helper.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
Reviewed-by: Mika Westerberg mika.westerb...@linux.intel.com
Acked-by: Rafael J
In Lynxpoint we have to enable clock per each LPSS device. That's why we have
to enumerate them from drivers/acpi/acpi_lpss.c. The DMA controller is one of
such devices.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
---
drivers/acpi/acpi_lpss.c | 7 +++
drivers/clk/x86
There is a patch series which introduces ACPI DMA helpers in similar way like
we have for DeviceTree.
In addition it applies this to the first user, namely dw_dmac driver.
Andy Shevchenko (6):
dma: acpi-dma: introduce ACPI DMA helpers
dmaengine: call acpi_dma_request_slave_channel as well
When device uses the fixed clock and has no private space of LTR, we have to
create main LPSS clock and register platform device. This is normally a case
for LPSS DMA controller.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
---
drivers/acpi/acpi_lpss.c | 4
1 file
Since we have CSRT only to get additional DMA controller resources, let's get
rid of drivers/acpi/csrt.c and move its logic inside ACPI DMA helpers code.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
Signed-off-by: Mika Westerberg mika.westerb...@linux.intel.com
Acked
On Tue, 2013-03-05 at 17:16 +0800, Viresh Kumar wrote:
On 4 March 2013 17:09, Andy Shevchenko
andriy.shevche...@linux.intel.com wrote:
Better to keep test parameters separate from internal variables.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
---
drivers/dma
On Thu, 2013-03-07 at 11:50 +0530, Vinod Koul wrote:
On Mon, Mar 04, 2013 at 11:09:24AM +0200, Andy Shevchenko wrote:
The first approach to get dmatest module more flexible and easier to play
with.
The amount of patches could be reduced, but I would like to get a comments
first
On Sun, Mar 10, 2013 at 3:44 PM, Viresh Kumar viresh.ku...@linaro.org wrote:
On 8 March 2013 21:11, Andy Shevchenko
andriy.shevche...@linux.intel.com wrote:
On Thu, 2013-03-07 at 11:50 +0530, Vinod Koul wrote:
On Mon, Mar 04, 2013 at 11:09:24AM +0200, Andy Shevchenko wrote:
The first
Comparison between buffers is stored to the dedicated structure.
Note that the verify result is now accessible only via file 'results' in the
debugfs.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
---
Documentation/dmatest.txt | 6 +-
drivers/dma/dmatest.c | 182
. For the details see
the above section 1. When dmatest is built as a module...
In both cases the module parameters are used as initial values for the test
case.
You always could check them at run-time by running
% grep -H . /sys/module/dmatest/parameters/*
Signed-off-by: Andy Shevchenko andriy.shevche
.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
---
drivers/dma/dmatest.c | 160 +++---
1 file changed, 113 insertions(+), 47 deletions(-)
diff --git a/drivers/dma/dmatest.c b/drivers/dma/dmatest.c
index e3955be..7f9e3cc 100644
Its meaning is to limit amount of error messages to be printed out when buffer
mismatch is occured.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
---
drivers/dma/dmatest.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/dma/dmatest.c b
wait_event_freezable_timeout() solves
that.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
---
drivers/dma/dmatest.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/dma/dmatest.c b/drivers/dma/dmatest.c
index a2c8904..e6b4cfa 100644
--- a/drivers/dma/dmatest.c
+++ b/drivers
that the buffer comparison is done in the old way, i.e. data is not
collected and just printed out.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
---
Documentation/dmatest.txt | 19
drivers/dma/dmatest.c | 234 --
2 files changed
We don't need to have them global and later we would like to protect access to
them as well.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
---
drivers/dma/dmatest.c | 29 -
1 file changed, 16 insertions(+), 13 deletions(-)
diff --git a/drivers/dma
This will help in future to hide a global variable usage.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
---
drivers/dma/dmatest.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/drivers/dma/dmatest.c b/drivers/dma/dmatest.c
index e6b4cfa
Better to keep test parameters separate from internal variables.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
---
drivers/dma/dmatest.c | 109 --
1 file changed, 62 insertions(+), 47 deletions(-)
diff --git a/drivers/dma
.
sleep 1
done
echo
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
---
Documentation/dmatest.txt | 12
drivers/dma/dmatest.c | 23 +--
2 files changed, 33 insertions(+), 2 deletions(-)
diff --git a/Documentation/dmatest.txt b
the commit
messages.
Module was tested on Intel Medfield and Lynxpoint systems with dw_dmac DMA
controller embedded.
Andy Shevchenko (10):
dmatest: cancel thread immediately when asked for
dmatest: allocate memory for pq_coefs from heap
dmatest: create dmatest_info to keep test parameters
On Tue, 2013-03-05 at 17:12 +0800, Viresh Kumar wrote:
On 4 March 2013 17:09, Andy Shevchenko
andriy.shevche...@linux.intel.com wrote:
We don't need to have them global and later we would like to protect access
to
them as well.
Signed-off-by: Andy Shevchenko andriy.shevche
On Tue, 2013-03-05 at 14:56 +0530, Vinod Koul wrote:
On Mon, Mar 04, 2013 at 11:09:30AM +0200, Andy Shevchenko wrote:
@@ -0,0 +1,48 @@
+ DMA Test Guide
+ ==
+
+ Andy Shevchenko andriy.shevche...@linux.intel.com
= ~(0xff shift);
+ mux |= xbar_chans[i][0] shift;
+ writel(mux, (void *)((u32)xbar + offset));
+ }
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord
Oh, missed Cc list in the middle. Return it back and thus leave a full
message below.
On Thu, Mar 7, 2013 at 8:11 AM, Vinod Koul vinod.k...@intel.com wrote:
On Wed, Mar 06, 2013 at 05:53:20PM +0200, Andy Shevchenko wrote:
How do you terminate a test? Esp if you have started bunch of concurent
On Thu, Nov 29, 2012 at 1:56 AM, Andrew Morton
a...@linux-foundation.org wrote:
On Wed, 21 Nov 2012 16:31:11 +0200
Andy Shevchenko andriy.shevche...@linux.intel.com wrote:
When build a kernel with make W=1 we will get a warning about missing
initializer. It comes from kfifo usage style
On Thu, Nov 29, 2012 at 11:21 AM, Andy Shevchenko
andy.shevche...@gmail.com wrote:
On Thu, Nov 29, 2012 at 1:56 AM, Andrew Morton
a...@linux-foundation.org wrote:
On Wed, 21 Nov 2012 16:31:11 +0200
Andy Shevchenko andriy.shevche...@linux.intel.com wrote:
When build a kernel with make W=1 we
On Thu, Nov 29, 2012 at 3:51 AM, Andrew Morton
a...@linux-foundation.org wrote:
On Wed, 21 Nov 2012 16:31:11 +0200
Andy Shevchenko andriy.shevche...@linux.intel.com wrote:
When build a kernel with make W=1 we will get a warning about missing
initializer. It comes from kfifo usage style
On Fri, Feb 8, 2013 at 6:28 AM, Viresh Kumar viresh.ku...@linaro.org wrote:
On Thu, Feb 7, 2013 at 10:35 PM, Andy Shevchenko
andy.shevche...@gmail.com wrote:
On Thu, Feb 7, 2013 at 5:39 PM, Viresh Kumar viresh.ku...@linaro.org wrote:
On 7 February 2013 21:06, Andy Shevchenko
andriy.shevche
to match by the
driver name. This will make it similar to the DT or ACPI cases.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
Reported-by: Mika Westerberg mika.westerb...@linux.intel.com
Cc: Eric Miao eric.m...@marvell.com
Cc: Greg Kroah-Hartman gre...@suse.de
---
drivers/base
to match by the
driver name. This will make it similar to the DT or ACPI cases.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
Reported-by: Mika Westerberg mika.westerb...@linux.intel.com
Cc: Eric Miao eric.y.m...@gmail.com
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
When status is DMA_SUCCESS the residue should be zero. Otherwise it's a bug.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
Cc: Linus Walleij linus.wall...@linaro.org
Cc: linux-arm-ker...@lists.infradead.org
---
drivers/dma/coh901318.c |4 +++-
1 file changed, 3 insertions
It's possible to have an inconsistency in the list due to unprotected operation
on it. The patch adds a proper locking on the list operation.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
Acked-by: Rob Herring rob.herr...@calxeda.com
---
drivers/of/dma.c |2 ++
1 file
This is a patcset of independent fixes of the DMAC drivers. They are simple and
being understandable in their context.
Andy Shevchenko (6):
of: dma: protect list write operation by spin_lock
dmaengine.h: remove redundant else keyword
dma: coh901318_lli: avoid unbalanced locking
dma
I have not checked the code but there is a possibility that custom pool-lock
is not needed at all due to dma_pool contains it's own lock.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
Cc: Linus Walleij linus.wall...@linaro.org
Cc: linux-arm-ker...@lists.infradead.org
Accordingly to commentary in the platform_device_register_full the memory
allocated for dma_mask will not going to be freed. That's why is better to
assign dma_mask afterwards.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
---
drivers/dma/edma.c |6 --
1 file changed
dmaengine_device_control returns -ENOSYS in case the dma driver doesn't have
such functionality.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
---
include/linux/dmaengine.h |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/include/linux/dmaengine.h b
There is no need to assign 0 to residue, because dma_cookie_status() does this
for us.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
---
drivers/dma/tegra20-apb-dma.c |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/dma/tegra20-apb-dma.c b/drivers/dma/tegra20-apb
On Tue, Feb 12, 2013 at 5:56 PM, Vinod Koul vinod.k...@intel.com wrote:
On Wed, Jan 30, 2013 at 09:32:56AM +0200, Andy Shevchenko wrote:
On Tue, 2013-01-29 at 20:57 +0530, Viresh Kumar wrote:
On Tue, Jan 29, 2013 at 10:52 AM, Mika Westerberg
mika.westerb...@linux.intel.com wrote:
We had
On Tue, Feb 12, 2013 at 6:16 PM, Vinod Koul vinod.k...@intel.com wrote:
On Tue, Jan 29, 2013 at 05:06:24PM +0200, Andy Shevchenko wrote:
In some cases we got the device without dma_mask configured. We have to apply
the default value to avoid crashes during memory mapping.
what
From: Mika Westerberg mika.westerb...@linux.intel.com
Intel Lynxpoint PCH Low Power Subsystem has DMA controller to support general
purpose serial buses like SPI, I2C, and HSUART. This controller is enumerated
from ACPI namespace with ACPI ID INTL9C60.
Signed-off-by: Andy Shevchenko
On Thu, Feb 7, 2013 at 5:39 PM, Viresh Kumar viresh.ku...@linaro.org wrote:
On 7 February 2013 21:06, Andy Shevchenko
andriy.shevche...@linux.intel.com wrote:
From: Mika Westerberg mika.westerb...@linux.intel.com
Intel Lynxpoint PCH Low Power Subsystem has DMA controller to support general
in argument 1
(different address spaces)
drivers/dma/dw_dmac.c:1691:32:expected void const *ptr
drivers/dma/dw_dmac.c:1691:32:got void [noderef] asn:2*[assigned] regs
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body
In some cases we got the device without dma_mask configured. We have to apply
the default value to avoid crashes during memory mapping.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
---
drivers/dma/dw_dmac.c |6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers
we have to pass this info somehow to the DMAC driver. And
like Mika already mentioned we have no other generic way except
IORESOURCE_DMA. If you have something better in mind, please share. We
could adopt our code then.
--
Andy Shevchenko andriy.shevche...@linux.intel.com
Intel Finland Oy
On Wed, Jan 30, 2013 at 8:41 AM, Matt Porter mpor...@ti.com wrote:
On Mon, Jan 28, 2013 at 09:27:24PM +0200, Andy Shevchenko wrote:
On Tue, Jan 15, 2013 at 10:32 PM, Matt Porter mpor...@ti.com wrote:
Adds support for parsing the TI EDMA DT data into the required
EDMA private API platform
On Wed, 2013-01-30 at 13:31 +0530, Viresh Kumar wrote:
On Wed, Jan 30, 2013 at 1:02 PM, Andy Shevchenko
andriy.shevche...@linux.intel.com wrote:
We get a device from the ACPI CSRT table. During enumeration we don't
know what kind of the device it is. From the enumeration point of view
by this patch due to len field in the descriptor
structure is left untouched by the original code.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
---
drivers/dma/dw_dmac.c | 47 ++--
drivers/dma/dw_dmac_regs.h |1 +
2 files
On Fri, 2013-01-25 at 09:43 +0530, Viresh Kumar wrote:
On Thu, Jan 24, 2013 at 6:37 PM, Andy Shevchenko
andriy.shevche...@linux.intel.com wrote:
Currently the driver returns full length of the active descriptor which is
wrong. We have to go throught the active descriptor and substract
On Fri, Jan 25, 2013 at 10:56 AM, Andy Shevchenko
andriy.shevche...@linux.intel.com wrote:
On Fri, 2013-01-25 at 09:43 +0530, Viresh Kumar wrote:
On Thu, Jan 24, 2013 at 6:37 PM, Andy Shevchenko
andriy.shevche...@linux.intel.com wrote:
diff --git a/drivers/dma/dw_dmac.c b/drivers/dma
101 - 200 of 17509 matches
Mail list logo
