...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
?
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
and remove calls to iounmap.
- The devm_ioremap_resource function checks the passed resource so
we can remove the NULL check after the platform_get_resource call.
What about another patch (that I guess should go first) that converts
printk to dev_* or pr_*?
--
With Best Regards,
Andy Shevchenko
__iomem *reg_base_addr; /* MAC registers base address */
kerneldoc format?
+++ b/drivers/net/ethernet/arc/arc_emac_regs.h
@@ -0,0 +1,72 @@
+/*
+ * Copyright (C) 2004, 2007-2010, 2011-2013 Synopsys, Inc. (www.synopsys.com)
2007-2013 ?
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from
On Tue, Jun 4, 2013 at 8:11 PM, Dan Williams d...@fb.com wrote:
On 6/4/13 12:25 AM, Andy Shevchenko andy.shevche...@gmail.com wrote:
On Tue, Jun 4, 2013 at 2:29 AM, Jon Mason jon.ma...@intel.com wrote:
On Fri, May 31, 2013 at 11:22:10AM +0300, Andy Shevchenko wrote:
[]
Since the testing
On Sun, Jun 9, 2013 at 10:17 PM, Dan Carpenter dan.carpen...@oracle.com wrote:
On Sun, Jun 09, 2013 at 08:15:20PM +0300, Andy Shevchenko wrote:
[]
What about another patch (that I guess should go first) that converts
printk to dev_* or pr_*?
Huh, what? Those are two totally unrelated
On Fri, Jun 7, 2013 at 6:02 AM, Xiang Wang wangx...@gmail.com wrote:
2013/6/6 Andy Shevchenko andy.shevche...@gmail.com:
On Thu, Jun 6, 2013 at 6:09 AM, Xiang Wang wangx...@gmail.com wrote:
[]
2. DMA controller handles trailing bytes for us.
This is the case I mentioned in my previous email
think you have to talk to Sakari
about your issues.
On Thu, Jun 06, 2013 at 11:32:06PM +0300, Andy Shevchenko wrote:
On Thu, Jun 6, 2013 at 9:33 PM, Bin Gao bin@linux.intel.com wrote:
There is a requirement to get the i2c_client pointer dynamically without
knowing the bus and slave
On Sun, Jun 9, 2013 at 11:57 PM, Dan Carpenter dan.carpen...@oracle.com wrote:
On Sun, Jun 09, 2013 at 10:27:03PM +0300, Andy Shevchenko wrote:
On Sun, Jun 9, 2013 at 10:17 PM, Dan Carpenter dan.carpen...@oracle.com
wrote:
On Sun, Jun 09, 2013 at 08:15:20PM +0300, Andy Shevchenko wrote
On Mon, Jun 10, 2013 at 3:04 AM, Wolfram Sang w...@the-dreams.de wrote:
On Thu, Jun 06, 2013 at 10:43:41PM +0300, Andy Shevchenko wrote:
On Mon, Jun 3, 2013 at 11:27 PM, Wolfram Sang w...@the-dreams.de wrote:
The allocated object should be the size of what the pointer is pointing
On Tue, Jun 11, 2013 at 12:43 AM, Oliver Schinagl
oliver+l...@schinagl.nl wrote:
On 06/06/13 21:16, Andy Shevchenko wrote:
On Sun, Jun 2, 2013 at 5:58 PM, Oliver Schinagl oliver+l...@schinagl.nl
wrote:
From: Oliver Schinagl oli...@schinagl.nl
+ if (likely((SID_SIZE))) {
Extra braces
)
+ return false;
return true;
}
What if rewrite like
if (divider-flags CLK_DIVIDER_EVEN == 0)
return true;
return div 2 || div % 2 == 0;
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message
On Tue, Jun 11, 2013 at 3:06 PM, Heiko Stübner he...@sntech.de wrote:
Am Dienstag, 11. Juni 2013, 13:51:56 schrieb Andy Shevchenko:
On Tue, Jun 11, 2013 at 2:29 PM, Heiko Stübner he...@sntech.de wrote:
[]
@@ -141,6 +149,8 @@ static bool _is_valid_div(struct clk_divider
*divider, unsigned
On Tue, Jun 11, 2013 at 3:37 PM, Andy Shevchenko
andy.shevche...@gmail.com wrote:
On Tue, Jun 11, 2013 at 3:06 PM, Heiko Stübner he...@sntech.de wrote:
Am Dienstag, 11. Juni 2013, 13:51:56 schrieb Andy Shevchenko:
On Tue, Jun 11, 2013 at 2:29 PM, Heiko Stübner he...@sntech.de wrote
On Wed, 2013-06-05 at 15:26 +0300, Andy Shevchenko wrote:
This is split of the dw_dmac driver as suggested by Arnd et al [1,2].
There are three most important patches:
2/4 moves driver to its own folder
3/4 does the actual split
4/4 introduces PCI part of the driver
During this files
On Wed, Jun 12, 2013 at 8:08 AM, Vinod Koul vinod.k...@intel.com wrote:
On Wed, Jun 05, 2013 at 03:26:44PM +0300, Andy Shevchenko wrote:
The dw_dmac driver is going to be split into multiple files. To make this
more
convenient move it to an own directory.
Signed-off-by: Andy Shevchenko
On Wed, Jun 12, 2013 at 10:39 AM, Vinod Koul vinod.k...@intel.com wrote:
On Wed, Jun 12, 2013 at 10:43:29AM +0300, Andy Shevchenko wrote:
On Wed, Jun 12, 2013 at 8:08 AM, Vinod Koul vinod.k...@intel.com wrote:
On Wed, Jun 05, 2013 at 03:26:44PM +0300, Andy Shevchenko wrote:
[]
Something
On Wed, Jun 12, 2013 at 10:52 AM, Vinod Koul vinod.k...@intel.com wrote:
On Wed, Jun 12, 2013 at 11:27:51AM +0300, Andy Shevchenko wrote:
On Wed, Jun 12, 2013 at 10:39 AM, Vinod Koul vinod.k...@intel.com wrote:
[]
Something like
config DW_DMAC_BIG_ENDIAN_IO
tristate
config
[+ Hein]
On Wed, 2013-06-12 at 13:42 +0530, Vinod Koul wrote:
On Wed, Jun 12, 2013 at 11:38:37AM +0300, Andy Shevchenko wrote:
On Wed, Jun 12, 2013 at 10:52 AM, Vinod Koul vinod.k...@intel.com wrote:
On Wed, Jun 12, 2013 at 11:27:51AM +0300, Andy Shevchenko wrote:
On Wed, Jun 12, 2013
For documenting, we can add this in commit log or better in driver code where
you use this
The driver is better place if you decide to move it (drivers/dma/dw/regs.h).
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body
will prepare later better approach with devm_* usage.
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read
suggest to mark it as __deprecated and wait couple of release cycles.
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
can avoid those 0xff.
+ ndev = alloc_etherdev(sizeof(struct arc_emac_priv));
+ if (!ndev) {
+ err = -ENOMEM;
+ goto out;
+ }
Redundant goto. Just return here.
+ }
+
+
Extra line.
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe
On Thu, Jun 13, 2013 at 9:33 PM, Joe Perches j...@perches.com wrote:
On Thu, 2013-06-13 at 21:25 +0300, Andy Shevchenko wrote:
On Thu, Jun 13, 2013 at 5:37 PM, Alexey Brodkin
alexey.brod...@synopsys.com wrote:
Driver for non-standard on-chip ethernet device ARC EMAC 10/100,
instantiated
On Thu, Jun 13, 2013 at 11:25 PM, Alexey Brodkin
alexey.brod...@synopsys.com wrote:
On 06/13/2013 10:25 PM, Andy Shevchenko wrote:
On Thu, Jun 13, 2013 at 5:37 PM, Alexey Brodkin
alexey.brod...@synopsys.com wrote:
Driver for non-standard on-chip ethernet device ARC EMAC 10/100,
instantiated
On Tue, Jun 11, 2013 at 8:11 PM, Bin Gao bin@linux.intel.com wrote:
On Sun, Jun 09, 2013 at 10:53:35PM +0300, Andy Shevchenko wrote:
Please, try to avoid top posting in the future emails.
On Fri, Jun 7, 2013 at 12:26 AM, Bin Gao bin@linux.intel.com wrote:
With v4l2, the camera sensor
);
+ goto exit;
Ditto.
+ dev_info(pdev-dev, sunxi SID ver %s loaded\n, DRV_VERSION);
+ ret = 0;
+ /* fall through */
Ditto.
+
+exit:
+ return ret;
Useless lines.
+module_platform_driver(sunxi_sid_driver);
+
+
Extra line.
--
With Best Regards,
Andy Shevchenko
DMA_CAP_PQ (1 2)
Can we reuse DMA_MEMCPY and so on from enum dma_transaction_type?
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
, %s driver unloaded\n, DRV_NAME);
It's useless to use DRV_NAME in conjunction with dev_* macros. dev_*
will print driver name as a prefix.
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord
,
Andy Shevchenko
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
It seems there is no user of the wp_gpio driver in the kernel. Let's remove it.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
Acked-by: Mika Westerberg mika.westerb...@linux.intel.com
---
drivers/gpio/gpio-langwell.c | 69 +---
1 file
On Tue, Jun 4, 2013 at 2:29 AM, Jon Mason jon.ma...@intel.com wrote:
On Fri, May 31, 2013 at 11:22:10AM +0300, Andy Shevchenko wrote:
On Fri, May 17, 2013 at 8:54 PM, Jon Mason jon.ma...@intel.com wrote:
dmatest would create a thread to stress XOR and PQ, if the capability is
present
There are kernel native helpers to convert hex ascii to the binary format:
hex_to_bin() and hex2bin(). Thus, no need to reimplement them customly.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
Cc: Geert Uytterhoeven ge...@linux-m68k.org
---
arch/cris/arch-v10/kernel/kgdb.c
On Tue, Jun 4, 2013 at 11:51 AM, Andy Shevchenko
andriy.shevche...@linux.intel.com wrote:
There are kernel native helpers to convert hex ascii to the binary format:
hex_to_bin() and hex2bin(). Thus, no need to reimplement them customly.
Signed-off-by: Andy Shevchenko andriy.shevche
To simplify the driver development let's split driver to library and platform
code parts. It helps us to add PCI driver in future.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
---
drivers/dma/Makefile | 2 +-
drivers/dma/dw/Kconfig
devm_ioremap_resource does sanity checks on the given resource. No need to
duplicate this in the driver.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
Acked-by: Viresh Kumar viresh.ku...@linaro.org
---
drivers/dma/dw_dmac.c | 5 +
1 file changed, 1 insertion(+), 4
The dw_dmac driver is going to be split into multiple files. To make this more
convenient move it to an own directory.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
Acked-by: Viresh Kumar viresh.ku...@linaro.org
---
MAINTAINERS | 3 +--
drivers/dma
This is the PCI part of the DesignWare DMAC driver. The controller is usually
used in the Intel hardware such as Intel Medfield.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
---
drivers/dma/dw/Kconfig | 9 +
drivers/dma/dw/Makefile | 3 ++
drivers/dma/dw/pci.c
core.c and
platform.c.
Cnages v0-v1:
- apply Viresh's ACKs
- append PCI part of the driver
- test altogether on Intel Medfield
- add 1/4 to the series as it based on it, but Vinod didn't apply it yet to
his tree.
Andy Shevchenko (4):
dw_dmac: don't check resource with devm_ioremap_resource
On Tue, 2013-06-04 at 15:01 +0200, Arnd Bergmann wrote:
On Tuesday 04 June 2013 15:36:18 Andy Shevchenko wrote:
This is second attempt to do split as suggested by Arnd et al [1,2].
There are three most important patches:
2/4 moves driver to its own folder
3/4 does the actual split
4
On Tue, Jun 4, 2013 at 5:03 PM, Arnd Bergmann a...@arndb.de wrote:
On Tuesday 28 May 2013, Andy Shevchenko wrote:
We have mac_pton() helper to parse MAC addresses.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
Acked-by: Arnd Bergmann a...@arndb.de
Hmm, the patch has
On Tue, Jun 4, 2013 at 5:38 PM, Arnd Bergmann a...@arndb.de wrote:
On Tuesday 04 June 2013 17:21:16 Andy Shevchenko wrote:
The easiest solution would be to
make the entire driver depend on NET.
I don't feel that is good idea. Driver is an abstraction to the ROM,
it doesn't mean you can't
Since we have at least one user of this function outside of CONFIG_NET
scope, we have to provide this function independently. The proposed
solution is to move it under lib/net_utils.c with corresponding
configuration variable and select wherever it is needed.
Signed-off-by: Andy Shevchenko
of the driver
- test altogether on Intel Medfield
- add 1/4 to the series as it based on it, but Vinod didn't apply it yet to
his tree.
Andy Shevchenko (4):
dw_dmac: don't check resource with devm_ioremap_resource
dma: move dw_dmac driver to an own directory
dma: dw: split driver
devm_ioremap_resource does sanity checks on the given resource. No need to
duplicate this in the driver.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
Acked-by: Viresh Kumar viresh.ku...@linaro.org
Acked-by: Arnd Bergmann a...@arndb.de
---
drivers/dma/dw_dmac.c | 5 +
1
This is the PCI part of the DesignWare DMAC driver. The controller is usually
used in the Intel hardware such as Intel Medfield.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
Acked-by: Arnd Bergmann a...@arndb.de
Acked-by: Viresh Kumar viresh.ku...@linaro.org
---
drivers/dma
To simplify the driver development let's split driver to library and platform
code parts. It helps us to add PCI driver in future.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
Acked-by: Arnd Bergmann a...@arndb.de
Acked-by: Viresh Kumar viresh.ku...@linaro.org
---
drivers/dma
The dw_dmac driver is going to be split into multiple files. To make this more
convenient move it to an own directory.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
Acked-by: Viresh Kumar viresh.ku...@linaro.org
Acked-by: Arnd Bergmann a...@arndb.de
---
MAINTAINERS
On Mon, Jun 3, 2013 at 3:26 PM, Joe Perches j...@perches.com wrote:
On Mon, 2013-06-03 at 11:16 +0300, Andy Shevchenko wrote:
On Sun, 2013-06-02 at 19:06 -0700, Joe Perches wrote:
On Mon, 2013-06-03 at 11:59 +1000, Ryan Mallon wrote:
On 31/05/13 19:27, Andy Shevchenko wrote
To support some (legacy) firmwares and platforms let's make life easier for
their customers.
This patch extracts SFI GPIO API from arch/x86/platform/mrst/mrst.c.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
Acked-by: Len Brown len.br...@intel.com
Cc: Grant Likely grant.lik
On Wed, Jun 5, 2013 at 8:25 PM, Guennadi Liakhovetski
g.liakhovet...@gmx.de wrote:
On Wed, 5 Jun 2013, Will Deacon wrote:
On Mon, May 27, 2013 at 08:11:07AM +0100, Andy Shevchenko wrote:
On Fri, 2013-05-24 at 23:55 +0200, Guennadi Liakhovetski wrote:
On Thu, 23 May 2013, Andy Shevchenko
On Thu, Jun 6, 2013 at 6:09 AM, Xiang Wang wangx...@gmail.com wrote:
2013/6/3 Andy Shevchenko andy.shevche...@gmail.com:
On Mon, Jun 3, 2013 at 6:22 AM, Xiang Wang wangx...@gmail.com wrote:
2013/5/31 Andy Shevchenko andy.shevche...@gmail.com:
On Fri, May 31, 2013 at 11:21 AM, Xiang Wang wangx
()?
+
+
+exit:
+ return ret;
Remove those two and empty lines.
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
);
...
}
or some variant thereof.
What the problem to use list_for_each_safe()?
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
understand why it so?
If it wrong approach, than probably you have to change **ptr - *ptr.
But without answer on first question I don't know if it proper solution or not.
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body
On Thu, Jun 6, 2013 at 9:12 PM, Jörn Engel jo...@logfs.org wrote:
On Thu, 6 June 2013 22:32:55 +0300, Andy Shevchenko wrote:
On Mon, Jun 3, 2013 at 8:28 PM, Joern Engel jo...@logfs.org wrote:
I have seen a lot of boilerplate code that either follows the pattern of
while (!list_empty
Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
by passing the client name.
Why ISP driver would like to register sensor drivers in the first place?
That seems the task of platform code, or DT, or ACPI5
Why do you need to re-register them at run time?
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line
)
present, so to keep the footprint low, add this small variant to the
pltfm driver.
My comments against v1 of this patch are still valid.
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord
transfer, be it successful or not.
This patch requires https://patchwork.kernel.org/patch/2601241/ to be
applied first.
What if you just move disabling code from i2c_dw_xfer_init() to the
top of i2c_dw_xfer() ?
Will it help?
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send
)
pci_trim_stale_devices(child);
}
+}
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http
;
+ pci_trim_stale_devices(dev);
Perhaps
list_for_each_entry_safe(dev, tmp, bus-devices, bus_list) {
if (PCI_SLOT(dev-devfn) == slot-device)
pci_trim_stale_devices(dev);
}
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list
(ACPI_TYPE_DEVICE, handle, depth,
pcihp_evaluate_rmv,
+ NULL, removable, NULL);
+ return !!removable;
+}
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
On Tue, Jun 25, 2013 at 9:31 PM, Mika Westerberg
mika.westerb...@linux.intel.com wrote:
On Tue, Jun 25, 2013 at 09:15:47PM +0300, Andy Shevchenko wrote:
On Tue, Jun 25, 2013 at 7:22 PM, Mika Westerberg
mika.westerb...@linux.intel.com wrote:
[]
+static acpi_status pcihp_evaluate_rmv
On Tue, Jun 25, 2013 at 9:51 PM, Mika Westerberg
mika.westerb...@linux.intel.com wrote:
On Tue, Jun 25, 2013 at 09:31:52PM +0300, Andy Shevchenko wrote:
I think it is better to remove the first value check from the
pcihp_evaluate_rmv() and keep the check here.
I'll fix that in the next
to add something else to 'out' path?
Otherwise I think it will look better if you do return instead of
[useless] gotos.
--
Andy Shevchenko andriy.shevche...@linux.intel.com
Intel Finland Oy
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord
, it should go to the
platform code / board file under arch/x86/platform/minnow/...
--
Andy Shevchenko andriy.shevche...@linux.intel.com
Intel Finland Oy
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info
: ..., __func__, ...'.
Cong, I don't think is a good idea to update lib/ code and net/ code in
one patch, since that are logically a bit different. lib/ code sounds
more common, it's better if it leads separately this series.
--
Andy Shevchenko andriy.shevche...@linux.intel.com
Intel Finland Oy
On Wed, 2013-06-26 at 09:21 -0700, Darren Hart wrote:
On Wed, 2013-06-26 at 10:55 +0300, Andy Shevchenko wrote:
+ out:
+ return err;
Are you planning to add something else to 'out' path?
Otherwise I think it will look better if you do return instead of
[useless] gotos.
I
On Tue, May 28, 2013 at 11:00 PM, Nikolay Balandin
n.a.balan...@gmail.com wrote:
From: Nikolay Balandin nbalan...@dev.rtsoft.ru
Use devm_kzalloc to make cleanup paths simpler
Signed-off-by: Nikolay Balandin nbalan...@dev.rtsoft.ru
Reviewed-by: Andy Shevchenko andy.shevche...@gmail.com
On Tue, May 28, 2013 at 11:01 PM, Nikolay Balandin
n.a.balan...@gmail.com wrote:
From: Nikolay Balandin nbalan...@dev.rtsoft.ru
Use devm_kzalloc to make cleanup paths simpler
Signed-off-by: Nikolay Balandin nbalan...@dev.rtsoft.ru
Reviewed-by: Andy Shevchenko andy.shevche...@gmail.com
On Wed, May 29, 2013 at 1:56 PM, Laxman Dewangan ldewan...@nvidia.com wrote:
On Monday 27 May 2013 05:44 PM, Andy Shevchenko wrote:
Accordingly to dma_cookie_status() description locking is not required.
I think we need lock here:
From isr handler, we call dma_cookie_complete() which
On Tue, May 28, 2013 at 10:47 PM, Steven Rostedt rost...@goodmis.org wrote:
hex_string() had a typo in a comment.
Signed-off-by: Steven Rostedt rost...@goodmis.org
Acked-by: Andy Shevchenko andy.shevche...@gmail.com
Index: linux-trace.git/lib/vsprintf.c
;
No need to keep those pointers since you may use debugfs_remove_recursive().
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
@@ -273,7 +273,7 @@ enum rsxx_hw_fifo_flush {
};
enum rsxx_pci_revision {
- RSXX_DISCARD_SUPPORT = 2,
+ RSXX_DISCARD_SUPPORT = 4,
RSXX_EEH_SUPPORT = 3,
Shouldn't it be sorted from low to high?
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list
) {
+ sync_timeout = SYNC_START_TIMEOUT;
+
+ dev_info(CARD_TO_DEV(card),
+Waiting for card to startup\n);
+
+ do {
+ ssleep(1);
Why not timers?
--
With Best Regards,
Andy Shevchenko
that we recover if such an error is the reason
+* for the timeout.
+*/
+ ioread32(card-regmap + SCRATCH);
This is just a dummy read, right? Perhaps you may add this word to the
explanation.
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from
2 pure_initcall
3 arch_initcall
14 postcore_initcall
29 subsys_initcall)
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
up to do.
Otherwise I don't think we have to touch that driver at all.
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
to set this.
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
.
Hi Jiri, Benjamin.
What do you think about patch I just sent?
P.S. Benjamin, I re-used your commit message, I think you have no objections.
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord
resources when driver is removed.
Signed-off-by: Andy Shevchenko andy.shevche...@gmail.com
Reported-by: Benjamin Tissoires benjamin.tissoi...@redhat.com
---
drivers/hid/hid-multitouch.c | 37 +
1 files changed, 13 insertions(+), 24 deletions(-)
diff --git a/drivers
On Thu, May 30, 2013 at 10:57 AM, Geert Uytterhoeven
ge...@linux-m68k.org wrote:
On Tue, May 28, 2013 at 5:53 PM, Andy Shevchenko
andriy.shevche...@linux.intel.com wrote:
diff --git a/arch/cris/arch-v10/kernel/kgdb.c
b/arch/cris/arch-v10/kernel/kgdb.c
index 37e6d2c..07bccd8 100644
Drop this one away, Sathyanarayanan Kuppuswamy takes care about it in
his patchset.
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
Drop this one away, Sathyanarayanan Kuppuswamy takes care about it in
his patchset.
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
)
-{
- platform_driver_unregister(bcma_sflash_driver);
-}
-
-module_init(bcm47xxsflash_init);
-module_exit(bcm47xxsflash_exit);
+module_platform_driver(bcma_sflash_driver);
--
1.7.1
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line unsubscribe linux-kernel
plan to use this driver somewhere outside of Nokia n900 device?
If so, there is more than this clean up to do.
Otherwise I don't think we have to touch that driver at all.
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body
);
+ if (ret ret != -ENODEV)
From the discussion of dw_dmac I remember we decide that ENODEV check
is redundant.
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More
On Thu, May 30, 2013 at 8:47 PM, Vinod Koul vinod.k...@intel.com wrote:
On Mon, May 27, 2013 at 03:14:30PM +0300, Andy Shevchenko wrote:
Here is a set of small independent patches that clean up or fix minor things
across DMA slave drivers.
The series looks fine. I am going to wait a day more
at http://www.tux.org/lkml/
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org
On Thu, 2013-05-30 at 19:25 +0200, Linus Walleij wrote:
On Wed, May 22, 2013 at 12:20 PM, Andy Shevchenko
andriy.shevche...@linux.intel.com wrote:
This makes the error handling much more simpler than open-coding everything
and
in addition makes the probe function smaller an tidier
Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
On Thu, May 30, 2013 at 5:45 AM, Sathyanarayanan Kuppuswamy
sathyanarayanan.kuppusw...@intel.com wrote:
From: Andy Shevchenko andriy.shevche...@linux.intel.com
Can you use newer version [1] of this patch?
[1] https://lkml.org/lkml/2013/5/28/83
--
With Best Regards,
Andy Shevchenko
Please, drop this one away.
Sathyanarayanan Kuppuswamy will take care of this in his patch series.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
()
return status
Because there is no reason to return residue of successfully finished
transfer. It should be 0.
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info
multiple boards and devices.
Patch 1 - 5 fixes some indentation issue, compiler warnings and renames.
Patch 6 - 13 refactors mrst code.
First of all, please, remove Gerrit IDs from the commit messages.
Andy Shevchenko (2):
sfi: fix compiler warnings
gpiolib: append SFI helpers for GPIO
To support some (legacy) firmwares and platforms let's make life easier for
their customers.
This patch extracts SFI GPIO API from arch/x86/platform/mrst/mrst.c.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
Acked-by: Len Brown len.br...@intel.com
Cc: Grant Likely grant.lik
On Fri, May 31, 2013 at 3:01 PM, Linus Walleij linus.wall...@linaro.org wrote:
On Wed, May 22, 2013 at 12:20 PM, Andy Shevchenko
andriy.shevche...@linux.intel.com wrote:
Otherwise we will end up with traceback from LOCKDEP:
Andy do you consider this a regression that needs to go into fixes
The dw_dmac driver is going to be split into multiple files. To make this more
convenient move it to an own directory.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
---
MAINTAINERS | 3 +--
drivers/dma/Kconfig | 20
501 - 600 of 17509 matches
Mail list logo
