This is first attempt to do split as suggested by Arnd et al.
First patch moves driver to its own folder.
Second one does the actual split.
During this files are renamed: mostly means that dw_dmac prefix is eliminated.
I hope to get it ready to be included in v3.11.
Andy Shevchenko (2):
dma
To simplify the driver development let's split driver to library and platform
code parts. It helps us to add PCI driver in future.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
---
drivers/dma/Makefile | 2 +-
drivers/dma/dw/Kconfig
);
And what is the level of this message? debug?
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ
not a case here).
Please, do not do such changes without good argumets.
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
.
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
specifier
which is available from v3.8(?).
Something like this:
dma_addr_t src_addr;
dev_dbg(dev, DMA addr: %pa\n, src_addr);
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More
On Thu, May 30, 2013 at 4:28 PM, Benjamin Tissoires
benjamin.tissoi...@gmail.com wrote:
On Wed, May 29, 2013 at 10:12 PM, Andy Shevchenko
andy.shevche...@gmail.com wrote:
mt_free_input_name() was never called during .remove(): hid_hw_stop()
removes the hid_input items in hdev-inputs, and so
On Sat, Jun 1, 2013 at 1:39 AM, Randy Dunlap rdun...@infradead.org wrote:
On 05/31/13 15:34, Andy Shevchenko wrote:
On Fri, May 31, 2013 at 11:22 PM, Emil Goode emilgo...@gmail.com wrote:
This patch fixes a format specifier warning. dma_addr_t can be either
u32 or u64 so we should cast
.
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
-charger_reference_current_ma)
return -ENODEV;
- ret = strict_strtoul(buf, 10, ma);
+ ret = kstrtoul(buf, 10, ma);
if (ret)
return -EINVAL;
Ditto.
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line unsubscribe linux
;
if (user_reg 0xff)
Same idea here.
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ
) || kstrtoul(buffer, 10, val))
return -EINVAL;
I see no harm to allow user to write octal values as well.
Thus, just
ret = kstrtoul(r-name, 0, reg);
if (ret)
return ret;
Alessandro, what do you think?
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send
enable;
int ret;
- ret = strict_strtoul(buf, 0, enable);
+ ret = kstrtoul(buf, 0, enable);
if (ret) {
dev_err(priv-dev, unable to parse enable input\n);
return -EINVAL;
return ret;
--
With Best Regards,
Andy Shevchenko
); \
} while (0)
-#define pkt_err(pd, fmt, ...) \
- pr_err(%s: fmt, pd-name, ##__VA_ARGS__)
May be put this in the right place before?
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line unsubscribe linux-kernel
On Sun, 2013-06-02 at 19:06 -0700, Joe Perches wrote:
On Mon, 2013-06-03 at 11:59 +1000, Ryan Mallon wrote:
On 31/05/13 19:27, Andy Shevchenko wrote:
Some trivial coding style comment below.
Thank you, Joe, for commenting this.
+ for (i = 0; i sfi_gpio_num_entry; i++, pentry
On Mon, 2013-06-03 at 10:25 +0530, Viresh Kumar wrote:
On 31 May 2013 21:20, Andy Shevchenko andriy.shevche...@linux.intel.com
wrote:
diff --git a/drivers/dma/Makefile b/drivers/dma/Makefile
+obj-$(CONFIG_DW_DMAC) += dw/
+++ b/drivers/dma/dw/Makefile
+obj-$(CONFIG_DW_DMAC
);
Too many braces.
It is not a macro, you don't need to embrace reg.
+ writel(0, pchan-phy-base + reg);
+
spin_lock_irqsave(pdev-phy_lock, flags);
pchan-phy-vchan = NULL;
pchan-phy = NULL;
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list
On Mon, Jun 3, 2013 at 12:23 PM, Chen Gang gang.c...@asianux.com wrote:
On 06/01/2013 05:05 AM, Andy Shevchenko wrote:
Why not (u16)~0 ?
We'd better to give a meaningful name to it just like Ben said.
Yeah, you could give a name, though I don't see this needs for
constants like (u16)~0. It's
On Mon, Jun 3, 2013 at 12:04 PM, Jingoo Han jg1@samsung.com wrote:
The usage of strict_strtoul() is not preferred, because
strict_strtoul() is obsolete. Thus, kstrtoul() should be
used.
Few comments below.
After addressing them take my
Reviewed-by: Andy Shevchenko andriy.shevche
did it.
If you're happy I'll take the patch.
Not fully. But there are few minor things which I believe Jingoo will
easily fix soon.
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
On Mon, Jun 3, 2013 at 12:05 PM, Jingoo Han jg1@samsung.com wrote:
The usage of strict_strtoul() is not preferred, because
strict_strtoul() is obsolete. Thus, kstrtoul() should be
used.
Signed-off-by: Jingoo Han jg1@samsung.com
Looks better.
Reviewed-by: Andy Shevchenko
Reviewed-by: Andy Shevchenko andriy.shevche...@linux.intel.com
--- a/drivers/misc/isl29003.c
+++ b/drivers/misc/isl29003.c
@@ -208,8 +208,9 @@ static ssize_t isl29003_store_range(struct device *dev,
unsigned long val;
int ret;
- if ((strict_strtoul(buf, 10, val) 0
On Mon, Jun 3, 2013 at 12:07 PM, Jingoo Han jg1@samsung.com wrote:
The usage of strict_strtoul() is not preferred, because
strict_strtoul() is obsolete. Thus, kstrtoul() should be
used.
There is an issue, after fixing it take my
Reviewed-by: Andy Shevchenko andriy.shevche
to assign transport_header here as well?
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http
On Mon, Jun 3, 2013 at 6:22 AM, Xiang Wang wangx...@gmail.com wrote:
2013/5/31 Andy Shevchenko andy.shevche...@gmail.com:
On Fri, May 31, 2013 at 11:21 AM, Xiang Wang wangx...@gmail.com wrote:
In some of our drivers (e.g. UART) we may stop a running DMA
before it finishes. So we need to know
On Mon, 2013-06-03 at 10:35 +0530, Viresh Kumar wrote:
On 31 May 2013 21:20, Andy Shevchenko andriy.shevche...@linux.intel.com
wrote:
This is first attempt to do split as suggested by Arnd et al.
First patch moves driver to its own folder.
Second one does the actual split.
During
On Mon, 2013-06-03 at 18:42 +0530, Viresh Kumar wrote:
On 3 June 2013 17:55, Andy Shevchenko andriy.shevche...@linux.intel.com
wrote:
In patch 2/2 I collect platform related code. I see a lot of #ifdefs
related to OF and ACPI. I would like to split it further and create
files like of.c
On Mon, Apr 22, 2013 at 8:56 AM, Vinod Koul vinod.k...@intel.com wrote:
On Tue, Apr 16, 2013 at 08:11:57PM +0200, Rafael J. Wysocki wrote:
On Tuesday, April 16, 2013 03:14:47 PM Andy Shevchenko wrote:
On Mon, 2013-04-15 at 22:06 +0530, Vinod Koul wrote:
On Tue, Apr 09, 2013 at 02:05:42PM
This fixes iff as if.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
---
lib/string.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/string.c b/lib/string.c
index e5878de..e551284 100644
--- a/lib/string.c
+++ b/lib/string.c
@@ -542,7 +542,7
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
---
drivers/pnp/isapnp/core.c | 5 +
drivers/pnp/pnpbios/proc.c | 5 ++---
2 files changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers/pnp/isapnp/core.c b/drivers/pnp/isapnp/core.c
index 918d5f0..f380bcf 100644
Additionally change cast from long to unsigned long to follow specificator.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
---
include/trace/events/9p.h | 28 +++-
1 file changed, 3 insertions(+), 25 deletions(-)
diff --git a/include/trace/events/9p.h b
We have mac_pton() helper to parse MAC addresses.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
---
drivers/misc/pch_phub.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/misc/pch_phub.c b/drivers/misc/pch_phub.c
index 931e635..8b4d4fb
Instead of pronting buffer byte-by-byte let's use native specificator to do the
job.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
---
drivers/pnp/pnpbios/proc.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/pnp/pnpbios/proc.c b/drivers/pnp
There are couple of #if 0's to avoid debug printing. Let's remove them as
Rafael suggested.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
---
drivers/pnp/isapnp/core.c | 11 ---
1 file changed, 11 deletions(-)
diff --git a/drivers/pnp/isapnp/core.c b/drivers/pnp
On Tue, Apr 23, 2013 at 3:40 PM, Tetsuo Handa
penguin-ker...@i-love.sakura.ne.jp wrote:
Commit a4b6a77b module: fix symbol versioning with symbol prefixes broke
loading of net/ipv6/ipv6.ko
I would rephrase this to any module uses memcmp, e.g. ipv6
Otherwise: Reviewed-by: Andy Shevchenko
be a fix for 3.9/stable but a better way to do this
would be much more appreciated.
What about my proposal to supply parameters for __builtin_memcmp in
memcmp macro.
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body
first analysis.
Signed-off-by: James Hogan james.ho...@imgtec.com
Cc: Rusty Russell ru...@rustcorp.com.au
Cc: Andy Shevchenko andriy.shevche...@linux.intel.com
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message
It works
Tested-by: Andy Shevchenko andriy.shevche...@linux.intel.com
On Wed, Apr 24, 2013 at 1:13 PM, James Hogan james.ho...@imgtec.com wrote:
On 24/04/13 02:00, H. Peter Anvin wrote:
On 04/23/2013 05:52 PM, H. Peter Anvin wrote:
On 04/23/2013 05:40 AM, Tetsuo Handa wrote:
Commit a4b6a77b
finding a match.
*/
And this is correct because ... ?
So, in this case it means if and only if, true?
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info
On Wed, Apr 24, 2013 at 7:24 PM, Jiri Kosina jkos...@suse.cz wrote:
On Wed, 24 Apr 2013, Andy Shevchenko wrote:
- * This routine returns 0 iff the first character is one of 'Yy1Nn0'.
+ * This routine returns 0 if the first character is one of 'Yy1Nn0'.
* Otherwise it will return -EINVAL
devm_ioremap_resource() will print a message if resource is not found.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
---
drivers/dma/dw_dmac.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c
index 2e5deaa
like the result of the following will be the same
depends on (SPI_MASTER !I2C) || I2C
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
(0x14)
+#define TPM_INT_STATUS (0x10)
+#define TPM_INT_ENABLE (0x08)
What the point to embrace those constants?
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord
This one I like a bit more.
Reviewed-by: Andy Shevchenko andy.shevche...@gmail.com
On Sun, May 19, 2013 at 2:11 PM, Axel Lin axel@ingics.com wrote:
This patch fixes below build error when CONFIG_SPI_MASTER=y CONFIG_I2C=m
CONFIG_GPIO_MCP23S08=y.
LD init/built-in.o
drivers/built
and net-next.
Good. May be you are also interesting to run / contribute to the
codespell tool [1].
[1] https://github.com/lucasdemarchi/codespell
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord
devm_ioremap_resource does sanity checks on the given resource. No need to
duplicate this in the driver.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
---
Since v1:
- fix commit message to be along with other similar patches
drivers/dma/dw_dmac.c | 5 +
1 file changed, 1
for the report.
Unfortunately neither me nor other guys in the team could not reproduce
mentioned issue on our hardware.
Nevertheless I will try to allocate time and suggest possible fix if any
comes to my mind. So, your testing and analysis is appreciated.
--
Andy Shevchenko andriy.shevche
called fake
PCI devices are gone.
This is a bad approach and patch should be reverted. Bin, please,
explain what you are trying to fix and on what device. We will find
better solution.
P.S. Keep me in Cc list.
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line
On Tue, 2013-05-14 at 10:24 +0530, Vinod Koul wrote:
On Wed, May 08, 2013 at 11:55:47AM +0300, Andy Shevchenko wrote:
This is the rest of patch series related to ACPI DMA helpers and Lynxpoint
DMAC.
Patches are rebased against current Linus' tree and Vinod's branch
for-linus
There is locking bug fix and few amendments. Each commit message verbose
enoough I think.
Andy Shevchenko (4):
gpio-langwell: initialize lock before usage
gpio-langwell: amend error messages
gpio-langwell: do not use direct access to iomapped memory
gpio-langwell: use managed functions
This makes the error handling much more simpler than open-coding everything and
in addition makes the probe function smaller an tidier.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
---
drivers/gpio/gpio-langwell.c | 78
1 file
] pci_device_probe+0x5a/0x92
...
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
---
drivers/gpio/gpio-langwell.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpio/gpio-langwell.c b/drivers/gpio/gpio-langwell.c
index 62ef10a..c1f33dd 100644
--- a/drivers
Instead of hardcoded names let's use __func__ macro.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
---
drivers/gpio/gpio-langwell.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/gpio/gpio-langwell.c b/drivers/gpio/gpio-langwell.c
index
We better to use readl() function instead of bad looking direct access.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
---
drivers/gpio/gpio-langwell.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/gpio/gpio-langwell.c b/drivers/gpio
managed to reproduce it with
help of your script. I'm about to send the patch. I will appreciate to
collect a Tested-by tags in case it solves the issue.
--
Andy Shevchenko andriy.shevche...@linux.intel.com
Intel Finland Oy
--
To unsubscribe from this list: send the line unsubscribe linux-kernel
for this, though it doesn't
increase the counter of the failed tests.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
Reported-by: Will Deacon will.dea...@arm.com
---
drivers/dma/dmatest.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/drivers/dma/dmatest.c b/drivers/dma
On Tue, May 21, 2013 at 6:11 PM, Will Deacon will.dea...@arm.com wrote:
Hi Andy,
On Tue, May 21, 2013 at 01:33:17PM +0100, Andy Shevchenko wrote:
When thread is going to be stopped we have to unconditionally terminate all
ongoing transfers. Otherwise it would be possible that callback
On Tue, May 21, 2013 at 8:23 PM, David Cohen david.a.co...@intel.com wrote:
On 05/21/2013 03:33 AM, Andy Shevchenko wrote:
There is locking bug fix and few amendments. Each commit message verbose
enoough I think.
Andy Shevchenko (4):
gpio-langwell: initialize lock before usage
gpio
This makes the error handling much more simpler than open-coding everything and
in addition makes the probe function smaller an tidier.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
---
drivers/gpio/gpio-langwell.c | 82
1 file
There is locking bug fix and few amendments. Each commit message verbose
enoough I think.
Since v1:
- patch 2/4 (amend error messages) moved to 4/4
- minor fix in patch 3/4 (use managed ...)
- fix patch 4/4 (amend error messages) to be real amendment
Andy Shevchenko (4):
gpio-langwell
There is no need to use hardcoded device name in the error messages, because
dev_err() prefixes the message with the device name anyway.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
---
drivers/gpio/gpio-langwell.c | 10 --
1 file changed, 4 insertions(+), 6 deletions
] pci_device_probe+0x5a/0x92
...
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
---
drivers/gpio/gpio-langwell.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpio/gpio-langwell.c b/drivers/gpio/gpio-langwell.c
index 62ef10a..c1f33dd 100644
--- a/drivers
We better to use readl() function instead of bad looking direct access.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
---
drivers/gpio/gpio-langwell.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/gpio/gpio-langwell.c b/drivers/gpio
On Wed, May 22, 2013 at 11:05 AM, Mika Westerberg
mika.westerb...@linux.intel.com wrote:
On Wed, May 22, 2013 at 10:47:38AM +0300, Andy Shevchenko wrote:
This makes the error handling much more simpler than open-coding everything
and
in addition makes the probe function smaller an tidier
(amend error messages) to be real amendment
Andy Shevchenko (5):
gpio-langwell: initialize lock before usage
gpio-langwell: do not use direct access to iomapped memory
gpio-langwell: use managed functions pcim_* and devm_*
gpio-langwell: amend error messages
gpio-langwell: drop away
We better to use readl() function instead of bad looking direct access.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
Acked-by: Mika Westerberg mika.westerb...@linux.intel.com
---
drivers/gpio/gpio-langwell.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions
Since the type of the reg_base member is void __iomem * we don't need to have
explicit casting in gpio_reg() and gpio_reg_2bit().
Update year in the copyright notice as well.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
---
drivers/gpio/gpio-langwell.c | 12
1
There is no need to use hardcoded device name in the error messages, because
dev_err() prefixes the message with the device name anyway.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
Acked-by: Mika Westerberg mika.westerb...@linux.intel.com
---
drivers/gpio/gpio-langwell.c
This makes the error handling much more simpler than open-coding everything and
in addition makes the probe function smaller an tidier.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
---
drivers/gpio/gpio-langwell.c | 79
1 file
] pci_device_probe+0x5a/0x92
...
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
Acked-by: Mika Westerberg mika.westerb...@linux.intel.com
---
drivers/gpio/gpio-langwell.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpio/gpio-langwell.c b/drivers/gpio
Since 0998d06310 device-core: Ensure drvdata = NULL when no driver is bound,
this is done by driver core after device_release or on probe failure. Thus we
can remove all platform_set_drvdata(pdev, NULL) in drivers.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
---
drivers/gpio
On Wed, May 22, 2013 at 3:41 PM, Will Deacon will.dea...@arm.com wrote:
On Tue, May 21, 2013 at 06:24:15PM +0100, Andy Shevchenko wrote:
On Tue, May 21, 2013 at 6:11 PM, Will Deacon will.dea...@arm.com wrote:
I now observe buffer verification failures in subsequent
test runs after an aborted
this one. Try to find better way to drag pointer.
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ
On Thu, May 23, 2013 at 1:09 PM, Vinod Koul vinod.k...@intel.com wrote:
On Tue, May 21, 2013 at 08:24:15PM +0300, Andy Shevchenko wrote:
On Tue, May 21, 2013 at 6:11 PM, Will Deacon will.dea...@arm.com wrote:
On Tue, May 21, 2013 at 01:33:17PM +0100, Andy Shevchenko wrote:
When thread
On Thu, May 23, 2013 at 1:19 PM, Vinod Koul vinod.k...@intel.com wrote:
On Tue, May 21, 2013 at 12:29:39PM +0300, Andy Shevchenko wrote:
On Tue, 2013-05-14 at 10:24 +0530, Vinod Koul wrote:
On Wed, May 08, 2013 at 11:55:47AM +0300, Andy Shevchenko wrote:
This is the rest of patch series
When user interrupts ongoing transfers the dmatest may end up with console
lockup, oops, or data mismatch. This patch prevents user to abort any ongoing
test.
Documentation is updated accordingly.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
Reported-by: Will Deacon will.dea
On Fri, 2013-05-24 at 23:55 +0200, Guennadi Liakhovetski wrote:
On Thu, 23 May 2013, Andy Shevchenko wrote:
When user interrupts ongoing transfers the dmatest may end up with console
lockup, oops, or data mismatch. This patch prevents user to abort any
ongoing
test.
Personally I
Accordingly to dma_cookie_status() description locking is not required.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
Cc: Li Yang le...@freescale.com
Cc: Zhang Wei z...@zh-kernel.org
Cc: linuxppc-...@lists.ozlabs.org
---
drivers/dma/fsldma.c | 10 +-
1 file changed, 1
last_used variable is applied only once, so, let's substitute it by its value.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
---
drivers/dma/mxs-dma.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/dma/mxs-dma.c b/drivers/dma/mxs-dma.c
index
There is no point to go throught the rest of the function if first call to
dma_cookie_status() returned DMA_SUCCESS.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
---
drivers/dma/txx9dmac.c | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git
It's better to use generic dma_cookie_status() that allows user to get standard
possible return codes independently of the DMAC driver in charge.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
Cc: Shawn Guo shawn@linaro.org
---
drivers/dma/ipu/ipu_idmac.c | 5 +
1 file
Accordingly to dma_cookie_status() description locking is not required.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
Cc: Stephen Warren swar...@wwwdotorg.org
Cc: linux-te...@vger.kernel.org
---
drivers/dma/tegra20-apb-dma.c | 8 +++-
1 file changed, 3 insertions(+), 5
Residue value is assigned to 0 by dma_cookie_status().
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
---
drivers/dma/edma.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/dma/edma.c b/drivers/dma/edma.c
index cd7e328..8e11499 100644
--- a/drivers/dma/edma.c
+++ b
dma_set_residue() sets only residue value, so user can't rely on the returned
values of cookies. That patch standardize the behaviour.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
---
drivers/dma/mmp_tdma.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
Accordingly to dma_cookie_status() description locking is not required.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
---
drivers/dma/pch_dma.c | 9 +
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/drivers/dma/pch_dma.c b/drivers/dma/pch_dma.c
index
last_used variable is applied only once, so, let's substitute it by its value.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
---
drivers/dma/imx-sdma.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
Accordingly to dma_cookie_status() description locking is not required.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
---
drivers/dma/mmp_pdma.c | 10 +-
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/drivers/dma/mmp_pdma.c b/drivers/dma/mmp_pdma.c
index
Accordingly to dma_cookie_status() description locking is not required.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
---
drivers/dma/mpc512x_dma.c | 10 +-
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/drivers/dma/mpc512x_dma.c b/drivers/dma
Accordingly to dma_cookie_status() description locking is not required.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
---
drivers/dma/ep93xx_dma.c | 10 +-
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/drivers/dma/ep93xx_dma.c b/drivers/dma/ep93xx_dma.c
Here is a set of small independent patches that clean up or fix minor things
across DMA slave drivers.
Andy Shevchenko (12):
imx-sdma: remove useless variable
mxs-dma: remove useless variable
edma: no need to assign residue to 0 explicitly
ep93xx_dma: remove useless use of lock
fsldma
On Wed, May 22, 2013 at 7:28 PM, David Cohen david.a.co...@intel.com wrote:
On 05/22/2013 03:20 AM, Andy Shevchenko wrote:
There is locking bug fix and few amendments. Each commit message verbose
enoough I think.
Since v2:
- apply ACKs
- addressed Mika's comment for patch 3/4
]
drivers/sfi/sfi_core.c:192:6: warning: no previous prototype for
‘sfi_unmap_table’ [-Wmissing-prototypes]
Indentation fixes are also included.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
---
drivers/sfi/sfi_acpi.c | 8
drivers/sfi/sfi_core.c | 4 ++--
include/linux
Let's use the common SFI helpers for GPIO API.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
Acked-by: Len Brown len.br...@intel.com
Cc: H. Peter Anvin h...@zytor.com
Cc: x...@kernel.org
---
arch/x86/platform/mrst/mrst.c | 94 ++-
1 file
To support some (legacy) firmwares and platforms let's make life easier for
their customers.
This patch extracts SFI GPIO API from arch/x86/platform/mrst/mrst.c.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
Acked-by: Len Brown len.br...@intel.com
Cc: Grant Likely grant.lik
On Tue, 2013-04-23 at 16:31 +0300, Andy Shevchenko wrote:
We have mac_pton() helper to parse MAC addresses.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
---
drivers/misc/pch_phub.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers
On Mon, 2013-04-22 at 16:01 +0300, Andy Shevchenko wrote:
Additionally change cast from long to unsigned long to follow specificator.
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com
---
include/trace/events/9p.h | 28 +++-
1 file changed, 3
On Tue, May 28, 2013 at 5:52 PM, Arnd Bergmann a...@arndb.de wrote:
depends on KMS_ARMCLCD != 'y'
depends on 'm' if KMS_ARMCLCD
Those two above could be one actually.
Just my 2 cents.
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line
\n, err);
- kfree(at25);
return err;
I believe there is no harm to remove 'fail' branch.
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
:
return err;
}
What about to switch to devm_* and remove those labels and kfrees at all?
Additionally you can add another patch to use module_platform_driver()
macro instead of module_init/exit.
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line
601 - 700 of 17509 matches
Mail list logo
