Re: [PATCH v2] usb: omap2430: fix memleak in err case

2013-05-28 Thread Andy Shevchenko
No go. Check the 4b7e450fb5cefb5865c77999a675330206ab3b8a And update you tree, please. -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH] dma: mmp_pdma: fix a memory alloc error

2013-05-28 Thread Andy Shevchenko
platform_device *op) } pdev-phy = devm_kzalloc(pdev-dev, - dma_channels * sizeof(struct mmp_pdma_chan), GFP_KERNEL); + dma_channels * sizeof(struct mmp_pdma_phy), GFP_KERNEL); For me it seems you did get how it works. -- With Best Regards, Andy

[PATCH] cris: kgdb: use native hex2bin

2013-05-28 Thread Andy Shevchenko
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- arch/cris/arch-v10/kernel/kgdb.c | 50 ++-- 1 file changed, 7 insertions(+), 43 deletions(-) diff --git a/arch/cris/arch-v10/kernel/kgdb.c b/arch/cris/arch-v10/kernel/kgdb.c index 37e6d2c

[PATCH] arch/cris: old patch to use hex2bin

2013-05-28 Thread Andy Shevchenko
Geert, would you like to add following patch to your tree as well? Andy Shevchenko (1): cris: kgdb: use native hex2bin arch/cris/arch-v10/kernel/kgdb.c | 50 ++-- 1 file changed, 7 insertions(+), 43 deletions(-) -- 1.8.2.rc0.22.gb3600c3 -- To unsubscribe

[PATCH, resend] pch_phub: re-use native MAC address parser

2013-05-28 Thread Andy Shevchenko
We have mac_pton() helper to parse MAC addresses. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Acked-by: Arnd Bergmann a...@arndb.de --- drivers/misc/pch_phub.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/misc/pch_phub.c b/drivers/misc

Re: [PATCH 1/2] HID: Add driver for Holtek gaming mouse 04d9:a067

2013-05-28 Thread Andy Shevchenko
version. + */ +module_exit(holtek_mouse_exit); +module_init(holtek_mouse_init); module_hid_driver() instead. -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH -next] dmaengine: ste_dma40: fix error return code in d40_probe()

2013-05-28 Thread Andy Shevchenko
; } -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ -- With Best Regards, Andy Shevchenko

Re: [PATCH] drivers: mfd: tps65912: Convert to use devm_kzalloc

2013-05-28 Thread Andy Shevchenko
-core.c:21: include/linux/device.h:574:14: note: expected ‘struct device *’ but argument is of type ‘struct device **’ -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH 1/1] drivers/misc: at2x: use devm_kzalloc() to make cleanup paths simpler

2013-05-28 Thread Andy Shevchenko
i2c_client *client) for (i = 1; i at24-num_addresses; i++) i2c_unregister_device(at24-client[i]); - Ditto. -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org

Re: [PATCH 30/51] DMA-API: dma: dw_dmac.c: convert to use dma_coerce_mask_and_coherent()

2013-09-20 Thread Andy Shevchenko
dma_mask (and should we do so by your opinion)? Additional question, who will free memory allocated for dma_mask in case if it was allocated, dma_mask initialized and then your code just substitute the address to some new value? -- Andy Shevchenko andriy.shevche...@linux.intel.com Intel Finland Oy

Re: [PATCH 30/51] DMA-API: dma: dw_dmac.c: convert to use dma_coerce_mask_and_coherent()

2013-09-20 Thread Andy Shevchenko
On Fri, Sep 20, 2013 at 5:40 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Fri, Sep 20, 2013 at 05:26:46PM +0300, Andy Shevchenko wrote: On Thu, 2013-09-19 at 22:55 +0100, Russell King wrote: This code sequence: if (!pdev-dev.dma_mask) { pdev-dev.dma_mask

[PATCH] arch: tile: re-use kbasename() helper

2013-09-27 Thread Andy Shevchenko
kbasename() returns the filename part of a pathname. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- arch/tile/kernel/stack.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/arch/tile/kernel/stack.c b/arch/tile/kernel/stack.c index 362284a

[PATCH 2/3] dmatest: remove IS_ERR_OR_NULL checks of debugfs calls

2013-07-23 Thread Andy Shevchenko
There is a really little chance when we are able to create a directory and are not able to create nodes under it. So, this patch just removes those checks. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/dma/dmatest.c | 17 + 1 file changed, 5

[PATCH 1/3] dmatest: make module parameters writable

2013-07-23 Thread Andy Shevchenko
writable and remove them from the debugfs. Though we're still using debugfs to control test runner and getting results. Documentation part is updated accordingly. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Suggested-by: Dan Williams d...@fb.com --- Documentation/dmatest.txt | 15

[PATCH 3/3] dmatest: print message on debug level in case of no error

2013-07-23 Thread Andy Shevchenko
Let's move the behaviour of printing no error message back to the pre v3.10 times. It means we will use debug level in the described case, and a warning level otherwise. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/dma/dmatest.c | 6 +- 1 file changed, 5

Re: [PATCH 1/2] HID: trivial devm conversion for special hid drivers

2013-07-24 Thread Andy Shevchenko
is the same for all patched drivers. -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http

Re: [PATCH 2/2] HID: multitouch: devm conversion

2013-07-24 Thread Andy Shevchenko
(hdev); - - kfree(td); - hid_set_drvdata(hdev, NULL); } static const struct hid_device_id mt_devices[] = { -- 1.8.3.1 -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

Re: [PATCH v2 1/2] HID: trivial devm conversion for special hid drivers

2013-07-24 Thread Andy Shevchenko
kzalloc in the driver - the .remove() callback contains only one kfree on top of hid_hw_stop() - the error path in the probe is easy enough to be manually checked Reviewed-by: Andy Shevchenko andy.shevche...@gmail.com Signed-off-by: Benjamin Tissoires benjamin.tissoi...@redhat.com --- drivers

Re: [PATCH] staging: rtl8712: fix potential leak in r871x_wx_set_enc_ext()

2014-05-07 Thread Andy Shevchenko
, IEEE_CRYPT_ALG_NAME_LEN); if (pext-ext_flags IW_ENCODE_EXT_GROUP_KEY) param-u.crypt.set_tx = 0; -- Andy Shevchenko andriy.shevche...@linux.intel.com Intel Finland Oy -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

Re: [PATCHv2 0/4] ACPI / LPSS: Solution for two issues seen on Asus T100

2014-05-15 Thread Andy Shevchenko
changed, 349 insertions(+), 28 deletions(-) create mode 100644 drivers/clk/clk-fractional-divider.c -- Andy Shevchenko andriy.shevche...@intel.com Intel Finland Oy -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org

Re: [PATCHv2 0/4] ACPI / LPSS: Solution for two issues seen on Asus T100

2014-05-16 Thread Andy Shevchenko
On Fri, 2014-05-16 at 07:29 +0800, Li, Aubrey wrote: On 2014/5/16 0:11, Mika Westerberg wrote: On Thu, May 15, 2014 at 11:59:46PM +0800, Li, Aubrey wrote: On 2014/5/15 22:53, Andy Shevchenko wrote: On Thu, 2014-05-15 at 22:35 +0800, Li, Aubrey wrote: On 2014/5/15 21:40, Heikki Krogerus

Re: [PATCHv2 0/4] ACPI / LPSS: Solution for two issues seen on Asus T100

2014-05-16 Thread Andy Shevchenko
On Fri, 2014-05-16 at 21:37 +0800, Li, Aubrey wrote: On 2014/5/16 15:04, Andy Shevchenko wrote: On Fri, 2014-05-16 at 07:29 +0800, Li, Aubrey wrote: On 2014/5/16 0:11, Mika Westerberg wrote: On Thu, May 15, 2014 at 11:59:46PM +0800, Li, Aubrey wrote: On 2014/5/15 22:53, Andy Shevchenko

Re: [PATCH] staging: rtl8712: fix potential leak in r871x_wx_set_enc_ext()

2014-05-13 Thread Andy Shevchenko
On Wed, 2014-05-07 at 11:55 +0300, Dan Carpenter wrote: On Wed, May 07, 2014 at 09:55:47AM +0300, Andy Shevchenko wrote: @@ -1824,6 +1817,15 @@ static int r871x_wx_set_enc_ext(struct net_device *dev, default: return -EINVAL; } + + param_len = sizeof(struct

[PATCH] lib.c: skip --param parameters

2014-06-16 Thread Andy Shevchenko
Very dumb patch to just skip --param allow-store-data-races=0 introduced in newest Linux kernel buildsystem. Actually the option is present in few GCC versions and probably should be handled properly. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- lib.c | 7 +++ 1 file

Re: [PATCH] lib.c: skip --param parameters

2014-06-17 Thread Andy Shevchenko
On Mon, 2014-06-16 at 09:02 -0700, Josh Triplett wrote: On Mon, Jun 16, 2014 at 01:43:06PM +0300, Andy Shevchenko wrote: Very dumb patch to just skip --param allow-store-data-races=0 introduced in newest Linux kernel buildsystem. Actually the option is present in few GCC versions

[PATCH v2 1/2] lib.c: introduce split_value_from_arg helper

2014-06-17 Thread Andy Shevchenko
The function tries to split a key / value from the given argument where delimiter can be either ' ' (space) or '=' (equal sign). It will be useful later as well. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- lib.c | 23 ++- 1 file changed, 14

[PATCH v2 0/2] fix for --param GCC's command line option

2014-06-17 Thread Andy Shevchenko
There is a dumb fix to avoid --param option and make sparse survive. Since v1: - added patch 1/2 - handle both --param=* and --param * Andy Shevchenko (2): lib.c: introduce split_value_from_arg helper lib.c: skip --param parameters lib.c | 38 -- 1

[PATCH v2 2/2] lib.c: skip --param parameters

2014-06-17 Thread Andy Shevchenko
. Instead of exact keyword it will recognize anything starting with --version as a correct option. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- lib.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/lib.c b/lib.c index 4e5a846..d5b94c3

Re: [PATCH] staging: rtl8712: remove _malloc()

2014-06-02 Thread Andy Shevchenko
); -- Andy Shevchenko andriy.shevche...@intel.com Intel Finland Oy -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org

Re: [PATCH v2] dma: Add Xilinx AXI Video Direct Memory Access Engine driver support

2014-01-23 Thread Andy Shevchenko
'dma/xilinx' as Xilinx has two more DMA IPs and we are also planning to upstream these drivers soon. 2. Rebased on v3.13.0-rc8 Changes in v2: - Removed DMA Test client module from the patchset as suggested by Andy Shevchenko - Removed device-id DT property, as suggested by Arnd

Re: [PATCH v2] dma: Add Xilinx AXI Video Direct Memory Access Engine driver support

2014-01-23 Thread Andy Shevchenko
the tasklet. So, you mean devm_request_irq() will race in any DMA driver? I think the proper solution is to disable all device work in the .remove() and devm will care about resources. majordomo-info.html -- Andy Shevchenko andriy.shevche...@linux.intel.com Intel Finland Oy -- To unsubscribe from

Re: [PATCHv10] dmaengine: Add support for BCM2835

2014-01-07 Thread Andy Shevchenko
an additional API change (DMA_SUCCESS). Andy: I would be happy to have your Reviewed-by again, but I removed it because of these changes. Sure. Couple of minor comments below, anyway still seems okay for me: Reviewed-by: Andy Shevchenko andriy.shevche...@linux.intel.com Changes compared

Re: [PATCH 1/2] Documentation: move all DMA documentations into Documentaion/dma

2014-01-16 Thread Andy Shevchenko
and resend? P.S. hint for future is to use -M -C when you rename files. -- Andy Shevchenko andriy.shevche...@linux.intel.com Intel Finland Oy -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: Baytrail problems (was Re: Linux 3.13-rc8)

2014-01-16 Thread Andy Shevchenko
been working on the solution. This adds an interesting twist to the general statement that new PCI/ACPI IDs should go into stable BTW, maybe they should not always do that. -- Andy Shevchenko andriy.shevche...@linux.intel.com Intel Finland Oy -- To unsubscribe from this list: send the line

Re: [PATCH resend 1/2] Documentation: move all DMA documentations into Documentaion/dma

2014-01-16 Thread Andy Shevchenko
with that I give my Acked-by: Andy Shevchenko andriy.shevche...@linux.intel.com for the dmatest.txt part. Signed-off-by: Hongbo Zhang hongbo.zh...@freescale.com Cc: David S. Miller da...@redhat.com Cc: Richard Henderson r...@cygnus.com Cc: Jakub Jelinek ja...@redhat.com Cc: James E.J. Bottomley

Re: [PATCH] Add Xilinx AXI Video DMA Engine driver

2014-01-17 Thread Andy Shevchenko
| 629 What about to modify dmatest.c accordingly to your needs? I see no much sense to have another copy of that in the tree. -- Andy Shevchenko andriy.shevche...@linux.intel.com Intel Finland Oy -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

Re: [PATCH] dma: dw: Add suspend and resume handling for PCI mode DW_DMAC.

2014-01-27 Thread Andy Shevchenko
, summarize everything we discussed we have to: - provide suspend_late, resume_early callbacks in the DMA driver instead of *_noirq versions - ensure that all clients on our platforms follow the described scenario Chiau Ee, I think you may to change your patch accordingly. -- Andy Shevchenko

Re: [PATCH v13] dmaengine: Add MOXA ART DMA engine driver

2013-12-12 Thread Andy Shevchenko
driver); +MODULE_LICENSE(GPL v2); -- Andy Shevchenko andriy.shevche...@linux.intel.com Intel Finland Oy -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] SFI: fix compilation warnings

2013-12-09 Thread Andy Shevchenko
On Fri, 2013-12-06 at 01:51 +, Zheng, Lv wrote: From: linux-acpi-ow...@vger.kernel.org [mailto:linux-acpi-ow...@vger.kernel.org] On Behalf Of Rafael J. Wysocki Sent: Friday, December 06, 2013 10:01 AM To: Zheng, Lv Cc: Andy Shevchenko; Wysocki, Rafael J; linux-a...@vger.kernel.org

[PATCH v2] SFI: fix compilation warnings

2013-12-09 Thread Andy Shevchenko
-function-declaration] if (!acpi_table_parse(signature, handler)) ^ cc1: some warnings being treated as errors The patch add linux/acpi.h to the top of file. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- Changes to v2: - fix for build when ACPI=n, SFI=y drivers/sfi

[PATCH] SFI: remove wrong FSF address from the license

2013-12-09 Thread Andy Shevchenko
Remove old and currently wrong address of the FSF from license parts of the code. There is no functional change. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/sfi/sfi_acpi.c | 6 -- drivers/sfi/sfi_core.c | 6 -- drivers/sfi/sfi_core.h | 6

Re: [PATCH] SFI: remove wrong FSF address from the license

2013-12-09 Thread Andy Shevchenko
On Mon, 2013-12-09 at 18:43 +0900, Alex Courbot wrote: On 12/09/2013 06:32 PM, Andy Shevchenko wrote: Remove old and currently wrong address of the FSF from license parts of the code. The address is not wrong, it is just that you don't want to see it become wrong should it change

Re: [PATCH] gpiolib: return -ENOENT when no GPIO mapping exists

2013-12-09 Thread Andy Shevchenko
as fallback, do not replace the previous error */ - if (!IS_ERR(pdesc) || !desc) - desc = pdesc; + desc = gpiod_find(dev, con_id, idx, flags); } if (IS_ERR(desc)) { -- Andy Shevchenko andriy.shevche...@linux.intel.com Intel Finland Oy

Re: [PATCH v2] SFI: fix compilation warnings

2013-12-10 Thread Andy Shevchenko
: Andy Shevchenko [mailto:andriy.shevche...@linux.intel.com] Sent: Monday, December 09, 2013 5:09 PM To: Wysocki, Rafael J; linux-acpi @ vger . kernel . org; LKML; Zheng, Lv Cc: Andy Shevchenko Subject: [PATCH v2] SFI: fix compilation warnings When build kernel with make W=1 we get

Re: [PATCH v2] SFI: fix compilation warnings

2013-12-10 Thread Andy Shevchenko
of its users. I think the patch in the linux-pm/bleeding-edge queue can fix the issue you've reported: https://git.kernel.org/cgit/linux/kernel/git/rafael/linux-pm.git/commit/?h=bleeding-edgeid=c099eacbcaec4475936fbf73e499507728ce47e1 Seems okay for me: Tested-by: Andy Shevchenko

Re: [PATCH v2] gpiolib: return -ENOENT if no GPIO mapping exists

2013-12-10 Thread Andy Shevchenko
during the GPIO resolution. One minor comment below. Independently on that: Reviewed-by: Andy Shevchenko andriy.shevche...@linux.intel.com Signed-off-by: Alexandre Courbot acour...@nvidia.com --- Changes since v1: - Rebase on top of Linus' devel tree - Fixed error reporting as suggested

Re: [PATCH 1/3] dmatest: make module parameters writable

2013-08-08 Thread Andy Shevchenko
On Fri, 2013-08-02 at 17:49 +, Dan Williams wrote: On 7/31/13 7:28 AM, Andy Shevchenko andriy.shevche...@linux.intel.com wrote: On Tue, 2013-07-23 at 18:36 +0300, Andy Shevchenko wrote: The debugfs interface brought a copy of the test case parameters. This makes different set

Re: [PATCH v3 2/3] Input: gpio_keys - convert to use devm_*

2014-04-28 Thread Andy Shevchenko
On Fri, 2014-04-25 at 21:43 -0700, Dmitry Torokhov wrote: On Fri, Apr 25, 2014 at 07:22:16PM +0300, Andy Shevchenko wrote: This makes the error handling much more simpler than open-coding everything and in addition makes the probe function smaller an tidier. [] - pdata = kzalloc

Re: [PATCH v3 1/3] Input: gpio_keys - use dev instead of pdev in gpio_keys_setup_key()

2014-04-28 Thread Andy Shevchenko
On Fri, 2014-04-25 at 14:21 -0700, Dmitry Torokhov wrote: On Fri, Apr 25, 2014 at 07:22:15PM +0300, Andy Shevchenko wrote: The platform device is not used in gpio_keys_setup_key(). This patch substitutes it by struct device. And the benefit of this is...? Probably no benefit for now

Re: lockdep warning after recent cleanup in console code

2014-04-29 Thread Andy Shevchenko
] ? vprintk_emit+0x3c5/0x3ea [0.00] [c15849a5] ? printk+0x28/0x2d [0.00] [c190179d] start_kernel+0x72/0x325 [0.00] [c19012b4] i386_start_kernel+0x82/0x86 [0.00] bootconsole [earlyhsu0] enabled -- Andy Shevchenko andriy.shevche...@linux.intel.com Intel Finland Oy

[PATCH] tools/perf: remove yet another strtoull()

2014-04-29 Thread Andy Shevchenko
Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net --- tools/perf/util/util.c | 22 +- 1 file changed, 1 insertion(+), 21 deletions(-) diff --git a/tools/perf/util/util.c b/tools/perf/util/util.c index 9f66549

Re: lockdep warning after recent cleanup in console code

2014-04-30 Thread Andy Shevchenko
On Tue, 2014-04-29 at 23:07 +0200, Jan Kara wrote: On Tue 29-04-14 11:38:04, Andy Shevchenko wrote: On Mon, 2014-04-28 at 21:24 +0200, Jan Kara wrote: On Mon 28-04-14 14:14:39, Steven Rostedt wrote: On Mon, 28 Apr 2014 19:51:39 +0200 Jan Kara j...@suse.cz wrote: On Mon 28

Re: [PATCH v2] dma: imx-sdma: add support for sdma memory copy

2014-04-24 Thread Andy Shevchenko
-dma_device.device_control = sdma_control; sdma-dma_device.device_issue_pending = sdma_issue_pending; sdma-dma_device.dev-dma_parms = sdma-dma_parms; -- Andy Shevchenko andriy.shevche...@linux.intel.com Intel Finland Oy -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

Re: [PATCH 2/2] ACPI / LPSS: Support for fractional divider clock

2014-04-25 Thread Andy Shevchenko
, 0, 0, NULL); pdata-clk = clk; -- Andy Shevchenko andriy.shevche...@linux.intel.com Intel Finland Oy -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

[PATCH v3 3/3] Input: gpio_keys - convert struct descriptions to kernel-doc

2014-04-25 Thread Andy Shevchenko
This patch converts descriptions of the structures defined in linux/gpio_keys.h to follow kernel-doc format. There is no functional change. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Acked-by: Linus Walleij linus.wall...@linaro.org --- include/linux/gpio_keys.h | 45

[PATCH v3 0/3] Input: gpio-keys - clean up series

2014-04-25 Thread Andy Shevchenko
This is a 3rd iteration of the small cleanup against gpio-keys driver. Changes since v2: - append received Acks - rebase against recent linux-next - test on Intel Medfield based product Andy Shevchenko (3): Input: gpio_keys - use dev instead of pdev in gpio_keys_setup_key() Input

[PATCH v3 2/3] Input: gpio_keys - convert to use devm_*

2014-04-25 Thread Andy Shevchenko
This makes the error handling much more simpler than open-coding everything and in addition makes the probe function smaller an tidier. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Acked-by: Linus Walleij linus.wall...@linaro.org --- drivers/input/keyboard/gpio_keys.c | 75

[PATCH v3 1/3] Input: gpio_keys - use dev instead of pdev in gpio_keys_setup_key()

2014-04-25 Thread Andy Shevchenko
The platform device is not used in gpio_keys_setup_key(). This patch substitutes it by struct device. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/input/keyboard/gpio_keys.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/input

Re: [PATCH v1] dma: imx-sdma: add support for sdma memory copy

2014-04-22 Thread Andy Shevchenko
, + i, count, sg_src-dma_address, %pad for dma_addr_t. Accept the idea, same as the above. Same as above. -- Andy Shevchenko andriy.shevche...@linux.intel.com Intel Finland Oy -- To unsubscribe from this list: send the line unsubscribe linux-kernel

Re: [PATCH] pinctrl-baytrail: workaround for irq descriptor conflict on ASUS T100TA

2014-04-23 Thread Andy Shevchenko
tried to fix this particular issue (make sure the interrupt belongs to a io_apic controller before letting io_apic touch it), but we just opened a can of worms of other issues I don't know how to deal with. -Mathias -- Andy Shevchenko andriy.shevche...@linux.intel.com Intel Finland Oy

Re: [RFC PATCH 0/5] add gpio_chip_ops to hold GPIO operations

2014-04-10 Thread Andy Shevchenko
version with all the drivers converted. JFYI: there is nice project called codespell [1]. [1] git://github.com/lucasdemarchi/codespell.git -- Andy Shevchenko andriy.shevche...@linux.intel.com Intel Finland Oy -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

Re: [PATCH v3 4/8] DMA: Freescale: add fsl_dma_free_descriptor() to reduce code duplication

2014-04-10 Thread Andy Shevchenko
will be the result of double list_del() against the same node? } /** -- Andy Shevchenko andriy.shevche...@linux.intel.com Intel Finland Oy -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH v3 6/8] DMA: Freescale: change descriptor release process for supporting async_tx

2014-04-10 Thread Andy Shevchenko
; /* Descriptors pool */ struct device *dev; /* Channel device */ -- Andy Shevchenko andriy.shevche...@linux.intel.com Intel Finland Oy -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More

Re: [PATCH v3 8/8] DMA: Freescale: add suspend resume functions for DMA driver

2014-04-10 Thread Andy Shevchenko
fsldma_chan_regs_save regs_save; + enum fsldma_pm_state pm_state; +#endif void (*toggle_ext_pause)(struct fsldma_chan *fsl_chan, int enable); void (*toggle_ext_start)(struct fsldma_chan *fsl_chan, int enable); -- Andy Shevchenko andriy.shevche...@linux.intel.com Intel Finland

Re: [PATCH v3 4/8] DMA: Freescale: add fsl_dma_free_descriptor() to reduce code duplication

2014-04-14 Thread Andy Shevchenko
On Fri, 2014-04-11 at 16:14 +0800, Hongbo Zhang wrote: On 04/10/2014 07:29 PM, Andy Shevchenko wrote: On Thu, 2014-04-10 at 15:10 +0800, hongbo.zh...@freescale.com wrote: [] @@ -819,8 +826,7 @@ static void fsldma_cleanup_descriptor(struct fsldma_chan *chan, dma_run_dependencies(txd

Re: [PATCH v3 6/8] DMA: Freescale: change descriptor release process for supporting async_tx

2014-04-14 Thread Andy Shevchenko
against comments is really minor thing. -- Andy Shevchenko andriy.shevche...@linux.intel.com Intel Finland Oy -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH 2/2] dma: Add Xilinx AXI Direct Memory Access Engine driver support

2014-03-31 Thread Andy Shevchenko
xilinx_dma_channel_set_config(struct dma_chan *dchan, + struct xilinx_dma_config *cfg); #endif -- Andy Shevchenko andriy.shevche...@linux.intel.com Intel Finland Oy -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

[PATCH] fs/udf: re-use hex_asc_upper_{hi,lo} macros

2014-07-09 Thread Andy Shevchenko
This patch cleans up udf_translate_to_linux() a bit by using globally defined macros instead of custom code. We can use sprintf(buf, %04X, ...) there as well, but this one faster. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- fs/udf/unicode.c | 9 - 1 file changed

[PATCH v1 1/5] seq_file: provide an analogue of print_hex_dump()

2014-07-09 Thread Andy Shevchenko
The new seq_hex_dump() is a complete analogue of print_hex_dump(). We have few users of this functionality already. It allows to reduce their codebase. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- fs/seq_file.c| 35 +++ include

[PATCH v1 3/5] crypto: qat - use seq_hex_dump() to dump buffers

2014-07-09 Thread Andy Shevchenko
Instead of custom approach let's use recently introduced seq_hex_dump() helper. In this case it slightly changes the output, namely the four tetrads will be output on one line. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/crypto/qat/qat_common

[PATCH v1 2/5] saa7164: convert to seq_hex_dump()

2014-07-09 Thread Andy Shevchenko
Instead of custom approach let's use recently added seq_hex_dump() helper. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/media/pci/saa7164/saa7164-core.c | 31 --- 1 file changed, 4 insertions(+), 27 deletions(-) diff --git a/drivers

[PATCH v1 5/5] [S390] zcrypt: use seq_hex_dump() to dump buffers

2014-07-09 Thread Andy Shevchenko
Instead of custom approach let's use recently introduced seq_hex_dump() helper. In this case it slightly changes the output, namely the four tetrads will be output on one line. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/s390/crypto/zcrypt_api.c | 10

[PATCH v1 0/5] fs/seq_file: introduce seq_hex_dump() helper

2014-07-09 Thread Andy Shevchenko
This introduces a new helper and switches current users to use it. parisc and s390 weren't tested anyhow, the other are compile tested. Andy Shevchenko (5): seq_file: provide an analogue of print_hex_dump() saa7164: convert to seq_hex_dump() crypto: qat - use seq_hex_dump() to dump buffers

[PATCH v1 4/5] parisc: use seq_hex_dump() to dump buffers

2014-07-09 Thread Andy Shevchenko
Instead of custom approach let's use recently introduced seq_hex_dump() helper. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/parisc/ccio-dma.c | 14 +++--- drivers/parisc/sba_iommu.c | 11 +++ 2 files changed, 6 insertions(+), 19 deletions

Re: [PATCH v1 4/5] parisc: use seq_hex_dump() to dump buffers

2014-07-09 Thread Andy Shevchenko
-- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line unsubscribe linux-kernel

Re: [PATCH v1 1/5] seq_file: provide an analogue of print_hex_dump()

2014-07-10 Thread Andy Shevchenko
-buf like other seq_foo calls do. But I still have doubts about it. Any opinion? -- Andy Shevchenko andriy.shevche...@intel.com Intel Finland Oy -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH v1 5/5] [S390] zcrypt: use seq_hex_dump() to dump buffers

2014-07-10 Thread Andy Shevchenko
On Wed, 2014-07-09 at 18:24 +0300, Andy Shevchenko wrote: Instead of custom approach let's use recently introduced seq_hex_dump() helper. In this case it slightly changes the output, namely the four tetrads will be output on one line. The above paragraph is not true and will be removed

Re: [PATCH v1 3/5] crypto: qat - use seq_hex_dump() to dump buffers

2014-07-10 Thread Andy Shevchenko
On Wed, 2014-07-09 at 11:31 -0700, Tadeusz Struk wrote: On 07/09/2014 08:24 AM, Andy Shevchenko wrote: In this case it slightly changes the output, namely the four tetrads will be output on one line. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com It's ok, I can

[PATCH v2 4/5] parisc: use seq_hex_dump() to dump buffers

2014-07-11 Thread Andy Shevchenko
it prints same data (by meaning) in both cases. I decide to choose to use the space divided one. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/parisc/ccio-dma.c | 14 +++--- drivers/parisc/sba_iommu.c | 11 +++ 2 files changed, 6 insertions(+), 19

[PATCH v2 2/5] saa7164: convert to seq_hex_dump()

2014-07-11 Thread Andy Shevchenko
Instead of custom approach let's use recently added seq_hex_dump() helper. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Reviewed-by: Steven Toth st...@kernellabs.com --- drivers/media/pci/saa7164/saa7164-core.c | 31 --- 1 file changed, 4

[PATCH v2 5/5] [S390] zcrypt: use seq_hex_dump() to dump buffers

2014-07-11 Thread Andy Shevchenko
Instead of custom approach let's use recently introduced seq_hex_dump() helper. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/s390/crypto/zcrypt_api.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/s390/crypto/zcrypt_api.c b

[PATCH v2 1/5] seq_file: provide an analogue of print_hex_dump()

2014-07-11 Thread Andy Shevchenko
The new seq_hex_dump() is a complete analogue of print_hex_dump(). We have few users of this functionality already. It allows to reduce their codebase. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- fs/seq_file.c| 35 +++ include

[PATCH v2 0/5] fs/seq_file: introduce seq_hex_dump() helper

2014-07-11 Thread Andy Shevchenko
in patch 3/5 - Joe found that output is changed in patch 4/5, thus I update commit message there Andy Shevchenko (5): seq_file: provide an analogue of print_hex_dump() saa7164: convert to seq_hex_dump() crypto: qat - use seq_hex_dump() to dump buffers parisc: use seq_hex_dump() to dump

[PATCH v2 3/5] crypto: qat - use seq_hex_dump() to dump buffers

2014-07-11 Thread Andy Shevchenko
Instead of custom approach let's use recently introduced seq_hex_dump() helper. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Acked-by: Tadeusz Struk tadeusz.st...@intel.com --- drivers/crypto/qat/qat_common/adf_transport_debug.c | 16 ++-- 1 file changed, 2

Re: [PATCH v1] x86: fix kernel crash on boot due to NULL dereference

2014-07-21 Thread Andy Shevchenko
) { setup_irq(0, irq0); } Seems it may need the same protection for system without legacy IRQ controller. Agree. I will add the same check there and resend v2. Regards! Gerry On 2014/7/17 22:59, Andy Shevchenko wrote: The patch x86, irq: Count legacy IRQs by legacy_pic

[PATCH v2] x86: fix kernel crash on boot due to NULL dereference

2014-07-21 Thread Andy Shevchenko
there and in setup_default_timer_irq(). Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- Since v1: - add check to setup_default_timer_irq() as well - adjust spelling in commit message arch/x86/kernel/irqinit.c | 2 +- arch/x86/kernel/time.c| 2 ++ 2 files changed, 3 insertions(+), 1 deletion

Re: [PATCH v2 2/2] lib.c: skip --param parameters

2014-06-30 Thread Andy Shevchenko
On Sat, 2014-06-28 at 09:59 -0700, Christopher Li wrote: Oops, I just click send before I type up the reply. Here we go again. On Tue, Jun 17, 2014 at 2:11 AM, Andy Shevchenko andriy.shevche...@linux.intel.com wrote: Very dumb patch to just skip --param allow-store-data-races=0 introduced

Re: [PATCH v2 2/2] lib.c: skip --param parameters

2014-06-30 Thread Andy Shevchenko
On Mon, 2014-06-30 at 01:51 -0700, Christopher Li wrote: On Mon, Jun 30, 2014 at 1:32 AM, Andy Shevchenko andriy.shevche...@linux.intel.com wrote: Hmm... I'd just added test printf to the handle_param() and see if I print *next, it is either --param or --param=*. So, using return (next

[PATCH v2 05/10] wireless: libertas: print esaped string via %*pE

2014-07-07 Thread Andy Shevchenko
Instead of custom approach this allows to print escaped strings via recently added kernel extension: %*pE. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/net/wireless/libertas/cfg.c | 8 ++-- drivers/net/wireless/libertas/mesh.c | 7 +++ 2 files changed, 5

[PATCH v2 01/10] lib / string_helpers: move documentation to c-file

2014-07-07 Thread Andy Shevchenko
The documentation of API belongs to c-file. This patch moves it accordingly. There is no functional change. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- include/linux/string_helpers.h | 34 -- lib/string_helpers.c | 38

[PATCH v2 03/10] lib / string_helpers: introduce string_escape_mem()

2014-07-07 Thread Andy Shevchenko
This is almost the opposite function to string_unescape(). Nevertheless it handles \0 and could be used for any byte buffer. The documentation is supplied together with the function prototype. The test cases covers most of the scenarios and would be expanded later on. Signed-off-by: Andy

[PATCH v2 04/10] lib/vsprintf: add %*pE[achnops] format specifier

2014-07-07 Thread Andy Shevchenko
] %*pEhp \x1bb \C\x07\x90\x0d] %*pEa \e\142\040\\\103\a\042\220\r\135 Please, read Documentation/printk-formats.txt and lib/string_helpers.c kernel documentation to get further information. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Suggested

[PATCH v2 06/10] wireless: ipw2x00: print SSID via %*pE

2014-07-07 Thread Andy Shevchenko
Instead of custom approach this allows to print escaped strings via recently added kernel extension: %*pE. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/net/wireless/ipw2x00/ipw2100.c | 22 +-- drivers/net/wireless/ipw2x00/ipw2200.c | 270

[PATCH v2 02/10] lib / string_helpers: refactoring the test suite

2014-07-07 Thread Andy Shevchenko
This patch prepares test suite for a following update. It introduces test_string_check_buf() helper which checks the result and dumps an error. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- lib/test-string_helpers.c | 39 +++ 1 file

[PATCH v2 07/10] lib80211: remove unused print_ssid()

2014-07-07 Thread Andy Shevchenko
. Additionally by default the \f, \v, \a, and \e are escaped to their alphabetic representation. It's safe to do since it is currently used for messaging only. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- include/net/lib80211.h | 5 - net/wireless/lib80211.c | 32

[PATCH v2 10/10] staging: rtl8192u: use %*pEn to escape buffer

2014-07-07 Thread Andy Shevchenko
Let's use kernel's native specifier to escape a buffer. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/staging/rtl8192u/ieee80211/ieee80211.h | 14 +- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211

[PATCH v2 08/10] staging: wlan-ng: use %*pEhp to print SN

2014-07-07 Thread Andy Shevchenko
This is a generic specifier to print an escaped buffer by given criteria. Let's use it instead of custom approach. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/staging/wlan-ng/prism2sta.c | 28 ++-- 1 file changed, 2 insertions(+), 26

[PATCH v2 00/10] lib: introduce string_escape_mem an %*pE specifier

2014-07-07 Thread Andy Shevchenko
- kernel documentation moved to c-file - when test case fails the necessary messages are printed on KERN_WARNING level Andy Shevchenko (10): lib / string_helpers: move documentation to c-file lib / string_helpers: refactoring the test suite lib / string_helpers: introduce string_escape_mem

[PATCH v2 09/10] staging: rtl8192e: use %*pEn to escape buffer

2014-07-07 Thread Andy Shevchenko
Let's use kernel's native specifier to escape a buffer. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/staging/rtl8192e/rtllib.h | 14 +- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging

Re: [PATCH v2 04/10] lib/vsprintf: add %*pE[achnops] format specifier

2014-07-08 Thread Andy Shevchenko
On Mon, 2014-07-07 at 09:50 -0700, Joe Perches wrote: On Mon, 2014-07-07 at 18:21 +0300, Andy Shevchenko wrote: diff --git a/lib/vsprintf.c b/lib/vsprintf.c [] static noinline_for_stack +char *escaped_string(char *buf, char *end, u8 *addr, struct printf_spec spec

<    3   4   5   6   7   8   9   10   11   12   >