We are transitioning pages from active to inactive in
clear_active_flags, those need counting as PGDEACTIVATE vm events.
Signed-off-by: Andy Whitcroft [EMAIL PROTECTED]
Acked-by: Mel Gorman [EMAIL PROTECTED]
---
diff --git a/mm/vmscan.c b/mm/vmscan.c
index d419e10..99ec7fa 100644
--- a/mm
but
that should be expected behaviour for high-order users. It is preferable
behaviour to potentially queueing unnecessary areas for IO. Note that kswapd
will not stall in this fashion.
[EMAIL PROTECTED]: update to version 2]
Signed-off-by: Mel Gorman [EMAIL PROTECTED]
Signed-off-by: Andy Whitcroft [EMAIL
Dan Williams wrote:
WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
#563: FILE: drivers/scsi/iioc34x/iioc34x_sas.c:58:
+EXPORT_SYMBOL(iioc34x_transport_template);
drivers/scsi/iioc34x/iioc34x_sas.c:57
struct scsi_transport_template *iioc34x_transport_template;
Andrew Morton wrote:
On Sat, 28 Jul 2007 19:07:22 +0200 Gabriel C [EMAIL PROTECTED] wrote:
Hi,
next randconfig error (
http://194.231.229.228/MM/randconfig-auto-87.mm_sparse.error )
...
mm/sparse.c: In function 'sparse_init':
mm/sparse.c:482: error: implicit declaration of function
Jason Wessel wrote:
Running checkpatch.pl products an warning when it should not. I believe
it can be fixed by adding to the regular expression, but feel free to
fix it another way as I may not know all the cases this is trying to catch.
Thanks for the patch. We had already caught this one
it is not known defaulting
to -1 seems a better course, and would help us where node 0 is
short of memory.
Signed-off-by: Andy Whitcroft [EMAIL PROTECTED]
---
arch/i386/pci/common.c |2 ++
arch/i386/pci/fixup.c|8 +---
arch/i386/pci/numa.c |8 +---
arch/i386/pci/visws.c
-by: Andy Whitcroft [EMAIL PROTECTED]
---
arch/x86_64/mm/init.c |9 +
1 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/arch/x86_64/mm/init.c b/arch/x86_64/mm/init.c
index ac49df0..5d1ed03 100644
--- a/arch/x86_64/mm/init.c
+++ b/arch/x86_64/mm/init.c
@@ -792,9 +792,10 @@ int
[This is a re-spin based on feedback from akpm.]
As pointed out by Mel when reclaim is applied at higher orders a
significant amount of IO may be started. As this takes finite time
to drain reclaim will consider more areas than ultimatly needed
to satisfy the request. This leads to more reclaim
We are transitioning pages from active to inactive in
clear_active_flags, those need counting as PGDEACTIVATE vm events.
Signed-off-by: Andy Whitcroft [EMAIL PROTECTED]
Acked-by: Mel Gorman [EMAIL PROTECTED]
---
mm/vmscan.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git
accounting (count deactivate events correctly)
- use our own sync/async flag type
[EMAIL PROTECTED]: update to version 2]
[EMAIL PROTECTED]: update to version 3]
Signed-off-by: Mel Gorman [EMAIL PROTECTED]
Signed-off-by: Andy Whitcroft [EMAIL PROTECTED]
---
mm/vmscan.c | 60
Jan Engelhardt wrote:
On Jul 23 2007 16:36, Kok, Auke wrote:
this somehow seems to match something completely non-related (a function
pointer declaration case):
ERROR: no space between function name and open parenthesis '('
#7278: FILE: drivers/net/e1000e/hw.h:434:
+ bool
them.
- parks the multple declaration support
- allows architecture defines in architecture specific headers
Andy Whitcroft (21):
Version: 0.09
loosen single statement brace checks
fix up multiple declaration to avoid function arguments
add some function space
Following this email are two cleanup patches against lumpy V6
(as contained in v2.6.21-rc7-mm1). These address the review feedback
from Andrew Morton, thanks for reviewing.
introduce-HIGH_ORDER-delineating-easily-reclaimable-orders-fix:
changes the name of the constant to
Switch from HIGH_ORDER to the more logical and descriptive
PAGE_ALLOC_COSTLY_ORDER indicating the boundary between orders
easily reclaimed and allocated and those which are not.
Signed-off-by: Andy Whitcroft [EMAIL PROTECTED]
Acked-by: Mel Gorman [EMAIL PROTECTED]
---
diff --git a/include/linux
in __isolate_lru_pages(), and
4) changes the parameter active to mode throughout.
Signed-off-by: Andy Whitcroft [EMAIL PROTECTED]
Acked-by: Mel Gorman [EMAIL PROTECTED]
---
diff --git a/mm/vmscan.c b/mm/vmscan.c
index ab7f4c0..5f3c2bb 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -590,38 +590,46
Getting the following on an x86_64 numa box:
CC arch/x86_64/vdso/vclock_gettime.o
arch/x86_64/vdso/vclock_gettime.c:1: error: code model `small' not
supported in the 32 bit mode
make[1]: *** [arch/x86_64/vdso/vclock_gettime.o] Error 1
make: *** [arch/x86_64/vdso] Error 2
Kernel config
Getting hard boot failures before any kernel output on an x86_64 blade:
root (hd0,0)
Filesystem type is ext2fs, partition type 0x83
kernel /vmlinuz-autobench ro root=/dev/VolGroup00/LogVol00 rhgb
console=tty0 console=ttyS1,19200 selinux=no autobench_args:
root=30726124 ABAT:1177507960 profile=2
Nick Piggin wrote:
Christoph Lameter wrote:
On Thu, 26 Apr 2007, Nick Piggin wrote:
mapping through the radix tree. You just need to change the way the
filesystem looks up pages.
You didn't think any of the criticisms of higher order page cache size
were valid?
They are all known
Andrew Morton wrote:
On Wed, 25 Apr 2007 11:21:33 -0700
Randy Dunlap [EMAIL PROTECTED] wrote:
On Mon, 23 Apr 2007 10:45:34 -0700 Andrew Morton wrote:
On Mon, 23 Apr 2007 16:11:23 +0200
Martin Schwidefsky [EMAIL PROTECTED] wrote:
Greetings,
I've added the results of the review to the
Getting a link failure on a ppc64 system:
LD .tmp_vmlinux1
init/built-in.o(.init.text+0x32e4): In function `.rd_load_image':
: undefined reference to `.__kmalloc_size_too_large'
fs/built-in.o(.text+0xa6fe0): In function `.ext3_fill_super':
: undefined reference to
Andy Whitcroft wrote:
Getting a link failure on a ppc64 system:
LD .tmp_vmlinux1
init/built-in.o(.init.text+0x32e4): In function `.rd_load_image':
: undefined reference to `.__kmalloc_size_too_large'
fs/built-in.o(.text+0xa6fe0): In function `.ext3_fill_super':
: undefined reference
Andy Whitcroft wrote:
Andy Whitcroft wrote:
Getting a link failure on a ppc64 system:
LD .tmp_vmlinux1
init/built-in.o(.init.text+0x32e4): In function `.rd_load_image':
: undefined reference to `.__kmalloc_size_too_large'
fs/built-in.o(.text+0xa6fe0): In function `.ext3_fill_super
Christoph Lameter wrote:
On Thu, 26 Apr 2007, Andy Whitcroft wrote:
Ok, this is a SLUB related link failure. Am investigating if PPC simply
needs larger allocs and needs CONFIG_LARGE_ALLOCS, of if this is an
inlining issue.
Ok this is confirmed as an inlining issue. With the compiler
Christoph Lameter wrote:
On Thu, 26 Apr 2007, Andy Whitcroft wrote:
But then how important is gcc 3.3 support?
Well we say 3.2 is the minimum. If we simply return(NULL) or BUG() in
Oh before I forget
Gcc 3.3 works just fine on other platforms like i386. This is more likely
a platform
Andrew Morton wrote:
On Thu, 26 Apr 2007 02:32:06 +0200 Arnd Bergmann [EMAIL PROTECTED] wrote:
On Thursday 26 April 2007, Andrew Morton wrote:
It would be neat if someone could create and maintain a new
scripts/spot-common-mistakes. Feed it a unified diff and it would complain
about
Christoph Lameter wrote:
On Thu, 26 Apr 2007, Andy Whitcroft wrote:
Gcc 3.3 works just fine on other platforms like i386. This is more likely
a platform issue. If we disable it then only for = gcc 3.3 on ppc. If
problems crop up with other platforms then we can expand on it.
I
Andrew Morton wrote:
On Thu, 26 Apr 2007 20:25:19 +0200
Borislav Petkov [EMAIL PROTECTED] wrote:
Remove build warning mm/memory.c:1491: warning: 'ptl' may be used
uninitialized in this function.
The spinlock pointer is assigned to null since it gets overwritten right
away in
Andrew Morton wrote:
Dave Hansen [EMAIL PROTECTED] wrote:
The following four patches provide the last needed changes before the
introduction of sparsemem. For a more complete description of what this
will do, please see this patch:
which is a patch against the 2.6.11.1 release. If consensus arrives
that this patch should be against the 2.6.11 tree, it will be done that
way in the future.
It seems to me that we have V (delta?) and VI (delta incremental) for
all the other kernel patch series. So perhaps we could have both,
On Wed, Apr 17, 2013 at 12:37:43PM +0800, Lingzhu Xiang wrote:
On 04/16/2013 06:33 PM, Luis Henriques wrote:
68d929862e29a8b52a7f2f2f86a0600423b093cd efi: be more paranoid about
available space when creating variables
This prevents a bricking issue for some Samsung devices but causes
On Sat, Apr 06, 2013 at 04:58:04PM +0200, Andrea Arcangeli wrote:
You're right, so this location clearly didn't trigger the problem so I
didn't notice the noop here. I only exercised the fix in the other
locations of the file that had the same problem.
It was a noop, so it really couldn't
On Tue, Apr 09, 2013 at 08:17:14PM -0700, Joe Perches wrote:
Comparisons of A to true and false are better written
as A and !A.
Bleat a message on use.
Signed-off-by: Joe Perches j...@perches.com
---
scripts/checkpatch.pl | 17 +
1 file changed, 17 insertions(+)
diff
On Wed, Apr 10, 2013 at 04:27:51AM -0700, Joe Perches wrote:
like
0 == foo
instead of
foo == 0
there were _way_ too many false positives of
the $Expression sort that I didn't add that test.
Makes sense then as it is.
Thanks.
-apw
--
To unsubscribe from this list: send the
On Tue, Apr 09, 2013 at 02:50:54PM -0700, James Bottomley wrote:
It's making checkpatch unusable on most drivers because it's spewing
tons of bogus warnings. The problem is the assumption that studly caps
is always wrong: it isn't if the variables are named after the various
conventions in
On Thu, Mar 28, 2013 at 12:58:22PM +0530, Mugunthan V N wrote:
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -281,6 +281,7 @@ our $signature_tags = qr{(?xi:
Tested-by:|
Reviewed-by:|
Reported-by:|
+ Suggested-by:|
To:|
Cc:
)};
Looks
On Tue, Dec 04, 2012 at 04:59:23AM -0800, Paul E. McKenney wrote:
Hello, Andy,
The current checkpatch.pl complains about cpp macros defined as follows:
#define callit call my_function
Of course, if you do put parentheses around the definition, your assembler
will complain. Could this
Andrew Morton wrote:
On Wed, 6 Dec 2006 16:59:04 +
Andy Whitcroft [EMAIL PROTECTED] wrote:
This is a repost of the lumpy reclaim patch set. This is
basically unchanged from the last post, other than being rebased
to 2.6.19-rc2-mm2.
The patch sequencing appeared to be designed to make
Andrew Morton wrote:
On Wed, 6 Dec 2006 16:59:04 +
Andy Whitcroft [EMAIL PROTECTED] wrote:
This is a repost of the lumpy reclaim patch set.
more...
One concern is that when the code goes to reclaim a lump and fails, we end
up reclaiming a number of pages which we didn't really want
Pekka J Enberg wrote:
[Andrew, I have been unable to find a NUMA-capable tester for this patch,
so can we please put this in to -mm for some exposure?]
From: Pekka Enberg [EMAIL PROTECTED]
This patch cleans up __cache_alloc and __cache_alloc_node functions. We no
longer need to do
Linus Torvalds wrote:
On Wed, 10 Jan 2007, Linus Torvalds wrote:
Which is why __init is wrong. It causes the linker to either put it at
the end of the thing (which would break the SuSE tool). Alternatively it
causes section mismatch problems (init and const don't work that well
Dave Hansen wrote:
I think the comments added say it pretty well, but I'll repeat it here.
This fix is pretty similar in concept to the one that Arnd posted
as a temporary workaround, but I've added a few comments explaining
what the actual assumptions are, and improved it a wee little bit.
of testing on this issue. The main
problem machine ppc64 on SLES9 with CIFS enabled passes with this patch
plus __init removed.
Results on TKO.
Acked-by: Andy Whitcroft [EMAIL PROTECTED]
-apw
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message
Roman Zippel wrote:
Hi,
On Wed, 10 Jan 2007, Linus Torvalds wrote:
This part:
const char __init linux_banner[] =
CANNOT work, because the stupid SuSE tool that look into the kernel binary
searches for Linux version as the thing, and as such the linux_banner
has to be the
Peter Zijlstra wrote:
On Mon, 2006-12-04 at 11:30 -0800, Andrew Morton wrote:
I'd also like to pin down the situation with lumpy-reclaim versus
anti-fragmentation. No offence, but I would of course prefer to avoid
merging the anti-frag patches simply based on their stupendous size. It
seems
the boundary pfn calculations.
Signed-off-by: Andy Whitcroft [EMAIL PROTECTED]
Acked-by: Peter Zijlstra [EMAIL PROTECTED]
---
diff --git a/mm/vmscan.c b/mm/vmscan.c
index 0f2d961..0effa3e 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -606,21 +606,14 @@ keep:
}
/*
- * zone-lru_lock is heavily contended
lumpy: ensure we respect zone boundaries
When scanning an aligned order N area ensure we only pull out pages
in the same zone as our tag page, else we will manipulate those
pages' LRU under the wrong zone lru_lock. Bad.
Signed-off-by: Andy Whitcroft [EMAIL PROTECTED]
Acked-by: Peter Zijlstra
This is a repost of the lumpy reclaim patch set. This is
basically unchanged from the last post, other than being rebased
to 2.6.19-rc2-mm2. This has passed basic stress testing on a range
of machines here.
[Sorry for the delay reposting, I had a test failure and needed
to confirm it was not
Zijlstra [EMAIL PROTECTED]
Signed-off-by: Andy Whitcroft [EMAIL PROTECTED]
---
diff --git a/fs/buffer.c b/fs/buffer.c
index c953c15..2f8b073 100644
--- a/fs/buffer.c
+++ b/fs/buffer.c
@@ -374,7 +374,7 @@ static void free_more_memory(void)
for_each_online_pgdat(pgdat) {
zones
and from the end of the inactive
list, increasing the chances of such areas coming free together.
Signed-off-by: Andy Whitcroft [EMAIL PROTECTED]
Acked-by: Peter Zijlstra [EMAIL PROTECTED]
---
diff --git a/mm/vmscan.c b/mm/vmscan.c
index 85f626b..fc23d87 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
test.kernel.org testing seems to have shaken out a problem with the
kernel banner changing, introduced by this commit:
[PATCH] Fix linux banner utsname information
commit a2ee8649ba6d71416712e798276bf7c40b64e6e5
We first noticed it with 2.6.19-git13 as we use this version
Linus Torvalds wrote:
On Mon, 11 Dec 2006, Herbert Poetzl wrote:
cool!
should definitely work for all 'known' cases
No it doesn't.
Do a
git grep '.*Linux version .*'
on the kernel, and see just how CRAP that get_kernel_version test is,
and has always been.
But let's hope that
Linus Torvalds wrote:
On Mon, 11 Dec 2006, Andy Whitcroft wrote:
I am afraid to report that this second version also fails for me, as you point
out CIFS can break us if defined.
Olaf, will you admit that the SLES9 code is crap now?
Andy, does just replacing the __initdata with const fix
Andrew Morton wrote:
On Wed, 6 Dec 2006 16:59:04 +
Andy Whitcroft [EMAIL PROTECTED] wrote:
This is a repost of the lumpy reclaim patch set.
more...
One concern is that when the code goes to reclaim a lump and fails, we end
up reclaiming a number of pages which we didn't really want
Kay Sievers wrote:
On Tue, 2006-11-28 at 14:30 -0800, Greg KH wrote:
On Tue, Nov 28, 2006 at 12:35:43PM +0100, Mariusz Kozlowski wrote:
Hello,
When CONFIG_MODULE_UNLOAD is not set then this happens:
CC kernel/module.o
kernel/module.c:852: error: `initstate' undeclared here (not
this out as explicit
calls, also introduce a type for the callback function allowing them
to be type checked. For each callback we pre-declare the function,
causing a type error on definition rather than on use elsewhere.
Signed-off-by: Andy Whitcroft [EMAIL PROTECTED]
---
diff --git a/include/linux
Mel Gorman wrote:
On Mon, 4 Dec 2006, Andrew Morton wrote:
, but I would of course prefer to avoid
merging the anti-frag patches simply based on their stupendous size.
It seems to me that lumpy-reclaim is suitable for the e1000 problem
, but perhaps not for the hugetlbpage problem.
I
Andrew Morton wrote:
On Mon, 4 Dec 2006 20:34:29 + (GMT)
Mel Gorman [EMAIL PROTECTED] wrote:
IOW: big-picture where-do-we-go-from-here stuff.
Start with lumpy reclaim,
I had lumpy-reclaim in my todo-queue but it seems to have gone away. I
think I need a lumpy-reclaim resend, please.
Andrew Morton wrote:
On Sat, 25 Nov 2006 13:03:45 -0800
Martin J. Bligh [EMAIL PROTECTED] wrote:
On 2.6.18-rc7 and later during LTP:
http://test.kernel.org/abat/48393/debug/console.log
The traces are a bit confusing, but I don't actually see anything wrong
there. The machine has used up
results in unspecified behavior
Move memory_setup() to avoid this.
Signed-off-by: Andy Whitcroft [EMAIL PROTECTED]
---
diff --git a/arch/i386/kernel/setup.c b/arch/i386/kernel/setup.c
index 8be04da..79df6e6 100644
--- a/arch/i386/kernel/setup.c
+++ b/arch/i386/kernel/setup.c
@@ -494,6 +494,12 @@ static
this, using the inode
permissions when the lowerlayer is read-only. This seems to work as
expected in my limited testing.
Comments on both approaches appreciated.
-apw
Andy Whitcroft (2):
ovl: copy_up_xattr may fail when the upper filesystem does not
support the same xattrs
overlayfs: when
://bugs.launchpad.net/bugs/1039402
Signed-off-by: Andy Whitcroft a...@canonical.com
---
fs/overlayfs/copy_up.c |9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/fs/overlayfs/copy_up.c b/fs/overlayfs/copy_up.c
index 87dbeee..b0b4229 100644
--- a/fs/overlayfs/copy_up.c
the notional permissions on the file permit write. This prevents
a copy_up occuring on the file and fails the write.
Switch to using inode permissions directly when the lower layer is
read-only.
BugLink: http://bugs.launchpad.net/bugs/1039402
Signed-off-by: Andy Whitcroft a...@canonical.com
---
fs
On Wed, Aug 15, 2012 at 09:59:51AM -0700, Casey Schaufler wrote:
On 8/15/2012 8:48 AM, Miklos Szeredi wrote:
From: Andy Whitcroft a...@canonical.com
When checking permissions on an overlayfs inode we do not take into
account either device cgroup restrictions nor security permissions
/bugs/944386
Signed-off-by: Andy Whitcroft a...@canonical.com
---
fs/overlayfs/dir.c |2 ++
fs/overlayfs/overlayfs.h |6 ++
fs/overlayfs/super.c |1 +
3 files changed, 9 insertions(+)
After a long hiatus I have had time to look into the issues
highlighted
On Fri, Aug 17, 2012 at 08:53:53PM +0200, Olaf Hering wrote:
On Fri, Aug 17, Ben Hutchings wrote:
You are never going to have a 'works everywhere' solution for
Linux guests.
The hook is the solution.
How are these distribution-specific integration scripts going
to get installed in
On Thu, Aug 02, 2012 at 10:00:04AM +0200, Schrober wrote:
Hi,
I think your check for SINGLE_STATEMENT_DO_WHILE_MACRO is wrong. Just to give
an example:
#define foobar(x) \
do { \
if (pizza_ready(x)) \
eat_pizza(x); \
} while (0)
if
{} while (0) loop\n . $herectx);
}
Looks reasonable enough.
Acked-by: Andy Whitcroft a...@canonical.com
-apw
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
*page_list)
Yeah that is a silly typo.
Acked-by: Andy Whitcroft [EMAIL PROTECTED]
-apw
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ
On Tue, Jan 29, 2008 at 05:17:28PM -0600, Timur Tabi wrote:
checkpatch.pl thinks that __asm__ is a function name, so it complains about
a space between the function name and a parenthesis when it sees
__asm__ (mov ax,bx).
This change will also encourage developers to use '__asm__' instead of
a warning when --file mode is used
Andy Whitcroft (14):
Version: 0.14
clean up some space violations in checkpatch.pl
a completly empty file should not provoke a whinge
reset report lines buffers between files
unary ++/-- may abutt close braces
__typeof__ is also
On Mon, Jan 28, 2008 at 12:28:41PM -0800, Christoph Lameter wrote:
Core code for mmu notifiers.
Signed-off-by: Christoph Lameter [EMAIL PROTECTED]
Signed-off-by: Andrea Arcangeli [EMAIL PROTECTED]
---
include/linux/list.h | 14 ++
include/linux/mm_types.h |6 +
On Tue, Feb 05, 2008 at 09:26:47PM +0200, Benny Halevy wrote:
Was version 0.13 NACKed?
It was picked up by Andrew for -mm according to my email. I do not
think there has been an -mm release since then however. This patch is
relative to that version.
-apw
--
To unsubscribe from this list: send
On Wed, Jan 16, 2008 at 11:21:21PM +0100, Andi Kleen wrote:
Deprecate checkpatch.pl --file mode; add warning; add --file-force
As discussed on linux-kernel checkpatch.pl only patches for whole
files have a significant cost. Better such changes should be only
done together with other
On Thu, Jan 03, 2008 at 01:54:42AM +0100, Arjan van de Ven wrote:
Subject: Make checkpatch.pl's quiet option not print the summary on no
errors
From: Arjan van de Ven [EMAIL PROTECTED]
CC: [EMAIL PROTECTED]
Right now, in quiet mode, checkpatch.pl still prints a summary line even
if the
On Wed, Jan 16, 2008 at 11:21:21PM +0100, Andi Kleen wrote:
I'm not entirely sure who collects checkpatch patches for .25 -- i thought it
was Andy W., but he doesn't seem to answer. Anyways whoever does it please
queue this patch for the next checkpatch.pl update. Or perhaps it could
be put
of fixes to unary detection
- detection of a number of new forms of types to improve type matching
- better inline handling
- recognision of '%' as an operator
Andy Whitcroft (28):
Version: 0.13
unary detection: maintain bracket state across lines
move to pre-sanitising
On Wed, Jan 16, 2008 at 12:06:46PM +0100, Ingo Molnar wrote:
btw, just found a checkpatch.pl buglet, it gets confused on zero-sized
files:
$ echo -n /tmp/1.c
$ scripts/checkpatch.pl --file /tmp/1.c
ERROR: Does not appear to be a unified-diff format patch
total: 1 errors, 0
On Thu, Jan 17, 2008 at 11:19:23AM -0800, Andrew Morton wrote:
On Thu, 17 Jan 2008 16:23:51 - Andy Whitcroft [EMAIL PROTECTED] wrote:
This version brings a large number of fixes which have built up over
the Christmas period. Mostly these are fixes for false positives, both
through
On Sat, Jan 19, 2008 at 02:56:05PM +0100, Jan Engelhardt wrote:
On Jan 18 2008 11:45, Ingo Molnar wrote:
* Jan Engelhardt [EMAIL PROTECTED] wrote:
This is against x86/mm.
hm, it has checkpatch failures -
All false positives.
The spacing thing is definately a matter for argument
On Sat, Jan 19, 2008 at 12:24:41AM +0900, Tetsuo Handa wrote:
Tetsuo Handa wrote:
checkpatch.pl was unable to handle \\ within quoted string.
Sorry, I didn't know checkpatch 0.13 is available.
No problem. Thanks for trying to fix it.
:)
-apw
--
To unsubscribe from this list: send the
On Wed, Jan 23, 2008 at 02:06:59PM -0800, Andrew Morton wrote:
On Mon, 21 Jan 2008 22:02:09 -0500 Theodore Ts'o [EMAIL PROTECTED]
wrote:
+int ext4_get_blocks_wrap(handle_t *handle, struct inode *inode, sector_t
block,
+ unsigned long max_blocks, struct buffer_head
On Sat, Jan 26, 2008 at 10:01:23PM -0800, Andrew Morton wrote:
int __initdata user_defined_memmap = 0;
checkpatch should have told you that this = 0 shouldn't be there. But it
doesn't.
Ok, this line would be correctly picked up if it was being added by this
author, but this line is in
On Tue, Jan 22, 2008 at 02:20:48PM +0100, Paolo Ciarrocchi wrote:
On Jan 14, 2008 11:23 PM, Paolo Ciarrocchi [EMAIL PROTECTED] wrote:
Add a filename option (default to 0)
in order to get the following summary output:
./scripts/checkpatch.pl --filename --file ./arch/sparc/kernel/apc.c
...
On Mon, Jan 14, 2008 at 11:19:48PM +0100, Bartlomiej Zolnierkiewicz wrote:
__FUNCTION__ is gcc specific, __func__ is C99
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
Research seems to indicate this is indeed sensible as __FUNCTION__ can
cause -Werror to trip. Have applied
On Mon, Jan 14, 2008 at 11:29:13PM +0100, Paolo Ciarrocchi wrote:
Hi Andy,
When I started using checkpatch I was confused by the following WARN message:
no space between function name and open parenthesis
I thought the problem was that a space was missing while the truth is the
On Sat, Feb 16, 2008 at 12:27:33PM +0200, Pekka Enberg wrote:
Hi,
On Feb 16, 2008 12:18 PM, Thomas Gleixner [EMAIL PROTECTED] wrote:
People, who do cleanups - I'm not talking about running lindent here -
read through the code while they fix it up.
Actually they find bugs that way or at
This version brings a number of minor fixes updating the type detector and
the unary tracker. It also brings a few small fixes for false positives.
It also reverts the --file warning. Of note:
- limit CVS checks to added lines
- improved type detections
- fixes to the unary tracker
Andy
On Tue, Feb 19, 2008 at 12:03:37AM +0100, Dmitry Adamushko wrote:
Hi,
[ description ]
Subject: kthread: add a memory barrier to kthread_stop()
'kthread' threads do a check in the following order:
- set_current_state(TASK_INTERRUPTIBLE);
- kthread_should_stop();
and
to the hugepage pool, drop the pool locks and then clear
page private. In either case the page may have been reallocated. BAD.
Make sure we clear out page private before we free the page.
Signed-off-by: Andy Whitcroft [EMAIL PROTECTED]
---
mm/hugetlb.c |2 +-
1 files changed, 1 insertions
On Sun, Feb 24, 2008 at 07:14:13PM +0100, Paolo Ciarrocchi wrote:
On Sun, Feb 24, 2008 at 4:18 PM, Benny Halevy [EMAIL PROTECTED] wrote:
[...]
How about:
- WARN(no space between function name and
open parenthesis '('\n . $herecurr);
+
On Sat, Feb 23, 2008 at 01:55:32PM +0100, Christer Weinigel wrote:
Andi Kleen wrote:
RFC: Update coding standard to avoid split up printk format strings
While we're talking about checkpatch.pl, I'd definitely like to teach
checkpatch about list_for_each and friends.
list_for_each is flow
On Fri, Feb 22, 2008 at 02:26:12PM +0100, Andi Kleen wrote:
At some point checkpatch.pl would need to be updated to know about this
exception too, that would be the next step.
Cirtainly we have exceptions for docstrings, so that shouldn't be a
problem if this were accepted.
-apw
--
To
On Mon, Feb 25, 2008 at 10:21:01AM +0330, Paolo Ciarrocchi wrote:
On 2/25/08, Andy Whitcroft
As we want the messages to be as short as possible, I am leaning towards
standardising on:
spaces prohibited where
spaces required where
in that case i would prefer:
space not required
On Sun, Feb 24, 2008 at 03:47:11PM +0100, Jörn Engel wrote:
While tracking down some unrelated bug I noticed that shrink_page_list()
keeps testing very low page numbers (aka kernel text) until deciding
that the page lacks a mapping and cannot get freed. Looks like a waste
of cpu and
On Mon, Feb 25, 2008 at 07:53:20PM +0100, Jörn Engel wrote:
On Mon, 25 February 2008 09:48:22 -0800, Dave Hansen wrote:
On Mon, 2008-02-25 at 15:07 +, Andy Whitcroft wrote:
shrink_page_list() would be expected to be passed pages pulled from
the active or inactive lists via
On Mon, Feb 25, 2008 at 09:42:00PM -0500, Pavel Roskin wrote:
Quoting Christoph Hellwig [EMAIL PROTECTED]:
On Mon, Feb 25, 2008 at 02:49:22PM -0800, Andrew Morton wrote:
the things which it finds.
+static DECLARE_MUTEX(kmmio_init_mutex);
That's not a mutex.
+
On Mon, Feb 25, 2008 at 06:34:49PM -0500, Christoph Hellwig wrote:
On Mon, Feb 25, 2008 at 02:49:22PM -0800, Andrew Morton wrote:
the things which it finds.
+static DECLARE_MUTEX(kmmio_init_mutex);
That's not a mutex.
+ down(kmmio_init_mutex);
It's a semaphore. Please do
On Tue, Feb 26, 2008 at 11:49:48AM +0100, Ingo Molnar wrote:
* Andy Whitcroft [EMAIL PROTECTED] wrote:
Ok, so that would be the following, work for everyone?
WARNING: mutexes are preferred for single holder semaphores
#1: FILE: Z95.c:1:
+ DECLARE_MUTEX(foo);
WARNING
On Wed, Oct 31, 2007 at 04:30:43PM +0100, Jan Kara wrote:
On Wed 24-10-07 18:07:29, Andy Whitcroft wrote:
On Wed, Oct 24, 2007 at 05:03:03PM +0200, Jan Kara wrote:
e2image -r /dev/sda1 - | gzip -dc root-image.gz
This thing is 27MB, I'll try and find some space to hold it and
let
On Tue, Nov 06, 2007 at 07:09:40PM +0530, Balbir Singh wrote:
Kamalesh Babulal wrote:
David Miller wrote:
From: Johannes Berg [EMAIL PROTECTED]
Date: Tue, 06 Nov 2007 11:54:46 +0100
CHK include/linux/compile.h
AS arch/powerpc/kernel/swsusp_32.o
201 - 300 of 940 matches
Mail list logo
