On Mon, Dec 03, 2007 at 03:53:17PM -0800, Andrew Morton wrote:
+#define READ_SC(p, r)readb ((p)-membase + RD_##r)
+#define WRITE_SC(p, r, v)writeb ((v), (p)-membase + WR_##r)
No space before the (. checkpatch misses this.
Yep, over careful in the special case for the
On Tue, Dec 18, 2007 at 06:46:41AM +0100, Borislav Petkov wrote:
On Mon, Dec 17, 2007 at 08:11:05AM +0100, Borislav Petkov wrote:
A slightly microoptimized version 1.1:
---
From: Borislav Petkov [EMAIL PROTECTED]
Check the patch level of the single hunks in a patch file, however only
On Wed, Nov 28, 2007 at 12:07:38PM +0100, Holger Schurig wrote:
I have a case where scripts/checkpatch.pl returns a false error.
First, here is the code:
static int lbs_scan_add_rates_tlv(u8 *tlv)
{
int i;
struct mrvlietypes_ratesparamset *rate_tlv =
(struct
On Sun, Nov 18, 2007 at 11:03:47AM +0100, Geert Uytterhoeven wrote:
checkpatch: Print filenames of patches instead of the very uninformative
`Your patch'.
Well this isn't quite enough as we often use this thing checking its
stdin. Which leads to an even less useful '- has no obvious ...'. I
I have one powerpc machine which managed to compile this snapshot! It
paniced on boot as below, might be nfs so copied them. General results
are popping out on TKO.
-apw
Freeing initrd memory: 1224k freed
Installing knfsd (copyright (C) 1996 [EMAIL PROTECTED]).
Unable to handle kernel paging
On Tue, Dec 25, 2007 at 04:50:04PM -0500, Erez Zadok wrote:
Using v2.6.24-rc6-125-g5356f66, code such as this:
if (is_file)/* dirs can be unlinked but chdir'ed to */
err = -ESTALE;
produces this false checkpatch error:
foo.c:947: ERROR: trailing statements
On Tue, Jan 01, 2008 at 12:12:22PM +0200, Benny Halevy wrote:
checkpatch.pl does not recognize #elif as a preprocessor directive
causing it to print bogus errors for, e.g.:
ERROR: need consistent spacing around '' (ctx:WxV)
when the operator is not recognized as unary in this context.
for
On Tue, Jan 01, 2008 at 06:15:46PM +0200, Boaz Harrosh wrote:
I have this code:
c_code
/*
* osd-r10 4.12.5 Data-In and Data-Out buffer offsets
* byte offset = mantissa * (2^(exponent+8))
*/
typedef __be32 osd_cdb_offset;
osd_cdb_offset __osd_encode_offset(u64 offset, unsigned
On Sun, Dec 02, 2007 at 01:03:35PM +0100, Christer Weinigel wrote:
Hi Andy,
you seem to be the last person messing around with checkpatch.pl so I'm
addressing this to you. :-)
checkpatch complains about the following:
WARNING: no space between function name and open parenthesis '('
On Thu, Jan 03, 2008 at 01:54:42AM +0100, Arjan van de Ven wrote:
Subject: Make checkpatch.pl's quiet option not print the summary on no
errors
From: Arjan van de Ven [EMAIL PROTECTED]
CC: [EMAIL PROTECTED]
Right now, in quiet mode, checkpatch.pl still prints a summary line even
if the
On Thu, Oct 25, 2007 at 01:48:14PM -0700, Andrew Morton wrote:
Andy, I thought we were going to whine about __inline__ and __inline, too?
Hmmm, I don't remember that coming up, but I'll add it to the todo. I
am assuming plain 'inline' is preferred over both of these -- yell if
you meant
On Sat, Oct 27, 2007 at 11:43:28AM +0100, Andy Whitcroft wrote:
On Thu, Oct 25, 2007 at 01:48:14PM -0700, Andrew Morton wrote:
Andy, I thought we were going to whine about __inline__ and __inline, too?
Hmmm, I don't remember that coming up, but I'll add it to the todo. I
am assuming
-by? And/or ack/nack's on my half-arsed theory above?
This code is definatly only used when SPARSEMEM is enabled, and VMEMMAP
is not which is not a combination we see on x86_64.
Acked-by: Andy Whitcroft [EMAIL PROTECTED]
Linus
--
From: Linus Torvalds [EMAIL PROTECTED]
Revert x86_64
On Tue, Oct 30, 2007 at 02:27:13PM -0500, Timur Tabi wrote:
I'm running checkpatch.pl (dated 10/17), and it complains about this line:
crc = __be32_to_cpu(* ((__be32 *) ((void *) firmware + calc_size)));
the message I get is:
ERROR: need space before that '*' (ctx:BxW)
#721: FILE:
On Tue, Oct 30, 2007 at 10:11:44PM -0700, Greg Kroah-Hartman wrote:
From: Keiichi Kii [EMAIL PROTECTED]
Fix typo.
Signed-off-by: Keiichi Kii [EMAIL PROTECTED]
Cc: Andy Whitcroft [EMAIL PROTECTED]
Cc: Randy Dunlap [EMAIL PROTECTED]
Signed-off-by: Greg Kroah-Hartman [EMAIL PROTECTED
Seems we are getting some kind of bug out of our s390x partition (lnxabat1)
when booting latest mainline releases, specifically since 2.6.23-git3.
Kernel BUG at 0002 Ýverbose debug info unavailable¨
illegal operation: 0001 Ý#1¨
Modules linked in: dm_mod sit tunnel4 ipv6 qeth ccwgroup
The check then is to see if a non {}'d block has no statements in it if the
ifdef is null. Hmmm. May be possible. Will think on it.
if (err)
+#ifdef CONFIG_GFAR_NAPI
napi_disable(priv-napi);
+#endif
-apw
-
To unsubscribe from this list: send the line unsubscribe
On Thu, Oct 18, 2007 at 01:13:52PM +0200, Ingo Molnar wrote:
latest checkpatch.pl works really well on sched.c.
there's only one problem left, this bogus false positive warning
reappeared:
WARNING: braces {} are not necessary for single statement blocks
#5710: FILE: sched.c:5710:
On Thu, Oct 18, 2007 at 08:25:21PM +0100, Andy Whitcroft wrote:
On Thu, Oct 18, 2007 at 01:13:52PM +0200, Ingo Molnar wrote:
latest checkpatch.pl works really well on sched.c.
there's only one problem left, this bogus false positive warning
reappeared:
WARNING: braces
On Thu, Oct 18, 2007 at 10:51:47PM +0200, Ingo Molnar wrote:
* Avi Kivity [EMAIL PROTECTED] wrote:
if (foo)
bar();
baz();
one();
detecting that would be awesome - it's often the sign of a real bug
because the intent is often to have bar() and
On Tue, Oct 23, 2007 at 08:44:20PM +0200, Jens Axboe wrote:
On Tue, Oct 23 2007, Kamalesh Babulal wrote:
Hi,
Kernel oops is triggered while running fsx-linux test, followed by cpu
softlock
over the AMD box
Unable to handle kernel NULL pointer dereference at 0018 RIP:
Seems that we are now getting strange errors mounting an ext2 root
filesystem under 2.6.23-git18:
EXT2-fs error (device sda1): ext2_check_page: bad entry in directory #2:
rec_len is smaller than minimal - offset=0, inode=0, rec_len=0,
name_len=0
This seems to be occuring consistently since
On Wed, Oct 24, 2007 at 03:59:00PM +0200, Jan Kara wrote:
Hello,
On Wed 24-10-07 14:15:40, Andy Whitcroft wrote:
Seems that we are now getting strange errors mounting an ext2 root
filesystem under 2.6.23-git18:
EXT2-fs error (device sda1): ext2_check_page: bad entry in directory
On Wed, Oct 24, 2007 at 05:03:03PM +0200, Jan Kara wrote:
e2image -r /dev/sda1 - | gzip -dc root-image.gz
This thing is 27MB, I'll try and find some space to hold it and
let you know where it is offlist.
-apw
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body
On Sun, Feb 10, 2008 at 03:33:02PM +0100, Marcin Slusarz wrote:
Hi
Checkpatch in current mainline outputs following errors:
$ ./scripts/checkpatch.pl -q --file ./fs/udf/misc.c
ERROR: need consistent spacing around '*' (ctx:WxV)
#205: FILE: fs/udf/misc.c:205:
+ tag *tag_p;
On Mon, Feb 11, 2008 at 06:58:08PM +0200, Benny Halevy wrote:
OK, but the return type doesn't have to be in the patched line, it could be in
a synchronization line or even missing if the function has a long multi-line
argument
list.
Ok, I guess thats fair criticism. Could you check out the
On Mon, Feb 11, 2008 at 06:05:48PM +0200, Benny Halevy wrote:
I saw this too with checkpatch.pl version 0.12
It seems like checkpatch.pl knows only about types derived
from @typeList by build_types.
Example below...
Benny
$ cat EOF | scripts/checkpatch.pl -
Signed-off-by: [EMAIL
On Wed, Feb 13, 2008 at 08:43:58PM +0100, Jan Engelhardt wrote:
On Feb 10 2008 15:33, Marcin Slusarz wrote:
Checkpatch in current mainline outputs following errors:
$ ./scripts/checkpatch.pl -q --file ./fs/udf/misc.c
ERROR: need consistent spacing around '*' (ctx:WxV)
#205: FILE:
On Fri, Feb 15, 2008 at 12:35:37AM +1100, Stephen Rothwell wrote:
Hi all,
I have created the first cut of the linux-next tree at
git://git.kernel.org/pub/scm/linux/kernel/git/sfr/linux-next.git.
Things to know about this tree:
It has two branches - master and stable. Stable is
On Thu, Feb 14, 2008 at 11:31:28AM -0800, Harvey Harrison wrote:
fastcall no longer exists in tree, remove it from checkpatch.
Signed-off-by: Harvey Harrison [EMAIL PROTECTED]
Seems to be true :) Have sucked this up for 0.15. Thanks.
-apw
---
scripts/checkpatch.pl |3 +--
1 files
On Fri, Feb 15, 2008 at 06:31:43PM +1100, Stephen Rothwell wrote:
Hi all,
I have created today's linux-next tree at
git://git.kernel.org/pub/scm/linux/kernel/git/sfr/linux-next.git.
Between each merge, the tree was built with allmodconfig for both
powerpc and x86_64.
You can see which
On Tue, Nov 06, 2012 at 03:36:25PM -0800, Andrew Morton wrote:
On Thu, 1 Nov 2012 00:12:18 -0700
Joe Perches j...@perches.com wrote:
Linux kernel doesn't like floating point, say so.
...
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2332,6 +2332,13 @@ sub process
On Thu, Nov 08, 2012 at 09:50:33PM +0800, Tao Ma wrote:
From: Tao Ma boyu...@taobao.com
In 9c0ece069, Linus removed feature-removal-schedule.txt from Documentation,
but there is still some reference to this file. So remove them.
Cc: Andrew Morton a...@linux-foundation.org
Cc: Andy
it is being phased out.
Cc: Andy Whitcroft a...@canonical.com
Signed-off-by: Kees Cook keesc...@chromium.org
---
scripts/checkpatch.pl |7 +++
1 file changed, 7 insertions(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 21a9f5d..37dc932 100755
--- a/scripts
Signed-off-by: Andy Whitcroft a...@canonical.com
---
drivers/firmware/efivars.c | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/drivers/firmware/efivars.c b/drivers/firmware/efivars.c
index ae50d2f..0bbf742 100644
--- a/drivers/firmware/efivars.c
+++ b/drivers
Signed-off-by: Andy Whitcroft a...@canonical.com
---
drivers/firmware/efivars.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/firmware/efivars.c b/drivers/firmware/efivars.c
index 4b12a8fd..ae50d2f 100644
--- a/drivers/firmware/efivars.c
+++ b/drivers
verify so deserve review.
On top of 7b218e8e5d433fc8b531ce911926e06de3e6f1f6 in Matt Flemmings efi.git
repo.
-apw
Andy Whitcroft (5):
efivarfs: efivarfs_file_read ensure we free data in error paths
efivarfs: efivarfs_create() ensure we drop our reference on inode on error
efivarfs
d_alloc_name() copies the passed name to new storage, once complete we
no longer need our name.
Signed-off-by: Andy Whitcroft a...@canonical.com
---
drivers/firmware/efivars.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/firmware/efivars.c b/drivers/firmware/efivars.c
index
When d_make_root() fails it will automatically drop the reference
on the root inode. We should not be doing so as well.
Signed-off-by: Andy Whitcroft a...@canonical.com
---
drivers/firmware/efivars.c | 16
1 file changed, 4 insertions(+), 12 deletions(-)
diff --git a/drivers
Ensure we free both the name and inode on error when building the
individual variables.
Signed-off-by: Andy Whitcroft a...@canonical.com
---
drivers/firmware/efivars.c | 20 ++--
1 file changed, 18 insertions(+), 2 deletions(-)
diff --git a/drivers/firmware/efivars.c b/drivers
On Thu, Oct 11, 2012 at 10:04:28PM +0800, Jeremy Kerr wrote:
Hi Andy,
@@ -969,16 +970,18 @@
return -ENOMEM;
list_for_each_entry_safe(entry, n, efivars-list, list) {
-struct inode *inode;
struct dentry *dentry, *root = efivarfs_sb-s_root;
-
my $asm_volatile =
qr{\b(__asm__|asm)\s+(__volatile__|volatile)\b};
if ($line =~ /\bvolatile\b/ $line !~ /$asm_volatile/) {
--
1.7.0.4
Looks sane and cirtainly if the file is gone we are gaining nothing with
this code.
Acked-by: Andy Whitcroft a...@canonical.com
-apw
This sounds an awful lot like the same problem I reported with fsck
hanging. I believe that Hugh had a candidate patch for that, which was
related to dirty tracking limits. It seems that that patch tested, and
acked by Peter. All on lkml under:
2.6.23-rc6-mm1 -- mkfs stuck in 'D'
-apw
if it does what you
need? I refactored it a bit applying it.
-apw
=== 8 ===
#!/usr/bin/perl -w
# (c) 2001, Dave Jones. [EMAIL PROTECTED] (the file handling bit)
# (c) 2005, Joel Schopp [EMAIL PROTECTED] (the ugly bit)
# (c) 2007, Andy Whitcroft [EMAIL PROTECTED] (new conditions, test suite, etc
Getting compile errors on S390:
CC arch/s390/mm/cmm.o
arch/s390/mm/cmm.c: In function `cmm_init':
arch/s390/mm/cmm.c:431: error: implicit declaration of function
`register_oom_notifier'
arch/s390/mm/cmm.c:443: error: implicit declaration of function
Seeing the following from an older power LPAR, pretty sure we had
this in the previous -mm also:
Unable to handle kernel paging request for data at address 0x
Faulting instruction address: 0xc0047ac8
cpu 0x0: Vector: 300 (Data Access) at [c058f750]
pc:
On Wed, Sep 19, 2007 at 07:44:03PM +0200, Sam Ravnborg wrote:
On Wed, Sep 19, 2007 at 10:28:48AM +0100, Andy Whitcroft wrote:
I am seeing this strange link error from a PowerMac G5 (powerpc):
[...]
KSYM.tmp_kallsyms2.S
AS .tmp_kallsyms2.o
LD vmlinux.o
2.6.23-rc6-mm1, 2.6.23-rc7-mm1 and 2.6.23-rc8-mm1 all fail to link
correctly on a powerpc machine (elm3b19) in our test grid. It fails as
below:
LD vmlinux.o
ld: dynreloc miscount for fs/built-in.o, section .opd
ld: can not edit opd Bad value
make: *** [vmlinux.o] Error 1
: passing arg 1 of
`vmemmap_section_start' makes pointer from integer without a cast
vmemmap_section_start() gets called with an argument which is unsigned long.
Signed-off-by: Badari Pulavarty [EMAIL PROTECTED]
Clearly correct.
Acked-by: Andy Whitcroft [EMAIL PROTECTED]
Index: linux
actually, my first patch wasn't using weak symbols, but I have been
convinced that it's the way to go(tm). Please see
http://lkml.org/lkml/2007/9/1/131 and the ongoing thread.
I am fine with replacing the brk randomization patch with the one that
wasn't using weak symbols (posted in the
On Fri, Sep 28, 2007 at 01:26:56AM -0700, Andrew Morton wrote:
On Fri, 28 Sep 2007 10:17:30 +0200 Thomas Gleixner [EMAIL PROTECTED] wrote:
can we please add this to checkpatch.pl ?
-spinlock_t bpci_lock = SPIN_LOCK_UNLOCKED;
+DEFINE_SPINLOCK(bpci_lock);
That check is already in
On Fri, Sep 28, 2007 at 04:37:49PM +0300, Pekka Enberg wrote:
Hi Andy,
On 9/28/07, Andy Whitcroft [EMAIL PROTECTED] wrote:
That is unfair. Every time we discuss it I state that I disagree that
hiding mostly useful tests is a good thing. I would love the tests to
be 100% accurate
On Fri, Sep 28, 2007 at 12:49:35PM +0200, Ingo Molnar wrote:
* Andy Whitcroft [EMAIL PROTECTED] wrote:
On Fri, Sep 28, 2007 at 11:39:02AM +0200, Ingo Molnar wrote:
And this is not about any particular false positive. I dont mind an
advanced mode non-default opt-in option
On Fri, Sep 28, 2007 at 11:39:02AM +0200, Ingo Molnar wrote:
* Andy Whitcroft [EMAIL PROTECTED] wrote:
WARNING: multiple assignments should be avoided
#2319:
+ max_load = this_load = total_load = total_pwr = 0;
That warning is non-bogus, although this is one
On Fri, Sep 28, 2007 at 10:40:03AM +0200, Ingo Molnar wrote:
* Andy Whitcroft [EMAIL PROTECTED] wrote:
This version brings a number of new checks, and a number of bug fixes.
your checkpatch patch itself produces 22 warnings ...
i ran it over kernel/sched.c and there are many bogus
On Fri, Sep 28, 2007 at 02:01:32AM -0700, Andrew Morton wrote:
On Fri, 28 Sep 2007 10:40:03 +0200 Ingo Molnar [EMAIL PROTECTED] wrote:
i ran it over kernel/sched.c and there are many bogus warnings that i
reported to you earlier:
WARNING: multiple assignments should be avoided
On Fri, Sep 28, 2007 at 10:32:38AM +0200, Thomas Gleixner wrote:
On Fri, 2007-09-28 at 01:26 -0700, Andrew Morton wrote:
On Fri, 28 Sep 2007 10:17:30 +0200 Thomas Gleixner [EMAIL PROTECTED]
wrote:
can we please add this to checkpatch.pl ?
-spinlock_t bpci_lock =
On Fri, Sep 28, 2007 at 10:46:42AM -0700, Andrew Morton wrote:
On Fri, 28 Sep 2007 14:21:38 +0100 Andy Whitcroft [EMAIL PROTECTED] wrote:
On Fri, Sep 28, 2007 at 12:49:35PM +0200, Ingo Molnar wrote:
* Andy Whitcroft [EMAIL PROTECTED] wrote:
On Fri, Sep 28, 2007 at 11:39:02AM
On Mon, Oct 01, 2007 at 12:30:07AM -0700, Andrew Morton wrote:
On Mon, 1 Oct 2007 08:44:48 +0200 Ingo Molnar [EMAIL PROTECTED] wrote:
(lkml Cc:-ed - this might be of interest to others too)
* Andy Whitcroft [EMAIL PROTECTED] wrote:
WARNING: EXPORT_SYMBOL(foo); should immediately
On Tue, Oct 02, 2007 at 09:01:10AM +0200, Andi Kleen wrote:
x86_64-sparsemem_vmemmap-2m-page-size-support.patch
x86_64-sparsemem_vmemmap-vmemmap-x86_64-convert-to-new-helper-based-initialisation.patch
Look like these two should be merged together
Also I'm concerned about a third
On Thu, Sep 06, 2007 at 10:07:12AM -0700, Shannon Nelson wrote:
list_for_each_entry(iter, desc-async_tx.tx_list, node) {
iter-hw-src_addr = addr;
addr += ioat_chan-xfercap;
+
+ if (--cnt == 0);
+ break;
}
}
@@
Am seeing the following compile error on all of my powerpc platforms:
CC kernel/sched.o
kernel/sched.c: In function `cpu_to_phys_group':
kernel/sched.c:5937: error: `per_cpu__cpu_sibling_map' undeclared (first use
in this function)
kernel/sched.c:5937: error: (Each undeclared
I have a couple of old NUMA-Q systems which are unable to read their
boot disks with 2.6.23-rc4-mm1. The disks appear to be recognised and
even the partition tables read correctly, and then they go pop:
qla1280: QLA1040 found on PCI bus 0, dev 10
Clocksource tsc unstable (delta = 99922590
node with no memory we will not start one and we end up
with a node with memory and no kswapd. Bad.
As kswapd_run is a no-op when a kswapd already exists this seems a safe
way to fix that. Paul's -zone conversion is obviously correct also.
Acked-by: Andy Whitcroft [EMAIL PROTECTED]
-apw
I have a couple of failed test runs against 2.6.23-rc6 where the
job timed out while running dbench over ext3. Both on powerpc,
though both significantly different hardware setups. A failed
run like this implies that the machine was still responsive to
other processes but the dbench was making
Annoyingly this seems to be intermittent, and I have not managed to get
a machine into this state again yet. Will keep trying.
-apw
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
The following commit just hit mainline and all my powerpc test boxes are
failing during compilation:
commit f629307c857c030d5a3dd777fee37c8bb395e171
tty: termios locking functions break with new termios type
Failing as follows:
drivers/char/tty_ioctl.c: In function
Kok, Auke wrote:
Andy Whitcroft wrote:
This version brings a number of new checks, and a number of bug
fixes. Of note:
- warnings for multiple assignments per line
This is bugged. e.g. the following line will hit this exception check:
int i = some_function(a, b, c);
Yep
Andrew Morton wrote:
On Tue, 24 Jul 2007 10:06:51 +0100 Andy Whitcroft [EMAIL PROTECTED] wrote:
This is a royal pain, since it now throws an ERROR for the obviously
preferable piece of code below:
if (err) {
do_something();
return -ERR;
} else {
do_somthing_else();
}
Hmmm
Kok, Auke wrote:
Andy Whitcroft wrote:
This version brings a number of new checks, and a number of bug
fixes. Of note:
- warnings for multiple assignments per line
- warnings for multiple declarations per line
- checks for single statement blocks with braces
This patch includes
Andrew Morton wrote:
+start_sector = req-sector*priv-blocking_factor;
+sectors = req-nr_sectors*priv-blocking_factor;
s/*/ * /. checkpatch missed this.
Ok, this is something we need to decide on. Currently we only ask for
consistent spacing on all the mathematic operators. This
Adrian Bunk wrote:
On Tue, Jul 24, 2007 at 08:58:25AM -0500, jschopp wrote:
within the last 3 weeks, this script went from *really usable* to *a big
noise maker*.
As we (mostly Andy of late) add more checks (good) there is bound to be
some code we just didn't forsee that generates false
of success is provided. It seems preferable
to fail a allocations above this order/ than killing things to try and
make it available. As higher order users already have to handle failure
to allocate they should be best equipped to continue.
Acked-by: Andy Whitcroft [EMAIL PROTECTED]
---
page_alloc.c
Jan Engelhardt wrote:
On Jul 23 2007 16:36, Kok, Auke wrote:
this somehow seems to match something completely non-related (a function
pointer declaration case):
ERROR: no space between function name and open parenthesis '('
#7278: FILE: drivers/net/e1000e/hw.h:434:
+ bool
Randy Dunlap wrote:
On Tue, 24 Jul 2007 10:20:35 -0700 Randy Dunlap wrote:
On Tue, 24 Jul 2007 18:51:39 +0200 (CEST) Jan Engelhardt wrote:
On Jul 24 2007 12:19, Andy Whitcroft wrote:
if (err) {
do_something();
return -ERR;
} else {
do_somthing_else();
}
if (err
Jan Engelhardt wrote:
On Jul 25 2007 02:22, Paul Mundt wrote:
Perhaps CodingStyle can start being versioned, so people can opt out of
certain 'improvements' whenever someone has a vision, much like some
nameless licenses.
I'd say Codingstyle is versioned by means of git commit IDs.
Jan Engelhardt wrote:
On Jul 24 2007 12:33, Andy Whitcroft wrote:
Warning on multiple declarations on a line is nice, but IMO really too
verbose (why is int i, j; bad? Did C somehow change syntax today?).
No the normal response is two fold:
1) what the heck are i and j those are meaningless
#ifdef
'incorrectly' and as such is a merge error. This should probabally be
considered a fix to this patch:
fix-corruption-of-memmap-on-ia64-sparsemem-when-mem_section-is-not-a-power-of-2.patch
Acked-by: Andy Whitcroft [EMAIL PROTECTED]
-apw
-
To unsubscribe from this list: send the line unsubscribe
Of the machines we test releases on automatically this only compiles on
NUMA-Q and does not boot there (some PCI issue).
ppc64 (beavis):
drivers/built-in.o(.text+0xd2784): In function `.srp_rport_add':
: undefined reference to `.scsi_tgt_it_nexus_create'
drivers/built-in.o(.text+0xd2884): In
On Wed, Jul 25, 2007 at 05:36:56PM +0100, Andy Whitcroft wrote:
Will investigate the NUMA-Q explosion and report on that separatly.
Ok, I've been looking at the NUMA-Q boot panic below:
BUG: unable to handle kernel NULL pointer dereference at virtual address
printing eip:
c111689f
Andy Whitcroft wrote:
KAMEZAWA Hiroyuki wrote:
Fix sparsemem_vmemmap init. sorry if known bug.
This patch fixes page table handling in sparsemem_vmammap.
Without this, part of vmem_map is not mapped because each section's start
addr of
mem_map is not aligned to PGD/PMD/PUD.
(In ia64
table was introduced:
commit 89689ae7f95995723fbcd5c116c47933a3bb8b13
[PATCH] Get rid of zone_table[]
That conversion inadvertantly only initialised the node mapping in
SPARSEMEM_EXTREME. Ensure we initialise the node mapping in
SPARSEMEM_STATIC.
Signed-off-by: Andy Whitcroft [EMAIL
on. The start of the second
PMD is missed.
Ahh yes, that I think is what your diagram shows. Yes this is pretty
clearly wrong for any sort of offset initialisation, and would be worse
lower down in the hierachy. This seems like a clean way to fix the bug.
Thanks for finding this.
Acked-by: Andy
On Wed, Aug 22, 2007 at 11:10:29AM -0700, Andrew Morton wrote:
[...]
CC arch/x86_64/kernel/asm-offsets.s
arch/x86_64/kernel/asm-offsets.c:1: error: -mpreferred-stack-boundary=3
is not between 4 and 12
make[1]: *** [arch/x86_64/kernel/asm-offsets.s] Error 1
[...]
Andi Kleen wrote:
On Thu, Aug 23, 2007 at 01:03:18PM +0100, Andy Whitcroft wrote:
It seems that this is a problem caused by the way we check for
compiler options in x86_64. Each compiler flag is checked for
individually and if available added to cflags-y, later that is
added to CFLAGS
Andrew Morton wrote:
On Wed, 22 Aug 2007 14:15:16 -0500
Dean Nelson [EMAIL PROTECTED] wrote:
On Wed, Aug 22, 2007 at 11:04:22AM -0700, Andrew Morton wrote:
On Wed, 22 Aug 2007 12:00:11 -0500
Dean Nelson [EMAIL PROTECTED] wrote:
3) WARNING: declaring multiple variables together should be
Andrew Morton wrote:
+for_each_possible_cpu(cpu) {
+rbdp = per_cpu(rcu_boost_dat, cpu);
+for (i = 0; i RCU_BOOST_ELEMENTS; i++) {
+rbdp[i].rbs_mutex = SPIN_LOCK_UNLOCKED;
Doesn't this confound lockdep? We're supposed to use
Mike Frysinger wrote:
in some code that does like:
#define foo { a, b, c, \
d, e, f, g }
...
int boo[] = foo;
...
checkpatch.pl throws a fit:
ERROR: Macros with complex values should be enclosed in parenthesis
#10: FILE: ...
+#define foo {a, b, c, d}
perhaps the check should
Andi Kleen wrote:
This reserved portion of the KVA must be PMD aligned.
Why do they need to be PMD aligned?
That comes from the fact that the KVA in x86 has traditionally been
mapped with huge pages where at all possible, for performance reasons.
The purpose of the remap itself always has
Andi Kleen wrote:
On Fri, Aug 24, 2007 at 06:44:38PM +0100, Mel Gorman wrote:
On (24/08/07 19:38), Andi Kleen didst pronounce:
Other than the fact that the memmap must be PMD aligned to use hugepage
entries for the memmap.
Why is that so? mem_map should be just part of lowmem anyways.
Not
jschopp wrote:
+# check for pointless casting of kmalloc return
+if ($rawline =~ /\*\)[ ]k[czm]alloc/) {
It looks to me like this will catch
foo = (char *) kmalloc(512);
but not
for = (char* )kmalloc(512);
I haven't tried it but how about something like:
if($rawline
: [EMAIL PROTECTED]
S: Supported
+F: scripts/checkpatch.pl
COMMON INTERNET FILE SYSTEM (CIFS)
P: Steve French
If this system goes in (and it seems sane enough) then this entry update
seems comprehensive.
Acked-by: Andy Whitcroft [EMAIL PROTECTED]
-apw
-
To unsubscribe from this list
. It seems more correct to
follow this model when the SLIT information is missing or corrupt.
This patch updates the SLIT failure paths to fill in the NUMA node
distance table with this default.
Signed-off-by: Andy Whitcroft [EMAIL PROTECTED]
---
arch/ia64/kernel/acpi.c | 62
Eugene Teo wrote:
Make checkpatch rant about trailing ; at the end of if expression.
Thanks to Auke for the regexp.
Signed-off by: Eugene Teo [EMAIL PROTECTED]
--- checkpatch.pl-0.09.default2007-08-03 23:31:40.0 +0800
+++ checkpatch.pl-0.092007-08-16
A couple of people suggested adding checks to checkpatch for trailing
semicolons on conditionals, where the conditional block may not be
actually conditional:
if (err);
return err;
While regression testing the changes, I ran these checks across the
whole of 2.6.23-rc3 and
It seems an extraneous trailing ';' has slipped into the skb length
checks in u32_match_it() triggering an unconditional missmatch.
Signed-off-by: Andy Whitcroft [EMAIL PROTECTED]
Cc: [EMAIL PROTECTED]
---
net/netfilter/xt_u32.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff
It seems we have gained an extraneous trailing ';' on one of the
wait loops in scif_sercon_putc(). Although this is completely
benign as the apparent payload is also the empty statement, it
invites error in the future. Clean it up now.
Signed-off-by: Andy Whitcroft [EMAIL PROTECTED]
Cc: Paul
Seems that a trailing ';' has slipped onto the end of the
get_slice_psize checks under CONFIG_PPC_MM_SLICES causing us to
return unconditionally and never preload.
Signed-off-by: Andy Whitcroft [EMAIL PROTECTED]
Cc: Paul Mackerras [EMAIL PROTECTED]
Cc: [EMAIL PROTECTED]
---
arch/powerpc/mm
Seems that a trailing ';' has slipped onto the end of the access_ok
check here, such that we will always return -EFAULT.
Signed-off-by: Andy Whitcroft [EMAIL PROTECTED]
Cc: Ralf Baechle [EMAIL PROTECTED]
Cc: [EMAIL PROTECTED]
---
arch/mips/kernel/irixsig.c |2 +-
1 files changed, 1
It seems a trailing ';' has slipped into mlx4_MAD_IFC() which causes
the response to be copied out unconditionally.
Signed-off-by: Andy Whitcroft [EMAIL PROTECTED]
Cc: Roland Dreier [EMAIL PROTECTED]
Cc: Sean Hefty [EMAIL PROTECTED]
Cc: Hal Rosenstock [EMAIL PROTECTED]
Cc: [EMAIL PROTECTED
501 - 600 of 940 matches
Mail list logo
