Re: [PATCH] update checkpatch.pl to version 0.10

On Fri, Sep 28, 2007 at 04:37:49PM +0300, Pekka Enberg wrote: > Hi Andy, > > On 9/28/07, Andy Whitcroft <[EMAIL PROTECTED]> wrote: > > That is unfair. Every time we discuss it I state that I disagree that > > hiding mostly useful tests is a good thing. I would l

Re: [PATCH] update checkpatch.pl to version 0.10

On Fri, Sep 28, 2007 at 12:49:35PM +0200, Ingo Molnar wrote: > > * Andy Whitcroft <[EMAIL PROTECTED]> wrote: > > > On Fri, Sep 28, 2007 at 11:39:02AM +0200, Ingo Molnar wrote: > > > > > And this is not about any particular false positive. I dont mind an &

Re: [PATCH] update checkpatch.pl to version 0.10

On Fri, Sep 28, 2007 at 11:39:02AM +0200, Ingo Molnar wrote: > > * Andy Whitcroft <[EMAIL PROTECTED]> wrote: > > > > > WARNING: multiple assignments should be avoided > > > > #2319: > > > > + max_load = this_load = total_load = to

Re: [PATCH] update checkpatch.pl to version 0.10

On Fri, Sep 28, 2007 at 10:40:03AM +0200, Ingo Molnar wrote: > > * Andy Whitcroft <[EMAIL PROTECTED]> wrote: > > > This version brings a number of new checks, and a number of bug fixes. > > your checkpatch patch itself produces 22 warnings ... >

Re: [PATCH] update checkpatch.pl to version 0.10

On Fri, Sep 28, 2007 at 02:01:32AM -0700, Andrew Morton wrote: > On Fri, 28 Sep 2007 10:40:03 +0200 Ingo Molnar <[EMAIL PROTECTED]> wrote: > > > i ran it over kernel/sched.c and there are many bogus warnings that i > > reported to you earlier: > > > > WARNING: multiple assignments should be

Re: [PATCH] spin_lock_unlocked cleanups

On Fri, Sep 28, 2007 at 10:32:38AM +0200, Thomas Gleixner wrote: > On Fri, 2007-09-28 at 01:26 -0700, Andrew Morton wrote: > > On Fri, 28 Sep 2007 10:17:30 +0200 Thomas Gleixner <[EMAIL PROTECTED]> > > wrote: > > > > > can we please add this to checkpatch.pl ? > > > > > > > -spinlock_t

Re: [PATCH] update checkpatch.pl to version 0.10

On Fri, Sep 28, 2007 at 10:46:42AM -0700, Andrew Morton wrote: > On Fri, 28 Sep 2007 14:21:38 +0100 Andy Whitcroft <[EMAIL PROTECTED]> wrote: > > > On Fri, Sep 28, 2007 at 12:49:35PM +0200, Ingo Molnar wrote: > > > > > > * Andy Whitcroft <[EMAIL PROTECTED

Re: checkpatch and kernel/sched.c

On Mon, Oct 01, 2007 at 12:30:07AM -0700, Andrew Morton wrote: > On Mon, 1 Oct 2007 08:44:48 +0200 Ingo Molnar <[EMAIL PROTECTED]> wrote: > > > > > (lkml Cc:-ed - this might be of interest to others too) > > > > * Andy Whitcroft <[EMAIL PROTECTED]> wr

Re: x86 patches was Re: -mm merge plans for 2.6.24

On Tue, Oct 02, 2007 at 09:01:10AM +0200, Andi Kleen wrote: > x86_64-sparsemem_vmemmap-2m-page-size-support.patch > x86_64-sparsemem_vmemmap-vmemmap-x86_64-convert-to-new-helper-based-initialisation.patch > > Look like these two should be merged together > > Also I'm concerned about a

Re: 2.6.24-rc2-mm1 (memory hotplug x86_64/vmemmap fix)

r to back the page tables that are used to create the mapping. > * Uses the main allocators if they are available, else bootmem. > @@ -44,7 +55,7 @@ void * __meminit vmemmap_alloc_block(uns > return page_address(page); > return NULL; > } else > -

Re: 2.6.24-rc2-mm1 -- strange apparent network failures

When testing some of the later 2.6.24-rc2-mm1+hotfix combinations on three of our test systems one job from each batch (1/4) failed. In each case the machine appears to have booted normally all the way to a login: prompt. However in the failed boots the networking though apparently initialised

Re: 2.6.24-rc2-mm1 -- QLogics ISP1020 gone missing

All of our machines with QLogics ISP1020 cards seem to have lost them on boot with 2.6.24-rc1-mm1+hotfixes. # lspci :00:0a.0 SCSI storage controller: QLogic Corp. ISP1020 Fast-wide SCSI (rev 05) # lspci -n :00:0a.0 0100: 1077:1020 (rev 05) # lspci -v -v :00:0a.0 SCSI storage

Re: 2.6.24-rc2-mm1 -- strange apparent network failures

On Fri, Nov 16, 2007 at 09:16:58PM -0800, Andrew Morgan wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Hi, > > This warning is just saying that you might want to reconsider > recompiling your dhclient with a newer libcap - which has native support > for 64-bit capabilities. This is

Re: [PATCH] checkpatch: Print filenames of patches

On Sun, Nov 18, 2007 at 11:03:47AM +0100, Geert Uytterhoeven wrote: > checkpatch: Print filenames of patches instead of the very uninformative > `Your patch'. Well this isn't quite enough as we often use this thing checking its stdin. Which leads to an even less useful '- has no obvious ...'. I

Re: mm snapshot broken-out-2007-11-20-01-45.tar.gz -- powerpc panic

I have one powerpc machine which managed to compile this snapshot! It paniced on boot as below, might be nfs so copied them. General results are popping out on TKO. -apw Freeing initrd memory: 1224k freed Installing knfsd (copyright (C) 1996 [EMAIL PROTECTED]). Unable to handle kernel paging

Re: [PATCH][try 2] architectural pstate driver for powernow-k8

On Tue, Oct 09, 2007 at 03:43:20PM -0500, Mark Langsdorf wrote: > On Tuesday 09 October 2007 15:06, Andi Kleen wrote: > > "Mark Langsdorf" <[EMAIL PROTECTED]> writes: > > > > > This patch should apply cleanly to the 2.6.22.6 kernel. > > > > Isn't that a little old? The earliest this could be

Re: [PATCH] 0/3 checkpatch updates, new checkfiles script

On Sun, Oct 07, 2007 at 03:05:47PM -0400, Erez Zadok wrote: > > and got many perl warnings such as: > > Use of uninitialized value in concatenation (.) or string at > ./scripts/checkpatch.pl line 455. Yes, this support seems to be wholy broken, as a non emacs user I had failed to test it

Re: [PATCH] fix minor problems in checkpatch.pl-next

On Thu, Oct 11, 2007 at 08:28:00AM -0400, Mike D. Day wrote: > When forming the prefix to output error msgs in gnu gcc format, the > lack of a type ($ or @) when referencing ARGV causes error messages. > > When invoked to check source files, the linenumber was off by +3 in > the gcc format

Re: [PATCH] checkpatch: Fix line number reporting

On Fri, Oct 12, 2007 at 03:26:54PM -0400, Mike D. Day wrote: > Fix line number reporting when checking source files (as opposed to > patches) > > Signed-off-by: Mike D. Day <[EMAIL PROTECTED]> Sorry you've had to fix this about 4 times, mostly because of ongoing changes, and slow replication

Re: 2.6.23-rc6-mm1

On Tue, Sep 18, 2007 at 02:43:48PM +0530, Kamalesh Babulal wrote: > Andrew Morton wrote: > >ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23-rc6/2.6.23-rc6-mm1/ > > > >2.6.23-rc6-mm1 is a 29MB diff against 2.6.23-rc6. > > > > > > > Hi Andrew, > > The 2.6.23-rc6-mm1build

2.6.23-rc6-mm1 -- powerpc link failure

I am seeing this strange link error from a PowerMac G5 (powerpc): [...] KSYM.tmp_kallsyms2.S AS .tmp_kallsyms2.o LD vmlinux.o ld: dynreloc miscount for fs/built-in.o, section .opd ld: can not edit opd Bad value make: *** [vmlinux.o] Error 1 Compiler version

2.6.23-rc6-mm1 -- powerpc pSeries_log_error panic in rtas_call/early_enable_eeh

Seeing the following panic booting an old powerpc LPAR: Unable to handle kernel paging request for data at address 0x Faulting instruction address: 0xc0047b48 cpu 0x0: Vector: 300 (Data Access) at [c06a3750] pc: c0047b48: .pSeries_log_error+0x364/0x420 lr:

2.6.23-rc6-mm1 -- mkfs stuck in 'D'

Seems I have a case of a largish i386 NUMA (NUMA-Q) which has a mkfs stuck in a 'D' wait: === mkfs.ext2 D c10220f4 0 6233 6222 c344fc80 0082 0286 c10220f4 c344fc90 002ed099 c2963340 c2b9f640 c142bce0 c2b9f640 c344fc90 002ed099 c344fcfc

Re: 2.6.23-rc6-mm1 -- powerpc link failure

On Wed, Sep 19, 2007 at 06:36:29PM +0200, Segher Boessenkool wrote: > >I am seeing this strange link error from a PowerMac G5 (powerpc): > > > > [...] > >KSYM.tmp_kallsyms2.S > >AS .tmp_kallsyms2.o > >LD vmlinux.o > > ld: dynreloc miscount for fs/built-in.o, section

Re: 2.6.23-rc6: hanging ext3 dbench tests

On Fri, Sep 14, 2007 at 10:49:05AM +0100, Andy Whitcroft wrote: > On Tue, Sep 11, 2007 at 06:30:49PM +0100, Andy Whitcroft wrote: > > Annoyingly this seems to be intermittent, and I have not managed to get > > a machine into this state again yet. Will keep trying. > > Ok,

Re: [Celinux-dev] [Announce] Linux-tiny project revival

On Thu, Sep 20, 2007 at 12:38:55AM +0200, Michael Opdenacker wrote: > Andrew, you're completely right... The patches should all aim at being > included into mainline or die. > > I'm finishing a sequence of crazy weeks and I will have time to send you > patches one by one next week, starting with

Re: error from checkpatch.pl version 0.10

On Thu, Sep 20, 2007 at 07:19:59PM +0530, Satyam Sharma wrote: > > > On Thu, 20 Sep 2007, Tetsuo Handa wrote: > > > > I checked my patch using checkpatch.pl version 0.10 > > and I got the following error. > > > > ERROR: need consistent spacing around '*' (ctx:WxV) > > #2334: FILE:

Re: Processes spinning forever, apparently in lock_timer_base()?

This sounds an awful lot like the same problem I reported with fsck hanging. I believe that Hugh had a candidate patch for that, which was related to dirty tracking limits. It seems that that patch tested, and acked by Peter. All on lkml under: 2.6.23-rc6-mm1 -- mkfs stuck in 'D' -apw

Re: [PATCH] emacs compile window support for checkpatch version .10

and tell me if it does what you need? I refactored it a bit applying it. -apw === 8< === #!/usr/bin/perl -w # (c) 2001, Dave Jones. <[EMAIL PROTECTED]> (the file handling bit) # (c) 2005, Joel Schopp <[EMAIL PROTECTED]> (the ugly bit) # (c) 2007, Andy Whitcroft <[EMAIL PROTEC

2.6.23-rc7-mm1 -- s390 compile failures

Getting compile errors on S390: CC arch/s390/mm/cmm.o arch/s390/mm/cmm.c: In function `cmm_init': arch/s390/mm/cmm.c:431: error: implicit declaration of function `register_oom_notifier' arch/s390/mm/cmm.c:443: error: implicit declaration of function

2.6.23-rc7-mm1 -- powerpc rtas panic

Seeing the following from an older power LPAR, pretty sure we had this in the previous -mm also: Unable to handle kernel paging request for data at address 0x Faulting instruction address: 0xc0047ac8 cpu 0x0: Vector: 300 (Data Access) at [c058f750] pc:

Re: [BUG] 2.6.23-git18 Kernel oops in sg helpers

On Tue, Oct 23, 2007 at 08:44:20PM +0200, Jens Axboe wrote: > On Tue, Oct 23 2007, Kamalesh Babulal wrote: > > Hi, > > > > Kernel oops is triggered while running fsx-linux test, followed by cpu > > softlock > > over the AMD box > > > > Unable to handle kernel NULL pointer dereference at

2.6.23-git18: ext2_check_page: bad entry in directory

Seems that we are now getting strange errors mounting an ext2 root filesystem under 2.6.23-git18: EXT2-fs error (device sda1): ext2_check_page: bad entry in directory #2: rec_len is smaller than minimal - offset=0, inode=0, rec_len=0, name_len=0 This seems to be occuring consistently since

Re: 2.6.23-git18: ext2_check_page: bad entry in directory

On Wed, Oct 24, 2007 at 03:59:00PM +0200, Jan Kara wrote: > Hello, > > On Wed 24-10-07 14:15:40, Andy Whitcroft wrote: > > Seems that we are now getting strange errors mounting an ext2 root > > filesystem under 2.6.23-git18: > > > > EXT2-fs error (device

Re: 2.6.23-git18: ext2_check_page: bad entry in directory

On Wed, Oct 24, 2007 at 05:03:03PM +0200, Jan Kara wrote: > e2image -r /dev/sda1 - | gzip -dc root-image.gz This thing is 27MB, I'll try and find some space to hold it and let you know where it is offlist. -apw - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the

Re: [PATCH v2] bitops kernel-doc: inline instead of macro

On Thu, Oct 25, 2007 at 01:48:14PM -0700, Andrew Morton wrote: > Andy, I thought we were going to whine about __inline__ and __inline, too? Hmmm, I don't remember that coming up, but I'll add it to the todo. I am assuming plain 'inline' is preferred over both of these -- yell if you meant

Re: [PATCH v2] bitops kernel-doc: inline instead of macro

On Sat, Oct 27, 2007 at 11:43:28AM +0100, Andy Whitcroft wrote: > On Thu, Oct 25, 2007 at 01:48:14PM -0700, Andrew Morton wrote: > > > Andy, I thought we were going to whine about __inline__ and __inline, too? > > Hmmm, I don't remember that coming up, but I'll add it to

Re: 2.6.24-rc1-git15 Kernel build fails on powerpc - Unrecognized opcode: `dssall'

On Tue, Nov 06, 2007 at 07:09:40PM +0530, Balbir Singh wrote: > Kamalesh Babulal wrote: > > David Miller wrote: > >> From: Johannes Berg <[EMAIL PROTECTED]> > >> Date: Tue, 06 Nov 2007 11:54:46 +0100 > >> > > CHK include/linux/compile.h > > AS arch/powerpc/kernel/swsusp_32.o >

Re: Warning: commit message does not conform to UTF-8. (mmotm "10-Nov-2007 22:46")

On Sat, Nov 10, 2007 at 07:30:57PM -0500, Erez Zadok wrote: > Andrew, > > I'm getting minor warnings when applying two patches from > > > It's probably not serious but I wonder if checkpatch catches this. > > Applying patch..git-net.patch > Warning:

Re: checkpatch.pl and no newline handling

On Mon, Nov 12, 2007 at 02:46:30PM -0500, Mike Frysinger wrote: > the current checkpatch.pl does not reject new files that lack a > newline, yet rejects patches that fix newlines in files ... quite the > opposite of what we actually want Nice. Just what the world needs. I wonder what the heck

Re: checkpatch.pl and no newline handling

On Mon, Nov 12, 2007 at 02:46:30PM -0500, Mike Frysinger wrote: > the current checkpatch.pl does not reject new files that lack a > newline, yet rejects patches that fix newlines in files ... quite the > opposite of what we actually want [EMAIL PROTECTED] echo -n "moo" >no-newline.c [EMAIL

[PATCH] update checkpatch.pl to version 0.12

ent blocks - handle patches which introduce or remove lines without newlines Andy Whitcroft (19): Version: 0.12 style fixes as spotted by checkpatch add a --terse options of a single line of output per report block brace checks should only apply for single line blocks al

Re: 2.6.24-rc2-mm1 -- mkfs failing on variety of fs types

We seem to have some general problem with mkfs for all filesystems. I am seeing this across at least three test systems although most are unable to compile this kernel :(, even with the hotfix. Basically, all mkfs operations for any filsystem type are failing, ext2 reports this as "short write",

Re: checkpatch: ERROR: Does not appear to be a unified-diff format patch

On Sat, Oct 13, 2007 at 02:55:01PM +0200, Jan Engelhardt wrote: > > On Oct 13 2007 14:47, Adrian Bunk wrote: > >On Sat, Oct 13, 2007 at 02:28:00PM +0200, Geert Uytterhoeven wrote: > >> scripts/checkpatch.pl doesn't seem to like this patch: > >> > >> $ scripts/checkpatch.pl

Re: [PATCH] checkpatch: Fix line number reporting

On Sat, Oct 13, 2007 at 02:35:12PM -0400, Erez Zadok wrote: > In message <[EMAIL PROTECTED]>, Andy Whitcroft writes: > > On Fri, Oct 12, 2007 at 03:26:54PM -0400, Mike D. Day wrote: > > > Fix line number reporting when checking source files (as opposed to > > >

Re: [BUG] 2.6.23-git8 kernel oops at __rb_rotate_left+0x7/0x70

On Tue, Oct 16, 2007 at 11:10:12AM +0200, Ingo Molnar wrote: > > * Kamalesh Babulal <[EMAIL PROTECTED]> wrote: > > > While running kernbench with the 2.6.23-git8 following oops is > > produced > > > > Unable to handle kernel NULL pointer dereference at 0010 RIP: > > []

Re: [BUG] 2.6.23-git8 kernel oops at __rb_rotate_left+0x7/0x70

On Tue, Oct 16, 2007 at 11:46:31AM +0200, Ingo Molnar wrote: > > * Ingo Molnar <[EMAIL PROTECTED]> wrote: > > > > > * Kamalesh Babulal <[EMAIL PROTECTED]> wrote: > > > > > While running kernbench with the 2.6.23-git8 following oops is > > > produced > > > > > > Unable to handle kernel NULL

[PATCH] update checkpatch.pl to version 0.11

revamp of the unary detection to make it more parser like - a new summary at the bottom of the report - --strict option for subjective checks - --file to enable checking on complete files - support for use in emacs "compile" window Andy Whitcroft (27): Version: 0.11

Re: [BUG] 2.6.23-git8 kernel oops at __rb_rotate_left+0x7/0x70

On Tue, Oct 16, 2007 at 07:00:37PM +0100, Andy Whitcroft wrote: > On Tue, Oct 16, 2007 at 11:46:31AM +0200, Ingo Molnar wrote: > > > > * Ingo Molnar <[EMAIL PROTECTED]> wrote: > > > > > > > > * Kamalesh Babulal <[EMAIL PROTECTED]> wrote: >

Re: [BUG] 2.6.23-git8 kernel oops at __rb_rotate_left+0x7/0x70

o noticed that it's not valid to call into > task_new_fair() if this_cpu != task_cpu(p). > > Reported-by: Kamalesh Babulal <[EMAIL PROTECTED]> > Reported-by: Andy Whitcroft <[EMAIL PROTECTED]> > Signed-off-by: Ingo Molnar <[EMAIL PROTECTED]> I have submitt

[PATCH] update checkpatch.pl to version 0.11

mpile" window Andy Whitcroft (27): Version: 0.11 fix up cat_vet for the case where there are no control characters any cast to a pointer introduces a type cpp unary operator detection needs to float attributes are also valid in type definitions sizeof may be

Re: [BUG] 2.6.23-git8 kernel oops at __rb_rotate_left+0x7/0x70

On Wed, Oct 17, 2007 at 04:52:26PM +0200, Ingo Molnar wrote: > > We (myself, Kamalesh and Dhaval) have tested the patch below, w/o > > being able to recreate the problem. The patch allows for > > task_new_fair() to be called even for the case when child is being > > added to another cpu's

Re: [PATCH] checkpatch: Fix line number reporting

On Tue, Oct 16, 2007 at 01:59:49PM -0400, Erez Zadok wrote: > In message <[EMAIL PROTECTED]>, Andy Whitcroft writes: > > On Sat, Oct 13, 2007 at 02:35:12PM -0400, Erez Zadok wrote: > > > In message <[EMAIL PROTECTED]>, Andy Whitcroft writes: > > > > On Fri

s390x: getting ipv6 bugs on mainline since 2.6.23-git3

Seems we are getting some kind of bug out of our s390x partition (lnxabat1) when booting latest mainline releases, specifically since 2.6.23-git3. Kernel BUG at 0002 Ýverbose debug info unavailable¨ illegal operation: 0001 Ý#1¨ Modules linked in: dm_mod sit tunnel4 ipv6 qeth ccwgroup

Re: [PATCH][NET] gianfar: fix obviously wrong #ifdef CONFIG_GFAR_NAPI placement

The check then is to see if a non {}'d block has no statements in it if the ifdef is null. Hmmm. May be possible. Will think on it. if (err) +#ifdef CONFIG_GFAR_NAPI napi_disable(>napi); +#endif -apw - To unsubscribe from this list: send the line "unsubscribe

Re: latest checkpatch

On Thu, Oct 18, 2007 at 01:13:52PM +0200, Ingo Molnar wrote: > > latest checkpatch.pl works really well on sched.c. > > there's only one problem left, this bogus false positive warning > reappeared: > > WARNING: braces {} are not necessary for single statement blocks > #5710: FILE:

Re: latest checkpatch

On Thu, Oct 18, 2007 at 08:25:21PM +0100, Andy Whitcroft wrote: > On Thu, Oct 18, 2007 at 01:13:52PM +0200, Ingo Molnar wrote: > > > > latest checkpatch.pl works really well on sched.c. > > > > there's only one problem left, this bogus false positive warning > &g

Re: latest checkpatch

On Thu, Oct 18, 2007 at 10:51:47PM +0200, Ingo Molnar wrote: > > * Avi Kivity <[EMAIL PROTECTED]> wrote: > > > >> if (foo) > > >> bar(); > > >> baz(); > > >> one(); > > >> > > > > > > detecting that would be awesome - it's often the sign of a real bug > > > because the

Re: [stable] 2.6.23 boot failures on x86-64.

I'm wrong, it > should be reverted. So something like the appended would make sense > regardless. > > Can I get a "tested-by"? And/or ack/nack's on my half-arsed theory above? This code is definatly only used when SPARSEMEM is enabled, and VMEMMAP is not which is not a combin

Re: checkpatch bug: space between left parenthesis and asterisk

On Tue, Oct 30, 2007 at 02:27:13PM -0500, Timur Tabi wrote: > I'm running checkpatch.pl (dated 10/17), and it complains about this line: > > crc = __be32_to_cpu(* ((__be32 *) ((void *) firmware + calc_size))); > > the message I get is: > > ERROR: need space before that '*' (ctx:BxW) > #721:

Re: [PATCH 5/6] fix typo in SubmittingPatches

On Tue, Oct 30, 2007 at 10:11:44PM -0700, Greg Kroah-Hartman wrote: > From: Keiichi Kii <[EMAIL PROTECTED]> > > Fix typo. > > Signed-off-by: Keiichi Kii <[EMAIL PROTECTED]> > Cc: Andy Whitcroft <[EMAIL PROTECTED]> > Cc: Randy Dunlap <[EMAIL PROTECTED]>

Re: 2.6.23-git18: ext2_check_page: bad entry in directory

On Wed, Oct 31, 2007 at 04:30:43PM +0100, Jan Kara wrote: > On Wed 24-10-07 18:07:29, Andy Whitcroft wrote: > > On Wed, Oct 24, 2007 at 05:03:03PM +0200, Jan Kara wrote: > > > > > e2image -r /dev/sda1 - | gzip -dc root-image.gz > > > > This thing is 27MB,

Re: x86/mm/pageattr: Code without effect?

On Sat, Apr 06, 2013 at 04:58:04PM +0200, Andrea Arcangeli wrote: > You're right, so this location clearly didn't trigger the problem so I > didn't notice the noop here. I only exercised the fix in the other > locations of the file that had the same problem. > > It was a noop, so it really

Re: [PATCH] checkpatch: Warn on comparisons to true and false

On Tue, Apr 09, 2013 at 08:17:14PM -0700, Joe Perches wrote: > Comparisons of A to true and false are better written > as A and !A. > > Bleat a message on use. > > Signed-off-by: Joe Perches > --- > scripts/checkpatch.pl | 17 + > 1 file changed, 17 insertions(+) > > diff

Re: [PATCH] checkpatch: Warn on comparisons to true and false

On Wed, Apr 10, 2013 at 04:27:51AM -0700, Joe Perches wrote: > like > 0 == foo > instead of > foo == 0 > > there were _way_ too many false positives of > the $Expression sort that I didn't add that test. Makes sense then as it is. Thanks. -apw -- To unsubscribe from this list:

Re: checkpatch: kill the bogus camelcase check

On Tue, Apr 09, 2013 at 02:50:54PM -0700, James Bottomley wrote: > It's making checkpatch unusable on most drivers because it's spewing > tons of bogus warnings. The problem is the assumption that studly caps > is always wrong: it isn't if the variables are named after the various > conventions

[PATCH 1/1] UBUNTU: SAUCE: ubuntu: overlayfs -- ovl_path_open should not take path reference

Author: Al Viro Date: Tue Jun 26 21:58:53 2012 +0400 switch dentry_open() to struct path, make it grab references itself BugLink: http://bugs.launchpad.net/bugs/1098378 Signed-off-by: Andy Whitcroft --- fs/overlayfs/super.c | 1 - 1 file changed, 1 deletion(-) Found

[PATCH 1/1] xen-netback: include definition of csum_ipv6_magic

ed-off-by: Andy Whitcroft --- drivers/net/xen-netback/netback.c | 1 + 1 file changed, 1 insertion(+) Found while trying to couple latest kernels for arm64 platforms. Looks like it got missed in the transition. -apw diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-n

Re: [PATCH] doc: fix generation of device-drivers

Acked-by: Andy Whitcroft -apw -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] - add "fixpae" bootparam to fix/workaround #930447

On Wed, Nov 27, 2013 at 09:41:03PM +0100, Roland wrote: > This patch is meant primarly for ubuntu, as they only ship PAE > enabled kernels and don`t ship non-PAE kernels anymore. So this > resolves an ubuntu specific problem (as the installer disc also has > PAE enabled kernel). > > I know it`s

Re: [PATCH v3] checkpatch: add DT compatible string documentation checks

e/bindings. Vendor prefixes > > are also checked for existing in vendor-prefixes.txt These should be > > temporary checks until we have more sophisticated binding schema checking. > > > > Signed-off-by: Rob Herring > > Cc: Grant Likely > > Cc: Andy

Re: [PATCH 097/102] efivars: explicitly calculate length of VariableName

On Wed, Apr 17, 2013 at 12:37:43PM +0800, Lingzhu Xiang wrote: > On 04/16/2013 06:33 PM, Luis Henriques wrote: > >68d929862e29a8b52a7f2f2f86a0600423b093cd efi: be more paranoid about > >available space when creating variables > > This prevents a bricking issue for some Samsung devices but causes

[PATCH 4/4] scsi: hyper-v storage -- mark as preferring READ CAPACITY (16) at SPC-2

BugLink: http://bugs.launchpad.net/bugs/1223499 Signed-off-by: Andy Whitcroft --- drivers/scsi/storvsc_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c index 14ba8fd..25e7dd5 100644 --- a/drivers/scsi/storvsc_drv.c +++ b/drivers

[PATCH 0/4] Hyper-V TRIM support

. Patches against v3.11. Comments? -apw Andy Whitcroft (4): scsi: add scsi device flag to request VPD pages be used at SPC-2 scsi: add scsi device flag to request READ CAPACITY (16) be preferred scsi: hyper-v storage -- mark as VPD capable at SPC-2 scsi: hyper-v storage -- mark as preferring READ

[PATCH 2/4] scsi: add scsi device flag to request READ CAPACITY (16) be preferred

BugLink: http://bugs.launchpad.net/bugs/1223499 Signed-off-by: Andy Whitcroft --- drivers/scsi/sd.c | 2 ++ include/scsi/scsi_device.h | 1 + 2 files changed, 3 insertions(+) diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index 5a8a04d..eba4d6c 100644 --- a/drivers/scsi/sd.c +++ b

[PATCH 1/4] scsi: add scsi device flag to request VPD pages be used at SPC-2

are present. Add a scsi quirk bit to allow those devices to hint we can and should try these VPD pages. BugLink: http://bugs.launchpad.net/bugs/1223499 Signed-off-by: Andy Whitcroft --- drivers/scsi/sd.c | 6 +- include/scsi/scsi_device.h | 1 + 2 files changed, 6 insertions(+), 1 deletion

[PATCH 3/4] scsi: hyper-v storage -- mark as VPD capable at SPC-2

BugLink: http://bugs.launchpad.net/bugs/1223499 Signed-off-by: Andy Whitcroft --- drivers/scsi/storvsc_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c index 1a28f56..14ba8fd 100644 --- a/drivers/scsi/storvsc_drv.c +++ b/drivers

Re: [PATCH 0/4] Hyper-V TRIM support

On Fri, Sep 13, 2013 at 07:57:58AM -0700, James Bottomley wrote: > This is an awful lot of contortions (which don't seem to have any other > users on the horizon) to support a device that's not standards > compliant. What about this, it's simple, it does the right thing and > it's contained in

Re: False positive in checkpatch

On Mon, Sep 23, 2013 at 09:21:07PM -0700, Joe Perches wrote: > On Mon, 2013-09-23 at 15:59 -0700, Paul E. McKenney wrote: > > Hello! > > > > The checkpatch.pl script complains as follows: > > > > ERROR: need consistent spacing around '*' (ctx:WxB) > > #57: FILE: include/linux/rcupdate.h:564: > >

Re: False positive in checkpatch

Thanx, Paul > How about this one, it is a bit of a hack but does at least correctly correct the formal characterisation of the operator to unary. Working on getting this tested a bit better before sending it out formally. -apw >From 5b4e22c123b3492838d12181129a8c168598dbf4 Mon S

[PATCH 0/3] overlayfs fixes for v3.8 and later base

Following this email are three patches against overlayfs.v17 which allow it to work against v3.10-rc6 and later. With these applied overlayfs passes basic testing. overlayfs -- ovl_path_open should not take path reference Found this in testing on Ubuntu raring, testing against loopback

[PATCH 2/2] overlayfs -- follow change to do_splice_direct interface

The commit below changed the interface to do_splice_direct, follow that change in copy_up: commit 7995bd287134f6c8f80d94bebe7396f05a9bc42b Author: Al Viro Date: Thu Jun 20 18:58:36 2013 +0400 splice: don't pass the address of ->f_pos to methods Signed-off-by: Andy Whitcr

[PATCH 1/2] vfs: export do_splice_direct() to modules -- fix

vfs: export do_splice_direct() to modules.] Signed-off-by: Andy Whitcroft --- fs/internal.h | 6 -- include/linux/fs.h | 6 ++ 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/fs/internal.h b/fs/internal.h index 6dd0ffd..6c9ec69 100644 --- a/fs/internal.h +++ b/fs/interna

[PATCH 1/1] overlayfs -- ovl_path_open should not take path reference

Author: Al Viro Date: Tue Jun 26 21:58:53 2012 +0400 switch dentry_open() to struct path, make it grab references itself BugLink: http://bugs.launchpad.net/bugs/1098378 Signed-off-by: Andy Whitcroft --- fs/overlayfs/super.c | 1 - 1 file changed, 1 deletion(-) Found

Re: [PATCH 2/2] overlayfs -- follow change to do_splice_direct interface

On Thu, Jun 27, 2013 at 06:37:45PM +0200, Miklos Szeredi wrote: > Thanks for the patches, Andy. I already pushed a similar set of fixes > to overlayfs.current (.v18) and to .v17 for the dentry_open() refcount > fix. Bah so you did, that'll teach me for waiting for them to be tested. > It is

Re: [PATCH] x86: dma-mapping: fix GFP_ATOMIC macro usage

On Fri, Jan 17, 2014 at 8:46 AM, Marek Szyprowski wrote: > GFP_ATOMIC is not a single gfp flag, but a macro which expands to the other > flags and LACK of __GFP_WAIT flag. To check if caller wanted to perform an > atomic allocation, the code must test __GFP_WAIT flag presence. This patch > fixes

Re: [PATCHv2 1/1] checkpatch: adding Suggested-by as standard signature

On Thu, Mar 28, 2013 at 12:58:22PM +0530, Mugunthan V N wrote: > --- a/scripts/checkpatch.pl > +++ b/scripts/checkpatch.pl > @@ -281,6 +281,7 @@ our $signature_tags = qr{(?xi: > Tested-by:| > Reviewed-by:| > Reported-by:| > + Suggested-by:| > To:| > Cc: > )};

Re: [PATCH] [checkpatch.pl] ctx_statement_block #if/#else/#endif fix

On Thu, May 15, 2014 at 04:43:15PM +0200, Ivo Sieben wrote: > When picking up a complete statement block #if/#else/#endif prepocesor > boundaries are taken into account by pushing current level & type on a stack. > But on an #else the level was read from stack again (without actually popping > it

Re: [PATCH] [checkpatch.pl] ctx_statement_block #if/#else/#endif fix

On Wed, Jun 11, 2014 at 10:16:40AM +0100, Andy Whitcroft wrote: > It doesn't seem right to remove the restore of the state. If you > consider the effect of an #if/#else/#endif combination the state of the > statement parser should be reset to the state at #if at the #else as t

Re: [PATCH] [checkpatch.pl] ctx_statement_block #if/#else/#endif fix

On Wed, Jun 11, 2014 at 10:57:11AM +0100, Andy Whitcroft wrote: > Signed-off-by: Andy Whitcroft With your permissions I'll add a Reported-by: etc to this patch in your name. -apw -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a mess

Re: [RFC] quiet checkpatch style recommendation about no spaces around bitfield :

On Mon, Mar 31, 2014 at 01:56:28PM -0700, Andrew Morton wrote: > On Mon, 31 Mar 2014 08:31:38 -0700 Joe Perches wrote: > > > > > @@ -143,13 +143,13 @@ union cvmx_usbcx_gahbcfg { > > > > * * 1'b1: Unmask the interrupt assertion to the > > > > application. > > > > */ > > >

ACPI resource change triggers loss of serial ports

. For Zhang's case I wonder if this check could be tightened up to cover only the zero base, something like the (untested) patch below. -apw [1] https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1313981 >From e5211c68278387ef65e483bcfedd5581a79ec783 Mon Sep 17 00:00:00 2001 From: Andy Whitcroft D

Re: [PATCH] checkpatch: Emit a warning on file add/move/delete

H", That seems like a sensible plan. Sometime we might try and work out if any entries are affected or needed. I think you are checking against the git ways of mentioning this only, don't know if there is any milage in checking the dates which also convey add/remove info via datea at the epoch. Acke

Re: [PATCH] checkpatch: Enable whitespace checks for DTS files

On Mon, Jun 30, 2014 at 11:53:31AM +0200, Geert Uytterhoeven wrote: > When run on *.dtsi or *.dts files, the whitespace checks were skipped, > while they are valid for DTS files. Hence stop skipping them. > > I ran checkpatch on all in-tree DTS files, and didn't notice any error or > warning

Re: [PATCH] checkpatch: Add for_each tests to indentation and brace tests

if ($line =~ /\b(?:(?:if|while|for)\s*\(|do\b)/ && $line !~ > /^.\s*#/ && $line !~ /\}\s*while\s*/) { > + if ($line =~ > /\b(?:(?:if|while|for|(?:[a-z_]+|)for_each[a-z_]+)\s*\(|do\b)/ && $line !~ > /^.\s*#/ && $line !~ /\}\s*while\s*/

Re: [PATCH 0/3] checkpatch: Add missing c90 types

gt; Joe Perches (3): > checkpatch: Add short int to c variable types > checkpatch: Add signed generic types > checkpatch: Add test for native c90 types in unusual order > > scripts/checkpatch.pl | 61 > --- > 1 file changed, 5

[PATCH 1/1] x86/speculation, objtool: Annotate indirect calls/jumps for objtool on 32bit

In 9e0e3c5130e9 ("x86/speculation, objtool: Annotate indirect calls/jumps for objtool") we added annotations for CALL_NOSPEC/JMP_NOSPEC on x86 64bit. We did not annotate the 32bit path. Annotate it similarly. Signed-off-by: Andy Whitcroft --- arch/x86/include/asm/nospec-branch.h |

Re: checkpatch potential false positive

On Mon, Nov 06, 2017 at 03:19:14PM +1100, Tobin C. Harding wrote: > Hi, > > When parsing drivers/staging/unisys/visorbus/visorchipset.c in Greg's > staging tree checkpatch emits > > -- > visorchipset.c > -- > WARNING: char * array declaration might be better as static

[PATCH 2/5] efivarfs: efivarfs_create() ensure we drop our reference on inode on error

Signed-off-by: Andy Whitcroft --- drivers/firmware/efivars.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/drivers/firmware/efivars.c b/drivers/firmware/efivars.c index ae50d2f..0bbf742 100644 --- a/drivers/firmware/efivars.c +++ b/drivers/firmware

[PATCH 1/5] efivarfs: efivarfs_file_read ensure we free data in error paths

Signed-off-by: Andy Whitcroft --- drivers/firmware/efivars.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/firmware/efivars.c b/drivers/firmware/efivars.c index 4b12a8fd..ae50d2f 100644 --- a/drivers/firmware/efivars.c +++ b/drivers/firmware/efivars.c

<    3   4   5   6   7   8   9   10   >