N);
memcpy(ap->bssid, ap_info->bssid, ETH_ALEN);
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
Changes in v2:
- Make the commit message more clearer.
- And correct the error on line number 116
in file drivers/staging/ks7010/ks_hostif.c
change
function definition argument like 'struct vb_device_info *','unsigned
long' etc. should also have an identifier name.
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
Changes in v2:
- By mistake one irrelevant line was added which is removed in this
patch.
-
function prototype arguments like 'struct vb_device_info *','unsigned
long' etc. should have an identifier name.
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
Changes in v3:
- By mistake one irrelevant line was added which is removed in this
patch.
-
N);
memcpy(ap->bssid, ap_info->bssid, ETH_ALEN);
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
Changes in v3:
- Commit message made more accurate and as per the changes.
- previously versions were not marked.
---
drivers/staging/ks7010/ks_hostif.c | 24 ++
N);
memcpy(ap->bssid, ap_info->bssid, ETH_ALEN);
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
Changes in v3:
- Commit message made more accurate and as per the changes.
- previously versions were not marked.
---
drivers/staging/ks7010/ks_hostif.c | 20
N);
memcpy(ap->bssid, ap_info->bssid, ETH_ALEN);
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
drivers/staging/ks7010/ks_hostif.c | 20 ++--
drivers/staging/ks7010/ks_wlan_net.c | 20 ++--
2 files changed, 20 insertions(+
ssid[0]), ETH_ALEN);
memcpy(ap->bssid, ap_info->bssid, ETH_ALEN);
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
drivers/staging/ks7010/ks_hostif.c | 24
drivers/staging/ks7010/ks_wlan_net.c | 20 ++--
2 files changed,
ssid[0]), ETH_ALEN);
memcpy(ap->bssid, ap_info->bssid, ETH_ALEN);
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
drivers/staging/ks7010/ks_hostif.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/ks7010/ks_host
function definition argument 'struct vb_device_info *' and 'unsigned
long' should also have an identifier name.
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
drivers/staging/xgifb/vb_init.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/d
function definition argument 'struct vb_device_info *' and 'unsigned
long' should also have an identifier name.
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
drivers/staging/xgifb/vb_init.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/d
Unnecessary parentheses as reported by checkpatch.pl
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
drivers/staging/ks7010/ks_hostif.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.c
b/d
function definition argument 'struct vb_device_info *' and 'unsigned
long' should also have an identifier name.
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
drivers/staging/xgifb/vb_init.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/s
Some of the block comments styles are not encouraged:
for example:
/*
block comment without introductory *
*/
and
/*
* block comment with line terminating */
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
drivers/staging/ks7010/ks7010_sdio.c | 6 --
1 file chan
Commenting Code Is a Bad Idea.
Comments are their to explain the code and how the code achieves its
goal and as codes in the comments does not explain what the code is
doing so there is no use of commenting them.
So in thos patch codes in the comments are removed.
Signed-off-by: Arushi Singhal
line exceeding 80 characters length.
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
changes in v2
- changes done such that no other errors can generate.
---
drivers/staging/xgifb/XGI_main_26.c | 21 +
drivers/staging/xgifb/vb_setmode.c
function prototype argument 'struct vb_device_info *' and 'unsigned
long' should also have an identifier name.
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
changes in v3
-make the subject title more relevant.
-change the identifier of struct vb_device_info to
ssid[0]), ETH_ALEN);
memcpy(ap->bssid, ap_info->bssid, ETH_ALEN);
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
drivers/staging/ks7010/ks_hostif.c | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/ks7010/
Unnecessary parentheses should be avoided as reported by checkpatch.pl
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
drivers/staging/ks7010/ks_hostif.c | 24
drivers/staging/ks7010/ks_wlan_net.c | 20 ++--
2 files chang
Unnecessary parentheses should be avoided as reported by checkpatch.pl
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
drivers/staging/ks7010/ks_hostif.c | 24
drivers/staging/ks7010/ks_wlan_net.c | 20 ++--
2 files chang
ssid[0]), ETH_ALEN);
memcpy(ap->bssid, ap_info->bssid, ETH_ALEN);
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
drivers/staging/ks7010/ks_hostif.c | 20 ++--
drivers/staging/ks7010/ks_wlan_net.c | 20 ++--
2 files changed, 20 insert
The following patch the checkpatch.pl warning:
drivers/staging/ks7010/ks_hostif.c warning: please, no spaces at the
start of a line
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
drivers/staging/ks7010/ks_hostif.c | 4 ++--
1 file changed, 2 insertions(+), 2 del
Unnecessary parentheses should be avoided as reported by checkpatch.pl
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
drivers/staging/ks7010/ks_hostif.c | 24
drivers/staging/ks7010/ks_wlan_net.c | 20 ++--
2 files chang
Error was reported by checkpatch.pl as
WARNING: Avoid multiple line dereference...
if there is boolean operator then it is fixed by Splitting line at
boolean operator.
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
drivers/staging/xgifb/XGI_main_26.
function definition argument like 'struct vb_device_info *','unsigned
long' etc. should have an identifier name.
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
drivers/staging/xgifb/vb_setmode.h | 19 ++-
1 file changed, 10 insertions(+), 9 deletions(-)
function definition argument like 'struct vb_device_info *','unsigned
long' etc. should also have an identifier name.
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
Changes in v2:
- By mistake one irrelevant line was added which is removed in this
patch.
---
d
N);
memcpy(ap->bssid, ap_info->bssid, ETH_ALEN);
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
drivers/staging/ks7010/ks_hostif.c | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/ks7010/ks_host
Macro argument 'a' may be better as '(a)' to avoid precedence issues as
reported by checkpatch.pl
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
drivers/staging/fwserial/fwserial.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/fw
Fix checkpatch issues: "CHECK: Alignment should match open parenthesis"
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
drivers/staging/vt6656/rxtx.c | 54 +--
1 file changed, 27 insertions(+), 27 deletions(-)
diff
This patch fixes the issue by aligning the * on each line in block
comments.
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
drivers/staging/speakup/fakekey.c| 10 +-
drivers/staging/speakup/i18n.c | 14 +++---
drivers/staging/speakup/
Function definitions arguments should also have an identifier name as
reported by checkpatch.pl.
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
drivers/staging/vt6656/channel.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/
Prefer kzalloc(sizeof(*ser_dev)...) over kzalloc(sizeof(struct
serio)...) as reported by checkpatch.pl.
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
drivers/staging/nvec/nvec_ps2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/stagin
Fix checkpatch issues: "CHECK: Alignment should match open parenthesis"
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
drivers/staging/vt6656/firmware.c | 34 +-
drivers/staging/vt6656/key.h | 2 +-
drivers/staging/vt6656
function definition argument 'struct vb_device_info *' should also have
an identifier name.
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
drivers/staging/xgifb/vb_init.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/xgifb/vb_in
function definition argument 'struct vb_device_info *' and 'unsigned
long' should also have an identifier name.
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
drivers/staging/xgifb/vb_init.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/s
Fix checkpatch issues: "CHECK: Alignment should match open parenthesis"
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
drivers/staging/vt6656/firmware.c | 34 +-
drivers/staging/vt6656/key.h | 2 +-
drivers/staging/vt6656
Fix checkpatch issues: "CHECK: Alignment should match open parenthesis"
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
drivers/staging/vt6656/rxtx.c | 54 +--
1 file changed, 27 insertions(+), 27 deletions(-)
diff
Function definitions arguments should also have an identifier name as
reported by checkpatch.pl.
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
drivers/staging/vt6655/baseband.h | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/d
Function definitions arguments should also have an identifier name as
reported by checkpatch.pl.
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
drivers/staging/vt6656/channel.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/
function definition argument 'struct vb_device_info *' and 'unsigned
long' should also have an identifier name.
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
drivers/staging/xgifb/vb_init.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/s
Error reported by checkpatch.pl as "avoid multiple line dereference".
Addition of new variables to make the code more readable and also to
correct about mentioned error as by itroducing new variables line is
not exceeding 80 characters.
Signed-off-by: Arushi Singhal <arush
Error reported by checkpatch.pl as "avoid multiple line dereference".
Addition of new variables to make the code more readable and also to
correct about mentioned error as by itroducing new variables line is
not exceeding 80 characters.
Signed-off-by: Arushi Singhal <arush
Error was reported by checkpatch.pl as "Avoid multiple line
dereference".And If there is boolean operator then it is
fixed by Splitting line at boolean operator to satisfy coding
style.
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
changes in v4
N);
memcpy(ap->bssid, ap_info->bssid, ETH_ALEN);
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
Changes in v4:
- Commit message made more accurate and as per the changes.
- previously versions were not marked.
drivers/sta
Error was reported by checkpatch.pl as "Avoid multiple line
dereference".And If there is boolean operator then it is
fixed by Splitting line at boolean operator to satisfy coding
style.
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
changes in v3
Commenting Code Is a Bad Idea.
Comments are their to explain the code and how the code achieves its
goal and as codes in the comments does not explain what the code is
doing so there is no use of commenting them.
So in this patch codes in the comments are removed.
Signed-off-by: Arushi Singhal
Error reported by checkpatch.pl as "avoid multiple line dereference".
Addition of new variables to make the code more readable.
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
changes in v7
- Improve the coding style.
- Introduced new variables.
drive
ap->bssid, ap_info->bssid, ETH_ALEN);
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
drivers/staging/ks7010/ks_hostif.c | 26 +-
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.c
b/drivers/st
Fixed coding style for null comparisons in speakup driver to be more
consistant with the rest of the kernel coding style.
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
changes in v2
- fixed coding style error and upto the coding style.
drivers/staging/speakup/fak
Fix checkpatch issues: "CHECK: Alignment should match open parenthesis"
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
drivers/staging/speakup/i18n.c | 2 +-
drivers/staging/speakup/kobjects.c | 38 +++---
2 files change
New variable is added to make the code more readable.
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
drivers/staging/xgifb/XGI_main_26.c | 29 ++---
1 file changed, 6 insertions(+), 23 deletions(-)
diff --git a/drivers/staging/xgifb/XGI_main_2
Fix checkpatch issues: "CHECK: Alignment should match open parenthesis".
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
changes in v2
- Aligned the lines which are not aligned in previous patch.
drivers/staging/speakup/i18n.c | 2 +-
drivers
N);
memcpy(ap->bssid, ap_info->bssid, ETH_ALEN);
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
Changes in v4:
- Commit message made more accurate and as per the changes.
drivers/staging/ks7010/ks_hostif.c | 24
1 file changed,
ap->bssid, ap_info->bssid, ETH_ALEN);
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
drivers/staging/ks7010/ks_hostif.c | 23 +++
drivers/staging/ks7010/ks_wlan_net.c | 18 +-
2 files changed, 20 insertions(+), 21 deletions(-)
This patch replaces bit shifting on 1 with the BIT(x) macro.
This was done with coccinelle:
@@
constant c;
@@
-1 << c
+BIT(c)
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
changes in v2
- remove the unnecessary parenthesis.
- removethe wrong changes.
dri
This patch replaces bit shifting on 1 with the BIT(x) macro.
This was done with coccinelle:
@@
constant c;
@@
-1 << c
+BIT(c)
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
changes in v2
-improve the code.
drivers/staging/fbtft/fb_agm1264k-fl.c | 2 +-
dri
This patch replaces bit shifting on 1 with the BIT(x) macro.
This was done with coccinelle:
@@
constant c;
@@
-1 << c
+BIT(c)
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
changes in v2
-remove/correct the wrong code.
drivers/staging/iio/cdc/ad7150.c | 2
Remove the code which do not have any value.
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
drivers/staging/lustre/lnet/lnet/net_fault.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/lustre/lnet/lnet/net_fault.c
b/drivers/staging/lustre/lne
Fixed coding style for null comparisons in speakup driver to be more
consistant with the rest of the kernel coding style.
Replaced 'x != NULL' with 'x' and 'x = NULL' with '!x'.
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
changes in v2
- change the commit s
Remove the extra parenthesis remove the checkpatch issue.
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
drivers/staging/iio/cdc/ad7746.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/iio/cdc/ad7746.c b/drivers/s
Delete tabs and add spaces to align the code to fix the
checkpatch issue: "CHECK: Alignment should match open parenthesis".
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
changes in v3
- make the commit message more clear.
drivers/staging/speakup/spea
To remove complexity of code the function is added in nfnetlink.h
to make code more clear and readable.
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
include/linux/netfilter/nfnetlink.h | 6 ++
net/netfilter/nf_conntrack_netlink.c | 12 +++-
2 files c
Rmoved parentheses on the right hand side of assignment, as they are
not required. The following coccinelle script was used to fix this
issue:
@@
local idexpression id;
expression e;
@@
id =
-(
e
-)
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
net/netfilte
Simplify function returns by merging assignment and return.
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
changes in v2
*correct the error.
drivers/staging/media/atomisp/pci/atomisp2/atomisp_v4l2.c | 8 ++--
.../media/atomisp/pci/atomisp2/css2400/runtim
To remove complexity of code the function is added in nfnetlink.h
to make code more clear and readable.
This is opencoded in a way that makes it error prone for future
netfilter netlink subsystems.
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
changes in v2
- make the
To remove complexity of code the function is added in nfnetlink.h
to make code more clear and readable.
This is opencoded in a way that makes it error prone for future
netfilter netlink subsystems.
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
changes in v3
This patch is to remove unneeded spaces before tabs so as to
follow kernel coding conventions.
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
kernel/pid_namespace.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/kernel/pid_namespace.c b/
Break lines so that they do not exceed
80 characters. Problem found using checkpatch.
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
kernel/pid_namespace.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/kernel/pid_namespace.c b/kernel/pid_names
Simplify function returns by merging assignment and return.
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
drivers/staging/greybus/loopback.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/staging/greybus/loopback.c
b/drivers/staging/g
This patch replaces bit shifting on 1 with the BIT(x) macro.
This was done with coccinelle:
@@
constant c;
@@
-1 << c
+BIT(c)
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
changes in v3
- change the subject.
- remove extra parenthesis.
drivers/staging/media/
Simplify function returns by merging assignment and return.
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
drivers/staging/media/atomisp/pci/atomisp2/atomisp_v4l2.c | 8 ++--
.../media/atomisp/pci/atomisp2/css2400/runtime/bufq/src/bufq.c| 7 ++-
2
This patch removes typedefs from struct and renames it from "typedef struct
bitstr_t" to "struct bitstr" as per kernel coding standards."
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
net/netfilter/nf_conntrack_h323_asn1.c | 80 +++
Remove typedef from struct.
Arushi Singhal (2):
net: netfilter: Remove typedef from "typedef struct field_t"
net: netfilter: Remove typedef from "typedef struct bitstr_t"
net/netfilter/nf_conntrack_h323_asn1.c | 98 +-
1 file changed,
This patch removes multiple assignments.
Done using coccinelle.
@@
identifier i1,i2;
constant c;
@@
- i1=i2=c;
+ i1=c;
+ i2=c;
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
contribution to outreachy netfilter project.
net/netfilter/nf_conntrack_proto_sctp.c | 3 ++-
Rmoved parentheses on the right hand side of assignment, as they are
not required. The following coccinelle script was used to fix this
issue:
@@
local idexpression id;
expression e;
@@
id =
-(
e
-)
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
net/netfilte
This patch removes typedefs from struct and renames it from "typedef struct
field_t" to "struct field" as per kernel coding standards."
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
net/netfilter/nf_conntrack_h323_asn1.c | 68 +++
;
@@
e1
-,
+;
e2;
//
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
drivers/iio/chemical/ams-iaq-core.c | 2 +-
drivers/iio/chemical/vz89x.c| 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/iio/chemical/ams-iaq-core.c
b/drive
;
@@
e1
-,
+;
e2;
//
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
drivers/iio/adc/max11100.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/iio/adc/max11100.c b/drivers/iio/adc/max11100.c
index 23c060e1b663..1180bcc22ff1
This patch replaces bit shifting on 1 with the BIT(x) macro.
This was done with coccinelle:
@@
constant c;
@@
-1 << c
+BIT(c)
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
drivers/staging/media/davinci_vpfe/dm365_ipipe.c | 2 +-
drivers/staging/media/
Remove the extra parenthesis remove the checkpatch issue.
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
drivers/staging/iio/cdc/ad7746.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/iio/cdc/ad7746.c b/drivers/s
This patch uses the following coccinelle script to remove
a variable that was simply used to store the return
value of a function call before returning it:
@@
identifier len,f;
@@
-int len;
... when != len
when strict
-len =
+return
f(...);
-return len;
Signed-off-by: Arushi
This patch replaces bit shifting on 1 with the BIT(x) macro.
This was done with coccinelle:
@@
constant c;
@@
-1 << c
+BIT(c)
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
drivers/staging/media/omap4iss/iss_csi2.c| 2 +-
drivers/staging/media/omap4iss/iss_i
Moved the contents of the header(tsl2x7x.h) into the source file
tsl2x7x_core.c with the exception of the platform data struct which is
supposed to be used from somewhere else other than the driver.
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
drivers/staging/iio
Moved the contents of the header(ad7746.h) into the source file
ad7746.c with the exception of the platform data struct which is
supposed to be used from somewhere else other than the driver.
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
drivers/staging/iio/cdc/ad7746
Fix checkpatch issues: "CHECK: Alignment should match open parenthesis".
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
changes in v2
- change the commit message.
drivers/staging/speakup/speakup_apollo.c | 2 +-
drivers/staging/speakup/speakup_decext.c |
Remove the extra parenthesis remove the checkpatch issue.
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
changes in v2
-done the changes according to the current tree
drivers/staging/iio/cdc/ad7746.c | 16
1 file changed, 8 insertions(+), 8 del
This patch uses the following coccinelle script to remove
a variable that was simply used to store the return
value of a function call before returning it:
@@
identifier len,f;
@@
-int len;
... when != len
when strict
-len =
+return
f(...);
-return len;
Signed-off-by: Arushi
Fix checkpatch warnings:
WARNING: Block comments use a trailing */ on a separate line
WARNING: Block comments use * on subsequent lines
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
net/ipv6/netfilter/ip6_tables.c | 16
1 file changed, 8 insertions
Fixed coding style for null comparisons to be more
consistant with the rest of the kernel coding style.
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
net/bridge/netfilter/ebt_among.c | 12 ++--
net/bridge/netfilter/ebt_arp.c | 10 +
Use managed resource functions devm_request_irq instead of request_irq.
Remove corresponding calls to free_irq in the probe.
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
drivers/staging/iio/trigger/iio-trig-bfin-timer.c | 7 +++
1 file changed, 3 insertions
Replace explicit NULL comparison with ! operator to simplify code.
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
net/netfilter/ipvs/ip_vs_ctl.c | 8 ++---
net/netfilter/ipvs/ip_vs_proto.c | 8 ++---
net/netfilter/nf_conntrack_broadcast.c | 2 +
Replace explicit NULL comparison with ! operator to simplify code.
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
net/ipv6/netfilter/ip6_tables.c| 4 ++--
net/ipv6/netfilter/ip6t_SYNPROXY.c | 16
net/ipv6/netfilter/ip6
Removed parentheses on the right hand side of assignment, as they are
not required. The following coccinelle script was used to fix this
issue:
@@
local idexpression id;
expression e;
@@
id =
-(
e
-)
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
net/ipv6/net
Replace explicit NULL comparison with ! operator to simplify code.
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
net/netfilter/ipvs/ip_vs_ctl.c | 8 ++---
net/netfilter/ipvs/ip_vs_proto.c | 8 ++---
net/netfilter/nf_conntrack_broadcast.c | 2 +
fix the line over 80 characters as reported by checkpatch.pl
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
net/ipv6/netfilter/ip6_tables.c| 6 --
net/ipv6/netfilter/ip6t_SYNPROXY.c | 3 ++-
2 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/ne
Removed parentheses on the right hand side of assignment, as they are
not required. The following coccinelle script was used to fix this
issue:
@@
local idexpression id;
expression e;
@@
id =
-(
e
-)
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
net/ipv6/net
This patch removes typedefs from struct and renames it from "typedef struct
bitstr_t" to "struct bitstr" as per kernel coding standards."
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
net/netfilter/nf_conntrack_h323_asn1.c | 80 +++
ock in the devices global data.
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
drivers/staging/iio/meter/ade7759.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/iio/meter/ade7759.c
b/drivers/staging/iio/meter/ade7759.c
index 0b6
Fix multiple checkpatch.pl issue to improve code readability.
Arushi Singhal (5):
kernel: pid: remove space after open square bracket
kernel: pid.c: Add space before the open parenthesis
kernel: pid: Fix line over 80 characters
kernel: pid_namespace: Remove return statement from void
This patch splits line over 80 characters addressing checkpatch.pl
warning
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
kernel/pid.c | 4 +++-
kernel/pid_namespace.c | 7 +--
2 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/kernel/pid.c b/
Remove the return statement from void function as is not useful.
Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com>
---
kernel/pid_namespace.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/kernel/pid_namespace.c b/kernel/pid_namespace.c
index 778959ecd5c3..be35c2fe725f
1 - 100 of 756 matches
Mail list logo