Re: tty, vt: lockdep warnings

2012-11-07 Thread Bjørn Mork
Alan Cox a...@lxorguk.ukuu.org.uk writes: + +static int bind_con_driver(const struct consw *csw, int first, int last, +int deflt) +{ + int ret; + + console_unlock(); console_lock() maybe... + ret = do_bind_con_driver(csw, first, last, deflt); +

Re: Fix memory leak in sierra_release()

2012-10-24 Thread Bjørn Mork
Lennart Sorensen lsore...@csclub.uwaterloo.ca writes: I found a memory leak in sierra_release() (well sierra_probe() I guess) that looses 8 bytes each time the driver releases a device. Here is the patch to fix it. diff --git a/drivers/usb/serial/sierra.c b/drivers/usb/serial/sierra.c

[PATCH usb-linus] USB: keyspan: fix typo causing GPF on open

2012-11-10 Thread Bjørn Mork
: Johan Hovold jhov...@gmail.com Signed-off-by: Bjørn Mork bj...@mork.no --- Hello Richard, I wonder if you are able to test and verify this? I do not guarantee that there aren't other issues around, but this small typo looked like an obvious killer... Bjørn drivers/usb/serial/keyspan.c |3

Re: [PATCH usb-linus] USB: keyspan: fix typo causing GPF on open

2012-11-11 Thread Bjørn Mork
Richard richj...@pacbell.net writes: Bjørn: I patched keyspan.c using your below supplied diff in 3.6.6 (I'm not using git.) The patch WORKS for me. (I tested using minicom and the two programs that usually access the Keyspan serial device.) Thanks for testing. Good to know that this

Re: IBM Thinkpad G41 PCMCIA problems

2005-02-21 Thread Bjørn Mork
I think I might have a new datapoint to add to this discussion: I've got a IBM Thinkpad T42 with 1 GB RAM. Never had any problems with PCMCIA, but that's probably just because another PCI device has been mapped into the hole in the BIOS memory map: [EMAIL PROTECTED]:~$ grep e820 /var/log/dmesg

Re: [PATCH 7/13] USB:support the new interfaces of Huawei Data Card devices in option driver

2012-07-13 Thread Bjørn Mork
Fangxiaozhi (Franko) fangxiao...@huawei.com writes: From: fangxiaozhi huana...@huawei.com 1. This patch is based on the kernel of 3.5-rc6 2. In this patch, we add new micro for matching the series USB devices with vendor ID and interface information. 3. In this patch, we add new

Re: 0xB16B00B5? Really? (was Re: Move hyperv out of the drivers/staging/ directory)

2012-07-20 Thread Bjørn Mork
KY Srinivasan k...@microsoft.com writes: Here is the link that describes how the guest ID should be composed: http://msdn.microsoft.com/en-us/library/windows/hardware/ff542653%28v=vs.85%29.aspx The unwanted value does not conform to those rules: Linux is not yet at major version 0xB5. I

[PATCH] drivers: hv: use Linux version in guest ID

2012-07-20 Thread Bjørn Mork
Use OS version number in the guest ID as recommended by Microsoft Signed-off-by: Bjørn Mork bj...@mork.no --- So how about something like this? Yes, I know including linux/version.h often is unwanted, but the spec does recommend using the actual OS version in the guest ID Yes

Re: [PATCH] Drivers: Base: Regmap: fix warnings, use %lu instead of %d for printf format

2013-04-07 Thread Bjørn Mork
Chen Gang gang.c...@asianux.com writes: fix warnings (with EXTRA_CFLAGS=-W): format ‘%d’ expects argument of type ‘int’, but argument 4 has type ‘size_t’ [-Wformat] Signed-off-by: Chen Gang gang.c...@asianux.com --- drivers/base/regmap/regcache.c |2 +- 1 files changed, 1

[regression] v3.8 - v3.9-rc6, caused by commit 8761a3d (loop: cleanup partitions when detaching loop device)

2013-04-09 Thread Bjørn Mork
Hello, the following simple test causes a deadlock between the loop driver, umount and blkid i v3.9-rc6 (tested on a standard Debian wheezy installating, i.e. with udev 175): qmitest:~# file cd-image-cfg1.iso cd-image-cfg1.iso: # ISO 9660 CD-ROM filesystem data 'D-LINK MODEM' qmitest:~# mount

Re: [regression] v3.8 - v3.9-rc6, caused by commit 8761a3d (loop: cleanup partitions when detaching loop device)

2013-04-09 Thread Bjørn Mork
Jens Axboe ax...@kernel.dk wrote: On Tue, Apr 09 2013, Bjørn Mork wrote: Hello, the following simple test causes a deadlock between the loop driver, umount and blkid i v3.9-rc6 (tested on a standard Debian wheezy installating, i.e. with udev 175): qmitest:~# file cd-image-cfg1.iso cd

Re: [PATCH] checkpatch: Warn on comparisons to true and false

2013-04-11 Thread Bjørn Mork
Dave Jones da...@redhat.com writes: On Wed, Apr 10, 2013 at 03:57:51PM -0700, Andrew Morton wrote: On Tue, 09 Apr 2013 20:17:14 -0700 Joe Perches j...@perches.com wrote: Comparisons of A to true and false are better written as A and !A. Bleat a message on use. hm.

Re: Linux 3.8.3

2013-03-17 Thread Bjørn Mork
Russell King - ARM Linux li...@arm.linux.org.uk writes: Sigh. At times, I really don't know why I bother wasting my time commenting on patches if they just go and agree with them, and promptly ignore them. I pointed out what this should be:

Re: [RFC V1 5/8] smi2021: Add smi2021_video.c

2013-03-18 Thread Bjørn Mork
Hans Verkuil hverk...@xs4all.nl writes: +/* + * + * The device delivers data in chunks of 0x400 bytes. + * The four first bytes is a magic header to identify the chunks. + * 0xaa 0xaa 0x00 0x00 = saa7113 Active Video Data + * 0xaa 0xaa 0x00 0x01 = PCM - 24Bit 2 Channel audio data + */

Re: [RFC V1 7/8] smi2021: Add smi2021_bl.c

2013-03-18 Thread Bjørn Mork
Jon Arne Jørgensen jona...@jonarne.no writes: This is the smi2021-bootloader module. This module will upload the firmware for the different somagic devices. I really don't understand why you want to make that a separate module. Building both the bootlader driver and the real driver into the

Re: Stable kernel 3.8.3 appears to break displayport on intel gen4

2013-03-18 Thread Bjørn Mork
Sergio Callegari sergio.calleg...@gmail.com writes: This is just a short note to let you know that after installing 3.8.3, display port stopped working on my laptop. Going back to 3.8.2 brought it back to life. This has been tested with the ubuntu mainline kernels that should be vanilla

Re: [PATCH] udevadm-info: Don't access sysfs 'resourceN' files

2013-03-18 Thread Bjørn Mork
Alex Williamson alex.william...@redhat.com writes: At least for KVM the kernel fix is the addition of the vfio driver which gives us a non-sysfs way to do this. If this problem was found a few years later and we were ready to make the switch I'd support just removing these resource files.

Re: [PATCH] udevadm-info: Don't access sysfs 'resourceN' files

2013-03-18 Thread Bjørn Mork
Alex Williamson alex.william...@redhat.com wrote: On Mon, 2013-03-18 at 18:20 +0100, Bjørn Mork wrote: Alex Williamson alex.william...@redhat.com writes: At least for KVM the kernel fix is the addition of the vfio driver which gives us a non-sysfs way to do this. If this problem was found

Re: [Intel][RNG] PCI IDs commented out for 82801I (ICH9 Mobile and non-mobile)?

2013-03-20 Thread Bjørn Mork
Shawn Starr shawn.st...@rogers.com writes: Hello folks, I was looking at why I can't load the Intel RNG driver (or why it doesn't load automatically) and it just so happens I have both the mobile and non-mobile ICH9 chipset. Looking at the driver I noticed: /* BAM, CAM, DBM, FBM, GxM

Re: 3.9-rc3+: reports battery as 0 mWh capacity on thinkpad x60

2013-03-23 Thread Bjørn Mork
Rafael J. Wysocki r...@sisk.pl writes: On Saturday, March 23, 2013 12:40:12 PM Pavel Machek wrote: Hi! pavel@amd:~$ cat /proc/acpi/battery/BAT0/info present: yes design capacity: 0 mWh last full capacity: 0 mWh battery technology: rechargeable design

Re: [PATCH 1/1] USB: Added quirk to recognize GE0301 3G modem as an interface.

2013-03-13 Thread Bjørn Mork
manoj.i...@canonical.com writes: +/* Reported by Timo Aaltonen tjaal...@ubuntu.com */ +UNUSUAL_DEV( 0x0af0, 0x7011, 0x, 0x, + Option, + Mass Storage, + USB_SC_DEVICE, USB_PR_DEVICE, option_ms_init, + 0 ), + /* Reported by F. Aben

v3.8 regression: Huawei mode switching fails (was Re: [PATCH 2/2]linux-usb:optimize to match the Huawei USB storage devices and support new switch command)

2013-03-04 Thread Bjørn Mork
Hello Franko, This patch causes a number of regressions for both the Huawei devices I have available for testing. One of them is completely unusable in v3.8 (unable to switch to modem mode) unless the usb-storage driver is disabled. I realize that some devices are historically handled by the

[PATCH] USB: storage: fix Huawei mode switching regression

2013-03-04 Thread Bjørn Mork
. The long term plan is to remove the list, not to add to it. Ref: http://permalink.gmane.org/gmane.linux.usb.general/28543 Cc: fangxiao...@huawei.com Cc: stable sta...@vger.kernel.org Signed-off-by: Bjørn Mork bj...@mork.no --- I just realized that this already had gone into maintained stable

Re: [PATCH] USB: storage: fix Huawei mode switching regression

2013-03-04 Thread Bjørn Mork
Ben Hutchings b...@decadent.org.uk writes: On Mon, 2013-03-04 at 14:19 +0100, Bjørn Mork wrote: [...] In-kernel mode switching was deprecated years ago with the development of the more user friendly userspace alternatives. The existing list of devices in usb-storage was only kept to prevent

Re: [PATCH] USB: storage: fix Huawei mode switching regression

2013-03-04 Thread Bjørn Mork
years before finally deleting it, arguing that noone can be using the feature because it's broken :) Bjørn On Mon, Mar 4, 2013 at 8:47 AM, Bjørn Mork bj...@mork.no wrote: Ben Hutchings b...@decadent.org.uk writes: On Mon, 2013-03-04 at 14:19 +0100, Bjørn Mork wrote: [...] In-kernel mode

Re: [PATCH] USB: storage: fix Huawei mode switching regression

2013-03-05 Thread Bjørn Mork
Fangxiaozhi (Franko) fangxiao...@huawei.com writes: -- commit 200e0d99 and commit cd060956, only put the switch command into kernel, instead of userspace usb_modeswitch utility. Yes. And that is the problem. It was agreed years ago that this functionality belongs in userspace. Ref e.g

Re: [PATCH] USB: storage: fix Huawei mode switching regression

2013-03-05 Thread Bjørn Mork
Oliver Neukum oneu...@suse.de writes: On Monday 04 March 2013 23:28:47 Josua Dietze wrote: I guess the real problem will be verifying that all of the entries can go away. This type of hardware tends to get old very fast, but there is always someone having a really ancient device. I will

Re: [PATCH] USB: storage: fix Huawei mode switching regression

2013-03-05 Thread Bjørn Mork
Oliver Neukum oneu...@suse.de writes: On Tuesday 05 March 2013 11:07:05 Bjørn Mork wrote: Fangxiaozhi (Franko) fangxiao...@huawei.com writes: -- commit 200e0d99 and commit cd060956, only put the switch command into kernel, instead of userspace usb_modeswitch utility. Yes

Re: [PATCH 2/2] driver-core: remove the duplicate assignment of kobj-parent in device_add

2013-03-07 Thread Bjørn Mork
Wei Yang weiy...@linux.vnet.ibm.com writes: kobject_add() will setup the kobject parent correctly. This patch removes the redundant code. Signed-off-by: Wei Yang weiy...@linux.vnet.ibm.com Reviewed-by: Ram Pai linux...@us.ibm.com Reviewed-by: Gavin Shan sha...@linux.vnet.ibm.com ---

Re: 答复: [PATCH] USB: storage: fix Huawei mode switching regression

2013-03-07 Thread Bjørn Mork
Fangxiaozhi (Franko) fangxiao...@huawei.com writes: As far as I know, except switching in kernel, there isn't any mode switch solution on Android now. Do you have any good ideas for the mode switch on Android system? Josh, the usb_modeswitch maintainer, is also maintaining

Re: [PATCH 2/2] driver-core: remove the duplicate assignment of kobj-parent in device_add

2013-03-07 Thread Bjørn Mork
[ not stripping any quoting to restore context for linux-kernel] Wei Yang weiy...@linux.vnet.ibm.com writes: On Thu, Mar 07, 2013 at 12:33:19PM +0100, Bjørn Mork wrote: Wei Yang weiy...@linux.vnet.ibm.com writes: kobject_add() will setup the kobject parent correctly. This patch removes

Re: [PATCH 1/1] NET: qmi_wwan: add Telit LE920 support

2013-01-29 Thread Bjørn Mork
Daniele Palmas dnl...@gmail.com writes: 2013/1/28 Bjørn Mork bj...@mork.no: Thanks for adding this device. But the patch doesn't apply to the current net tree. Care to rebase it? Sure. Should I use the following git repository git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/net

Re: [PATCH 1/1] USB: option: add support for Telit LE920

2013-01-29 Thread Bjørn Mork
Dan Williams d...@redhat.com writes: On Mon, 2013-01-28 at 16:47 +0100, Daniele Palmas wrote: From: danielepa danielepa@L2011.(none) Add PID and special handling for Telit LE920 Any idea what interfaces 1 and 5 are? Is one perhaps a pseudo-ethernet interface that could be used instead of

Re: [PATCH 1/1] USB: option: add support for Telit LE920

2013-01-30 Thread Bjørn Mork
Daniele Palmas dnl...@gmail.com writes: The output of lsusb for interface #1 is the following: Interface Descriptor: bLength 9 bDescriptorType 4 bInterfaceNumber1 bAlternateSetting 0 bNumEndpoints 2

Re: [PATCH v2] NET: qmi_wwan: add Telit LE920 support

2013-01-30 Thread Bjørn Mork
Daniele Palmas dnl...@gmail.com writes: Add VID, PID and fixed interface for Telit LE920 Signed-off-by: Daniele Palmas dnl...@gmail.com --- v2: - rebased against net tree Excellent! Thanks. Looks like an interesting device BTW. Acked-by: Bjørn Mork bj...@mork.no -- To unsubscribe from

Re: [PATCH] usb/net/asix_devices: Add USBNET HG20F9 ethernet dongle

2013-02-27 Thread Bjørn Mork
David Miller da...@davemloft.net writes: Applied, thanks Glen. Actually, I had to revert, this doesn't even compile against current sources: CC [M] drivers/net/usb/asix_devices.o drivers/net/usb/asix_devices.c:941:14: error: ‘asix_rx_fixup’ undeclared here (not in a function)

Re: [GIT] x86 platform driver bugfixes for 3.8

2013-03-01 Thread Bjørn Mork
Matthew Garrett matthew.garr...@nebula.com writes: This set covers regressions and two obvious bugfixes. The rest can wait for 3.9. Sorry for nagging, but I assume the 3.9 merge window will close over the weekend and I haven't seen the pull request for the rest of these posted yet. I hope

Re: [GIT] x86 platform driver bugfixes for 3.8

2013-03-01 Thread Bjørn Mork
Bjørn Mork bj...@mork.no writes: Matthew Garrett matthew.garr...@nebula.com writes: This set covers regressions and two obvious bugfixes. The rest can wait for 3.9. Sorry for nagging, but I assume the 3.9 merge window will close over the weekend and I haven't seen the pull request

Re: [PATCH, resubmit] ax88179_178a: ASIX AX88179_178A USB 3.0/2.0 to gigabit ethernet adapter driver

2013-01-28 Thread Bjørn Mork
Hello Michael, Michael Leun lkml20130...@newton.leun.net writes: I would vote to not accept that driver for mainline as long as this issues are not fixed. The vendor should not be able to claim hooray, hooray, great device, we even have an driver in linux main line when it is actually such

Re: [PATCH, resubmit] ax88179_178a: ASIX AX88179_178A USB 3.0/2.0 to gigabit ethernet adapter driver

2013-01-28 Thread Bjørn Mork
Freddy fre...@asix.com.tw writes: Bjørn, I am trying to reproduce the issue mentioned by Michael and I have a question about submitting this driver. Should I merge this driver into asix_devices.c and asix_common.c even through the usb command, tx_fixup, and rx_fixup functions are totally

Re: [PATCH 1/1] NET: qmi_wwan: add Telit LE920 support

2013-01-28 Thread Bjørn Mork
Daniele Palmas dnl...@gmail.com writes: Add VID, PID and fixed interface for Telit LE920 Signed-off-by: Daniele Palmas dnl...@gmail.com --- drivers/net/usb/qmi_wwan.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/net/usb/qmi_wwan.c

Re: [PATCH] mpt2sas: prevent double free on error path

2013-01-23 Thread Bjørn Mork
Jörn Engel jo...@logfs.org writes: diff --git a/drivers/scsi/mpt2sas/mpt2sas_scsih.c b/drivers/scsi/mpt2sas/mpt2sas_scsih.c index c6bdc92..43b3a98 100644 --- a/drivers/scsi/mpt2sas/mpt2sas_scsih.c +++ b/drivers/scsi/mpt2sas/mpt2sas_scsih.c @@ -570,6 +570,18 @@

Re: [GIT] x86 platform driver bugfixes for 3.8

2013-01-16 Thread Bjørn Mork
Matthew Garrett matthew.garr...@nebula.com writes: This set covers regressions and two obvious bugfixes. The rest can wait for 3.9. Hello Matthew, may I request that you include the patch sony-laptop: fully enable SNY controlled modems for 3.8 as well? I'd even like it to go to

Re: usb_wwan_write() called while device still being resumed

2013-02-14 Thread Bjørn Mork
: 8bit Reported-by: Alex Courbot acour...@nvidia.com Signed-off-by: Bjørn Mork bj...@mork.no --- drivers/usb/serial/usb_wwan.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/usb/serial/usb_wwan.c b/drivers/usb/serial/usb_wwan.c index 01c94aa..44e106d 100644

Re: usb_wwan_write() called while device still being resumed

2013-02-15 Thread Bjørn Mork
Alex Courbot acour...@nvidia.com writes: Unfortunately it does not, and fails the same way. On the other hand, I do not see the issue when doing the following: diff --git a/drivers/usb/serial/usb_wwan.c b/drivers/usb/serial/usb_wwan.c index e4fad5e..1490029 100644 ---

Re: [Ksummit-2006-discuss] 2007 Linux Kernel Summit

2007-01-26 Thread Bjørn Mork
Mauro Carvalho Chehab [EMAIL PROTECTED] writes: The company I work hold last year an ETSI internal meeting about IMS in Brasília. It were a very interesting experience. The meeting were closed to ETSI members and some people invited. After the meeting, there were two days of an open event.

Re: [ 34/95] USB: option: add ZTE K5006-Z

2012-09-11 Thread Bjørn Mork
tschae...@t-online.de Signed-off-by: Bjørn Mork bj...@mork.no Signed-off-by: Greg Kroah-Hartman gre...@linuxfoundation.org Signed-off-by: Ben Hutchings b...@decadent.org.uk --- drivers/usb/serial/option.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/serial/option.c b

Re: [PATCH 2/3] drivers/misc: Add realtek pci card reader driver

2012-07-26 Thread Bjørn Mork
wei_w...@realsil.com.cn writes: +static bool msi_en = 1; +module_param(msi_en, bool, S_IRUGO | S_IWUSR); +MODULE_PARM_DESC(msi_en, Enable MSI); + +static bool adma_mode = 1; +module_param(adma_mode, bool, S_IRUGO | S_IWUSR); +MODULE_PARM_DESC(adma_mode, ADMA Mode); Why would I want to

Re: Kernel Oops while disconnecting USB peripheral (always)

2012-07-28 Thread Bjørn Mork
Daniel Mack zon...@gmail.com writes: On 23.07.2012 16:47, Alan Stern wrote: On Mon, 23 Jul 2012, Sarbojit Ganguly wrote: That is why I provided two stacks, 1st one is when I tried to remove the USB hub (which connects a webcam + microphone) 2nd one is when I tried to remove an USB powered

Re: Kernel Oops while disconnecting USB peripheral (always)

2012-07-28 Thread Bjørn Mork
Daniel Mack zon...@gmail.com writes: On 28.07.2012 14:27, Bjørn Mork wrote: The reason is this change: 0998d0631 device-core: Ensure drvdata = NULL when no driver is bound It will make bugs like this suddenly 100% reproducible. But the bugs *are* in the drivers, and may have been

Re: input0: bad kobj_uevent_env content in show_uevent()

2012-09-02 Thread Bjørn Mork
Fengguang Wu fengguang...@intel.com writes: After the __devinit* removal series, I can still get kernel panic in show_uevent(). So there are more sources of bug.. Debug patch: @@ -343,8 +343,11 @@ static ssize_t show_uevent(struct device goto out; /* copy keys to

Re: input0: bad kobj_uevent_env content in show_uevent()

2012-09-03 Thread Bjørn Mork
, but work to get rid of CONFIG_HOTPLUG completly for 3.7 as it just causes problems. OK, do you want me to propose some commit message, or do you prefer to write something coherent yourself instead? In any case, if you need it for the oneline hack: Signed-off-by: Bjørn Mork bj...@mork.no Bjørn

Re: [BUG Report] BUG: unable to handle kernel NULL pointer dereference at

2012-08-13 Thread Bjørn Mork
Liu Bo liub.li...@gmail.com writes: I'm using mainline upstream 3.6.0-rc1 compiled based on Fedora-16. When I unplug my mobile usb card, I hit this: [ 247.017258] BUG: unable to handle kernel NULL pointer dereference at (null) [ 247.017378] IP: [a03bf27f]

Re: [PATCH] drivers: hv: use Linux version in guest ID

2012-08-13 Thread Bjørn Mork
Greg KH gre...@linuxfoundation.org writes: On Fri, Jul 20, 2012 at 04:02:44PM +, KY Srinivasan wrote: On Fri, Jul 20, 2012 at 10:03:08AM +0200, Bjørn Mork wrote: +/* Linux vendor ID allocated by Microsoft */ +#define HV_LINUX_GUEST_ID_VENDOR0xB16B + +/* Creating

Re: [PATCH] drivers: hv: use Linux version in guest ID

2012-08-13 Thread Bjørn Mork
KY Srinivasan k...@microsoft.com writes: In the interim, I have submitted a patch that conforms to the MSFT guidelines for generating guest IDs for non-MSFT operating systems on Hyper-V. Oh, sorry. I missed that. Found it now. Thanks Including distro info in a driver interface looks a bit

Re: [PATCH 0/5] Call netif_carrier_off() after register_netdev()

2012-08-15 Thread Bjørn Mork
Ben Hutchings bhutchi...@solarflare.com writes: But if you do it beforehand then it doesn't have the intended effect. (Supposed to be fixed by 22604c866889c4b2e12b73cbf1683bda1b72a313, which had to be reverted: c276e098d3ee33059b4a1c747354226cec58487c.) So you have to do it after, but

Re: BUG: unable to handle kernel paging request in usb_match_id()

2012-08-17 Thread Bjørn Mork
Fengguang Wu fengguang...@intel.com writes: @@ -779,6 +780,7 @@ static int usb_device_match(struct devic intf = to_usb_interface(dev); usb_drv = to_usb_driver(drv); + pr_info(%s: device %s, driver %s \n, __func__, dev_name(dev), drv-name);

Re: BUG: unable to handle kernel paging request in usb_match_id()

2012-08-17 Thread Bjørn Mork
Bjørn Mork bj...@mork.no writes: Fengguang Wu fengguang...@intel.com writes: @@ -779,6 +780,7 @@ static int usb_device_match(struct devic intf = to_usb_interface(dev); usb_drv = to_usb_driver(drv); + pr_info(%s: device %s, driver %s \n, __func__

Re: BUG: unable to handle kernel paging request in usb_match_id()

2012-08-19 Thread Bjørn Mork
Ming Lei tom.leim...@gmail.com writes: On Fri, Aug 17, 2012 at 10:42 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Fri, Aug 17, 2012 at 10:38:16AM -0400, Alan Stern wrote: On Fri, 17 Aug 2012, Ming Lei wrote: But, if HOTPLUG is not enabled, should device_add() trigger driver

Re: [PATCH 0/4] PCI/PM: PCI D3cold support fixes for 3.6-rc1

2012-08-19 Thread Bjørn Mork
for sysfs file d3cold_allowed Hello, I am hoping these patches will appear in 3.6? They fix real problems in 3.6-rc1 for me. If it helps in any way, feel free to add Tested-by: Bjørn Mork bj...@mork.no to the 3 bugfix patches, including version 2 of patch #3. Bjørn -- To unsubscribe from this list

Re: linux-next: build failure after merge of the net-next tree

2012-07-10 Thread Bjørn Mork
Stephen Rothwell s...@canb.auug.org.au writes: Hi all, After merging the net-next tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/net/usb/qmi_wwan.c:381:13: error: 'qmi_wwan_unbind_shared' undeclared here (not in a function) Caused by a bad automatic merge

Re: [PATCH] USB: add USB_VENDOR_AND_INTERFACE_INFO() macro

2012-07-11 Thread Bjørn Mork
Greg Kroah-Hartman gre...@linuxfoundation.org writes: On Tue, Jul 10, 2012 at 06:51:03PM -0300, Gustavo Padovan wrote: { USB_VENDOR_AND_INTERFACE_INFO(0x0a5c, 0xff, 0x01, 0x01) } Two entries in the cdc_wdm driver can also be converted to use this interface. Do you want to send a patch doing

[regression][PATCH v3] watchdog: Fix disable/enable regression

2012-12-18 Thread Bjørn Mork
/state Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=51661 Cc: sta...@vger.kernel.org # v3.7 Cc: Norbert Warmuth nwarm...@t-online.de Cc: Joseph Salisbury joseph.salisb...@canonical.com Cc: Thomas Gleixner t...@linutronix.de Signed-off-by: Bjørn Mork bj...@mork.no --- v3: added Bugzilla

[RESEND][PATCH v3] watchdog: Fix disable/enable regression

2012-12-19 Thread Bjørn Mork
/state Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=51661 Cc: sta...@vger.kernel.org # v3.7 Cc: Norbert Warmuth nwarm...@t-online.de Cc: Joseph Salisbury joseph.salisb...@canonical.com Cc: Thomas Gleixner t...@linutronix.de Signed-off-by: Bjørn Mork bj...@mork.no --- Hello Linus, This post

Re: [RESEND][PATCH v3] watchdog: Fix disable/enable regression

2012-12-19 Thread Bjørn Mork
Don Zickus dzic...@redhat.com writes: On Wed, Dec 19, 2012 at 08:51:31PM +0100, Bjørn Mork wrote: commit 8d451690 (watchdog: Fix CPU hotplug regression) cause an oops or hard lockup when doing echo 0 /proc/sys/kernel/nmi_watchdog echo 1 /proc/sys/kernel/nmi_watchdog and the kernel

Re: [RESEND][PATCH v3] watchdog: Fix disable/enable regression

2012-12-19 Thread Bjørn Mork
Bjørn Mork bj...@mork.no writes: Don Zickus dzic...@redhat.com writes: What about the opposite cases? nmi_watchdog=1 echo 1 /sys/devices/system/cpu/cpu1/online I don't see why not. But verifying it would be nice. I thought that it would be a simple thing to test using qemu-kvm

Bisected oops regression between v3.7-rc8 and v3.7: nmi_watchdog

2012-12-14 Thread Bjørn Mork
Hello, I was a bit surprised by v3.7 hanging all the time, usually just freezing but sometimes with a stack dump pointing to timerqueue_del calling rb_erase and oopsing there. Of course I could never make it dump anything when prepared to capture it via netconsole, so the best I have is this

[PATCH] Revert watchdog: Fix CPU hotplug regression

2012-12-14 Thread Bjørn Mork
: Thomas Gleixner t...@linutronix.de Signed-off-by: Bjørn Mork bj...@mork.no --- kernel/watchdog.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/kernel/watchdog.c b/kernel/watchdog.c index c8c21be..dd4b80a 100644 --- a/kernel/watchdog.c +++ b/kernel/watchdog.c @@ -368,9

[PATCH v2] watchdog: Fix disable/enable regression

2012-12-14 Thread Bjørn Mork
/state Cc: sta...@vger.kernel.org # v3.7 Cc: Norbert Warmuth nwarm...@t-online.de Cc: Joseph Salisbury joseph.salisb...@canonical.com Cc: Thomas Gleixner t...@linutronix.de Signed-off-by: Bjørn Mork bj...@mork.no --- v2: implemented an alternate workaround for the original problem. Hello Thomas, I

Re: [PATCH v2] LDT - Linux Driver Template

2012-11-16 Thread Bjørn Mork
Greg KH gre...@linuxfoundation.org writes: Normally you just start with a driver for a device like the one you need to write and modify it from there. Yes. Even if the template driver is fixed up to be the most beautiful driver ever made, it will still always be made for non-existing

Re: 3.11.0-rc6+: INFO: possible circular locking dependency detected

2013-08-20 Thread Bjørn Mork
Miles Lane miles.l...@gmail.com writes: [ 24.990076] [ INFO: possible circular locking dependency detected ] [ 24.990086] 3.11.0-rc6+ #154 Not tainted [ 24.990094] --- [ 24.990103] crda/1159 is trying to acquire lock: [ 24.990111]

Re: [Bug] Reproducible data corruption on i5-3340M: Please revert 53a59fc67!

2013-08-15 Thread Bjørn Mork
Linus Torvalds torva...@linux-foundation.org writes: Comments? Especially s390, ARM, ia64, sh and um that I edited blindly... I can see that :-) You have a couple of unsigned logns here. Bjørn --- a/arch/arm64/include/asm/tlb.h +++ b/arch/arm64/include/asm/tlb.h @@ -35,6 +35,7 @@ struct

Re: [RFC PATCH] thinkpad_acpi: Add support for controlling charge thresholds

2013-11-05 Thread Bjørn Mork
Julian Andres Klode j...@jak-linux.org writes: +TPACPI_HANDLE(battery, root, \\_SB.PCI0.LPC.EC.HKEY, +\\_SB.PCI0.LPCB.EC.HKEY, /* X121e, T430u */ +\\_SB.PCI0.LPCB.H_EC.HKEY, /* L430 */ +\\_SB.PCI0.LPCB.EC0.HKEY, /* Edge/S series */ +

v3.13-rc1: ‘system_trusted_keyring’ undeclared caused by commit 09fbc47373826 (KEYS: verify a certificate is signed by a 'trusted' key)

2013-11-23 Thread Bjørn Mork
This commit commit 09fbc47373826d67531380662b516de2da120545 Author: Mimi Zohar zo...@linux.vnet.ibm.com Date: Tue Aug 20 14:36:27 2013 -0400 KEYS: verify a certificate is signed by a 'trusted' key Only public keys, with certificates signed by an existing 'trusted' key on the

Re: [PATCH V3] usbnet: fix race condition caused spinlock bad magic issue

2013-11-14 Thread Bjørn Mork
Oliver Neukum oli...@neukum.org writes: On Thu, 2013-11-14 at 10:03 +0800, wangbiao wrote: From: wang, biao biao.w...@intel.com Date: Mon, 11 Nov 2013 10:23:40 +0800 Subject: [PATCH] usbnet: fix race condition caused spinlock bad magic issue there is race between usbnet_terminate_urbs and

Re: [PATCH 2/2] net: cdc_ncm: respect operator preferred MTU reported by MBIM

2014-03-17 Thread Bjørn Mork
Is this *really* driver material, or should we just leave the IP MTU hint handling up to the userspace management application? There are no less than 3(!) different ways for a device to specify the MBIM MTU: 1) wMaxSegmentSize field of the MBIM Control Model Functional Descriptor

Re: [PATCH 2/2] net: cdc_ncm: respect operator preferred MTU reported by MBIM

2014-03-17 Thread Bjørn Mork
Ben Chan benc...@chromium.org writes: It's a bit messy how MTU is currently handled in MBIM. While wMTU may seem optional and redundant, it addresses some issues with wMaxSegmentSize and MBIM_CID_IP_CONFIGURATION, and hence why I suggest using wMTU when available: (1) wMaxSegmentSize The

Re: [PATCH v3 2/2] net: cdc_ncm: respect operator preferred MTU reported by MBIM

2014-03-18 Thread Bjørn Mork
v3 (which is same as v2) adds the le16_to_cpu conversion on ctx-mbim_extended_desc-wMTU as pointed out and suggested by 'Bjørn Mork bj...@mork.no'. Looks good to me FWIW. I was worried that I might have created a merge conflict here by posting the unrelated cdc_ncm fix, touching the same

Re: [PATCH v3 1/2] USB: cdc: add MBIM extended functional descriptor structure

2014-03-18 Thread Bjørn Mork
Ben Chan benc...@chromium.org writes: This patch adds the MBIM extended functional descriptor structure defined in Universal Serial Bus Communications Class Subclass Specification for Mobile Broadband Interface Model, Revision 1.0, Errata-1 published by USB-IF. Signed-off-by: Ben Chan

Re: v3.14-rc1+: new error: nsc-ircc, Wrong chip version ff

2014-03-18 Thread Bjørn Mork
Paul Bolle pebo...@tiscali.nl writes: Rafael, 0) Ever since v3.14-rc1 I've noticed two new boot messages on an, outdated, ThinkPad X41: nsc-ircc, Found chip at base=0x164e nsc-ircc, Wrong chip version ff Looks like that driver calls request_region for its fir_base IO ports too

Re: [PATCH] net/usb: Add Lenovo ThinkPad OneLink GigaLAN USB ID to ax88179 driver

2014-02-25 Thread Bjørn Mork
Keith Packard kei...@keithp.com writes: Kyle McMartin says: lenovo_info, surely. Yeah, Daniel Stone caught the same bug. Not a big deal; the only difference between any of these elements is the string produced by the kernel. Yes, and that mess should really be cleaned up in this driver

Re: [PATCH 1/1] AX88179_178A: Add VID:DID for Lenovo OneLinkDock Gigabit LAN

2014-02-26 Thread Bjørn Mork
fre...@asix.com.tw writes: From: Freddy Xin fre...@asix.com.tw Add VID:DID for Lenovo OneLinkDock Gigabit LAN This is the same patch Keith Packard sent, but with a slighly different description. I take that as another proof that we should not attempt to describe devices in these drivers.

Re: [PATCH 1/1] AX88179_178A: Add VID:DID for Lenovo OneLinkDock Gigabit LAN

2014-02-26 Thread Bjørn Mork
David Miller da...@davemloft.net writes: From: Bjørn Mork bj...@mork.no Date: Wed, 26 Feb 2014 13:13:12 +0100 fre...@asix.com.tw writes: From: Freddy Xin fre...@asix.com.tw Add VID:DID for Lenovo OneLinkDock Gigabit LAN This is the same patch Keith Packard sent, but with a slighly

Re: [PATCH 1/1] AX88179_178A: Add VID:DID for Lenovo OneLinkDock Gigabit LAN

2014-02-26 Thread Bjørn Mork
David Miller da...@davemloft.net writes: From: Bjørn Mork bj...@mork.no No, sorry for being confusing. The patch is fine. But Keith sent it first... Did I apply Keith's patch? No, you didn't. And when I went looking at it now, I see why: It was posted to linux-usb and linux-kernel

Re: [RFC PATCH] support Thinkpad X1 Carbon's adaptive keyboard

2014-03-03 Thread Bjørn Mork
Shuduo Sang shuduo.s...@canonical.com writes: Hi all, We are working together with Lenovo to enable thinkpad X1 Carbon's fancy feature, Adaptive Keyboard[1] for Linux. Adaptive keyboard has five modes on Windows including Home mode, Web browser mode, Web conference mode, Function mode and

Re: [PATCH net-next 1/2] r8152: add CONFIG_RTL8152_EARLY_AGG_SUPER

2014-03-12 Thread Bjørn Mork
Hayes Wang hayesw...@realtek.com writes: + config RTL8152_EARLY_AGG_SUPER + hex rx early agg parameter for super speed + default 0x0e832981 + help + This is the rx early agg parameter for USB super speed. + + endmenu How do I as an

Re: [PATCH] usbnet: remove generic hard_header_len check

2014-02-13 Thread Bjørn Mork
Emil Goode emilgo...@gmail.com writes: This patch removes a generic hard_header_len check from the usbnet module that is causing dropped packages under certain circumstances for devices that send rx packets that cross urb boundaries. One example is the AX88772B which occasionally send rx

Re: [PATCH] usbnet: remove generic hard_header_len check

2014-02-13 Thread Bjørn Mork
Emil Goode emilgo...@gmail.com writes: Yes I should have put a comment in the changelog about this. All skbs that are passed to rx_process have their state set to rx_cleanup and just because the skb was cloned doesn't mean that we should free the original in a different way. As it is I think

Re: [PATCH 1/2 v2] usbnet: fix bad header length bug

2014-02-10 Thread Bjørn Mork
Oliver Neukum oli...@neukum.org writes: On Mon, 2014-02-10 at 13:00 +0100, Emil Goode wrote: On Mon, Feb 10, 2014 at 07:40:58AM +0100, Oliver Neukum wrote: Well, then how about simply removing the check? It seems to have outlived its usefulness. Regards Oliver I

Re: [BUGREPORT] Linux USB 3.0

2014-02-11 Thread Bjørn Mork
Markus Rechberger mrechber...@gmail.com writes: Next kernel crash report, this time a Synology NAS System: http://support.sundtek.com/index.php/topic,1511.0.html There is no etxhci_hcd driver in the mainline kernel... Feb 11 18:50:41 DiskStation kernel: [103740.405521] Backtrace: Feb 11

Re: IRQ kernel message after upgrade to 3.14-rc1

2014-02-11 Thread Bjørn Mork
I assume you use the i915 driver? This is a known regression for some chips. Fix is in the i915 repo. Bjørn On 11 February 2014 22:37:04 CET, Arend van Spriel ar...@broadcom.com wrote: I upgraded a couple of test rigs for our wireless drivers and noticed this blurb showing up in the logs

Re: [PATCH 1/1] Create megaraid ioctl device node

2013-05-06 Thread Bjørn Mork
Patrick Monnerat patrick.monne...@datasphere.ch writes: From: Patrick Monnerat p...@datasphere.ch Create ioctl device node for megaraid_sas driver. Let this node be managed by udev. Fix a typo. Or maybe just simplify it all and use a misc device instead? See how this is done in e.g.

Re: [GIT] Networking

2013-05-02 Thread Bjørn Mork
-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Bjørn Mork bj...@mork.no --- net/8021q/vlan_dev.c |2 +- net/core/ethtool.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/net/8021q/vlan_dev.c b/net/8021q/vlan_dev.c

Re: [GIT] Networking

2013-05-02 Thread Bjørn Mork
David Miller da...@davemloft.net writes: From: Bjørn Mork bj...@mork.no Date: Thu, 02 May 2013 11:06:42 +0200 Adding the new netdev features will make it go from 1 to 2: We already had more than 31 feature bits before Patrick's changes, and I'm pretty sure this was the case when we added

Re: [GIT] Networking

2013-05-02 Thread Bjørn Mork
Ben Hutchings bhutchi...@solarflare.com writes: On Thu, 2013-05-02 at 05:17 -0400, David Miller wrote: From: Bjørn Mork bj...@mork.no Date: Thu, 02 May 2013 11:06:42 +0200 Adding the new netdev features will make it go from 1 to 2: We already had more than 31 feature bits before

Re: [PATCH] NET DRIVER: Added support for Cinterion's PLxx WWAN Interface

2013-05-06 Thread Bjørn Mork
)},/* Cinterion PLxx */ /* 4. Gobi 1000 devices */ {QMI_GOBI1K_DEVICE(0x05c6, 0x9212)},/* Acer Gobi Modem Device */ Looks good. Thanks. Acked-by: Bjørn Mork bj...@mork.no -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

Re: [PATCH 1/3] thinkpad_acpi: return -NODEV while operating uninitialized LEDs

2013-06-07 Thread Bjørn Mork
Adam Lee adam@canonical.com writes: --- a/drivers/platform/x86/thinkpad_acpi.c +++ b/drivers/platform/x86/thinkpad_acpi.c @@ -5401,9 +5401,12 @@ static int led_write(char *buf) return -ENODEV; while ((cmd = next_cmd(buf))) { - if (sscanf(cmd, %d, led)

Re: [Arm-netbook] getting allwinner SoC support upstream (was Re: Uploading linux (3.9.4-1))

2013-06-07 Thread Bjørn Mork
Tomasz Figa tomasz.f...@gmail.com writes: Seeing from your posts you don't have any knowledge on how Linux kernel development works and even on how Allwinner's cooperation with our community looks (and seem to be completely closed to our effort of showing you the reality), so I'm not sure

Re: [PATCH] net: skbuff: use _RET_IP_

2013-05-30 Thread Bjørn Mork
Sergei Shtylyov sergei.shtyl...@cogentembedded.com writes: Why not text:%#lx as already used in this string? It's equivalent to 0x%lx. Well, I don't know the reasoning in this case, but I'd like to note that those are not strictly equivalent. Personally I find the formatting of 0 annoying

Re: [PATCH] net: skbuff: use _RET_IP_

2013-05-31 Thread Bjørn Mork
Joe Perches j...@perches.com writes: On Thu, 2013-05-30 at 18:11 -0700, Davidlohr Bueso wrote: On Thu, 2013-05-30 at 13:08 +0200, Bjørn Mork wrote: Sergei Shtylyov sergei.shtyl...@cogentembedded.com writes: Why not text:%#lx as already used in this string? It's equivalent to 0x%lx

  1   2   3   4   5   6   7   >