On Sun, Apr 15, 2007 at 09:10:50AM +0200, Borislav Petkov wrote:
On Sat, Apr 14, 2007 at 09:13:41AM -0700, Randy Dunlap wrote:
On Fri, 13 Apr 2007 11:14:22 +0200 Borislav Petkov wrote:
This patch shuts warnings of the sort:
make -C /mnt/samsung_200/sam/kernel/trees/21-rc6/build
snip
I'm pretty sure the reason you cannot reproduce this warning is the line
xsl:param name=refentry.version.suppress1/xsl:param
which can be found in param.xsl, it being a part of the docbook-xsl
distribution. The parameter's name is self-explanatory and a '1' suppresses
the
On Wed, Apr 18, 2007 at 10:16:54AM -0700, Randy Dunlap wrote:
On Fri, 13 Apr 2007 11:29:43 +0200 Borislav Petkov wrote:
Sorry for the improper whitespaces, here's a correct version.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
Index: 21-rc6/scripts/kernel-doc
A fixed version of the patch shutting up missing version warnings when building
mandocs.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
Index: 21-rc7/scripts/kernel-doc
===
--- 21-rc7.orig/scripts/kernel-doc
+++ 21-rc7/scripts
On Thu, Apr 19, 2007 at 09:21:22AM -0700, Randy Dunlap wrote:
On Thu, 19 Apr 2007 09:19:32 +0200 Borislav Petkov wrote:
A fixed version of the patch shutting up missing version warnings when
building
mandocs.
http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt ::
Please include
On Thu, Apr 19, 2007 at 08:53:36AM -0700, Randy Dunlap wrote:
On Thu, 19 Apr 2007 08:20:59 +0200 Borislav Petkov wrote:
snip
I'm pretty sure the reason you cannot reproduce this warning is the
line
xsl:param name=refentry.version.suppress1/xsl:param
which can
On Sat, Apr 21, 2007 at 12:20:45AM -0700, Andrew Morton wrote:
On Thu, 19 Apr 2007 09:19:32 +0200 Borislav Petkov [EMAIL PROTECTED] wrote:
we already did this in the top-level Makefile. It's in $(KERNELVERSION)
and is printed by `make kernelversion'.
Cannot we use that info somehow?
Yes
Sorry about the wrong whitespaces again :), here's a correct one
-
From: Borislav Petkov [EMAIL PROTECTED]
This patch shuts warnings of the sort:
make -C /mnt/samsung_200/sam/kernel/trees/21-rc6/build \
KBUILD_SRC=/mnt/samsung_200/sam/kernel/trees/21-rc6 \
KBUILD_EXTMOD= -f
in
Documentation/DocBook/Makefile):
-
From: Borislav Petkov [EMAIL PROTECTED]
This patch shuts warnings of the sort:
make -C /mnt/samsung_200/sam/kernel/trees/21-rc6/build \
KBUILD_SRC=/mnt/samsung_200/sam/kernel/trees/21-rc6 \
KBUILD_EXTMOD= -f /mnt/samsung_200/sam/kernel/trees/21-rc6
makes the array subscripts unreadable in the docs.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
--- 21-rc6/scripts/kernel-doc.orig 2007-04-07 16:48:51.0 +0200
+++ 21-rc6/scripts/kernel-doc 2007-04-07 16:51:17.0 +0200
@@ -1456,7 +1456,16 @@ sub create_parameterlist
Andrew, you can drop
+kernel-doc-handle-spaces-in-array-size.patch
since
+kernel-doc-handle-arrays-with-arithmetic-expressions-as.patch
fixes the issue in a slightly better way.
--
Regards/Gruß,
Boris.
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of
Here's a patch for kernel-doc that enables the generation of a global, TOC-like
index.html
page after building 'htmldocs'
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
Index: 21-rc6/Documentation/DocBook/Makefile
===
--- 21
This patch sorts the DOCBOOKS entries in Documentation/DocBook/Makefile
alphabetically.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
Index: 21-rc6/Documentation/DocBook/Makefile
===
--- 21-rc6.orig/Documentation/DocBook
\fi
* kernel-hacking.tex
/log
This is a rather arbitrary fix, so suggest away.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
Index: 21-rc6/Documentation/DocBook/kernel-hacking.tmpl
===
--- 21-rc6.orig/Documentation/DocBook
On Thu, Apr 12, 2007 at 04:48:51PM -0700, Randy Dunlap wrote:
On Thu, 12 Apr 2007 22:38:42 +0200 Borislav Petkov wrote:
When building pdfdocs, the db2pdf converter bails out because of an
latex-reserved token - '#' - in the intermediary .tex file which ends up
in a
conversion error
DTD for the man header, I believe, for the
troff output is truncated too.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
Index: 21-rc6/scripts/kernel-doc
===
--- 21-rc6.orig/scripts/kernel-doc
+++ 21-rc6/scripts/kernel-doc
@@ -326,6
Sorry for the improper whitespaces, here's a correct version.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
Index: 21-rc6/scripts/kernel-doc
===
--- 21-rc6.orig/scripts/kernel-doc
+++ 21-rc6/scripts/kernel-doc
@@ -326,6 +326,32
On Fri, Apr 13, 2007 at 08:20:49AM -0700, Randy Dunlap wrote:
On Fri, 13 Apr 2007 08:35:00 +0200 Borislav Petkov wrote:
On Thu, Apr 12, 2007 at 04:48:51PM -0700, Randy Dunlap wrote:
On Thu, 12 Apr 2007 22:38:42 +0200 Borislav Petkov wrote:
When building pdfdocs, the db2pdf
On Sat, Apr 14, 2007 at 09:13:41AM -0700, Randy Dunlap wrote:
On Fri, 13 Apr 2007 11:14:22 +0200 Borislav Petkov wrote:
This patch shuts warnings of the sort:
make -C /mnt/samsung_200/sam/kernel/trees/21-rc6/build \
KBUILD_SRC=/mnt/samsung_200/sam/kernel/trees/21-rc6
variable instead.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-floppy.c | 67 +++--
1 files changed, 17 insertions(+), 50 deletions(-)
diff --git a/drivers/ide/ide-floppy.c b/drivers/ide/ide-floppy.c
index 3d9b1e5..4106eb4 100644
medium type, this
comparison is now done by simply checking whether the medium has changed.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-floppy.c | 89 -
1 files changed, 32 insertions(+), 57 deletions(-)
diff --git a/drivers/ide
the current/maximum capacity descriptor. i.e the first one.
- fix comments formatting
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-floppy.c | 132 +
1 files changed, 50 insertions(+), 82 deletions(-)
diff --git a/drivers/ide/ide
which releases that last
reference.
Rename ide_floppy_release() to idefloppy_cleanup_obj() in order to make its
purpose
more clear. There should be no functionality change resulting from this patch.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-floppy.c |6 +++---
1
In addition to shortening the function name, move the printk-call into the
function thereby saving some code lines. Also, make the function out_of_line
since it is not on a performance critical path.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-floppy.c | 37
Replace the ide-floppy packet commands opcode defines with the generic ones.
Add a missing GPCMD_WRITE_12 (opcode 0xaa) to the generic ones in cdrom.h. The
last one can be found in the current version of INF-8090, p.905.
CC: Jens Axboe [EMAIL PROTECTED]
Signed-off-by: Borislav Petkov [EMAIL
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-floppy.c | 41 -
1 files changed, 0 insertions(+), 41 deletions(-)
diff --git a/drivers/ide/ide-floppy.c b/drivers/ide/ide-floppy.c
index 5c85833..d98264e 100644
--- a/drivers/ide/ide
That is,
- remove unnecessary comments
- shorten comments
- shorten lines longer 80 columns
- cleanup whitespace
- add a missing loglevel KERN_ to a printk-call
- fix misc checkpatch warnings
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-floppy.c | 402
* some debug_log() calls were not using ide-floppy: prefix
* a few used printk levels different than KERN_INFO (KERN_NOTICE
and KERN_ERR, which is the default one if no level is given)
There should be no functional change resulting from this patch.
Signed-off-by: Borislav Petkov [EMAIL
This BUG_ON is unneeded since the -handler != NULL check is performed in
ide_set_handler().
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-floppy.c |7 +++
1 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/ide/ide-floppy.c b/drivers/ide/ide
Hi Bart,
here's the second version of the ide-floppy refactoring trail. All the
patches are based on the version of your quilt tree from the 05.01. Also, you've
already applied patch 5 in this series but i'm submitting it still for the sake
of completeness.
drivers/ide/ide-cd.c |2
While at it, collapse idefloppy_analyze_error() into
idefloppy_request_sense_callback() since the latter was its only user.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-floppy.c | 82 +
1 files changed, 24 insertions(+), 58
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-floppy.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/ide/ide-floppy.c b/drivers/ide/ide-floppy.c
index c889c16..89b26ea 100644
--- a/drivers/ide/ide-floppy.c
+++ b/drivers/ide/ide
Also, move xfer_func_t typedef to the ide.h since it is used by two drivers
now (more coming).
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-cd.c |2 --
drivers/ide/ide-floppy.c | 37 ++---
include/linux/ide.h |3 +++
3
-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-floppy.c | 147 +++--
1 files changed, 75 insertions(+), 72 deletions(-)
diff --git a/drivers/ide/ide-floppy.c b/drivers/ide/ide-floppy.c
index 0729df5..3d9b1e5 100644
--- a/drivers/ide/ide
This change is temporary and after unification of the IDE subsystem proper
bit setting and testing macros will be introduced.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-floppy.c | 82 +-
1 files changed, 45 insertions(+), 37
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-floppy.c | 25 -
1 files changed, 4 insertions(+), 21 deletions(-)
diff --git a/drivers/ide/ide-floppy.c b/drivers/ide/ide-floppy.c
index 7d4ac0b..11c2c9b 100644
--- a/drivers/ide/ide-floppy.c
+++ b
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-floppy.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/ide/ide-floppy.c b/drivers/ide/ide-floppy.c
index 89b26ea..0729df5 100644
--- a/drivers/ide/ide-floppy.c
+++ b/drivers/ide/ide-floppy.c
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-floppy.c | 28 ++--
1 files changed, 14 insertions(+), 14 deletions(-)
diff --git a/drivers/ide/ide-floppy.c b/drivers/ide/ide-floppy.c
index e4ebb21..e63758a 100644
--- a/drivers/ide/ide-floppy.c
typedefs and teach
idefloppy_create_mode_sense_cmd() to work directly on u8 buffers.
Also, since idefloppy_get_capability_page() was used to read only the sfrp bit,
rename the latter so that the name reflects what it does.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-floppy.c
idefloppy_format_start to idefloppy_format_unit
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-floppy.c | 169 +
1 files changed, 79 insertions(+), 90 deletions(-)
diff --git a/drivers/ide/ide-floppy.c b/drivers/ide/ide-floppy.c
[...]
This is not an equivalent transformation:
header-wp is 0 or 1
pc.buffer[3] 0x80 is 0 or 0x80
It seems to work fine for -wp (because it is needlessly defined as 'int')
but may seriously confuse set_disk_ro() and thus bdev_read_only() users.
Should be fixed to '(pc.buffer[3]
On Sat, Jan 12, 2008 at 09:14:39PM +0100, Bartlomiej Zolnierkiewicz wrote:
[...]
PS1 Please rebase the patches still needing polishing on top of updated
IDE quilt tree, recast them and respin the patch series (no need to post
already merged patches).
sure, will do.
PS2 what happend to fix
On Sat, Jan 12, 2008 at 09:18:01PM +0100, Bartlomiej Zolnierkiewicz wrote:
On Friday 11 January 2008, Borislav Petkov wrote:
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-floppy.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-floppy.c | 90 ++---
1 files changed, 36 insertions(+), 54 deletions(-)
diff --git a/drivers/ide/ide-floppy.c b/drivers/ide/ide-floppy.c
index 7648684..06d83cb 100644
--- a/drivers/ide
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-floppy.c | 26 +++---
1 files changed, 3 insertions(+), 23 deletions(-)
diff --git a/drivers/ide/ide-floppy.c b/drivers/ide/ide-floppy.c
index 2b9885f..7648684 100644
--- a/drivers/ide/ide-floppy.c
+++ b
-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-floppy.c | 176 --
1 files changed, 76 insertions(+), 100 deletions(-)
diff --git a/drivers/ide/ide-floppy.c b/drivers/ide/ide-floppy.c
index 06d83cb..caeffb7 100644
--- a/drivers/ide/ide-floppy.c
+++ b
() to idefloppy_format_unit().
Finally, rename the reworked functions to ide_floppy..().
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-floppy.c | 153 +++--
1 files changed, 78 insertions(+), 75 deletions(-)
diff --git a/drivers/ide/ide-floppy.c b
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-floppy.c |8 +++-
1 files changed, 7 insertions(+), 1 deletions(-)
diff --git a/drivers/ide/ide-floppy.c b/drivers/ide/ide-floppy.c
index 00ea8d6..5004773 100644
--- a/drivers/ide/ide-floppy.c
+++ b/drivers/ide/ide
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-floppy.c |7 +--
1 files changed, 1 insertions(+), 6 deletions(-)
diff --git a/drivers/ide/ide-floppy.c b/drivers/ide/ide-floppy.c
index b826ac5..e7cc9dd 100644
--- a/drivers/ide/ide-floppy.c
+++ b/drivers/ide/ide
() to
ide_floppy_io_buffers().
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-floppy.c | 67 +
1 files changed, 20 insertions(+), 47 deletions(-)
diff --git a/drivers/ide/ide-floppy.c b/drivers/ide/ide-floppy.c
index e7cc9dd..6c917fc 100644
This info is already available through ioctl() and /proc
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-floppy.c | 63 +
1 files changed, 13 insertions(+), 50 deletions(-)
diff --git a/drivers/ide/ide-floppy.c b/drivers/ide/ide
This flag is not being set anywhere in the driver so it can go.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-floppy.c | 17 ++---
1 files changed, 6 insertions(+), 11 deletions(-)
diff --git a/drivers/ide/ide-floppy.c b/drivers/ide/ide-floppy.c
index
In addition to shortening the function name, move the printk-call into the
function thereby saving some code lines. Also, make the function out_of_line
since it is not on a performance critical path. Finally, rename the reworked
function to ide_floppy..().
Signed-off-by: Borislav Petkov [EMAIL
Hi Bart,
here are the remaining patches which had issues to be worked out. I decided
to keep the Flexible Disk Page and Capacity Descriptor in
idefloppy_floppy_t for the sake of the two printk calls for which they are
used. Otherwise, we'll be changing long-known driver behavior and this won't
be
..and replace them with flag enums.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-floppy.c | 132 +
1 files changed, 73 insertions(+), 59 deletions(-)
diff --git a/drivers/ide/ide-floppy.c b/drivers/ide/ide-floppy.c
index
on.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-floppy.c | 357 +-
1 files changed, 161 insertions(+), 196 deletions(-)
diff --git a/drivers/ide/ide-floppy.c b/drivers/ide/ide-floppy.c
index f9faf26..9361dfd 100644
On Mon, Jan 14, 2008 at 10:50:58PM +0100, Bartlomiej Zolnierkiewicz wrote:
On Sunday 13 January 2008, Borislav Petkov wrote:
..and replace them with flag enums.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-floppy.c | 132
On Mon, Jan 14, 2008 at 10:38:35PM +0100, Bartlomiej Zolnierkiewicz wrote:
On Sunday 13 January 2008, Borislav Petkov wrote:
We merge idefloppy_{input,output}_buffers() into idefloppy_io_buffers() by
introducing a 4th arg. called direction. According to its value
we atapi_input_bytes
This patches remove redundant DMA_..BIT_MASK definitions across two drivers.
First off, consolidate dma bitmask definitions in the proper header file...
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
--
Index: 23-rc6/include/linux/dma-mapping.h
move local #defines to the dma-mappings header.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
--
Index: 23-rc6/drivers/scsi/gdth.c
===
--- 23-rc6/drivers/scsi/gdth.c.orig 2007-09-17 17:53:26.0 +0200
+++ 23-rc6/drivers
Move dma bitmask definitions into the dma-mappings header.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
--
Index: 23-rc6/drivers/net/netxen/netxen_nic_main.c
===
--- 23-rc6/drivers/net/netxen/netxen_nic_main.c.orig2007-09-17
On Mon, Sep 17, 2007 at 11:14:48AM -0700, Jeremy Fitzhardinge wrote:
Borislav Petkov wrote:
This patches remove redundant DMA_..BIT_MASK definitions across two drivers.
First off, consolidate dma bitmask definitions in the proper header file...
Signed-off-by: Borislav Petkov [EMAIL
Move dma bitmask definitions into the dma-mappings header.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
Cc: Jeremy Fitzhardinge [EMAIL PROTECTED]
--
Index: 23-rc6/drivers/scsi/gdth.c
===
--- 23-rc6/drivers/scsi/gdth.c.orig
These patches remove redundant DMA_..BIT_MASK definitions across two drivers.
In this version of the patches, the computation of the bitmasks is done by
the compiler.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
Cc: Jeremy Fitzhardinge [EMAIL PROTECTED]
--
Index: 23-rc6/include/linux/dma
Move dma bitmask definitions into the dma-mappings header.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
Cc: Jeremy Fitzhardinge [EMAIL PROTECTED]
--
Index: 23-rc6/drivers/net/netxen/netxen_nic_main.c
===
--- 23-rc6/drivers/net
On Mon, Sep 17, 2007 at 02:42:28PM -0400, Mathieu Desnoyers wrote:
i386 optimization of the immediate values which uses a movl with code patching
to set/unset the value used to populate the register used as variable source.
Changelog:
- Use text_poke_early with cr0 WP save/restore to patch
On Mon, Sep 17, 2007 at 11:01:21PM -0700, Jeremy Fitzhardinge wrote:
Muli Ben-Yehuda wrote:
+#define DMA_64BIT_MASKDMA_BIT_MASK(64)
This one does not do what you mean. You need an explicit mask or a
~0ULL here.
Yeah, I was just about to comment on it. Its possible the
These patches remove redundant DMA_..BIT_MASK definitions across
two drivers. In this version of the patches, the computation
of the majority of the bitmasks is done by the compiler.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
Cc: Jeremy Fitzhardinge [EMAIL PROTECTED]
Cc: Muli Ben-Yehuda
Move dma bitmask definitions into the dma-mappings header.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
Cc: Jeremy Fitzhardinge [EMAIL PROTECTED]
Cc: Muli Ben-Yehuda [EMAIL PROTECTED]
---
23-rc6/drivers/net/netxen/netxen_nic_main.c |3 ---
1 file changed, 3 deletions(-)
Index: b/23-rc6
Move dma bitmask definitions into the dma-mappings header.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
Cc: Jeremy Fitzhardinge [EMAIL PROTECTED]
Cc: Muli Ben-Yehuda [EMAIL PROTECTED]
---
23-rc6/drivers/scsi/gdth.c |5 -
1 file changed, 5 deletions(-)
Index: b/23-rc6/drivers/scsi
On Tue, Sep 18, 2007 at 11:46:40AM +0530, Satyam Sharma wrote:
Hi Borislav,
On Tue, 18 Sep 2007, Borislav Petkov wrote:
On Mon, Sep 17, 2007 at 11:01:21PM -0700, Jeremy Fitzhardinge wrote:
Muli Ben-Yehuda wrote:
+#define DMA_64BIT_MASKDMA_BIT_MASK(64
this patch for it touches drivers maintained by
different people and there might be responsibility issues, imho.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
Cc: Jeremy Fitzhardinge [EMAIL PROTECTED]
Cc: Muli Ben-Yehuda [EMAIL PROTECTED]
drivers/net/netxen/netxen_nic_main.c |3 ---
drivers/scsi
this patch for it touches drivers maintained by
different people and i there might be responsibility issues, imho.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
Cc: Jeremy Fitzhardinge [EMAIL PROTECTED]
Cc: Muli Ben-Yehuda [EMAIL PROTECTED]
drivers/net/netxen/netxen_nic_main.c |3 ---
drivers
Hi Andrew,
since there's no iso9660 maintainer i send this one to you :).
---
From: Borislav Petkov [EMAIL PROTECTED]
shut up those:
fs/isofs/namei.c: In function 'isofs_lookup':
fs/isofs/namei.c:161: warning: 'offset' may be used uninitialized in this
function
fs/isofs/namei.c:161: warning
On Thu, Nov 15, 2007 at 09:49:22AM -0800, Lucy McCoy wrote:
Greg Boris,
I've been out of town and just saw this.
This patch will work with the 19HS but WILL BREAK all other Keyspan
adapters. It will take me a few days to get to looking at a correct fix but
that keyspan_send_setup(port, 1)
On Thu, Nov 15, 2007 at 01:10:16PM -0800, Lucy McCoy wrote:
Hi Lucy,
I'm not familiar with the termios stuff on Linux so can you take a look
at the following modified code to see if this solves your NULL ptr problem?
will test the patch tomorrow and get back to you with results.
Does cflag
On Fri, Nov 16, 2007 at 03:02:38PM -0500, Mathieu Desnoyers wrote:
Hi,
just a conventions proposal: have you thought of shortening all those
immediate_foo prefixes to 'imm_foo', for example? This'll make the
code much more readable, i think.
-
Regards/Gruß,
Boris.
-
To unsubscribe from
On Thu, Nov 15, 2007 at 01:10:16PM -0800, Lucy McCoy wrote:
static int keyspan_open (struct usb_serial_port *port, struct file *filp)
{
struct keyspan_port_private *p_priv;
struct keyspan_serial_private *s_priv;
struct usb_serial *serial = port-serial;
Being bitten by this several times myself here's a quick hack for checking the
patch
level of the diffs in a patch file. It works only when checkpatch.pl is called
from within the kernel tree.
---
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
--
scripts/checkpatch.pl | 18
---
From: Borislav Petkov [EMAIL PROTECTED]
Simplify logic in cdrom_release() without semantical change.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
--
drivers/cdrom/cdrom.c | 17 +
1 files changed, 9 insertions(+), 8 deletions(-)
diff --git a/drivers/cdrom/cdrom.c b
On Mon, Dec 17, 2007 at 08:11:05AM +0100, Borislav Petkov wrote:
A slightly microoptimized version 1.1:
---
From: Borislav Petkov [EMAIL PROTECTED]
Check the patch level of the single hunks in a patch file, however only when
checkpatch.pl is called from within the kernel tree.
Signed-off
On Thu, Dec 20, 2007 at 01:48:49AM +0100, Bartlomiej Zolnierkiewicz wrote:
Hi Bart,
Hi all,
PS ide-cd Maintainer position is still open...
i'd like to take that position if nobody objects. I've done some work around the
kernel here and there and i think its time for me to get serious.
Thanks.
On Fri, Dec 21, 2007 at 08:57:49PM +0100, Bartlomiej Zolnierkiewicz wrote:
On Thursday 20 December 2007, Borislav Petkov wrote:
On Thu, Dec 20, 2007 at 01:48:49AM +0100, Bartlomiej Zolnierkiewicz wrote:
Hi Bart,
Hi all,
PS ide-cd Maintainer position is still open...
i'd like to take
On Fri, Dec 21, 2007 at 06:12:02PM +, Andy Whitcroft wrote:
On Tue, Dec 18, 2007 at 06:46:41AM +0100, Borislav Petkov wrote:
On Mon, Dec 17, 2007 at 08:11:05AM +0100, Borislav Petkov wrote:
A slightly microoptimized version 1.1:
---
From: Borislav Petkov [EMAIL PROTECTED
On Mon, Nov 26, 2007 at 02:18:52PM -0800, Andrew Morton wrote:
On Sun, 18 Nov 2007 14:11:30 +0100
Borislav Petkov [EMAIL PROTECTED] wrote:
On Thu, Nov 15, 2007 at 01:10:16PM -0800, Lucy McCoy wrote:
...
yes, after testing this i can confirm that this one fixes the NULL ptr
problem here
On Fri, Nov 30, 2007 at 04:30:11PM +, Jaime Velasco Juan wrote:
Signed-off-by: Oliver Neukum [EMAIL PROTECTED]
Signed-off-by: Jaime Velasco Juan [EMAIL PROTECTED]
---
diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
index a18659e..352c94c 100644
---
On Fri, Nov 30, 2007 at 09:23:43AM -0800, Lucy McCoy wrote:
Hi All,
I've been too busy to get to this but i'd rather not use the code fragment
i sent Boris to try. It would be better to go ahead with the tty setup if
the pointer is not NULL, otherwise use the defaults and not reference the
On Sun, Dec 02, 2007 at 01:57:34PM +, Alan Cox wrote:
On Sun, 2 Dec 2007 09:03:40 +0100
Borislav Petkov [EMAIL PROTECTED] wrote:
On Fri, Nov 30, 2007 at 09:23:43AM -0800, Lucy McCoy wrote:
Hi All,
I've been too busy to get to this but i'd rather not use the code
fragment
Hi Pavel,
hi Rafael,
after a quick search i couldn't find anything dealing with the topic in the
subject line so here we go:
One sometimes can mix up (and by one i mean me) the
kernel images one boots after having suspended the machine previously. There can
be at least two reasons for that:
1.
On Thu, Dec 06, 2007 at 10:46:48PM +0100, Rafael J. Wysocki wrote:
On Thursday, 6 of December 2007, Borislav Petkov wrote:
Hi Pavel,
hi Rafael,
after a quick search i couldn't find anything dealing with the topic in the
subject line so here we go:
One sometimes can mix up
need a tester when you have some prototypes ready. By the
way,
what do you do when the suspend image header mismatches and it is unsafe to
continue booting?
Also, there's a freakishly long comment in suspend_64.c, might wanna shorten it:
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
diff --git
On Mon, Nov 19, 2007 at 10:31:39AM -0500, Mathieu Desnoyers wrote:
* Borislav Petkov ([EMAIL PROTECTED]) wrote:
On Fri, Nov 16, 2007 at 03:02:38PM -0500, Mathieu Desnoyers wrote:
Hi,
just a conventions proposal: have you thought of shortening all those
immediate_foo prefixes to 'imm_foo
From: Borislav Petkov [EMAIL PROTECTED]
Remove repeated comment from the linker script for the x86-32 target.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
--
arch/x86/kernel/vmlinux_32.lds.S |6 --
1 files changed, 0 insertions(+), 6 deletions(-)
diff --git a/arch/x86/kernel
On Sat, Dec 08, 2007 at 11:50:33PM +0100, Rafael J. Wysocki wrote:
On Saturday, 8 of December 2007, Borislav Petkov wrote:
On Fri, Dec 07, 2007 at 09:19:09PM +0100, Rafael J. Wysocki wrote:
...
Well, there's a patchset in the current mainline that allows you to
use
Hi Andrew,
Hi Len,
after booting 2.6.24-rc4-mm1 (2.6.24-rc4-190-g94545ba, otoh, boots just
fine) on my asus laptop, the machine reboots after claiming that
Critical temperature reached (255 C). However, the degrees number
is kinda hinting at 0xff all-ones field. Will try dump_stack in
On Sun, Dec 09, 2007 at 08:50:02AM +0100, Borislav Petkov wrote:
Hi Andrew,
Hi Len,
after booting 2.6.24-rc4-mm1 (2.6.24-rc4-190-g94545ba, otoh, boots just
fine) on my asus laptop, the machine reboots after claiming that
Critical temperature reached (255 C). However, the degrees number
On Sun, Dec 09, 2007 at 03:27:57PM +0100, Rafael J. Wysocki wrote:
...
Instead, I'd rather issue a warning that the swsusp header mismatches, say
with
which kernel the machine got suspended with and then start the countdown
for reboot.
What exactly would that change? You need to
On Sun, Dec 09, 2007 at 10:46:35PM +0100, Rafael J. Wysocki wrote:
On Sunday, 9 of December 2007, Borislav Petkov wrote:
On Sun, Dec 09, 2007 at 03:27:57PM +0100, Rafael J. Wysocki wrote:
...
Instead, I'd rather issue a warning that the swsusp header mismatches,
say with
which
On Sun, Dec 09, 2007 at 10:19:47AM +0100, Borislav Petkov wrote:
On Sun, Dec 09, 2007 at 08:50:02AM +0100, Borislav Petkov wrote:
Hi Andrew,
Hi Len,
after booting 2.6.24-rc4-mm1 (2.6.24-rc4-190-g94545ba, otoh, boots just
fine) on my asus laptop, the machine reboots after claiming
On Tue, Dec 11, 2007 at 01:00:24PM -0700, Bjorn Helgaas wrote:
On Tuesday 11 December 2007 10:44:43 am Borislav Petkov wrote:
On Sun, Dec 09, 2007 at 10:19:47AM +0100, Borislav Petkov wrote:
On Sun, Dec 09, 2007 at 08:50:02AM +0100, Borislav Petkov wrote:
Hi Andrew,
Hi Len
1 - 100 of 23602 matches
Mail list logo
