On Tue, Jul 30, 2013 at 06:42:58PM -0400, Dong Fang wrote:
On 07/29/2013 04:06 AM, Dan Carpenter wrote:
Oh. It appears that nothing changed between v1 and v2. Only the CC
list.
It's probably that the list moderation on ocfs2-devel was confusing
for non-native English speakers the patch
explain what oz_hcd_heartbeat() does.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org
The test here can underflow so we pass bogus lengths to the hardware.
It's a static checker fix and I don't know the impact.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/block/paride/pg.c b/drivers/block/paride/pg.c
index 4a27b1d..2ce3dfd 100644
--- a/drivers/block
I was just reading http://faultlinux.lip6.fr/ which says that in
2011 the static checker fault rate in arch/ and fs/ was worse than
in drivers/. I suspect that there are some security vulnerabilities
there.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux
On Thu, Aug 01, 2013 at 03:05:56PM -0400, Dave Jones wrote:
On Thu, Aug 01, 2013 at 12:13:22PM +0300, Dan Carpenter wrote:
I was just reading http://faultlinux.lip6.fr/ which says that in
2011 the static checker fault rate in arch/ and fs/ was worse than
in drivers/
I've been working
then it was missed when the sizeof(f-report) changed.
5) In [patch 6/6] we set the -len member. But because it is at the
end of a variable length array with no limit check the remote
attacker can just rewrite it using the memcpy() on the next line.
regards,
dan carpenter
--
To unsubscribe from
Hi Evan,
Are you sending html email or something? Your emails aren't showing
up on the de...@driverdev.osuosl.org list.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info
the potential dead lock.
Signed-off-by: Gu Zheng guz.f...@cn.fujitsu.com
Relax, Greg isn't taking new patches for another three weeks because the
merge window is open.
Also what happened to [PATCH 1/2]?
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux
returning directly instead
of having do-nothing gotos. Using descriptive labels instead of
GW-BASIC style err0 and err1. I also flipped the order of
put_device() and ida_remove() so they are a mirror reflection of the
order they were allocated.
Signed-off-by: Dan Carpenter dan.carpen
code was not just messy, it was also buggy. If you do the
error handling in the right way by unwinding in the correct order and
thinking about label names then your code will be less buggy.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body
There is a stray unlock here which was not intended. I have removed it.
Fixes: 3f9f3dfb5755 ('fat: add fat_fallocate operation')
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/fs/fat/file.c b/fs/fat/file.c
index 03f716f..befedee 100644
--- a/fs/fat/file.c
+++ b/fs/fat/file.c
There is a bug in cpsw_probe() where we do:
ndev-irq = platform_get_irq(pdev, 0);
if (ndev-irq 0) {
The problem is that ndev-irq is unsigned so the error handling
doesn't work. I have changed it to a regular int.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff
There is a bug in omap2_mbox_probe() where we try do:
mbox-irq = platform_get_irq(pdev, info-irq_id);
if (mbox-irq 0) {
The problem is that mbox-irq is unsigned so the error handling doesn't
work. I've changed it to a signed integer.
Signed-off-by: Dan
If pm2 were NULL we would oops printing the error message.
Fortunately, that's not possible so I have removed the NULL checks.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/power/pm2301_charger.c b/drivers/power/pm2301_charger.c
index b733c69..62c15af 100644
pnp_irq() returns -1 on error but cast to an unsigned. It is confusing
for callers who assume that it returns a negative value. I have
introduced a new define IORESOURCE_INVALID which is the same value but
hopefully it looks less like a negative value.
Signed-off-by: Dan Carpenter dan.carpen
On Wed, Nov 06, 2013 at 09:22:36AM +0800, Gu Zheng wrote:
Hi Dan,
On 11/05/2013 07:02 PM, Dan Carpenter wrote:
On Tue, Nov 05, 2013 at 06:01:00PM +0800, Gu Zheng wrote:
The lock sequence of dcon_blank_fb(fb_info-lock --- console_lock) is
against
with the one of console_callback
On Thu, Nov 07, 2013 at 05:44:38PM +0530, Mugunthan V N wrote:
On Thursday 07 November 2013 01:18 PM, Dan Carpenter wrote:
There is a bug in cpsw_probe() where we do:
ndev-irq = platform_get_irq(pdev, 0);
if (ndev-irq 0) {
The problem is that ndev-irq is unsigned so the error
On Thu, Nov 07, 2013 at 10:03:19PM +0530, Mugunthan V N wrote:
On Thursday 07 November 2013 05:52 PM, Dan Carpenter wrote:
On Thu, Nov 07, 2013 at 05:44:38PM +0530, Mugunthan V N wrote:
On Thursday 07 November 2013 01:18 PM, Dan Carpenter wrote:
There is a bug in cpsw_probe() where we do
On Tue, Oct 01, 2013 at 09:39:48PM -0400, Mathieu Rhéaume wrote:
Fixed a lot of warnings from checkpatch.pl about the 80 characters per line
limitation.
The code was better in the original, sorry. Also this doesn't apply to
linux-next from Friday.
regards,
dan carpenter
--
To unsubscribe
,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
by checkpatch.pl.
Checkpatch.pl is wrong here and this doesn't compile.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please
The code here is copying the version to inq.driver_version but we don't
want it to be NUL terminated. Instead we pad the rest of the array with
spaces. It's fewer lines to use memcpy() and maybe a little nicer.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
---
v2: use memcpy() instead
On Fri, Sep 13, 2013 at 02:03:23PM +0200, Geert Uytterhoeven wrote:
On Fri, Sep 13, 2013 at 10:05 AM, Dan Carpenter
+ strncpy(inq.driver_version, DRV_VER_COMPL,
+ min(sizeof(inq.driver_version), strlen(DRV_VER_COMPL)));
This does the exact same thing as memcpy(), right
:.
+ hv_kbd_free_device(kbd_dev);
+
+ return ret;
+}
+
+
Extra blank line.
+static int hv_kbd_remove(struct hv_device *dev)
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info
which function to look at.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Just roll something like the following into your patch.
regards,
dan carpenter
diff --git a/drivers/input/serio/hyperv-keyboard.c
b/drivers/input/serio/hyperv-keyboard.c
index 0d4625f..262721b 100644
--- a/drivers/input/serio/hyperv-keyboard.c
+++ b/drivers/input/serio/hyperv-keyboard.c
vmbus_recvpacket_raw() in
drivers/hv/channel.c.
I'm confused.
There is no mention of -offset8 in vmbus_recvpacket_raw().
It's a good idea to add a check there but the lower levels don't know
about the sizeof(synth_kbd_protocol_response) so we would still need
something like my check.
regards,
dan carpenter
On Mon, Sep 16, 2013 at 04:49:29PM -0400, Joseph Salisbury wrote:
On 09/16/2013 04:38 PM, Dan Carpenter wrote:
On Mon, Sep 16, 2013 at 01:42:35PM -0400, Joseph Salisbury wrote:
Reverting the patch changes the driver back to useing kzalloc() and
memcpy() instead of kmemdup. Doing so has
and will provide the results.
The two bugs are the same it's that the code has shifted a little. Mark
the commit as buggy and continue with the git bisect.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord
On Mon, Sep 16, 2013 at 09:55:44PM +, KY Srinivasan wrote:
-Original Message-
From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
Sent: Monday, September 16, 2013 1:13 PM
To: KY Srinivasan
Cc: o...@aepfle.de; gre...@linuxfoundation.org; jasow...@redhat.com; Dmitry
On Mon, Sep 16, 2013 at 05:53:57PM -0400, Mike Snitzer wrote:
- variable names need to be a bit more verbose (arr = array)
struct array is a horrible name. :P Please don't use either arr
or array.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux
with the diffstat.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
at the end of the line. That's the New Unwritten
Style Guidelines. Most of the kernel does it this way and it's easier
to read.
But this could be fixed in a later patch instead of redoing the whole
series.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux
sizeof() is already size_t so there is no need to cast here. Generally,
casting inside the min() macro instead of using min_t() is considered
bad style.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/pinctrl/pinconf.c b/drivers/pinctrl/pinconf.c
index a138965
Sure. There are a lot of non-const strings though.
diff --git a/include/linux/printk.h b/include/linux/printk.h
index e6131a78..317587b 100644
--- a/include/linux/printk.h
+++ b/include/linux/printk.h
@@ -122,6 +122,11 @@ asmlinkage int printk_emit(int facility, int level,
asmlinkage
On Wed, Sep 18, 2013 at 05:11:04PM +0300, Dan Carpenter wrote:
asmlinkage __printf(1, 2) __cold
int printk(const char *fmt, ...);
+#define printk(fmt, ...) do { \
+ compiletime_assert(__builtin_constant_p(fmt), \
+Non-constant
message?
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Ah, ok. I had no idea what you were talking about before. I thought
you were talking about build errors in a file that didn't exist...
(Because the subject says build and there was a typo in the file
name).
Navin, says you can remove it.
regards,
dan carpenter
--
To unsubscribe from this list
CC the linux-kernel list though because they don't care about details in
staging.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
://gitorious.org/thierryreding/linux-next.git until later this month.
Thierry Reding has taken over while Stephen is on vacation.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info
The test here can underflow so we pass bogus lengths to the hardware.
It's a static checker fix and I don't know the impact.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
---
I sent this originally Jul 31, 2013 but there was no response.
diff --git a/drivers/block/paride/pg.c b/drivers
don't need to check the
values before calling debugfs_remove() because that accepts ERR_PTRs and
NULL pointers.
We don't need to set pkt-dfs_f_info to NULL in pkt_debugfs_dev_new()
because it was initialized with kzalloc() so I have removed that.
Signed-off-by: Dan Carpenter dan.carpen
can do this. mutex_lock() always succeeds and
tty_write_lock() can fail.
I think we just have to live with the error message.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info
!test_bit(TTY_CLOSING, tty-flags)) {
tty_unlock(tty);
i am not an expert on this but you may need to replace that tty_unlock() with
tty_write_unlock().
No. The original code is correct.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe
success deliberately to make the netif layer happy */
return NETDEV_TX_OK;
In the original code the success path was if condition false, then if
condition true, then follow a goto then return. In the new code it is
straight line path to success with no nested if else statements.
regards,
dan
merging
and branches. Is it still better/suitable/possible to sync some bug fix
patches from staging brach to next brach?
next syncs with everyone once a day.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord
On some paths, there can be fewer than SKD_MAX_MSIX_COUNT (13) elements
in the skdev-msix_entries[] array so we would be going past the end of
the array.
Fixes: e67f86b31ae5 ('Add support for sTec's pci-e flash card Kronos')
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
---
Static checker
On Sat, Nov 30, 2013 at 08:19:32PM +0100, Pavel Machek wrote:
so perhaps Nico Golde or Dan Carpenter can elaborate? I Cc-ed them
now.
Or is it some kind of super-secret issue and still under embargo for
10 days?
Pavel
works.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
On Sun, Dec 01, 2013 at 05:43:08PM +0200, Aldo Iljazi wrote:
A few checkpatch cleanups, particularly:
Lines 83, 87, 89, 196: Removed spaces before tabs.
Lines 141, 265.267: Removed trailing whitespace.
Don't send two patches with the exact same subject.
regards,
dan carpenter
DLREQ_BIOS 0
We shouldn't have two blank lines in a row.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read
Looks good to me.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
I sent a patch to fix some bitwise AND tests but I guess I missed some.
Sorry about that.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/pinctrl/pinctrl-abx500.c b/drivers/pinctrl/pinctrl-abx500.c
index 4780959..5183e7bb 100644
--- a/drivers/pinctrl/pinctrl-abx500.c
There are 3 other uses before go gets initialized.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http
a Signed-off-by line and it has to match your email address
which you used to send the email.
Otherwise, the patch is good an fixes an important bug.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
We still need to apply this fix.
regards,
dan carpenter
On Fri, Aug 23, 2013 at 11:19:49AM +0300, Dan Carpenter wrote:
We fixed the call to request_mem_region() patch
3354f73 ('drivers/vlynq/vlynq.c: fix resource size off by 1 error').
But we need to fix the call the release_mem_region
On Mon, Nov 11, 2013 at 12:46:24PM +0100, Michal Nazarewicz wrote:
go variable is initialised only after the switch case so it cannot be
dereferenced prior to that happening.
Signed-off-by: Michal Nazarewicz min...@mina86.com
Looks good. Thanks. :)
regards,
dan carpenter
We accidentally applied two correct but duplicative fixes for a memory
leak here:
4b6271a64463 ('dma: edma: Fix memory leak')
2f6d8fad0a16 ('dma: edma.c: remove edma_desc leakage')
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/dma/edma.c b/drivers/dma/edma.c
index
alloc_anon_inode() returns an ERR_PTR(), it doesn't return NULL.
Fixes: 71ad7490c1f3 ('rework aio migrate pages to use aio fs')
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/fs/aio.c b/fs/aio.c
index bf8d080..699f53e 100644
--- a/fs/aio.c
+++ b/fs/aio.c
@@ -164,8 +164,8
On Fri, Nov 15, 2013 at 11:39:38AM +0100, Julien DELACOU wrote:
Pending interrupts clearing is done in dwc2_enable_common_interrupts
so we don't need to do it twice.
Are there any user visible effects to this bug? How did you spot it?
regards,
dan carpenter
--
To unsubscribe from
about. Care to give us a hint and what you want us to do
here?
I have also added Johan Hedberg to the CC list because he also helped
break the build. Don't do that.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord
is misleading because we don't get anything it only returns zero
on success?
phase_point might be helpful but I don't know what a phase_point is.
Add a comment about that maybe.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message
Signed-off-by is intended to have a legal meaning that you didn't steal
someone's code. You can't sign off for other people.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info
comments is more annoying than the space.
This seems like a small bug in checkpatch.pl. Joe, the problem is this
code:
for ( ; x; x++) {
It's complaining about the space character before the semicolon.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux
.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
, 0x1F00},
One of these is not like the others. You have introduced a bug with
0xF870 vs 0x0F000870.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
pdata is a NULL not an ERR_PTR so there is no use printing it.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/mfd/max14577.c b/drivers/mfd/max14577.c
index 1337c4527028..a5e1c370c609 100644
--- a/drivers/mfd/max14577.c
+++ b/drivers/mfd/max14577.c
@@ -96,8 +96,7
Thanks so much. :)
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
;
+ return;
Should be a break here. This function wasn't tested.
+ }
+ }
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
of staging, then remove all the extra
crap so it doesn't look like barf.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read
);
+ if (copy_to_user(*ptr, parcel, size))
+ return -EFAULT;
+ *ptr += size;
+ return 0;
+}
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
be 32 bits
on both arches.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
)
+#define align_helper(ptr)ALIGN(ptr, sizeof(void *))
+
This is a terrible name.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
file changed, 49 insertions(+), 49 deletions(-)
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http
)
return BP_NOT_CAP;
if (ret == 0)
return 1;
return 0;
More lines, but simpler to understand than the original.
Think of checkpatch.pl as a pointer to bad code and not that we just
have to silence checkpatch and move on.
regards,
dan carpenter
--
To unsubscribe from
On Thu, Dec 05, 2013 at 03:09:15PM -0800, Joe Perches wrote:
On Fri, 2013-12-06 at 01:50 +0300, Dan Carpenter wrote:
On Thu, Dec 05, 2013 at 10:23:53PM +0100, Will Tange wrote:
Fixes warnings regarding redundant parantheses thrown by the checkpatch
tool in bpctl_mod.c
[]
if (ret
On Thu, Dec 05, 2013 at 03:29:22PM -0800, Joe Perches wrote:
On Fri, 2013-12-06 at 02:21 +0300, Dan Carpenter wrote:
On Thu, Dec 05, 2013 at 03:09:15PM -0800, Joe Perches wrote:
On Fri, 2013-12-06 at 01:50 +0300, Dan Carpenter wrote:
On Thu, Dec 05, 2013 at 10:23:53PM +0100, Will Tange
It's too early to start resending. Wait for another week at least.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read
Leave a blank line between the subject and the body of the changelog.
The signed-off-by line is missing.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
I see one in a commit
message I assume it is wrong. Add some more explanation to say why you
removed the spin_unlock.
Also redundant means unnecessary but sort of implies that it is
harmless. Say something like: staging: ced401: fix double unlock bug.
regards,
dan carpenter
--
To unsubscribe
Subject is still messed up. Send the email to yourself first and then
to the list until you figure it out. (hint add a blank line).
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More
parameter does.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
sparse says:
drivers/staging/ced1401/usb1401.c:1080:28: warning:
context imbalance in 'Handle1401Esc' - unexpected unlock
Thank you.
Reviewed-by: Dan Carpenter dan.carpen...@oracle.com
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel
ACPI_RESOURCE_TYPE_ADDRESS64:
+ hyperv_mmio_start = res-data.address64.minimum;
+ hyperv_mmio_size = res-data.address64.address_length;
}
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord
I'm sorry, I know it sucks to not get credit for fixes, but please just
fold this into [patch 1/5]. We really should have a tag for this kind
of thing.
Would something like this work?
Additional-Fixes: Gerd Hoffmann kra...@redhat.com
regards,
dan carpenter
--
To unsubscribe from this list
On Mon, Feb 24, 2014 at 11:55:43AM +0100, Gerd Hoffmann wrote:
On Mo, 2014-02-24 at 13:42 +0300, Dan Carpenter wrote:
I'm sorry, I know it sucks to not get credit for fixes, but please just
fold this into [patch 1/5]. We really should have a tag for this kind
of thing.
It's not because
on this in
the past. :P
Anyway, it should be that the operator goes on the first line like Ian
says...
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
in a separate patch.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
On Mon, Feb 10, 2014 at 01:59:56PM -0800, Joe Perches wrote:
On Mon, 2014-02-10 at 23:24 +0300, Dan Carpenter wrote:
On Mon, Feb 10, 2014 at 09:19:46AM -0800, Joe Perches wrote:
On Mon, 2014-02-10 at 12:27 +0300, Dan Carpenter wrote:
We do not want to encourage a million
first patch
)
}
void
-kiblnd_destroy_peer (kib_peer_t *peer)
+kiblnd_destroy_peer(kib_peer_t *peer)
{
This is a random unrelated white space change, so do it in a separate
patch.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message
,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
= (buff_in == buff_out);
+ return buff_comparison;
This isn't simpler than the original code.
Just do:
int synth_buffer_empty(void)
{
return buff_in == buff_out;
}
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message
On Fri, Feb 28, 2014 at 04:12:22PM +0900, Daeseok Youn wrote:
clean up checkpatch.pl warnings:
WARNING: Line length over 80 characters
Patch is white space dammaged and doesn't apply.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel
);
}
Then the caller becomes:
outl_1564_timer(devpriv, cmd, APCI1564_TCW_PROG);
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
On Fri, Feb 28, 2014 at 10:52:32AM +0300, Dan Carpenter wrote:
On Fri, Feb 28, 2014 at 01:31:20AM -0600, Chase Southwood wrote:
hwdrv_apci1564.c had numerous lines over the column limit. This patch
splits all such lines to bring them in compliance with coding style.
Signed-off-by: Chase
.
Anyway, take some more time with this and play with different ways to
clean it up.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
,
+ DSP_EXCEPTIONABORT);
Do it like this:
bridge_deh_notify(hdeh_mgr, DSP_SYSERROR,
DSP_EXCEPTIONABORT);
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord
On Sat, Mar 01, 2014 at 12:41:55AM -0800, Masood Mehmood wrote:
- Adjusted pointer's '*' declaration to the data_type.
- Added space after 'if' keyword
Signed-off-by: Masood Mehmood ody.g...@gmail.com
Looks good.
Reviewed-by: Dan Carpenter dan.carpen...@oracle.com
regards,
dan carpenter
at was used.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
On Sat, Mar 01, 2014 at 04:28:27AM -0600, Chase Southwood wrote:
This patch introduces a handful of outl and inl helper functions with the
ultimate goal of improving code readability and allowing several lines
which violate the character limit to be shortened in a sane way.
Cc: Dan Carpenter
501 - 600 of 9292 matches
Mail list logo
