something about those trivial cases?
Do you have more examples of ambiguous returns, so I can help you hunt them?
The main thing is what your check finds. If you know that ret is zero
then return zero.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux
On Sat, May 17, 2014 at 11:35:55PM +0100, Russell King - ARM Linux wrote:
On Sun, May 18, 2014 at 01:08:36AM +0300, Dan Carpenter wrote:
Let's look at that error handling again.
err: -- the name is not descriptive. the location is bad.
kfree(pdev-dev.dma_mask); - null
it there for future work but really it's not
hard to add it back if it's needed.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please
Sorry, I should have noticed this before, but the subject doesn't match
the patch any more.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
()
error: we previously assumed 'ak-adc_info' could be null (see line 789)
And 75 of these:
fs/efs/inode.c:298 efs_map_block()
warn: variable dereferenced before check 'bh' (see line 292)
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux
characters
All five of these do the same thing. It should just be one patch.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please
This one does feel like a bug in the original code as you mention. I
have added the TI devs to the CC list so they can help us.
regards,
dan carpenter
On Mon, May 19, 2014 at 06:31:05AM +0200, Julia Lawall wrote:
From: Julia Lawall julia.law...@lip6.fr
Delete unnecessary local variable
);
+
+ return rc;
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
board_t *brd)
{
int rc = 0;
Oh, and you may as well remove this initialization while you are at it.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
Was there really a v1 version of this patchset because I don't see it in
my inbox?
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
:
skein_assert(foo++ == bar);
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This patch is great, thanks, don't resend. But I wish the subject said
fix instead of rewrite. I was expecting it to just be a cleanup.
It helps a lot if `git log --oneline` says which patches should be
backported.
regards,
dan carpenter
--
To unsubscribe from this list: send the line
On Sat, May 17, 2014 at 09:00:04PM -0700, David Matlack wrote:
Remove uninitialized struct that is only used to regulate whether
incorrect eeprom checksums are ignored.
Looking at the patch, this looks like a bugfix but the changelog doesn't
give any clues.
regards,
dan carpenter
code. I try to allow lots of patches in
and let people send fix up patches for minor stuff. But, obviously, you
should be running Sparse as part of the review process so if I made you
redo this patch it's because your process is broken. When I review
patches I am trying to help you.
regards,
dan
Awesome. Thanks.
Reviewed-by: Dan Carpenter dan.carpen...@oracle.com
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please
for that. You can leave
linux-kernel off if you want because they don't care about staging
drivers. The staging list is de...@driverdev.osuosl.org.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
val);
216 return _FAIL;
217 }
You have changed it to return _FAIL instead of true. Perhaps that is ok
but you need to explain it in the changelog.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux
. this applies to next-20140516.
A week is too short a time. You will always get a message that your
patch was either applied or dropped.
greetings from Linuxdays Vienna, Austria
Hi hi. Greetings from Africa. :)
regards,
dan carpenter
--
To unsubscribe from this list: send the line
a second version of the patch.
You should be running Sparse yourself as part of your own QC tests
before submitting patches to review. http://lwn.net/Articles/205624/
It is a normal minimum requirement along with checkpatch.pl.
regards,
dan carpenter
--
To unsubscribe from this list: send the line
Terrific, thanks. :)
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
because I have verified it. Resend it however you
want and I will Ack it. No worries. I hope the long explanation is
helpfull and thanks for doing this cleanup work.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord
with them.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
On Mon, May 19, 2014 at 08:57:49AM -0700, David Matlack wrote:
On Mon, May 19, 2014 at 2:21 AM, Dan Carpenter dan.carpen...@oracle.com
wrote:
Looking at the patch, this looks like a bugfix but the changelog doesn't
give any clues.
Yeah this isn't a bug fix.
The only member of struct
On Mon, May 19, 2014 at 01:44:18PM -0600, Jake Edge wrote:
Not sure it's useful (or even the right way to go about it), but, if it
is, Greg (or Jason or whoever) can add my:
Reviewed-by: Jake Edge j...@lwn.net
Yep. Great. Greg will add it.
regards,
dan carpenter
--
To unsubscribe from
to help adjust the behavior of our
IO service partitions for better performance.
That sounds like it really belongs in sysfs instead of debugfs.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
so long as it makes the code easier to read. Don't
lose track of the real goal.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
bit systems
we truncate the upper 32 bits away so that could succeed. I haven't
followed it further than that.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/kernel/module.c b/kernel/module.c
index 626d164..26e0d15 100644
--- a/kernel/module.c
+++ b/kernel/module.c
@@ -2536,7
Sounds great.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
and also reported here:
https://lkml.org/lkml/2014/5/2/388
Unless there is a good reason to keep the commit, I'd say let's just revert
it.
Yes. Let's revert it.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord
On Thu, May 29, 2014 at 09:17:09AM +0900, DaeSeok Youn wrote:
Hi, Dan.
2014-05-28 19:11 GMT+09:00 Dan Carpenter dan.carpen...@oracle.com:
On Wed, May 28, 2014 at 06:29:38PM +0900, DaeSeok Youn wrote:
In your patch it has:
+ dgap_tty_uninit(brd, false);
But it should only
-by: Dan Carpenter dan.carpen...@oracle.com
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http
/differential input mode for the AI subdevice. We needed to
clear the FIFO of data before the conversion to handle card mode
switching glitches.
[ I made some style changes. - Ian ]
If the first line of the email is From: then git assigns authorship
credit automatically.
regards,
dan carpenter
support code.
+
+ If in doubt, say N here.
+
Actually, you're probably going to need to add a bunch of dependencies
here or it will break make randconfig right away. Sorry that I forgot
about this in the first review.
regards,
dan carpenter
--
To unsubscribe from this list: send the line
to catch up before you resend.
The latest couple versions of the patches have been ok, btw.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
I have reviewed this patchset.
Reviewed-by: Dan Carpenter dan.carpen...@oracle.com
Btw, I wish you would fold some of these patches together next time.
For example, patches 3-6 are very closely related and they should have
just been one thing.
Or the times where the change log says, I am going
When you do a v2 patchset, put a v2 in the subject and say which things
changed since v1. https://www.google.com/search?q=how+to+send+a+v2+patch
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
On Fri, May 30, 2014 at 11:20:05AM -0700, Thomas Wood wrote:
When using scripts/checkpatch.pl, there are errors about trailing whitespace.
Use scripts/cleanfile to remove these errors.
Someone already fixed these. Work against linux-next.
regards,
dan carpenter
--
To unsubscribe from
This changelog doesn't match the patch.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http
if
statement's conditionals together. Then it removes a
redundant else clause.
Thanks for pointing this out, but the else statement wasn't redundant.
Your change introduces a bug.
Your patch doesn't apply. You need to work against linux-next.
regards,
dan carpenter
--
To unsubscribe from this list: send
On Sat, May 31, 2014 at 10:01:39AM +0200, Yann Droneaud wrote:
Hi Dan,
Le vendredi 30 mai 2014 à 23:10 +0300, Dan Carpenter a écrit :
This changelog doesn't match the patch.
Hum, let me guess I've failed to set the proper subject prefix
to add v6 suffic to PATCH:
I've changed
;
- return offset;
+ return 0;
}
The original code looks buggy. I wonder what it was supposed to do?
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
for another patch.
IRDA_ERROR(via-ircc: dongle probing not supported, please specify
dongle_id module parameter.\n);
- return dongle_id;
+ return 9;
So put the comment here.
return 9; /* Everything is an IBM */
}
regards,
dan carpenter
--
To unsubscribe from this list
or not */
329 if (!dongle_id)
330 dongle_id = via_ircc_read_dongle_id(self-io.fir_base);
331 self-io.dongle_id = dongle_id;
If you don't use a module id then it acts like an IBM dongle by default.
regards,
dan carpenter
--
To unsubscribe from this list: send
used
anywhere. What is the exact cppcheck warning message?
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ
the process.
Also don't try to fix this now by resending again without the first two
patches. That just creates more confusion.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info
that :-(
But I'll make a patch that completely removes testing variable then instead?
Yes. Btw, what do the cppcheck error messages for this look like
anyway?
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord
should just be i.
TODO-list: 2014-06-02: dgap: get rid of brd-first minor because it is 0
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
On Mon, Jun 02, 2014 at 02:14:47PM +0900, Daeseok Youn wrote:
Adds a label for kfree(brd). And also remove
a state value as BOARD_FAILED in brd when dgap_do_remap() is failed.
Because brd will free after failure.
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com
Reviewed-by: Dan Carpenter
On Sun, Jun 01, 2014 at 10:00:16AM +0200, Yann Droneaud wrote:
Hi Dan,
Le samedi 31 mai 2014 à 15:05 +0300, Dan Carpenter a écrit :
On Sat, May 31, 2014 at 10:01:39AM +0200, Yann Droneaud wrote:
Le vendredi 30 mai 2014 à 23:10 +0300, Dan Carpenter a écrit :
This changelog doesn't
. It gets allocated a
couple lines later.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http
These all look great. Thanks. :)
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org
...@spectrumdigital.se
Someone already sent this one. You should be working against
linux-next.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
[ I am writing this at the end after writing the rest of this email.
After looking at the CP_TO_USR() macro more carefully, I realize that
the uninitialized variable bugs you are fixing are false positives.
The information leaks where the max size is not capped are real
security bugs.
On Mon, Jun 02, 2014 at 06:35:15PM +0900, DaeSeok Youn wrote:
Hi, Dan.
2014-06-02 16:30 GMT+09:00 Dan Carpenter dan.carpen...@oracle.com:
On Mon, Jun 02, 2014 at 02:03:58PM +0900, Daeseok Youn wrote:
The dgap_probe1() function is just calling dgap_found_board().
So it is removed
[patch 2] fix braces style
[patch 3] remove parens from return values
[patch 4] reverse an if statement
patch 3 and 4 are small enough that you could get away with pushing them
into a single misc fixes patch and we wouldn't have complained but the
first two patches are very big.
regards,
dan
On Fri, May 23, 2014 at 02:39:43PM -0700, Chaitanya Hazarey wrote:
Added a blank line after declarations to fix the following warnings issued by
checkpatch.pl:
drivers/staging/silicom/bypasslib/bypass.c:138: WARNING: Missing a blank line
after declarations
Yep. That applies now.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
On Sat, May 24, 2014 at 10:44:12PM -0700, Chaitanya Hazarey wrote:
Fixed a lot of errors of the type ERROR: space required after that ','
(ctx:VxV)
Add a tab at the start of the line as well.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel
Since you're redoing this one anyway, please use a more specific subject
like:
[PATCH] Staging: Silicom: bpctl_mod.c bypass.c: add blank lines
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
On Sun, May 25, 2014 at 09:15:06AM -0700, Chaitanya Hazarey wrote:
Fixed a lot of errors of the type ERROR: space required after that ','
(ctx:VxV)
Added tabs at the beginning of line.
Signed-off-by: Chaitanya Hazarey c...@24.io
---
Great. :) Thanks.
regards,
dan carpenter
);
return info;
}
kfree(info);
Wait. How does this code work without that INIT_LIST_HEAD()? What am
I missing here...
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo
);
+ dgap_cleanup_board(brd);
+ return ret;
Wow. This is nasty. We shouldn't have to call dgap_tty_uninit() when
the init failed. Can't we clean this up instead of adding
brd-nasync = 0; work arounds?
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body
platform_object {
struct platform_device pdev;
char name[1];
+ u64 dma_mask;
};
Heh. No this doesn't work as patch #1. You have to have name at the
end of the struct.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body
On Tue, May 27, 2014 at 09:58:18AM +0900, Heesub Shin wrote:
Hello Carpenter,
On 05/26/2014 07:36 PM, Dan Carpenter wrote:
On Mon, May 26, 2014 at 07:04:53PM +0900, Heesub Shin wrote:
@@ -124,7 +122,6 @@ static struct page_info *alloc_largest_available(struct
ion_system_heap *heap
;
Actually, for these I would introduce an int chan variable just for
that loop instead of i which we re-use.
So then we remove the call to dgap_tty_uninit() from
dgap_firmware_load().
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body
: reformat long lines
...
Etc.
Sorry for asking people to redo these again...
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
and the compile
wouldn't break so I have to go into the code and look at it.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read
This one as well would have been easier to review if you folded patches
7-10 together.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
,
+ unsigned long size,
+ unsigned int max_order)
Was this whitespace-only change intentional?
Yes. It's correct.
Heesub changed page_info to page and that forced a re-alignment of
the parameters.
regards,
dan carpenter
that you need to resend
anyway with a fixed subject line).
regards,
dan carpenter
ul_Command1 = inl(dev-iobase +
APCI3501_TIMER_CTRL_REG);
ul_Command1 = ul_Command1 0xF9FEUL;
outl(0x0, dev-iobase + APCI3501_TIMER_CTRL_REG
Great. Thanks.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
.
To be honest, I think once dgap the code is cleaned up this error
handling will be easy to write. We shouldn't have things like:
brd-dgap_major_serial_registered = TRUE; because we will know which
order things were registered and unregister them in the reverse order.
regards,
dan carpenter
emails. So I'm adding
this stuff to the todo list.
TODO-list: 2014-05-28: dgap: cleanups and bug fixes.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
, huh? :)
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
There was a typo here so we return directly instead of freeing hwinfo.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/sound/firewire/fireworks/fireworks.c
b/sound/firewire/fireworks/fireworks.c
index 8e856cc..996fdc4 100644
--- a/sound/firewire/fireworks/fireworks.c
+++ b
We know that err is zero from the line before. No need to check
again.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/misc/mei/hw-me.c b/drivers/misc/mei/hw-me.c
index 6a2d272..86694093 100644
--- a/drivers/misc/mei/hw-me.c
+++ b/drivers/misc/mei/hw-me.c
@@ -274,8
These days most people use git to send patches so I have added a section
about that.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
---
v2: fix typo in commit message
v3: update git am and log commands. Mention the man pages.
diff --git a/Documentation/email-clients.txt b/Documentation
statement deleted by
mistake?
Cheers,
--
Luís
Good eye. I have created a Smatch check to look for these bugs.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
On Mon, May 12, 2014 at 02:33:23AM +0200, Willy Tarreau wrote:
2.6.32-longterm review patch. If anyone has any objections, please let me
know.
--
From: Dan Carpenter dan.carpen...@oracle.com
[ Upstream commit db31c55a6fb245fdbb752a2ca4aefec89afabb06 ]
If kmsg
Subject: [PATCH] Fix missing a blank line after declaration for usbip
Subject should have a subsystem prefix.
[PATCH] Staging: usbip: missing a blank lines after declarations
There is no Signed-off-by line.
Put the stuff from the email into the changelog.
regards,
dan carpenter
--
To unsubscribe
On Sat, May 10, 2014 at 09:53:18PM +0530, Raghavendra Ganiga wrote:
This is a patch to remove warnings
reported by checkpatch tool on
comedi_test.c file
Same complaints as before.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body
On Sat, May 10, 2014 at 09:16:29PM +0530, Raghavendra Ganiga wrote:
This is a patch to fix
the warnings shown
by checkpatch tool on file
cb_das16_cs.c file
Emails should be line wrapped at 72 characters. 30 is too small.
Subject prefix should be: [patch] Staging: comedi: ...
regards,
dan
This one is better. Just fix the subject and it will be ok.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read
{
/* everything's ok, change the addr in netdev */
This is fine, but in the future, just go over the 80 character limit
instead of doing the unusual line break.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
We changed this from blk_alloc_queue_node() to blk_mq_init_queue() so
the check needs to be updated as well.
Fixes: ee5036035df1 ('mtip32xx: convert to use blk-mq')
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/block/mtip32xx/mtip32xx.c
b/drivers/block/mtip32xx
devm_ioremap() returns a NULL on error so the IS_ERR() check needs to be
updated.
Fixes: 6b99c68ec1f9 ('usb: phy: msm: Migrate to Managed Device Resource
allocation')
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy-msm-usb.c
The if condition here was supposed to return on error but the return
statement is missing. The effect is that the -mixername is set to
??? instead of DT019X.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/sound/isa/sb/sb_mixer.c b/sound/isa/sb/sb_mixer.c
index 6496822
On Wed, May 14, 2014 at 05:24:52PM +0400, Sergei Shtylyov wrote:
Hello.
On 14-05-2014 16:55, Dan Carpenter wrote:
devm_ioremap() returns a NULL on error so the IS_ERR() check needs to be
updated.
Fixes: 6b99c68ec1f9 ('usb: phy: msm: Migrate to Managed Device Resource
allocation
You should be working against linux-next. Also Mark Hounschell has sent
a fix for this already but it hasn't been applied yet. The subject
should have Staging in it.
[PATCH] Staging: dgap: addd __iomem annotations.
Otherwise looks ok.
regards,
dan carpenter
--
To unsubscribe from this list
On Wed, May 14, 2014 at 07:20:27PM +0200, Pawel Lebioda wrote:
Fix Missing a blank line after declaration style problems
for all files in drivers/staging/usbip.
Signed-off-by: Pawel Lebioda pawel.lebiod...@gmail.com
Great. Thanks.
regards,
dan carpenter
--
To unsubscribe from this list
;
}
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
On Fri, Jun 13, 2014 at 12:52:25PM -0700, Joe Perches wrote:
On Fri, 2014-06-13 at 12:46 +0300, Dan Carpenter wrote:
On Fri, Jun 13, 2014 at 02:30:22AM -0700, Joe Perches wrote:
+# check for missing a space in a string concatination
+if ($prevrawline =~ /[^\\][a-zA-Z
() takes a (void *) as user data, dereferenced and assigend to
u32.
applies to next-20140611
It doesn't dereference the pointer. You are getting mixed up with the
vt6656 version of ethtool_ioctl() I think? You're not allowed to
dereference __user pointers.
regards,
dan carpenter
On Fri, Jun 13, 2014 at 12:23:43PM +0200, Martin Kepplinger wrote:
Remove a totally unnecessary typedef. This is more readable now.
Choose a lower case name for the struct, otherwise we have to change all
these again in a while.
regards,
dan carpenter
--
To unsubscribe from this list: send
Wrong description, doesn't apply, and breaks the build.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ
);
mcaddr-next = adapter-mcastaddrs;
adapter-mcastaddrs = mcaddr;
Are you sure this is correct? It's not always a one-to-one replacement
from what I have been told.
I hate this checkpatch.pl warning because it just encourages people to
add bugs.
regards,
dan carpenter
--
To unsubscribe from
drivers/staging/ced1401/ced_ioc.c:703:30:got char [noderef]
asn:1*puBuf
Signed-off-by: Seunghun Lee way...@gmail.com
No. This silences the warning by disabling Sparse.
Fix the annotations instead.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe
along the lines of:
@@
expression E1, E2;
@@
LIBCFS_ALLOC (E1,E2);
...
- memset(E1,0,E2);
Signed-off-by: Vitaly Osipov vitaly.osi...@gmail.com
Reviewed-by: Dan Carpenter dan.carpen...@oracle.com
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux
analysis program called cppcheck.
We don't need a cover letter for a single patch. Just put this stuff in
the patch description next time.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More
901 - 1000 of 9292 matches
Mail list logo
