[PATCH v3] ARM: add get_user() support for 8 byte types

2014-06-12 Thread Daniel Thompson
: fix a couple of checkpatch issues Signed-off-by: Rob Clark robdcl...@gmail.com Signed-off-by: Daniel Thompson daniel.thomp...@linaro.org Cc: Russell King - ARM Linux li...@arm.linux.org.uk --- Notes: I'd like to wake this patch up again. It was rejected back in 2012 on the grounds

Re: [PATCH 1/4] serial: core: Consistent LF handling for poll_put_char

2014-05-15 Thread Daniel Thompson
On 14/05/14 16:08, Jason Wessel wrote: On 05/14/2014 09:55 AM, Daniel Thompson wrote: The behaviour of the UART poll_put_char infrastructure is inconsistent with respect to linefeed conversions. This in turn leads to difficulty using kdb on serial ports that are not also consoles (e.g

[PATCH tty-next v2 4/4] serial: kgdb_nmi: Improve console integration with KDB I/O

2014-05-29 Thread Daniel Thompson
does. Signed-off-by: Daniel Thompson daniel.thomp...@linaro.org --- drivers/tty/serial/kgdb_nmi.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/drivers/tty/serial/kgdb_nmi.c b/drivers/tty/serial/kgdb_nmi.c index 20d21d0..cfadf29 100644 --- a/drivers/tty

[PATCH tty-next v2 2/4] serial: kgdb_nmi: Use container_of() to locate private data

2014-05-29 Thread Daniel Thompson
-by: Daniel Thompson daniel.thomp...@linaro.org --- drivers/tty/serial/kgdb_nmi.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/tty/serial/kgdb_nmi.c b/drivers/tty/serial/kgdb_nmi.c index 5f673b7..d51b2a1 100644 --- a/drivers/tty/serial/kgdb_nmi.c +++ b/drivers

[PATCH tty-next v2 0/4] serial: kgdb_nmi: Allow ttyNMIX to act as primary console

2014-05-29 Thread Daniel Thompson
on any other part of the kernel. The series has been runtime tested on ARM and compile tested on x86 and powerpc. Changes since v1: - Trimmed down the first patch to the remaining fragments as described above. - Rebased on tty-next as requested by Greg KH. Daniel Thompson (4): serial: cpm_uart

[PATCH tty-next v2 3/4] serial: kgdb_nmi: Switch from tasklets to real timers

2014-05-29 Thread Daniel Thompson
kgdb_nmi uses tasklets on the assumption they will not be scheduled until the next timer tick. This assumption is invalid and can lead to live lock, continually servicing the kgdb_nmi tasklet. This is fixed by using the timer API instead. Signed-off-by: Daniel Thompson daniel.thomp...@linaro.org

[PATCH tty-next v2 1/4] serial: cpm_uart: No LF conversion in put_poll_char()

2014-05-29 Thread Daniel Thompson
than simply rip out the conversion code. Signed-off-by: Daniel Thompson daniel.thomp...@linaro.org Cc: Doug Anderson diand...@chromium.org Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Cc: Jiri Slaby jsl...@suse.cz Cc: Christophe Leroy christophe.le...@c-s.fr Cc: linux-ser...@vger.kernel.org

[PATCH v6] serial: sirf: Fix compilation failure

2014-05-29 Thread Daniel Thompson
gre...@linuxfoundation.org Cc: Jiri Slaby jsl...@suse.cz Cc: Barry Song bao...@kernel.org Cc: Qipan Li qipan...@csr.com Cc: linux-ser...@vger.kernel.org Signed-off-by: Daniel Thompson daniel.thomp...@linaro.org --- drivers/tty/serial/sirfsoc_uart.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH tty-next] serial: sirf: Fix compilation failure

2014-05-29 Thread Daniel Thompson
gre...@linuxfoundation.org Cc: Jiri Slaby jsl...@suse.cz Cc: Barry Song bao...@kernel.org Cc: Qipan Li qipan...@csr.com Cc: linux-ser...@vger.kernel.org Signed-off-by: Daniel Thompson daniel.thomp...@linaro.org --- Notes: Sorry to resend within a few minutes. Patch is identical to parent

Re: [PATCH] tty: serial: msm_serial.c: Cleaning up uninitialized variables

2014-06-02 Thread Daniel Thompson
On 01/06/14 14:38, Rickard Strandqvist wrote: There is a risk that the variable will be used without being initialized. This was largely found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se ---

[RESEND PATCH] drm: Add 800x600 (SVGA) screen resolution to the built-in EDIDs

2014-05-23 Thread Daniel Thompson
the existing users of the established timing bits forcing a rework of the ESTABLISHED_TIMINGS_BITS macro. Tested new EDID on an aged (and misbehaving) industrial LCD panel; existing EDIDs still pass edid-decode's checksum checks. Signed-off-by: Daniel Thompson daniel.thomp...@linaro.org Cc: Randy Dunlap

[RESEND PATCH v5 1/5] ARM: versatile: Enable DEBUG_LL_UART_PL01X

2014-05-23 Thread Daniel Thompson
This defconfig already enables DEBUG_LL and by default DEBUG_LL_UART_NONE will be selected (but due to some back compability magic I'd like to remove is not actually honoured). DEBUG_LL_UART_PL01X is a much saner default. Signed-off-by: Daniel Thompson daniel.thomp...@linaro.org --- arch/arm

[RESEND PATCH v5 3/5] ARM: Conceal DEBUG_LL_UART_NONE from unsupported platforms

2014-05-23 Thread Daniel Thompson
it. Signed-off-by: Daniel Thompson daniel.thomp...@linaro.org --- arch/arm/Kconfig.debug | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug index eab8ecb..4c8d7db 100644 --- a/arch/arm/Kconfig.debug +++ b/arch/arm

[RESEND PATCH v5 2/5] ARM: ep93xx: Enable DEBUG_LL_UART_PL01X

2014-05-23 Thread Daniel Thompson
This defconfig already enables DEBUG_LL and by default DEBUG_LL_UART_NONE will be selected (but due to some back compability magic I'd like to remove is not actually honoured). DEBUG_LL_UART_PL01X is a much saner default. Signed-off-by: Daniel Thompson daniel.thomp...@linaro.org --- arch/arm

[RESEND PATCH v5 5/5] arm: Fix DEBUG_LL for multi-platform kernels (without PL01X)

2014-05-23 Thread Daniel Thompson
the DEBUG_LL backend will be overriden. Problem is fixed by removing the automatic enabling of this option. Signed-off-by: Daniel Thompson daniel.thomp...@linaro.org --- arch/arm/Kconfig.debug | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/arch/arm/Kconfig.debug b/arch/arm

[RESEND PATCH v5 4/5] arm: Seperate DEBUG_UART_PHYS from DEBUG_LL on EP93XX

2014-05-23 Thread Daniel Thompson
On EP93XX uncompress.h uses CONFIG_DEBUG_UART_PHYS instead of a hard coded serial port. This means the build breaks when DEBUG_LL (and DEBUG_LL_UART_PL01X) is not enabled. This is fixed by adding a new dependancy. Signed-off-by: Daniel Thompson daniel.thomp...@linaro.org --- arch/arm

[RESEND PATCH v5 0/5] arm: Fix DEBUG_LL for multi-platform kernels (without PL01X)

2014-05-23 Thread Daniel Thompson
: * Remove pointless single platform support (thanks Arnd Bergmann) Daniel Thompson (5): ARM: versatile: Enable DEBUG_LL_UART_PL01X ARM: ep93xx: Enable DEBUG_LL_UART_PL01X ARM: Conceal DEBUG_LL_UART_NONE from unsupported platforms arm: Seperate DEBUG_UART_PHYS from DEBUG_LL on EP93XX arm: Fix

Re: [RESEND PATCH v5 3/5] ARM: Conceal DEBUG_LL_UART_NONE from unsupported platforms

2014-05-27 Thread Daniel Thompson
On 26/05/14 14:39, Arnd Bergmann wrote: diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug index eab8ecb..4c8d7db 100644 --- a/arch/arm/Kconfig.debug +++ b/arch/arm/Kconfig.debug @@ -842,7 +842,18 @@ choice config DEBUG_LL_UART_NONE bool No low-level

Re: [RESEND PATCH v5 3/5] ARM: Conceal DEBUG_LL_UART_NONE from unsupported platforms

2014-05-27 Thread Daniel Thompson
On 27/05/14 14:37, Arnd Bergmann wrote: I'm very happy to update my patch to follow this one. However since it will render the corresponding debug-macro.S unreachable by KBuild I like to nuke the file as well. Good idea? No. See the description under config DEBUG_LL_UART_NONE:

[PATCH v6 0/5] arm: Fix DEBUG_LL for multi-platform kernels (without PL01X)

2014-05-27 Thread Daniel Thompson
to a series. - Tested defconfig builds of all impacted platforms. Changes since v2: - Switch from def_bool to bool (thanks Russell King) Changes since v1: - Remove pointless single platform support (thanks Arnd Bergmann) Daniel Thompson (5): ARM: versatile: Enable DEBUG_LL_UART_PL01X ARM: ep93xx

[PATCH v6 3/5] ARM: Hide DEBUG_LL_UART_NONE from unsupported platforms

2014-05-27 Thread Daniel Thompson
means to use DEBUG_LL. Signed-off-by: Daniel Thompson daniel.thomp...@linaro.org --- arch/arm/Kconfig.debug | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug index eab8ecb..33f0b38 100644 --- a/arch/arm/Kconfig.debug +++ b/arch/arm

[PATCH v6 1/5] ARM: versatile: Enable DEBUG_LL_UART_PL01X

2014-05-27 Thread Daniel Thompson
This defconfig already enables DEBUG_LL and by default DEBUG_LL_UART_NONE will be selected (but due to some back compability magic I'd like to remove is not actually honoured). DEBUG_LL_UART_PL01X is a much saner default. Signed-off-by: Daniel Thompson daniel.thomp...@linaro.org --- arch/arm

[PATCH v6 5/5] arm: Fix DEBUG_LL for multi-platform kernels (without PL01X)

2014-05-27 Thread Daniel Thompson
the DEBUG_LL backend will be overriden. Problem is fixed by removing the automatic enabling of this option. Signed-off-by: Daniel Thompson daniel.thomp...@linaro.org --- arch/arm/Kconfig.debug | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/arch/arm/Kconfig.debug b/arch/arm

[PATCH v6 2/5] ARM: ep93xx: Enable DEBUG_LL_UART_PL01X

2014-05-27 Thread Daniel Thompson
This defconfig already enables DEBUG_LL and by default DEBUG_LL_UART_NONE will be selected (but due to some back compability magic I'd like to remove is not actually honoured). DEBUG_LL_UART_PL01X is a much saner default. Signed-off-by: Daniel Thompson daniel.thomp...@linaro.org --- arch/arm

[PATCH v6 4/5] arm: Seperate DEBUG_UART_PHYS from DEBUG_LL on EP93XX

2014-05-27 Thread Daniel Thompson
On EP93XX uncompress.h uses CONFIG_DEBUG_UART_PHYS instead of a hard coded serial port. This means the build breaks when DEBUG_LL (and DEBUG_LL_UART_PL01X) is not enabled. This is fixed by adding a new dependancy. Signed-off-by: Daniel Thompson daniel.thomp...@linaro.org --- arch/arm

[PATCH] serial: st-asc: Fix data corruption during long console bursts

2014-05-13 Thread Daniel Thompson
and the busy-wait until the FIFO is empty in asc_console_write() will complete at the same time. Signed-off-by: Daniel Thompson daniel.thomp...@linaro.org --- drivers/tty/serial/st-asc.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/tty/serial/st-asc.c b/drivers

[PATCH 4/4] serial: kgdb_nmi: Improve console integration with KDB I/O

2014-05-14 Thread Daniel Thompson
does. Signed-off-by: Daniel Thompson daniel.thomp...@linaro.org --- drivers/tty/serial/kgdb_nmi.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/drivers/tty/serial/kgdb_nmi.c b/drivers/tty/serial/kgdb_nmi.c index 20d21d0..cfadf29 100644 --- a/drivers/tty

[PATCH 1/4] serial: core: Consistent LF handling for poll_put_char

2014-05-14 Thread Daniel Thompson
() but it is optional for drivers to use this function. Fortunately we can be confident the translation is safe because the (very common) 8250 already does this translation. Signed-off-by: Daniel Thompson daniel.thomp...@linaro.org Cc: Kumar Gala ga...@kernel.crashing.org Cc: Pantelis Antoniou pa...@intracom.gr

[PATCH 3/4] serial: kgdb_nmi: Switch from tasklets to real timers

2014-05-14 Thread Daniel Thompson
kgdb_nmi uses tasklets on the assumption they will not be scheduled until the next timer tick. This assumption is invalid and can lead to live lock, continually servicing the kgdb_nmi tasklet. This is fixed by using the timer API instead. Signed-off-by: Daniel Thompson daniel.thomp...@linaro.org

[PATCH 2/4] serial: kgdb_nmi: Use container_of() to locate private data

2014-05-14 Thread Daniel Thompson
-by: Daniel Thompson daniel.thomp...@linaro.org --- drivers/tty/serial/kgdb_nmi.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/tty/serial/kgdb_nmi.c b/drivers/tty/serial/kgdb_nmi.c index 5f673b7..d51b2a1 100644 --- a/drivers/tty/serial/kgdb_nmi.c +++ b/drivers

[PATCH 0/4] serial: kgdb_nmi: Allow ttyNMIX to act as primary console

2014-05-14 Thread Daniel Thompson
and compile tested on x86 and powerpc. Daniel Thompson (4): serial: core: Consistent LF handling for poll_put_char serial: kgdb_nmi: Use container_of() to locate private data serial: kgdb_nmi: Switch from tasklets to real timers serial: kgdb_nmi: Improve console integration with KDB I/O drivers/tty

Re: [PATCH v3] ARM: add get_user() support for 8 byte types

2014-06-17 Thread Daniel Thompson
On 12/06/14 16:58, Russell King - ARM Linux wrote: On Thu, Jun 12, 2014 at 04:42:35PM +0100, Daniel Thompson wrote: A new atomic modeset/pageflip ioctl being developed in DRM requires get_user() to work for 64bit types (in addition to just put_user()). v1: original v2: pass correct size

Re: [PATCH v3] ARM: add get_user() support for 8 byte types

2014-06-17 Thread Daniel Thompson
On 17/06/14 12:09, Russell King - ARM Linux wrote: On Tue, Jun 17, 2014 at 11:17:23AM +0100, Daniel Thompson wrote: ... at this point there is a narrowing cast followed by an implicit widening. This results in compiler either ignoring r3 altogether or, if spilling to the stack, generating code

Re: [PATCH v3] ARM: add get_user() support for 8 byte types

2014-06-17 Thread Daniel Thompson
On 17/06/14 14:36, Russell King - ARM Linux wrote: On Tue, Jun 17, 2014 at 02:28:44PM +0100, Daniel Thompson wrote: On 17/06/14 12:09, Russell King - ARM Linux wrote: On Tue, Jun 17, 2014 at 11:17:23AM +0100, Daniel Thompson wrote: ... at this point there is a narrowing cast followed

Re: [RFC PATCH 07/11] coresight: add CoreSight ETM driver

2014-06-03 Thread Daniel Thompson
On 30/05/14 14:43, mathieu.poir...@linaro.org wrote: diff --git a/drivers/coresight/coresight-etm-cp14.c b/drivers/coresight/coresight-etm-cp14.c new file mode 100644 index 000..0088bbb --- /dev/null +++ b/drivers/coresight/coresight-etm-cp14.c @@ -0,0 +1,511 @@ +/* Copyright (c)

Re: [RFC PATCH 07/11] coresight: add CoreSight ETM driver

2014-06-03 Thread Daniel Thompson
On 03/06/14 17:37, Mathieu Poirier wrote: +static ssize_t debugfs_status_read(struct file *file, char __user *user_buf, +size_t count, loff_t *ppos) +{ + ssize_t ret; + uint32_t val; + unsigned long flags; + char *buf = kmalloc(PAGE_SIZE,

[PATCH] irqchip: nvic: Use the generic noop function

2014-06-04 Thread Daniel Thompson
Using the generic function saves looking up this custom one in a source navigator. Signed-off-by: Daniel Thompson daniel.thomp...@linaro.org Cc: Thomas Gleixner t...@linutronix.de Cc: Jason Cooper ja...@lakedaemon.net --- drivers/irqchip/irq-nvic.c | 10 +- 1 file changed, 1 insertion

[PATCH v2] irqchip: nvic: Use the generic noop function

2014-06-04 Thread Daniel Thompson
Using the generic function saves looking up this custom one in a source navigator. Signed-off-by: Daniel Thompson daniel.thomp...@linaro.org Cc: Thomas Gleixner t...@linutronix.de Cc: Jason Cooper ja...@lakedaemon.net --- drivers/irqchip/irq-nvic.c | 13 - 1 file changed, 4

[PATCH] serial: st-asc: Fix SysRq char handling

2014-03-28 Thread Daniel Thompson
the requires masking and has been tested to confirm that it correctly handles magic sysrq sequences on ST's B2020 board. Signed-off-by: Daniel Thompson daniel.thomp...@linaro.org --- drivers/tty/serial/st-asc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/tty

[PATCH] serial: mux: Align SUPPORT_SYSRQ behaviour with other drivers.

2014-03-28 Thread Daniel Thompson
needless complexity when doing a code review to check for unexpected side effects of any changes to the serial core. This is (cross-)compile tested only because I do not have any PA-RISC hardware. Signed-off-by: Daniel Thompson daniel.thomp...@linaro.org --- drivers/tty/serial/mux.c | 2 +- 1 file

[PATCH] drm: Add 800x600 (SVGA) screen resolution to the built-in EDIDs

2014-03-28 Thread Daniel Thompson
the existing users of the established timing bits forcing a rework of the ESTABLISHED_TIMINGS_BITS macro. Tested new EDID on an aged (and misbehaving) industrial LCD panel; existing EDIDs still pass edid-decode's checksum checks. Signed-off-by: Daniel Thompson daniel.thomp...@linaro.org --- Documentation

Re: [RFC v3 1/9] sysrq: Implement __handle_sysrq_nolock to avoid recursive locking in kdb

2014-04-28 Thread Daniel Thompson
On 25/04/14 17:45, Steven Rostedt wrote: On Fri, 25 Apr 2014 17:29:22 +0100 Daniel Thompson daniel.thomp...@linaro.org wrote: If kdb is triggered using SysRq-g then any use of the sr command results in the SysRq key table lock being recursively acquired, killing the debug session

Re: [RFC v3 7/9] kdb: Categorize kdb commands (similar to SysRq categorization)

2014-04-28 Thread Daniel Thompson
On 25/04/14 17:57, Steven Rostedt wrote: +KDB_ENABLE_ALL_NO_ARGS = KDB_ENABLE_ALL 16, +KDB_ENABLE_MEM_READ_NO_ARGS = KDB_ENABLE_MEM_READ 16, +KDB_ENABLE_MEM_WRITE_NO_ARGS = KDB_ENABLE_MEM_WRITE 16, +KDB_ENABLE_REG_READ_NO_ARGS = KDB_ENABLE_REG_READ 16, +

Re: [RFC v3 1/9] sysrq: Implement __handle_sysrq_nolock to avoid recursive locking in kdb

2014-04-28 Thread Daniel Thompson
On 28/04/14 18:44, Colin Cross wrote: Is that case documented somewhere in the code comments? Perhaps not near enough to the _nolock but the primary bit of comment is here (and in same file as kdb_sr). --- cut here --- * kdb_main_loop - After initial setup and assignment of the *

Re: [RFC v3 1/9] sysrq: Implement __handle_sysrq_nolock to avoid recursive locking in kdb

2014-04-29 Thread Daniel Thompson
On 28/04/14 18:44, Colin Cross wrote: Is that case documented somewhere in the code comments? Perhaps not near enough to the _nolock but the primary bit of comment is here (and in same file as kdb_sr). --- cut here --- * kdb_main_loop - After initial setup and assignment of the *

[PATCH 3/3] kdb: Implement seq_file command

2014-04-29 Thread Daniel Thompson
of a brave expert an even bigger subset can be unsafely examined). Good arguments to try with this command include: cpuinfo_op, gpiolib_seq_ops and vmalloc_op. Signed-off-by: Daniel Thompson daniel.thomp...@linaro.org --- kernel/debug/kdb/kdb_main.c | 28 1 file changed

[PATCH 0/3] kdb: Infrastructure to display sequence files

2014-04-29 Thread Daniel Thompson
that kdb has interrupt context. Note also that some of the seq_operations structures hook into driver supplied code that will only be called if that driver is enabled so the test above are useful but cannot be exhaustive. Daniel Thompson (3): kdb: Add framework to display sequence files proc

[PATCH 2/3] proc: Provide access to /proc/interrupts from kdb

2014-04-29 Thread Daniel Thompson
the file to be displayed from kdb. Signed-off-by: Daniel Thompson daniel.thomp...@linaro.org --- fs/proc/interrupts.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/fs/proc/interrupts.c b/fs/proc/interrupts.c index a352d57..1f8eeaf 100644 --- a/fs/proc/interrupts.c +++ b/fs/proc

[PATCH 1/3] kdb: Add framework to display sequence files

2014-04-29 Thread Daniel Thompson
files via kdb. Signed-off-by: Daniel Thompson daniel.thomp...@linaro.org --- include/linux/kdb.h | 3 +++ kernel/debug/kdb/kdb_io.c | 51 +++ 2 files changed, 54 insertions(+) diff --git a/include/linux/kdb.h b/include/linux/kdb.h index 290db12

[PATCH 1/3] kdb: Add framework to display sequence files

2014-04-30 Thread Daniel Thompson
files via kdb. Signed-off-by: Daniel Thompson daniel.thomp...@linaro.org --- include/linux/kdb.h | 5 + kernel/debug/kdb/kdb_io.c | 51 +++ 2 files changed, 56 insertions(+) diff --git a/include/linux/kdb.h b/include/linux/kdb.h index 290db12

[PATCH 3/3] kdb: Implement seq_file command

2014-04-30 Thread Daniel Thompson
of a brave expert an even bigger subset can be unsafely examined). Good arguments to try with this command include: cpuinfo_op, gpiolib_seq_ops and vmalloc_op. Signed-off-by: Daniel Thompson daniel.thomp...@linaro.org --- kernel/debug/kdb/kdb_io.c | 6 -- kernel/debug/kdb/kdb_main.c | 28

[PATCH 2/3] proc: Provide access to /proc/interrupts from kdb

2014-04-30 Thread Daniel Thompson
the file to be displayed from kdb. Signed-off-by: Daniel Thompson daniel.thomp...@linaro.org --- fs/proc/interrupts.c | 8 1 file changed, 8 insertions(+) diff --git a/fs/proc/interrupts.c b/fs/proc/interrupts.c index a352d57..d8b64f0 100644 --- a/fs/proc/interrupts.c +++ b/fs/proc

[PATCH 0/3] kdb: Infrastructure to display sequence files

2014-04-30 Thread Daniel Thompson
() and used it to fix build error when CONFIG_KGDB_KDB is not set (oops). * Better comment explaining why seq_file's lock member can be left uninitialized (its will not detect errors because we know it is already not allowed for seq_file ops to use it). Daniel Thompson (3): kdb: Add framework

[PATCH v4 3/9] kdb: Rename kdb_repeat_t to kdb_cmdflags_t, cmd_repeat to cmd_flags

2014-05-06 Thread Daniel Thompson
-by: John Stultz john.stu...@linaro.org Signed-off-by: Daniel Thompson daniel.thomp...@linaro.org --- include/linux/kdb.h| 6 +++--- kernel/debug/kdb/kdb_main.c| 6 +++--- kernel/debug/kdb/kdb_private.h | 2 +- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/include/linux

[PATCH v4 5/9] kdb: Use KDB_REPEAT_* values as flags

2014-05-06 Thread Daniel Thompson
From: Anton Vorontsov anton.voront...@linaro.org The actual values of KDB_REPEAT_* enum values and overall logic stayed the same, but we now treat the values as flags. This makes it possible to add other flags and combine them, plus makes the code a lot simpler and shorter. But

[PATCH v4 7/9] kdb: Categorize kdb commands (similar to SysRq categorization)

2014-05-06 Thread Daniel Thompson
: kill Reboot: reboot All:cpu, kgdb, (and all of the above), nmi_console Signed-off-by: Daniel Thompson daniel.thomp...@linaro.org --- include/linux/kdb.h | 68 +- kernel/debug/kdb/kdb_bp.c | 21 ++ kernel/debug/kdb/kdb_main.c | 100

[PATCH v4 9/9] kdb: Allow access to sensitive commands to be restricted by default

2014-05-06 Thread Daniel Thompson
Currently kiosk mode must be explicitly requested by the bootloader or userspace. It is convenient to be able to change the default value in a similar manner to CONFIG_MAGIC_SYSRQ_DEFAULT_MASK. Signed-off-by: Daniel Thompson daniel.thomp...@linaro.org --- kernel/debug/kdb/kdb_main.c | 2 +- lib

[PATCH v4 6/9] kdb: Remove KDB_REPEAT_NONE flag

2014-05-06 Thread Daniel Thompson
From: Anton Vorontsov anton.voront...@linaro.org Since we now treat KDB_REPEAT_* as flags, there is no need to pass KDB_REPEAT_NONE. It's just the default behaviour when no flags are specified. Signed-off-by: Anton Vorontsov anton.voront...@linaro.org Signed-off-by: John Stultz

[PATCH v4 8/9] kdb: Add enable mask for groups of commands

2014-05-06 Thread Daniel Thompson
Stultz john.stu...@linaro.org Signed-off-by: Daniel Thompson daniel.thomp...@linaro.org --- include/linux/kdb.h | 1 + kernel/debug/kdb/kdb_main.c | 30 +- 2 files changed, 30 insertions(+), 1 deletion(-) diff --git a/include/linux/kdb.h b/include/linux/kdb.h

[PATCH v4 4/9] kdb: Rename kdb_register_repeat() to kdb_register_flags()

2014-05-06 Thread Daniel Thompson
...@linaro.org Signed-off-by: John Stultz john.stu...@linaro.org Signed-off-by: Daniel Thompson daniel.thomp...@linaro.org --- include/linux/kdb.h | 10 +++--- kernel/debug/kdb/kdb_bp.c | 14 kernel/debug/kdb/kdb_main.c | 86 ++--- kernel/trace

[PATCH v4 2/9] kdb: Remove currently unused kdbtab_t-cmd_flags

2014-05-06 Thread Daniel Thompson
From: Anton Vorontsov anton.voront...@linaro.org The struct member is never used in the code, so we can remove it. We will introduce real flags soon by renaming cmd_repeat to cmd_flags. Signed-off-by: Anton Vorontsov anton.voront...@linaro.org Signed-off-by: John Stultz john.stu...@linaro.org

[PATCH v4 1/9] sysrq: Implement __handle_sysrq_nolock to avoid recursive locking in kdb

2014-05-06 Thread Daniel Thompson
If kdb is triggered using SysRq-g then any use of the sr command results in the SysRq key table lock being recursively acquired, killing the debug session. That patch resolves the problem by introducing a _nolock alternative for __handle_sysrq. Signed-off-by: Daniel Thompson daniel.thomp

[PATCH v4 0/9] kdb: Allow selective reduction in capabilities (was kiosk mode)

2014-05-06 Thread Daniel Thompson
: Rename kdb_register_repeat() to kdb_register_flags() kdb: Use KDB_REPEAT_* values as flags kdb: Remove KDB_REPEAT_NONE flag kdb: Add enable mask for groups of commands Daniel Thompson (3): sysrq: Implement __handle_sysrq_nolock to avoid recursive locking in kdb kdb: Categorize kdb

[PATCH] arm: Describe required sort order for textofs-y (TEXT_OFFSET)

2014-05-06 Thread Daniel Thompson
The section of the makefile that determines the TEXT_OFFSET is sorted by address so that, in multi-arch kernel builds, the architecture with the most stringent requirements for the kernel base address gets to define TEXT_OFFSET. The comment should reflect that. Signed-off-by: Daniel Thompson

[PATCH] arm: Fix DEBUG_LL for multi-platform kernels (without PL01X)

2014-04-04 Thread Daniel Thompson
the compatibility options for SPEAr when ARCH_MULTIPLATFORM is not set. Signed-off-by: Daniel Thompson daniel.thomp...@linaro.org --- arch/arm/Kconfig.debug | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug index 0531da8..f10c784

Re: [PATCH] arm: Fix DEBUG_LL for multi-platform kernels (without PL01X)

2014-04-04 Thread Daniel Thompson
On 04/04/14 12:39, Arnd Bergmann wrote: Problem is fixed by only deploying the compatibility options for SPEAr when ARCH_MULTIPLATFORM is not set. The assumption is actually wrong: SPEAr does not support single platform builds any more. The PLAT_SPEAR_SINGLE symbol in Kconfig is a leftover

[PATCH v2] arm: Fix DEBUG_LL for multi-platform kernels (without PL01X)

2014-04-04 Thread Daniel Thompson
DEBUG_UART_PL01X, which is intended to provide some kind of compatibility with single platform builds, spuriously depends upon ARCH_SPEAR13XX (and similar SPEAr options). Problem is fixed by removing problematic dependancies. Signed-off-by: Daniel Thompson daniel.thomp...@linaro.org --- Notes: v2: Remove

Re: [PATCH] arm: Fix DEBUG_LL for multi-platform kernels (without PL01X)

2014-04-04 Thread Daniel Thompson
On 04/04/14 15:41, Russell King - ARM Linux wrote: The happens because the multi-platform mode may include ARCH_SPEAR13XX and this forcibly engages DEBUG_UART_PL01X to provide some kind of compatibility with single platform builds (SPEAr supports both single and multi-platform). This in turn

[PATCH v3] arm: Fix DEBUG_LL for multi-platform kernels (without PL01X)

2014-04-04 Thread Daniel Thompson
the DEBUG_LL backend will be overriden. Problem is fixed by removing the automatic enabling of this option. Signed-off-by: Daniel Thompson daniel.thomp...@linaro.org --- Notes: v3: Switch from def_bool to bool (thanks Russell King) v2: Remove pointless single platform support (thanks Arnd Bergmann

Re: [PATCH v3] arm: Fix DEBUG_LL for multi-platform kernels (without PL01X)

2014-04-07 Thread Daniel Thompson
On 04/04/14 16:41, Daniel Thompson wrote: diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug index 0531da8..7e19c94 100644 --- a/arch/arm/Kconfig.debug +++ b/arch/arm/Kconfig.debug @@ -989,12 +989,7 @@ config DEBUG_LL_INCLUDE # Compatibility options for PL01x config

[PATCH v4 2/5] ARM: ep93xx: Enable DEBUG_LL_UART_PL01X

2014-04-07 Thread Daniel Thompson
This defconfig already enables DEBUG_LL and by default DEBUG_LL_UART_NONE will be selected (but due to some back compability magic I'd like to remove is not actually honoured). DEBUG_LL_UART_PL01X is a much saner default. Signed-off-by: Daniel Thompson daniel.thomp...@linaro.org --- arch/arm

[PATCH v4 0/5] arm: Fix DEBUG_LL for multi-platform kernels (without PL01X)

2014-04-07 Thread Daniel Thompson
to a series. - Tested defconfig builds of all impacted platforms. Changes since v2: - Switch from def_bool to bool (thanks Russell King) Changes since v1: - Remove pointless single platform support (thanks Arnd Bergmann) Daniel Thompson (5): ARM: versatile: Enable DEBUG_LL_UART_PL01X ARM: ep93xx

[PATCH v4 1/5] ARM: versatile: Enable DEBUG_LL_UART_PL01X

2014-04-07 Thread Daniel Thompson
This defconfig already enables DEBUG_LL and by default DEBUG_LL_UART_NONE will be selected (but due to some back compability magic I'd like to remove is not actually honoured). DEBUG_LL_UART_PL01X is a much saner default. Signed-off-by: Daniel Thompson daniel.thomp...@linaro.org --- arch/arm

[PATCH v4 3/5] ARM: Conceal DEBUG_LL_UART_NONE from unsupported platforms

2014-04-07 Thread Daniel Thompson
it. Signed-off-by: Daniel Thompson daniel.thomp...@linaro.org --- arch/arm/Kconfig.debug | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug index 0531da8..0702d6d 100644 --- a/arch/arm/Kconfig.debug +++ b/arch/arm

[PATCH v4 5/5] arm: Fix DEBUG_LL for multi-platform kernels (without PL01X)

2014-04-07 Thread Daniel Thompson
the DEBUG_LL backend will be overriden. Problem is fixed by removing the automatic enabling of this option. Signed-off-by: Daniel Thompson daniel.thomp...@linaro.org --- arch/arm/Kconfig.debug | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/arch/arm/Kconfig.debug b/arch/arm

[PATCH v4 4/5] arm: Seperate DEBUG_UART_PHYS from DEBUG_LL on EP93XX

2014-04-07 Thread Daniel Thompson
On EP93XX uncompress.h uses CONFIG_DEBUG_UART_PHYS instead of a hard coded serial port. This means the build breaks when DEBUG_LL (and DEBUG_LL_UART_PL01X) is not enabled. This is fixed by adding a new dependancy. Signed-off-by: Daniel Thompson daniel.thomp...@linaro.org --- Notes: Having

[RESEND PATCH v5 1/5] ARM: versatile: Enable DEBUG_LL_UART_PL01X

2014-04-24 Thread Daniel Thompson
This defconfig already enables DEBUG_LL and by default DEBUG_LL_UART_NONE will be selected (but due to some back compability magic I'd like to remove is not actually honoured). DEBUG_LL_UART_PL01X is a much saner default. Signed-off-by: Daniel Thompson daniel.thomp...@linaro.org --- arch/arm

[RESEND PATCH v5 4/5] arm: Seperate DEBUG_UART_PHYS from DEBUG_LL on EP93XX

2014-04-24 Thread Daniel Thompson
On EP93XX uncompress.h uses CONFIG_DEBUG_UART_PHYS instead of a hard coded serial port. This means the build breaks when DEBUG_LL (and DEBUG_LL_UART_PL01X) is not enabled. This is fixed by adding a new dependancy. Signed-off-by: Daniel Thompson daniel.thomp...@linaro.org --- Notes: Having

[RESEND PATCH v5 5/5] arm: Fix DEBUG_LL for multi-platform kernels (without PL01X)

2014-04-24 Thread Daniel Thompson
the DEBUG_LL backend will be overriden. Problem is fixed by removing the automatic enabling of this option. Signed-off-by: Daniel Thompson daniel.thomp...@linaro.org --- arch/arm/Kconfig.debug | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/arch/arm/Kconfig.debug b/arch/arm

[RESEND PATCH v5 3/5] ARM: Conceal DEBUG_LL_UART_NONE from unsupported platforms

2014-04-24 Thread Daniel Thompson
it. Signed-off-by: Daniel Thompson daniel.thomp...@linaro.org --- arch/arm/Kconfig.debug | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug index 4a2fc0b..450e6f7 100644 --- a/arch/arm/Kconfig.debug +++ b/arch/arm

[RESEND PATCH v5 2/5] ARM: ep93xx: Enable DEBUG_LL_UART_PL01X

2014-04-24 Thread Daniel Thompson
This defconfig already enables DEBUG_LL and by default DEBUG_LL_UART_NONE will be selected (but due to some back compability magic I'd like to remove is not actually honoured). DEBUG_LL_UART_PL01X is a much saner default. Signed-off-by: Daniel Thompson daniel.thomp...@linaro.org --- arch/arm

[RESEND PATCH v5 0/5] arm: Fix DEBUG_LL for multi-platform kernels (without PL01X)

2014-04-24 Thread Daniel Thompson
Daniel Thompson (5): ARM: versatile: Enable DEBUG_LL_UART_PL01X ARM: ep93xx: Enable DEBUG_LL_UART_PL01X ARM: Conceal DEBUG_LL_UART_NONE from unsupported platforms arm: Seperate DEBUG_UART_PHYS from DEBUG_LL on EP93XX arm: Fix DEBUG_LL for multi-platform kernels (without PL01X) arch/arm

[RFC v3 8/9] kdb: Add enable mask for groups of commands

2014-04-25 Thread Daniel Thompson
Stultz john.stu...@linaro.org Signed-off-by: Daniel Thompson daniel.thomp...@linaro.org --- include/linux/kdb.h | 1 + kernel/debug/kdb/kdb_main.c | 30 +- 2 files changed, 30 insertions(+), 1 deletion(-) diff --git a/include/linux/kdb.h b/include/linux/kdb.h

[RFC v3 9/9] kdb: Allow access to sensitive commands to be restricted by default

2014-04-25 Thread Daniel Thompson
Currently kiosk mode must be explicitly requested by the bootloader or userspace. It is convenient to be able to change the default value in a similar manner to CONFIG_MAGIC_SYSRQ_DEFAULT_MASK. Signed-off-by: Daniel Thompson daniel.thomp...@linaro.org --- kernel/debug/kdb/kdb_main.c | 2 +- lib

[RFC v3 6/9] kdb: Remove KDB_REPEAT_NONE flag

2014-04-25 Thread Daniel Thompson
From: Anton Vorontsov anton.voront...@linaro.org Since we now treat KDB_REPEAT_* as flags, there is no need to pass KDB_REPEAT_NONE. It's just the default behaviour when no flags are specified. Signed-off-by: Anton Vorontsov anton.voront...@linaro.org Signed-off-by: John Stultz

[RFC v3 7/9] kdb: Categorize kdb commands (similar to SysRq categorization)

2014-04-25 Thread Daniel Thompson
: kill Reboot: reboot All:cpu, kgdb, (and all of the above), nmi_console Signed-off-by: Daniel Thompson daniel.thomp...@linaro.org --- include/linux/kdb.h | 52 ++- kernel/debug/kdb/kdb_bp.c | 21 ++ kernel/debug/kdb/kdb_main.c | 100

[RFC v3 5/9] kdb: Use KDB_REPEAT_* values as flags

2014-04-25 Thread Daniel Thompson
From: Anton Vorontsov anton.voront...@linaro.org The actual values of KDB_REPEAT_* enum values and overall logic stayed the same, but we now treat the values as flags. This makes it possible to add other flags and combine them, plus makes the code a lot simpler and shorter. But

[RFC v3 2/9] kdb: Remove currently unused kdbtab_t-cmd_flags

2014-04-25 Thread Daniel Thompson
From: Anton Vorontsov anton.voront...@linaro.org The struct member is never used in the code, so we can remove it. We will introduce real flags soon by renaming cmd_repeat to cmd_flags. Signed-off-by: Anton Vorontsov anton.voront...@linaro.org Signed-off-by: John Stultz john.stu...@linaro.org

[RFC v3 4/9] kdb: Rename kdb_register_repeat() to kdb_register_flags()

2014-04-25 Thread Daniel Thompson
From: Anton Vorontsov anton.voront...@linaro.org We're about to add more options for commands behaviour, so let's give a more generic name to the low-level kdb command registration function. There are just various renames, no functional changes. Signed-off-by: Anton Vorontsov

[RFC v3 3/9] kdb: Rename kdb_repeat_t to kdb_cmdflags_t, cmd_repeat to cmd_flags

2014-04-25 Thread Daniel Thompson
From: Anton Vorontsov anton.voront...@linaro.org We're about to add more options for command behaviour, so let's expand the meaning of kdb_repeat_t. So far we just do various renames, there should be no functional changes. Signed-off-by: Anton Vorontsov anton.voront...@linaro.org Signed-off-by:

[RFC v3 0/9] kdb: Allow selective reduction in capabilities (was kiosk mode)

2014-04-25 Thread Daniel Thompson
to cmd_flags kdb: Rename kdb_register_repeat() to kdb_register_flags() kdb: Use KDB_REPEAT_* values as flags kdb: Remove KDB_REPEAT_NONE flag kdb: Add enable mask for groups of commands Daniel Thompson (3): sysrq: Implement __handle_sysrq_nolock to avoid recursive locking in kdb kdb

[RFC v3 1/9] sysrq: Implement __handle_sysrq_nolock to avoid recursive locking in kdb

2014-04-25 Thread Daniel Thompson
on the key table when kdb is triggered by something other than SysRq-g however in that case any other CPU involved should release the spin lock before kgdb parks the slave CPUs. Signed-off-by: Daniel Thompson daniel.thomp...@linaro.org --- drivers/tty/sysrq.c | 11 --- include/linux

[RFC v2 10/10] kdb: Allow access to sensitive commands to be restricted by default

2014-04-02 Thread Daniel Thompson
Currently kiosk mode must be explicitly requested by the bootloader or userspace. It is convenient to be able to change the default value in a similar manner to CONFIG_MAGIC_SYSRQ_DEFAULT_MASK. Signed-off-by: Daniel Thompson daniel.thomp...@linaro.org --- kernel/debug/kdb/kdb_main.c | 2 +- lib

[RFC v2 04/10] kdb: Rename kdb_register_repeat() to kdb_register_flags()

2014-04-02 Thread Daniel Thompson
...@linaro.org Signed-off-by: John Stultz john.stu...@linaro.org Signed-off-by: Daniel Thompson daniel.thomp...@linaro.org --- include/linux/kdb.h | 10 +++--- kernel/debug/kdb/kdb_bp.c | 14 kernel/debug/kdb/kdb_main.c | 86 ++--- kernel/trace

[RFC v2 09/10] kdb: Improve usability of help text when running in kiosk mode

2014-04-02 Thread Daniel Thompson
classified as safe. Signed-off-by: Daniel Thompson daniel.thomp...@linaro.org --- kernel/debug/kdb/kdb_main.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/kernel/debug/kdb/kdb_main.c b/kernel/debug/kdb/kdb_main.c index 808bf55..77b6e61 100644 --- a/kernel/debug/kdb/kdb_main.c +++ b/kernel

[RFC v2 08/10] kdb: Add kiosk mode

2014-04-02 Thread Daniel Thompson
-off-by: John Stultz john.stu...@linaro.org Signed-off-by: Daniel Thompson daniel.thomp...@linaro.org --- include/linux/kdb.h | 1 + kernel/debug/kdb/kdb_main.c | 31 ++- 2 files changed, 31 insertions(+), 1 deletion(-) diff --git a/include/linux/kdb.h b

[RFC v2 07/10] kdb: Mark safe commands as KDB_SAFE and KDB_SAFE_NO_ARGS

2014-04-02 Thread Daniel Thompson
. Signed-off-by: Anton Vorontsov anton.voront...@linaro.org Signed-off-by: John Stultz john.stu...@linaro.org Signed-off-by: Daniel Thompson daniel.thomp...@linaro.org --- include/linux/kdb.h | 2 ++ kernel/debug/kdb/kdb_main.c | 48 - kernel/trace

[RFC v2 03/10] kdb: Rename kdb_repeat_t to kdb_cmdflags_t, cmd_repeat to cmd_flags

2014-04-02 Thread Daniel Thompson
-by: John Stultz john.stu...@linaro.org Signed-off-by: Daniel Thompson daniel.thomp...@linaro.org --- include/linux/kdb.h| 4 ++-- kernel/debug/kdb/kdb_main.c| 6 +++--- kernel/debug/kdb/kdb_private.h | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/include/linux

[RFC v2 01/10] sysrq: Implement __handle_sysrq_nolock to avoid recursive locking in kdb

2014-04-02 Thread Daniel Thompson
on the key table when kdb is triggered by something other than SysRq-g however in that case any other CPU involved should release the spin lock before kgdb parks the slave CPUs. Signed-off-by: Daniel Thompson daniel.thomp...@linaro.org --- drivers/tty/sysrq.c | 11 --- include/linux

[RFC v2 05/10] kdb: Use KDB_REPEAT_* values as flags

2014-04-02 Thread Daniel Thompson
-wise, there should be no changes. Signed-off-by: Anton Vorontsov anton.voront...@linaro.org Signed-off-by: John Stultz john.stu...@linaro.org Signed-off-by: Daniel Thompson daniel.thomp...@linaro.org --- include/linux/kdb.h | 4 ++-- kernel/debug/kdb/kdb_main.c | 21 +++-- 2

  1   2   3   4   5   6   7   8   9   10   >