From: Dave Chinner dchin...@redhat.com
When competing sync(2) calls walk the same filesystem, they need to
walk the list of inodes on the superblock to find all the inodes
that we need to wait for IO completion on. However, when multiple
wait_sb_inodes() calls do this at the same time
From: Dave Chinner dchin...@redhat.com
The process of reducing contention on per-superblock inode lists
starts with moving the locking to match the per-superblock inode
list. This takes the global lock out of the picture and reduces the
contention problems to within a single filesystem
Hi folks,
This series of patches is against the curent mmotm tree here:
http://git.cmpxchg.org/cgit/linux-mmotm.git/
It addresses several VFS scalability issues, the most pressing of which is lock
contention triggered by concurrent sync(2) calls.
The patches in the series are:
writeback: plug
From: Dave Chinner dchin...@redhat.com
We only add an item to the LRU is it is empty, and we only remove
them if they are on the LRU. We can check these conditions without
holding the node lock and avoid grabbing the lock if they evaluate
as not needing a list operation.
We can do this without
From: Dave Chinner dchin...@redhat.com
Doing writeback on lots of little files causes terrible IOPS storms
because of the per-mapping writeback plugging we do. This
essentially causes imeediate dispatch of IO for each mapping,
regardless of the context in which writeback is occurring.
IOWs
On Wed, Jul 31, 2013 at 08:35:07AM -0500, Ben Myers wrote:
Hey Zhi,
On Wed, Jul 31, 2013 at 12:07:32PM +0800, Zhi Yong Wu wrote:
On Wed, Jul 31, 2013 at 7:11 AM, Dave Chinner da...@fromorbit.com wrote:
On Tue, Jul 30, 2013 at 05:59:07PM +0800, zwu.ker...@gmail.com wrote:
From: Zhi Yong
suggest that you need to explain what FALLOC_FL_COLLAPSE_RANGE
does in great detail right here.
Cheers,
Dave.
--
Dave Chinner
da...@fromorbit.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info
the beginning of the file.
Does the right thing happen to the mmap'ed region in memory?
Implementation detail. like a hole punch, it needs to invalidate the
range that it is operating over so mmap()d regions are refaulted
after the operation is done.
Cheers,
Dave.
--
Dave Chinner
da...@fromorbit.com
On Wed, Jul 31, 2013 at 08:46:45PM -0400, Theodore Ts'o wrote:
On Thu, Aug 01, 2013 at 10:23:41AM +1000, Dave Chinner wrote:
On Wed, Jul 31, 2013 at 06:01:54PM -0400, Theodore Ts'o wrote:
Have you considered what happens if you have a 10 megabyte file, of
which the first 5 megs
into has no extents in it.
IOWs, the first operation that needs to be done is a hole punch of
the range being removed - we need xfs_free_file_space() call on the
range first.
And as Ted pointed out, we also need to invalidate the page cache
over the range being moved.
Cheers,
Dave.
--
Dave Chinner
da
);
+ if (ret)
+ goto journal_stop;
So, this code punches out the existing space in the file so that the
extent shifting is moving extents into a hole. Why is this in the
ext4 code, but not the XFS code?
Cheers,
Dave.
--
Dave Chinner
da...@fromorbit.com
--
To unsubscribe from
On Wed, Jul 31, 2013 at 09:07:52PM -0400, Theodore Ts'o wrote:
On Thu, Aug 01, 2013 at 10:54:47AM +1000, Dave Chinner wrote:
It's not just the range that it's operating on, but also the region
beyond the range that's been collapsed out.
Yes, that's part of the range
On Thu, Aug 01, 2013 at 12:06:05AM -0400, Theodore Ts'o wrote:
On Thu, Aug 01, 2013 at 12:59:14PM +1000, Dave Chinner wrote:
This funtionality is not introducing any new problems w.r.t. mmap().
In terms of truncating a mmap'd file, that can already occur and
the behaviour is well known
On Wed, Jul 31, 2013 at 04:40:19PM +0200, Jan Kara wrote:
On Wed 31-07-13 14:15:40, Dave Chinner wrote:
From: Dave Chinner dchin...@redhat.com
Doing writeback on lots of little files causes terrible IOPS storms
because of the per-mapping writeback plugging we do. This
essentially
On Wed, Jul 31, 2013 at 05:11:14PM +0200, Jan Kara wrote:
On Wed 31-07-13 14:15:45, Dave Chinner wrote:
/*
+ * mark an inode as under writeback on the given bdi
+ */
+void bdi_mark_inode_writeback(struct backing_dev_info *bdi, struct inode
*inode)
+{
+ WARN_ON_ONCE(bdi
On Wed, Jul 31, 2013 at 05:15:42PM +0200, Jan Kara wrote:
On Wed 31-07-13 14:15:46, Dave Chinner wrote:
From: Dave Chinner dchin...@redhat.com
Inodes are removed lazily from the bdi writeback list, so in the
absence of sync(2) work inodes will build up on the bdi writback
list even
On Wed, Jul 31, 2013 at 08:48:40AM +0200, Sedat Dilek wrote:
On Wed, Jul 31, 2013 at 6:15 AM, Dave Chinner da...@fromorbit.com wrote:
Hi folks,
This series of patches is against the curent mmotm tree here:
http://git.cmpxchg.org/cgit/linux-mmotm.git/
Current is not precise enough
or used - I just want to be
able to use the infrastructure it provides. As such renaming and
relocating it is not something I'm about to do in this specific
patchset
Cheers,
Dave.
--
Dave Chinner
da...@fromorbit.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel
On Thu, Aug 01, 2013 at 01:12:35AM -0700, Christoph Hellwig wrote:
On Wed, Jul 31, 2013 at 02:15:41PM +1000, Dave Chinner wrote:
From: Dave Chinner dchin...@redhat.com
Some filesystems don't use the VFS inode hash and fake the fact they
are hashed so that all the writeback code works
On Thu, Aug 01, 2013 at 02:07:39PM +0900, Namjae Jeon wrote:
2013/8/1, Dave Chinner da...@fromorbit.com:
On Wed, Jul 31, 2013 at 11:42:00PM +0900, Namjae Jeon wrote:
From: Namjae Jeon namjae.j...@samsung.com
Fallocate now supports new FALLOC_FL_COLLAPSE_RANGE flag.
The semantics
/2012-12/msg00124.html
Yeah, probably makes sense to do this. I'll have a look at porting
it forwards to my current tree as xfs_vnodeops.c has gone away in
that series...
Cheers,
Dave.
--
Dave Chinner
da...@fromorbit.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel
On Thu, Aug 01, 2013 at 02:33:09PM +0900, Namjae Jeon wrote:
2013/8/1, Dave Chinner da...@fromorbit.com:
On Wed, Jul 31, 2013 at 11:42:14PM +0900, Namjae Jeon wrote:
From: Namjae Jeon namjae.j...@samsung.com
New fallocate flag FALLOC_FL_COLLAPSE_RANGE implementation for XFS.
Hi Dave
hex filename
792234 99018 632 891884 d9bec fs/xfs/xfs.o.orig
792090 99018 632 891740 d9b5c fs/xfs/xfs.o
Which means making it inline hasn't cost us anything at individual
call sites.
Reviewed-by: Dave Chinner dchin...@redhat.com
Cheers,
Dave.
--
Dave Chinner
da
to sysfs without first having some clue about whether
we are solving the right problem and solving it in a sane manner...
Cheers,
Dave.
--
Dave Chinner
da...@fromorbit.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
of the operations that the issuer want to have
complete as fast as possible
Cheers,
Dave.
--
Dave Chinner
da...@fromorbit.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
.
FWIW, buffered IO on XFS - the normal case for most operations -
holds the i_mutex over the call to file_remove_suid(), and that's
why this warning is pretty much never seen - direct IO writes to
suid files is very unusual
Cheers,
Dave.
--
Dave Chinner
da...@fromorbit.com
--
To unsubscribe
.
--
Dave Chinner
da...@fromorbit.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[my keyboard my be on the fritz - it's not typing what I'm thinking...]
On Thu, Sep 19, 2013 at 06:38:22AM +1000, Dave Chinner wrote:
On Wed, Sep 18, 2013 at 12:38:23PM +0200, Knut Petersen wrote:
On 18.09.2013 11:10, Daniel Vetter wrote:
Just now I prepared a patch changing the same
On Thu, Sep 19, 2013 at 08:57:04AM +0200, Daniel Vetter wrote:
On Wed, Sep 18, 2013 at 10:38 PM, Dave Chinner da...@fromorbit.com wrote:
No, that's wrong. -count_objects should never ass SHRINK_STOP.
Indeed, it should always return a count of objects in the cache,
regardless of the context
On Tue, Oct 15, 2013 at 01:41:28PM -0400, Johannes Weiner wrote:
On Tue, Oct 15, 2013 at 12:41:23PM +1100, Dave Chinner wrote:
On Mon, Oct 14, 2013 at 05:42:50PM -0400, Johannes Weiner wrote:
Hi Dave,
On Fri, Oct 11, 2013 at 11:39:30AM +1100, Dave Chinner wrote:
On Thu, Oct 10
On Tue, Oct 15, 2013 at 10:05:26PM -0400, Rik van Riel wrote:
On 10/15/2013 07:41 PM, Dave Chinner wrote:
On Tue, Oct 15, 2013 at 01:41:28PM -0400, Johannes Weiner wrote:
I'm not forgetting about them, I just track them very coarsely by
linking up address spaces and then lazily enforce
sayin'.
---
Akira, can you please post the entire set of messages you are
getting when XFS showing problems? That way I can try to confirm
whether it's a regression in XFS or something else.
Cheers,
Dave.
--
Dave Chinner
da...@fromorbit.com
--
To unsubscribe from this list: send the line
On Wed, Oct 16, 2013 at 12:05:28AM -0700, Christoph Hellwig wrote:
On Wed, Oct 16, 2013 at 08:36:18AM +1100, Dave Chinner wrote:
Sure, but file_remove_suid() doesn't actually modify any VFS inode
structures until we process the flags and the modifications within
-setattr, which in XFS
block IO?
Cheers,
Dave.
--
Dave Chinner
da...@fromorbit.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org
as CONFIG_XFS_DEBUG and see what warnings that
throws?
Cheers,
Dave.
--
Dave Chinner
da...@fromorbit.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read
, but still there) that
this code may still not end up in the kernel at all...
So, it's probably best right now to revert this patch until we have
the fallocate API support merged into the kernel...
Cheers,
Dave.
--
Dave Chinner
da...@fromorbit.com
--
To unsubscribe from this list: send the line
a fatal gunshot wound to the head.
i.e. the person is *dead* and life is *unrecoverable*.
That's what you are doing here - returning EIOs to IOs in progress
is effectively shooting the fileystem (and user data) in the
head.
Cheers,
Dave.
--
Dave Chinner
da...@fromorbit.com
--
To unsubscribe
://oss.sgi.com/archives/xfs/2013-10/msg00374.html
Cheers,
Dave.
--
Dave Chinner
da...@fromorbit.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read
On Wed, Oct 16, 2013 at 06:31:04PM -0400, Johannes Weiner wrote:
On Wed, Oct 16, 2013 at 01:26:06PM +1100, Dave Chinner wrote:
On Tue, Oct 15, 2013 at 10:05:26PM -0400, Rik van Riel wrote:
On 10/15/2013 07:41 PM, Dave Chinner wrote:
On Tue, Oct 15, 2013 at 01:41:28PM -0400, Johannes
);
truncate_inode_pages_range(mapping, 0, (loff_t)-1);
}
and thereby avoiding the mapping lock altogether for inodes that do
not require it to be taken?
Cheers,
Dave.
--
Dave Chinner
da...@fromorbit.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message
.
--
Dave Chinner
da...@fromorbit.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
On Tue, Nov 26, 2013 at 04:27:25PM -0500, Johannes Weiner wrote:
On Tue, Nov 26, 2013 at 10:49:21AM +1100, Dave Chinner wrote:
On Sun, Nov 24, 2013 at 06:38:28PM -0500, Johannes Weiner wrote:
Previously, page cache radix tree nodes were freed after reclaim
emptied out their page pointers
/list-lru changes being made as I am
the original author of the list-lru code and the shrinker
integration and have more than a passing interest in ensuring
it doesn't get broken or crippled
Cheers,
Dave.
--
Dave Chinner
da...@fromorbit.com
--
To unsubscribe from this list: send the line
On Tue, Nov 26, 2013 at 06:00:10PM -0500, Johannes Weiner wrote:
On Wed, Nov 27, 2013 at 09:29:37AM +1100, Dave Chinner wrote:
On Tue, Nov 26, 2013 at 04:27:25PM -0500, Johannes Weiner wrote:
On Tue, Nov 26, 2013 at 10:49:21AM +1100, Dave Chinner wrote:
On Sun, Nov 24, 2013 at 06:38:28PM
On Wed, Nov 27, 2013 at 12:08:04PM -0500, Johannes Weiner wrote:
On Tue, Nov 26, 2013 at 10:17:16AM +1100, Dave Chinner wrote:
On Sun, Nov 24, 2013 at 06:38:25PM -0500, Johannes Weiner wrote:
Reclaim will be leaving shadow entries in the page cache radix tree
upon evicting the real page
;
+
+ list_lru_walk_node(workingset_shadow_nodes, sc-nid,
+shadow_lru_isolate, nr_reclaimed, sc-nr_to_scan);
+
+ return nr_reclaimed;
+}
Do we need check against GFP_NOFS here? I don't think so, but I just
wanted to check...
Cheers,
Dave.
--
Dave Chinner
da
On Mon, Oct 14, 2013 at 05:42:50PM -0400, Johannes Weiner wrote:
Hi Dave,
On Fri, Oct 11, 2013 at 11:39:30AM +1100, Dave Chinner wrote:
On Thu, Oct 10, 2013 at 05:46:54PM -0400, Johannes Weiner wrote:
Costs
These patches increase struct inode by three words to manage shadow
On Tue, Oct 15, 2013 at 01:19:05PM -0700, Christoph Hellwig wrote:
On Sat, Oct 05, 2013 at 01:19:18PM +1000, Dave Chinner wrote:
Yup, we don't hold the i_mutex *at all* through the fast path for
direct IO writes. Having to grab the i_mutex on every IO just for
the extremely unlikely case we
Trond here again:
http://lists.linux-foundation.org/pipermail/ksummit-2012-discuss/2012-June/66.html
Yup, and my take on the role of a Maintainer is here:
http://oss.sgi.com/archives/xfs/2013-08/msg00633.html
P: Silicon Graphics Inc
+M: Dave Chinner
think it might be possible he decided to unplug and
actually live for a couple of days?
If by live you mean taking my race car to play amongst a gaggle
of supercars on an airstrip then yes, living is exactly what I was
doing on the weekend :)
Cheers,
Dave.
--
Dave Chinner
da
On Thu, Nov 07, 2013 at 02:48:06PM +0100, Jan Kara wrote:
On Tue 05-11-13 15:12:45, Dave Chinner wrote:
On Mon, Nov 04, 2013 at 05:50:13PM -0700, Andreas Dilger wrote:
Something simple like “start writing at 16MB dirty on a single file”
would probably avoid a lot of complexity at little
Chinner dchin...@fromorbit.com
M: Ben Myers b...@sgi.com
-M: Alex Elder el...@kernel.org
M: x...@oss.sgi.com
L: x...@oss.sgi.com
W: http://oss.sgi.com/projects/xfs
Reviewed-by: Dave Chinner da...@fromorbit.com
--
Dave Chinner
da...@fromorbit.com
--
To unsubscribe from this list
0 0 0 0 0 0 0 0 0 0 0
253 16 vdb 0 0 0 0 0 0 0 0 0 0 0
253 32 vdc 0 0 0 0 0 0 0 0 0 0 0
253 48 vdd 0 0 0 0 0 0 0 0 0 0 0
I have no idea if it's related to the above hang, but either way
breaking iostat is a major regression
Cheers,
Dave.
--
Dave Chinner
da...@fromorbit.com
On Tue, Nov 19, 2013 at 09:05:09AM -0700, Jens Axboe wrote:
On Tue, Nov 19 2013, Christoph Hellwig wrote:
On Tue, Nov 19, 2013 at 07:02:18PM +1100, Dave Chinner wrote:
I have no idea if it's related to the above hang, but either way
breaking iostat is a major regression
Both
On Tue, Nov 19, 2013 at 02:20:42PM -0700, Jens Axboe wrote:
On Tue, Nov 19 2013, Jens Axboe wrote:
On Tue, Nov 19 2013, Dave Chinner wrote:
Hi Jens,
I was just running xfstests on a 3.13 kernel that has had the block
layer changed merged into it. generic/269 on XFS is hanging
On Tue, Nov 19, 2013 at 03:51:27PM -0700, Jens Axboe wrote:
On 11/19/2013 03:42 PM, Jens Axboe wrote:
On 11/19/2013 02:43 PM, Jens Axboe wrote:
On 11/19/2013 02:34 PM, Dave Chinner wrote:
On Tue, Nov 19, 2013 at 02:20:42PM -0700, Jens Axboe wrote:
On Tue, Nov 19 2013, Jens Axboe wrote
it now. might take a little while to confirm given it had
taken a few iterations of xfstests before I tripped over it...
Cheers,
Dave.
--
Dave Chinner
da...@fromorbit.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
.
--
Dave Chinner
da...@fromorbit.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
-seeks;
(4 * nr_pages_scanned) is a dividend, while:
delta *= max_pass;
- do_div(delta, lru_pages + 1);
+ do_div(delta, denominator + 1);
(lru_pages + 1) is a divisor.
Cheers,
Dave.
--
Dave Chinner
da...@fromorbit.com
--
To unsubscribe from this list: send the line
On Tue, Dec 03, 2013 at 01:44:38PM +0400, Vladimir Davydov wrote:
On 12/03/2013 01:33 PM, Dave Chinner wrote:
kmemcg reclaim is introduced, we will have to make up phony values for
nr_pages_scanned and lru_pages again when doing kmem-only reclaim for a
memory cgroup, which is possible
this patch set less and less as I work my way through
it...
Cheers,
Dave.
--
Dave Chinner
da...@fromorbit.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
in the struct list_lru, not wrapping
around the outside. I don't see any changelog to tell me why you
changed the code from what was last in Glauber's tree, so can you
explain why exposing all this memcg stuff to everyone is a good
idea?
Cheers,
Dave.
--
Dave Chinner
da...@fromorbit.com
--
To unsubscribe
| SHRINKER_MEMCG_AWARE;
That's basically the only real logic change that should be
necessary to configure memcg LRUs and shrinkers for any user of the
list_lru infrastructure
Cheers,
Dave.
--
Dave Chinner
da...@fromorbit.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel
left, so somewhere below of XFS there a lot more stack being
consumed in the IO path on 3.13. I'll do some more tracing of this
to try to find out where it is all going
Cheers,
Dave.
--
Dave Chinner
da...@fromorbit.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel
On Wed, Dec 04, 2013 at 08:59:40AM +1100, Dave Chinner wrote:
Hi Jens,
Not sure who to direct this to or CC, so I figured you are the
person to do that. I just had xfstests generic/299 (an AIO/DIO test)
oops in dio_complete() like so:
[ 9650.586724] general protection fault: [#1] SMP
On Wed, Dec 04, 2013 at 12:58:38PM +1100, Dave Chinner wrote:
On Wed, Dec 04, 2013 at 08:59:40AM +1100, Dave Chinner wrote:
Hi Jens,
Not sure who to direct this to or CC, so I figured you are the
person to do that. I just had xfstests generic/299 (an AIO/DIO test)
oops in dio_complete
On Tue, Dec 03, 2013 at 08:47:12PM -0700, Jens Axboe wrote:
On Wed, Dec 04 2013, Dave Chinner wrote:
On Wed, Dec 04, 2013 at 12:58:38PM +1100, Dave Chinner wrote:
On Wed, Dec 04, 2013 at 08:59:40AM +1100, Dave Chinner wrote:
Hi Jens,
Not sure who to direct this to or CC, so I
situations
Cheers,
Dave.
--
Dave Chinner
da...@fromorbit.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
On Tue, Dec 03, 2013 at 04:15:57PM +0400, Vladimir Davydov wrote:
On 12/03/2013 02:48 PM, Dave Chinner wrote:
@@ -236,11 +236,17 @@ shrink_slab_node(struct shrink_control *shrinkctl,
struct shrinker *shrinker,
return 0;
/*
- * copy the current shrinker scan count
On Wed, Dec 04, 2013 at 03:17:49PM +1100, Dave Chinner wrote:
On Tue, Dec 03, 2013 at 08:47:12PM -0700, Jens Axboe wrote:
On Wed, Dec 04 2013, Dave Chinner wrote:
On Wed, Dec 04, 2013 at 12:58:38PM +1100, Dave Chinner wrote:
On Wed, Dec 04, 2013 at 08:59:40AM +1100, Dave Chinner wrote
On Wed, Dec 04, 2013 at 08:41:43PM -0700, Jens Axboe wrote:
On Thu, Dec 05 2013, Dave Chinner wrote:
On Wed, Dec 04, 2013 at 03:17:49PM +1100, Dave Chinner wrote:
On Tue, Dec 03, 2013 at 08:47:12PM -0700, Jens Axboe wrote:
On Wed, Dec 04 2013, Dave Chinner wrote:
On Wed, Dec 04
On Wed, Dec 04, 2013 at 10:31:32AM +0400, Vladimir Davydov wrote:
On 12/04/2013 08:51 AM, Dave Chinner wrote:
On Tue, Dec 03, 2013 at 04:15:57PM +0400, Vladimir Davydov wrote:
On 12/03/2013 02:48 PM, Dave Chinner wrote:
@@ -236,11 +236,17 @@ shrink_slab_node(struct shrink_control *shrinkctl
On Tue, Dec 03, 2013 at 04:29:14PM +0400, Vladimir Davydov wrote:
On 12/03/2013 03:18 PM, Dave Chinner wrote:
On Mon, Dec 02, 2013 at 03:19:45PM +0400, Vladimir Davydov wrote:
FS-shrinkers, which shrink dcaches and icaches, keep dentries and inodes
in list_lru structures in order to evict
On Thu, Dec 05, 2013 at 10:22:20PM +0800, Ming Lei wrote:
On Wed, 4 Dec 2013 12:58:38 +1100
Dave Chinner da...@fromorbit.com wrote:
And I just hit this from running xfs_repair which is doing
multithreaded direct IO directly on /dev/vdc:
.
So this is looking like another virtio
On Fri, Dec 06, 2013 at 08:26:51AM +1100, Dave Chinner wrote:
On Thu, Dec 05, 2013 at 10:22:20PM +0800, Ming Lei wrote:
On Wed, 4 Dec 2013 12:58:38 +1100
Dave Chinner da...@fromorbit.com wrote:
And I just hit this from running xfs_repair which is doing
multithreaded direct IO
On Wed, Mar 12, 2014 at 07:15:03AM +0100, Peter Zijlstra wrote:
On Wed, Mar 12, 2014 at 01:31:53PM +1100, Dave Chinner wrote:
With the queuing spinlock, I expected to see somewhat better
results, but I didn't at first. Turns out if you have any sort of
lock debugging turned
|1 -
fs/xfs/xfs_iops.c| 16
fs/xfs/xfs_log_cil.c | 19 +++
fs/xfs/xfs_mount.c | 24
fs/xfs/xfs_sb.c | 10 --
5 files changed, 43 insertions(+), 27 deletions(-)
--
Dave Chinner
da...@fromorbit.com
into the reserve pool as it has much more important uses...
You don' tneed to resent the entire patch for this - I can remove it
directly myself
Otherwise it looks good, so consider it
Reviewed-by: Dave Chinner dchin...@redhat.com
Cheers,
Dave.
--
Dave Chinner
da...@fromorbit.com
, is likely
to only happen if the DVR/NLE application is buggy. Hence I think
that telling the application it is doing something that is likely to
be wrong is better than silently truncating the file
Cheers,
Dave.
--
Dave Chinner
da...@fromorbit.com
--
To unsubscribe from this list: send the line
by extent splitting.
*/
You're more than welcome to do that, Ted. Just wait until we get the
VFS part into the XFS tree first ;)
Cheers,
Dave.
--
Dave Chinner
da...@fromorbit.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord
On Wed, Feb 19, 2014 at 01:37:16AM +0900, Namjae Jeon wrote:
From: Namjae Jeon namjae.j...@samsung.com
This patch series is in response of the following post:
http://lwn.net/Articles/556136/
ext4: introduce two new ioctls
Dave chinner suggested that truncate_block_range
(which was one
On Tue, Feb 25, 2014 at 02:16:01PM +1100, Stephen Rothwell wrote:
Hi Dave,
On Mon, 24 Feb 2014 11:57:10 +1100 Dave Chinner da...@fromorbit.com wrote:
Namjae Jeon (10):
fs: Add new flag(FALLOC_FL_COLLAPSE_RANGE) for fallocate
xfs: Add support FALLOC_FL_COLLAPSE_RANGE
On Tue, Feb 25, 2014 at 03:23:35PM -0800, Hugh Dickins wrote:
On Tue, 25 Feb 2014, Dave Chinner wrote:
On Tue, Feb 25, 2014 at 02:16:01PM +1100, Stephen Rothwell wrote:
On Mon, 24 Feb 2014 11:57:10 +1100 Dave Chinner da...@fromorbit.com
wrote:
Namjae Jeon (10):
fs: Add
On Tue, Feb 25, 2014 at 03:41:28PM -0800, Andrew Morton wrote:
On Tue, 25 Feb 2014 15:23:35 -0800 (PST) Hugh Dickins hu...@google.com
wrote:
On Tue, 25 Feb 2014, Dave Chinner wrote:
On Tue, Feb 25, 2014 at 02:16:01PM +1100, Stephen Rothwell wrote:
On Mon, 24 Feb 2014 11:57:10 +1100
On Tue, Feb 25, 2014 at 03:41:20PM -0800, Hugh Dickins wrote:
On Mon, 24 Feb 2014, Dave Chinner wrote:
On Sat, Feb 22, 2014 at 09:06:25AM -0500, Theodore Ts'o wrote:
On Wed, Feb 19, 2014 at 01:37:43AM +0900, Namjae Jeon wrote:
+ /*
+* There is no need to overlap
On Tue, Feb 25, 2014 at 05:52:16PM -0800, Andrew Morton wrote:
On Wed, 26 Feb 2014 12:34:26 +1100 Dave Chinner da...@fromorbit.com wrote:
On Tue, Feb 25, 2014 at 03:41:28PM -0800, Andrew Morton wrote:
On Tue, 25 Feb 2014 15:23:35 -0800 (PST) Hugh Dickins hu...@google.com
wrote
On Tue, Feb 25, 2014 at 08:45:15PM -0800, Hugh Dickins wrote:
On Wed, 26 Feb 2014, Dave Chinner wrote:
On Tue, Feb 25, 2014 at 03:23:35PM -0800, Hugh Dickins wrote:
Of course I'm interested in the possibility of extending it to tmpfs;
which may not be a worthwhile exercise in itself
On Tue, Feb 25, 2014 at 09:25:40PM -0800, Hugh Dickins wrote:
On Wed, 26 Feb 2014, Dave Chinner wrote:
On Tue, Feb 25, 2014 at 03:41:20PM -0800, Hugh Dickins wrote:
On Mon, 24 Feb 2014, Dave Chinner wrote:
On Sat, Feb 22, 2014 at 09:06:25AM -0500, Theodore Ts'o wrote:
On Wed, Feb 19
On Wed, Feb 26, 2014 at 03:08:58PM -0800, Hugh Dickins wrote:
On Wed, 26 Feb 2014, Dave Chinner wrote:
On Tue, Feb 25, 2014 at 08:45:15PM -0800, Hugh Dickins wrote:
On Wed, 26 Feb 2014, Dave Chinner wrote:
On Tue, Feb 25, 2014 at 03:23:35PM -0800, Hugh Dickins wrote:
I should
);
return AOP_WRITEPAGE_ACTIVATE;
redirty_page_for_writepage()?
Cheers,
Dave.
--
Dave Chinner
da...@fromorbit.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
else can make
a mess after that
Oh, and when pasting stack traces - turn off line wrapping ;)
Cheers,
Dave.
--
Dave Chinner
da...@fromorbit.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info
the misunderstandings about what get_block() actually does
and returns so it works correctly with XFS.
I need to port it forward to your new patch set (hopefully later
this week), so don't spend too much time trying to work out exactly
what this code needs to do...
Cheers,
Dave.
--
Dave Chinner
da
.
Yes, the increase in context switches is expected. Every sync IO
causes a log force if it changed inode metadata, and the above
commit, as it describes, moves them to a work queue. Hence there's
more context switches involved in a log force that has to do work.
Cheers,
Dave.
--
Dave Chinner
da
On Mon, Mar 03, 2014 at 04:07:35PM -0700, Ross Zwisler wrote:
On Mon, 3 Mar 2014, Dave Chinner wrote:
On Fri, Feb 28, 2014 at 03:20:31PM -0500, Matthew Wilcox wrote:
On Fri, Feb 28, 2014 at 10:49:31AM -0700, Toshi Kani wrote:
The original code,
xip_file_fault(), jumps to found
this information with the graphs
rather than just dumping unlabelled data on people ;)
Cheers,
Dave.
--
Dave Chinner
da...@fromorbit.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
[ 64.992006] [81cef652] system_call_fastpath+0x16/0x1b
So either this patchset doesn't work right now, or there's something
else broken in the tip/master tree...
Cheers,
Dave.
--
Dave Chinner
da...@fromorbit.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body
On Tue, Mar 11, 2014 at 11:11:59PM -0400, Steven Rostedt wrote:
On Wed, 12 Mar 2014 13:31:53 +1100
Dave Chinner da...@fromorbit.com wrote:
So either this patchset doesn't work right now, or there's something
else broken in the tip/master tree...
I've found a few things broken
-by: Linus Torvalds torva...@linux-foundation.org
Cheers,
Dave.
--
Dave Chinner
da...@fromorbit.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Feb 12, 2014 at 06:18:29PM +1100, Dave Chinner wrote:
It looks like just do_signal() has a stack frame that is about 230
bytes even under normal circumstancs (largely due to struct ksignal
- which in turn is largely due to the insane 128-byte padding in
siginfo_t). Add a few other
On Thu, Feb 13, 2014 at 03:34:19PM -0800, Christian Kujau wrote:
On Fri, 14 Feb 2014 at 09:26, Dave Chinner wrote:
after upgrading from 3.13-rc8 to 3.14.0-rc2 on this PowerPC G4 machine,
the WARNING below was printed.
Shortly after, a lockdep warning appeared (possibly related to my
301 - 400 of 3916 matches
Mail list logo
