Re: [PATCH 1/4] build system: section garbage collection for vmlinux

2007-09-12 Thread Denys Vlasenko
On Tuesday 11 September 2007 22:47, Daniel Walker wrote: On Tue, 2007-09-11 at 21:07 +0100, Denys Vlasenko wrote: This patch is needed for --gc-sections to work, regardless of which final form that support will have. This patch renames .text.xxx and .data.xxx sections into .xxx.text

Re: [PATCH 0/4] build system: section garbage collection for vmlinux

2007-09-12 Thread Denys Vlasenko
On Tuesday 11 September 2007 22:03, Andi Kleen wrote: Denys Vlasenko [EMAIL PROTECTED] writes:    text    data     bss     dec     hex filename 5159478 1005139  406784 6571401  644589 linux-2.6.23-rc4.org/vmlinux 5131822  996090  401439 6529351  63a147 linux-2.6.23-rc4.gc/vmlinux

[PATCH 1/2] section garbage collection for i386

2007-09-12 Thread Denys Vlasenko
Hi Sam, This patch is preparatory: it adds a few KEEP() directives where I forgot them in previous patch set, adds comments which explains places where KEEP() is definitely not needed, and fixes i386 vdso generation in an obviously safe way. Please apply. Signed-off-by: Denys Vlasenko [EMAIL

[PATCH 2/2] section garbage collection for i386

2007-09-12 Thread Denys Vlasenko
is analogous to last patch of first series - run-tested and looks safe, but needs to go into -mm first. Signed-off-by: Denys Vlasenko [EMAIL PROTECTED] -- vda diff -urpN linux-2.6.23-rc4.gc5/arch/i386/kernel/modules.lds linux-2.6.23-rc4.gc6/arch/i386/kernel/modules.lds --- linux-2.6.23-rc4.gc5/arch/i386

[PATCH 3/2] section garbage collection for i386 - BONUS TRACK

2007-09-12 Thread Denys Vlasenko
, maybe statistically it will have a bit less alignment padding because I placed together a few page-aligned chunks, but that's all). Signed-off-by: Denys Vlasenko [EMAIL PROTECTED] -- vda diff -urpN linux-2.6.23-rc4.gc6/arch/i386/kernel/vmlinux.lds.S linux-2.6.23-rc4.gc7/arch/i386/kernel

[PATCH] module.c: add missing ifdefs for CONFIG_UNUSED_SYMBOLS

2007-09-13 Thread Denys Vlasenko
is compile tested with various combinations of CONFIGs. Please put it into -mm. Signed-off-by: Denys Vlasenko [EMAIL PROTECTED] -- vda --- linux-2.6.23-rc6/include/linux/module.h Wed Sep 12 22:35:32 2007 +++ linux-2.6.23-rc6.structmodule/include/linux/module.h Thu Sep 13 10:04:33 2007 @@ -264,28 +264,30

Re: [PATCH] module.c: add missing ifdefs for CONFIG_UNUSED_SYMBOLS

2007-09-13 Thread Denys Vlasenko
On Friday 14 September 2007 00:00, Andrew Morton wrote: In short, patch makes trivial changes which are obviously correct (famous last words). The intent seems reasonable. Would have preferred separate patches for the separate things though.. This: akpm:/usr/src/25 grep '^+#'

drivers/usb/misc/emi*.c have the biggest data objects in the whole tree

2007-09-14 Thread Denys Vlasenko
Hi Tapio, You are the author of these files. Are you still maintaining them? If not, do you know who is the current maintainer? These two object files hold the biggest data objects in the whole Linux kernel after lockdep: textdata bss dec hex filename 1258 160516 0

[PATCH] add consts where appropriate in sound/pci/hda/*

2007-09-14 Thread Denys Vlasenko
declarations in hda_patch.h The rest of the patch (bulk of it) adds const in many places. Patch is compile tested. Please apply. Signed-off-by: Denys Vlasenko [EMAIL PROTECTED] -- vda constify_hda_codec.diff.bz2 Description: BZip2 compressed data

Re: [PATCH] add consts where appropriate in sound/pci/hda/*

2007-09-14 Thread Denys Vlasenko
On Friday 14 September 2007 19:09, Joe Perches wrote: On Fri, 2007-09-14 at 18:48 +0100, Denys Vlasenko wrote: Patch is attached. The SND_HDA_PRESETS define doesn't seem useful. It's only used once. It is defined in .h file and used in .c file. It is made so because defining static data

[PATCH] add consts where appropriate in fs/nls/*

2007-09-14 Thread Denys Vlasenko
-by: Denys Vlasenko [EMAIL PROTECTED] -- vda constify_fs_nls.diff.bz2 Description: BZip2 compressed data

Re: [PATCH] add consts where appropriate in sound/pci/hda/*

2007-09-14 Thread Denys Vlasenko
On Friday 14 September 2007 18:48, Denys Vlasenko wrote: There is a lot of data structures in that code, and most of them seems to be read-only. I added const modifiers to most of such places: textdata bss dec hex filename 106315 179564 36 285915 45cdb snd-hda

Re: [PATCH] add consts where appropriate in sound/pci/hda/*

2007-09-15 Thread Denys Vlasenko
On Saturday 15 September 2007 11:29, Jan Engelhardt wrote: On Sep 15 2007 12:18, Sam Ravnborg wrote: textdata bss dec hex filename 106315 179564 36 285915 45cdb snd-hda-intel.o 2830512624 36 285711 45c0f snd-hda-intel_patched.o This is kinda

Re: [PATCH] add consts where appropriate in sound/pci/hda/*

2007-09-15 Thread Denys Vlasenko
On Saturday 15 September 2007 13:40, Andreas Schwab wrote: Denys Vlasenko [EMAIL PROTECTED] writes: ELF is not as rigid as old a.out (which had only one text, one data and one bss segment per .o file IIRC), but size was born in a.out days, so it sort of translates ELF into a.out. Try

Re: Per option CFLAGS?

2007-09-15 Thread Denys Vlasenko
On Saturday 15 September 2007 16:17, Rene Herman wrote: On 09/15/2007 10:47 AM, Adrian Bunk wrote: The stub source file is usually considered a good way to do this. Mmm. If I'll have to live with it, I can, but thought I'd ask if there was some nice build trickery available instead.

Re: [PATCH] add consts where appropriate in sound/pci/hda/*

2007-09-17 Thread Denys Vlasenko
struct hda_codec_preset snd_hda_preset_analog[] are checked to match declarations in hda_patch.h The rest of the patch (bulk of it) adds const in many places. Patch is compile tested. Please apply. Signed-off-by: Denys Vlasenko [EMAIL PROTECTED] Sorry for the late reply. First

alternatives in modules

2007-09-18 Thread Denys Vlasenko
Hi Mathieu, I was looking through kernel/module.c and if understand it correctly, it doesn't handle .altinstructions in modules at all. Am I reading code correctly? -- vda - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More

bnx2 dirver's firmware images

2007-09-18 Thread Denys Vlasenko
Hi Michael, In bnx2_fw.h I see the following: static u32 bnx2_RXP_b06FwBss[(0x13dc/4) + 1] = { 0x0 }; static struct fw_info bnx2_rxp_fw_06 = { ... .bss= bnx2_RXP_b06FwBss, ... }; I grepped for the usage of .bss member (grepped for '[.]bss[^_]') and it is

Re: [patch 1/7] Immediate Values - Architecture Independent Code

2007-09-18 Thread Denys Vlasenko
On Monday 17 September 2007 19:42, Mathieu Desnoyers wrote: Index: linux-2.6-lttng/include/asm-generic/vmlinux.lds.h === --- linux-2.6-lttng.orig/include/asm-generic/vmlinux.lds.h2007-09-17 13:25:06.0 -0400 +++

Re: bnx2 dirver's firmware images

2007-09-18 Thread Denys Vlasenko
On Tuesday 18 September 2007 19:45, Michael Chan wrote: We can compress all the different sections of the firmware. Currently, we only compress the biggest chunks and the rest are uncompressed. These zeros should compress to almost nothing. But I agree that the firmware is still big. You

Re: [patch 1/7] Immediate Values - Architecture Independent Code

2007-09-18 Thread Denys Vlasenko
On Tuesday 18 September 2007 18:59, Mathieu Desnoyers wrote: * Denys Vlasenko ([EMAIL PROTECTED]) wrote: On Monday 17 September 2007 19:42, Mathieu Desnoyers wrote: Index: linux-2.6-lttng/include/asm-generic/vmlinux.lds.h

Re: bnx2 dirver's firmware images

2007-09-19 Thread Denys Vlasenko
230a3 net.org/bnx2.o Signed-off-by: Denys Vlasenko [EMAIL PROTECTED] -- vda --- linux-2.6.23-rc6.org/drivers/net/bnx2.c Tue Sep 11 22:33:54 2007 +++ linux-2.6.23-rc6.gunzip/drivers/net/bnx2.c Wed Sep 19 00:01:19 2007 @@ -2767,93 +2767,61 @@ spin_unlock_bh(bp-phy_lock); } -#define FW_BUF_SIZE

Re: [patch 1/7] Immediate Values - Architecture Independent Code

2007-09-19 Thread Denys Vlasenko
On Tuesday 18 September 2007 21:47, Mathieu Desnoyers wrote: * Denys Vlasenko ([EMAIL PROTECTED]) wrote: On Tuesday 18 September 2007 18:59, Mathieu Desnoyers wrote: * Denys Vlasenko ([EMAIL PROTECTED]) wrote: On Monday 17 September 2007 19:42, Mathieu Desnoyers wrote: Index: linux

Re: [patch 1/7] Immediate Values - Architecture Independent Code

2007-09-19 Thread Denys Vlasenko
On Tuesday 18 September 2007 21:47, Mathieu Desnoyers wrote: * Denys Vlasenko ([EMAIL PROTECTED]) wrote: On Tuesday 18 September 2007 18:59, Mathieu Desnoyers wrote: * Denys Vlasenko ([EMAIL PROTECTED]) wrote: On Monday 17 September 2007 19:42, Mathieu Desnoyers wrote: Index: linux

Re: [patch 1/4] Linux Kernel Markers - Architecture Independent Code

2007-09-19 Thread Denys Vlasenko
On Wednesday 19 September 2007 12:37, Mathieu Desnoyers wrote: Index: linux-2.6-lttng/include/asm-generic/vmlinux.lds.h === --- linux-2.6-lttng.orig/include/asm-generic/vmlinux.lds.h 2007-09-14 10:11:18.0 -0400 +++

Re: bnx2 dirver's firmware images

2007-09-19 Thread Denys Vlasenko
On Wednesday 19 September 2007 22:00, Michael Chan wrote: On Wed, 2007-09-19 at 09:30 +0100, Denys Vlasenko wrote: + /* gzip header (1f,8b,08... 10 bytes total + possible asciz filename) +* is stripped, 32-bit unpacked size (LE) is prepended instead */ + sz = *zbuf

Re: [patch 1/4] Linux Kernel Markers - Architecture Independent Code

2007-09-19 Thread Denys Vlasenko
On Wednesday 19 September 2007 14:53, Frank Ch. Eigler wrote: Mathieu Desnoyers [EMAIL PROTECTED] writes: [...] Do you think I should also remove the __markers_strings section from here ? Current systemtap marker support code relies on the __markers_strings section. Let users know

Re: [patch 4/7] Immediate Values - i386 Optimization

2007-09-20 Thread Denys Vlasenko
On Tuesday 18 September 2007 22:07, Mathieu Desnoyers wrote: i386 optimization of the immediate values which uses a movl with code patching to set/unset the value used to populate the register used as variable source. Changelog: - Use text_poke_early with cr0 WP save/restore to patch the

Re: [patch 7/8] Immediate Values - Documentation

2007-09-20 Thread Denys Vlasenko
On Monday 27 August 2007 16:59, Mathieu Desnoyers wrote: +We can therefore affirm that adding 2 markers to getppid, on a system with high +memory pressure, would have a performance hit of at least 6.0% on the system +call time, all within the uncertainty limits of these tests. The same

arch/x86_64/kernel/Makefile: why EXTRA_AFLAGS := -traditional

2007-09-20 Thread Denys Vlasenko
Hi Andi, arch/x86_64/kernel/Makefile has EXTRA_AFLAGS := -traditional and this is causing me trouble with #define MACRO(a,b) a.b (defined in one of included header file). It expands incorrectly, as a. b - extra space. If I use a.##b, all other .S files suffer - I am getting a.##b expansion in

Re: bnx2 dirver's firmware images

2007-09-20 Thread Denys Vlasenko
On Wednesday 19 September 2007 22:43, Michael Chan wrote: On Wed, 2007-09-19 at 21:29 +0100, Denys Vlasenko wrote: Are you saying that you successfully run-tested it? I've only reviewed the code. Let's resolve these issues first before testing the code. Please test these two patches. I

Re: [PATCH -mm] sb16: Shut up uninitialized var build warning

2007-09-20 Thread Denys Vlasenko
On Sunday 02 September 2007 23:06, Rene Herman wrote: On 09/02/2007 10:15 PM, Satyam Sharma wrote: sound/isa/sb16/sb16.c: In function ‘snd_sb16_isa_probe’: Blah. Your message has: Content-Type: TEXT/PLAIN; charset=iso-2022-jp This apparently is caused by a combination of GCC

Re: Strage buffer behaviour

2007-11-12 Thread Denys Vlasenko
On Sunday 11 November 2007 11:33, Tino Keitel wrote: The dd command reads 100 MB from each partition two times in a row. It looks like sda1 and sda2 are not bufferd (the first 4 dd runs), but sda3 and sda4 are (the last 4 dd runs). The computer is a Mac mini with a 2,5 SATA hard disk. The

Re: [BUG] New Kernel Bugs

2007-11-13 Thread Denys Vlasenko
On Tuesday 13 November 2007 07:08, Mark Lord wrote: Ingo Molnar wrote: .. This is all QA-101 that _cannot be argued against on a rational basis_, it's just that these sorts of things have been largely ignored for years, in favor of the all-too-easy open source means many eyeballs and

Re: [BUG] New Kernel Bugs

2007-11-13 Thread Denys Vlasenko
On Tuesday 13 November 2007 10:56, Adrian Bunk wrote: On Tue, Nov 13, 2007 at 12:13:56PM -0500, Theodore Tso wrote: On Tue, Nov 13, 2007 at 04:52:32PM +0100, Benoit Boissinot wrote: Btw, I used to test every -mm kernel. But since I've switched distros (gentoo-ubuntu) and I have less

Re: [BUG] New Kernel Bugs

2007-11-13 Thread Denys Vlasenko
On Tuesday 13 November 2007 11:57, Gabriel C wrote: The main problem is finding experienced developers who spend time on looking into bug reports. There are already. IMO the problem is the development model. There are tons new features in each new kernel release and 'tons new bugs' which

Re: [BUG] New Kernel Bugs

2007-11-13 Thread Denys Vlasenko
On Wednesday 14 November 2007 00:27, Adrian Bunk wrote: You missed the following in my email: we slowly scare them away due to the many bug reports without any reaction. The problem is that bug reports take time. If you go away from easy things like compile errors then even things like

Re: [BUG] New Kernel Bugs

2007-11-14 Thread Denys Vlasenko
hi Matthew, On Wednesday 14 November 2007 06:35, Hannes Reinecke wrote: Matthew Wilcox wrote: On Wed, Nov 14, 2007 at 12:46:20AM -0700, Denys Vlasenko wrote: Finally they replied and asked to rediff it against their git tree. I did that and sent patches back. No reply since

Re: [PATCH] CRISv10 fasttimer: Scrap INLINE and name timeval_cmp better

2007-11-14 Thread Denys Vlasenko
On Wednesday 14 November 2007 09:08, Jesper Nilsson wrote: Scrap the local __INLINE__ macro, and rename timeval_cmp to fasttime_cmp. Inline macro was completely unnecessary since the macro was defined locally to be inline. timeval_cmp was inaccurately named since it does comparison on struct

Re: [PATCH] intel-iommu fixes

2007-11-15 Thread Denys Vlasenko
On Sunday 28 October 2007 21:51, Al Viro wrote: -#define MAX_FAULT_REASON_IDX ARRAY_SIZE(fault_reason_strings) +#define MAX_FAULT_REASON_IDX ARRAY_SIZE(fault_reason_strings) - 1 The macro is unsafe without yet another ()s around it. -- vda - To unsubscribe from this list: send

Re: [patch] Printk kernel version in WARN_ON

2007-11-17 Thread Denys Vlasenko
On Saturday 17 November 2007 10:15, Arjan van de Ven wrote: Hi, #define WARN_ON(condition) ({ \ int __ret_warn_on = !!(condition); \ if (unlikely(__ret_warn_on)) { \ -

[PATCH] printk.c: use ints instead of longs for logbuf index

2007-11-18 Thread Denys Vlasenko
on amd64: textdata bss dec hex filename 5997 313 17736 240465dee 2.6.23.1.t64/kernel/printk.o 5858 313 17700 238715d3f 2.6.23.1.printk.t64/kernel/printk.o Please take this patch into -mm. Signed-off-by: Denys Vlasenko [EMAIL PROTECTED] -- vda diff -urpN

Re: [BUG] USB_PERSIST

2007-11-18 Thread Denys Vlasenko
On Sunday 18 November 2007 20:14, Raymano Garibaldi wrote: In kernel 2.6.23.8 USB_PERSIST feature does not work if the same USB device is detached and reattached while computer is suspended. The mount points for the USB storage device mounted before suspend are lost and the device has to be

[PATCH] smallint: minimum efficiently addressable memory unit

2007-12-17 Thread Denys Vlasenko
unit. * Recommended usage: global flag or enum variables; flag/enum struct members * Don't use for: local variables, members of user-visible structs * Guaranteed to be at least byte-sized. */ Comments from architecture people are sought. Signed-off-by: Denys Vlasenko [EMAIL PROTECTED] -- vda

Re: [PATCH 4/8] unify paravirt parts of system.h

2007-12-04 Thread Denys Vlasenko
On Tuesday 04 December 2007 11:41, Glauber de Oliveira Costa wrote: On Dec 4, 2007 5:18 PM, Avi Kivity [EMAIL PROTECTED] wrote: There is no cr8 register on i386. This had better be protected by an #ifdef. Sure. I mentioned it in the changelog. I, however, am not sure If I agree it should

[PATCH 0/3] build system: section garbage collection

2007-11-24 Thread Denys Vlasenko
Hi Sam, On Sunday 18 November 2007 15:00, Sam Ravnborg wrote: On Tue, Sep 11, 2007 at 09:05:33PM +0100, Denys Vlasenko wrote: Build system: section garbage collection for vmlinux Newer gcc and binutils can do dead code and data removal at link time. It is achieved using combination

[PATCH 2/3] build system: section garbage collection - modpost fix

2007-11-24 Thread Denys Vlasenko
On Saturday 24 November 2007 15:14, Denys Vlasenko wrote: 2.modpost Update scripts/mod/* machinery to correctly handle the case when we have more than 64k sections. Signed-off-by: Denys Vlasenko [EMAIL PROTECTED] -- vda diff -urpN linux-2.6.gc1/scripts/mod/file2alias.c linux-2.6.gc2

[PATCH 3/3] build system: section garbage collection - main part

2007-11-24 Thread Denys Vlasenko
On Saturday 24 November 2007 15:14, Denys Vlasenko wrote: 3.gc The meat of the patchset is here. Introduce config option DISCARD_UNUSED_SECTIONS. If it is selected: Pass -ffunction-sections -fdata-sections to gcc and --gc-sections --print-gc-sections to ld. Use arch

Re: [RFC] Documentation about unaligned memory access

2007-11-25 Thread Denys Vlasenko
On Thursday 22 November 2007 16:15, Daniel Drake wrote: In summary: if your code causes unaligned memory accesses to happen, your code will not work on some platforms, and will perform *very* badly on others. Although understanding alignment is important, there is another extreme - what I call

Re: [PATCH 23/27] x86: debugctlmsr kconfig

2007-11-25 Thread Denys Vlasenko
On Sunday 25 November 2007 14:08, Roland McGrath wrote: This adds the (internal) Kconfig macro CONFIG_X86_DEBUGCTLMSR, to be defined when configuring to support only hardware that definitely supports MSR_IA32_DEBUGCTLMSR with the BTF flag. The Intel documentation says P6 family and later

Re: forcedeth ethernet driver Low power state

2007-11-25 Thread Denys Vlasenko
On Sunday 25 November 2007 10:59, Jeroen wrote: On Nov 25, 2007 7:36 PM, Robert Hancock [EMAIL PROTECTED] wrote: Are you sure forcedeth even supports that feature? I haven't seen any code for it, and certainly it should never be enabled by default.. The windows driver does. I have to

Re: [PATCH 23/27] x86: debugctlmsr kconfig

2007-11-26 Thread Denys Vlasenko
On Sunday 25 November 2007 23:51, Roland McGrath wrote: Why is it defined in configuration system instead of some *.h file? That seems to be existing practice for this sort of thing. I just followed what I saw. I think that if such conditional constants can be defined in header files (IOW:

Re: [PATCH -mm] printk trivial optimizations fix

2007-11-28 Thread Denys Vlasenko
On Wednesday 28 November 2007 11:02, Hugh Dickins wrote: mm's printk has been showing %p in abominable upper case recently: its trivial optimizations have changed the default from lower to upper, so the 'p' case needs to enforce lower explicitly. Signed-off-by: Hugh Dickins [EMAIL PROTECTED]

[PATCH] net/ipv4/netfilter/ip_tables.c: remove some inlines

2007-12-16 Thread Denys Vlasenko
are performance critical. Result as reported by size: textdata bss dec hex filename - 6451 380 8869191b07 ip_tables.o + 6339 348 7267591a67 ip_tables.o Please take this patch into netfilter queue. Signed-off-by: Denys Vlasenko [EMAIL PROTECTED

Re: [PATCH] net/ipv4/netfilter/ip_tables.c: remove some inlines

2007-12-26 Thread Denys Vlasenko
On Monday 17 December 2007 14:47, Patrick McHardy wrote: Please CC netfilter-devel on netfilter patches. Denys Vlasenko wrote: Hi Patrick, Harald, I was working on unrelated problem and noticed that ip_tables.c seem to abuse inline. I prepared a patch which removes inlines except

[PATCH] ip[6]_tables.c: remove some inlines

2007-12-31 Thread Denys Vlasenko
and thus are performance-critical. Please take this patch into netfilter queue. Signed-off-by: Denys Vlasenko [EMAIL PROTECTED] -- vda diff --git a/net/ipv4/netfilter/ip_tables.c b/net/ipv4/netfilter/ip_tables.c index f5b66ec..982b7f9 100644 --- a/net/ipv4/netfilter/ip_tables.c +++ b/net/ipv4

Re: [PATCH] ip[6]_tables.c: remove some inlines

2007-12-31 Thread Denys Vlasenko
On Monday 31 December 2007 17:00, Patrick McHardy wrote: Denys Vlasenko wrote: ip[6]_tables.c seem to abuse inline. This patch removes inlines except those which are used by packet matching code and thus are performance-critical. Some people also consider the ruleset replacement

Re: Using -traditional in EXTRA_AFLAGS

2007-10-25 Thread Denys Vlasenko
On Thursday 25 October 2007 16:21, Glauber de Oliveira Costa wrote: is there any particular reason we're using -traditional in EXTRA_AFLAGS in Makefiles? What? Where? I thought I removed them all. Or is this from the x86_64 tree? This is from arch/x86/kernel/Makefile_64 Indeed.

Re: [IDE] Fix build bug

2007-10-30 Thread Denys Vlasenko
On Thursday 25 October 2007 22:41, Bartlomiej Zolnierkiewicz wrote: -static const struct ide_port_info generic_chipsets[] __devinitdata = { +static struct ide_port_info generic_chipsets[] __devinitdata = { /* 0 */ DECLARE_GENERIC_PCI_DEV(Unknown, 0), { /* 1 */ I

Re: [GIT PATCH] final SCSI pieces for the merge window

2007-10-30 Thread Denys Vlasenko
On Wednesday 24 October 2007 15:27, Matthew Wilcox wrote: On Wed, Oct 24, 2007 at 09:28:10AM -0400, James Bottomley wrote: OK, so it's no secret that I'm the last of the subsystem maintainers whose day job isn't working on the linux kernel. If you want a full time person, who did you have

Re: [PATCH 1/4] stringbuf: A string buffer implementation

2007-10-30 Thread Denys Vlasenko
On Tuesday 23 October 2007 22:12, Matthew Wilcox wrote: Consecutive calls to printk are non-atomic, which leads to various implementations for accumulating strings which can be printed in one call. This is a generic string buffer which can also be used for non-printk purposes. There is no

Re: [PATCH] drivers/scsi/lpfc/lpfc_hw.h: Some minor cleanup.

2007-10-30 Thread Denys Vlasenko
On Tuesday 30 October 2007 10:54, Richard Knutsson wrote: Signed-off-by: Richard Knutsson [EMAIL PROTECTED] --- Diffed against linus-git Checked with script/checkpatch.pl diff --git a/drivers/scsi/lpfc/lpfc_hw.h b/drivers/scsi/lpfc/lpfc_hw.h index 451accd..6f56528 100644 ---

Re: [PATCH 2/4 -v5] x86_64 EFI runtime service support: EFI runtime services

2007-10-30 Thread Denys Vlasenko
On Tuesday 30 October 2007 05:55, Huang, Ying wrote: +static inline unsigned long native_get_wallclock(void) +{ + unsigned long retval; + + if (efi_enabled) + retval = efi_get_time(); + else + retval = mach_get_cmos_time(); + + return retval; +}

Re: [PATCH 0/3] debloat aic7xxx and aic79xx drivers

2007-10-18 Thread Denys Vlasenko
Hi Andrew, James, On Monday 15 October 2007 14:53, Gabriel C wrote: Compile tested and applies cleanly to 2.6.23. I don't have this hardware anymore and cannot run test these patches. I can test these patches on an aic7892 controller later on today if you want. Works fine for me

Re: [PATCH] ia64 vDSO vs --build-id

2007-10-19 Thread Denys Vlasenko
On Thursday 18 October 2007 23:11, Roland McGrath wrote: When gcc uses --build-id by default, the gate.lds.S linker script runs afoul of the new note section and produces a bad DSO image. This fixes it. I wonder why we bother having --build-id. -- vda - To unsubscribe from this list: send the

Re: [PATCH] ia64: check-segrel.lds vs --build-id

2007-10-19 Thread Denys Vlasenko
On Thursday 18 October 2007 20:54, Roland McGrath wrote: Some versions of ld with --build-id support will crash when using the flag with a linker script that discards notes. This bites ia64's check-segrel.lds. The bug is easy to avoid. It's fixed in newer ld (not released yet IIRC), but why

Re: libata crash

2007-10-19 Thread Denys Vlasenko
On Friday 19 October 2007 08:05, Jan Dittmer wrote: Jeff Garzik wrote: Building on x86-64, I'm betting? :) I fell victim to the same thing a few days ago, missing some compile breakage that only appeared with make ARCH=i386 allmodconfig make ARCH=i386 -sj9 Though am I

Re: [PATCH 2/4] lib: vsprintf: Optimize division by 10000

2012-09-24 Thread Denys Vlasenko
On Fri, Aug 3, 2012 at 7:21 AM, George Spelvin li...@horizon.com wrote: The same multiply-by-inverse technique can be used to convert division by 1 to a 32x32-64-bit multiply. Signed-off-by: George Spelvin li...@horizon.com --- lib/vsprintf.c | 60

Re: [PATCH 1/4] lib: vsprintf: Optimize division by 10 for small integers.

2012-09-24 Thread Denys Vlasenko
On Fri, Aug 3, 2012 at 7:21 AM, George Spelvin li...@horizon.com wrote: Shrink the reciprocal approximations used in put_dec_full4 based on the comments in put_dec_full9. Signed-off-by: George Spelvin li...@horizon.com Cc: Denys Vlasenko vda.li...@googlemail.com Cc: Michal Nazarewicz min

parisc: orphaned asm/compat_signal.h file?

2012-09-24 Thread Denys Vlasenko
Hi, I noticed the following: In linux-mmotm and parisc-2.6.git trees, arch/parisc/include/asm/compat_signal.h file is just: /* Use generic */ #include asm-generic/compat_signal.h which isn't correct since asm-generic/compat_signal.h doesn't exist. Nobody noticed this because

[PATCH -mm v4 0/4] coredump: add new elf notes: siginfo, mapped files

2012-09-24 Thread Denys Vlasenko
at the moment. Denys Vlasenko (4): coredump: pass siginfo_t* to do_coredump() and below, not merely signr compat: move compat_siginfo_t definition to asm/compat.h coredump: add a new elf note with siginfo of the signal coredump: extend core dump note section to contain file names of mapped

[PATCH -mm v4 1/4] coredump: pass siginfo_t* to do_coredump() and below, not merely signr

2012-09-24 Thread Denys Vlasenko
This is a preparatory patch for the introduction of NT_SIGINFO elf note. With this patch we pass siginfo_t *siginfo instead of int signr to do_coredump() and put it into coredump_params. It will be used by the next patch. Most changes are simple s/signr/siginfo-si_signo/. Signed-off-by: Denys

[PATCH -mm v4 2/4] compat: move compat_siginfo_t definition to asm/compat.h

2012-09-24 Thread Denys Vlasenko
to be replaced by __compat_uid[32]_t. compat_uptr_t had to be moved up before compat_siginfo_t in asm/compat.h on a several architectures (tile already had it moved up). compat_sigval_t had to be relocated from linux/compat.h to asm/compat.h. Signed-off-by: Denys Vlasenko vda.li...@googlemail.com --- arch

[PATCH -mm v4 4/4] coredump: extend core dump note section to contain file names of mapped files

2012-09-24 Thread Denys Vlasenko
This note has the following format: long count -- how many files are mapped long page_size -- units for file_ofs array of [COUNT] elements of long start long end long file_ofs followed by COUNT filenames in ASCII: FILE1 NUL FILE2 NUL... Signed-off-by: Denys Vlasenko vda.li

Re: [PATCH 2/4] lib: vsprintf: Optimize division by 10000

2012-09-24 Thread Denys Vlasenko
On Mon, Sep 24, 2012 at 2:35 PM, George Spelvin li...@horizon.com wrote: Here is the comparison of the x86-32 assembly of the fragment which does x / 1 thing, before and after the patch: -01 c6 add%eax,%esi -b8 59 17 b7 d1 mov$0xd1b71759,%eax -f7 e6

Re: [PATCH 3/4] lib: vsprintf: Optimize put_dec_trunc8

2012-09-25 Thread Denys Vlasenko
On Tue, Sep 25, 2012 at 1:44 PM, George Spelvin li...@horizon.com wrote: Thanks to Denys Vlasenko for sending me his benchmarking code. I went and hacked on it to ransomize the numbers being converted more, since repeatedly converting the same number underestimates the number of branch

[PATCH 1/2] bnx2: factor out gzip unpacker

2007-09-21 Thread Denys Vlasenko
, cursor bitmaps, whatever. Patch is run tested by Michael Chan (driver author). Michael, can you add your ACK? Signed-off-by: Denys Vlasenko [EMAIL PROTECTED] -- vda diff -urpN linux-2.6.23-rc6/drivers/net/bnx2.c linux-2.6.23-rc6.bnx2/drivers/net/bnx2.c --- linux-2.6.23-rc6/drivers/net/bnx2.c

[PATCH 2/2] bnx2: move gzip unpacker to zlib

2007-09-21 Thread Denys Vlasenko
On Friday 21 September 2007 12:01, Denys Vlasenko wrote: I will move this code out of the driver and into zlib in follow-on patch. No, I won't. I accidentally attached both patches to first email, you can find it there. Sorry. -- vda - To unsubscribe from this list: send the line unsubscribe

Re: [patch 7/8] Immediate Values - Documentation

2007-09-21 Thread Denys Vlasenko
On Friday 21 September 2007 14:31, Mathieu Desnoyers wrote: Immediates make code bigger, right? Nope. Example: char x; void testb(void) { if (x 5) testa(); } Would turn into: 56: b0 00 mov$0x0,%al 58: 3c 05

Re: [PATCH 1/2] bnx2: factor out gzip unpacker

2007-09-21 Thread Denys Vlasenko
On Friday 21 September 2007 17:14, David Miller wrote: From: Denys Vlasenko [EMAIL PROTECTED] Date: Fri, 21 Sep 2007 12:01:24 +0100 Hi Jeff, BNX2 and TG3 patches goes through Michael Chan and myself, and I usually merge them in instead of Jeff. Didn't know that, sorry. Do patches look

Re: [PATCH 1/2] bnx2: factor out gzip unpacker

2007-09-21 Thread Denys Vlasenko
On Friday 21 September 2007 18:49, David Miller wrote: From: Denys Vlasenko [EMAIL PROTECTED] Date: Fri, 21 Sep 2007 18:03:55 +0100 Do patches look ok to you? I'm travelling so I haven't looked closely yet :-) Michael can take a look and I'll try to do so as well tonight. Good. I

Re: [PATCH 1/2] bnx2: factor out gzip unpacker

2007-09-21 Thread Denys Vlasenko
On Friday 21 September 2007 19:36, [EMAIL PROTECTED] wrote: On Fri, 21 Sep 2007 19:05:23 BST, Denys Vlasenko said: I plan to use gzip compression on following drivers' firmware, if patches will be accepted: textdata bss dec hex filename 17653 109968 240

Re: [PATCH 1/2] bnx2: factor out gzip unpacker

2007-09-21 Thread Denys Vlasenko
On Friday 21 September 2007 21:13, Andi Kleen wrote: Denys Vlasenko [EMAIL PROTECTED] writes: I plan to use gzip compression on following drivers' firmware, if patches will be accepted: textdata bss dec hex filename 17653 109968 240 127861 1f375 drivers

Re: [PATCH 1/2] bnx2: factor out gzip unpacker

2007-09-21 Thread Denys Vlasenko
On Friday 21 September 2007 20:33, Krzysztof Oledzki wrote: On Fri, 21 Sep 2007, Denys Vlasenko wrote: On Friday 21 September 2007 19:36, [EMAIL PROTECTED] wrote: On Fri, 21 Sep 2007 19:05:23 BST, Denys Vlasenko said: I plan to use gzip compression on following drivers' firmware

Re: drivers/usb/misc/emi*.c have the biggest data objects in the whole tree

2007-09-28 Thread Denys Vlasenko
On Friday 28 September 2007 05:41, Greg KH wrote: On Fri, Sep 14, 2007 at 11:35:34AM +0100, Denys Vlasenko wrote: Hi Tapio, You are the author of these files. Are you still maintaining them? If not, do you know who is the current maintainer? These two object files hold the biggest

Re: F_DUPFD_CLOEXEC implementation

2007-09-29 Thread Denys Vlasenko
Hi Ulrich, On Friday 28 September 2007 18:34, Ulrich Drepper wrote: One more small change to extend the availability of creation of file descriptors with FD_CLOEXEC set. Adding a new command to fcntl() requires no new system call and the overall impact on code size if minimal. Tangential

Re: F_DUPFD_CLOEXEC implementation

2007-09-30 Thread Denys Vlasenko
On Monday 01 October 2007 00:11, Davide Libenzi wrote: On Sun, 30 Sep 2007, Denys Vlasenko wrote: Hi Ulrich, On Friday 28 September 2007 18:34, Ulrich Drepper wrote: One more small change to extend the availability of creation of file descriptors with FD_CLOEXEC set. Adding a new

Re: F_DUPFD_CLOEXEC implementation

2007-10-01 Thread Denys Vlasenko
On Monday 01 October 2007 04:15, Davide Libenzi wrote: On Mon, 1 Oct 2007, Denys Vlasenko wrote: My use case is: I want to do a nonblocking read on descriptor 0 (stdin). It may be a pipe or a socket. There may be other processes which share this descriptor with me, I simply cannot

Re: F_DUPFD_CLOEXEC implementation

2007-10-01 Thread Denys Vlasenko
On Monday 01 October 2007 19:16, Al Viro wrote: * it's on a bunch of cyclic lists. Have its neighbor go away while you are doing all that crap = boom * there's that thing call current position... It gets buggered. * overwriting it while another task might be in the middle

Re: F_DUPFD_CLOEXEC implementation

2007-10-02 Thread Denys Vlasenko
On Monday 01 October 2007 20:04, Davide Libenzi wrote: They don't even need to read in parallel, just having shared fd is enough. Think about pipes, sockets and terminals. A real-world scenario: * a process started from shell (interactive or shell script) * it sets O_NONBLOCK and does a

testers needed for drivers/usb/misc/emi*.c

2007-10-02 Thread Denys Vlasenko
On Tuesday 02 October 2007 17:35, Greg KH wrote: I suggest the following optimizations: Change structure to typedef struct _INTEL_HEX_RECORD { __u8 type; __u8 length; __u16 address; __u8

Re: Strange network related data corruption

2007-10-08 Thread Denys Vlasenko
On Sunday 07 October 2007 17:47, Malte Schröder wrote: Hello, I am encountering some strange data corruption when transferring data from one of my PCs that I use as a file-server. on the server: FILE=large file; | cut -d -f1 | nc -lp5000 -q0; while nc -lp5000 -q0 $FILE; do : ; done $

Re: [PATCH 1/2] Colored kernel output (run2)

2007-10-08 Thread Denys Vlasenko
On Saturday 06 October 2007 20:13, Jan Engelhardt wrote: Colored kernel message output (1/2) This patch makes it possible to give kernel messages a selectable color. It can be chosen at compile time, overridden at boot time, and changed at run time. IMHO: useless bloat. And yes, I've read

Re: Strange network related data corruption

2007-10-09 Thread Denys Vlasenko
On Tuesday 09 October 2007 12:25, Malte Schröder wrote: Does it happen over loopback? I just tried a few times and yes, it also happens on loopback, but much less frequently. Now I am really confused ... Actually, that eliminates a lot of cases. Run memtest86 overnight (bad hardware

Re: Nonblocking call may block in a mutex? Nonblocking call after poll may fail?

2007-08-31 Thread Denys Vlasenko
On Friday 31 August 2007 13:13, anon... anon.al wrote: Hi! This is a driver-related question on non-blocking writes and poll. Setup: there is a single output-buffer (in kernel-space) of 24 bytes for writes from all processes A, B, and C: each process is restricted to use at most 8 bytes:

[PATCH 0/3] debloat aic7xxx and aic79xx drivers

2007-08-31 Thread Denys Vlasenko
On Friday 31 August 2007 14:42, Hannes Reinecke wrote: Jan Engelhardt wrote: On Aug 30 2007 13:02, Matthew Wilcox wrote: Well, you can send it to Linus/Andrew, that will usually upset people and they start commenting on it. Or they don't, and everything is fine. (The default y approach so

[PATCH 1/3] debloat aic7xxx and aic79xx drivers

2007-08-31 Thread Denys Vlasenko
On Friday 31 August 2007 16:13, Denys Vlasenko wrote: Attached are three patches which fix that: textdata bss dec hex filename 261433 500181172 312623 4c52f linux-2.6.23-rc1.org.t/drivers/scsi/aic7xxx/built-in.o 199654 500181172 250844 3d3dc linux

[PATCH 2/3] debloat aic7xxx and aic79xx drivers

2007-08-31 Thread Denys Vlasenko
On Friday 31 August 2007 16:15, Denys Vlasenko wrote: On Friday 31 August 2007 16:13, Denys Vlasenko wrote: Attached are three patches which fix that: textdata bss dec hex filename 261433 500181172 312623 4c52f linux-2.6.23-rc1.org.t/drivers/scsi/aic7xxx

[PATCH 3/3] debloat aic7xxx and aic79xx drivers

2007-08-31 Thread Denys Vlasenko
On Friday 31 August 2007 16:16, Denys Vlasenko wrote: On Friday 31 August 2007 16:15, Denys Vlasenko wrote: On Friday 31 August 2007 16:13, Denys Vlasenko wrote: Attached are three patches which fix that: textdata bss dec hex filename 261433 500181172

Re: 4KSTACKS + DEBUG_STACKOVERFLOW harmful

2007-08-31 Thread Denys Vlasenko
On Friday 31 August 2007 15:35, Jörn Engel wrote: On Fri, 31 August 2007 12:11:25 +0100, Denys Vlasenko wrote: KSYM_NAME_LEN = 128 sounds stupid. The name which is wider than 80 chars?? Kernel shouldn't have names that long. Say, 50 chars ought to be enough. Might be an enforcement

  1   2   3   4   5   6   7   8   9   10   >