Re: [PATCH 11/21] MSI: Consolidate precondition checks

2007-03-27 Thread Eric W. Biederman
Michael Ellerman [EMAIL PROTECTED] writes: Consolidate precondition checks into a single if statement. Acked-by: Eric W. Biederman [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH 12/21] MSI: Leave MSI-X masking to the irq chip

2007-03-27 Thread Eric W. Biederman
Michael Ellerman [EMAIL PROTECTED] writes: When freeing an MSI-X in msi_free_irq(), the irq must have already been free'd (otherwise we'd hit the BUG_ON), and in the process will have been masked or otherwise disabled by the irq chip methods. So there's no reason to mask again in the MSI

Re: [PATCH 14/21] MSI: Use a list instead of the custom link structure

2007-03-27 Thread Eric W. Biederman
Michael Ellerman [EMAIL PROTECTED] writes: The msi descriptors are linked together with what looks a lot like a linked list, but isn't a struct list_head list. Make it one. The only complication is that previously we walked a list of irqs, and got the descriptor for each with get_irq_msi().

Re: [PATCH 13/21] MSI: Do MSI masking in the arch code

2007-03-27 Thread Eric W. Biederman
Michael Ellerman [EMAIL PROTECTED] writes: It's an arch detail whether MSI irqs need to be masked using the PCI MSI registers. Agreed. It isn't an arch detail that they need to be unmasked in the pci configuration space. I assume this patch is motivated just to make arch support easier and

Re: [PATCH 16/21] MSI: arch should connect the irq and the msi_desc desc when it's ready

2007-03-28 Thread Eric W. Biederman
Michael Ellerman [EMAIL PROTECTED] writes: set_irq_msi() currently connects an irq_desc to an msi_desc. The archs call it at some point in their setup routine, and then the generic code sets up the reverse mapping from the msi_desc back to the irq. set_irq_msi() should really do both

Re: 2.6.21-rc1 and 2.6.21-rc2 kwin dies silently

2007-03-28 Thread Eric W. Biederman
Adrian Bunk [EMAIL PROTECTED] writes: I think I got your problem: After rebooting, you do git bisect [bad|good] *once*. Then recompile the kernel from the current tree, reboot, and again *once* git bisect [bad|good]. etc. Sounds right. Someone else doing the bisect suggested that

Re: [patch] MSI-X: fix resume crash

2007-03-28 Thread Eric W. Biederman
or someone wants a more thorough patch this late in the release cycle. Signed-off-by: Eric W. Biederman [EMAIL PROTECTED] -- Subject: [patch] MSI-X: fix resume crash From: Eric W. Biederman [EMAIL PROTECTED] I think the right solution is to simply make pci_enable_device just

Re: 2.6.21-rc1 and 2.6.21-rc2 kwin dies silently

2007-03-28 Thread Eric W. Biederman
Sid I think I have found the problem. Could you try the following patch. I believe I accidentally switched the sense of a test diff --git a/kernel/exit.c b/kernel/exit.c index f132349..b55ed4c 100644 --- a/kernel/exit.c +++ b/kernel/exit.c @@ -790,7 +790,7 @@ static void exit_notify(struct

Re: [PATCH 10/21] MSI: Add an arch_msi_supported()

2007-03-28 Thread Eric W. Biederman
Michael Ellerman [EMAIL PROTECTED] writes: I agree with most of that. I thought of doing that change, but didn't want to have the powerpc code stuck behind a huge pile of driver changes. My only other worry is that at some point we'll get a driver that does want to choose the entries it's

Re: [patch] MSI-X: fix resume crash

2007-03-28 Thread Eric W. Biederman
Len Brown [EMAIL PROTECTED] writes: Tony, Len the way pci_disable_device is being used in a suspend/resume path by a few drivers is completely incompatible with the way irqs are allocated on ia64. In particular people the following sequence occurs in several drivers. probe:

Re: [PATCH] x86_64 irq: keep consistent for changing IRQ0_VECTOR from 0x20 to 0x30

2007-03-28 Thread Eric W. Biederman
Yinghai Lu [EMAIL PROTECTED] writes: On 3/7/07, Eric W. Biederman [EMAIL PROTECTED] wrote: The comment fixes or some variation on them are needed. Please check the patch about comment. YH Looks good to me. I've cleaned up the description and placed the patch inline for easier consumption

Re: [PATCH 14/21] MSI: Use a list instead of the custom link structure

2007-03-28 Thread Eric W. Biederman
Michael Ellerman [EMAIL PROTECTED] writes: I thought about doing it in the MSI enable methods, but I think it really belongs in the (nonexistant) routine that allocs and sets up a pci_dev. I agree that would be a good place for it as well. I think it's pretty dicy to be passing around a

[PATCH] pid: Properly detect orphaned process groups in exit_notify

2007-03-28 Thread Eric W. Biederman
[EMAIL PROTECTED] Thanks to: Michael Wu Signed-off-by: Eric W. Biederman [EMAIL PROTECTED] --- diff --git a/kernel/exit.c b/kernel/exit.c index f132349..b55ed4c 100644 --- a/kernel/exit.c +++ b/kernel/exit.c @@ -790,7 +790,7 @@ static void exit_notify(struct task_struct *tsk) pgrp

Re: [PATCH 13/21] MSI: Do MSI masking in the arch code

2007-03-29 Thread Eric W. Biederman
Michael Ellerman [EMAIL PROTECTED] writes: The main motivation was to have the arch in control of as much direct register writing as possible. Even though our HV does allow us to write to config space, it's not obviously safe for Linux to be flipping bits and also calling the HV to configure

Re: [PATCH 2.6.21-rc5] MSI: read-flush MSI-X table (rev 2)

2007-03-29 Thread Eric W. Biederman
Mitch Williams [EMAIL PROTECTED] writes: This patch fixes a kernel bug which is triggered when using the irqbalance daemon with MSI-X hardware. Because both MSI-X interrupt messages and MSI-X table writes are posted, it's possible for them to cross while in-flight. This results in

Re: 2.6.21-rc5-mm2 - compile error on x86-64

2007-03-29 Thread Eric W. Biederman
/root.c:83: undefined reference to `proc_sys_init' Fix that up and remove an ifdef-in-C. Cc: Eric W. Biederman [EMAIL PROTECTED] Cc: Helge Hafting [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] Eric - To unsubscribe from this list: send the line unsubscribe linux-kernel

Re: [PATCH 2.6.21-rc5] MSI: read-flush MSI-X table (rev 2)

2007-03-29 Thread Eric W. Biederman
Williams, Mitch A [EMAIL PROTECTED] writes: Chuck Ebbert wrote: Are you going to post one for 2.6.20 as well? Some people might be interested... The first time I posted this patch, Greg KH indicated that he thought it was too intrusive to add to -stable, especially considering that our MSI-X

Re: [PATCH 2.6.21-rc5] MSI: read-flush MSI-X table (rev 2)

2007-03-29 Thread Eric W. Biederman
Williams, Mitch A [EMAIL PROTECTED] writes: Chuck Ebbert wrote: Are you going to post one for 2.6.20 as well? Some people might be interested... The first time I posted this patch, Greg KH indicated that he thought it was too intrusive to add to -stable, especially considering that our MSI-X

Re: 2.6.21-rc5-mm2 - compile error on x86-64

2007-03-29 Thread Eric W. Biederman
Andrew Morton [EMAIL PROTECTED] writes: config PROC_SYSCTL bool Sysctl support (/proc/sys) if EMBEDDED depends on PROC_FS select SYSCTL default y CONFIG_PROC_SYSCTL depends on CONFIG_PROC_FS CONFIG_PROC_SYSCTL selects CONFIG_SYSCTL So I don't see

Re: [PATCH 2.6.21-rc5] Flush MSI-X table writes (rev 3)

2007-03-30 Thread Eric W. Biederman
, and since it's unmasked immediately after, no additional flushes are required in the various affinity setting routines. This patch has been validated with (unreleased) network hardware which uses MSI-X. Revised with input from Eric Biederman. Acked-by: Eric W. Biederman [EMAIL PROTECTED] Signed

Re: [PATCH 2.6.20.4] Flush MSI-X table writes (rev 3)

2007-03-30 Thread Eric W. Biederman
Greg KH [EMAIL PROTECTED] writes: Sorry, but this isn't going to go into 2.6.20 any time soon as it doesn't fit the rules for the -stable tree. But I'll take an updated version for my pci tree to go to Linus after 2.6.21 is out. Greg this does fix a bug that affects 2.6.21. We have

Re: [PATCH 2.6.21-rc5] Flush MSI-X table writes (rev 3)

2007-03-30 Thread Eric W. Biederman
Greg KH [EMAIL PROTECTED] writes: On Fri, Mar 30, 2007 at 12:47:47PM -0700, Andrew Morton wrote: Did we end up deciding whether this is (needed*safe) enough for 2.6.21? I say no for now, I have seen no bug reports for any hardware that is not in a lab for this. The bug report would be

Re: [PATCH 2.6.21-rc5] Flush MSI-X table writes (rev 3)

2007-03-30 Thread Eric W. Biederman
Williams, Mitch A [EMAIL PROTECTED] writes: Agreed, this is a subtle bug, and was a real hairball to track down. Even so, I'm surprised that nobody else has dug into this, since it should affect anybody running MSI-X. I originally thought I was seeing a hardware bug, which is why I dug more

Re: 2.6.21-rc5-mm2 - compile error on x86-64

2007-03-30 Thread Eric W. Biederman
Helge Hafting [EMAIL PROTECTED] writes: Correct. I seem to remember that the latter is considered deprecated, but some programs may still depend on it. So I disabled it to see what broke. udev complained about the missing /proc/sys/kernel/hotplug, but was happy to use

Re: 2.6.21-rc5-mm3 - no boot, address not 2M aligned

2007-03-31 Thread Eric W. Biederman
Andrew Morton [EMAIL PROTECTED] writes: On Sat, 31 Mar 2007 09:12:20 +0200 Helge Hafting [EMAIL PROTECTED] wrote: A new error for me: loading 2.6.21rc5mm3 Bios data check successful Destination address not 2M aligned -- System halted This is using the same lilo that loads

Re: 2.6.21-rc5-mm3 - no boot, address not 2M aligned

2007-03-31 Thread Eric W. Biederman
[EMAIL PROTECTED] writes: I had the same with this .config from 2.6.21-rc3-mm2 after running 'make oldconfig' and answering N to all new questions. Then, I tweaked some items, mostly to see if there was an 'align kernel' item in there somewhere. Diff between _working_ 2.6.21-rc5-mm3 .config

Re: 2.6.21-rc5-mm3 - no boot, address not 2M aligned

2007-04-02 Thread Eric W. Biederman
Vivek Goyal [EMAIL PROTECTED] writes: On Sat, Mar 31, 2007 at 11:29:57PM -0700, Andrew Morton wrote: On Sun, 01 Apr 2007 00:15:51 -0600 [EMAIL PROTECTED] (Eric W. Biederman) wrote: Does anyone know how to express the constraint of a 2M aligned number in Kconfig? Nope, but we could make

Re: 2.6.21-rc5-mm3 - no boot, address not 2M aligned

2007-04-02 Thread Eric W. Biederman
Vivek Goyal [EMAIL PROTECTED] writes: Only advantage of CONFIG_PHYSICAL_START seems to be that one has got capability to run the kernel from other addresses without modifying the boot-loader. One can argue that now people should use a relocatable kernel for such a feature. But for using

Re: [ckrm-tech] [PATCH 7/7] containers (V7): Container interface to nsproxy subsystem

2007-04-02 Thread Eric W. Biederman
Srivatsa Vaddagiri [EMAIL PROTECTED] writes: On Mon, Apr 02, 2007 at 09:09:39AM -0500, Serge E. Hallyn wrote: Losing the directory isn't a big deal though. And both unsharing a namespace (which causes a ns_container_clone) and mounting the hierarchy are done by userspace, so if for some

Re: [3/5] 2.6.21-rc4: known regressions (v2)

2007-04-02 Thread Eric W. Biederman
Bjorn Helgaas [EMAIL PROTECTED] writes: The main reason we wait until pci_enable_device() to allocate an IRQ number is that ia64 currently only has about 180 device vectors, and there are machines with more PCI slots than that. If we don't reserve irqs that the hardware doesn't support we

Re: 2.6.21-rc5 possible regression: KDE processes die silently (was: 2.6.21-rc3-mm2: KDE processes die while system is idle)

2007-04-02 Thread Eric W. Biederman
. Biederman [EMAIL PROTECTED] commit 0475ac0845f9295bc5f69af45f58dff2c104c8d1 Fixed-By : Eric W. Biederman [EMAIL PROTECTED] Commit : 14e9d5730adfca26452b3a2838a80af6950556f5 Status : fixed in -rc6 These might or might not be related issues. The description above sounds like

Re: 2.6.21-rc5-mm3 - no boot, address not 2M aligned

2007-04-02 Thread Eric W. Biederman
Vivek Goyal [EMAIL PROTECTED] writes: I guess at this point the easy case is that we modify /sbin/kexec to support it. And the other bootloaders can come be upgraded if the feature is interesting enough. On i386, somebody already found an interesting usage of CONFIG_PHYSICAL_START

[PATCH] net: Ignore sysfs network device rename bugs.

2007-04-03 Thread Eric W. Biederman
. Signed-off-by: Eric W. Biederman [EMAIL PROTECTED] --- net/core/dev.c | 11 --- 1 files changed, 4 insertions(+), 7 deletions(-) diff --git a/net/core/dev.c b/net/core/dev.c index 5984b55..cf054f9 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -751,13 +751,10 @@ int

[PATCH] msi: Immediately mask and unmask msi-x irqs.

2007-04-03 Thread Eric W. Biederman
PROTECTED] Cc: Andrew Morton [EMAIL PROTECTED] Signed-off-by: Eric W. Biederman [EMAIL PROTECTED] --- drivers/pci/msi.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c index ad33e01..435c195 100644 --- a/drivers/pci/msi.c +++ b/drivers

Re: [PATCH] msi: Immediately mask and unmask msi-x irqs.

2007-04-03 Thread Eric W. Biederman
Siddha, Suresh B [EMAIL PROTECTED] writes: set_msi_irq_affinity() is already doing read_msi_msg(). So the mask operation before this should atleast get flushed before we modify the irq destination information. We modify irq reception information in assign_irq_vector, before that. With my

Re: 2.6.21-rc5-mm4

2007-04-04 Thread Eric W. Biederman
Jiri Kosina [EMAIL PROTECTED] writes: On Tue, 3 Apr 2007, Jiri Kosina wrote: we're also having problems reproducing it on that same combination (2.6.21-rc4 + my tree), so it points to something in -mm. Since your trace is completely different right now it looks like something else is

Re: 2.6.21-rc5 possible regression: KDE processes die silently

2007-04-04 Thread Eric W. Biederman
. Oliver provokes his crash with amarok which would fit in with the sound hypothesis. Oliver reports the problem not recurring after updating to 2.6.21-rc5-git7. We also have one bug kwin ran into that got fixed after -rc5: Subject: kwin dies silently [...] Fixed-By : Eric W. Biederman

Re: [ckrm-tech] [PATCH 7/7] containers (V7): Container interface to nsproxy subsystem

2007-04-04 Thread Eric W. Biederman
Next time I have a moment I will try and take a closer look. However currently these approaches feel like there is some unholy coupling going on between different things. In addition there appear to be some weird assumptions (an array with one member per task_struct) in the group. The pid

Re: regression: sysctl_check changes in 2.6.24 are O(n) resulting in slow creation of 10000 network interfaces

2008-01-06 Thread Eric W. Biederman
Benjamin LaHaise [EMAIL PROTECTED] writes: Hello folks, 2.6.24-rc6 regresses on the 1 network interface creation test relative to 2.6.23. The cause appears to be the new code in sysctl_check_lookup(), which shows up as the #1 item while profiling. Is a revert of this new code

Re: [Bluez-devel] Oops involving RFCOMM and sysfs

2008-01-07 Thread Eric W. Biederman
Tejun Heo [EMAIL PROTECTED] writes: Hello, Tejun Heo wrote: Al Viro wrote: On Sat, Jan 05, 2008 at 11:30:25PM +0900, Tejun Heo wrote: Assuming that this is what we get, everything looks explainable - we have sysfs_rename_dir() calling sysfs_get_dentry() while the parent gets evicted. We

Re: [PATCH] msi: set 'En' bit of MSI Mapping Capability

2008-01-07 Thread Eric W. Biederman
Peer Chen [EMAIL PROTECTED] writes: Eric, Any decision for this patch, if not, currently we prefer to add all our code to quirks.c. Sorry. I think adding the code to quirks.c is fine. For bisection and code inspection purposes I would prefer the code to come as a patchset of two patches.

Re: [RFC] netns / sysfs interaction

2008-01-07 Thread Eric W. Biederman
Al Viro [EMAIL PROTECTED] writes: As much as I hate to touch either subject, let alone both at once... Eric, would you mind explaining what exactly do you want sysfs to do in presense of your namespaces? On the what does user see if we do ... level. Right. I need to repost the

Re: regression: sysctl_check changes in 2.6.24 are O(n) resulting in slow creation of 10000 network interfaces

2008-01-07 Thread Eric W. Biederman
David Miller [EMAIL PROTECTED] writes: From: [EMAIL PROTECTED] (Eric W. Biederman) Date: Sun, 06 Jan 2008 23:57:57 -0700 Why do we need 1 interfaces? Why isn't network device creation a slow path? Because people create virtual devices like mad. So is this a bug report telling me

Re: [Bluez-devel] Oops involving RFCOMM and sysfs

2008-01-07 Thread Eric W. Biederman
Al Viro [EMAIL PROTECTED] writes: On Mon, Jan 07, 2008 at 06:18:21PM +0900, Tejun Heo wrote: Tejun Heo wrote: Eric W. Biederman wrote: That said, the mechanism is a bit too fragile. sysfs currently ensures that dentry/inode point to the associated sysfs_dirent. This is mainly remanent

Re: [PROCFS] [NETNS] issue with /proc/net entries

2008-01-10 Thread Eric W. Biederman
Benjamin Thery [EMAIL PROTECTED] writes: Hi Eric, While testing the current network namespace stuff merged in net-2.6.25, I bumped into the following problem with the /proc/net/ entries. It doesn't always display the actual data of the current namespace, but sometime displays data from

My position on general ``RAS'' tool support infrastructure

2007-09-13 Thread Eric W. Biederman
Pete/Piet Delaney [EMAIL PROTECTED] writes: Jason, Eric: Did you read Keith Owens suggestion on RAS tools from: Yes. There is a tension here between generality of support infrastructure, maintainability of the infrastructure, simplicity of the infrastructure and reliability of the

Re: MTRR initialization

2007-09-16 Thread Eric W. Biederman
Yinghai Lu [EMAIL PROTECTED] writes: On 9/16/07, Howard Chu [EMAIL PROTECTED] wrote: Yinghai Lu wrote: On 9/14/07, Howard Chu [EMAIL PROTECTED] wrote: Hi, was wondering if anyone else has been tripped up by this... I've got 4GB of RAM in my Asus A8V Deluxe and memory hole mapping enabled

Re: MTRR initialization

2007-09-18 Thread Eric W. Biederman
Howard Chu [EMAIL PROTECTED] writes: Eric W. Biederman wrote: but Andi and Eric said resetting mtrr is not good... when someone from intel try to trim the MTRR for intel CPU. There are a couple issues with changing the MTRR configuration. - You may not have perfect information on the cpu

Re: 2.6.23-rc6-mm1: BUG kmalloc-16: Object padding overwritten (sysfs?)

2007-09-20 Thread Eric W. Biederman
Christoph Lameter [EMAIL PROTECTED] writes: On Thu, 20 Sep 2007, Christoph Lameter wrote: Eric: Anything that comes to mind in sysfs? Arg. Forget it. Its likely SLUB mm related. Ok. Eric - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to

Re: [PATCH] sysctl: Check length at deprecated_sysctl_warning.

2007-11-12 Thread Eric W. Biederman
Tetsuo Handa [EMAIL PROTECTED] writes: Hello. Thanks for reformatting my patch and sorry for surprising you with directory name (I meant to type linux-2.6.24-rc2, not linux-2.6.22-rc2). According to linux-2.6.23, it seems that I should return -ENOTDIR for invalid args-nlen value. I got

Re: [poll] Is the megafreeze development model broken?

2007-11-12 Thread Eric W. Biederman
ciol [EMAIL PROTECTED] writes: Hi, I'd like to ask you a few questions: * Do you like the way linux distributions integrate the kernel? * Wouldn't you prefer they ship with the stable and still maintained 2.6.16.X, while providing optionally the latest kernel for those who want or just have

Re: [PATCH] sysctl: Check length at deprecated_sysctl_warning.

2007-11-13 Thread Eric W. Biederman
Tetsuo Handa [EMAIL PROTECTED] writes: Hello. Andrew Morton wrote: I believe (args-nlen CTL_MAXNAME) was correct. I'll leave it to you. But if you want to allow args-nlen == CTL_MAXNAME, you also need to update do_sysctl(). Which has been that way since before I decided to touch it.

Re: [PATCH] Fix warning for token-ring from sysctl checker

2007-11-14 Thread Eric W. Biederman
David Miller [EMAIL PROTECTED] writes: From: Olof Johansson [EMAIL PROTECTED] Date: Tue, 13 Nov 2007 01:23:13 -0600 As seen when booting ppc64_defconfig: sysctl table check failed: /net/token-ring .3.14 procname does not match binary path procname Signed-off-by: Olof Johansson [EMAIL

Re: [PATCH] Fix warning for token-ring from sysctl checker

2007-11-14 Thread Eric W. Biederman
Olof Johansson [EMAIL PROTECTED] writes: On Wed, Nov 14, 2007 at 08:45:28AM -0800, Randy Dunlap wrote: On Wed, 14 Nov 2007 08:56:20 -0700 Eric W. Biederman wrote: David Miller [EMAIL PROTECTED] writes: From: Olof Johansson [EMAIL PROTECTED] Date: Tue, 13 Nov 2007 01:23:13 -0600

Re: [PATCH] do_task_stat: don't use task_pid_nr_ns() lockless

2007-11-17 Thread Eric W. Biederman
Oleg Nesterov [EMAIL PROTECTED] writes: Without rcu/tasklist/siglock lock task_pid_nr_ns() may read the freed memory, move the callsite under -siglock. Sadly, we can report pid == 0 if the task was detached. We only get detached in release_task so it is a pretty small window where we can

Re: [PATCH] task_pid_nr_ns() breaks proc_pid_readdir()

2007-11-17 Thread Eric W. Biederman
Oleg Nesterov [EMAIL PROTECTED] writes: proc_pid_readdir: for (...; ...; task = next_tgid(tgid + 1, ns)) { tgid = task_pid_nr_ns(task, ns); ... use tgid ... The first problem is that task_pid_nr_ns() can race with RCU and read the freed memory. However,

Re: [PATCH] do_task_stat: don't use task_pid_nr_ns() lockless

2007-11-19 Thread Eric W. Biederman
Pavel Emelyanov [EMAIL PROTECTED] writes: Eric W. Biederman wrote: We only get detached in release_task so it is a pretty small window where we can return pid == 0. Usually get_task_pid will fail first and we will return -ESRCH. Still the distance from open to There is another bug

Re: [PATCH] task_pid_nr_ns() breaks proc_pid_readdir()

2007-11-19 Thread Eric W. Biederman
Oleg Nesterov [EMAIL PROTECTED] writes: On 11/17, Eric W. Biederman wrote: Oleg Nesterov [EMAIL PROTECTED] writes: Make sure that task_pid_nr_ns() returns !0 before updating tgid. Note that next_tgid(tgid + 1) can find the same struct pid again, but we shouldn't go into the endless

Re: [PATCH] task_pid_nr_ns() breaks proc_pid_readdir()

2007-11-19 Thread Eric W. Biederman
Oleg Nesterov [EMAIL PROTECTED] writes: On 11/19, Eric W. Biederman wrote: I think we can solve the immediate issues cleanly without it, and we are pretty much in bug fixing territory now. Yes sure. Besides, the patch I showed for illustration is not complete, and it is not easy to solve

[PATCH] proc: Remove races from proc_id_readdir()

2007-11-19 Thread Eric W. Biederman
in question. A structure is introduced to return these values because it is slightly cleaner and easier to optimize, and the resulting code is a little shorter. Signed-off-by: Eric W. Biederman [EMAIL PROTECTED] --- fs/proc/base.c | 51 --- 1 files

[PATCH 0/4] proc: Cleanup status files.

2007-11-19 Thread Eric W. Biederman
There is a long standing ugliness with /proc/pid/stat, /proc/pid/statm, and /proc/pid/status that they do not use the seqfile API. In addition they are currently reporting pids in the pid namespace of the current task instead of the pid namespace with which proc was mounted which is confusing.

[PATCH] sysctl: Fix ax25 checks

2007-12-17 Thread Eric W. Biederman
/standard_window_size .3.9.1.5 Unknown sysctl binary path === (...) and so on ... Signed-off-by: Eric W. Biederman [EMAIL PROTECTED] --- kernel/sysctl_check.c |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/kernel/sysctl_check.c b/kernel

Re: [PATCH] sysctl: Fix ax25 checks

2007-12-17 Thread Eric W. Biederman
Bernard Pidoux [EMAIL PROTECTED] writes: Eric, I applied your patch and now I have all /proc/sys/net/ax25 created and initialized as before. Thanks for reporting this. Eric -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED]

Re: [PATCH] kexec: force x86_64 arches to boot kdump kernels on boot cpu

2007-12-17 Thread Eric W. Biederman
Andi Kleen [EMAIL PROTECTED] writes: On Thu, Dec 13, 2007 at 09:39:22AM -0500, Neil Horman wrote: Ok, new patch attached, taking into account Andi's request for a cleaner method Sorry for not noticing that earlier, but was there a specific reason this needs to be an early quirk at all?

Re: [RFC PATCH 08/12] PAT 64b: coherent mmap and sysfs bin ioctl

2007-12-17 Thread Eric W. Biederman
Andi Kleen [EMAIL PROTECTED] writes: On Mon, Dec 17, 2007 at 08:57:50AM +1100, Paul Mackerras wrote: Greg KH writes: Ok, sorry, it wasn't blindingly obvious that this was for pci sysfs devices that are mmaped, that makes a bit more sense. But I'd like to see what ioctl is wanted here

Re: [PATCH -mm -v3] x86 boot : export boot_params via sysfs

2007-12-17 Thread Eric W. Biederman
H. Peter Anvin [EMAIL PROTECTED] writes: This is directly analogous to how we treat identity information in IDE, or PCI configuration space -- some fields are pre-digested, but the entire raw information is also available. Add to that a totally unchanged value can just be easier to get

Re: [RFC PATCH 02/12] PAT 64b: Basic PAT implementation

2007-12-17 Thread Eric W. Biederman
Andi Kleen [EMAIL PROTECTED] writes: I do know we need to use the low 4 pat mappings to avoid most of the PAT errata issues. They don't really matter. These are all very old systems who have run fine for many years without PAT. It is no problem to let them continue to do so and just

Re: [RFC PATCH 02/12] PAT 64b: Basic PAT implementation

2007-12-17 Thread Eric W. Biederman
Venki Pallipadi [EMAIL PROTECTED] writes: Checking the manual for this. You are right, we had missed some steps here. Actually, manual says on MP, PAT MSR on all CPUs must be consistent (even when they are not really using it in their page tables. So, this will change the init and shutdown

Re: [RFC PATCH 06/12] PAT 64b: Add ioremap_wc support

2007-12-18 Thread Eric W. Biederman
Siddha, Suresh B [EMAIL PROTECTED] writes: Yes. We are looking for comments for our proposal to track the reserved/non-reserved regions some what different. This is the critical issue which had been holding off PAT for years now... The mattr infrastructure appears to do a decent job of

Re: [RFC PATCH 08/12] PAT 64b: coherent mmap and sysfs bin ioctl

2007-12-18 Thread Eric W. Biederman
Andi Kleen [EMAIL PROTECTED] writes: Well the other alternative looks like having a second file per par bar. Say resource0_wc to support the write-combining mode, possibly The intention was to support memory not in bars, but give a generic IOMMU mapped memory interface for user space e.g.

Re: [PATCH] msi: set 'En' bit of MSI Mapping Capability

2007-12-18 Thread Eric W. Biederman
peerchen [EMAIL PROTECTED] writes: According to the HyperTransport spec, 'En' indicate if the MSI Mapping is active. Set the 'En' bit when setup pci and add the quirk for some nvidia devices. The patch base on kernel 2.6.24-rc5 Ok. This is starting to look good. Signed-off-by: Andy

Re: [PATCH] msi: set 'En' bit of MSI Mapping Capability

2007-12-20 Thread Eric W. Biederman
Peer Chen [EMAIL PROTECTED] writes: The quirk is for our Intel platform, we don't want HT MSI mapping enabled in any of our devices. Why is this a problem? I seem to recall a real hypertransport bus downstream of the Intel cpu. If there is a real hypertransport bus in the middle then what

Re: [PATCH] msi: set 'En' bit of MSI Mapping Capability

2007-12-20 Thread Eric W. Biederman
Andrew Morton [EMAIL PROTECTED] writes: On Wed, 19 Dec 2007 16:41:25 -0800 Andrew Morton [EMAIL PROTECTED] wrote: It would be better to just add a stub implementation of ht_enable_msi_mapping() for all the other architectures - avoid fancy cpp tricks. And by this I really do mean going

Re: [PATCH] constify tables in kernel/sysctl_check.c

2007-12-20 Thread Eric W. Biederman
Jan Beulich [EMAIL PROTECTED] writes: Remains the question whether it is intended that many, perhaps even large, tables are compiled in without ever having a chance to get used, i.e. whether there shouldn't #ifdef CONFIG_xxx get added. The constification looks good. The file should be

[Jan Beulich] [PATCH] constify tables in kernel/sysctl_check.c

2007-12-20 Thread Eric W. Biederman
From: Jan Beulich [EMAIL PROTECTED] Remains the question whether it is intended that many, perhaps even large, tables are compiled in without ever having a chance to get used, i.e. whether there shouldn't #ifdef CONFIG_xxx get added. Signed-off-by: Jan Beulich [EMAIL PROTECTED] Acked-by: Eric W

Re: [PATCH 0/10] sysfs network namespace support

2007-12-21 Thread Eric W. Biederman
Greg KH [EMAIL PROTECTED] writes: On Sat, Dec 01, 2007 at 02:06:58AM -0700, Eric W. Biederman wrote: Now that we have network namespace support merged it is time to revisit the sysfs support so we can remove the dependency on !SYSFS. snip Oops, I forgot to apply this to my tree. Eric

Re: [Jan Beulich] [PATCH] constify tables in kernel/sysctl_check.c

2007-12-21 Thread Eric W. Biederman
Dave Jones [EMAIL PROTECTED] writes: On Thu, Dec 20, 2007 at 04:14:05PM -0700, Eric W. Biederman wrote: Remains the question whether it is intended that many, perhaps even large, tables are compiled in without ever having a chance to get used, i.e. whether there shouldn't #ifdef

Re: [PATCH] constify tables in kernel/sysctl_check.c

2007-12-21 Thread Eric W. Biederman
Jan Beulich [EMAIL PROTECTED] writes: Eric W. Biederman [EMAIL PROTECTED] 21.12.07 00:05 Jan Beulich [EMAIL PROTECTED] writes: Remains the question whether it is intended that many, perhaps even large, tables are compiled in without ever having a chance to get used, i.e. whether

Re: [PATCH] msi: set 'En' bit of MSI Mapping Capability

2007-12-24 Thread Eric W. Biederman
Peer Chen [EMAIL PROTECTED] writes: I feel it's dangerous to set the En bit on Intel platform, If the HT MSI En is set, the MSI should be expected to transform to HT INT message format. It may cause interrupt lost or hardware internal state machine failed depend on the hardware design.

Re: [patch -mm 2/4] mqueue namespace : add unshare support

2007-11-29 Thread Eric W. Biederman
Cedric Le Goater [EMAIL PROTECTED] writes: From: Cedric Le Goater [EMAIL PROTECTED] This patch includes the mqueue namespace in the nsproxy object. It also adds the support of unshare() and clone() with a new clone flag CLONE_NEWMQ (1 bit left in the clone flags !) CLONE_NEWMQ is

[PATCH 0/4] Sysctl namespace support

2007-11-29 Thread Eric W. Biederman
Currently the network namespace work has gotten about as far as we can without the ability to make sysctls that are per network namespace. The techniques we have been using for other namespace of examining current and replacing the ctl_table.data field depending on the namespace instance that

[PATCH 1/4] sysctl: Add register_sysctl_paths function

2007-11-29 Thread Eric W. Biederman
this change is both a space savings and a code simplification. CC: Olaf Kirch [EMAIL PROTECTED] CC: Olaf Hering [EMAIL PROTECTED] Signed-off-by: Eric W. Biederman [EMAIL PROTECTED] --- include/linux/sysctl.h |9 + kernel/sysctl.c| 90

[PATCH 2/4] sysctl: Remember the ctl_table we passed to register_sysctl_paths

2007-11-29 Thread Eric W. Biederman
-by: Eric W. Biederman [EMAIL PROTECTED] --- include/linux/sysctl.h |1 + kernel/sysctl.c|1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/include/linux/sysctl.h b/include/linux/sysctl.h index eb522bf..8b2e9e0 100644 --- a/include/linux/sysctl.h +++ b/include/linux

[PATCH 4/4] net: Implement the per network namespace sysctl infrastructure

2007-11-29 Thread Eric W. Biederman
other sysctls continue to be globally visible. Signed-off-by: Eric W. Biederman [EMAIL PROTECTED] --- include/net/net_namespace.h |9 +++ net/sysctl_net.c| 57 +++ 2 files changed, 66 insertions(+), 0 deletions(-) diff --git a/include/net

[PATCH 3/4] sysctl: Infrastructure for per namespace sysctls

2007-11-29 Thread Eric W. Biederman
is added to add a new sysctl table on a non-default sysctl list. The only intrusive part of this patch is propagating the information to decided which list of sysctls to use for sysctl_check_table. Signed-off-by: Eric W. Biederman [EMAIL PROTECTED] --- include/linux/sysctl.h | 16

Re: [patch -mm 2/4] mqueue namespace : add unshare support

2007-11-29 Thread Eric W. Biederman
Oren Laadan [EMAIL PROTECTED] writes: Two comments: 1) Does it ever make any sense to clone the IPC namespace *without* doing so also for the MQ namespace or vice versa ? Unless there is a good reason for doing so, a single CLONE_IPCMQ flag would suffice. SYSVIPC and POSIX IPC are

Re: + proc-fix-the-threaded-proc-self.patch added to -mm tree

2007-11-29 Thread Eric W. Biederman
Albert Cahalan [EMAIL PROTECTED] writes: On Nov 28, 2007 6:31 AM, Eric W. Biederman [EMAIL PROTECTED] wrote: Ingo Molnar [EMAIL PROTECTED] writes: * Albert Cahalan [EMAIL PROTECTED] wrote: On Nov 27, 2007 7:49 PM, Guillaume Chazarain [EMAIL PROTECTED] wrote: In a lot of ways if you access

Re: [PATCH] kexec: force x86_64 arches to boot kdump kernels on boot cpu

2007-11-29 Thread Eric W. Biederman
Ben Woodard [EMAIL PROTECTED] writes: Eric W. Biederman wrote: Vivek Goyal [EMAIL PROTECTED] writes: Ok. Got it. So in this case we route the interrupts directly through LAPIC and put LVT0 in ExtInt mode and IOAPIC is bypassed. I am looking at Intel Multiprocessor specification v1.4

Re: [PATCH 0/4] Sysctl namespace support

2007-11-30 Thread Eric W. Biederman
Herbert Xu [EMAIL PROTECTED] writes: On Thu, Nov 29, 2007 at 10:40:24AM -0700, Eric W. Biederman wrote: Herbert we need this infrastructure most in net-2.6.25 (as not having it is a current bottleneck to further development of the network namespace) so these patches are against net-2.6.25

Re: [PATCH 4/4] net: Implement the per network namespace sysctl infrastructure

2007-11-30 Thread Eric W. Biederman
Serge E. Hallyn [EMAIL PROTECTED] writes: Hey Eric, the patches look nice. The hand-forcing of the passed-in net_ns into a copy of current-nsproxy does make it seem like nsproxy may not be the best choice of what to pass in. Doesn't only net_sysctl_root-lookup() look at the argument?

[PATCH 0/10] sysfs network namespace support

2007-12-01 Thread Eric W. Biederman
Now that we have network namespace support merged it is time to revisit the sysfs support so we can remove the dependency on !SYSFS. I'm not even trying to base this on any of Tejun's very interesting work on sysfs to remove the coupling between kobjects and sysfs_dirents. For my objective

[PATCH 01/10] sysfs: Make sysfs_mount static again.

2007-12-01 Thread Eric W. Biederman
but we should continue to get the useful part of the debugging information. This was the reason I made sysfs_mount static earlier. Signed-off-by: Eric W. Biederman [EMAIL PROTECTED] --- fs/sysfs/file.c |2 +- fs/sysfs/mount.c |2 +- fs/sysfs/sysfs.h |1 - 3 files changed, 2 insertions

[PATCH 02/10] sysfs: Support for preventing unmounts.

2007-12-01 Thread Eric W. Biederman
blocks will be either created or destroyed. Signed-off-by: Eric W. Biederman [EMAIL PROTECTED] --- fs/sysfs/mount.c | 79 - fs/sysfs/sysfs.h | 10 +++ 2 files changed, 81 insertions(+), 8 deletions(-) diff --git a/fs/sysfs/mount.c b/fs

[PATCH 03/10] sysfs: sysfs_get_dentry add a sb parameter

2007-12-01 Thread Eric W. Biederman
In preparation for multiple mounts of sysfs add a superblock parameter to sysfs_get_dentry. Signed-off-by: Eric W. Biederman [EMAIL PROTECTED] --- fs/sysfs/dir.c | 11 ++- fs/sysfs/file.c |2 +- fs/sysfs/sysfs.h |2 +- 3 files changed, 8 insertions(+), 7 deletions(-) diff

[PATCH 04/10] sysfs: Implement __sysfs_get_dentry

2007-12-01 Thread Eric W. Biederman
This function is similar but much simpler to sysfs_get_dentry returns a sysfs dentry if one curently exists. This requires less locking the sysfs_get_dentry and which makes it preferable in some contexts. Signed-off-by: Eric W. Biederman [EMAIL PROTECTED] --- fs/sysfs/dir.c | 38

[PATCH 05/10] sysfs: Rename Support multiple superblocks

2007-12-01 Thread Eric W. Biederman
This patch modifies the sysfs_rename_dir and sysfs_move_dir to support multiple sysfs dentry trees rooted in different sysfs superblocks. Signed-off-by: Eric W. Biederman [EMAIL PROTECTED] --- fs/sysfs/dir.c | 190 +++ 1 files changed, 135

[PATCH 06/10] sysfs: sysfs_chmod_file handle multiple superblocks

2007-12-01 Thread Eric W. Biederman
Teach sysfs_chmod_file how to handle multiple sysfs superblocks. Signed-off-by: Eric W. Biederman [EMAIL PROTECTED] --- fs/sysfs/file.c | 51 --- 1 files changed, 28 insertions(+), 23 deletions(-) diff --git a/fs/sysfs/file.c b/fs/sysfs/file.c

[PATCH 07/10] sysfs: Implement sysfs tagged directory support.

2007-12-01 Thread Eric W. Biederman
makes it an uninteresting problem to solve. Signed-off-by: Eric W. Biederman [EMAIL PROTECTED] --- fs/sysfs/bin.c|2 +- fs/sysfs/dir.c| 182 + fs/sysfs/file.c |8 +- fs/sysfs/group.c | 12 ++-- fs/sysfs/inode.c

[PATCH 08/10] sysfs: Implement sysfs_delete_link and sysfs_rename_link

2007-12-01 Thread Eric W. Biederman
kobject is renamed or deleted. If they are called later I loose track of which tag the target kobject was marked with and can no longer find the old symlink to remove it. Signed-off-by: Eric W. Biederman [EMAIL PROTECTED] --- fs/sysfs/symlink.c| 31 +++ include

[PATCH 09/10] driver core: Implement tagged directory support for device classes.

2007-12-01 Thread Eric W. Biederman
. Signed-off-by: Eric W. Biederman [EMAIL PROTECTED] --- drivers/base/class.c | 30 --- drivers/base/core.c| 51 +-- include/linux/device.h |2 + 3 files changed, 55 insertions(+), 28 deletions(-) diff --git

<    2   3   4   5   6   7   8   9   10   11   >