Re: [PATCH 1/4] hwmon, fam15h_power: Change email address, MAINTAINERS entry

2012-10-29 Thread Guenter Roeck
On Mon, Oct 29, 2012 at 06:50:47PM +0100, Andreas Herrmann wrote: Signed-off-by: Andreas Herrmann herrmann.der.u...@googlemail.com Applied. Thanks, Guenter -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More

Re: [PATCH] hwmon: da9055: Fix chan_mux[DA9055_ADC_ADCIN3] setting

2012-10-29 Thread Guenter Roeck
On Mon, Oct 29, 2012 at 04:34:38PM +0800, Axel Lin wrote: Set chan_mux[DA9055_ADC_ADCIN3] = DA9055_ADC_MUX_ADCIN3. Signed-off-by: Axel Lin axel@ingics.com --- Hi, This looks like a typo, but I don't have a hardware to test it. Axel drivers/hwmon/da9055-hwmon.c |2 +- 1 file

Re: [PATCH] hwmon: da9055: Fix chan_mux[DA9055_ADC_ADCIN3] setting

2012-10-29 Thread Guenter Roeck
On Mon, Oct 29, 2012 at 04:34:38PM +0800, Axel Lin wrote: Set chan_mux[DA9055_ADC_ADCIN3] = DA9055_ADC_MUX_ADCIN3. Signed-off-by: Axel Lin axel@ingics.com --- Hi, This looks like a typo, but I don't have a hardware to test it. Axel drivers/hwmon/da9055-hwmon.c |2 +- 1 file

[GIT PULL] hwmon patches for 3.7-rc4

2012-11-02 Thread Guenter Roeck
Hi Linus, Please pull hwmon patches for Linux 3.7-rc4 from signed tag: git://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-for-linus Thanks, Guenter -- The following changes since commit 8f0d8163b50e01f398b14bcd4dc039ac5ab18d64: Linux 3.7-rc3 (2012-10-28

Re: [PATCH resend] spi core: Provide means to instantiate devices through sysfs

2012-09-22 Thread Guenter Roeck
On Sat, Sep 22, 2012 at 12:11:33PM -0400, Mark Brown wrote: On Mon, Sep 17, 2012 at 04:51:20PM -0700, Guenter Roeck wrote: The I2C core provides a means to instantiate devices from userspace using sysfs attributes. Provide the same mechanism for SPI devices. So, unlike I2C this is only

Re: [PATCH v4 2/2] hwmon: (ads7828) add support for ADS7830

2012-10-03 Thread Guenter Roeck
On Wed, Oct 03, 2012 at 10:03:08AM -0400, Vivien Didelot wrote: Hi Guenter, On Tue, 2012-10-02 at 22:07 -0700, Guenter Roeck wrote: On Tue, Oct 02, 2012 at 11:33:27PM -0400, Vivien Didelot wrote: From: Guillaume Roguez guillaume.rog...@savoirfairelinux.com The ADS7830 device

Re: make CONFIG_EXPERIMENTAL invisible and default

2012-10-03 Thread Guenter Roeck
On Tue, Oct 02, 2012 at 07:50:42PM -, Kees Cook wrote: This config item has not carried much meaning for a while now and is almost always enabled by default. As agreed during the Linux kernel summit, it should be removed. As a first step, remove it from being listed, and default it to on.

Re: make CONFIG_EXPERIMENTAL invisible and default

2012-10-03 Thread Guenter Roeck
On Wed, Oct 03, 2012 at 04:33:21PM -0700, Kees Cook wrote: On Wed, Oct 3, 2012 at 4:29 PM, Guenter Roeck li...@roeck-us.net wrote: On Tue, Oct 02, 2012 at 07:50:42PM -, Kees Cook wrote: This config item has not carried much meaning for a while now and is almost always enabled by default

Re: [PATCH v5 1/2] hwmon: (ads7828) driver cleanup

2012-10-03 Thread Guenter Roeck
On Wed, Oct 03, 2012 at 04:54:07PM -0400, Vivien Didelot wrote: As there is no reliable way to identify the chip, it is preferable to remove the detect callback, to avoid misdetection. Module parameters are not worth it here, so let's get rid of them and add an ads7828_platform_data

Re: [PATCH v5 2/2] hwmon: (ads7828) add support for ADS7830

2012-10-03 Thread Guenter Roeck
On Wed, Oct 03, 2012 at 04:54:08PM -0400, Vivien Didelot wrote: From: Guillaume Roguez guillaume.rog...@savoirfairelinux.com The ADS7830 device is almost the same as the ADS7828, except that it does 8-bit sampling, instead of 12-bit. This patch extends the ads7828 driver to support this

[PATCH] drm: nouveau: Fix build warning seen is HWMON is undefined

2012-10-05 Thread Guenter Roeck
Fix: nouveau_pm.c: In function ‘nouveau_hwmon_init’: nouveau_pm.c:703:24: warning: unused variable ‘therm’ [-Wunused-variable] Signed-off-by: Guenter Roeck li...@roeck-us.net --- This was seen in the latest upstream kernel. drivers/gpu/drm/nouveau/nouveau_pm.c |4 ++-- 1 file changed, 2

[GIT PULL] hwmon fixes for 3.7-rc2

2012-10-19 Thread Guenter Roeck
:33 -0700) Drop some leftover dependencies on CONFIG_EXPERIMENTAL, and add support for Intel Atom CE4110/4150/4170. Guenter Roeck (1): hwmon: (coretemp) Add

Re: [RFC] Energy/power monitoring within the kernel

2012-10-23 Thread Guenter Roeck
On Tue, Oct 23, 2012 at 06:30:49PM +0100, Pawel Moll wrote: Greetings All, More and more of people are getting interested in the subject of power (energy) consumption monitoring. We have some external tools like battery simulators, energy probes etc., but some targets can measure their

Re: [PATCH] hwmon: ina2xx: use module_i2c_driver to simplify the code

2012-10-08 Thread Guenter Roeck
On Mon, Oct 08, 2012 at 08:40:35PM +0800, Wei Yongjun wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn Use the module_i2c_driver() macro to make the code smaller and a bit simpler. dpatch engine is used to auto generate this patch. (https://github.com/weiyj/dpatch) Signed-off-by:

Re: [PATCH] hwmon: da9052: Use da9052_reg_update for rmw operations

2012-10-11 Thread Guenter Roeck
On Thu, Oct 11, 2012 at 10:03:51PM +0800, Axel Lin wrote: Signed-off-by: Axel Lin axel@ingics.com --- drivers/hwmon/da9052-hwmon.c | 27 +++ 1 file changed, 7 insertions(+), 20 deletions(-) Applied to -next. Thanks, Guenter -- To unsubscribe from this list:

Re: [PATCH] hwmon: (ina2xx) Use module_i2c_driver macro

2012-10-11 Thread Guenter Roeck
On Thu, Oct 11, 2012 at 11:56:26PM +0800, Axel Lin wrote: Signed-off-by: Axel Lin axel@ingics.com --- drivers/hwmon/ina2xx.c | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) Hi Axel, A similar patch from Wei Yongjun is already queued in my -next branch. It is not

Re: [RFC] Energy/power monitoring within the kernel

2012-10-24 Thread Guenter Roeck
On Wed, Oct 24, 2012 at 05:37:27PM +0100, Pawel Moll wrote: On Tue, 2012-10-23 at 23:02 +0100, Guenter Roeck wrote: Traditionally such data should be exposed to the user via hwmon sysfs interface, and that's exactly what I did for my platform - I have a /sys/class/hwmon/hwmon*/device

Re: [lm-sensors] [PATCH 1/2] hwmon: (applesmc) Allow negative temperature values

2012-07-16 Thread Guenter Roeck
On Mon, Jul 16, 2012 at 09:18:10AM +0200, Henrik Rydberg wrote: There are many userland reports of sensors with unreasonably small and large temperatures. There seem to be several reasons for this: Firstly, the major sensor type (sp78) is actually a signed number. This explains why some

Re: [lm-sensors] [PATCH 2/2] hwmon: (applesmc) Ignore some temperature registers

2012-07-16 Thread Guenter Roeck
On Mon, Jul 16, 2012 at 09:18:11AM +0200, Henrik Rydberg wrote: Not all sensors in the T range are useful temperatures. This patch creates a subset of sensors to be exported to userland, excluding the unknown types. Signed-off-by: Henrik Rydberg rydb...@euromail.se Applied to -next.

Re: [PATCH 1/2] watchdog: introduce new watchdog AUTOSTART option

2013-04-14 Thread Guenter Roeck
On Mon, Apr 15, 2013 at 12:43:31AM +, Kim, Milo wrote: Hi Guenter I really don't like that idea. It defeats a significant part of the purpose for having a watchdog, which is to prevent user-space hangups. To make this a driver option is even more odd - it forces every user of

Re: [NEW DRIVER V4 7/7] DA9058 REGULATOR driver

2013-04-15 Thread Guenter Roeck
On Mon, Apr 15, 2013 at 03:00:58PM +, Opensource [Anthony Olech] wrote: -Original Message- From: Guenter Roeck [mailto:li...@roeck-us.net] Sent: 12 April 2013 14:32 To: Opensource [Anthony Olech] Cc: Mark Brown; Liam Girdwood; Jean Delvare; Randy Dunlap; LKML; David

Re: [NEW DRIVER V4 7/7] DA9058 REGULATOR driver

2013-04-15 Thread Guenter Roeck
On Mon, Apr 15, 2013 at 05:29:13PM +, Opensource [Anthony Olech] wrote: -Original Message- From: Guenter Roeck [mailto:li...@roeck-us.net] Sent: 15 April 2013 17:36 To: Opensource [Anthony Olech] Cc: LKML Subject: Re: [NEW DRIVER V4 7/7] DA9058 REGULATOR driver On Mon

Re: [RFC PATCH] watchdog: Add hook for kicking in kdump path

2013-04-15 Thread Guenter Roeck
On Mon, Apr 15, 2013 at 04:55:04PM -0400, Don Zickus wrote: On Fri, Apr 12, 2013 at 02:30:24PM -0700, Guenter Roeck wrote: On Fri, Apr 12, 2013 at 05:16:27PM -0400, Don Zickus wrote: On Wed, Apr 10, 2013 at 08:10:41AM -0700, Guenter Roeck wrote: have no idea how to even find out

Re: [NEW DRIVER V4 7/7] DA9058 REGULATOR driver

2013-04-16 Thread Guenter Roeck
On Tue, Apr 16, 2013 at 09:17:27AM +, Opensource [Anthony Olech] wrote: -Original Message- From: Guenter Roeck [mailto:li...@roeck-us.net] Sent: 15 April 2013 18:46 To: Opensource [Anthony Olech] Cc: LKML Subject: Re: [NEW DRIVER V4 7/7] DA9058 REGULATOR driver On Mon

Re: [PATCH v5 1/3] i2c: mux: Add i2c-arb-gpio-challenge 'mux' driver

2013-04-16 Thread Guenter Roeck
On Tue, Apr 16, 2013 at 11:36:33AM +0200, Wolfram Sang wrote: Doug, [ ... ] callenge response? ... diff --git a/drivers/i2c/muxes/i2c-arb-gpio-challenge.c b/drivers/i2c/muxes/i2c-arb-gpio-challenge.c new file mode 100644 index 000..bda020a --- /dev/null +++

Re: [PATCH v6 1/3] i2c: mux: Add i2c-arb-gpio-challenge 'mux' driver

2013-04-16 Thread Guenter Roeck
On Tue, Apr 16, 2013 at 09:29:00AM -0700, Doug Anderson wrote: The i2c-arb-gpio-challenge driver implements an I2C arbitration scheme where masters need to claim the bus with a GPIO before they can start a transcation. This should generally only be used when standard I2C I am having fun with

Re: [PATCH v3] watchdog: Add hook for kicking in kdump path

2013-04-17 Thread Guenter Roeck
On Wed, Apr 17, 2013 at 05:19:56PM -0400, Don Zickus wrote: A common problem with kdump is that during the boot up of the second kernel, the hardware watchdog times out and reboots the machine before a vmcore can be captured. Instead of tellling customers to disable their hardware watchdog

Re: [PATCH v3] watchdog: Add hook for kicking in kdump path

2013-04-17 Thread Guenter Roeck
On Wed, Apr 17, 2013 at 02:49:59PM -0700, Eric W. Biederman wrote: Don Zickus dzic...@redhat.com writes: A common problem with kdump is that during the boot up of the second kernel, the hardware watchdog times out and reboots the machine before a vmcore can be captured. Instead of

Re: [NEW DRIVER V5 6/7] drivers/hwmon: DA9058 HWMON driver

2013-04-17 Thread Guenter Roeck
On Wed, Apr 17, 2013 at 05:33:36PM +0100, Anthony Olech wrote: This patch is relative to linux next-20130417 This is the HWMON component driver of the Dialog DA9058 PMIC. This driver is just one component of the whole DA9058 PMIC driver. It depends on the CORE and ADC component drivers of

Re: [PATCH 1/4] mfd: Kontron PLD mfd driver

2013-04-17 Thread Guenter Roeck
On Sat, Apr 13, 2013 at 10:38:07PM +0200, Thomas Gleixner wrote: [ ... ] + return kempld_read8(pld, index) | kempld_read8(pld, index+1) 8; index + 1) Please Wondering why does checkpatch not report those ? I just

Re: [PATCH 1/4] mfd: Kontron PLD mfd driver

2013-04-18 Thread Guenter Roeck
On Wed, Apr 17, 2013 at 09:40:53PM -0700, Joe Perches wrote: On Wed, 2013-04-17 at 21:19 -0700, Guenter Roeck wrote: On Sat, Apr 13, 2013 at 10:38:07PM +0200, Thomas Gleixner wrote: + return kempld_read8(pld, index) | kempld_read8(pld, index+1) 8

Re: CodingStyle

2013-04-18 Thread Guenter Roeck
On Thu, Apr 18, 2013 at 10:48:06AM +, Opensource [Anthony Olech] wrote: -Original Message- From: Guenter Roeck [mailto:li...@roeck-us.net] Sent: 18 April 2013 05:14 To: Opensource [Anthony Olech] Cc: Jean Delvare; Mark Brown; Randy Dunlap; lm-sens...@lm-sensors.org; LKML

Re: [PATCH v3] watchdog: Add hook for kicking in kdump path

2013-04-18 Thread Guenter Roeck
On Thu, Apr 18, 2013 at 09:00:09AM -0400, Don Zickus wrote: On Wed, Apr 17, 2013 at 02:49:59PM -0700, Eric W. Biederman wrote: Don Zickus dzic...@redhat.com writes: A common problem with kdump is that during the boot up of the second kernel, the hardware watchdog times out and reboots

Re: [PATCH v3] watchdog: Add hook for kicking in kdump path

2013-04-18 Thread Guenter Roeck
On Thu, Apr 18, 2013 at 09:52:57AM -0400, Don Zickus wrote: On Thu, Apr 18, 2013 at 06:49:04AM -0700, Guenter Roeck wrote: On Thu, Apr 18, 2013 at 09:00:09AM -0400, Don Zickus wrote: On Wed, Apr 17, 2013 at 02:49:59PM -0700, Eric W. Biederman wrote: Don Zickus dzic...@redhat.com writes

Re: [PATCH 1/4] mfd: Kontron PLD mfd driver

2013-04-18 Thread Guenter Roeck
On Thu, Apr 18, 2013 at 09:42:17AM -0700, Joe Perches wrote: On Thu, 2013-04-18 at 06:35 -0700, Guenter Roeck wrote: On Wed, Apr 17, 2013 at 09:40:53PM -0700, Joe Perches wrote: On Wed, 2013-04-17 at 21:19 -0700, Guenter Roeck wrote: On Sat, Apr 13, 2013 at 10:38:07PM +0200, Thomas

Re: [NEW DRIVER V6 6/7] drivers/hwmon: DA9058 HWMON driver

2013-04-20 Thread Guenter Roeck
On Fri, Apr 19, 2013 at 08:25:02PM +0200, Lars-Peter Clausen wrote: Same comment as before, I'd like to see this using the generic IIO to HWMON bridge instead of recreating it. ... and I agree. Seems we are getting more and more of those, and at some point it makes really sense to find a

Re: [NEW DRIVER V6 6/7] drivers/hwmon: DA9058 HWMON driver

2013-04-21 Thread Guenter Roeck
On Mon, Apr 22, 2013 at 01:14:26AM +, Opensource [Anthony Olech] wrote: -Original Message- From: Guenter Roeck [mailto:li...@roeck-us.net] Sent: 20 April 2013 18:35 To: Lars-Peter Clausen Cc: Opensource [Anthony Olech]; Jean Delvare; Mark Brown; Randy Dunlap; lm-sens...@lm

Re: [PATCH v4 2/2] watchdog: fix w83627hf_wdt clear timeout expired

2013-04-03 Thread Guenter Roeck
Chung tonychun...@gmail.com Acked-by: Guenter Roeck li...@roeck-us.net --- drivers/watchdog/w83627hf_wdt.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/watchdog/w83627hf_wdt.c b/drivers/watchdog/w83627hf_wdt.c index 8fd..7eaa226 100644

Re: [PATCH] Blackfin: bf537: rename CONFIG_AD7314

2013-04-04 Thread Guenter Roeck
bfin_spi_board_info[] __initdata = { }, #endif -#if defined(CONFIG_AD7314) || defined(CONFIG_AD7314_MODULE) +#if IS_ENABLED(CONFIG_SENSORS_AD7314) { .modalias = ad7314, .max_speed_hz = 100, Acked-by: Guenter Roeck li...@roeck-us.net

Re: [PATCH] Blackfin: bf537: rename CONFIG_ADT75

2013-04-04 Thread Guenter Roeck
On Thu, Apr 04, 2013 at 01:40:03PM +0200, Jean Delvare wrote: On Thu, 04 Apr 2013 12:31:06 +0200, Paul Bolle wrote: In v3.2 the Analog Devices ADT75 temperature sensor driver was removed as an IIO driver and support for it was added to the LM75 HWMON driver. But it was apparently overlooked

Re: [PATCH] Blackfin: bf537: rename CONFIG_ADT75

2013-04-04 Thread Guenter Roeck
On Thu, Apr 04, 2013 at 02:59:43PM +0200, Paul Bolle wrote: On Thu, 2013-04-04 at 05:07 -0700, Guenter Roeck wrote: On Thu, Apr 04, 2013 at 01:40:03PM +0200, Jean Delvare wrote: This breakage is telling us something about the weird approach taken in this file, methinks. Yes

Re: 3.8.3 and 3.9git occasional watchdog oops

2013-04-04 Thread Guenter Roeck
On Fri, Apr 05, 2013 at 12:23:30AM +0200, Arkadiusz Miskiewicz wrote: On Thursday 14 of March 2013, Arkadiusz Miśkiewicz wrote: Hi. Just hit watchdog related oops in 3.8.3 kernel. Unfortunately photos only. http://ixion.pld-linux.org/~arekm/watchdog-oops-3.8.3/IMG_8942.JPG

Re: [PATCH] Blackfin: bf537: use CONFIG_SND_SOC_AD193X

2013-04-05 Thread Guenter Roeck
On Fri, Apr 05, 2013 at 11:43:37AM +0200, Jean Delvare wrote: On Fri, 05 Apr 2013 11:20:46 +0200, Paul Bolle wrote: 1) Added Jean and Guenter because they seem to take in interest in Blackfin's stamp files. Doh, no, I only express my disgust and I'd rather stay away from them as much as I

Re: [PATCH RFC] watchdog: core: don't try to stop device if not running

2013-04-05 Thread Guenter Roeck
On Fri, Apr 05, 2013 at 06:09:44PM +0200, Hector Palacios wrote: A watchdog device may be stopped from userspace using WDIOC_SETOPTIONS ioctl and flag WDIOS_DISABLECARD. If the device is closed after this operation, watchdog_release() is called and status bits checked for stopping it. Besides,

Re: 3.8.3 and 3.9git occasional watchdog oops

2013-04-05 Thread Guenter Roeck
On Thu, Apr 04, 2013 at 06:59:59PM -0700, Guenter Roeck wrote: On Fri, Apr 05, 2013 at 12:23:30AM +0200, Arkadiusz Miskiewicz wrote: On Thursday 14 of March 2013, Arkadiusz Miśkiewicz wrote: Hi. Just hit watchdog related oops in 3.8.3 kernel. Unfortunately photos only. http

[PATCH] watchdog: Fix race condition in registration code

2013-04-05 Thread Guenter Roeck
after it was created. Reported-by: Arkadiusz Miskiewicz a.miskiew...@gmail.com Signed-off-by: Guenter Roeck li...@roeck-us.net --- Arkadiusz, would be great if you can test this in your system. drivers/watchdog/watchdog_dev.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [PATCH v4 1/3] i2c: mux: Add i2c-arbitrator-cros-ec 'mux' driver

2013-04-06 Thread Guenter Roeck
On Fri, Apr 05, 2013 at 02:03:52PM -0600, Stephen Warren wrote: On 04/05/2013 01:37 PM, Simon Glass wrote: HI Wolfram, On Wed, Apr 3, 2013 at 12:19 PM, Wolfram Sang w...@the-dreams.de wrote: Doug, Separately from a discussion of the technical merits, I'd say that this patch is

Re: [PATCH v4 1/3] i2c: mux: Add i2c-arbitrator-cros-ec 'mux' driver

2013-04-07 Thread Guenter Roeck
On Sat, Apr 06, 2013 at 10:11:32PM +0200, Wolfram Sang wrote: Hi, Very interesting discussion, especially the argument that we already shipped would not be a convincing argument. I had senior kernel maintainers tell me and the company I work for that we should submit _all_ our

Re: [v5] clk: add si5351 i2c common clock driver

2013-04-07 Thread Guenter Roeck
On Fri, Apr 05, 2013 at 05:23:35AM -, Sebastian Hesselbarth wrote: This patch adds a common clock driver for Silicon Labs Si5351a/b/c i2c programmable clock generators. Currently, the driver supports DT kernels only and VXCO feature of si5351b is not implemented. DT bindings selectively

Re: [v5] clk: add si5351 i2c common clock driver

2013-04-07 Thread Guenter Roeck
On Mon, Apr 08, 2013 at 01:49:24AM +0200, Sebastian Hesselbarth wrote: On 04/08/2013 12:50 AM, Guenter Roeck wrote: On Fri, Apr 05, 2013 at 05:23:35AM -, Sebastian Hesselbarth wrote: This patch adds a common clock driver for Silicon Labs Si5351a/b/c i2c programmable clock generators

Re: [PATCH RFC] watchdog: core: don't try to stop device if not running

2013-04-08 Thread Guenter Roeck
On Mon, Apr 08, 2013 at 09:48:57AM +0200, Hector Palacios wrote: On 04/05/2013 08:34 PM, Guenter Roeck wrote: On Fri, Apr 05, 2013 at 06:09:44PM +0200, Hector Palacios wrote: A watchdog device may be stopped from userspace using WDIOC_SETOPTIONS ioctl and flag WDIOS_DISABLECARD. If the device

Re: [PATCH v2] watchdog: core: don't try to stop device if not running

2013-04-08 Thread Guenter Roeck
On Mon, Apr 08, 2013 at 11:10:58AM +0200, Hector Palacios wrote: A watchdog device may be stopped from userspace using WDIOC_SETOPTIONS ioctl and flag WDIOS_DISABLECARD. If the device is closed after this operation, watchdog_release() is called and status bits checked for stopping it. Besides,

Re: [v5] clk: add si5351 i2c common clock driver

2013-04-08 Thread Guenter Roeck
On Mon, Apr 08, 2013 at 08:11:38AM +0200, Sebastian Hesselbarth wrote: On 04/08/2013 02:17 AM, Guenter Roeck wrote: On Mon, Apr 08, 2013 at 01:49:24AM +0200, Sebastian Hesselbarth wrote: On 04/08/2013 12:50 AM, Guenter Roeck wrote: On Fri, Apr 05, 2013 at 05:23:35AM -, Sebastian

Re: [RFC PATCH] watchdog: Add hook for kicking in kdump path

2013-04-08 Thread Guenter Roeck
On Mon, Apr 08, 2013 at 08:48:58AM -0400, Don Zickus wrote: On Mon, Apr 08, 2013 at 01:46:58PM +0800, Dave Young wrote: On 04/06/2013 04:16 AM, Don Zickus wrote: A common problem with kdump is that during the boot up of the second kernel, the hardware watchdog times out and reboots the

Re: [PATCH v3] watchdog: core: don't try to stop device if not running

2013-04-08 Thread Guenter Roeck
watchdog did not stop!: wd_fd = open(/dev/watchdog, O_RDWR); flags = WDIOS_DISABLECARD; ioctl(wd_fd, WDIOC_SETOPTIONS, flags); close(wd_fd); Signed-off-by: Hector Palacios hector.palac...@digi.com Reviewed-by: Guenter Roeck li...@roeck-us.net --- Changes from

Re: [PATCH v6] clk: add si5351 i2c common clock driver

2013-04-08 Thread Guenter Roeck
On Mon, Apr 08, 2013 at 06:46:57PM +0200, Sebastian Hesselbarth wrote: This patch adds a common clock driver for Silicon Labs Si5351a/b/c i2c programmable clock generators. Currently, the driver does not support VXCO feature of si5351b. Passing platform_data or DT bindings selectively allow to

Re: mfd: Core driver for Winbond chips

2013-04-09 Thread Guenter Roeck
On Tue, Apr 09, 2013 at 11:37:01AM +0200, Samuel Ortiz wrote: Hi Guenter, On Sat, Mar 23, 2013 at 10:49:14AM -0700, Guenter Roeck wrote: MFD core driver for various variants of Winbond/Nuvoton SuperIO chips. Signed-off-by: Guenter Roeck li...@roeck-us.net --- drivers/mfd/Kconfig

Re: [RFC PATCH] watchdog: Add hook for kicking in kdump path

2013-04-09 Thread Guenter Roeck
On Tue, Apr 09, 2013 at 10:44:31AM -0400, Don Zickus wrote: On Mon, Apr 08, 2013 at 08:15:09AM -0700, Guenter Roeck wrote: On Mon, Apr 08, 2013 at 08:48:58AM -0400, Don Zickus wrote: On Mon, Apr 08, 2013 at 01:46:58PM +0800, Dave Young wrote: On 04/06/2013 04:16 AM, Don Zickus wrote

Re: [RFC PATCH] watchdog: Add hook for kicking in kdump path

2013-04-09 Thread Guenter Roeck
On Tue, Apr 09, 2013 at 11:14:23AM -0400, Don Zickus wrote: On Tue, Apr 09, 2013 at 07:52:28AM -0700, Guenter Roeck wrote: On Tue, Apr 09, 2013 at 10:44:31AM -0400, Don Zickus wrote: On Mon, Apr 08, 2013 at 08:15:09AM -0700, Guenter Roeck wrote: On Mon, Apr 08, 2013 at 08:48:58AM -0400

Re: mfd: Core driver for Winbond chips

2013-04-09 Thread Guenter Roeck
On Tue, Apr 09, 2013 at 01:45:44PM +0200, Wim Van Sebroeck wrote: Hi Guenter, I was waiting for feedback from Wim, who submitted a similar driver, about his thoughts. Key question is how to reserve access to the shared resource - either through an exported function in the mfd driver

Re: [PATCH 3/4] gpio: Kontron PLD gpio driver

2013-04-09 Thread Guenter Roeck
On Tue, Apr 09, 2013 at 10:46:15AM +0200, Linus Walleij wrote: On Mon, Apr 8, 2013 at 7:15 PM, Kevin Strasser kevin.stras...@linux.intel.com wrote: From: Michael Brunner michael.brun...@kontron.com Add gpio support for the on-board PLD found on some Kontron embedded modules.

Re: mfd: Core driver for Winbond chips

2013-04-09 Thread Guenter Roeck
On Tue, Apr 09, 2013 at 07:31:15PM +0200, Wim Van Sebroeck wrote: Hi Guenter, I was waiting for feedback from Wim, who submitted a similar driver, about his thoughts. Key question is how to reserve access to the shared resource - either through an exported function in the

Re: [RFC PATCH] watchdog: Add hook for kicking in kdump path

2013-04-10 Thread Guenter Roeck
On Wed, Apr 10, 2013 at 09:40:39AM -0400, Don Zickus wrote: On Tue, Apr 09, 2013 at 09:07:58AM -0700, Guenter Roeck wrote: Just look for the use of mod_timer in the watchdog directory. So looking at the mod_timer logic in various drivers, it seems regardless if the /dev/watchdog

Re: [RFC PATCH] watchdog: Add hook for kicking in kdump path

2013-04-10 Thread Guenter Roeck
On Wed, Apr 10, 2013 at 10:20:55AM -0400, Don Zickus wrote: On Wed, Apr 10, 2013 at 06:51:23AM -0700, Guenter Roeck wrote: On Wed, Apr 10, 2013 at 09:40:39AM -0400, Don Zickus wrote: On Tue, Apr 09, 2013 at 09:07:58AM -0700, Guenter Roeck wrote: Just look for the use of mod_timer

Re: [RFC PATCH] watchdog: Add hook for kicking in kdump path

2013-04-10 Thread Guenter Roeck
On Wed, Apr 10, 2013 at 12:17:39PM -0400, Don Zickus wrote: On Wed, Apr 10, 2013 at 08:10:41AM -0700, Guenter Roeck wrote: On Wed, Apr 10, 2013 at 10:20:55AM -0400, Don Zickus wrote: On Wed, Apr 10, 2013 at 06:51:23AM -0700, Guenter Roeck wrote: On Wed, Apr 10, 2013 at 09:40:39AM -0400

Re: [PATCH 4/4] watchdog: Kontron PLD watchdog timer

2013-04-10 Thread Guenter Roeck
On Mon, Apr 08, 2013 at 10:15:21AM -0700, Kevin Strasser wrote: From: Michael Brunner michael.brun...@kontron.com Add watchdog timer support for the on-board PLD found on some Kontron embedded modules. Signed-off-by: Michael Brunner michael.brun...@kontron.com Signed-off-by: Kevin

Re: [PATCH 2/4] i2c: Kontron PLD i2c bus driver

2013-04-10 Thread Guenter Roeck
On Mon, Apr 08, 2013 at 10:15:19AM -0700, Kevin Strasser wrote: From: Michael Brunner michael.brun...@kontron.com Add i2c support for the on-board PLD found on some Kontron embedded modules. Signed-off-by: Michael Brunner michael.brun...@kontron.com Signed-off-by: Kevin Strasser

Re: [RFC PATCH] watchdog: Add hook for kicking in kdump path

2013-04-10 Thread Guenter Roeck
On Wed, Apr 10, 2013 at 12:49:14PM -0400, David Teigland wrote: On Wed, Apr 10, 2013 at 09:40:39AM -0400, Don Zickus wrote: However, we still have the problem that if the machine panics and we want to jump into the kdump kernel, we need to 'kick' the watchdog one more time. This provides

Re: [PATCH] hrtimer, add expiry time overflow check in hrtimer_interrupt

2013-04-10 Thread Guenter Roeck
Prarit: Should this be tagged for -stable? Please. I am hitting this problem with 3.8.6 on powerpc. The patch fixes it for me. Tested-by: Guenter Roeck li...@roeck-us.net Guenter -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

Re: [NEW DRIVER V4 7/7] DA9058 REGULATOR driver

2013-04-12 Thread Guenter Roeck
On Fri, Apr 12, 2013 at 02:05:28PM +0100, Anthony Olech wrote: This is the REGULATOR component driver of the Dialog DA9058 PMIC. This driver is just one component of the whole DA9058 PMIC driver. It depends on the CORE component driver of the DA9058 MFD. There are 6 warnings from

Re: [PATCH 2/2] watchdog: fix cleanup device code on registration

2013-04-12 Thread Guenter Roeck
On Fri, Apr 12, 2013 at 06:51:48AM +, Kim, Milo wrote: Duplicate lines of code are moved to cleanup_dev section. And it returns 0 explicitly in case of no error. Signed-off-by: Milo(Woogyom) Kim milo@ti.com --- drivers/watchdog/watchdog_dev.c | 18 +- 1 file

Re: [NEW DRIVER V4 6/7] DA9058 HWMON driver

2013-04-12 Thread Guenter Roeck
On Fri, Apr 12, 2013 at 02:05:28PM +0100, Anthony Olech wrote: This is the HWMON component driver of the Dialog DA9058 PMIC. This driver is just one component of the whole DA9058 PMIC driver. It depends on the CORE and ADC component drivers of the DA9058 MFD. Signed-off-by: Anthony Olech

Re: [PATCH 1/2] watchdog: introduce new watchdog AUTOSTART option

2013-04-12 Thread Guenter Roeck
On Fri, Apr 12, 2013 at 06:51:47AM +, Kim, Milo wrote: Conventionally, watchdog timer driver is activated by an user space request. This patch enables an automatic start/ping operation of a watchdog without an application. (a) Work flow If a watchdog timer driver is configured with

Re: [RFC PATCH] watchdog: Add hook for kicking in kdump path

2013-04-12 Thread Guenter Roeck
On Fri, Apr 12, 2013 at 05:16:27PM -0400, Don Zickus wrote: On Wed, Apr 10, 2013 at 08:10:41AM -0700, Guenter Roeck wrote: have no idea how to even find out if multiple watchdogs are open on the system. Is there a list I could walk? And with regard to 'watchdog is /* the dev_t

Re: [PATCH] documentation: hwmon: Fix typo in documentation/hwmon

2013-04-12 Thread Guenter Roeck
On Sat, Apr 13, 2013 at 01:22:11AM +0900, Masanari Iida wrote: Correct spelling typo in Documentation/hwmon Signed-off-by: Masanari Iida standby2...@gmail.com --- Documentation/hwmon/adt7410 | 2 +- Documentation/hwmon/sht15 | 2 +- Documentation/hwmon/zl6100 | 2 +- 3 files changed,

Re: [NEW DRIVER V4 6/7] DA9058 HWMON driver

2013-04-12 Thread Guenter Roeck
On Fri, Apr 12, 2013 at 05:53:48PM +0200, Lars-Peter Clausen wrote: On 04/12/2013 03:05 PM, Anthony Olech wrote: This is the HWMON component driver of the Dialog DA9058 PMIC. This driver is just one component of the whole DA9058 PMIC driver. It depends on the CORE and ADC component drivers

[PATCH] gcc4: Disable __compiletime_object_size for GCC 4.6+

2013-04-12 Thread Guenter Roeck
/include/asm/uaccess_32.h:211:26: error: call to 'copy_from_user_overflow' declared with attribute error: copy_from_user() buffer size is not provably correct make[3]: [sound/oss/sb_audio.o] Error 1 (ignored) Disable it where broken. Signed-off-by: Guenter Roeck li...@roeck-us.net

Re: [GIT PULL REQUEST] watchdog - v3.9-rc6 Fixes

2013-04-14 Thread Guenter Roeck
On Sun, Apr 14, 2013 at 09:17:03AM +0200, Wim Van Sebroeck wrote: Hi Linus, Please pull from 'master' branch of git://www.linux-watchdog.org/linux-watchdog.git It will fix compile errors for teh at91rm9200_wdt driver. This will update the following files: Kconfig |2 +- 1

Re: gpio-ucb1400

2013-03-30 Thread Guenter Roeck
On Fri, Mar 29, 2013 at 08:46:39PM +0100, Jean Delvare wrote: Hi all, In September 2009, a driver for the GPIO function of the UCB1400 chip was added to the kernel tree. The probe function of this driver requires ucbdata to be set. The only place where this happens is in function

Re: gpio-ucb1400

2013-03-30 Thread Guenter Roeck
On Sat, Mar 30, 2013 at 08:20:44PM +0100, Marek Vasut wrote: Dear Guenter Roeck, On Fri, Mar 29, 2013 at 08:46:39PM +0100, Jean Delvare wrote: Hi all, In September 2009, a driver for the GPIO function of the UCB1400 chip was added to the kernel tree. The probe function

Re: [PATCH v7 5/5] hwmon: add ST-Ericsson ABX500 hwmon driver

2013-03-30 Thread Guenter Roeck
On Sat, Mar 30, 2013 at 04:18:18PM -0700, Anton Vorontsov wrote: On Wed, Mar 27, 2013 at 12:48:07PM -0700, Guenter Roeck wrote: On Wed, Mar 27, 2013 at 03:13:32PM +0800, Hongbo Zhang wrote: Each of ST-Ericsson X500 chip set series consists of both ABX500 and DBX500 chips

Re: [PATCHv2 2/2] watchdog: fix w83627hf_wdt reboot due to timeout expired

2013-03-30 Thread Guenter Roeck
On Sat, Mar 30, 2013 at 06:59:08PM -0700, Tony Chung wrote: Observed that the w83627hf watchdog timer start counting during reboot. If the system load the driver after 5 minutes, it rebooted immediately because of timer expired. For example, fsck took more than 5 minutes to run, then reboot

Re: [PATCHv2 2/2] watchdog: fix w83627hf_wdt reboot due to timeout expired

2013-03-31 Thread Guenter Roeck
On Sun, Mar 31, 2013 at 08:45:54AM -0700, Tony Chung wrote: How about this? - t = ~0xC0; /* disable keyboard mouse turning off - watchdog */ + t = ~0xE0; /* clear timeout occurred and disable keyboard +

[PATCH] misc/vmw_vmci: VMWARE_VMCI depends on NET

2013-03-31 Thread Guenter Roeck
Fix: ERROR: memcpy_toiovec [drivers/misc/vmw_vmci/vmw_vmci.ko] undefined! ERROR: memcpy_fromiovec [drivers/misc/vmw_vmci/vmw_vmci.ko] undefined! Both functions are defined in the core networking code. Signed-off-by: Guenter Roeck li...@roeck-us.net --- drivers/misc/vmw_vmci/Kconfig |2

[PATCH] drm/tilcdc: Disable building as module

2013-04-01 Thread Guenter Roeck
be done separately. Cc: Rob Clark robdcl...@gmail.com Signed-off-by: Guenter Roeck li...@roeck-us.net --- drivers/gpu/drm/tilcdc/Kconfig |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/tilcdc/Kconfig b/drivers/gpu/drm/tilcdc/Kconfig index d24d040..6ddb729 100644

[PATCH] of_net.h: Provide dummy functions if OF_NET is not configured

2013-04-01 Thread Guenter Roeck
if OF_NET is not configured. This is safe because all callers do check the return values. If desired, at least some of the #ifdefs in the code can subsequently be removed. Cc: David Daney david.da...@cavium.com Signed-off-by: Guenter Roeck li...@roeck-us.net --- include/linux/of_net.h | 10

Re: [PATCH] of_net.h: Provide dummy functions if OF_NET is not configured

2013-04-01 Thread Guenter Roeck
On Mon, Apr 01, 2013 at 01:44:24PM -0500, Rob Herring wrote: On 04/01/2013 01:19 PM, Guenter Roeck wrote: of_get_mac_address() and of_get_phy_mode() are only provided if OF_NET is configured. While most callers check for the define, not all do, and those who do require #ifdef around

Re: [PATCH] misc/vmw_vmci: VMWARE_VMCI depends on NET

2013-04-01 Thread Guenter Roeck
On Mon, Apr 01, 2013 at 12:29:39PM -0700, Greg Kroah-Hartman wrote: On Sun, Mar 31, 2013 at 09:43:59PM -0700, Guenter Roeck wrote: Fix: ERROR: memcpy_toiovec [drivers/misc/vmw_vmci/vmw_vmci.ko] undefined! ERROR: memcpy_fromiovec [drivers/misc/vmw_vmci/vmw_vmci.ko] undefined! Both

Re: [PATCH] misc/vmw_vmci: VMWARE_VMCI depends on NET

2013-04-01 Thread Guenter Roeck
On Mon, Apr 01, 2013 at 01:11:52PM -0700, Greg Kroah-Hartman wrote: On Mon, Apr 01, 2013 at 01:02:35PM -0700, Guenter Roeck wrote: On Mon, Apr 01, 2013 at 12:29:39PM -0700, Greg Kroah-Hartman wrote: On Sun, Mar 31, 2013 at 09:43:59PM -0700, Guenter Roeck wrote: Fix: ERROR

Re: [PATCH v3 2/2] watchdog: fix w83627hf_wdt clear timeout expired

2013-04-01 Thread Guenter Roeck
On Sun, Mar 31, 2013 at 10:59:32PM -0700, Tony Chung wrote: Observed that the w83627hf watchdog timer start counting during reboot. If the system load the driver after 5 minutes, it rebooted immediately because of timer expired. For example, fsck took more than 5 minutes to run, then the

Re: UIO device tree bindings.

2013-04-01 Thread Guenter Roeck
On Mon, Apr 01, 2013 at 05:40:08PM +0200, Pavel Machek wrote: On Mon 2013-04-01 16:23:36, Pavel Machek wrote: Hi! I'd like to get uio device tree bindings to work -- with recent FPGA parts it will be important. Latest version I see is

Re: UIO device tree bindings.

2013-04-02 Thread Guenter Roeck
On Tue, Apr 02, 2013 at 01:51:51PM +0200, Pavel Machek wrote: On Mon 2013-04-01 19:42:12, Guenter Roeck wrote: On Mon, Apr 01, 2013 at 05:40:08PM +0200, Pavel Machek wrote: On Mon 2013-04-01 16:23:36, Pavel Machek wrote: Hi! I'd like to get uio device tree bindings to work

Re: UIO device tree bindings.

2013-04-02 Thread Guenter Roeck
On Tue, Apr 02, 2013 at 03:46:45PM +0200, Pavel Machek wrote: Hi! Or maybe we can do some magic with module parameter. That should be enough for expected use. I don't think that would make a difference. I mean, just take ns16550 as another example. No one has problems

[PATCH 0/5] Provide empty functions if OF_NET is not configured

2013-04-02 Thread Guenter Roeck
Provide empty functions for of_get_phy_mode() and of_get_mac_address() if OF_NET is not configured. Modify affected drivers to rely on the now available functions. Guenter Roeck (5): of_net.h: Provide dummy functions if OF_NET

[PATCH 2/5] net/cadence/at91_ether: Simplify OF dependencies

2013-04-02 Thread Guenter Roeck
-end functions and call of_get_mac_address() and of_get_phy_mode() directly instead. Signed-off-by: Guenter Roeck li...@roeck-us.net --- drivers/net/ethernet/cadence/at91_ether.c | 44 - 1 file changed, 6 insertions(+), 38 deletions(-) diff --git a/drivers/net

[PATCH 4/5] net/freescale/fec: Simplify OF dependencies

2013-04-02 Thread Guenter Roeck
an OF dependent function as front-end. Also, the function depends on OF_NET, not on OF, so the conditional code was not correct anyway. Drop the front-end function and call of_get_phy_mode() directly. Signed-off-by: Guenter Roeck li...@roeck-us.net --- drivers/net/ethernet/freescale/fec.c | 19

[PATCH 5/5] net/nxp/lpc_eth: Drop ifdef CONFIG_OF_NET

2013-04-02 Thread Guenter Roeck
Since of_get_mac_address() is now declared even if CONFIG_OF_NET is not configured, the ifdef is no longer necessary and can be removed. Signed-off-by: Guenter Roeck li...@roeck-us.net --- drivers/net/ethernet/nxp/lpc_eth.c |2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net

[PATCH 3/5] net/cadence/macb: Simplify OF dependencies

2013-04-02 Thread Guenter Roeck
-end functions and call of_get_mac_address() and of_get_phy_mode() directly instead. Signed-off-by: Guenter Roeck li...@roeck-us.net --- drivers/net/ethernet/cadence/macb.c | 43 +-- 1 file changed, 6 insertions(+), 37 deletions(-) diff --git a/drivers/net

[PATCH 1/5] of_net.h: Provide empty functions if OF_NET is not configured

2013-04-02 Thread Guenter Roeck
is not configured. This is safe because all callers do check the return values. Cc: David Daney david.da...@cavium.com Signed-off-by: Guenter Roeck li...@roeck-us.net Acked-by: Rob Herring rob.herr...@calxeda.com --- include/linux/of_net.h | 10 ++ 1 file changed, 10 insertions(+) diff --git

Re: [PATCH v3 2/2] watchdog: fix w83627hf_wdt clear timeout expired

2013-04-02 Thread Guenter Roeck
On Mon, Apr 01, 2013 at 09:59:00PM -0700, Tony Chung wrote: Thanks Guenter! I agree with you. My first reaction was also about a small watchdog server that will start in early boot process. There are pros and cons. For example, there are many types of watchdog devices such as

  1   2   3   4   5   6   7   8   9   10   >