[PATCH v3 1/1] phy: micrel: Fix finding PHY properties in MAC node for KSZ9031.

2016-01-07 Thread Henri Roosen
cked-by: Andrew Lunn <and...@lunn.ch> Signed-off-by: Henri Roosen <henri.roo...@ginzinger.com> --- Changes since v2: - removed unnecessary empty line drivers/net/phy/micrel.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/net/phy/micrel.c

[PATCH 1/1] phy: micrel: Fix finding PHY properties in MAC node for KSZ9031.

2015-12-22 Thread Henri Roosen
Commit 651df2183543 ("phy: micrel: Fix finding PHY properties in MAC node.") only fixes finding PHY properties in MAC node for KSZ9021. This commit applies the same fix for KSZ9031. Signed-off-by: Henri Roosen <henri.roo...@ginzinger.com> --- drivers/net/phy/micrel.c | 13 +

[PATCH v2 1/1] phy: micrel: Fix finding PHY properties in MAC node for KSZ9031.

2015-12-23 Thread Henri Roosen
Commit 651df2183543 ("phy: micrel: Fix finding PHY properties in MAC node.") only fixes finding PHY properties in MAC node for KSZ9021. This commit applies the same fix for KSZ9031. Signed-off-by: Henri Roosen <henri.roo...@ginzinger.com> --- drivers/net/phy/micrel.c | 13 +

Re: [PATCH 1/1] phy: micrel: Fix finding PHY properties in MAC node for KSZ9031.

2015-12-23 Thread Henri Roosen
On 12/22/2015 11:14 PM, David Miller wrote: From: Andrew Lunn <and...@lunn.ch> Date: Tue, 22 Dec 2015 12:06:34 +0100 On Tue, Dec 22, 2015 at 11:58:40AM +0100, Henri Roosen wrote: Commit 651df2183543 ("phy: micrel: Fix finding PHY properties in MAC node.") only fixes findin

Re: [PATCH 1/1] phy: micrel: Fix finding PHY properties in MAC node for KSZ9031.

2015-12-23 Thread Henri Roosen
On 12/22/2015 11:14 PM, David Miller wrote: From: Andrew Lunn <and...@lunn.ch> Date: Tue, 22 Dec 2015 12:06:34 +0100 On Tue, Dec 22, 2015 at 11:58:40AM +0100, Henri Roosen wrote: Commit 651df2183543 ("phy: micrel: Fix finding PHY properties in MAC node.") only fixes findin

Re: [PATCH V2 2/2] rt: Increase/decrease the nr of migratory tasks when enabling/disabling migration

2017-06-27 Thread Henri Roosen
On 06/26/2017 05:07 PM, Daniel Bristot de Oliveira wrote: There is a problem in the migrate_disable()/enable() implementation regarding the number of migratory tasks in the rt/dl RQs. The problem is the following: When a task is attached to the rt runqueue, it is checked if it either can run in

[PATCH 1/1] remoteproc: fix elf_loader da_to_va translation and writing beyond segment

2017-05-03 Thread Henri Roosen
. The actual memcpy of the segment was already correctly using the FileSiz for length, however the unnecessary "Zero out remaining memory" would write beyond the 0x1fff end of the memory region! This patch removes the harmful code. Signed-off-by: Henri Roosen <henri.roo...@ginzinger.com&

Re: [PATCH 1/1] remoteproc: fix elf_loader da_to_va translation and writing beyond segment

2017-05-15 Thread Henri Roosen
On 05/14/2017 06:14 AM, Bjorn Andersson wrote: On Thu 11 May 09:12 PDT 2017, Henri Roosen wrote: On 05/11/2017 02:05 AM, Bjorn Andersson wrote: On Wed 03 May 05:12 PDT 2017, Henri Roosen wrote: Consider a system with 2 memory regions: 0x1fff8000 - 0x1fff: iram So I presume there's

Re: [PATCH 1/1] remoteproc: fix elf_loader da_to_va translation and writing beyond segment

2017-05-11 Thread Henri Roosen
On 05/11/2017 02:05 AM, Bjorn Andersson wrote: On Wed 03 May 05:12 PDT 2017, Henri Roosen wrote: Consider a system with 2 memory regions: 0x1fff8000 - 0x1fff: iram So I presume there's a hole here. 0x2100 - 0x21007fff: dram The .elf file for this system contains the following

Re: [PATCH] rpmsg: rpmsg_core: fix null-ptr dereference for devices without ops

2017-06-26 Thread Henri Roosen
On 06/25/2017 11:51 PM, Bjorn Andersson wrote: On Fri 02 Jun 04:35 PDT 2017, Henri Roosen wrote: A device might not have an ops structure registered. This patch fixes a null-prt dereference by checking ops before dereferencing it. In what scenario do you end up with a rpdev without ops

Re: [PATCH] rpmsg: Release rpmsg devices in backends

2017-06-02 Thread Henri Roosen
The rpmsg devices are allocated in the backends and as such must be freed there as well. Signed-off-by: Bjorn Andersson --- drivers/rpmsg/qcom_smd.c | 11 +++ drivers/rpmsg/virtio_rpmsg_bus.c | 9 + 2 files changed, 20 insertions(+) diff

[PATCH] rpmsg: virtio_rpmsg_bus: fix nameservice address

2017-06-02 Thread Henri Roosen
Commit 2a48d7322dc8 ("rpmsg: rpmsg_send() operations takes rpmsg_endpoint") only changed the nameservice address for virtio_rpmsg_announce_create() but did not do the same change for virtio_rpmsg_announce_destroy(). Signed-off-by: Henri Roosen <henri.roo...@ginzinger.com> --

[PATCH] rpmsg: virtio_rpmsg_bus: cleanup multiple assignment to ops

2017-06-02 Thread Henri Roosen
Trivial cleanup: the .ops pointer is assigned twice. This patch removes the first assignment. Signed-off-by: Henri Roosen <henri.roo...@ginzinger.com> --- drivers/rpmsg/virtio_rpmsg_bus.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/rpmsg/virtio_rpmsg_bus.c b/drivers

[PATCH] rpmsg: cleanup incorrect function in dev_err message

2017-06-02 Thread Henri Roosen
Trivial cleanup for incorrect function in dev_err message Signed-off-by: Henri Roosen <henri.roo...@ginzinger.com> --- drivers/rpmsg/rpmsg_char.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/rpmsg/rpmsg_char.c b/drivers/rpmsg/rpmsg_char.c index 0ca2ccc..0

[PATCH] rpmsg: virtio_rpmsg_bus: fix announce for devices without endpoint

2017-06-02 Thread Henri Roosen
A device might not have an endpoint assigned. This patch checks if rpdev->ept has a value before dereferencing or using it. Signed-off-by: Henri Roosen <henri.roo...@ginzinger.com> --- drivers/rpmsg/virtio_rpmsg_bus.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) d

[PATCH] rpmsg: rpmsg_core: fix null-ptr dereference for devices without ops

2017-06-02 Thread Henri Roosen
A device might not have an ops structure registered. This patch fixes a null-prt dereference by checking ops before dereferencing it. Signed-off-by: Henri Roosen <henri.roo...@ginzinger.com> --- drivers/rpmsg/rpmsg_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [PATCH V2 2/2] rt: Increase/decrease the nr of migratory tasks when enabling/disabling migration

2017-06-27 Thread Henri Roosen
On 06/26/2017 05:07 PM, Daniel Bristot de Oliveira wrote: There is a problem in the migrate_disable()/enable() implementation regarding the number of migratory tasks in the rt/dl RQs. The problem is the following: When a task is attached to the rt runqueue, it is checked if it either can run in

Re: [PATCH] rpmsg: Release rpmsg devices in backends

2017-06-02 Thread Henri Roosen
The rpmsg devices are allocated in the backends and as such must be freed there as well. Signed-off-by: Bjorn Andersson --- drivers/rpmsg/qcom_smd.c | 11 +++ drivers/rpmsg/virtio_rpmsg_bus.c | 9 + 2 files changed, 20 insertions(+) diff --git

[PATCH] rpmsg: rpmsg_core: fix null-ptr dereference for devices without ops

2017-06-02 Thread Henri Roosen
A device might not have an ops structure registered. This patch fixes a null-prt dereference by checking ops before dereferencing it. Signed-off-by: Henri Roosen --- drivers/rpmsg/rpmsg_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rpmsg/rpmsg_core.c b

[PATCH] rpmsg: cleanup incorrect function in dev_err message

2017-06-02 Thread Henri Roosen
Trivial cleanup for incorrect function in dev_err message Signed-off-by: Henri Roosen --- drivers/rpmsg/rpmsg_char.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/rpmsg/rpmsg_char.c b/drivers/rpmsg/rpmsg_char.c index 0ca2ccc..0b5d0d3 100644 --- a/drivers/rpmsg

[PATCH] rpmsg: virtio_rpmsg_bus: fix announce for devices without endpoint

2017-06-02 Thread Henri Roosen
A device might not have an endpoint assigned. This patch checks if rpdev->ept has a value before dereferencing or using it. Signed-off-by: Henri Roosen --- drivers/rpmsg/virtio_rpmsg_bus.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/rpmsg/virtio_rpmsg_bus.

[PATCH] rpmsg: virtio_rpmsg_bus: cleanup multiple assignment to ops

2017-06-02 Thread Henri Roosen
Trivial cleanup: the .ops pointer is assigned twice. This patch removes the first assignment. Signed-off-by: Henri Roosen --- drivers/rpmsg/virtio_rpmsg_bus.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/rpmsg/virtio_rpmsg_bus.c b/drivers/rpmsg/virtio_rpmsg_bus.c index 3c582f2

[PATCH] rpmsg: virtio_rpmsg_bus: fix nameservice address

2017-06-02 Thread Henri Roosen
Commit 2a48d7322dc8 ("rpmsg: rpmsg_send() operations takes rpmsg_endpoint") only changed the nameservice address for virtio_rpmsg_announce_create() but did not do the same change for virtio_rpmsg_announce_destroy(). Signed-off-by: Henri Roosen --- drivers/rpmsg/virtio_rpmsg_bus.c | 2

Re: [PATCH 1/1] remoteproc: fix elf_loader da_to_va translation and writing beyond segment

2017-05-15 Thread Henri Roosen
On 05/14/2017 06:14 AM, Bjorn Andersson wrote: On Thu 11 May 09:12 PDT 2017, Henri Roosen wrote: On 05/11/2017 02:05 AM, Bjorn Andersson wrote: On Wed 03 May 05:12 PDT 2017, Henri Roosen wrote: Consider a system with 2 memory regions: 0x1fff8000 - 0x1fff: iram So I presume there's

[PATCH 1/1] remoteproc: fix elf_loader da_to_va translation and writing beyond segment

2017-05-03 Thread Henri Roosen
. The actual memcpy of the segment was already correctly using the FileSiz for length, however the unnecessary "Zero out remaining memory" would write beyond the 0x1fff end of the memory region! This patch removes the harmful code. Signed-off-by: Henri Roosen --- drivers/

Re: [PATCH 1/1] remoteproc: fix elf_loader da_to_va translation and writing beyond segment

2017-05-11 Thread Henri Roosen
On 05/11/2017 02:05 AM, Bjorn Andersson wrote: On Wed 03 May 05:12 PDT 2017, Henri Roosen wrote: Consider a system with 2 memory regions: 0x1fff8000 - 0x1fff: iram So I presume there's a hole here. 0x2100 - 0x21007fff: dram The .elf file for this system contains the following

Re: [PATCH] rpmsg: rpmsg_core: fix null-ptr dereference for devices without ops

2017-06-26 Thread Henri Roosen
On 06/25/2017 11:51 PM, Bjorn Andersson wrote: On Fri 02 Jun 04:35 PDT 2017, Henri Roosen wrote: A device might not have an ops structure registered. This patch fixes a null-prt dereference by checking ops before dereferencing it. In what scenario do you end up with a rpdev without ops

[PATCH v3 1/1] phy: micrel: Fix finding PHY properties in MAC node for KSZ9031.

2016-01-07 Thread Henri Roosen
cked-by: Andrew Lunn Signed-off-by: Henri Roosen --- Changes since v2: - removed unnecessary empty line drivers/net/phy/micrel.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c index e13ad6c..7a56799 100644 -

[PATCH 1/1] phy: micrel: Fix finding PHY properties in MAC node for KSZ9031.

2015-12-22 Thread Henri Roosen
Commit 651df2183543 ("phy: micrel: Fix finding PHY properties in MAC node.") only fixes finding PHY properties in MAC node for KSZ9021. This commit applies the same fix for KSZ9031. Signed-off-by: Henri Roosen --- drivers/net/phy/micrel.c | 13 +++-- 1 file changed, 11 insert

Re: [PATCH 1/1] phy: micrel: Fix finding PHY properties in MAC node for KSZ9031.

2015-12-23 Thread Henri Roosen
On 12/22/2015 11:14 PM, David Miller wrote: From: Andrew Lunn Date: Tue, 22 Dec 2015 12:06:34 +0100 On Tue, Dec 22, 2015 at 11:58:40AM +0100, Henri Roosen wrote: Commit 651df2183543 ("phy: micrel: Fix finding PHY properties in MAC node.") only fixes finding PHY properties i

Re: [PATCH 1/1] phy: micrel: Fix finding PHY properties in MAC node for KSZ9031.

2015-12-23 Thread Henri Roosen
On 12/22/2015 11:14 PM, David Miller wrote: From: Andrew Lunn Date: Tue, 22 Dec 2015 12:06:34 +0100 On Tue, Dec 22, 2015 at 11:58:40AM +0100, Henri Roosen wrote: Commit 651df2183543 ("phy: micrel: Fix finding PHY properties in MAC node.") only fixes finding PHY properties i

[PATCH v2 1/1] phy: micrel: Fix finding PHY properties in MAC node for KSZ9031.

2015-12-23 Thread Henri Roosen
Commit 651df2183543 ("phy: micrel: Fix finding PHY properties in MAC node.") only fixes finding PHY properties in MAC node for KSZ9021. This commit applies the same fix for KSZ9031. Signed-off-by: Henri Roosen --- drivers/net/phy/micrel.c | 13 +++-- 1 file changed, 11 insert