Re: 20% performance drop on PostgreSQL 9.2 from kernel 3.5.3 to 3.6-rc5 on AMD chipsets - bisected

2012-09-25 Thread Hillf Danton
On Tue, Sep 25, 2012 at 12:54 AM, Peter Zijlstra a.p.zijls...@chello.nl wrote: On Mon, 2012-09-24 at 09:33 -0700, Linus Torvalds wrote: Sure, the scan bits bitops will return = nr_cpu_ids for the I couldn't find a bit thing, but that doesn't mean that everything else should. Fair enough..

Re: [PATCH] MM: Support more pagesizes for MAP_HUGETLB/SHM_HUGETLB v6

2012-10-19 Thread Hillf Danton
tree. v4: Ported to latest tree. Minor changes for review feedback. Updated description. v5: Remove unnecessary prototypes to fix merge error (Hillf Danton) v6: Rebased. Fix some unlikely error paths (Hillf Danton) Acked-by: Rik van Riel r...@redhat.com Acked-by: KAMEZAWA Hiroyuki kamezawa.hir

Re: [PATCH] MM: Support more pagesizes for MAP_HUGETLB/SHM_HUGETLB v4

2012-10-13 Thread Hillf Danton
Hi Andi, On Fri, Oct 12, 2012 at 7:53 AM, Andi Kleen a...@firstfloor.org wrote: diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h index 2251648..c626a2a 100644 --- a/include/linux/hugetlb.h +++ b/include/linux/hugetlb.h @@ -183,7 +183,13 @@ extern const struct file_operations

Re: [PATCH v2 1/7] swiotlb: Make io_tlb_end a physical address instead of a virtual one

2012-10-13 Thread Hillf Danton
Hi Alexander, On Fri, Oct 12, 2012 at 4:34 AM, Alexander Duyck alexander.h.du...@intel.com wrote: This change replaces all references to the virtual address for io_tlb_end with references to the physical address io_tlb_end. The main advantage of replacing the virtual address with a physical

Re: Local DoS through write heavy I/O on CFQ Deadline

2012-10-13 Thread Hillf Danton
Hi Alex, On Sat, Oct 13, 2012 at 12:29 AM, Alex Bligh a...@alex.org.uk wrote: Michael, --On 12 October 2012 16:58:39 +0200 Michal Hocko mho...@suse.cz wrote: Once dirty_ratio (resp. dirty_bytes) limit is hit then the process which writes gets throttled. If this is not the case then there is

Re: Local DoS through write heavy I/O on CFQ Deadline

2012-10-13 Thread Hillf Danton
On Sun, Oct 14, 2012 at 3:33 AM, Alex Bligh a...@alex.org.uk wrote: Or perhaps I have the wrong end of the stick. Never mind a friendly link:) -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH] MM: Support more pagesizes for MAP_HUGETLB/SHM_HUGETLB v5

2012-10-13 Thread Hillf Danton
Hi Andi, On Sat, Oct 13, 2012 at 11:38 PM, Andi Kleen a...@firstfloor.org wrote: v2: Port to new tree. Fix unmount. v3: Ported to latest tree. v4: Ported to latest tree. Minor changes for review feedback. Updated description. v5: Remove unnecessary prototypes to fix merge error (Hillf

Re: [PATCH] rcu: restore correct batch limiting

2012-10-17 Thread Hillf Danton
Hi Eric, On Wed, Oct 17, 2012 at 3:14 PM, Eric Dumazet eric.duma...@gmail.com wrote: From: Eric Dumazet eduma...@google.com Commit 29c00b4a1d9e27 (rcu: Add event-tracing for RCU callback invocation) added a regression in rcu_do_batch() Under stress, RCU is supposed to allow to process all

Re: [patch for-3.7] fs, xattr: fix bug when removing a name not in xattr list

2012-10-18 Thread Hillf Danton
Hi David, On Thu, Oct 18, 2012 at 11:41 AM, David Rientjes rient...@google.com wrote: Commit 38f38657444d (xattr: extract simple_xattr code from tmpfs) moved some code from tmpfs but introduced a subtle bug along the way. That commit is fine but you did revert commit b9d6cfdeaf67(xattr: mark

Re: PROBLEM: Silent data corruption when using sendfile()

2012-07-14 Thread Hillf Danton
On Sat, Jul 14, 2012 at 4:20 PM, Eric Dumazet eric.duma...@gmail.com wrote: Might be, or not (could be a NIC bug) Dunno why sendfile sits in the layer of NIC and how they interact. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to

Re: OOPS with 3.9.0rc2+

2013-03-13 Thread Hillf Danton
On Wed, Mar 13, 2013 at 11:44 PM, Borislav Petkov b...@alien8.de wrote: + dri-devel. On Wed, Mar 13, 2013 at 02:34:31PM +0100, Rolf Offermanns wrote: Hi, I get a kernel oops / panic with a 3.9.0rc2+ kernel (git from 2h ago) on my Sony Vaio laptop. It happened with rc1, too.

Re: Kernel oops on mmap ?

2013-03-13 Thread Hillf Danton
[cc Russell] On Wed, Mar 13, 2013 at 11:04 PM, Mark Jackson mpfj-l...@mimc.co.uk wrote: Can any help diagnose what my userspace task is doing to get the followings oops ? [ 42.587772] Unable to handle kernel paging request at virtual address bfac6004 [ 42.595431] pgd = cf748000 [

Re: Inactive memory keep growing and how to release it?

2013-03-14 Thread Hillf Danton
On Sat, Mar 9, 2013 at 10:14 AM, Will Huck will.hu...@gmail.com wrote: Cc experts. Hugh, Johannes, On 03/04/2013 08:21 PM, Lenky Gao wrote: 2013/3/4 Zlatko Calusic zlatko.calu...@iskon.hr: The drop_caches mechanism doesn't free dirty page cache pages. And your bash script is creating a

Re: [PATCH 1/1] mm/hugetlb: add more arch-defined huge_pte_xxx functions

2013-03-14 Thread Hillf Danton
On Thu, Mar 14, 2013 at 9:14 PM, Michal Hocko mho...@suse.cz wrote: Ouch, this adds a lot of code that is almost same for all archs except for some. Can we just make one common definition and define only those that differ, please? Wonder if he is the guy that added THP for s390, which was a

Re: [PATCHv2, RFC 03/30] mm: drop actor argument of do_generic_file_read()

2013-03-14 Thread Hillf Danton
On Fri, Mar 15, 2013 at 1:50 AM, Kirill A. Shutemov kirill.shute...@linux.intel.com wrote: From: Kirill A. Shutemov kirill.shute...@linux.intel.com There's only one caller of do_generic_file_read() and the only actor is file_read_actor(). No reason to have a callback parameter. This cleanup

Re: [PATCHv2, RFC 03/30] mm: drop actor argument of do_generic_file_read()

2013-03-14 Thread Hillf Danton
On Fri, Mar 15, 2013 at 1:50 AM, Kirill A. Shutemov kirill.shute...@linux.intel.com wrote: There's only one caller of do_generic_file_read() and the only actor is file_read_actor(). No reason to have a callback parameter. This cleanup is not urgent if it nukes no barrier for THP cache. Hillf

Re: [PATCHv2, RFC 00/30] Transparent huge page cache

2013-03-14 Thread Hillf Danton
On Fri, Mar 15, 2013 at 1:50 AM, Kirill A. Shutemov kirill.shute...@linux.intel.com wrote: Here's the second version of the patchset. The intend of the work is get code ready to enable transparent huge page cache for the most simple fs -- ramfs. Where is your git tree including THP cache?

Re: [PATCHv2, RFC 08/30] thp, mm: rewrite add_to_page_cache_locked() to support huge pages

2013-03-14 Thread Hillf Danton
On Fri, Mar 15, 2013 at 1:50 AM, Kirill A. Shutemov kirill.shute...@linux.intel.com wrote: + page_cache_get(page); + spin_lock_irq(mapping-tree_lock); + page-mapping = mapping; + page-index = offset; + error = radix_tree_insert(mapping-page_tree, offset, page);

Re: [PATCHv2, RFC 09/30] thp, mm: rewrite delete_from_page_cache() to support huge pages

2013-03-14 Thread Hillf Danton
On Fri, Mar 15, 2013 at 1:50 AM, Kirill A. Shutemov kirill.shute...@linux.intel.com wrote: + if (PageTransHuge(page)) { + int i; + + for (i = 0; i HPAGE_CACHE_NR; i++) + radix_tree_delete(mapping-page_tree, page-index + i); Move the

Re: [PATCHv2, RFC 13/30] thp, mm: implement grab_cache_huge_page_write_begin()

2013-03-14 Thread Hillf Danton
On Fri, Mar 15, 2013 at 1:50 AM, Kirill A. Shutemov kirill.shute...@linux.intel.com wrote: +#ifdef CONFIG_TRANSPARENT_HUGEPAGE +struct page *grab_cache_huge_page_write_begin(struct address_space *mapping, + pgoff_t index, unsigned flags); +#else +static inline struct

Re: [PATCHv2, RFC 14/30] thp, mm: naive support of thp in generic read/write routines

2013-03-14 Thread Hillf Danton
On Fri, Mar 15, 2013 at 1:50 AM, Kirill A. Shutemov kirill.shute...@linux.intel.com wrote: + if (PageTransTail(page)) { + page_cache_release(page); + page = find_get_page(mapping, + index

Re: [PATCHv2, RFC 16/30] thp: handle file pages in split_huge_page()

2013-03-15 Thread Hillf Danton
On Fri, Mar 15, 2013 at 1:50 AM, Kirill A. Shutemov kirill.shute...@linux.intel.com wrote: -int split_huge_page(struct page *page) +static int split_anon_huge_page(struct page *page) { struct anon_vma *anon_vma; int ret = 1; -

Re: [PATCHv2, RFC 19/30] thp, mm: split huge page on mmap file page

2013-03-15 Thread Hillf Danton
On Fri, Mar 15, 2013 at 1:50 AM, Kirill A. Shutemov kirill.shute...@linux.intel.com wrote: We are not ready to mmap file-backed tranparent huge pages. It is not on todo list either. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to

Re: [PATCHv2, RFC 23/30] thp: prepare zap_huge_pmd() to uncharge file pages

2013-03-15 Thread Hillf Danton
On Fri, Mar 15, 2013 at 1:50 AM, Kirill A. Shutemov kirill.shute...@linux.intel.com wrote: From: Kirill A. Shutemov kirill.shute...@linux.intel.com Uncharge pages from correct counter. Signed-off-by: Kirill A. Shutemov kirill.shute...@linux.intel.com --- mm/huge_memory.c |4 +++- 1

Re: [PATCHv2, RFC 24/30] thp: move maybe_pmd_mkwrite() out of mk_huge_pmd()

2013-03-15 Thread Hillf Danton
On Fri, Mar 15, 2013 at 1:50 AM, Kirill A. Shutemov kirill.shute...@linux.intel.com wrote: From: Kirill A. Shutemov kirill.shute...@linux.intel.com It's confusing that mk_huge_pmd() has sematics different from mk_pte() or mk_pmd(). Let's move maybe_pmd_mkwrite() out of mk_huge_pmd() and

Re: [PATCHv2, RFC 25/30] thp, mm: basic huge_fault implementation for generic_file_vm_ops

2013-03-15 Thread Hillf Danton
On Fri, Mar 15, 2013 at 1:50 AM, Kirill A. Shutemov kirill.shute...@linux.intel.com wrote: +#ifdef CONFIG_TRANSPARENT_HUGEPAGE +static int filemap_huge_fault(struct vm_area_struct *vma, struct vm_fault *vmf) +{ + struct file *file = vma-vm_file; + struct address_space *mapping

Re: [PATCHv2, RFC 08/30] thp, mm: rewrite add_to_page_cache_locked() to support huge pages

2013-03-15 Thread Hillf Danton
On Fri, Mar 15, 2013 at 9:23 PM, Kirill A. Shutemov kirill.shute...@linux.intel.com wrote: Hillf Danton wrote: On Fri, Mar 15, 2013 at 1:50 AM, Kirill A. Shutemov kirill.shute...@linux.intel.com wrote: + page_cache_get(page); + spin_lock_irq(mapping-tree_lock); + page

Re: [PATCHv2, RFC 13/30] thp, mm: implement grab_cache_huge_page_write_begin()

2013-03-15 Thread Hillf Danton
On Fri, Mar 15, 2013 at 9:24 PM, Kirill A. Shutemov kirill.shute...@linux.intel.com wrote: Hillf Danton wrote: On Fri, Mar 15, 2013 at 1:50 AM, Kirill A. Shutemov kirill.shute...@linux.intel.com wrote: +#ifdef CONFIG_TRANSPARENT_HUGEPAGE +struct page *grab_cache_huge_page_write_begin(struct

Re: [PATCHv2, RFC 16/30] thp: handle file pages in split_huge_page()

2013-03-15 Thread Hillf Danton
On Fri, Mar 15, 2013 at 9:26 PM, Kirill A. Shutemov kirill.shute...@linux.intel.com wrote: Hillf Danton wrote: On Fri, Mar 15, 2013 at 1:50 AM, Kirill A. Shutemov kirill.shute...@linux.intel.com wrote: -int split_huge_page(struct page *page) +static int split_anon_huge_page(struct page

Re: [PATCHv2, RFC 19/30] thp, mm: split huge page on mmap file page

2013-03-15 Thread Hillf Danton
On Fri, Mar 15, 2013 at 9:29 PM, Kirill A. Shutemov kirill.shute...@linux.intel.com wrote: Hillf Danton wrote: On Fri, Mar 15, 2013 at 1:50 AM, Kirill A. Shutemov kirill.shute...@linux.intel.com wrote: We are not ready to mmap file-backed tranparent huge pages. It is not on todo list

Re: [PATCHv2, RFC 13/30] thp, mm: implement grab_cache_huge_page_write_begin()

2013-03-15 Thread Hillf Danton
On Fri, Mar 15, 2013 at 9:35 PM, Kirill A. Shutemov kirill.shute...@linux.intel.com wrote: Hillf Danton wrote: On Fri, Mar 15, 2013 at 9:24 PM, Kirill A. Shutemov kirill.shute...@linux.intel.com wrote: Hillf Danton wrote: On Fri, Mar 15, 2013 at 1:50 AM, Kirill A. Shutemov kirill.shute

Re: [PATCHv2, RFC 08/30] thp, mm: rewrite add_to_page_cache_locked() to support huge pages

2013-03-15 Thread Hillf Danton
On Fri, Mar 15, 2013 at 9:50 PM, Kirill A. Shutemov kirill.shute...@linux.intel.com wrote: Hillf Danton wrote: On Fri, Mar 15, 2013 at 9:23 PM, Kirill A. Shutemov kirill.shute...@linux.intel.com wrote: Hillf Danton wrote: On Fri, Mar 15, 2013 at 1:50 AM, Kirill A. Shutemov kirill.shute

Re: use after free in sysfs_find_dirent

2013-03-16 Thread Hillf Danton
On Fri, Mar 15, 2013 at 1:04 PM, Sasha Levin levinsasha...@gmail.com wrote: On 03/15/2013 12:03 AM, Sasha Levin wrote: On 03/07/2013 01:26 AM, Dave Jones wrote: On Thu, Mar 07, 2013 at 02:02:30PM +0800, Greg Kroah-Hartman wrote: On Thu, Mar 07, 2013 at 12:28:54AM -0500, Dave Jones wrote:

Re: [PATCH 04/10] mm: vmscan: Decide whether to compact the pgdat based on reclaim progress

2013-03-18 Thread Hillf Danton
On Sun, Mar 17, 2013 at 9:04 PM, Mel Gorman mgor...@suse.de wrote: In the past, kswapd makes a decision on whether to compact memory after the pgdat was considered balanced. This more or less worked but it is late to make such a decision and does not fit well now that kswapd makes a decision

Re: kswapd craziness round 2

2013-03-07 Thread Hillf Danton
On Fri, Mar 8, 2013 at 3:37 AM, Jiri Slaby jsl...@suse.cz wrote: On 03/01/2013 03:02 PM, Hillf Danton wrote: On Fri, Mar 1, 2013 at 1:02 AM, Jiri Slaby jsl...@suse.cz wrote: Ok, no difference, kswap is still crazy. I'm attaching the output of grep -vw '0' /proc/vmstat if you see something

[PATCH] vmscan: minor cleanup for kswapd

2013-03-09 Thread Hillf Danton
The local variable, total_scanned, is no longer used, so clean up now. Signed-off-by: Hillf Danton dhi...@gmail.com --- --- a/mm/vmscan.c Thu Feb 21 20:01:02 2013 +++ b/mm/vmscan.c Sun Mar 10 12:52:10 2013 @@ -2619,7 +2619,6 @@ static unsigned long balance_pgdat(pg_da bool

Re: [PATCH] mm, x86: no zeroing of hugetlbfs pages at boot

2013-03-09 Thread Hillf Danton
On Thu, Mar 7, 2013 at 5:50 AM, Cliff Wickman c...@sgi.com wrote: From: Cliff Wickman c...@sgi.com Allocating a large number of 1GB hugetlbfs pages at boot takes a very long time. Large system sites would at times like to allocate a very large amount of memory as 1GB pages. They would put

Re: sysfs: Kernel OOPS when install and remove modules

2013-03-10 Thread Hillf Danton
On Mon, Mar 11, 2013 at 10:55 AM, Greg KH gre...@linuxfoundation.org wrote: On Mon, Mar 11, 2013 at 10:17:13AM +0800, Gao feng wrote: I get the below stack when I execute the shell program #!/bin/bash while :; do modprobe 8139too rmmod 8139too done I trust it is not the problem of

Re: doing lots of disk writes causes oom killer to kill processes

2013-03-11 Thread Hillf Danton
On 11 March 2013 13:15, Michal Suchanek hramr...@gmail.com wrote: On 8 February 2013 17:31, Michal Suchanek hramr...@gmail.com wrote: Hello, I am dealing with VM disk images and performing something like wiping free space to prepare image for compressing and storing on server or copying it to

Re: [PATCH 4/9] mm: use mm_populate() for blocking remap_file_pages()

2013-03-11 Thread Hillf Danton
On Tue, Mar 12, 2013 at 8:24 AM, Michel Lespinasse wal...@google.com wrote: (Sorry for the late reply) On Mon, Mar 11, 2013 at 4:03 PM, Andrew Morton a...@linux-foundation.org wrote: On Sun, 10 Mar 2013 20:55:21 +0200 Tommi Rantala tt.rant...@gmail.com wrote: 2012/12/21 Michel Lespinasse

Re: [BUG] potential deadlock led by cpu_hotplug lock (memcg involved)

2013-03-12 Thread Hillf Danton
On Tue, Mar 12, 2013 at 2:36 PM, Li Zefan lize...@huawei.com wrote: Seems a new bug in 3.9 kernel? Bogus info, perhaps. [ 207.271924] == [ 207.271932] [ INFO: possible circular locking dependency detected ] [ 207.271942]

Re: [PATCH] mm/hugetlb: fix total hugetlbfs pages count when memory overcommit accouting

2013-03-13 Thread Hillf Danton
[cc Andi] On Wed, Mar 13, 2013 at 3:08 PM, Wanpeng Li liw...@linux.vnet.ibm.com wrote: After commit 42d7395f (mm: support more pagesizes for MAP_HUGETLB/SHM_HUGETLB) be merged, kernel permit multiple huge page sizes, and when the system administrator has configured the system to provide

[PATCH 1/2] stop_machine: check work-done while handling enqueued works

2013-02-07 Thread Hillf Danton
The comment just above cpu_stop_signal_done() says it is uncertain that the input @done is valid, and the works enqueued through the function stop_one_cpu_nowait() do carry no done, thus we have to check if it is valid when updating work result. Signed-off-by: Hillf Danton dhi...@gmail.com

[PATCH 2/2] stop_machine: dequeue work before signal completion

2013-02-07 Thread Hillf Danton
As checked with BUG_ON in the case of CPU_UP_PREPARE, we have to dequeue work first for further actions, then stopper reaches sane and clear state. Signed-off-by: Hillf Danton dhi...@gmail.com --- --- a/kernel/stop_machine.c Fri Feb 8 11:22:44 2013 +++ b/kernel/stop_machine.c Fri Feb 8

Re: [console_unlock] WARNING: at kernel/sched/clock.c:219 sched_clock_cpu()

2013-02-07 Thread Hillf Danton
Hello Fengguang On Fri, Feb 8, 2013 at 10:06 AM, Fengguang Wu fengguang...@intel.com wrote: [0.00] Console: colour VGA+ 80x25 [0.00] [ cut here ] [0.00] WARNING: at /c/kernel-tests/src/linux/kernel/sched/clock.c:219 sched_clock_cpu+0x65/0x140()

Re: linux-next: Tree for Feb 8 [ smp|cpufreq: WARNING: at kernel/smp.c:245 smp_call_function_single ]

2013-02-08 Thread Hillf Danton
Hello Sedat On Fri, Feb 8, 2013 at 4:46 PM, Sedat Dilek sedat.di...@gmail.com wrote: On Fri, Feb 8, 2013 at 5:31 AM, Stephen Rothwell s...@canb.auug.org.au wrote: With today's Linux-Next I see this warning: [0.377442] [ cut here ] [0.377452] WARNING: at

Re: [PATCH 2/2] stop_machine: dequeue work before signal completion

2013-02-08 Thread Hillf Danton
Hello Namhyung On Fri, Feb 8, 2013 at 4:22 PM, Namhyung Kim namhy...@kernel.org wrote: On Fri, 8 Feb 2013 11:42:43 +0800, Hillf Danton wrote: As checked with BUG_ON in the case of CPU_UP_PREPARE, we have to dequeue work first for further actions, then stopper reaches sane and clear state

Re: [PATCH 3/4] rwsem: implement write lock stealing

2013-02-08 Thread Hillf Danton
On Sat, Feb 9, 2013 at 10:45 AM, Michel Lespinasse wal...@google.com wrote: + if (waiter-type != RWSEM_WAITING_FOR_WRITE) { + list_del(waiter-list); + + /* Set RWSEM_WAITING_BIAS before waking the last reader +

Re: [PATCH 3/4] rwsem: implement write lock stealing

2013-02-09 Thread Hillf Danton
On Sat, Feb 9, 2013 at 3:42 PM, Michel Lespinasse wal...@google.com wrote: On Fri, Feb 8, 2013 at 11:30 PM, Hillf Danton dhi...@gmail.com wrote: On Sat, Feb 9, 2013 at 10:45 AM, Michel Lespinasse wal...@google.com wrote: + if (waiter-type != RWSEM_WAITING_FOR_WRITE

Re: [PATCH 1/2] stop_machine: check work-done while handling enqueued works

2013-02-09 Thread Hillf Danton
On Sun, Feb 10, 2013 at 3:08 AM, Tejun Heo t...@kernel.org wrote: Hello, Hillf. On Fri, Feb 08, 2013 at 11:39:56AM +0800, Hillf Danton wrote: The comment just above cpu_stop_signal_done() says it is uncertain that the input @done is valid, and the works enqueued through the function

[PATCH 1/2] stop_machine: check work-done while handling enqueued works

2013-02-09 Thread Hillf Danton
of stop_one_cpu_nowait() - active_load_balance_cpu_stop() - always returns 0 and thus there's no in-kernel user which triggers this bug. Fix it by checking whether @done exists before updating @done-ret. Thanks Tejun for sharing commit message. Signed-off-by: Hillf Danton dhi...@gmail.com Reviewed-by: Namhyung

[PATCH 2/2] stop_machine: dequeue work before signal completion

2013-02-09 Thread Hillf Danton
Tejun for sharing commit message, again. Signed-off-by: Hillf Danton dhi...@gmail.com Reviewed-by: Namhyung Kim namhy...@kernel.org Cc: sta...@vger.kernel.org --- --- a/kernel/stop_machine.c Sun Feb 10 13:00:00 2013 +++ b/kernel/stop_machine.c Sun Feb 10 13:02:18 2013 @@ -334,23 +334,24

[PATCH 1/3] stop_machine: check work-done while handling enqueued works

2013-02-06 Thread Hillf Danton
To advoid invalid reference, updating work result is moved to cpu_stop_signal_done(). Signed-off-by: Hillf Danton dhi...@gmail.com --- --- a/kernel/stop_machine.c Wed Feb 6 19:50:56 2013 +++ b/kernel/stop_machine.c Wed Feb 6 19:54:34 2013 @@ -51,9 +51,11 @@ static void

[PATCH 2/3] stop_machine: dequeue work before signal completion

2013-02-06 Thread Hillf Danton
As handled by the kernel thread, work is dequeued first for further actions. Signed-off-by: Hillf Danton dhi...@gmail.com --- --- a/kernel/stop_machine.c Wed Feb 6 19:57:12 2013 +++ b/kernel/stop_machine.c Wed Feb 6 20:02:12 2013 @@ -334,23 +334,24 @@ static int __cpuinit

[PATCH 3/3] stop_machine: wake up stopper thread lazily

2013-02-06 Thread Hillf Danton
Ring no bell if the stopper thread is busy in handling enqueued works. Signed-off-by: Hillf Danton dhi...@gmail.com --- --- a/kernel/stop_machine.c Wed Feb 6 20:05:44 2013 +++ b/kernel/stop_machine.c Wed Feb 6 20:06:56 2013 @@ -72,8 +72,10 @@ static void cpu_stop_queue_work(struct c

Re: [PATCH v2 3/3] mm: accelerate munlock() treatment of THP pages

2013-02-07 Thread Hillf Danton
On Thu, Feb 7, 2013 at 7:44 AM, Sasha Levin sasha.le...@oracle.com wrote: On 02/04/2013 02:17 AM, Michel Lespinasse wrote: munlock_vma_pages_range() was always incrementing addresses by PAGE_SIZE at a time. When munlocking THP pages (or the huge zero page), this resulted in taking the

Re: [PATCH 2/3] stop_machine: dequeue work before signal completion

2013-02-07 Thread Hillf Danton
On Thu, Feb 7, 2013 at 10:29 AM, Tejun Heo t...@kernel.org wrote: On Wed, Feb 6, 2013 at 6:21 PM, Namhyung Kim namhy...@kernel.org wrote: Why does this matter? It's inside spinlock. What's being made better by this change? IIUC the work should be deleted from the list, otherwise it'd

Re: [PATCH 1/3] stop_machine: check work-done while handling enqueued works

2013-02-07 Thread Hillf Danton
Hello Tejun On Thu, Feb 7, 2013 at 2:46 AM, Tejun Heo t...@kernel.org wrote: @@ -279,8 +281,6 @@ repeat: preempt_disable(); ret = fn(arg); - if (ret) - done-ret = ret; If this is meant as a pure cleanup, I'm not sure it's an

Re: [PATCH, RFC 06/16] thp, mm: rewrite add_to_page_cache_locked() to support huge pages

2013-01-29 Thread Hillf Danton
On Mon, Jan 28, 2013 at 5:24 PM, Kirill A. Shutemov kirill.shute...@linux.intel.com wrote: @@ -443,6 +443,7 @@ int add_to_page_cache_locked(struct page *page, struct address_space *mapping, pgoff_t offset, gfp_t gfp_mask) { int error; + int nr = 1;

Re: [PATCH, RFC 06/16] thp, mm: rewrite add_to_page_cache_locked() to support huge pages

2013-01-29 Thread Hillf Danton
On Mon, Jan 28, 2013 at 5:24 PM, Kirill A. Shutemov kirill.shute...@linux.intel.com wrote: + page_cache_get(page); + spin_lock_irq(mapping-tree_lock); + page-mapping = mapping; + if (PageTransHuge(page)) { + int i; + for (i = 0; i

Re: [PATCH, RFC 06/16] thp, mm: rewrite add_to_page_cache_locked() to support huge pages

2013-01-29 Thread Hillf Danton
On Mon, Jan 28, 2013 at 5:24 PM, Kirill A. Shutemov kirill.shute...@linux.intel.com wrote: + page_cache_get(page); + spin_lock_irq(mapping-tree_lock); + page-mapping = mapping; + if (PageTransHuge(page)) { + int i; + for (i = 0; i

Re: [patch 09/40] cpu: hotplug: Implement setup/removal interface

2013-02-01 Thread Hillf Danton
On Thu, Jan 31, 2013 at 8:11 PM, Thomas Gleixner t...@linutronix.de wrote: +/** + * __cpuhp_setup_state - Setup the callbacks for an hotplug machine state + * @state: The state to setup + * @invoke:If true, the startup function is invoked for cpus where + * cpu state =

Re: How to online remove an error scsi disk from the system?

2013-02-01 Thread Hillf Danton
On Fri, Feb 1, 2013 at 2:13 PM, Tao Ma t...@tao.ma wrote: Hi All, In our product system, we have several sata disks attached to one machine. So when one of the disk fails, the jbd2(yes, we use ext4) will hang forever and we will get something in /var/log/messages like below. It seems

Re: mm: BUG in mempolicy's sp_insert

2013-02-26 Thread Hillf Danton
On Tue, Feb 26, 2013 at 9:54 AM, Sasha Levin sasha.le...@oracle.com wrote: On 02/25/2013 08:52 PM, KOSAKI Motohiro wrote: On Mon, Feb 25, 2013 at 8:30 AM, Sasha Levin sasha.le...@oracle.com wrote: Hi all, While fuzzing with trinity inside a KVM tools guest running latest -next kernel, I've

Re: mm: BUG in mempolicy's sp_insert

2013-02-27 Thread Hillf Danton
On Thu, Feb 28, 2013 at 1:26 PM, KOSAKI Motohiro kosaki.motoh...@jp.fujitsu.com wrote: Insert new node after updating node in tree. Thanks. you are right. I could reproduce and verified. Thank you too;) pleasure to do minor work for you. btw, how about your belly now? fully recovered? Hillf

Re: kswapd craziness round 2

2013-03-01 Thread Hillf Danton
On Fri, Mar 1, 2013 at 1:02 AM, Jiri Slaby jsl...@suse.cz wrote: Ok, no difference, kswap is still crazy. I'm attaching the output of grep -vw '0' /proc/vmstat if you see something there. Thanks to you for test and data. Lets try to restore the deleted nap, then. Hillf --- a/mm/vmscan.c

Re: [PATCH -V1 15/24] mm/THP: HPAGE_SHIFT is not a #define on some arch

2013-03-01 Thread Hillf Danton
Hello Aneesh [with lkml cced] -#if HPAGE_PMD_ORDER MAX_ORDER -#error hugepages can't be allocated by the buddy allocator -#endif ... - if (!has_transparent_hugepage()) { + if (!has_transparent_hugepage() || (HPAGE_PMD_ORDER MAX_ORDER)) { transparent_hugepage_flags = 0;

Re: [PATCH 1/3] aio: Fix a null pointer deref in batch_complete_aio

2013-01-25 Thread Hillf Danton
-by: Valdis Kletnieks valdis.kletni...@vt.edu Signed-off-by: Kent Overstreet koverstr...@google.com --- Acked-by: Hillf Danton dhi...@gmail.com fs/aio.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/fs/aio.c b/fs/aio.c index 62573d3..0d2f39d 100644 --- a/fs/aio.c +++ b

Re: [PATCH 3/3] aio-use-cancellation-list-lazily-fix

2013-01-25 Thread Hillf Danton
On Fri, Jan 25, 2013 at 5:43 AM, Kent Overstreet koverstr...@google.com wrote: The cancellation changes were fubar - we can't cancel a kiocb if it doesn't actually have a cancellation callback. The use of xchg() in aio_complete() was right - there we're marking the kiocb as completed - but we

Re: next-20130117 - kernel BUG with aio

2013-01-22 Thread Hillf Danton
On Mon, Jan 21, 2013 at 9:24 PM, Valdis Kletnieks valdis.kletni...@vt.edu wrote: Am seeing a reproducible BUG in the kernel with next-20130117 whenever I fire up VirtualBox. Unfortunately, I hadn't done that in a while, so the last 'known good' kernel was next-20121203. I'm strongly

Re: [PATCH 1/1] mm/hugetlb: Set PTE as huge in hugetlb_change_protection

2013-01-22 Thread Hillf Danton
-by: Chris Metcalf cmetc...@tilera.com --- Acked-by: Hillf Danton dhi...@gmail.com mm/hugetlb.c |1 + mm/migrate.c |4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/mm/hugetlb.c b/mm/hugetlb.c index 4f3ea0b..546db81 100644 --- a/mm/hugetlb.c +++ b/mm/hugetlb.c

Re: next-20130117 - kernel BUG with aio

2013-01-23 Thread Hillf Danton
On Wed, Jan 23, 2013 at 5:28 AM, valdis.kletni...@vt.edu wrote: On Tue, 22 Jan 2013 21:43:27 +0800, Hillf Danton said: On Mon, Jan 21, 2013 at 9:24 PM, Valdis Kletnieks valdis.kletni...@vt.edu wrote: Am seeing a reproducible BUG in the kernel with next-20130117 whenever I fire up

Re: kernel BUG at kernel/smpboot.c:125!

2013-01-18 Thread Hillf Danton
On Sat, Jan 19, 2013 at 3:18 AM, Dave Jones da...@redhat.com wrote: Since 3.7, we've started seeing reports of this BUG_ON in kernel/smpboot.c being hit.. 121 if (kthread_should_park()) { 122 __set_current_state(TASK_RUNNING); 123

Re: kswapd craziness round 2

2013-02-18 Thread Hillf Danton
On Mon, Feb 18, 2013 at 2:18 PM, Daniel J Blueman dan...@numascale-asia.com wrote: On Monday, 18 February 2013 06:10:02 UTC+8, Jiri Slaby wrote: Hi, You still feel the sour taste of the kswapd craziness in v3.7 thread, right? Welcome to the hell, part two :{. I believe this started

Re: [GIT PULL] smp/hotplug changes for v3.9

2013-02-20 Thread Hillf Danton
On Tue, Feb 19, 2013 at 10:28 PM, Ingo Molnar mi...@kernel.org wrote: + /* drain remaining works */ + spin_lock_irqsave(stopper-lock, flags); + list_for_each_entry(work, stopper-works, list) + cpu_stop_signal_done(work-done, false); After flushing enqueued

Re: kswapd craziness round 2

2013-02-21 Thread Hillf Danton
On Thu, Feb 21, 2013 at 6:14 AM, Jiri Slaby jsl...@suse.cz wrote: Does Ingo's revert help? https://lkml.org/lkml/2013/2/15/168 Not at all... Then mind taking a try? --- a/mm/vmscan.c Thu Feb 21 20:01:02 2013 +++ b/mm/vmscan.c Thu Feb 21 20:05:58 2013 @@ -1715,7 +1715,7 @@ static

Re: [PATCH 8/9] memory-hotplug: enable memory hotplug to handle hugepage

2013-02-22 Thread Hillf Danton
Hello Naoya [add Michal in cc list] On Fri, Feb 22, 2013 at 3:41 AM, Naoya Horiguchi n-horigu...@ah.jp.nec.com wrote: +/* Returns true for head pages of in-use hugepages, otherwise returns false. */ +int is_hugepage_movable(struct page *hpage) s/int/bool/ can we? +{ + struct page

Are there numa balancing topics scheduled for the incoming LSF?

2013-02-22 Thread Hillf Danton
Hello all On Mon, Dec 17, 2012 at 7:19 AM, Linus Torvalds torva...@linux-foundation.org wrote: On Wed, Dec 12, 2012 at 2:03 AM, Mel Gorman mgor...@suse.de wrote: This is a pull request for Automatic NUMA Balancing V11. The list Ok, guys, I've pulled this and pushed out. There were some

Re: [3.8.0-rc1] BUG in __split_huge_page_pmd() at mm/huge_memory.c:2743 ( was Re: bug report for 3.8.0-rc1+)

2013-02-23 Thread Hillf Danton
Hello Peter [with Andrea and Mel cced] On Fri, Feb 22, 2013 at 8:51 PM, Peter Hurley pe...@hurleysoftware.com wrote: Hi Kirill, I thought you might be interested in this. HEAD is now at a49f0d1... Linux 3.8-rc1 peter@thor:~/src/kernels/mainline$ sed = mm/huge_memory.c | sed 'N;s/\n/ /' |

Re: [PATCH 1/7] mm: interval tree updates

2012-09-07 Thread Hillf Danton
. Once the interval tree functions are available, using them as a replacement to the VMA prio tree is a relatively simple, mechanical job. Signed-off-by: Michel Lespinasse wal...@google.com Cc: Rik van Riel r...@redhat.com Cc: Hillf Danton dhi...@gmail.com Cc: Peter Zijlstra a.p.zijls

Re: [PATCH] list corruption by gather_surplus

2012-07-27 Thread Hillf Danton
On Fri, Jul 27, 2012 at 5:43 AM, Cliff Wickman c...@sgi.com wrote: From: Cliff Wickman c...@sgi.com Gentlemen, I see that you all have done maintenance on mm/hugetlb.c, so I'm hoping one or two of you could comment on a problem and proposed fix. I am seeing list corruption occurring from

[RFC patch] vm: clear swap entry before copying pte

2012-07-27 Thread Hillf Danton
If swap entry is cleared, we can see the reason that copying pte is interrupted. If due to page table lock held long enough, no need to increase swap count. Signed-off-by: Hillf Danton dhi...@gmail.com --- --- a/mm/memory.c Fri Jul 27 21:33:32 2012 +++ b/mm/memory.c Fri Jul 27 21:35

Re: Direct I/O bug in kernel

2012-07-27 Thread Hillf Danton
On Wed, Jul 25, 2012 at 1:28 AM, Victor Meyerson calculuspeng...@yahoo.com wrote: Still different checksums and I used the same random-file from my first test. Then try the fix at https://lkml.org/lkml/2012/7/27/54 Good Weekend Hillf -- To unsubscribe from this list: send the line

Re: [PATCH] MIPS: fix tc_id calculation

2012-07-28 Thread Hillf Danton
On Sat, Jul 28, 2012 at 5:08 PM, RongQing Li roy.qing...@gmail.com wrote: Any advice 2012/7/2 roy.qing...@gmail.com: From: RongQing.Li roy.qing...@gmail.com Now the tc_id is: (read_c0_tcbind() TCBIND_CURTC_SHIFT) TCBIND_CURTC; After substitute macro: (read_c0_tcbind() 21) ((0xff)

Re: [PATCH -alternative] mm: hugetlbfs: Close race during teardown of hugetlbfs shared page tables V2 (resend)

2012-07-31 Thread Hillf Danton
On Tue, Jul 31, 2012 at 3:11 AM, Larry Woodman lwood...@redhat.com wrote: [ 1106.156569] [ cut here ] [ 1106.161731] kernel BUG at mm/filemap.c:135! [ 1106.166395] invalid opcode: [#1] SMP [ 1106.170975] CPU 22 [ 1106.173115] Modules linked in: bridge stp llc

Re: [RFC patch] vm: clear swap entry before copying pte

2012-07-31 Thread Hillf Danton
Hi Hugh, On Tue, Jul 31, 2012 at 10:34 AM, Hugh Dickins hu...@google.com wrote: But I can see that the lack of reinitialization of entry.val here does raise doubt and confusion. A better tidyup would be to remove the initialization of swp_entry_t entry from its onstack declaration, and do it

Re: [patch] hugetlb: correct page offset index for sharing pmd

2012-08-13 Thread Hillf Danton
. What if another case of vma_prio_tree_foreach in try_to_unmap_file is correct? Using vma_hugecache_offset is not incorrect because the pgoff will fit into the same vmas but it is confusing so the standard PAGE_SHIFT based index calculation is used instead. Cc: Hillf Danton dhi...@gmail.com

Re: [PATCH] hugetlb: do not use vma_hugecache_offset for vma_prio_tree_foreach

2012-08-13 Thread Hillf Danton
On Mon, Aug 13, 2012 at 9:09 PM, Michal Hocko mho...@suse.cz wrote: On Mon 13-08-12 20:10:41, Hillf Danton wrote: On Sun, Aug 12, 2012 at 5:31 PM, Michal Hocko mho...@suse.cz wrote: From d07b88a70ee1dbcc96502c48cde878931e7deb38 Mon Sep 17 00:00:00 2001 From: Michal Hocko mho...@suse.cz

Re: [PATCH] hugetlb: do not use vma_hugecache_offset for vma_prio_tree_foreach

2012-08-13 Thread Hillf Danton
On Mon, Aug 13, 2012 at 9:49 PM, Michal Hocko mho...@suse.cz wrote: I will leave it as an excersise for the careful reader... Is it too late for you to prepare a redelivery? -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to

Re: [patch] mmap: feed back correct prev vma when finding vma

2012-08-14 Thread Hillf Danton
-by: Hillf Danton dhi...@gmail.com mm/mmap.c | 45 + 1 file changed, 21 insertions(+), 24 deletions(-) --- 3.6-rc1/mm/mmap.c 2012-08-03 08:31:27.064842271 -0700 +++ linux/mm/mmap.c 2012-08-13 12:23:35.862895633 -0700 @@ -356,17 +356,14 @@ void

Re: [PATCH 2/5] mm: replace vma prio_tree with an interval tree

2012-08-14 Thread Hillf Danton
On Tue, Aug 7, 2012 at 3:25 PM, Michel Lespinasse wal...@google.com wrote: +#define ITSTRUCT struct vm_area_struct +#define ITSTART(n) ((n)-vm_pgoff) +#define ITLAST(n) ((n)-vm_pgoff + \ + (((n)-vm_end - (n)-vm_start) PAGE_SHIFT) - 1) [...] @@ -1547,7 +1545,6 @@

Re: [patch v2] hugetlb: correct page offset index for sharing pmd

2012-08-16 Thread Hillf Danton
On Thu, Aug 16, 2012 at 7:03 AM, Andrew Morton a...@linux-foundation.org wrote: Don't be too concerned about the size of a change - it's the end result which matters. If a larger patch results in a better end result, then do the larger patch. Hi Andrew, This work was triggered by the fact

Re: [PATCH] hugetlb: do not use vma_hugecache_offset for vma_prio_tree_foreach

2012-08-16 Thread Hillf Danton
that one expects index in page units rather than in huge_page_shift. Using vma_hugecache_offset is not incorrect because the pgoff will fit into the same vmas but it is confusing so the standard PAGE_SHIFT based index calculation is used instead. Cc: Hillf Danton dhi...@gmail.com Cc: Mel Gorman m

Re: [RFC patch] mmap: permute find_vma with find_vma_prev

2012-08-07 Thread Hillf Danton
On Tue, Aug 7, 2012 at 10:08 AM, Hugh Dickins hu...@google.com wrote: And rarely is its prev search actually required. Whereas there are lots of users of find_vma(), who want it to be as quick as possible: it should not be burdened with almost-never-needed extras. Got, thanks. I don't know

Re: [patch v2] hugetlb: correct page offset index for sharing pmd

2012-08-07 Thread Hillf Danton
On Mon, Aug 6, 2012 at 11:54 PM, Michal Hocko mho...@suse.cz wrote: It's just that page_table_shareable fix the index silently by saddr PUD_MASK. Follow no up, and see no wrong in page_table_shareable frankly. Hillf -- To unsubscribe from this list: send the line unsubscribe linux-kernel in

[patch] mmap: feed back correct prev vma when finding vma

2012-08-09 Thread Hillf Danton
After walking rb tree, if vma is determined, prev vma has to be determined based on vma; and rb_prev should be considered only if no vma determined. Signed-off-by: Hillf Danton dhi...@gmail.com --- --- a/mm/mmap.c Fri Aug 3 07:38:10 2012 +++ b/mm/mmap.c Mon Aug 6 20:10:18 2012 @@ -385,9

Re: [patch] mmap: feed back correct prev vma when finding vma

2012-08-10 Thread Hillf Danton
On Fri, Aug 10, 2012 at 9:26 AM, Hugh Dickins hu...@google.com wrote: On Thu, 9 Aug 2012, Hillf Danton wrote: After walking rb tree, if vma is determined, prev vma has to be determined based on vma; and rb_prev should be considered only if no vma determined. Why? Because you think more code

Re: [patch] hugetlb: correct page offset index for sharing pmd

2012-08-10 Thread Hillf Danton
On Fri, Aug 10, 2012 at 5:48 PM, Michal Hocko mho...@suse.cz wrote: On Fri 03-08-12 15:32:35, Michal Hocko wrote: On Fri 03-08-12 20:56:45, Hillf Danton wrote: The computation of page offset index is open coded, and incorrect, to be used in scanning prio tree, as huge page offset is required

Re: Direct I/O bug in kernel

2012-08-10 Thread Hillf Danton
On Fri, Aug 10, 2012 at 4:53 AM, Victor Meyerson calculuspeng...@yahoo.com wrote: I tried that patch, although I had to edit a slightly different line as dio_bio_alloc was near line 392 instead of 349 in the version of fs/direct-io.c in my tree. I still got different checksums between the

Re: [patch] hugetlb: correct page offset index for sharing pmd

2012-08-10 Thread Hillf Danton
On Fri, Aug 10, 2012 at 8:27 PM, Michal Hocko mho...@suse.cz wrote: I guess you mean unmap_ref_private and that has been changed by you (0c176d5 mm: hugetlb: fix pgoff computation when unmapping page from vma)... I was wrong at that time when giving my Reviewed-by. The patch didn't break

  1   2   3   4   5   6   7   8   9   10   >