[PATCH 4/6] Staging: winbond: mds: fixed some lines over 80 characters

Fixed some coding style issues Signed-off-by: Iker Pedrosa ikerpedro...@gmail.com --- drivers/staging/winbond/mds.c | 56 +-- 1 file changed, 33 insertions(+), 23 deletions(-) diff --git a/drivers/staging/winbond/mds.c b/drivers/staging/winbond/mds.c

[PATCH 5/6] Staging: winbond: mds_f: fixed lines over 80 characters

Fixed some coding style issues. Signed-off-by: Iker Pedrosa ikerpedro...@gmail.com --- drivers/staging/winbond/mds_f.h | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/staging/winbond/mds_f.h b/drivers/staging/winbond/mds_f.h index ce8be07..ce5a78c 100644

[PATCH 6/6] Staging: winbond: mds_f: deleted extern function

Deleted an extern function that wasn't used in this driver. Signed-off-by: Iker Pedrosa ikerpedro...@gmail.com --- drivers/staging/winbond/mds_f.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/winbond/mds_f.h b/drivers/staging/winbond/mds_f.h index ce5a78c..159b2eb 100644

[PATCH 2/6] Staging: winbond: wb35reg: white space deleted

White space deleted before a semicolon. Signed-off-by: Iker Pedrosa ikerpedro...@gmail.com --- drivers/staging/winbond/wb35reg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/winbond/wb35reg.c b/drivers/staging/winbond/wb35reg.c index 34a2618..1314f93

[PATCH 3/6] Staging: winbond: wb35reg: avoided use of extern function

Prototype of a function added to the header to avoid the use of extern. Signed-off-by: Iker Pedrosa ikerpedro...@gmail.com --- drivers/staging/winbond/phy_calibration.h | 1 + drivers/staging/winbond/wb35reg.c | 3 +-- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 0/6] Staging: winbond: Fixed some coding style issues

Fixes some coding style issues from drivers/staging/winbond Iker Pedrosa (6): Staging: winbond: wb35reg: changed sleep function from msleep to usleep Staging: winbond: wb35reg: white space deleted Staging: winbond: wb35reg: avoided use of extern function Staging: winbond: mds: fixed

[PATCH 1/6] Staging: winbond: wb35reg: changed sleep function from msleep to usleep

Changed sleep function from msleep to usleep according to the documentation. Signed-off-by: Iker Pedrosa ikerpedro...@gmail.com --- drivers/staging/winbond/wb35reg.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/winbond/wb35reg.c b/drivers/staging

Re: [PATCH 0/6] Staging: winbond: Fixed some coding style issues

? Justin P. Mattock From: Iker Pedrosa Sent: ‎Monday‎, ‎August‎ ‎5‎, ‎2013 ‎2‎:‎58‎ ‎AM To: pa...@ucw.cz Cc: gre...@linuxfoundation.org, justinmatt...@gmail.com, ikerpedro...@gmail.com, mujeeb.a...@gmail.com, harsh1ku...@gmail.com, de...@driverdev.osuosl.org, linux-kernel@vger.kernel.org

[PATCH 00/24] Staging: winbond: Fixed some coding style issues

Fixes some coding style issues from drivers/staging/winbond Iker Pedrosa (24): Staging: winbond: mto: removed function declaration Staging: winbond: mto: avoided use of extern functions Staging: winbond: mto: deleted extern functions Staging: winbond: phy_calibration: fixed some lines

[PATCH 22/24] Staging: winbond: wb35tx_s: erased the spaces after opening a '['

Erased the spaces that existed after opening some square brackets '['. Signed-off-by: Iker Pedrosa ikerpedro...@gmail.com --- drivers/staging/winbond/wb35tx_s.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/winbond/wb35tx_s.h b/drivers/staging/winbond

[PATCH 09/24] Staging: winbond: reg: fixed some lines over 80 characters

First of the patches that fixes the lines over 80 characters in reg.c Signed-off-by: Iker Pedrosa ikerpedro...@gmail.com --- drivers/staging/winbond/reg.c | 30 +- 1 file changed, 17 insertions(+), 13 deletions(-) diff --git a/drivers/staging/winbond/reg.c b/drivers

[PATCH 05/24] Staging: winbond: phy_calibration: fixed some lines over 80 characters

Second of the patches that fixes the lines over 80 characters in phy_calibration.c Signed-off-by: Iker Pedrosa ikerpedro...@gmail.com --- drivers/staging/winbond/phy_calibration.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/staging/winbond

[PATCH 11/24] Staging: winbond: reg: fixed some lines over 80 characters

Third of the patches that fixes the lines over 80 characters in reg.c Signed-off-by: Iker Pedrosa ikerpedro...@gmail.com --- drivers/staging/winbond/reg.c | 30 -- 1 file changed, 20 insertions(+), 10 deletions(-) diff --git a/drivers/staging/winbond/reg.c b/drivers

[PATCH 04/24] Staging: winbond: phy_calibration: fixed some lines over 80 characters

First of the patches that fixes the lines over 80 characters in phy_calibration.c Signed-off-by: Iker Pedrosa ikerpedro...@gmail.com --- drivers/staging/winbond/phy_calibration.c | 46 ++- 1 file changed, 27 insertions(+), 19 deletions(-) diff --git a/drivers

[PATCH 19/24] Staging: winbond: wb35rx: fixed some lines over 80 characters

Fixed some lines over 80 characters. Signed-off-by: Iker Pedrosa ikerpedro...@gmail.com --- drivers/staging/winbond/wb35rx.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/staging/winbond/wb35rx.c b/drivers/staging/winbond/wb35rx.c index 48ed95c..999b7046

[PATCH 24/24] Staging: winbond: wbusb: changed sleep function from msleep to usleep

According to the documentation it is not recommended to use msleep for 1ms - 20ms because it may sleep longer than 20ms. So, it is recommended to use usleep instead. Signed-off-by: Iker Pedrosa ikerpedro...@gmail.com --- drivers/staging/winbond/wbusb.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 01/24] Staging: winbond: mto: removed function declaration

The following function declarations have been removed because they aren't implemented. Signed-off-by: Iker Pedrosa ikerpedro...@gmail.com --- drivers/staging/winbond/mto.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/winbond/mto.c b/drivers/staging/winbond/mto.c index

[PATCH 14/24] Staging: winbond: reg: fixed some lines over 80 characters

Sixth of the patches that fixes the lines over 80 characters in reg.c Signed-off-by: Iker Pedrosa ikerpedro...@gmail.com --- drivers/staging/winbond/reg.c | 28 ++-- 1 file changed, 18 insertions(+), 10 deletions(-) diff --git a/drivers/staging/winbond/reg.c b/drivers

[PATCH 20/24] Staging: winbond: wb35tx: changed sleep function from msleep to usleep

According to the documentation it is not recommended to use msleep for 1ms - 20ms because it may sleep longer than 20ms. So, it is recommended to use usleep instead. Signed-off-by: Iker Pedrosa ikerpedro...@gmail.com --- drivers/staging/winbond/wb35tx.c | 4 ++-- 1 file changed, 2 insertions

[PATCH 06/24] Staging: winbond: reg: erased trailing whitespace

Erased all the errors given by checkpatch stating trailing whitespace. Signed-off-by: Iker Pedrosa ikerpedro...@gmail.com --- drivers/staging/winbond/reg.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/winbond/reg.c b/drivers/staging/winbond

[PATCH 07/24] Staging: winbond: reg: white space deleted

White space deleted before semicolons. Signed-off-by: Iker Pedrosa ikerpedro...@gmail.com --- drivers/staging/winbond/reg.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/winbond/reg.c b/drivers/staging/winbond/reg.c index 5883d23..80b4b34 100644

[PATCH 03/24] Staging: winbond: mto: deleted extern functions

Deleted declaration of external functions that weren't used on this driver. Signed-off-by: Iker Pedrosa ikerpedro...@gmail.com --- drivers/staging/winbond/mto.h | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/winbond/mto.h b/drivers/staging/winbond/mto.h index 22bb264

[PATCH 12/24] Staging: winbond: reg: fixed some lines over 80 characters

Fourth of the patches that fixes the lines over 80 characters in reg.c Signed-off-by: Iker Pedrosa ikerpedro...@gmail.com --- drivers/staging/winbond/reg.c | 33 ++--- 1 file changed, 22 insertions(+), 11 deletions(-) diff --git a/drivers/staging/winbond/reg.c b

[PATCH 21/24] Staging: winbond: wb35tx: Replace printk with netdev_err

The previously used printk lacked the warning level, now we've got a more accurate way to know the error. Signed-off-by: Iker Pedrosa ikerpedro...@gmail.com --- drivers/staging/winbond/wb35tx.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/winbond

[PATCH 23/24] Staging: winbond: wbusb: fixed some lines over 80 characters

Fixed some lines over 80 characters. Signed-off-by: Iker Pedrosa ikerpedro...@gmail.com --- drivers/staging/winbond/wbusb.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/drivers/staging/winbond/wbusb.c b/drivers/staging/winbond/wbusb.c index 3fa1ae4

[PATCH 18/24] Staging: winbond: wb35rx: changed sleep function from msleep to usleep

According to the documentation it is not recommended to use msleep for 1ms - 20ms because it may sleep longer than 20ms. So, it is recommended to use usleep instead. Signed-off-by: Iker Pedrosa ikerpedro...@gmail.com --- drivers/staging/winbond/wb35rx.c | 4 ++-- 1 file changed, 2 insertions

[PATCH 10/24] Staging: winbond: reg: fixed some lines over 80 characters

Second of the patches that fixes the lines over 80 characters in reg.c Signed-off-by: Iker Pedrosa ikerpedro...@gmail.com --- drivers/staging/winbond/reg.c | 30 -- 1 file changed, 20 insertions(+), 10 deletions(-) diff --git a/drivers/staging/winbond/reg.c b/drivers

[PATCH 15/24] Staging: winbond: reg: fixed some lines over 80 characters

Seventh of the patches that fixes the lines over 80 characters in reg.c Signed-off-by: Iker Pedrosa ikerpedro...@gmail.com --- drivers/staging/winbond/reg.c | 24 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/drivers/staging/winbond/reg.c b/drivers

[PATCH 02/24] Staging: winbond: mto: avoided use of extern functions

Prototype of two functions added to the header to avoid the use of extern. Signed-off-by: Iker Pedrosa ikerpedro...@gmail.com --- drivers/staging/winbond/mto.c | 4 +--- drivers/staging/winbond/mto.h | 4 ++-- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/staging/winbond

[PATCH 17/24] Staging: winbond: wb35reg_s: deleted space before tabulation

Deleted an space before a tabulation. Signed-off-by: Iker Pedrosa ikerpedro...@gmail.com --- drivers/staging/winbond/wb35reg_s.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/winbond/wb35reg_s.h b/drivers/staging/winbond/wb35reg_s.h index dc79faa..cdbbf35

[PATCH 08/24] Staging: winbond: reg: changed sleep function from msleep to usleep

According to the documentation it is not recommended to use msleep for 1ms - 20ms because it may sleep longer than 20ms. So, it is recommended to use usleep instead. Signed-off-by: Iker Pedrosa ikerpedro...@gmail.com --- drivers/staging/winbond/reg.c | 52

[PATCH 16/24] Staging: winbond: wb35reg_f: fixed lines over 80 characters

Fixed lines over 80 characters. Signed-off-by: Iker Pedrosa ikerpedro...@gmail.com --- drivers/staging/winbond/wb35reg_f.h | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers/staging/winbond/wb35reg_f.h b/drivers/staging/winbond/wb35reg_f.h index

[PATCH 13/24] Staging: winbond: reg: fixed some lines over 80 characters

Fifth of the patches that fixes the lines over 80 characters in reg.c Signed-off-by: Iker Pedrosa ikerpedro...@gmail.com --- drivers/staging/winbond/reg.c | 33 ++--- 1 file changed, 22 insertions(+), 11 deletions(-) diff --git a/drivers/staging/winbond/reg.c b

Re: [PATCH 00/24] Staging: winbond: Fixed some coding style issues

for the next series of patches but I will wait to start them until the previous are accepted. -- Regards, Iker Pedrosa ikerpedro...@gmail.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH 1/6] Staging: winbond: wb35reg: changed sleep function from msleep to usleep

Pedrosa wrote: Changed sleep function from msleep to usleep according to the documentation. Signed-off-by: Iker Pedrosa ikerpedro...@gmail.com Can you explain why this is good idea? -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz

Re: [PATCH] Staging: rtl8192e: rtllib_rx: checking NULL value after doing dev_alloc_skb

So, what should I do? Do I send the patch via bugzilla? I'm a newbie and I don't know that to do, what do you recommend me? On Fri, 9 Aug 2013 15:38:13 +0300 Dan Carpenter dan.carpen...@oracle.com wrote: On Thu, Aug 08, 2013 at 12:56:44PM +0200, Iker Pedrosa wrote: Checking the return

[PATCH] Staging: winbond: wb35reg: fixed some line over 80 characters

Fixed some coding style issues Signed-off-by: Iker Pedrosa ikerpedro...@gmail.com --- drivers/staging/winbond/wb35reg.c | 31 +++ 1 file changed, 19 insertions(+), 12 deletions(-) diff --git a/drivers/staging/winbond/wb35reg.c b/drivers/staging/winbond/wb35reg.c

[PATCH v2 23/24] Staging: winbond: wbusb: fixed some lines over 80 characters

Fixed some lines over 80 characters. Signed-off-by: Iker Pedrosa ikerpedro...@gmail.com --- drivers/staging/winbond/wbusb.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/drivers/staging/winbond/wbusb.c b/drivers/staging/winbond/wbusb.c index 3fa1ae4

[PATCH v2 00/24] Staging: winbond: Fixed some coding style issues

Fixes some coding style issues from drivers/staging/winbond Iker Pedrosa (24): Staging: winbond: mto: removed function declaration Staging: winbond: mto: avoided use of extern functions Staging: winbond: mto: deleted extern functions Staging: winbond: phy_calibration: first of the patches

[PATCH v2 11/24] Staging: winbond: reg: third of the patches that fixes lines over 80 characters

Third of the patches that fixes the lines over 80 characters in reg.c Signed-off-by: Iker Pedrosa ikerpedro...@gmail.com --- drivers/staging/winbond/reg.c | 30 -- 1 file changed, 20 insertions(+), 10 deletions(-) diff --git a/drivers/staging/winbond/reg.c b/drivers

[PATCH v2 08/24] Staging: winbond: reg: changed sleep function from msleep to usleep

the same problem please copy the output so that I can figure out what is the problem. Signed-off-by: Iker Pedrosa ikerpedro...@gmail.com --- drivers/staging/winbond/reg.c | 54 +-- 1 file changed, 27 insertions(+), 27 deletions(-) diff --git a/drivers

[PATCH v2 21/24] Staging: winbond: wb35tx: Replace printk with netdev_err

The previously used printk lacked the warning level, now we've got a more accurate way to know the error. Signed-off-by: Iker Pedrosa ikerpedro...@gmail.com --- drivers/staging/winbond/wb35tx.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/winbond

[PATCH v2 13/24] Staging: winbond: reg: fifth of the patches that fixes lines over 80 characters

Fifth of the patches that fixes the lines over 80 characters in reg.c Signed-off-by: Iker Pedrosa ikerpedro...@gmail.com --- drivers/staging/winbond/reg.c | 33 ++--- 1 file changed, 22 insertions(+), 11 deletions(-) diff --git a/drivers/staging/winbond/reg.c b

[PATCH v2 24/24] Staging: winbond: wbusb: changed sleep function from msleep to usleep

According to the documentation it is not recommended to use msleep for 1ms - 20ms because it may sleep longer than 20ms. So, it is recommended to use usleep instead. Signed-off-by: Iker Pedrosa ikerpedro...@gmail.com --- drivers/staging/winbond/wbusb.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH v2 22/24] Staging: winbond: wb35tx_s: erased the spaces after opening a '['

Erased the spaces that existed after opening some square brackets '['. Signed-off-by: Iker Pedrosa ikerpedro...@gmail.com --- drivers/staging/winbond/wb35tx_s.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/winbond/wb35tx_s.h b/drivers/staging/winbond

[PATCH v2 19/24] Staging: winbond: wb35rx: fixed some lines over 80 characters

Fixed some lines over 80 characters. Signed-off-by: Iker Pedrosa ikerpedro...@gmail.com --- drivers/staging/winbond/wb35rx.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/staging/winbond/wb35rx.c b/drivers/staging/winbond/wb35rx.c index 48ed95c..999b7046

[PATCH v2 16/24] Staging: winbond: wb35reg_f: fixed lines over 80 characters

Fixed lines over 80 characters. Signed-off-by: Iker Pedrosa ikerpedro...@gmail.com --- drivers/staging/winbond/wb35reg_f.h | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers/staging/winbond/wb35reg_f.h b/drivers/staging/winbond/wb35reg_f.h index

[PATCH v2 20/24] Staging: winbond: wb35tx: changed sleep function from msleep to usleep

the same problem please copy the output so that I can figure out what is the problem. Signed-off-by: Iker Pedrosa ikerpedro...@gmail.com --- drivers/staging/winbond/wb35tx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/winbond/wb35tx.c b/drivers/staging

[PATCH v2 17/24] Staging: winbond: wb35reg_s: deleted space before tabulation

Deleted an space before a tabulation. Signed-off-by: Iker Pedrosa ikerpedro...@gmail.com --- drivers/staging/winbond/wb35reg_s.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/winbond/wb35reg_s.h b/drivers/staging/winbond/wb35reg_s.h index dc79faa..cdbbf35

[PATCH v2 12/24] Staging: winbond: reg: fourth of the patches that fixes lines over 80 characters

Fourth of the patches that fixes the lines over 80 characters in reg.c Signed-off-by: Iker Pedrosa ikerpedro...@gmail.com --- drivers/staging/winbond/reg.c | 33 ++--- 1 file changed, 22 insertions(+), 11 deletions(-) diff --git a/drivers/staging/winbond/reg.c b

[PATCH v2 14/24] Staging: winbond: reg: sixth of the patches that fixes lines over 80 characters

Sixth of the patches that fixes the lines over 80 characters in reg.c Signed-off-by: Iker Pedrosa ikerpedro...@gmail.com --- drivers/staging/winbond/reg.c | 28 ++-- 1 file changed, 18 insertions(+), 10 deletions(-) diff --git a/drivers/staging/winbond/reg.c b/drivers

[PATCH v2 15/24] Staging: winbond: reg: seventh of the patches that fixes lines over 80 characters

Seventh of the patches that fixes the lines over 80 characters in reg.c Signed-off-by: Iker Pedrosa ikerpedro...@gmail.com --- drivers/staging/winbond/reg.c | 24 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/drivers/staging/winbond/reg.c b/drivers

[PATCH v2 18/24] Staging: winbond: wb35rx: changed sleep function from msleep to usleep

According to the documentation it is not recommended to use msleep for 1ms - 20ms because it may sleep longer than 20ms. So, it is recommended to use usleep instead. Signed-off-by: Iker Pedrosa ikerpedro...@gmail.com --- drivers/staging/winbond/wb35rx.c | 4 ++-- 1 file changed, 2 insertions

[PATCH v2 10/24] Staging: winbond: reg: second of the patches that fixes lines over 80 characters

Second of the patches that fixes the lines over 80 characters in reg.c Signed-off-by: Iker Pedrosa ikerpedro...@gmail.com --- drivers/staging/winbond/reg.c | 30 -- 1 file changed, 20 insertions(+), 10 deletions(-) diff --git a/drivers/staging/winbond/reg.c b/drivers

[PATCH v2 09/24] Staging: winbond: reg: first of the patches that fixes lines over 80 characters

First of the patches that fixes the lines over 80 characters in reg.c Signed-off-by: Iker Pedrosa ikerpedro...@gmail.com --- drivers/staging/winbond/reg.c | 26 ++ 1 file changed, 10 insertions(+), 16 deletions(-) diff --git a/drivers/staging/winbond/reg.c b/drivers

[PATCH v2 04/24] Staging: winbond: phy_calibration: first of the patches that fixes lines over 80 characters

First of the patches that fixes the lines over 80 characters in phy_calibration.c Signed-off-by: Iker Pedrosa ikerpedro...@gmail.com --- drivers/staging/winbond/phy_calibration.c | 46 ++- 1 file changed, 27 insertions(+), 19 deletions(-) diff --git a/drivers

[PATCH v2 06/24] Staging: winbond: reg: erased trailing whitespace

Erased all the errors given by checkpatch stating trailing whitespace. Signed-off-by: Iker Pedrosa ikerpedro...@gmail.com --- drivers/staging/winbond/reg.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/winbond/reg.c b/drivers/staging/winbond

[PATCH v2 07/24] Staging: winbond: reg: white space deleted

White space deleted before semicolons. Signed-off-by: Iker Pedrosa ikerpedro...@gmail.com --- drivers/staging/winbond/reg.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/winbond/reg.c b/drivers/staging/winbond/reg.c index 5883d23..80b4b34 100644

[PATCH v2 01/24] Staging: winbond: mto: removed function declaration

The following function declarations have been removed because they aren't implemented. Signed-off-by: Iker Pedrosa ikerpedro...@gmail.com --- drivers/staging/winbond/mto.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/winbond/mto.c b/drivers/staging/winbond/mto.c index

[PATCH v2 05/24] Staging: winbond: phy_calibration: second of the patches that fixes lines over 80 characters

Second of the patches that fixes the lines over 80 characters in phy_calibration.c Signed-off-by: Iker Pedrosa ikerpedro...@gmail.com --- drivers/staging/winbond/phy_calibration.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/staging/winbond

[PATCH v2 02/24] Staging: winbond: mto: avoided use of extern functions

Prototype of two functions added to the header to avoid the use of extern. Signed-off-by: Iker Pedrosa ikerpedro...@gmail.com --- drivers/staging/winbond/mto.c | 4 +--- drivers/staging/winbond/mto.h | 4 ++-- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/staging/winbond

[PATCH v2 03/24] Staging: winbond: mto: deleted extern functions

Deleted declaration of external functions that weren't used on this driver. Signed-off-by: Iker Pedrosa ikerpedro...@gmail.com --- drivers/staging/winbond/mto.h | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/winbond/mto.h b/drivers/staging/winbond/mto.h index 22bb264

Re: [PATCH v2 15/24] Staging: winbond: reg: seventh of the patches that fixes lines over 80 characters

the whole series. regards, dan carpenter I will change it for the new version of this patch but I want to wait some days until everybody looks the patches that I've sent. -- Regards, Iker Pedrosa ikerpedro...@gmail.com -- To unsubscribe from this list: send the line unsubscribe linux

[PATCH] Staging: rtl8192u: r819xU_cmdpkt: checking NULL value after doing dev_alloc_skb

Checking the return of dev_alloc_skb as stated in the following bug: https://bugzilla.kernel.org/show_bug.cgi?id=60411 Signed-off-by: Iker Pedrosa ikerpedro...@gmail.com Reported-by: RUC_Soft_Sec rucsoft...@gmail.com --- drivers/staging/rtl8192u/r819xU_cmdpkt.c | 2 ++ 1 file changed, 2

[PATCH v3 21/24] Staging: winbond: wb35tx: Replace printk with netdev

The previously used printk lacked the warning level, now we've got a more accurate way to know the error. Signed-off-by: Iker Pedrosa ikerpedro...@gmail.com --- drivers/staging/winbond/wb35tx.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/winbond

[PATCH] Staging: rtl8192e: rtllib_rx: checking NULL value after doing dev_alloc_skb

Checking the return of dev_alloc_skb as stated in the following bug: https://bugzilla.kernel.org/show_bug.cgi?id=60401 Signed-off-by: Iker Pedrosa ikerpedro...@gmail.com --- drivers/staging/rtl8192e/rtllib_rx.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/staging/rtl8192e

[PATCH] Staging: winbond: wb35reg: fixed some line over 80 characters

Fixed some coding style issues Signed-off-by: Iker Pedrosa --- drivers/staging/winbond/wb35reg.c | 31 +++ 1 file changed, 19 insertions(+), 12 deletions(-) diff --git a/drivers/staging/winbond/wb35reg.c b/drivers/staging/winbond/wb35reg.c index 9be1b3b..35d3beb

[PATCH 4/6] Staging: winbond: mds: fixed some lines over 80 characters

Fixed some coding style issues Signed-off-by: Iker Pedrosa --- drivers/staging/winbond/mds.c | 56 +-- 1 file changed, 33 insertions(+), 23 deletions(-) diff --git a/drivers/staging/winbond/mds.c b/drivers/staging/winbond/mds.c index faa93f0..fcc3d21

[PATCH 5/6] Staging: winbond: mds_f: fixed lines over 80 characters

Fixed some coding style issues. Signed-off-by: Iker Pedrosa --- drivers/staging/winbond/mds_f.h | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/staging/winbond/mds_f.h b/drivers/staging/winbond/mds_f.h index ce8be07..ce5a78c 100644 --- a/drivers/staging

[PATCH 6/6] Staging: winbond: mds_f: deleted extern function

Deleted an extern function that wasn't used in this driver. Signed-off-by: Iker Pedrosa --- drivers/staging/winbond/mds_f.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/winbond/mds_f.h b/drivers/staging/winbond/mds_f.h index ce5a78c..159b2eb 100644 --- a/drivers/staging

[PATCH 2/6] Staging: winbond: wb35reg: white space deleted

White space deleted before a semicolon. Signed-off-by: Iker Pedrosa --- drivers/staging/winbond/wb35reg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/winbond/wb35reg.c b/drivers/staging/winbond/wb35reg.c index 34a2618..1314f93 100644 --- a/drivers

[PATCH 3/6] Staging: winbond: wb35reg: avoided use of extern function

Prototype of a function added to the header to avoid the use of extern. Signed-off-by: Iker Pedrosa --- drivers/staging/winbond/phy_calibration.h | 1 + drivers/staging/winbond/wb35reg.c | 3 +-- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/winbond

[PATCH 0/6] Staging: winbond: Fixed some coding style issues

Fixes some coding style issues from drivers/staging/winbond Iker Pedrosa (6): Staging: winbond: wb35reg: changed sleep function from msleep to usleep Staging: winbond: wb35reg: white space deleted Staging: winbond: wb35reg: avoided use of extern function Staging: winbond: mds: fixed

[PATCH 1/6] Staging: winbond: wb35reg: changed sleep function from msleep to usleep

Changed sleep function from msleep to usleep according to the documentation. Signed-off-by: Iker Pedrosa --- drivers/staging/winbond/wb35reg.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/winbond/wb35reg.c b/drivers/staging/winbond/wb35reg.c index

Re: [PATCH 0/6] Staging: winbond: Fixed some coding style issues

stin P. Mattock > > > > From: Iker Pedrosa > Sent: ‎Monday‎, ‎August‎ ‎5‎, ‎2013 ‎2‎:‎58‎ ‎AM > To: pa...@ucw.cz > Cc: gre...@linuxfoundation.org, justinmatt...@gmail.com, > ikerpedro...@gmail.com, mujeeb.a...@gmail.com, harsh1ku...@gmail.com, > de...@driverdev.osuosl.org,

Re: [PATCH 1/6] Staging: winbond: wb35reg: changed sleep function from msleep to usleep

According to Documentation/timers/timers-howto.txt it is not recommended to use msleep for 1ms - 20ms because it may sleep longer than 20ms. So, it is recommended to use usleep instead. On Mon, 12 Aug 2013 12:05:10 +0200 Pavel Machek wrote: > On Mon 2013-08-05 11:58:27, Iker Pedrosa wr

Re: [PATCH] Staging: rtl8192e: rtllib_rx: checking NULL value after doing dev_alloc_skb

So, what should I do? Do I send the patch via bugzilla? I'm a newbie and I don't know that to do, what do you recommend me? On Fri, 9 Aug 2013 15:38:13 +0300 Dan Carpenter wrote: > On Thu, Aug 08, 2013 at 12:56:44PM +0200, Iker Pedrosa wrote: > > Checking the return of dev_alloc_skb

[PATCH] Staging: rtl8192e: rtllib_rx: checking NULL value after doing dev_alloc_skb

Checking the return of dev_alloc_skb as stated in the following bug: https://bugzilla.kernel.org/show_bug.cgi?id=60401 Signed-off-by: Iker Pedrosa --- drivers/staging/rtl8192e/rtllib_rx.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers

[PATCH v2 23/24] Staging: winbond: wbusb: fixed some lines over 80 characters

Fixed some lines over 80 characters. Signed-off-by: Iker Pedrosa --- drivers/staging/winbond/wbusb.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/drivers/staging/winbond/wbusb.c b/drivers/staging/winbond/wbusb.c index 3fa1ae4..a2868f2 100644

[PATCH v2 00/24] Staging: winbond: Fixed some coding style issues

Fixes some coding style issues from drivers/staging/winbond Iker Pedrosa (24): Staging: winbond: mto: removed function declaration Staging: winbond: mto: avoided use of extern functions Staging: winbond: mto: deleted extern functions Staging: winbond: phy_calibration: first of the patches

[PATCH v2 11/24] Staging: winbond: reg: third of the patches that fixes lines over 80 characters

Third of the patches that fixes the lines over 80 characters in reg.c Signed-off-by: Iker Pedrosa --- drivers/staging/winbond/reg.c | 30 -- 1 file changed, 20 insertions(+), 10 deletions(-) diff --git a/drivers/staging/winbond/reg.c b/drivers/staging/winbond/reg.c

[PATCH v2 08/24] Staging: winbond: reg: changed sleep function from msleep to usleep

the same problem please copy the output so that I can figure out what is the problem. Signed-off-by: Iker Pedrosa --- drivers/staging/winbond/reg.c | 54 +-- 1 file changed, 27 insertions(+), 27 deletions(-) diff --git a/drivers/staging/winbond/reg.c b

[PATCH v2 21/24] Staging: winbond: wb35tx: Replace printk with netdev_err

The previously used printk lacked the warning level, now we've got a more accurate way to know the error. Signed-off-by: Iker Pedrosa --- drivers/staging/winbond/wb35tx.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/winbond/wb35tx.c b/drivers

[PATCH v2 13/24] Staging: winbond: reg: fifth of the patches that fixes lines over 80 characters

Fifth of the patches that fixes the lines over 80 characters in reg.c Signed-off-by: Iker Pedrosa --- drivers/staging/winbond/reg.c | 33 ++--- 1 file changed, 22 insertions(+), 11 deletions(-) diff --git a/drivers/staging/winbond/reg.c b/drivers/staging/winbond

[PATCH v2 24/24] Staging: winbond: wbusb: changed sleep function from msleep to usleep

According to the documentation it is not recommended to use msleep for 1ms - 20ms because it may sleep longer than 20ms. So, it is recommended to use usleep instead. Signed-off-by: Iker Pedrosa --- drivers/staging/winbond/wbusb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH v2 22/24] Staging: winbond: wb35tx_s: erased the spaces after opening a '['

Erased the spaces that existed after opening some square brackets '['. Signed-off-by: Iker Pedrosa --- drivers/staging/winbond/wb35tx_s.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/winbond/wb35tx_s.h b/drivers/staging/winbond/wb35tx_s.h index 715f87d

[PATCH v2 19/24] Staging: winbond: wb35rx: fixed some lines over 80 characters

Fixed some lines over 80 characters. Signed-off-by: Iker Pedrosa --- drivers/staging/winbond/wb35rx.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/staging/winbond/wb35rx.c b/drivers/staging/winbond/wb35rx.c index 48ed95c..999b7046 100644 --- a/drivers

[PATCH v2 16/24] Staging: winbond: wb35reg_f: fixed lines over 80 characters

Fixed lines over 80 characters. Signed-off-by: Iker Pedrosa --- drivers/staging/winbond/wb35reg_f.h | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers/staging/winbond/wb35reg_f.h b/drivers/staging/winbond/wb35reg_f.h index 95dc980..cd6710c 100644

[PATCH v2 20/24] Staging: winbond: wb35tx: changed sleep function from msleep to usleep

the same problem please copy the output so that I can figure out what is the problem. Signed-off-by: Iker Pedrosa --- drivers/staging/winbond/wb35tx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/winbond/wb35tx.c b/drivers/staging/winbond/wb35tx.c index

[PATCH v2 17/24] Staging: winbond: wb35reg_s: deleted space before tabulation

Deleted an space before a tabulation. Signed-off-by: Iker Pedrosa --- drivers/staging/winbond/wb35reg_s.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/winbond/wb35reg_s.h b/drivers/staging/winbond/wb35reg_s.h index dc79faa..cdbbf35 100644 --- a/drivers

[PATCH v2 12/24] Staging: winbond: reg: fourth of the patches that fixes lines over 80 characters

Fourth of the patches that fixes the lines over 80 characters in reg.c Signed-off-by: Iker Pedrosa --- drivers/staging/winbond/reg.c | 33 ++--- 1 file changed, 22 insertions(+), 11 deletions(-) diff --git a/drivers/staging/winbond/reg.c b/drivers/staging/winbond

[PATCH v2 14/24] Staging: winbond: reg: sixth of the patches that fixes lines over 80 characters

Sixth of the patches that fixes the lines over 80 characters in reg.c Signed-off-by: Iker Pedrosa --- drivers/staging/winbond/reg.c | 28 ++-- 1 file changed, 18 insertions(+), 10 deletions(-) diff --git a/drivers/staging/winbond/reg.c b/drivers/staging/winbond/reg.c

[PATCH v2 15/24] Staging: winbond: reg: seventh of the patches that fixes lines over 80 characters

Seventh of the patches that fixes the lines over 80 characters in reg.c Signed-off-by: Iker Pedrosa --- drivers/staging/winbond/reg.c | 24 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/drivers/staging/winbond/reg.c b/drivers/staging/winbond/reg.c index

[PATCH v2 18/24] Staging: winbond: wb35rx: changed sleep function from msleep to usleep

According to the documentation it is not recommended to use msleep for 1ms - 20ms because it may sleep longer than 20ms. So, it is recommended to use usleep instead. Signed-off-by: Iker Pedrosa --- drivers/staging/winbond/wb35rx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions

[PATCH v2 10/24] Staging: winbond: reg: second of the patches that fixes lines over 80 characters

Second of the patches that fixes the lines over 80 characters in reg.c Signed-off-by: Iker Pedrosa --- drivers/staging/winbond/reg.c | 30 -- 1 file changed, 20 insertions(+), 10 deletions(-) diff --git a/drivers/staging/winbond/reg.c b/drivers/staging/winbond/reg.c

[PATCH v2 09/24] Staging: winbond: reg: first of the patches that fixes lines over 80 characters

First of the patches that fixes the lines over 80 characters in reg.c Signed-off-by: Iker Pedrosa --- drivers/staging/winbond/reg.c | 26 ++ 1 file changed, 10 insertions(+), 16 deletions(-) diff --git a/drivers/staging/winbond/reg.c b/drivers/staging/winbond/reg.c

[PATCH v2 04/24] Staging: winbond: phy_calibration: first of the patches that fixes lines over 80 characters

First of the patches that fixes the lines over 80 characters in phy_calibration.c Signed-off-by: Iker Pedrosa --- drivers/staging/winbond/phy_calibration.c | 46 ++- 1 file changed, 27 insertions(+), 19 deletions(-) diff --git a/drivers/staging/winbond

[PATCH v2 06/24] Staging: winbond: reg: erased trailing whitespace

Erased all the errors given by checkpatch stating trailing whitespace. Signed-off-by: Iker Pedrosa --- drivers/staging/winbond/reg.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/winbond/reg.c b/drivers/staging/winbond/reg.c index 75b7752

[PATCH v2 07/24] Staging: winbond: reg: white space deleted

White space deleted before semicolons. Signed-off-by: Iker Pedrosa --- drivers/staging/winbond/reg.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/winbond/reg.c b/drivers/staging/winbond/reg.c index 5883d23..80b4b34 100644 --- a/drivers/staging/winbond

[PATCH v2 01/24] Staging: winbond: mto: removed function declaration

The following function declarations have been removed because they aren't implemented. Signed-off-by: Iker Pedrosa --- drivers/staging/winbond/mto.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/winbond/mto.c b/drivers/staging/winbond/mto.c index 560c0ab..0d0f9fb 100644

  1   2   >