From: Ioana Radulescu <ruxandra.radule...@nxp.com>
This patch adds the command building/parsing wrapper functions
for the DPCON object. The binary interface version is v3.2.
Signed-off-by: Ioana Radulescu <ruxandra.radule...@nxp.com>
Signed-off-by: Ioana Ciornei <ioana.cior...@
Add a README file describing the driver architecture, components
and I/O interface.
Signed-off-by: Ioana Radulescu <ruxandra.radule...@nxp.com>
---
drivers/staging/fsl-dpaa2/ethernet/README | 186 +
1 files changed, 186 insertions(+), 0 deletions(-)
creat
Add the command build/parse APIs for operating on DPNI objects through
the DPAA2 Management Complex.
Signed-off-by: Ioana Radulescu <ruxandra.radule...@nxp.com>
---
drivers/staging/Kconfig |2 +
drivers/staging/Makefile |1 +
drivers/stagi
Signed-off-by: Ioana Radulescu <ruxandra.radule...@nxp.com>
---
MAINTAINERS |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 312c582..da4a6fa 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -5057,6 +5057,12 @@ S: Maintai
, add dpio
https://www.spinics.net/lists/kernel/msg2396338.html
[PATCH] bus: fsl-mc: add DPCON object APIs
https://www.spinics.net/lists/kernel/msg2398182.html
Ioana Radulescu (8):
staging: fsl-dpaa2/eth: Add Ethernet driver overview document
staging: fsl-dpaa2/eth: Add APIs for DPNI objects
Add a list of TODO items for the Ethernet driver
Signed-off-by: Ioana Radulescu <ruxandra.radule...@nxp.com>
---
drivers/staging/fsl-dpaa2/ethernet/TODO |9 +
1 files changed, 9 insertions(+), 0 deletions(-)
create mode 100644 drivers/staging/fsl-dpaa2/ethernet/TODO
diff
(DPCONs).
Signed-off-by: Ioana Radulescu <ruxandra.radule...@nxp.com>
Signed-off-by: Bogdan Hamciuc <bogdan.hamc...@nxp.com>
---
drivers/staging/fsl-dpaa2/ethernet/Makefile|2 +-
drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 2460
drivers/staging/fsl-dp
Add custom statistics to be reported via ethtool -S. These include
driver specific per-cpu statistics as well as queue and channel
counters.
Signed-off-by: Ioana Radulescu <ruxandra.radule...@nxp.com>
---
drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 42 -
d
Add support for several ethtool operations: show hardware statistics,
get/set link settings, get hash configuration.
Signed-off-by: Ioana Radulescu <ruxandra.radule...@nxp.com>
Signed-off-by: Bogdan Hamciuc <bogdan.hamc...@nxp.com>
---
drivers/staging/fsl-dpaa2/ethernet/Makefile
Add trace events in significant places of the data path.
Useful for debuggging.
Signed-off-by: Ioana Radulescu <ruxandra.radule...@nxp.com>
---
drivers/staging/fsl-dpaa2/ethernet/Makefile|3 +
.../staging/fsl-dpaa2/ethernet/dpaa2-eth-trace.h | 185
d
Add the command build/parse APIs for operating on DPNI objects through
the DPAA2 Management Complex.
Signed-off-by: Ioana Radulescu <ruxandra.radule...@nxp.com>
---
v2: update #include paths
drivers/staging/Kconfig |2 +
drivers/staging/Ma
updates in patch #4 due to networking API changes
Ioana Radulescu (9):
bus: fsl-mc: add DPCON object APIs
staging: fsl-dpaa2/eth: Add Ethernet driver overview document
staging: fsl-dpaa2/eth: Add APIs for DPNI objects
staging: fsl-dpaa2/eth: Add Freescale DPAA2 Ethernet driver
staging: fsl
Add support for several ethtool operations: show hardware statistics,
get/set link settings, get hash configuration.
Signed-off-by: Ioana Radulescu <ruxandra.radule...@nxp.com>
Signed-off-by: Bogdan Hamciuc <bogdan.hamc...@nxp.com>
---
v2: no changes
drivers/staging/fsl-dpaa2/ether
Add a README file describing the driver architecture, components
and I/O interface.
Signed-off-by: Ioana Radulescu <ruxandra.radule...@nxp.com>
---
v2: no changes
drivers/staging/fsl-dpaa2/ethernet/README | 186 ++
1 file changed, 186 insertions(+)
creat
(DPCONs).
A more detailed description of the driver can be found in the
associated README file.
Signed-off-by: Ioana Radulescu <ruxandra.radule...@nxp.com>
Signed-off-by: Bogdan Hamciuc <bogdan.hamc...@nxp.com>
---
v2:
- update #include paths
- ndo_get_stats64() now
Add custom statistics to be reported via ethtool -S. These include
driver specific per-cpu statistics as well as queue and channel
counters.
Signed-off-by: Ioana Radulescu <ruxandra.radule...@nxp.com>
---
v2: no changes
drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c
Add trace events in significant places of the data path.
Useful for debuggging.
Signed-off-by: Ioana Radulescu <ruxandra.radule...@nxp.com>
---
v2: no changes
drivers/staging/fsl-dpaa2/ethernet/Makefile| 3 +
.../staging/fsl-dpaa2/ethernet/dpaa2-eth-trace.h
Signed-off-by: Ioana Radulescu <ruxandra.radule...@nxp.com>
---
v2: Remove "Freescale" from the driver name
MAINTAINERS | 6 ++
1 file changed, 6 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index b38b42f96e6a..4368f67bb261 100644
--- a/MAINTAINERS
+++ b/MAINTA
From: Ioana Radulescu <ruxandra.radule...@freescale.com>
This patch adds the command building/parsing wrapper functions
for the DPCON object. The binary interface version is v3.2.
A DPCON (DataPath Concentrator) is an aggregator object that
allows ingress frames from multiple hardware
Add a list of TODO items for the Ethernet driver
Signed-off-by: Ioana Radulescu <ruxandra.radule...@nxp.com>
---
v2: Add note
drivers/staging/fsl-dpaa2/ethernet/TODO | 14 ++
1 file changed, 14 insertions(+)
create mode 100644 drivers/staging/fsl-dpaa2/ethernet/TODO
diff
n in the
swp command registers, after all other fields are filled in.
The current implementation doesn't follow this rule for all
commands, which may result in an incompletely configured
command being processed by the hardware. Enforce the correct
order of writes to avoid this situation.
Signed-off
All possible values of the switch statement are explicitly
handled, so there's no need to have a default branch.
Signed-off-by: Ioana Radulescu <ruxandra.radule...@nxp.com>
---
drivers/staging/fsl-dpaa2/ethernet/dpaa2-ethtool.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/s
(DPCONs).
A more detailed description of the driver can be found in the
associated README file.
Signed-off-by: Ioana Radulescu <ruxandra.radule...@nxp.com>
Signed-off-by: Bogdan Hamciuc <bogdan.hamc...@nxp.com>
---
v3: no changes
v2:
- update #include paths
- ndo_get_stats64() now
From: Ioana Radulescu <ruxandra.radule...@freescale.com>
This patch adds the command building/parsing wrapper functions
for the DPCON object. The binary interface version is v3.2.
A DPCON (DataPath Concentrator) is an aggregator object that
allows ingress frames from multiple hardware
Signed-off-by: Ioana Radulescu <ruxandra.radule...@nxp.com>
---
v3: no changes
v2: Remove "Freescale" from the driver name
MAINTAINERS | 6 ++
1 file changed, 6 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index b38b42f96e6a..4368f67bb261 100644
--- a/MAINTAINERS
+
Add a README file describing the driver architecture, components
and I/O interface.
Signed-off-by: Ioana Radulescu <ruxandra.radule...@nxp.com>
---
v3: no changes
v2: no changes
drivers/staging/fsl-dpaa2/ethernet/README | 186 ++
1 file changed, 186 inse
driver
is still in staging
- minor updates in patch #4 due to networking API changes
Ioana Radulescu (9):
bus: fsl-mc: add DPCON object APIs
staging: fsl-dpaa2/eth: Add Ethernet driver overview document
staging: fsl-dpaa2/eth: Add APIs for DPNI objects
staging: fsl-dpaa2/eth: Add
Add trace events in significant places of the data path.
Useful for debuggging.
Signed-off-by: Ioana Radulescu <ruxandra.radule...@nxp.com>
---
v3: no changes
v2: no changes
drivers/staging/fsl-dpaa2/ethernet/Makefile| 3 +
.../staging/fsl-dpaa2/ethernet/dpaa2-eth-trace.h
Add a list of TODO items for the Ethernet driver
Signed-off-by: Ioana Radulescu <ruxandra.radule...@nxp.com>
---
v3: Add contact info
v2: Add note
drivers/staging/fsl-dpaa2/ethernet/TODO | 14 ++
1 file changed, 14 insertions(+)
create mode 100644 drivers/staging/fsl-dpaa2/et
Add the command build/parse APIs for operating on DPNI objects through
the DPAA2 Management Complex.
Signed-off-by: Ioana Radulescu <ruxandra.radule...@nxp.com>
---
v3: no changes
v2: update #include paths
drivers/staging/Kconfig |2 +
drivers/staging/Ma
Add custom statistics to be reported via ethtool -S. These include
driver specific per-cpu statistics as well as queue and channel
counters.
Signed-off-by: Ioana Radulescu <ruxandra.radule...@nxp.com>
---
v3: no changes
v2: no changes
drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c
Add support for several ethtool operations: show hardware statistics,
get/set link settings, get hash configuration.
Signed-off-by: Ioana Radulescu <ruxandra.radule...@nxp.com>
Signed-off-by: Bogdan Hamciuc <bogdan.hamc...@nxp.com>
---
v3: no changes
v2: no changes
drivers/stagi
Use the correct mechanisms for translating a DMA-mapped IOVA
address into a virtual one. Without this fix, once SMMU is
enabled on Layerscape platforms, the Ethernet driver throws
IOMMU translation faults.
Signed-off-by: Nipun Gupta <nipun.gu...@nxp.com>
Signed-off-by: Ioana Rad
Gupta <nipun.gu...@nxp.com>
Signed-off-by: Ioana Radulescu <ruxandra.radule...@nxp.com>
---
drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c
b/drivers/stagi
Make a couple of locally used functions and structures static.
Issue found through static analysis tool.
Signed-off-by: Ioana Radulescu <ruxandra.radule...@nxp.com>
---
drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 6 +++---
drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.h
In dpni_get_irq_status(), status is both in and out parameter,
so initialize before use.
Issue found through static analysis tool.
Signed-off-by: Ioana Radulescu <ruxandra.radule...@nxp.com>
---
drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 2 +-
1 file changed, 1 insertion(+), 1 de
The driver logic for allocating a MAC address to a net device
is complicated enough to deserve a function of its own. While
here, cleanup a bit the code comments.
Signed-off-by: Ioana Radulescu <ruxandra.radule...@nxp.com>
---
drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.
If the Ethernet driver doesn't find any DPIO devices during probe,
it may be either because there's none available or because they
haven't been probed yet. Request deferred probing in case it's
the latter.
Signed-off-by: Bharat Bhushan <bharat.bhus...@nxp.com>
Signed-off-by: Ioana Rad
Introduce a helper macro for accessing the frame annotation
status field in a frame buffer.
Signed-off-by: Ioana Radulescu <ruxandra.radule...@nxp.com>
---
drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 31 --
drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.h | 6 ++
Add a label to the ethtool statistics counters, to differentiate
between hardware counters and driver specific ones.
Signed-off-by: Ioana Radulescu <ruxandra.radule...@nxp.com>
---
drivers/staging/fsl-dpaa2/ethernet/dpaa2-ethtool.c | 54 +++---
1 file changed, 27 inse
Reset the buffer pool object before using it, like we do
for the other DPAA2 objects.
Signed-off-by: Ioana Radulescu <ruxandra.radule...@nxp.com>
---
drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/staging/fsl-dpaa2/ethernet
ndo_start_xmit() returns a value of type netdev_tx_t. Update
our ndo function to use the correct type.
Signed-off-by: Ioana Radulescu <ruxandra.radule...@nxp.com>
---
drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/d
This patch series contains fixes for a few minor bugs and
code cleanup and cosmetics. No significant functional changes.
Ioana Radulescu (18):
staging: fsl-dpaa2/eth: Add "static" keyword where needed
staging: fsl-dpaa2/eth: Initialize variable before use
staging: fsl-dpaa2/eth:
We already have a variable for the DMA mapping device,
so use that directly.
Signed-off-by: Ioana Radulescu <ruxandra.radule...@nxp.com>
---
drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/fsl-dpaa2/et
Don't use GFP_DMA when allocating memory for the hash key,
as we don't actually need to allocate from the lowest zone.
Signed-off-by: Ioana Radulescu <ruxandra.radule...@nxp.com>
---
drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
The function itself checks whether GRO support is enabled
and acts accordingly, so we don't need to verify it in the
driver as well.
Signed-off-by: Ioana Radulescu <ruxandra.radule...@nxp.com>
---
drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 5 +
1 file changed, 1 insertion
Remove the dpni_id and buffer_layout fields from device's
private structure. They're only used at probe so we don't
need to store them for further use.
Signed-off-by: Ioana Radulescu <ruxandra.radule...@nxp.com>
---
drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.
on that.
Signed-off-by: Bogdan Purcareata <bogdan.purcare...@nxp.com>
Signed-off-by: Ioana Radulescu <ruxandra.radule...@nxp.com>
---
drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.
We only need to know the buffer pool id, so save exactly
that in the device's private structure, instead of the
entire DPBP attributes struct.
Signed-off-by: Ioana Radulescu <ruxandra.radule...@nxp.com>
---
drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 12 +++-
drivers/stagi
A few error/warning messages lacked a newline at the end
of the text. Add it for improved consistency and cosmetics.
Signed-off-by: Ioana Radulescu <ruxandra.radule...@nxp.com>
---
drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 14 +++---
drivers/staging/fsl-dpaa2/ethernet
Not having Rx hashing distribution enabled for an
interface is a valid configuration and shouldn't be
treated as an error.
Signed-off-by: Ioana Radulescu <ruxandra.radule...@nxp.com>
---
drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 4 ++--
1 file changed, 2 insertions(+), 2 del
Reorder fields in the device's private structure such that
the ones most used on the hotpath are at the beginning of
the structure.
This brings a small performance improvement due to better
cache usage.
Signed-off-by: Ioana Radulescu <ruxandra.radule...@nxp.com>
---
drivers/staging/fsl
On the egress path, frame errors are reported using both a FD control
field and the frame annotation status. The current code only handles
FAS errors. Update to look at both fields when accounting Tx errors.
Signed-off-by: Bogdan Purcareata <bogdan.purcare...@nxp.com>
Signed-off-by:
dpaa2_io_service_register() returns zero even if
qbman_swp_CDAN_set() encountered an error. Fix this
by propagating the error code so the caller is informed
data availability notifications are not properly set
for a channel.
Signed-off-by: Ioana Radulescu <ruxandra.radule...@nxp.com>
---
d
In case dpaa2_io_service_rearm() fails with an error other then
EBUSY, it will do so silently; add a check for this and a warning
message, as a failure here means we're unable to receive any
more traffic on the current cpu.
Signed-off-by: Ioana Radulescu <ruxandra.radule...@nxp.com>
---
d
function to free only
the subsequent buffers.
Signed-off-by: Ioana Radulescu <ruxandra.radule...@nxp.com>
---
drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c
b/d
entering an endless loop.
Signed-off-by: Ioana Radulescu <ruxandra.radule...@nxp.com>
Signed-off-by: Bogdan Purcareata <bogdan.purcare...@nxp.com>
---
drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 58 --
1 file changed, 35 insertions(+), 23 deletions(-)
diff --g
a warning.
Signed-off-by: Ioana Radulescu <ruxandra.radule...@nxp.com>
---
drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c
b/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c
index e9fe1c9
Include firmware version in the driver information exported
through ethtool.
Signed-off-by: Ioana Radulescu <ruxandra.radule...@nxp.com>
---
drivers/staging/fsl-dpaa2/ethernet/dpaa2-ethtool.c | 14 +-
drivers/staging/fsl-dpaa2/ethernet/dpni-cmd.h | 5
drivers/staging/fsl
On Rx path, if we fail to build an skb from the incoming FD,
we still need to update the channel buffer count accordingly,
otherwise we risk depleting the pool while the software counter
still sees available buffers.
Signed-off-by: Ioana Radulescu <ruxandra.radule...@nxp.com>
---
drivers/s
-by: Ioana Radulescu <ruxandra.radule...@nxp.com>
---
drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 12 +++-
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c
b/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c
index 6540ab0..3a8bad1
Early during probe the netdevice name is not initialized yet,
so use dev_err instead of netdev_err when printing error
messages.
Signed-off-by: Ioana Radulescu <ruxandra.radule...@nxp.com>
---
drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 2 +-
1 file changed, 1 insertion(+), 1 de
Take into consideration the return value of napi_complete_done(),
since there might be an indication that it's not suitable to
enable driver interrupts yet.
Signed-off-by: Bogdan Purcareata
---
drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 3 +--
1 file changed, 1
esult when cpu id is negative, by
explicitly stating the comparison is between signed values.
Signed-off-by: Ioana Radulescu <ruxandra.radule...@nxp.com>
---
drivers/staging/fsl-mc/bus/dpio/dpio-service.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging
explicitly comparing the
cpu id with the "any" value before verifying the upper bound.
Signed-off-by: Ioana Radulescu <ruxandra.radule...@nxp.com>
---
v2:
- make condition more clear (as suggested by Dan Carpenter)
- don't use unlikely()
drivers/staging/fsl-mc/bus/dpio/dpio-service.c
Add a counter for the number of egress frames that need to be
realloc'ed due to insufficient headroom space.
Signed-off-by: Ioana Radulescu <ruxandra.radule...@nxp.com>
---
drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 1 +
drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.h | 1 +
d
basis.
Signed-off-by: Ioana Radulescu <ruxandra.radule...@nxp.com>
---
drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 9 ++---
drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.h | 11 ---
2 files changed, 14 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/fsl-dpaa2/et
(as client),
we see an increase in throughput from 3.79Gbps to 5.11Gbps. For UDP
traffic no improvement is observed, since the stack usually creates
skbs with minimal headroom (2B) for UDP frames.
Ioana Radulescu (6):
staging: fsl-dpaa2/eth: Fix access to FAS field
staging: fsl-dpaa2/eth: Don't
Extra headroom in RX buffers")
Signed-off-by: Ioana Radulescu <ruxandra.radule...@nxp.com>
---
drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 8
drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.h | 13 +
2 files changed, 13 insertions(+), 8 deletions(-)
diff --git a
we currently use.
Signed-off-by: Ioana Radulescu <ruxandra.radule...@nxp.com>
---
drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 73 +-
drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.h | 6 ---
2 files changed, 13 insertions(+), 66 deletions(-)
diff --git a/d
of our own interfaces, there is no
functional change; for traffic forwarded from a different device or
generated on the core, skb realloc operations are moved from the stack
to our driver, with no visible impact on performance.
Signed-off-by: Ioana Radulescu <ruxandra.radule...@nxp.com>
---
dri
alignment of forwarded frames.
Signed-off-by: Ioana Radulescu <ruxandra.radule...@nxp.com>
---
drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 14 ++
drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.h | 2 +-
2 files changed, 11 insertions(+), 5 deletions(-)
diff --git a/drivers/stagi
in the
skb. In case of forwarded frames, this info will then be used for Tx
and Tx confirmation hardware queue selection, ensuring all processing
of the given frame is done on a single core.
Signed-off-by: Bogdan Purcareata <bogdan.purcare...@nxp.com>
Signed-off-by: Ioana Rad
netdevice queue
affinity to the sending core.
Signed-off-by: Bogdan Purcareata <bogdan.purcare...@nxp.com>
Signed-off-by: Ioana Radulescu <ruxandra.radule...@nxp.com>
---
drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 14 +-
1 file changed, 13 insertions(+), 1 deletion(-)
in fashion from a list of available
services.
Signed-off-by: Ioana Radulescu <ruxandra.radule...@nxp.com>
---
drivers/staging/fsl-mc/bus/dpio/dpio-service.c | 17 +
drivers/staging/fsl-mc/include/dpaa2-io.h | 2 ++
2 files changed, 19 insertions(+)
diff --git a/drivers/st
as argument mostly for uniformity,
but this doesn't change the previous functionality.
Signed-off-by: Ioana Radulescu <ruxandra.radule...@nxp.com>
---
drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 24 ++--
drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.h | 1 +
2 files c
netperf (client), 256 flows:
17.27Gbps with 100% cpu load vs 18.78Gbps with 77.6% cpu load
Ioana Radulescu (2):
staging: fsl-mc/dpio: Add dpaa2_io_service_select() API
staging: fsl-dpaa2/eth: Use affine DPIO services
drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 24
Update the doc file to comply with the rst format.
It's not integrated into the documentation build structure yet,
since it's still located in drivers/staging.
Signed-off-by: Ioana Radulescu <ruxandra.radule...@nxp.com>
---
v2: patch generated with -M option
.../staging/fsl-mc/{READ
MC portals may not be available at the initial probing attempt
due to dependencies on other modules.
Check the return value of the MC portal allocation function and
defer probing in case it's not available yet. For all other error
cases the behaviour stays the same.
Signed-off-by: Ioana
Checkpatch complains about unnamed arguments in a function
prototype, so fix it.
Signed-off-by: Ioana Radulescu
---
drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.h | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.h
b
File net.h has several bitmask defines that could be implemented
more clearly using the BIT() macro.
Signed-off-by: Ioana Radulescu
---
drivers/staging/fsl-dpaa2/ethernet/net.h | 448 +++
1 file changed, 219 insertions(+), 229 deletions(-)
diff --git a/drivers
Comments in file net.h are too fancy for their own good,
so convert them to the regular format.
Signed-off-by: Ioana Radulescu
---
drivers/staging/fsl-dpaa2/ethernet/net.h | 76
1 file changed, 38 insertions(+), 38 deletions(-)
diff --git a/drivers/staging/fsl
File net.h contains unused defines, so remove them.
Signed-off-by: Ioana Radulescu
---
drivers/staging/fsl-dpaa2/ethernet/net.h | 85
1 file changed, 85 deletions(-)
diff --git a/drivers/staging/fsl-dpaa2/ethernet/net.h
b/drivers/staging/fsl-dpaa2/ethernet
Private header file net.h receives a cleanup and the remaining code
is then merged into dpkg.h
This patchset depends on:
staging: fsl-dpaa2/eth: add SPDX license identifiers
(https://lore.kernel.org/patchwork/patch/969402/)
Ioana Radulescu (4):
staging: fsl-dpaa2/eth: Cleanup comments
File net.h contains definitions that are exclusively used by
the key generator/classification API. Merge its contents with
dpkg.h in order to reduce the number of private headers.
Signed-off-by: Ioana Radulescu
---
drivers/staging/fsl-dpaa2/ethernet/dpkg.h | 350
intention and makes most sense as a default.
Signed-off-by: Ioana Radulescu
---
drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 6 +++---
drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.h | 5 -
2 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/fsl-dpaa2/ethernet
We never really used the driver version, so no point
in keeping it around.
Signed-off-by: Ioana Radulescu
---
drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 2 --
drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.h | 1 -
drivers/staging/fsl-dpaa2/ethernet/dpaa2-ethtool.c | 2 --
3 files
Error message was referencing wrong function, fix it.
Signed-off-by: Ioana Radulescu
---
drivers/staging/fsl-dpaa2/ethsw/ethsw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/fsl-dpaa2/ethsw/ethsw.c
b/drivers/staging/fsl-dpaa2/ethsw/ethsw.c
index 0d54564e
There's no need to explicitly cast DPAA2_ETH_MFL to u16,
so remove it.
Signed-off-by: Ioana Radulescu
Suggested-by: Dan Carpenter
---
drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/fsl-dpaa2/ethernet/dpaa2
We don't need to call dev_set_drvdata(dev, NULL) on driver
remove since core kernel code also performs this step.
Signed-off-by: Ioana Radulescu
---
drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c
We are using DMA_FROM_DEVICE when mapping RX frame buffers,
but DMA_BIDIRECTIONAL for unmap. Fix the direction for DMA
unmapping operation.
Fixes: 87eb55e418b7 ("staging: fsl-dpaa2/eth: Fix potential endless loop")
Signed-off-by: Ioana Radulescu
---
drivers/staging/fsl-dpaa2/ethe
only once at probe time, with the largest
possible value.
Signed-off-by: Ioana Radulescu
---
drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 26 ++
1 file changed, 6 insertions(+), 20 deletions(-)
diff --git a/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c
b/drivers
One bug fix, one small functional change and a couple of
cleanup patches.
Ioana Radulescu (5):
staging: fsl-dpaa2/eth: Fix DMA mapping direction
staging: fsl-dpaa2/eth: Remove obsolete reference
staging: fsl-dpaa2/eth: Remove pointless instruction
staging: fsl-dpaa2/eth: MTU cleanup
Don't set the lower MTU limit explicitly, since we use
the default value anyway.
Signed-off-by: Ioana Radulescu
---
drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c
b/drivers
Commit 2b7c86eb7bf3 ("staging: fsl-dpaa2/eth: Don't enable FAS on Tx")
removed the status field from the TX confirm frame annotation,
but a reference to it remained in the description of free_tx_fd().
Remove it.
Signed-off-by: Ioana Radulescu
---
drivers/staging/fsl-dpaa2/ethernet/d
Structures that are mapped to hardware registers should explicitly
specify the expected endianness for fields larger than 1 byte.
Signed-off-by: Ioana Radulescu <ruxandra.radule...@nxp.com>
---
drivers/staging/fsl-mc/bus/dpio/qbman-portal.c | 16
drivers/staging/fsl-mc/bu
Function qbman_pull_desc_set_token() is not used at all, so remove it.
Signed-off-by: Ioana Radulescu <ruxandra.radule...@nxp.com>
---
drivers/staging/fsl-mc/bus/dpio/qbman-portal.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/fsl-mc/bus/dpio/qbman-portal.c
b/d
Some code cleanup and bug fixes based on warnings reported by sparse
when building on x86.
Ioana Radulescu (5):
staging: fsl-mc/dpio: Fix incorrect cast
staging: fsl-mc/dpio: Fix cast truncate warning
staging: fsl-mc/dpio: Use __leXX types where needed
staging: fsl-mc/dpio: Fix incorrect
Move the cast in dpaa2_sg_get_addr() to the right place.
Signed-off-by: Ioana Radulescu <ruxandra.radule...@nxp.com>
---
drivers/staging/fsl-mc/include/dpaa2-fd.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/fsl-mc/include/dpaa2-fd.h
b/drivers/stagi
One MC command structure got away with using uXX fields instead
of __leXX. Fix it.
Signed-off-by: Ioana Radulescu <ruxandra.radule...@nxp.com>
---
v2: new patch
drivers/staging/fsl-dpaa2/ethernet/dpni-cmd.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/s
1 - 100 of 276 matches
Mail list logo