Fixes several ugly bugs...
Please pull from 'upstream-fixes' branch of
master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git
upstream-fixes
to receive the following updates:
drivers/net/fec_mpc52xx.c|4 ++--
drivers/net/gianfar.c|2 +-
Alan Cox wrote:
For things like SATA based devices they aren't that fast yet.
You forget the Gigabyte i-RAM.
For others: the i-RAM is a SATA-based device that plugs into a PCI slot
on your motherboard (for power), providing RAM+battery backup as fast as
your SATA bus and DIMMs will go.
Robert Hancock wrote:
This fixes some problems with ATAPI devices on nForce4 controllers in ADMA mode
on systems with memory located above 4GB. We need to delay setting the 64-bit
DMA mask until the PRD table and padding buffer are allocated so that they don't
get allocated above 4GB and break
Tom Lanyon wrote:
Hi list,
Just built a new machine with a Pioneer SATA DVD drive and linux
distro install CDs are not recognising it. The drive is connected to
the ICH9R southbridge of an Intel P35 chipset motherboard.
I can boot from the CD/DVD so the drive itself is working, but the
kernel
Tejun Heo wrote:
These are upstream patches I collected while Jeff is away. Thanks.
* workaround for ATAPI tape drives
* detection/suspend workarounds for several laptops
* ICH8/9 port_enable fix
ata_piix controller ID reorganization is included to ease the fixes.
Please pull from
Ingo Molnar wrote:
single-bzImage initrd
was and is possible,
Correct (though s/initrd/initramfs/).
Take a look at usr/Makefile for how initramfs is automatically included
in the image, right now.
The intention at the time was to quickly follow up this stub (generated
by gen_init_cpio)
SO_NO_CHECK support for IPv6 appeared to be missing. This is presented,
based on a reading of net/ipv4/udp.c.
I wonder if IPv4's CHECKSUM_PARTIAL check from udp_push_pending_frames()
also needs to be copied to IPv6?
Signed-off-by: Jeff Garzik [EMAIL PROTECTED]
---
net/ipv6/udp.c | 10
YOSHIFUJI Hideaki / 吉藤英明 wrote:
In article [EMAIL PROTECTED] (at Wed, 21 Nov 2007 07:45:32 -0500), Jeff Garzik
[EMAIL PROTECTED] says:
SO_NO_CHECK support for IPv6 appeared to be missing. This is presented,
based on a reading of net/ipv4/udp.c.
Disagree. UDP checksum is mandatory in IPv6
Alan Cox wrote:
If a card has no IRQ then pass no interrupt handler but allow polled
usage.
Signed-off-by: Alan Cox [EMAIL PROTECTED]
diff -u --new-file --recursive --exclude-from /usr/src/exclude
linux.vanilla-2.6.24-rc2-mm1/drivers/ata/pata_isapnp.c
Maxim Levitsky wrote:
From 7e24227257f315e52fe0b494dc1253d2a0ce5dff Mon Sep 17 00:00:00 2001
From: Maxim Levitsky [EMAIL PROTECTED]
Date: Fri, 23 Nov 2007 01:15:36 +0200
Subject: [PATCH] NET: dmfe: don't access configuration space in D3 state
Accidently I reversed the order of pci_save_state
Ian Wienand wrote:
Hi,
When rebooting today I got
Will now restart.
ACPI: PCI interrupt for device :00:03.0 disabled
GSI 20 (level, low) - CPU 1 (0x0100) vector 53 unregistered
Destroying IRQ53 without calling free_irq
WARNING: at
Joe Perches wrote:
Signed-off-by: Joe Perches [EMAIL PROTECTED]
---
drivers/net/chelsio/cxgb2.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
appied 29-36 to netdev#upstream
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to
I pulled all the patches collected by DaveM in davem/netdev-2.6.git a
few days ago into jgarzik/netdev-2.6.git#upstream. As of a few minutes
ago, jgarzik/netdev-2.6.git was rebased to the latest 2.6.24-rc
(torvalds/linux-2.6.git).
Jeff
-
To unsubscribe from this list: send the line
Thomas Klein wrote:
Using own tx_packets counter instead of firmware counters.
Signed-off-by: Thomas Klein [EMAIL PROTECTED]
---
drivers/net/ehea/ehea.h |2 +-
drivers/net/ehea/ehea_main.c |9 +++--
2 files changed, 8 insertions(+), 3 deletions(-)
applies 1-2 to
Robert Hancock wrote:
Based on a quick look at sata_mv it appears it sets a 64-bit DMA mask
unconditionally, but for non-ATA_PROT_DMA commands (which includes all
ATAPI), it just falls back to ata_qc_issue_prot which issues via the
legacy SFF interface and can only handle 32-bit addressing. So
Divy Le Ray wrote:
From: Divy Le Ray [EMAIL PROTECTED]
Return error code when msi-x settings fail.
Signed-off-by: Divy Le Ray [EMAIL PROTECTED]
---
drivers/net/cxgb3/cxgb3_main.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
applied 1-9 to #upstream, then trimmed all
Bryan Wu wrote:
From: Mike Frysinger [EMAIL PROTECTED]
Signed-off-by: Mike Frysinger [EMAIL PROTECTED]
Signed-off-by: Bryan Wu [EMAIL PROTECTED]
---
drivers/net/Kconfig |2 +-
drivers/net/smc91x.h |2 +-
applied 1-2 to #upstream-fixes
-
To unsubscribe from this list: send the line
sonic zhang wrote:
INT status can be OR.
Signed-off-by: Sonic Zhang [EMAIL PROTECTED]
---
drivers/ata/pata_bf54x.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
applied
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to
|2 +-
include/linux/pci_ids.h|4
16 files changed, 84 insertions(+), 61 deletions(-)
Ayaz Abdulla (2):
forcedeth: new mcp79 pci ids
forcedeth boot delay fix
Benjamin Herrenschmidt (1):
ibm_newemac: Fix possible lockup on close
Jeff Garzik (1):
dmfe
ATA_HORKAGE_STUCK_ERR for ATAPI tape drives
Gabriel C (1):
pata_sis.c: Add Packard Bell EasyNote K5305 to laptops
Jeff Garzik (1):
pata_ali: trim trailing whitespace (fix checkpatch complaints)
Mark Lord (1):
libata-scsi: be tolerant of 12-byte ATAPI commands in 16-byte CDBs
Tejun Heo wrote:
2. Filter out certain commands from ACPI. I definitely don't like BIOS
locking up random features via _GTF commands. It makes debugging difficult.
I agree.
Take a look at what Alan has been doing for the trusted command stuff.
At the very least we should definitely blare a
Divy Le Ray wrote:
Jeff Garzik wrote:
Divy Le Ray wrote:
From: Divy Le Ray [EMAIL PROTECTED]
Add parity initialization for T3C adapters.
Signed-off-by: Divy Le Ray [EMAIL PROTECTED]
---
drivers/net/cxgb3/adapter.h |1
drivers/net/cxgb3/cxgb3_main.c| 82
Nothing remarkable. Mainly bonding fixes and bringing ibm_newemac up to
snuff.
Please pull from 'upstream-linus' branch of
master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git
upstream-linus
to receive the following updates:
Documentation/networking/bonding.txt | 29
Divy Le Ray wrote:
From: Divy Le Ray [EMAIL PROTECTED]
Add parity initialization for T3C adapters.
Signed-off-by: Divy Le Ray [EMAIL PROTECTED]
---
drivers/net/cxgb3/adapter.h |1
drivers/net/cxgb3/cxgb3_main.c| 82
drivers/net/cxgb3/cxgb3_offload.c | 15 ++
Divy Le Ray wrote:
From: Divy Le Ray [EMAIL PROTECTED]
Update GPIO mapping for T3C.
Update xgmac for T3C support.
Fix typo in mtu table.
Signed-off-by: Divy Le Ray [EMAIL PROTECTED]
applied #upstream-fixes
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body
Notable: kill spurious NCQ completion detection
libata disabling command queueing (aka NCQ) based on some hueristics for
detection device brokenness that ultimately turned out to be broken.
Remove the broken hueristic and turn NCQ back on for all the wrongfully
maligned hard drives.
Theodore Tso wrote:
On Sat, Dec 08, 2007 at 11:33:57AM -0600, Mike McGrath wrote:
Huh? What's the concern? All you are submitting is a list of
hardware devices in your system. That's hardly anything sensitive
We actually had a very vocal minority about all of that which ended up
putting
As an aside...
Speaking as the maintainer rng-tools, which is the home of the hardware
RNG entropy gathering daemon...
I wish somebody (not me) would take rngd and several other projects, and
combine them into a single actively maintained entropy gathering package.
IMO entropy gathering
Matt Mackall wrote:
On Sat, Dec 08, 2007 at 02:36:33PM -0500, Jeff Garzik wrote:
As an aside...
Speaking as the maintainer rng-tools, which is the home of the hardware
RNG entropy gathering daemon...
I wish somebody (not me) would take rngd and several other projects, and
combine them
Theodore Tso wrote:
I think the userspace config problems were mainly due to the fact that
there wasn't a single official userspace utility package for the
random number package. Comments in drivers/char/random.c for how to
set up /etc/init.d/random is Just Not Enough.
Absolutely.
If we
Orion Poplawski wrote:
Not sure what the latest status of sata_mv hotplug should be, but it
seems close. I'm currently running 2.6.24-0.81.rc4.git7.fc9 with a
MV88SX5081. Pulled a couple drives and re-added. One device got
re-added, but the other did not. It seems like I got the system to
Adrian Bunk wrote:
This patch fixes the following section mismatch with CONFIG_HOTPLUG=n:
-- snip --
...
WARNING: vmlinux.o(.init.text.20+0x4cb25): Section mismatch: reference to
.exit.text:sis190_mii_remove (between 'sis190_init_one' and 'read_eeprom')
...
-- snip --
Signed-off-by:
[EMAIL PROTECTED] wrote:
From: Randy Dunlap [EMAIL PROTECTED]
Make E1000E default to the same kconfig setting as E1000. So people's
machiens don't stop working when they use oldconfig.
Signed-off-by: Randy Dunlap [EMAIL PROTECTED]
Cc: Jeff Garzik [EMAIL PROTECTED]
Cc: Auke Kok [EMAIL
Adrian Bunk wrote:
Code used by the non-__devinit s2io_open() mustn't be __devinit.
This patch fixes the following section mismatch with CONFIG_HOTPLUG=n:
-- snip --
...
WARNING: vmlinux.o(.text+0x6f6e3e): Section mismatch: reference to
.init.text.20:s2io_test_intr (between 's2io_open' and
Adrian Bunk wrote:
On Fri, Dec 14, 2007 at 03:39:26PM -0500, Jeff Garzik wrote:
[EMAIL PROTECTED] wrote:
From: Randy Dunlap [EMAIL PROTECTED]
...
So I think the breakage that occurs is mitigated by two factors:
1) kernel hackers that do their own configs are expected to be able to
figure
On Mon, Dec 24, 2007 at 11:48:13PM +0300, Alexey Dobriyan wrote:
Hi, I occasionally get those soft resetting link messages
right after STR. Typical messages below (from photos):
eth1: link up, 100Mbps, full-duplex, lpa 0x45E1
i8042 kbd 00:0a: activation failed
sd 0:0:0:0: [sda] Starting
saeed bishara wrote:
Hi,
my NFS server seems not to utilize the read-ahead feature, my exported
dir is located on ext3 fs over sata disk. the sata controller can
issue commands up to 1MB, also I modified the read ahead under the sys
to 1MB. but when the client do reads in 32KB chunks (rsize), I
saeed bishara wrote:
(linux-nfs added to cc)
I cannot speak for the NFS server code specifically, but 32kb sounds
like a network read (or write) data size limit.
yes
Are you using TCP? Are you using NFSv4, or an older version?
I'm using NFSv3/UDP.
IMO, you definitely want TCP and NFSv4.
Arjan van de Ven wrote:
This patch also adds a sysfs property for each device into which root can
write a '1' to enable extended configuration space. The kernel will print
a notice into dmesg when this happens (including the name of the app) so that
if the system crashes as a result of this
Linus Torvalds wrote:
Well, the *current* behaviour as far as setup is concerned is
unacceptable. But yes, longer term, we should be able to just have quirk
entries for saying enable mmconfig because I know it's safe, except we
should not enable them until after the core PCI probing has
saeed bishara wrote:
Are you using TCP? Are you using NFSv4, or an older version?
I'm using NFSv3/UDP.
IMO, you definitely want TCP and NFSv4. Much better network behavior,
with some of the silly UDP limits (plus greatly improved caching
behavior, due to v4 delegations).
the clients of my
Tejun Heo wrote:
Thanks a lot for the detailed explanation. Nvidia ppl, any ideas?
FLUSH is used regularly. We really need to fix this.
I reiterate my opinion :) ... We should remove ADMA support from
sata_nv. It's only in a few chips, it's not appearing in any new chips,
and nasty
Allen Martin wrote:
The question I had for NVIDIA regarding this that I never got
answered
was, is there any reason why we would need a delay when switching
between NCQ and non-NCQ commands on ADMA, and if not, is
there any known
cause that could cause the controller to get into this
Signed-off-by: Jeff Garzik [EMAIL PROTECTED]
---
drivers/ata/pata_acpi.c |4 +-
drivers/ata/pata_optidma.c |2 +-
drivers/ata/pata_pdc2027x.c |2 +-
drivers/ata/pata_pdc202xx_old.c |4 +-
drivers/ata/pata_via.c |2 +-
drivers/ata/pata_winbond.c
Alan Cox wrote:
On Wed, 24 Oct 2007 18:20:52 -0700
David Brownell [EMAIL PROTECTED] wrote:
Add a new resource_len() function, so drivers can start using this
instead of driver-private code for a common idiom. The call can be
useful with at least:
- request_region(), release_region()
-
David Brownell wrote:
On Wednesday 24 October 2007, Jeff Garzik wrote:
With regards to resource reservation... IMO we should mimic struct
pci_dev and add struct resource[] to struct device.
One minor difficulty: PCI has a limit on the number of BARs,
but other busses don't. It'd be better
Andrew Morton wrote:
On Wed, 24 Oct 2007 19:48:26 -0400 (EDT) Jeff Garzik [EMAIL PROTECTED] wrote:
drivers/scsi/ips.c | 178
this driver seems a bit of a basket case :(
What's going on here?
scb-dcdb.cmd_attribute
Benjamin Herrenschmidt wrote:
The current napi_disable() uses msleep_interruptible() but doesn't
(and can't) exit in case there's a signal, thus ending up doing a
hot spin without a cpu_relax. Use uninterruptible sleep instead.
Signed-off-by: Benjamin Herrenschmidt [EMAIL PROTECTED]
---
* is quite self-contained
* gives a noticable power savings
I'm definitely interested in seeing somebody pursue software-initiated
link PM as well...
Jeff
commit 218f3d30e60f32394738372c594d063f8e43ee6d
Author: Jeff Garzik [EMAIL PROTECTED]
Date: Thu Oct 25 00:33:27
-by: Kristen Carlson Accardi [EMAIL PROTECTED]
Signed-off-by: Jeff Garzik [EMAIL PROTECTED]
drivers/ata/ahci.c | 157 -
1 file changed, 155 insertions(+), 2 deletions(-)
0fdf9763a76f4cce208b7139e555019217765e81
diff --git a/drivers/ata
David Miller wrote:
The forthcoming patches are also available from:
kernel.org:/pub/scm/linux/kernel/git/davem/msiquirk-2.6.git
and clean up the handling of the common quirk wherein setting
INTX_DISABLE will mistakedly disable MSI generation for some
devices.
For devices without that
Kristen Carlson Accardi wrote:
Enable enclosure management via LED
As described in the AHCI spec, some AHCI controllers may support
Enclosure management via a variety of protocols. This patch
adds support for the LED message type that is specified in
AHCI 1.1 and higher.
Signed-off-by:
Adrian Bunk wrote:
strn_pattern_cmp() and ata_port_detach() can become static.
Signed-off-by: Adrian Bunk [EMAIL PROTECTED]
---
drivers/ata/libata-core.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
applied
-
To unsubscribe from this list: send the line unsubscribe
Al Viro wrote:
Proposed addition to icside part, provided that ARM folks ACK it - gets
icside to build and AFAICS it's correct:
diff --git a/drivers/ata/pata_icside.c b/drivers/ata/pata_icside.c
index be30923..842fe08 100644
--- a/drivers/ata/pata_icside.c
+++ b/drivers/ata/pata_icside.c
@@
applied both bonding patches
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Adrian Bunk wrote:
According to git, the only one who touched this file during the last
5 years was me when removing drivers...
modinfo offers less ancient information.
Signed-off-by: Adrian Bunk [EMAIL PROTECTED]
Acked-by: Geert Uytterhoeven [EMAIL PROTECTED]
Acked-by: Paul Gortmaker [EMAIL
Adrian Bunk wrote:
This patch contains the following cleanups:
- make ipg_nic_get_stats() static
- move DefaultPhyParam[] from ipg.h to ipg.c and make it static
applied
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More
Jan-Bernd Themann wrote:
napi_disable / napi_enable must be applied on all ehea queues.
Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED]
applied
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
Ingo Molnar wrote:
* Andrew Nelless [EMAIL PROTECTED] wrote:
Hi,
I booted up 2.6.24-rc1 this morning [Real early over a brew ;-)] and
was having a problems with multiple ~5 second hangs on SATA/drive init
(Something to do with EH something-or-other and resets but I'll
email in separately
pata_icside build for recent libata API changes
Alan Cox (1):
libata-core: Be a bit more relaxed about early DMA zero devices
Jeff Garzik (1):
[libata] Create [and use -ed.] internal helper ata_dev_set_feature()
Kuan Luo (1):
[libata] sata_nv: SWNCQ should not apply to MCP61
Please pull from 'upstream-linus' branch of
master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git
upstream-linus
to receive the following updates:
Documentation/networking/00-INDEX|2 -
Documentation/networking/net-modules.txt | 315 --
Ack'd by the ISDN maintainer.
Please pull from 'warnings-upstream' branch of
master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/misc-2.6.git
warnings-upstream
to receive the following updates:
drivers/isdn/sc/shmem.c |9 -
1 files changed, 4 insertions(+), 5 deletions(-)
Jeff
sound/oss/sb_common.c: In function 'probe_sbmpu':
sound/oss/sb_common.c:1231: warning: cast to pointer from integer of different
size
Signed-off-by: Jeff Garzik [EMAIL PROTECTED]
---
sound/oss/sb_common.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/sound/oss
that permits the silencing
of this compiler warning.
This change mimics the ifdef-ery and Kconfig defaults of MUST_CHECK as
closely as possible.
Signed-off-by: Jeff Garzik [EMAIL PROTECTED]
---
include/linux/compiler.h |6 ++
lib/Kconfig.debug|8
2 files changed, 14
that have existed for years, and are duly noted
in FIXMEs. There does not seem to be much need to warn on every kernel
build for a driver bug or handicap that has existed for years.
Signed-off-by: Jeff Garzik [EMAIL PROTECTED]
---
drivers/isdn/capi/capidrv.c |3 ++-
drivers/scsi/advansys.c
, if it turns out cmsg-Data value truncation on 64-bit
platforms is problematic in practice.
Signed-off-by: Jeff Garzik [EMAIL PROTECTED]
---
drivers/isdn/capi/capidrv.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/isdn/capi/capidrv.c b/drivers/isdn/capi/capidrv.c
Andrew Morton wrote:
On Thu, 25 Oct 2007 04:06:13 -0400 (EDT) Jeff Garzik [EMAIL PROTECTED] wrote:
The __deprecated marker is quite useful in highlighting the remnants of
old APIs that want removing.
However, it is quite normal for one or more years to pass, before the
(usually ancient
which are no longer necessary.
Signed-off-by: David S. Miller [EMAIL PROTECTED]
[corrected subject line s/4/5/. the actual patches are OK]
Acked-by: Jeff Garzik [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED
Stephane Eranian wrote:
Jeff,
On Tue, Oct 23, 2007 at 07:09:08PM -0400, Jeff Garzik wrote:
By deleting unused code, this makes perfmon irq handling more efficient,
as well as reducing code size.
* remove unused pfm_install_alt_pmu_interrupt()
* remove unused pfm_remove_alt_pmu_interrupt()
I
This is a summary of items and issues that remain outstanding for
libata. Whenever a git branch is mentioned, it is referring to a branch
at git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata-dev.git
Current push just sent to Linus:
Jeff Garzik wrote:
Active libata branches:
ALLSuperset branch for -mm testing
alpmLink power management (2.6.24-rc hopefully)
anAsync notify (2.6.24-rc hopefully)
for-testingInteresting-but-not-ready stuff
masterVanilla linux-2.6.git
Tejun Heo wrote:
Jeff Garzik wrote:
3) Tejun: libata: implement ata_wait_after_reset()
^^^ Tejun, what case does this solve? Still needed?
Not needed yet. It will be necessary to support a weird device (CF
bridged over SATA) but it's a nice clean up regardless (instead of
quoting
Bill Davidsen wrote:
Adrian Bunk wrote:
This patch contains the planned removal of the eepro100 driver.
Are the e100 people satisfied that e100 now handles all known cases? I
Nope. There are still e100 work outstanding that means we cannot kill
eepro100.
Jeff
-
To unsubscribe
thanks for reviewing these!
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Jeff Garzik wrote:
Ismail Dönmez wrote:
Thursday 25 October 2007 Tarihinde 17:55:00 yazmıştı:
I think the OpenBSD people decided to actually do something about this,
and I suspect it had *nothing* to do with license issues, and everything
to do with these kinds of problems. I wish them all
Ismail Dönmez wrote:
Thursday 25 October 2007 Tarihinde 17:55:00 yazmıştı:
I think the OpenBSD people decided to actually do something about this,
and I suspect it had *nothing* to do with license issues, and everything
to do with these kinds of problems. I wish them all the luck, although
Linux Kernel Mailing List wrote:
Gitweb:
http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=568a17ffce2eeceae0cd9fc37e97cbad12f70278
Commit: 568a17ffce2eeceae0cd9fc37e97cbad12f70278
Parent: 4cfe6c3c1c301d3d7a36c9d579597b75ebb8ea13
Author: Rusty
Alan Cox wrote:
On Fri, 26 Oct 2007 01:36:37 +0200
Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] wrote:
Need to check if the host is a PCI one before reading IDE_ALTSTATUS_REG.
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
Umm why ? The altstatus register goes back to ST-506 and
Karsten Keil wrote:
On Thu, Oct 25, 2007 at 04:06:16AM -0400, Jeff Garzik wrote:
drivers/isdn/capi/capidrv.c: In function 'if_sendbuf':
drivers/isdn/capi/capidrv.c:1865: warning: cast from pointer to integer
of different size
We are passing a kernel pointer, skb-data, but the interface itself
Bartlomiej Zolnierkiewicz wrote:
On Thursday 25 October 2007, Jeff Garzik wrote:
Store our hwif indices at probe time, in order to eliminate a needless
and ugly loop across all hwifs, searching for our pci device.
It seems that we can simplify it even further and remove knowledge about
hwifs
Matthew Wilcox wrote:
drivers/scsi/advansys.c:71:2: warning: #warning this driver is still
not properly converted to the DMA API
I'll be removing this #warning from advansys when I get rid of the
last bus_to_virt. Which I've already done ... it's just that the
resulting driver works on
Matthew Wilcox wrote:
On Thu, Oct 25, 2007 at 10:07:17PM -0400, Jeff Garzik wrote:
Is this warning of value to anybody but you?
Yup. It signals this driver isn't production quality yet.
Is this information worth printing out on everyone else's kernel build?
I thnk that's worth noting
Kumar Gala wrote:
On Oct 26, 2007, at 4:40 AM, Jeff Garzik wrote:
ia64/sn/kernel/huberror.c:
- remove pointless void* cast
- add KERN_xxx prefix
ia64/sn/pci/tioce_provider.c: start functions at column zero
ppc/8xx_io/fec.c: kill prototype, remove extra whitespace
ppc/platforms/85xx
* change #warning to a code comment
* add comment and special ifdef'd 64-bit code for a situation where
we must store a pointer into a CAPI field 'Data', which is fixed by
the interface at 32 bits.
Signed-off-by: Jeff Garzik [EMAIL PROTECTED]
---
drivers/isdn/capi/capidrv.c | 25
- kill pointless irq handler loop to find base address, it is already
passed to irq handler via Scsi_Host.
- kill now-pointless !base test.
Signed-off-by: Jeff Garzik [EMAIL PROTECTED]
---
drivers/scsi/sym53c416.c | 16 +---
1 files changed, 1 insertions(+), 15 deletions
interrupt handlers return a return value these days.
Also, kill always-true test and unneeded void* cast.
Signed-off-by: Jeff Garzik [EMAIL PROTECTED]
---
drivers/net/irda/au1k_ir.c | 11 ---
1 files changed, 4 insertions(+), 7 deletions(-)
diff --git a/drivers/net/irda/au1k_ir.c b
irq handlers have returned a return value for years now... catch up with
the times.
Also, ditch unneeded prototype.
Signed-off-by: Jeff Garzik [EMAIL PROTECTED]
---
drivers/media/video/planb.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/media/video
Signed-off-by: Jeff Garzik [EMAIL PROTECTED]
---
arch/arm/mach-integrator/pci_v3.c |8 +---
arch/arm/mach-omap1/pm.c |2 +-
arch/arm/mach-sa1100/ssp.c|3 +--
arch/arm/plat-omap/mcbsp.c| 20
4 files changed, 19 insertions(+), 14 deletions
mostly in and around irq handlers.
Signed-off-by: Jeff Garzik [EMAIL PROTECTED]
---
arch/arm/mach-pxa/ssp.c|2 +-
arch/arm/mach-s3c2410/usb-simtec.c |2 +-
arch/arm/plat-omap/mailbox.c |2 +-
arch/ia64/sn/pci/pcibr/pcibr_provider.c|6
In these drivers, dev_id is always non-NULL.
Signed-off-by: Jeff Garzik [EMAIL PROTECTED]
---
arch/ia64/hp/sim/simeth.c |5 -
arch/mips/pmc-sierra/msp71xx/msp_hwbutton.c |5 +
drivers/net/cpmac.c |3 ---
drivers/net/ucc_geth.c
as a temporary
variable. Update the function to reflect this usage, changing
the first arg's name from 'irq' to 'dummy'
ppc/platforms/sbc82xx.c: ditto
sparc/kernel/time.c: mark timer_interrupt() static (from DaveM)
Signed-off-by: Jeff Garzik [EMAIL PROTECTED]
---
arch/ia64/sn/kernel
Neither gdth_get_status() nor __gdth_interrupt() need their 'irq'
argument, so remove it.
Signed-off-by: Jeff Garzik [EMAIL PROTECTED]
---
drivers/scsi/gdth.c | 21 +
1 files changed, 9 insertions(+), 12 deletions(-)
diff --git a/drivers/scsi/gdth.c b/drivers/scsi/gdth.c
its usage with that constant.
Signed-off-by: Jeff Garzik [EMAIL PROTECTED]
---
drivers/net/declance.c |6 +++---
drivers/net/lp486e.c |9 -
drivers/usb/gadget/s3c2410_udc.c |4 ++--
3 files changed, 9 insertions(+), 10 deletions(-)
diff --git a/drivers/net
Andrew Morton wrote:
That was a goofup. I proposed that we should add a #define
TWO_ARG_IRQ_HANDLERS (or whatever) and I think I actually wrote the patch,
but it got lost.
I agree it would be a kind thing to do in this case.
Yep, I was thinking that including
#define IRQ_HANDLER_V3
Karsten Keil wrote:
* change #warning to a code comment
* add comment and special ifdef'd 64-bit code for a situation where
we must store a pointer into a CAPI field 'Data', which is fixed by
the interface at 32 bits.
Signed-off-by: Jeff Garzik [EMAIL PROTECTED]
Acked-by: Karsten Keil
Arjan van de Ven wrote:
On Fri, 26 Oct 2007 17:47:58 -0400
Jeff Garzik [EMAIL PROTECTED] wrote:
Andrew Morton wrote:
That was a goofup. I proposed that we should add a #define
TWO_ARG_IRQ_HANDLERS (or whatever) and I think I actually wrote the
patch, but it got lost.
I agree it would
-by: Jeff Garzik [EMAIL PROTECTED]
---
drivers/scsi/atari_scsi.c| 10 +-
drivers/scsi/dtc.c |5 +++--
drivers/scsi/g_NCR5380.c |5 +++--
drivers/scsi/mac_scsi.c |4 ++--
drivers/scsi/pas16.c |5 +++--
drivers/scsi/sun3_scsi.c |4
* remove unnecessary cast
* remove unnecessary use of 'irq' function arg
Signed-off-by: Jeff Garzik [EMAIL PROTECTED]
---
drivers/scsi/NCR5380.c |7 ---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/NCR5380.c b/drivers/scsi/NCR5380.c
index 2597209..31787d8
Arjan van de Ven wrote:
the other serious question is.. how is IRQ_HANDLER_V3 different from a
#ifdef VERSION = 2.6.24 .
it's not really ;)
Note my mention of backport -- kernel version isn't relevant when the
various enterprise distros have random featuresets under random kernel
net/ipv6/tcp_ipv6.c: In function 'tcp_v6_rcv':
net/ipv6/tcp_ipv6.c:1736: error: implicit declaration of function
'get_softnet_dma'
net/ipv6/tcp_ipv6.c:1736: warning: assignment makes pointer from integer
without a cast
Signed-off-by: Jeff Garzik [EMAIL PROTECTED]
---
diff --git a/net/ipv6
1201 - 1300 of 7471 matches
Mail list logo
