On Tue, 2007-03-06 at 21:31 +0100, Rafael J. Wysocki wrote:
For now, we have decided to make the workqueues nonfreezable (the patch for
that has already been merged, AFAICT).
It isn't in 2.6.21-rc3.
I wanted to adapt the BUG_ON(block IO not from suspend code)
patch from suspend2 but
.
Signed-off-by: Johannes Berg [EMAIL PROTECTED]
--- linux-2.6.orig/fs/partitions/Kconfig2007-03-15 11:04:20.785467186
+0100
+++ linux-2.6/fs/partitions/Kconfig 2007-03-15 11:05:14.505467186 +0100
@@ -235,5 +235,4 @@ config EFI_PARTITION
select CRC32
help
Say Y
On Sat, 2007-02-10 at 14:23 +0100, Hesse, Christian wrote:
The driver generates two network devices. The second one is for promicious
mode? Is there any chance to disable the interface?
The second one is the so-called master interface which is used for QoS
stuff. We're working on hiding it
On Tue, 2007-02-13 at 11:10 -0800, Randy Dunlap wrote:
From: Randy Dunlap [EMAIL PROTECTED]
Output of a struct in html mode needs to include the short description
from the struct name line in the output title line.
Yup, that fixes it for structs. I guess I forgot to mention this earlier
[EMAIL PROTECTED]
Output of a function or struct in html mode needs to include the short
description from the function/struct name line in the output title line.
Signed-off-by: Randy Dunlap [EMAIL PROTECTED]
So if anyone cares:
Acked-by: Johannes Berg [EMAIL PROTECTED]
---
scripts/kernel
On Tue, 2007-02-13 at 18:13 +, Pavel Machek wrote:
Yes... is there merged .git tree somewhere? I downloaded iwl git tree,
but it did not contain d80211 stack. I'm now downloading wireless-dev
git tree...
I would expect Intel to post patches some time soon to get into
wireless-dev.
On Tue, 2007-04-10 at 18:20 +0530, Srinivasa Ds wrote:
Below patch fixes this problem. please let me know comments on this.
+#include linux/sysdev.h
Yeah, I heard about that change but didn't have a chance to check it out
yet. Patch looks good to me, of course.
johannes
signature.asc
While debugging why I keep having problems with suspend to disk on my
quad with more recent kernels (2.6.20 worked fine), I managed to capture
this weird ata workqueue corruption via netconsole, just a bit later the
system froze (I was in X but this seems like a reason to panic):
[ 243.981215]
On Thu, 2007-02-22 at 23:58 +0100, Guennadi Liakhovetski wrote:
I think, we only want 1, right? And the latter seems to be more generic /
platform independent? And as a side-effect, powermac would have to migrate
to generic rtc:-)
Can we migrate all of powerpc to genrtc? But yes, I agree.
On Fri, 2007-02-23 at 19:31 +0100, Guennadi Liakhovetski wrote:
Johannes, is there any special meaning in migrate all of powerpc to
genrtc? Or is it just porting every single rtc driver to the generic rtc
API, moving it under drivers/rtc and adjusting its users or are there any
global
On Wed, 2007-02-28 at 02:28 +0300, Oleg Nesterov wrote:
Ugh. I know nothing, nothing, nothing about suspend. I'll try to guess.
Commit: ed746e3b18f4df18afa3763155972c5835f284c5
Yes? with the patch above, _cpu_down() called _after_ freeze_processes() ???
perfect :)
See also my original
On Wed, 2007-02-28 at 01:00 +0100, Rafael J. Wysocki wrote:
How about other kthread_stop()s ? For example,
kernel/softirq.c:cpu_callback() ?
I'd they should be affected as well.
They won't be, if they have PF_NOFREEZE set.
Yup, I missed that.
johannes
signature.asc
Description:
On Wed, 2007-02-28 at 00:57 +0100, Rafael J. Wysocki wrote:
Okay, in that case I'd suggest removing create_freezeable_workqueue() and
make all workqueues nonfreezable once again for 2.6.21 (as far as I know, only
the two XFS workqueues are affected).
I think Nigel might object but I forgot
In wireless we'd like to allow renaming of the phy devices we surface in
sysfs. The base wireless code, however, can be built modular and thus we
need device_rename exported.
Signed-off-by: Johannes Berg [EMAIL PROTECTED]
---
Is this acceptable? For testing reasons we want the cfg80211 code
Hi,
Patch for 2.6.20 is attached.
... and in the meantime netdevices aren't class_device any more :) IOW,
your patch isn't going to work any more. Also, I think wireless could
benefit from this as well.
The kobject framework is well designed, so adding these
features is trivial
On Wed, 2007-02-28 at 12:14 +1100, Nigel Cunningham wrote:
Controversy is no reason to give in! Nevertheless, I think you're right
- I believe the XFS guys said they fixed the issue that had caused I/O
to be submitted post-freeze. Well, we'll see if it appears again, won't
we?
I get to be
the complete input after %d. This
patch changes that.
Signed-off-by: Johannes Berg [EMAIL PROTECTED]
---
Shrug. My use case for this collapsed, but I figured having scanf doing
that correctly might be a good thing.
lib/vsprintf.c |9 +
1 file changed, 9 insertions(+)
--- wireless
On Wed, 2007-02-28 at 10:51 -0800, Jean Tourrilhes wrote:
That's why I always specify the kernel version. I'll look into
that, I'm sure it's not the end of the world ;-)
Sure, just wanted to point it out.
In which sense ? Wireless interface are regular netdevices.
Yeah but in
On Wed, 2007-02-28 at 16:26 -0800, Jean Tourrilhes wrote:
+ /* This function is only used for network interface.
+ * Some hotplug package track interfaces by their name and
+ * therefore want to know when the name is changed by the user. */
Right now, that's true, but wireless
On Wed, 2007-02-28 at 16:51 -0800, Jean Tourrilhes wrote:
I would prefer to fix the comment when this change actually
happens. I prefer comments to refer to the current reality, rather
than past/future situation.
Uh, no. device_rename is perfectly fine, even other people may use it in
[adding linux-wireless to CC]
On Sun, 2007-03-04 at 16:08 -0600, Matt Mackall wrote:
Recent kernels are having troubles with wireless for me. Two seemingly
related problems:
I don't think they are related actually.
a) NetworkManager seems oblivious to the existence of my IPW2200
This is due
On Sun, 2007-03-04 at 17:17 -0800, Greg KH wrote:
This is due to the recent sysfs restructuring I think. IIRC the fix is
to upgrade hal to a current git version.
If that's the cause, the fix is to back out whatever was done to break
userspace. Breaking userspace is not ok. Upgrading
On Tue, 2007-02-27 at 22:51 +0100, Rafael J. Wysocki wrote:
For 2.6.21-rc1 I've invented the appended workaround (works for me, waiting
for
Johannes to confirm it works for him too), but I think we need something
better
for -mm and future kernels.
Finally I could get back to this but
43cb76d91ee85f579a69d42bc8efc08bac560278 (?)
Handled-By : Johannes Berg [EMAIL PROTECTED]
Status : unknown
I really think this is a CONFIG_SYSFS_DEPRECATED issue (not being set),
but want to get Matt confirm either way before saying this is a real
issue or not.
I just tested on my quad
On Mon, 2007-03-05 at 07:59 -0500, Theodore Tso wrote:
(depending on whether we want to accomodate Debian's glacial
release schedule).
I don't think Debian updates the kernel to some actual newer version
either.
johannes
signature.asc
Description: This is a digitally signed message part
On Mon, 2007-03-05 at 17:56 -0800, Greg KH wrote:
Theory F: It broke because you are using NetworkManager for your
network devices and the patches that fix this have not made it into a
real release?
I'm just guessing, but does anyone who is having this problem, NOT using
NetworkManager?
-by: Johannes Berg [EMAIL PROTECTED]
---
net/mac80211/debugfs.c | 20 ++--
net/mac80211/debugfs_sta.c |4
net/mac80211/ieee80211_i.h |4 ++--
net/mac80211/sta_info.h|2 ++
4 files changed, 18 insertions(+), 12 deletions(-)
--- wireless-dev.orig/net
Rank 1: __ieee80211_rx
Warning at net/mac80211/rx.c:1672
Reported 6 times (11 total reports)
Same issue that was ranked 2nd last week
Johannes has diagnosed this as a driver bug in the iwlwifi drivers
More info:
When I halt -p, lockdep warnings triggered as following (hand copy):
WARNING : at kernel/lockdep.c: 700 lookup_lock_class()
snip
lock_acquire
cleanup_workqueue_thread
workqueue_cpu_callback
notifier_call_chain
__raw_notifier_call_chain
raw_notifier_call_chain
__cpu_down
The warning that triggered (lockdep.c:700) means that one class (key)
was used with more than one name.
Right.
Looking at cleanup_workqueue_thread(), the lock_acquire() there works on
wq-lockdep_map, and that is only initialized at one spot:
__create_workqueue_key(), thus it stands to
On Wed, 2007-09-12 at 05:34 -0700, David Miller wrote:
From: Johannes Berg [EMAIL PROTECTED]
Date: Thu, 06 Sep 2007 17:19:55 +0200
Oh btw. Can we stick a might_sleep() into dev_close() *before* the test
whether the device is up? That way, we'd have seen the bug, but
apparently nobody
On Mon, 2007-09-10 at 10:39 -0700, Paul E. McKenney wrote:
On Mon, Sep 10, 2007 at 02:05:47PM +0200, Johannes Berg wrote:
To implement the multicast list callback in mac80211 we need to
do partial list iteration. Since I want to convert the interface
list to an RCU list, I need a new list
On Sa, 2007-09-15 at 21:00 +0200, Eric Valette wrote:
I came to this conclusion too. But I would have preferred to have
#define subsys_exit(fn) modules_exit(fn)
in the case of a module and nop in the non module case...
module_exit is a no-op anyway in the non-modular
[FWIW, my powerbook worked with -rc1]
2.6.24-rc2 works so lala :)
b43 doesn't authenticate via wpa (bluetooth isn't loaded):
WEXT auth param 4 value 0x0 - ioctl[SIOCSIWAUTH]: Operation not supported
WEXT auth param 5 value 0x1 - Internet Systems Consortium DHCP Client V3.1.0
Those error
Currently freezing failures are extremely verbose which sometimes is
unnecessary and prevents the user from seeing which task could not be
frozen.
That's a good thing.
I don't think compile time option is right thing to do.
Dump just the stacks of the non-frozen tasks?
That's harder
+ if (ieee80211_hw_config(local))
+ return -EINVAL;
-EINVAL seems not right. Doesn't that already return an error code?
johannes
signature.asc
Description: This is a digitally signed message part
On Tue, 2007-12-18 at 09:03 -0500, Miles Lane wrote:
I have only seen this happen once, and cannot reproduce it. I'll keep
trying, though.
Dec 16 22:10:48 syntropy kernel: [ 231.718023]
===
Do you have a version that isn't line-wrapped
Sorry. GMail doesn't support sending unwrapped text, as far as I can
tell. I will send the log segment to you as an attachment. Also,
when I sent my .config inline to Andrew recently, it tripped his spam
filter. I'll attach it as well.
Thanks. This is a bug in iwlwifi.
The problem is
What could be causing such a problem?
I would guess that user has ssb loaded from his initrd for some reason
and upgraded the modules by hand.
johannes
signature.asc
Description: This is a digitally signed message part
void myfunc(u8 *data, u32 value)
{
[...]
value = cpu_to_le32(value);
put_unaligned(value, data);
u32 value = get_unaligned(data);
Actually, this is wrong. put_unaligned and get_unaligned use the type of
the data pointer, e.g. on
-by: Tony Breeds [EMAIL PROTECTED]
---
The problem was seen and reported by Johannes Berg and Frederik Himpe.
Paul, I think this is good for 2.6.24.
Changes since v1:
- I noticed that the #define was explictly using current rather than
the task passed in. Using tsk is the right thing to do
Hi,
During a hibernate cycle on my G5, while machine was powering down after
saving the image, I just had a NULL dereference in
clockevents_program_event when accessing dev-mode, dev was NULL.
Unfortunately the machine rebooted before I was able to write down more
than the fact that it was
Hi,
Ok, then I have question: Is the following pseudocode correct
(and problem is in lock validation which checks something
already initialized for another queue) or reusing work_struct
is not permitted from inside called work function ?
(Note comment in code It is permissible to free
Hi,
On my powerbook, with NO_HZ and HIGH_RES_TIMERS, I observed recently
that powernowd would not ever switch between CPU speeds.
Doing some scripting to read /proc/stat every half second and print the
differences, I get output like this on a mostly idle system:
# for reference:
# [user, nice,
Sidenote: in the above example, you may wish to reorder the fields in the
above structure so that the overall structure uses less memory. For example,
moving field3 to sit inbetween field1 and field2 (where the padding is
inserted) would shrink the overall structure by 1 byte:
struct
Going back to an earlier example:
void myfunc(u8 *data, u32 value)
{
[...]
*((u16 *) data) = cpu_to_le32(value);
[...]
typo? should it be a u32 cast?
To avoid the unaligned memory access, you could rewrite it as follows:
void
Contrary to what I claimed later in the thread, my 64-bit powerpc box
(quad-core G5) doesn't suffer from this problem.
Does anybody have any idea? I don't even know how to debug it further.
johannes
signature.asc
Description: This is a digitally signed message part
On my powerbook, with NO_HZ and HIGH_RES_TIMERS, I observed recently
that powernowd would not ever switch between CPU speeds.
Also happens without NO_HZ (with HIGH_RES_TIMERS).
johannes
signature.asc
Description: This is a digitally signed message part
On Tue, 2007-11-27 at 20:57 +1100, Paul Mackerras wrote:
Johannes Berg writes:
Contrary to what I claimed later in the thread, my 64-bit powerpc box
(quad-core G5) doesn't suffer from this problem.
Does anybody have any idea? I don't even know how to debug it further.
I see
On Tue, 2007-11-27 at 16:00 +1100, Tony Breeds wrote:
On Mon, Nov 26, 2007 at 05:23:13PM +0100, Johannes Berg wrote:
Contrary to what I claimed later in the thread, my 64-bit powerpc box
(quad-core G5) doesn't suffer from this problem.
Does anybody have any idea? I don't even know how
During a hibernate cycle on my G5, while machine was powering down after
saving the image, I just had a NULL dereference in
clockevents_program_event when accessing dev-mode, dev was NULL.
Unfortunately the machine rebooted before I was able to write down more
than the fact that it was
On Sat, 2007-12-15 at 00:16 -0800, Ray Lee wrote:
On Dec 14, 2007 11:09 PM, Ray Lee [EMAIL PROTECTED] wrote:
On Dec 14, 2007 6:41 PM, Gabriel C [EMAIL PROTECTED] wrote:
Correct, absolutely no traffic. So if it works for you, then either
it's something that got fixed between -rc3 and -rc5,
On Sun, 2007-12-16 at 00:27 +0100, Michael Buesch wrote:
On Sunday 16 December 2007 00:18:43 Rafael J. Wysocki wrote:
Well, the only problem with that is I suspect there are some newer cards
that
work better with v3 firmware, although they are supposed to support both.
Impossible. The
On Sun, 2007-12-16 at 00:27 +0100, Michael Buesch wrote:
On Sunday 16 December 2007 00:18:43 Rafael J. Wysocki wrote:
Well, the only problem with that is I suspect there are some newer
cards that
work better with v3 firmware, although they are supposed to support
both.
On Fri, 2007-12-28 at 19:58 +0100, Christoph Hellwig wrote:
On Thu, Dec 20, 2007 at 01:47:13PM +0100, Arnd Bergmann wrote:
Also, Christoph has recently posted a suggestion for how to improve
the interface to allow the 'get' operation to return an error:
./drivers/net/3c527.c: * DOC: Notes
Aside from those being about the least interesting drivers in the
tree, that's pretty neat.
The docbook infrastructure probably needs to figure out a way to pick
up this stuff automatically if it's not otherwise tied in.
The 5th and 6th patch in this
There are lots and lots of files that currently contain kerneldoc
comments that are unreferenced by docbook (and have been for years).
We should somehow sweep them all up into some sort of bucket
automatically.
That'd be another thing, but yes, it'd be nice as well. Not something
I'm aiming
Get rid of the following compiler warning message:
net/mac80211/ieee80211_sta.c: In function 'ieee80211_rx_mgmt_assoc_resp':
net/mac80211/ieee80211_sta.c:1187: warning: format '%d' expects type 'int',
but argument 7 has type 'long unsigned int'
a different fix is already applied.
On Thu, 2007-10-18 at 19:48 +0400, Oleg Nesterov wrote:
+void flush_work_sync(struct work_struct *work)
If we really the new helper, perhaps we can make it a bit better?
1. Modify insert_work() to take the struct list_head *at parameter instead
of int tail. I think this patch will also
On 2.6.24.1-stable kernel review cycle, i requested inclusions of
commit 69f817b654d683265118188bbfb8bc0d8978cce6 (mac80211: Restore
rx.fc before every invocation of ieee80211_invoke_rx_handlers)
That one I can agree with, it's a trivial fix.
and ece8edddf067d21c4e5abfe3f1205da1588edbb2
On Thu, 2012-11-01 at 19:01 +0100, Arend van Spriel wrote:
On 11/01/2012 06:43 PM, Randy Dunlap wrote:
From: Randy Dunlap rdun...@infradead.org
Fix printk format warning for ssid_len, which is a size_t:
drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c:3941:2: warning:
format
On Mon, 2012-09-24 at 12:03 +0300, Dan Carpenter wrote:
iwl_alloc_ucode() - iwl_alloc_fw_desc() - dma_alloc_coherent()
I'm filing bugzilla entries for regressions. What's the status on
this?
It looks like a VM change caused it, but I merged a patch for -next to
not require such large
On Sat, 2012-11-03 at 19:40 -0600, Shuah Khan wrote:
Add missing dma_mapping_error() checks to validate dma addresses returned by
dma_map_page() calls to avoid the following warning:
[ 28.475686] WARNING: at lib/dma-debug.c:933 check_unmap+0x459/0x8a0()
[ 28.475688] Hardware name: HP
On Mon, 2012-11-05 at 09:26 -0700, Shuah Khan wrote:
Thanks for the report. Since I think doing BUG_ON() in such a scenario
is a really bad idea, I've applied a different patch with your
Reported-by.
Yeah. I wasn't sure about BUS() either. Did you notice the other cases
of BUG_ON() in
On Tue, 2012-10-23 at 13:04 -0700, Kees Cook wrote:
This config item has not carried much meaning for a while now and is
almost always enabled by default. As agreed during the Linux kernel
summit, remove it.
CC: John W. Linville linvi...@tuxdriver.com
CC: Johannes Berg johan
On Tue, 2012-11-13 at 07:52 +1000, Dave Airlie wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=875328
blamed for breaking wireless.
https://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=35b2a113cb0298d4f9a1263338b456094a414057
apparantly the initscripts used
On Fri, 2007-08-31 at 21:06 -0700, Randy Dunlap wrote:
Johannes is using a feature of kernel-doc that I wasn't even familiar
with, also one that no one else is using. I'm sure that Johannes can
point us to some source code and generated output for it though.
It's not been merged yet:
On Sun, 2007-09-02 at 18:05 +0200, Christian Kujau wrote:
but given the amount of changes currently
going into net/ I thought this might be interesting:
[15604.137408] RTNL: assertion failed at net/core/dev.c (2595)
[15604.138807] [c038c612] __dev_set_promiscuity+0xc2/0xd0
[15604.139163]
[EMAIL PROTECTED]
Looks good to me. The new style seems to be to do
#ifdef SOMETHING
code
#else
#define wiphy_uevent NULL
#endif
and then using it unconditionally, but I'm fine with both.
Acked-by: Johannes Berg [EMAIL PROTECTED]
---
net/wireless/sysfs.c |2 ++
1 file changed, 2 insertions
On Thu, 2007-09-06 at 16:23 +0800, Herbert Xu wrote:
On Thu, Sep 06, 2007 at 10:32:33AM +0530, Satyam Sharma wrote:
[ 382.529041] [c02c8abc] dev_close+0x24/0x67
[ 382.529052] [e01f402b] ieee80211_master_stop+0x4a/0x6d [mac80211]
This is where the bug is. You cannot call
On Thu, 2007-09-06 at 20:36 +0800, Herbert Xu wrote:
Johannes Berg [EMAIL PROTECTED] wrote:
Hah, I suspected as much but didn't have a chance to look yet. I had
plans to replace that sub_if_list with an RCU list and not require the
lock there, but that's far off. Any ideas how to fix
On Thu, 2007-09-06 at 20:36 +0800, Herbert Xu wrote:
Yeah I think they're all under RTNL too. So you don't need to
take the lock here at all since you should already have the RTNL.
Ok, this patch gets rid of the lock. I'd appreciate if you could give it
a quick look for obvious RCU abuse as I
On Thu, 2007-09-06 at 16:23 +0800, Herbert Xu wrote:
On Thu, Sep 06, 2007 at 10:32:33AM +0530, Satyam Sharma wrote:
[ 382.529041] [c02c8abc] dev_close+0x24/0x67
[ 382.529052] [e01f402b] ieee80211_master_stop+0x4a/0x6d [mac80211]
This is where the bug is. You cannot call
On Fri, 2007-09-07 at 07:25 -0700, Paul E. McKenney wrote:
@@ -226,22 +225,22 @@ void ieee80211_if_reinit(struct net_devi
/* Remove all virtual interfaces that use this BSS
* as their sdata-bss */
struct ieee80211_sub_if_data
On Fri, 2007-09-07 at 07:25 -0700, Paul E. McKenney wrote:
I don't like ASSERT_RTNL() much because it actually tries to lock it.
I'd be much happer if it was WARN_ON(!mutex_locked(rtnl_mutex)) or
something equivalent.
Ah! It would indeed be nice to have a lower-overhead
To implement the multicast list callback in mac80211 we need to
do partial list iteration. Since I want to convert the interface
list to an RCU list, I need a new list walking primitive:
list_for_each_entry_continue_rcu().
Signed-off-by: Johannes Berg [EMAIL PROTECTED]
Cc: linux-kernel
done
under rtnl so are well protected against each other, and the
read-side locks we took in the RX and TX code are already in
RCU read-side critical sections.
Signed-off-by: Johannes Berg [EMAIL PROTECTED]
Cc: Florian Lohoff [EMAIL PROTECTED]
Cc: Herbert Xu [EMAIL PROTECTED]
Cc: Michal Piotrowski
On Thu, 2007-09-06 at 08:46 -0700, Paul E. McKenney wrote:
Looks good to me from an RCU viewpoint. I cannot claim familiarity with
this code. I therefore especially like the indications of where RTNL
is held and not!!!
:)
Some questions below based on a quick scan. And a global question:
On Fri, 2007-09-07 at 08:34 -0700, Paul E. McKenney wrote:
+ * Continue to iterate over rcu list of given type, continuing after
+ * the current position.
Please add something like the following to this comment:
Note that the caller is responsible for making sure that
the
On Fri, 2007-09-07 at 18:01 +0200, Michael Buesch wrote:
What's the problem with trying to lock it?
I think I had a problem with it once when I inserted it into some code
that was atomic and it all blew up badly ;) Nothing important really but
it sort of made me not like it much.
johannes
On Fri, 2007-09-07 at 12:57 -0700, Paul E. McKenney wrote:
Actually, list_for_each_continue_rcu() needs to be removed in favor of
your new list_for_each_entry_continue_rcu(). There are currently only
two users as of 2.6.22. One of them immediately does a list_entry(),
and the other would
On Sat, 2007-09-08 at 13:11 +0200, Michal Piotrowski wrote:
Subject : Unable to access memory card reader anymore
References : http://bugzilla.kernel.org/show_bug.cgi?id=8885
Last known good : ?
Submitter : Christian Casteyde [EMAIL PROTECTED]
Caused-By : ?
On Mon, 2007-09-10 at 13:09 +0200, Johannes Berg wrote:
On Sat, 2007-09-08 at 13:11 +0200, Michal Piotrowski wrote:
Subject : Unable to access memory card reader anymore
Last known good/caused-by doesn't apply, the bug has been in there ever
since the mac80211 code was merged
-by: Johannes Berg [EMAIL PROTECTED]
Cc: linux-kernel@vger.kernel.org
Cc: Paul E. McKenney [EMAIL PROTECTED]
---
John, I don't know if you want to merge this or not. There's no clear
list.h maintainer and this patch is requisite for the bugfix I'm going
to send in a minute so it'd probably be best
I think we already fixed this?
Fix ZERO_OR_NULL_PTR(ZERO_SIZE_PTR)
There is no use of ZERO_OR_NULL ptr in krealloc. Linus added a check to
ksize() instead so that ksize(NULL) returns 0 instead of failing.
However, this still doesn't fix the other corner case I pointed out:
On Wed, 2007-07-25 at 11:53 -0700, Christoph Lameter wrote:
It will give you a ZERO_SIZE_PTR
void *krealloc(const void *p, size_t new_size, gfp_t flags)
{
void *ret;
size_t ks;
if (unlikely(!new_size)) {
kfree(p);
return
On Fri, 2007-08-24 at 12:11 +0200, Rafael J. Wysocki wrote:
The idea is [...]
Shouldn't that actually be added into some generic (non-x86-64) doc
file?
johannes
signature.asc
Description: This is a digitally signed message part
On Fri, 2007-08-24 at 16:23 -0700, Andrew Morton wrote:
The preferred way of doing this is via Kconfig, please. ie: add a
CONFIG_HIBERNATION_HEADER to arch/x86_64/Kconfig.
It would be better to do something like this in (say) suspend.h:
#ifdef CONFIG_HIBERNATION_HEADER
extern int
On Mon, 2007-08-27 at 13:06 +0200, Rafael J. Wysocki wrote:
Well, I don't like the weak symbols stuff, but I have managed to limit the
number of additional #ifdefs in snapshot.c to just one.
The generic patch is now the following:
Fine with me, I was just throwing out ideas anyway :)
On Sat, 2007-08-25 at 03:58 -0400, Jiri Slaby wrote:
ath5k, use short preamble for some rates
2, 5.5 and 11 in b/g are now in short preamble mode
umm, mac80211 needs to be able to choose depending on the network.
johannes
signature.asc
Description: This is a digitally signed message part
On Tue, 2007-08-28 at 12:00 -0400, Jiri Slaby wrote:
The files are available only under GPLv2 since now.
Since the BSD people are already getting upset about (for various
reasons among which seem to be a clear non-understanding) I'd suggest
changing it to:
+ * Parts of this file were
On Wed, 2007-08-29 at 15:13 +0200, Xavier Bestel wrote:
How about asking for changes to be dual-licenced too ?
In theory, that could work, but in practice relying on functions that
the Linux kernel offers in GPLv2-only headers etc. will make the result
GPLv2 anyway, and disentangling it would
On Sun, 2007-08-12 at 23:25 -0700, [EMAIL PROTECTED] wrote:
Add file pattern to MAINTAINER entry
+F: include/linux/nl80211.h
+F: include/net/cfg80211.h
+F: net/wireless/core.*
+F: net/wireless/sysfs.*
+F: net/wireless/radiotap.c
I must've missed the original discussion
On Fri, 2007-08-03 at 21:21 +0400, Oleg Nesterov wrote:
To avoid a possible confusion: it is still OK if work-func() flushes
its own workqueue, so strictly speaking this trace is false positive,
but it would be very nice if we can get rid of this practice.
I just had a thought: we could get
On Mon, 2007-08-06 at 11:07 +0200, Pavel Machek wrote:
Hi!
+config SUSPEND_UP_POSSIBLE
+ bool
+ depends on (X86 !X86_VOYAGER) || (PPC32 PPC_MPC52xx) \
+ || (PPC64 (PPC_PSERIES || PPC_PMAC)) || ARM || BLACKFIN \
+ || MIPS || SUPERH || FRV
+ depends
On Mon, 2007-08-06 at 14:53 +0400, Oleg Nesterov wrote:
But this makes -lockdep_map meaningless? We always take wq-lockdep_map
for reading, now we can't detect deadlocks.
read_lock(A);
lock(B);
vs
lock(B);
read_lock(A);
is valid, kernel/lockdep.c should not
On Mon, 2007-08-06 at 13:05 +0200, Marc Dietrich wrote:
I applied the patch, but now I get:
=
[ INFO: inconsistent lock state ]
2.6.23-rc1-mm2 #4
-
inconsistent {softirq-on-W} - {in-softirq-W} usage.
swapper/0
On Mon, 2007-08-06 at 12:26 +0200, Pavel Machek wrote:
Well, so that it does not bitrot? This is few bytes, I'd say, and I
believe we have too many config options already.
This is not an option the user is ever going to see. I think I'd prefer
having two new per-ARCH config symbols though:
On Mon, 2007-08-06 at 13:15 +0200, Johannes Berg wrote:
config SUSPEND_UP_POSSIBLE
depends on ARCH_SUSPEND_UP_POSSIBLE
and then the architecture gets to define that when it can suspend.
In fact, just doing
depends on (ARCH_SUSPEND_UP_POSSIBLE !SMP
On Mon, 2007-08-06 at 13:56 +0200, Rafael J. Wysocki wrote:
On Monday, 6 August 2007 13:36, Pavel Machek wrote:
On Mon 2007-08-06 13:15:17, Johannes Berg wrote:
On Mon, 2007-08-06 at 12:26 +0200, Pavel Machek wrote:
Well, so that it does not bitrot? This is few bytes, I'd say, and I
1 - 100 of 2311 matches
Mail list logo
