Re: [PATCH] Use attribute groups in struct device_type

2007-03-10 Thread Kay Sievers
On 3/10/07, Greg KH [EMAIL PROTECTED] wrote: On Sat, Mar 10, 2007 at 02:12:04AM -0500, Dmitry Torokhov wrote: On Saturday 10 March 2007 01:55, Greg KH wrote: On Fri, Mar 09, 2007 at 10:54:43PM -0800, Greg KH wrote: On Sat, Mar 10, 2007 at 01:37:34AM -0500, Dmitry Torokhov wrote: Greg,

Re: [PATCH] Remove decl_subsys_name macro and single usage of it.

2007-03-15 Thread Kay Sievers
On 3/1/07, Robert P. J. Day [EMAIL PROTECTED] wrote: Remove the macro decl_subsys_name which can be used to declare a sysfs subsystem, along with the single invocation of it in the source tree, since there appears to be little value in creating a subsystem whose subsystem name differs from

Re: [PATCH] Remove decl_subsys_name macro and single usage of it.

2007-03-15 Thread Kay Sievers
On Thu, 2007-03-15 at 08:52 -0400, Robert P. J. Day wrote: On Thu, 15 Mar 2007, Kay Sievers wrote: On 3/1/07, Robert P. J. Day [EMAIL PROTECTED] wrote: Remove the macro decl_subsys_name which can be used to declare a sysfs subsystem, along with the single invocation

current git crashes on bootup with pci_iounmap()

2007-02-13 Thread Kay Sievers
kernel BUG at lib/iomap.c:254! invalid opcode: [#1] ... The screen picture is here: http://vrfy.org/pci_iounmap.jpg It's a Thinkpad T43p. 2.6.20 was working fine. Commenting out: IO_COND(addr, /* nothing */, iounmap(addr)); in: lib/iomap.c:254 makes at least booting up possible.

Re: current git crashes on bootup with pci_iounmap()

2007-02-13 Thread Kay Sievers
On Tue, 2007-02-13 at 17:04 +0100, Marcel Holtmann wrote: kernel BUG at lib/iomap.c:254! invalid opcode: [#1] ... The screen picture is here: http://vrfy.org/pci_iounmap.jpg It's a Thinkpad T43p. 2.6.20 was working fine. Commenting out: IO_COND(addr, /*

Re: current git crashes on bootup with pci_iounmap()

2007-02-14 Thread Kay Sievers
On 2/13/07, Kay Sievers [EMAIL PROTECTED] wrote: On Tue, 2007-02-13 at 17:04 +0100, Marcel Holtmann wrote: kernel BUG at lib/iomap.c:254! invalid opcode: [#1] ... The screen picture is here: http://vrfy.org/pci_iounmap.jpg It's a Thinkpad T43p. 2.6.20 was working fine

Re: 2.6.21-rc3-mm2

2007-03-19 Thread Kay Sievers
On Mon, 2007-03-19 at 12:55 -0700, Andrew Morton wrote: On Mon, 19 Mar 2007 12:17:24 -0700 Randy Dunlap [EMAIL PROTECTED] wrote: On Wed, 7 Mar 2007 20:19:15 -0800 Andrew Morton wrote: ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.21-rc3/2.6.21-rc3-mm2/ -

Re: new sysfs layout and ethernet device names

2007-03-22 Thread Kay Sievers
On 3/20/07, Bill Nottingham [EMAIL PROTECTED] wrote: I was fiddling with the 'new' (no CONFIG_SYSFS_DEPRECATED) layout and ethernet device names, and noticed that the new layout effectively restricts the availability of certain device names. By making a directory for the ethernet device name in

Re: 2.6.21-rc4-mm1

2007-03-27 Thread Kay Sievers
On 3/26/07, Eric Rannaud [EMAIL PROTECTED] wrote: On Mon, Mar 26, 2007 at 01:22:32AM -0800, Andrew Morton wrote: On Mon, 26 Mar 2007 11:09:49 +0200 Cornelia Huck [EMAIL PROTECTED] wrote: If so, do you think I should labour on with uevent-improve-error-checking-and-handling.patch plus your

Re: current git crashes on bootup with pci_iounmap()

2007-02-24 Thread Kay Sievers
On Wed, 2007-02-21 at 20:34 +0900, Tejun Heo wrote: Kay Sievers wrote: On 2/13/07, Kay Sievers [EMAIL PROTECTED] wrote: On Tue, 2007-02-13 at 17:04 +0100, Marcel Holtmann wrote: kernel BUG at lib/iomap.c:254! invalid opcode: [#1] ... The screen picture is here

Re: [bug] hung bootup in various drivers, was: 2.6.21-rc5: known regressions

2007-03-30 Thread Kay Sievers
On Fri, 2007-03-30 at 12:32 -0700, Greg KH wrote: On Fri, Mar 30, 2007 at 07:46:19PM +0200, Ingo Molnar wrote: * Greg KH [EMAIL PROTECTED] wrote: BUG: at drivers/base/driver.c:187 driver_unregister() [c0105ff9] show_trace_log_lvl+0x19/0x2e [c01063e2] show_trace+0x12/0x14

Re: [PATCH 12/11] sched: rt-group: uid-group interface

2008-01-08 Thread Kay Sievers
On Jan 8, 2008 12:02 PM, Peter Zijlstra [EMAIL PROTECTED] wrote: On Tue, 2008-01-08 at 16:27 +0530, Dhaval Giani wrote: On Mon, Jan 07, 2008 at 05:57:42PM +0100, Peter Zijlstra wrote: Subject: sched: rt-group: add uid-group interface Extend the /sys/kernel/uids/uid/ interface to

Re: [i2c] [PATCH] update module-init-tools to support the i2c subsystem

2008-01-14 Thread Kay Sievers
On Jan 14, 2008 6:50 PM, Jean Delvare [EMAIL PROTECTED] wrote: On Mon, 14 Jan 2008 18:08:16 +0100 (CET), Geert Uytterhoeven wrote: On Mon, 14 Jan 2008, Jean Delvare wrote: I thought that the module aliases were generated by scripts/mod/modpost? As a matter of fact, I did not apply Jon's

Re: iso9660 vs udf

2007-09-19 Thread Kay Sievers
On 9/19/07, Andries E. Brouwer [EMAIL PROTECTED] wrote: On Wed, Sep 19, 2007 at 08:05:32AM +0530, Satyam Sharma wrote: I was actually asking for the logs explaining why you thought the _kernel_ incorrectly announced it as an UDF filesystem. No, the CDROM announces itself as an UDF

Re: 2.6.23-rc6-mm1

2007-09-20 Thread Kay Sievers
On 9/20/07, Andrew Morton [EMAIL PROTECTED] wrote: On Wed, 19 Sep 2007 21:43:14 -0700 David Brownell [EMAIL PROTECTED] wrote: On Wednesday 19 September 2007, Andrew Morton wrote: On Wed, 19 Sep 2007 16:44:48 -0700 David Brownell [EMAIL PROTECTED] wrote: 4[ 21.211942] Duplicate

Re: 2.6.24-rc2-mm1

2007-11-14 Thread Kay Sievers
On Wed, 2007-11-14 at 08:59 -0800, Greg KH wrote: On Wed, Nov 14, 2007 at 05:36:48PM +0800, Dave Young wrote: On Nov 14, 2007 4:41 PM, Andrew Morton [EMAIL PROTECTED] wrote: On Wed, 14 Nov 2007 14:47:38 +0800 Dave Young [EMAIL PROTECTED] wrote: On Nov 14, 2007 2:38 PM, Andrew

Re: 2.6.24-rc2-mm1

2007-11-14 Thread Kay Sievers
On Wed, 2007-11-14 at 20:19 +0100, Jiri Kosina wrote: On Wed, 14 Nov 2007, Kay Sievers wrote: Could it be an init-order problem, where something tries to use the block subsystem? Before it is initialized with: block/genhd.c :: subsys_initcall(genhd_device_init); If that's the case, we

Re: 2.6.24-rc2-mm1

2007-11-14 Thread Kay Sievers
On Thu, 2007-11-15 at 09:01 +0800, Dave Young wrote: On Nov 15, 2007 5:27 AM, Kay Sievers [EMAIL PROTECTED] wrote: On Wed, 2007-11-14 at 20:19 +0100, Jiri Kosina wrote: On Wed, 14 Nov 2007, Kay Sievers wrote: Could it be an init-order problem, where something tries to use

Re: 2.6.24-rc2-mm1

2007-11-15 Thread Kay Sievers
On Thu, 2007-11-15 at 16:14 +0800, Dave Young wrote: On Thu, Nov 15, 2007 at 03:38:13AM +0100, Kay Sievers wrote: On Thu, 2007-11-15 at 09:01 +0800, Dave Young wrote: On Nov 15, 2007 5:27 AM, Kay Sievers [EMAIL PROTECTED] wrote: On Wed, 2007-11-14 at 20:19 +0100, Jiri Kosina wrote

Re: EIP is at device_shutdown+0x32/0x60

2007-11-15 Thread Kay Sievers
On Nov 15, 2007 5:34 PM, Greg KH [EMAIL PROTECTED] wrote: On Thu, Nov 15, 2007 at 09:55:34PM +0900, Yasunori Goto wrote: On Thu, 15 Nov 2007 12:11:58 +0300 Alexey Dobriyan [EMAIL PROTECTED] wrote: Three boxes rarely oops during reboot or poweroff with 2.6.24-rc2-mm1 (1) and

Re: 2.6.24-rc2-mm1

2007-11-15 Thread Kay Sievers
On Thu, 2007-11-15 at 09:06 -0800, Greg KH wrote: On Thu, Nov 15, 2007 at 04:14:07PM +0800, Dave Young wrote: On Thu, Nov 15, 2007 at 03:38:13AM +0100, Kay Sievers wrote: On Thu, 2007-11-15 at 09:01 +0800, Dave Young wrote: On Nov 15, 2007 5:27 AM, Kay Sievers [EMAIL PROTECTED] wrote

Re: [patch 1/6] sclp: sysfs interface for SCLP cpi

2007-11-16 Thread Kay Sievers
On Nov 16, 2007 3:29 PM, Martin Schwidefsky [EMAIL PROTECTED] wrote: + +static decl_subsys(cpi, NULL, NULL); + decl_subsys() and all other static kset cruft called subsys will be gone with 2.6.25. The patch series doing this is in -mm, and this patch will need (trivial) adaption to the new

Re: [patch 6/6] kernel: Shutdown Actions Interface

2007-11-16 Thread Kay Sievers
On Nov 16, 2007 3:29 PM, Martin Schwidefsky [EMAIL PROTECTED] wrote: From: Michael Holzheu [EMAIL PROTECTED] -static struct subsys_attribute dump_type_attr = - __ATTR(dump_type, 0644, dump_type_show, dump_type_store); - -static decl_subsys(dump, NULL, NULL); I guess this will

Re: [PATCH 007 of 7] md: Get name for block device in sysfs

2007-12-16 Thread Kay Sievers
On Mon, 2007-12-17 at 09:43 +1100, Neil Brown wrote: On Saturday December 15, [EMAIL PROTECTED] wrote: On Dec 14, 2007 7:26 AM, NeilBrown [EMAIL PROTECTED] wrote: Given an fd on a block device, returns a string like /block/sda/sda1 which can be used to find related

Re: /sys/block [was: [PATCH 007 of 7] md: Get name for block device in sysfs]

2007-12-17 Thread Kay Sievers
On Mon, 2007-12-17 at 08:29 +0300, Michael Tokarev wrote: Kay Sievers wrote: On Mon, 2007-12-17 at 09:43 +1100, Neil Brown wrote: On Saturday December 15, [EMAIL PROTECTED] wrote: On Dec 14, 2007 7:26 AM, NeilBrown [EMAIL PROTECTED] wrote: Given an fd on a block device, returns a string

Re: [1/4] DST: Distributed storage documentation.

2007-12-17 Thread Kay Sievers
On Dec 17, 2007 4:03 PM, Evgeniy Polyakov [EMAIL PROTECTED] wrote: +++ b/Documentation/dst/sysfs.txt @@ -0,0 +1,33 @@ +This file describes sysfs files created for each storage. + +1. Per-storage files. +Each storage has its own dir /sysfs/devices/$storage_name, +2. Per-node files.

Re: [RFC] kobject/kset/ktype documentation and example code updated

2007-12-19 Thread Kay Sievers
On Wed, 2007-12-19 at 23:26 -0500, Alan Stern wrote: On Wed, 19 Dec 2007, Greg KH wrote: associated with a kobject, then the parent for the kobject can be set to NULL in the call to kobject_add() and then the kobject will be placed under the kset itself. and then the kobject's parent

Re: [RFC] New kobject/kset/ktype documentation and example code

2007-11-29 Thread Kay Sievers
On Thu, 2007-11-29 at 10:35 +0100, Cornelia Huck wrote: On Thu, 29 Nov 2007 08:50:31 +0100, Kay Sievers [EMAIL PROTECTED] wrote: We have ~20 callers of kobject_(un)register(), convert them to kobject_init() + kobject_add() + kobject_uevent(), and just delete the broken kobject_(un

Re: [PATCH] kobject: make sure kobj-ktype is set before kobject_init

2007-11-29 Thread Kay Sievers
On Thu, 2007-11-29 at 11:05 +0100, Cornelia Huck wrote: On Wed, 28 Nov 2007 17:00:57 -0500 (EST), Alan Stern [EMAIL PROTECTED] wrote: On Wed, 28 Nov 2007, Greg KH wrote: On Wed, Nov 28, 2007 at 03:42:00PM -0500, Alan Stern wrote: This patch (as1020) adds a check to kobject_init() to

Re: [PATCH] kobject: make sure kobj-ktype is set before kobject_init

2007-11-29 Thread Kay Sievers
On Thu, 2007-11-29 at 10:54 -0500, Alan Stern wrote: On Thu, 29 Nov 2007, Kay Sievers wrote: And if someone calls kobject_put() after kobject_init() to clean up, their release function will not be called if they didn't set the ktype. So the check really belongs into kobject_init() IMO

Re: does /proc/sys/kernel/modprobe actually do anything?

2007-11-29 Thread Kay Sievers
On Nov 29, 2007 1:58 PM, Robert P. J. Day [EMAIL PROTECTED] wrote: On Thu, 29 Nov 2007, Alexey Dobriyan wrote: On 11/29/07, Robert P. J. Day [EMAIL PROTECTED] wrote: echo '#! /bin/sh' /tmp/modprobe echo 'echo $@ /tmp/modprobe.log' /tmp/modprobe echo 'exec /sbin/modprobe $@'

Re: [PATCH] kobject: make sure kobj-ktype is set before kobject_init

2007-11-29 Thread Kay Sievers
On Thu, 2007-11-29 at 12:06 -0500, Alan Stern wrote: On Thu, 29 Nov 2007, Kay Sievers wrote: In fact, if we were designing the kobject API from scratch, I'd suggest making the ktype value an argument to kobject_init() so that it _couldn't_ be omitted. Sounds fine, maybe we

Re: Relax permissions for reading hard drive serial number?

2007-11-29 Thread Kay Sievers
On Nov 29, 2007 4:46 PM, Dan Kegel [EMAIL PROTECTED] wrote: On Nov 29, 2007 7:37 AM, Xavier Bestel [EMAIL PROTECTED] wrote: One sticking point is that apps like Photoshop and probably Punkbuster want to retrieve the hard drive's serial number So they can't be installed on a network

Re: [PATCH] kobject: make sure kobj-ktype is set before kobject_init

2007-11-29 Thread Kay Sievers
On Thu, 2007-11-29 at 13:04 -0500, Alan Stern wrote: On Thu, 29 Nov 2007, Kay Sievers wrote: Sounds fine, maybe we should also pass the name along, so it will be obvious what happens here: int kobject_init(struct kobject *kobj, struct kobj_type *type, const char *fmt

Re: [PATCH] kobject: make sure kobj-ktype is set before kobject_init

2007-11-29 Thread Kay Sievers
On Thu, 2007-11-29 at 14:05 -0500, Alan Stern wrote: On Thu, 29 Nov 2007, Kay Sievers wrote: Your error scenario confirmed my initial concern about suggesting kobject_put() to clean up an initialized kobject. We should probably make kobject_cleanup() free only the resources taken

Re: [PATCH] kobject: make sure kobj-ktype is set before kobject_init

2007-11-29 Thread Kay Sievers
On Thu, 2007-11-29 at 15:09 -0500, Alan Stern wrote: On Thu, 29 Nov 2007, Kay Sievers wrote: My conclusion is different. We should make kobject_init() not consume any resources at all; just initialize various fields. That way it would be okay to call either kfree() or kobject_put

Re: [PATCH] kobject: make sure kobj-ktype is set before kobject_init

2007-11-29 Thread Kay Sievers
On Thu, 2007-11-29 at 21:20 +0100, Kay Sievers wrote: On Thu, 2007-11-29 at 15:09 -0500, Alan Stern wrote: On Thu, 29 Nov 2007, Kay Sievers wrote: There's another good reason for not assigning the name in kobject_init(): Code that uses kobjects (like the driver core) doesn't set

Re: [patch 1/3] bdi patches

2007-11-30 Thread Kay Sievers
On Nov 30, 2007 9:06 AM, Miklos Szeredi [EMAIL PROTECTED] wrote: Provide a place in sysfs for the backing_dev_info object. This allows us to see and set the various BDI specific variables. You don't say what the place is, and I'm not quite familiar enough with sysfs internals to figure

Re: Since sysfs_mount is static and used only in sysfs_init function, it could be just an automatic variable.

2007-12-02 Thread Kay Sievers
On Dec 2, 2007 11:53 PM, Greg KH [EMAIL PROTECTED] wrote: On Sun, Dec 02, 2007 at 03:22:46PM -0700, Eric W. Biederman wrote: Greg KH [EMAIL PROTECTED] writes: On Sun, Dec 02, 2007 at 02:52:17PM +0800, rae l wrote: On Dec 2, 2007 12:48 PM, Greg KH [EMAIL PROTECTED] wrote: ...

Re: [dm-devel] Re: 2.6.24-rc4-mm1

2007-12-06 Thread Kay Sievers
On Dec 6, 2007 8:38 PM, Greg KH [EMAIL PROTECTED] wrote: On Thu, Dec 06, 2007 at 02:18:08PM -0500, [EMAIL PROTECTED] wrote: On Thu, 06 Dec 2007 04:04:20 PST, Andrew Morton said: ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.24-rc4/2.6.24-rc4-mm1/

Re: [dm-devel] Re: 2.6.24-rc4-mm1

2007-12-06 Thread Kay Sievers
On Thu, 2007-12-06 at 18:12 -0500, [EMAIL PROTECTED] wrote: On Thu, 06 Dec 2007 23:04:12 +0100, Kay Sievers said: What's the value of SYSFS_DEPRECATED? Care to set it to yes, if it isn't, and try again? I *knew* there was a D'Oh! error in here. ;) Bisection is fast closing

Re: [BUG] 2.6.23-rc3 can't see sd partitions on Alpha

2007-12-07 Thread Kay Sievers
On Fri, 2007-12-07 at 19:06 +0100, Ingo Molnar wrote: * Bob Tracy [EMAIL PROTECTED] wrote: Ingo Molnar wrote: * Bob Tracy [EMAIL PROTECTED] wrote: Current state of the source tree is the 6f37ac... version, so I'll start backing out the above diffs in related groups and

Re: [EMAIL PROTECTED] created...

2007-11-19 Thread Kay Sievers
On Nov 20, 2007 1:17 AM, David Miller [EMAIL PROTECTED] wrote: From: Greg KH [EMAIL PROTECTED] Date: Mon, 19 Nov 2007 14:54:55 -0800 Woah, the [EMAIL PROTECTED] list is NOT a subscriber-only list at all. It's wide open with a bunch of mailman rule filter to try to handle the worst of the

Re: gitweb: kernel versions in the history (feature request, probably)

2007-11-21 Thread Kay Sievers
On Nov 21, 2007 8:52 AM, Jarek Poplawski [EMAIL PROTECTED] wrote: On Tue, Nov 20, 2007 at 10:20:09PM -0500, J. Bruce Fields wrote: On Wed, Nov 21, 2007 at 12:30:23AM +0100, Jarek Poplawski wrote: I don't know git, but it seems, at least if done for web only, this shouldn't be so 'heavy'.

Re: PCMCIA serial_cs driver binding problems.

2007-11-23 Thread Kay Sievers
On Nov 20, 2007 3:08 PM, [EMAIL PROTECTED] wrote: I'm working to sort out what appear to be issues with binding of the serial_cs driver to a PCMCIA wireless card (Zoom). Card works perfectly in recent 2.6.2[23] kernels if cardmgr is running and PCMCIA_IOCTL support is in the kernel. The

Re: [RFC] New kobject/kset/ktype documentation and example code

2007-11-28 Thread Kay Sievers
On Wed, 2007-11-28 at 12:45 +0100, Cornelia Huck wrote: On Tue, 27 Nov 2007 15:02:52 -0800, Greg KH [EMAIL PROTECTED] wrote: A kset serves these functions: - It serves as a bag containing a group of objects. A kset can be used by the kernel to track all block devices or all PCI

Re: [RFC] New kobject/kset/ktype documentation and example code

2007-11-28 Thread Kay Sievers
On Wed, 2007-11-28 at 10:01 +0100, Cornelia Huck wrote: On Tue, 27 Nov 2007 15:02:52 -0800, Greg KH [EMAIL PROTECTED] wrote: Among other things, kobject_init() sets the kobject's reference count to one. Calling kobject_init() is not sufficient, however. Kobject users must, at a minimum,

Re: [RFC] New kobject/kset/ktype documentation and example code

2007-11-28 Thread Kay Sievers
On Wed, 2007-11-28 at 16:48 +0100, Cornelia Huck wrote: On Wed, 28 Nov 2007 13:23:02 +0100, Kay Sievers [EMAIL PROTECTED] wrote: On Wed, 2007-11-28 at 12:45 +0100, Cornelia Huck wrote: On Tue, 27 Nov 2007 15:02:52 -0800, Greg KH [EMAIL PROTECTED] wrote: The uevent function

Re: [RFC] New kobject/kset/ktype documentation and example code

2007-11-28 Thread Kay Sievers
On Wed, 2007-11-28 at 16:52 +0100, Cornelia Huck wrote: On Wed, 28 Nov 2007 13:35:54 +0100, Kay Sievers [EMAIL PROTECTED] wrote: On Wed, 2007-11-28 at 10:01 +0100, Cornelia Huck wrote: On Tue, 27 Nov 2007 15:02:52 -0800, Greg KH [EMAIL PROTECTED] wrote: Among other things

Re: [RFC] New kobject/kset/ktype documentation and example code

2007-11-28 Thread Kay Sievers
On Wed, 2007-11-28 at 17:12 +0100, Cornelia Huck wrote: On Wed, 28 Nov 2007 16:57:48 +0100, Kay Sievers [EMAIL PROTECTED] wrote: On Wed, 2007-11-28 at 16:48 +0100, Cornelia Huck wrote: On Wed, 28 Nov 2007 13:23:02 +0100, Kay Sievers [EMAIL PROTECTED] wrote: On Wed, 2007-11-28

Re: [RFC] New kobject/kset/ktype documentation and example code

2007-11-28 Thread Kay Sievers
On Wed, 2007-11-28 at 17:51 +0100, Cornelia Huck wrote: On Wed, 28 Nov 2007 17:36:29 +0100, Kay Sievers [EMAIL PROTECTED] wrote: On Wed, 2007-11-28 at 17:12 +0100, Cornelia Huck wrote: On Wed, 28 Nov 2007 16:57:48 +0100, Kay Sievers [EMAIL PROTECTED] wrote: On Wed, 2007-11

Re: [RFC] New kobject/kset/ktype documentation and example code

2007-11-28 Thread Kay Sievers
On Wed, 2007-11-28 at 14:03 -0500, Alan Stern wrote: On Tue, 27 Nov 2007, Greg KH wrote: Part of the difficulty in understanding the driver model - and the kobject abstraction upon which it is built - is that there is no obvious starting place. Dealing with kobjects requires understanding

Re: [RFC] New kobject/kset/ktype documentation and example code

2007-11-28 Thread Kay Sievers
On Wed, 2007-11-28 at 14:36 -0500, Alan Stern wrote: On Wed, 28 Nov 2007, Kay Sievers wrote: Actually the current code doesn't seem to check whether kobj-ktype is NULL or to use the value of kobj-kset-kobj.ktype. Is this an oversight? We just require the ktype. No -- we should

Re: [PATCH] kobject: make sure kobj-ktype is set before kobject_init

2007-11-28 Thread Kay Sievers
On Wed, 2007-11-28 at 15:42 -0500, Alan Stern wrote: This patch (as1020) adds a check to kobject_init() to insure that the ktype field is not NULL. That's good. This is just for safety's sake; as far as I know there are no remaining places where the field is left unset. But ironically,

Re: [RFC] New kobject/kset/ktype documentation and example code

2007-11-28 Thread Kay Sievers
On Wed, 2007-11-28 at 22:08 -0800, Greg KH wrote: On Wed, Nov 28, 2007 at 06:00:27PM +0100, Kay Sievers wrote: On Wed, 2007-11-28 at 17:51 +0100, Cornelia Huck wrote: On Wed, 28 Nov 2007 17:36:29 +0100, Kay Sievers [EMAIL PROTECTED] wrote: On Wed, 2007-11-28 at 17:12 +0100, Cornelia Huck

Re: [dm-devel] Re: 2.6.24-rc4-mm1

2007-12-07 Thread Kay Sievers
On Fri, 2007-12-07 at 15:28 -0500, [EMAIL PROTECTED] wrote: On Fri, 07 Dec 2007 19:44:29 +0100, Kay Sievers said: Anybody got any brilliant ideas? :) I guess it's nash again, which version is it? Confirmed - nash again. 6.0.9 does not work, upgrading to 6.0.19 works. Oh, cool! I

Re: [dm-devel] Re: 2.6.24-rc4-mm1

2007-12-07 Thread Kay Sievers
On Fri, 2007-12-07 at 13:20 -0500, [EMAIL PROTECTED] wrote: On Fri, 07 Dec 2007 00:24:04 +0100, Kay Sievers said: On Thu, 2007-12-06 at 18:12 -0500, [EMAIL PROTECTED] wrote: On Thu, 06 Dec 2007 23:04:12 +0100, Kay Sievers said: What's the value of SYSFS_DEPRECATED? Care to set

Re: [BUG] 2.6.23-rc3 can't see sd partitions on Alpha

2007-12-08 Thread Kay Sievers
On Fri, 2007-12-07 at 23:05 -0600, Bob Tracy wrote: Kay Sievers wrote: Is the udev daemon (still) running while it fails? Yes, and there's something else I forgot to mention that may be significant... For the bad case, in addition to udevd, ps -ef shows a sh -e /lib/udev/net.agent running

Re: [BUG] 2.6.23-rc3 can't see sd partitions on Alpha

2007-12-07 Thread Kay Sievers
On Sat, 2007-12-08 at 09:43 +1300, Michael Cree wrote: Bob Tracy wrote: That was quick :-). Backing out the sysctl_check.c diff gives me a working kernel. Beats the [EMAIL PROTECTED] out of me how/why, though. Michael Cree: could you try backing out the diff below from your

Re: [1/4] DST: Distributed storage documentation.

2007-12-10 Thread Kay Sievers
On Dec 10, 2007 12:47 PM, Evgeniy Polyakov [EMAIL PROTECTED] wrote: diff --git a/Documentation/dst/sysfs.txt b/Documentation/dst/sysfs.txt new file mode 100644 index 000..79d79dc --- /dev/null +++ b/Documentation/dst/sysfs.txt @@ -0,0 +1,30 @@ +This file describes sysfs files created

Re: [1/4] DST: Distributed storage documentation.

2007-12-10 Thread Kay Sievers
On Mon, 2007-12-10 at 15:58 +0300, Evgeniy Polyakov wrote: On Mon, Dec 10, 2007 at 01:51:43PM +0100, Kay Sievers ([EMAIL PROTECTED]) wrote: On Dec 10, 2007 12:47 PM, Evgeniy Polyakov [EMAIL PROTECTED] wrote: diff --git a/Documentation/dst/sysfs.txt b/Documentation/dst/sysfs.txt new file

Re: [1/4] DST: Distributed storage documentation.

2007-12-10 Thread Kay Sievers
On Mon, 2007-12-10 at 17:50 +0300, Evgeniy Polyakov wrote: On Mon, Dec 10, 2007 at 03:31:48PM +0100, Kay Sievers ([EMAIL PROTECTED]) wrote: I meant that for each new device, it will be placed into /sys/devices/its_name, but it can also be accessed via /sys/bus/dst/devices/ Still

Re: [1/4] DST: Distributed storage documentation.

2007-12-10 Thread Kay Sievers
On Mon, 2007-12-10 at 22:33 +0300, Evgeniy Polyakov wrote: On Mon, Dec 10, 2007 at 08:02:28PM +0100, Kay Sievers ([EMAIL PROTECTED]) wrote: uganda:~/codes# ls -l /sys/devices/storage/n-0-81003ebc220/ total 0 drwxr-xr-x 2 root root0 2007-12-10 13:23 power -r--r--r-- 1 root

Re: [1/4] DST: Distributed storage documentation.

2007-12-10 Thread Kay Sievers
On Mon, 2007-12-10 at 22:51 +0300, Evgeniy Polyakov wrote: On Mon, Dec 10, 2007 at 08:44:55PM +0100, Kay Sievers ([EMAIL PROTECTED]) wrote: Actually not - I have to set reference counter to something other than 1 or +/- 1, and thus will have to call kref_get() in a loop, which

Re: 2.6.22.14 oops msg with commvault galaxy ?

2007-12-13 Thread Kay Sievers
On Thu, 2007-12-13 at 13:55 +0100, Ingo Molnar wrote: * Dhaval Giani [EMAIL PROTECTED] wrote: Could you please see if the following patch removes the oops due to CFS sysfs files? (There might still be the other oops due to the floppy sysfs files) Ingo, could you please add this

Re: 2.6.22.14 oops msg with commvault galaxy ?

2007-12-13 Thread Kay Sievers
On Thu, 2007-12-13 at 15:02 +, Vincent Fortier wrote: On Thu, 2007-12-13 at 08:59 -0500, Kay Sievers wrote: On Thu, 2007-12-13 at 13:55 +0100, Ingo Molnar wrote: * Dhaval Giani [EMAIL PROTECTED] wrote: Could you please see if the following patch removes the oops due to CFS

Re: 2.6.22.14 oops msg with commvault galaxy ?

2007-12-13 Thread Kay Sievers
On Thu, 2007-12-13 at 17:50 +0100, Ingo Molnar wrote: * Kay Sievers [EMAIL PROTECTED] wrote: + sa-attr.owner = NULL; sa-attr.name = name; i'm wondering why doesnt this affect 2.6.23 and later? Does sysfs initialize the owner field to NULL automatically

Re: kobject -k_name memory leak

2007-12-15 Thread Kay Sievers
On Sat, 2007-12-15 at 16:34 +0300, Alexey Dobriyan wrote: On Fri, Dec 14, 2007 at 01:48:23PM -0800, Greg KH wrote: On Mon, Dec 03, 2007 at 01:25:51PM -0800, Greg KH wrote: On Tue, Dec 04, 2007 at 12:09:59AM +0300, Alexey Dobriyan wrote: On Mon, Dec 03, 2007 at 12:47:16PM -0800, Greg KH

Re: [PATCH 007 of 7] md: Get name for block device in sysfs

2007-12-15 Thread Kay Sievers
On Dec 14, 2007 7:26 AM, NeilBrown [EMAIL PROTECTED] wrote: Given an fd on a block device, returns a string like /block/sda/sda1 which can be used to find related information in /sys. Ideally we should have an ioctl that works on char devices as well, but that seems far from

[PATCH] PNP: add all PNP card device id's as individual aliases

2007-12-24 Thread Kay Sievers
From: Kay Sievers [EMAIL PROTECTED] Subject: PNP: add all PNP card device id's as individual aliases The current PNP combined card + devices module aliase can never ever match anything, because all these values are never available all at the same time to match a module. Instead of adding

Re: [PATCH 0/4] PM: Do not destroy/create devices while suspended (rev. 2)

2008-01-02 Thread Kay Sievers
On Jan 2, 2008 2:15 PM, Ingo Molnar [EMAIL PROTECTED] wrote: A stupid question. The old RTC driver is in drivers/char/rtc.c, and maps to: crw-r--r-- 1 root root 10, 135 Oct 25 18:02 /dev/rtc the new driver is in drivers/rtc/*, and maps to: crw-r--r-- 1 root root 254, 0 Dec 12 02:30

Re: linux-2.6.23-git3: Many sysfs-related warnings in dmesg

2007-10-25 Thread Kay Sievers
On Wed, 2007-10-24 at 16:52 -0700, Greg KH wrote: On Wed, Oct 24, 2007 at 04:43:48PM -0700, Greg KH wrote: On Wed, Oct 17, 2007 at 12:16:54PM +0200, Kay Sievers wrote: On Tue, 2007-10-16 at 16:23 -0700, Greg KH wrote: On Tue, Oct 16, 2007 at 03:32:48PM -0700, David Miller wrote

Re: [PATCH 0/6] kill i386 and x86_64 directories

2007-10-25 Thread Kay Sievers
On 10/25/07, Sam Ravnborg [EMAIL PROTECTED] wrote: On Thu, Oct 25, 2007 at 09:56:44PM +0200, Sam Ravnborg wrote: This series kill the old i386 and x86_64 directories. The relevant files are moved and adapted and Kconfig.debug was consolidated (thanks to Randy). I had to modify both the

Re: per BDI dirty limit (was Re: -mm merge plans for 2.6.24)

2007-10-26 Thread Kay Sievers
On Fri, 2007-10-26 at 16:48 +0200, Peter Zijlstra wrote: I appreciate the sysfs people their opinion that /sys/bdi/ might not be the best from their POV, however I'm not seeing where to hook the BDI object from so that it all makes sense, a few of the things are currently not exposed in sysfs

Re: per BDI dirty limit (was Re: -mm merge plans for 2.6.24)

2007-10-26 Thread Kay Sievers
On Fri, 2007-10-26 at 17:22 +0200, Peter Zijlstra wrote: On Fri, 2007-10-26 at 17:10 +0200, Kay Sievers wrote: On Fri, 2007-10-26 at 16:48 +0200, Peter Zijlstra wrote: I appreciate the sysfs people their opinion that /sys/bdi/ might not be the best from their POV, however I'm

Re: per BDI dirty limit (was Re: -mm merge plans for 2.6.24)

2007-10-26 Thread Kay Sievers
On Fri, 2007-10-26 at 17:33 +0200, Peter Zijlstra wrote: On Fri, 2007-10-26 at 17:33 +0200, Kay Sievers wrote: On Fri, 2007-10-26 at 17:22 +0200, Peter Zijlstra wrote: On Fri, 2007-10-26 at 17:10 +0200, Kay Sievers wrote: On Fri, 2007-10-26 at 16:48 +0200, Peter Zijlstra wrote

Re: [alsa-devel] sysfs: WARNING: at fs/sysfs/dir.c:424 sysfs_add_one() - with ALSA

2007-10-26 Thread Kay Sievers
On 10/26/07, Takashi Iwai [EMAIL PROTECTED] wrote: At Fri, 26 Oct 2007 08:52:02 -0700, Greg KH wrote: On Fri, Oct 26, 2007 at 02:47:22PM +0530, Kamalesh Babulal wrote: I get similar warning, while loading the alsa driver This is a different problem, not a rename issue like the network

Re: [RFC] full suspend/resume support for i915 DRM driver

2007-10-26 Thread Kay Sievers
On 10/26/07, Jesse Barnes [EMAIL PROTECTED] wrote: On Thursday, October 25, 2007 9:59 pm Greg KH wrote: On Thu, Oct 25, 2007 at 04:53:18PM -0700, Jesse Barnes wrote: Ok, here's yet another version that uses the device model for the suspend/resume, rather than pci hooks. Greg, DRM

Re: linux-2.6.23-git3: Many sysfs-related warnings in dmesg

2007-10-26 Thread Kay Sievers
for the help, Kay From: Kay Sievers [EMAIL PROTECTED] Subject: Driver Core: fix bug in device_rename() for SYSFS_DEPRECATED=y Signed-off-by: Kay Sievers [EMAIL PROTECTED] --- diff --git a/drivers/base/core.c b/drivers/base/core.c index c134341..3f4d6aa 100644 --- a/drivers/base/core.c +++ b

Re: [RFC] full suspend/resume support for i915 DRM driver

2007-10-26 Thread Kay Sievers
On Fri, 2007-10-26 at 11:12 -0700, Jesse Barnes wrote: On Friday, October 26, 2007 10:10 am Kay Sievers wrote: The conversion is already queued in Greg's tree, and in -mm: http://git.kernel.org/?p=linux/kernel/git/gregkh/patches.git;a=blob;f =driver/drm-convert-from-class_device-to-device

Re: fixing up DRM device model usage

2007-10-26 Thread Kay Sievers
On Fri, 2007-10-26 at 11:40 -0700, Jesse Barnes wrote: On Friday, October 26, 2007 10:10 am Kay Sievers wrote: On 10/26/07, Jesse Barnes [EMAIL PROTECTED] wrote: On Thursday, October 25, 2007 9:59 pm Greg KH wrote: On Thu, Oct 25, 2007 at 04:53:18PM -0700, Jesse Barnes wrote: Ok

Re: sysfs: WARNING: at fs/sysfs/dir.c:424 sysfs_add_one()

2007-10-26 Thread Kay Sievers
On 10/26/07, Amit Shah [EMAIL PROTECTED] wrote: On 27/10/2007, Greg KH [EMAIL PROTECTED] wrote: On Fri, Oct 26, 2007 at 10:55:15PM +0530, Amit Shah wrote: On 26/10/2007, Greg KH [EMAIL PROTECTED] wrote: On Fri, Oct 26, 2007 at 12:44:38PM +0530, Amit Shah wrote: On 2.6.24-rc1, I get

Re: linux-2.6.23-git3: Many sysfs-related warnings in dmesg

2007-10-27 Thread Kay Sievers
On Fri, 2007-10-26 at 19:36 -0700, Greg KH wrote: On Fri, Oct 26, 2007 at 08:07:44PM +0200, Kay Sievers wrote: On Fri, 2007-10-26 at 12:05 -0500, Larry Finger wrote: On my openSUSE 10.3 x86_64 system running v2.6.24-rc1-281-g22d2aa1, I get the sysfs rename messages. Care to try

Re: per BDI dirty limit (was Re: -mm merge plans for 2.6.24)

2007-10-27 Thread Kay Sievers
On Sat, 2007-10-27 at 09:02 -0700, Greg KH wrote: On Sat, Oct 27, 2007 at 10:39:59AM +0200, Peter Zijlstra wrote: On Fri, 2007-10-26 at 19:40 -0700, Greg KH wrote: On Sat, Oct 27, 2007 at 03:18:08AM +0200, Peter Zijlstra wrote: On Fri, 2007-10-26 at 22:04 +0200, Peter Zijlstra wrote:

Re: fixing up DRM device model usage

2007-10-27 Thread Kay Sievers
On Fri, 2007-10-26 at 14:31 -0700, Jesse Barnes wrote: On Friday, October 26, 2007 12:08 pm Kay Sievers wrote: The open coded: device_create_file(dev-dev, device_attrs[i]) should probably replaced by passing the array to the class, and the core will do that for you. You mean just set

Re: Device mapper regression 2.6.23 vs. v2.6.23-6597-gcfa76f0

2007-10-29 Thread Kay Sievers
On Mon, 2007-10-29 at 00:18 -0700, Andrew Morton wrote: On Sun, 21 Oct 2007 21:23:21 +0200 Thomas Meyer [EMAIL PROTECTED] wrote: I have an external hard drive with an encrypted partition. I am using kde so all i had to do under 2.6.23 was cryptsetup luksOpen /dev/sdb2 crypt-extern

Re: [PATCH] sysfs: add filter function to groups

2007-10-29 Thread Kay Sievers
On Mon, 2007-10-29 at 10:16 -0500, James Bottomley wrote: In the SCSI transport classes (and soon to be in the AEN event subsystem) we have a lot of need for a grouping that doesn't include all files in the group. We basically want to show capability by which file is present. A classic

Re: [PATCH] sysfs: add filter function to groups

2007-10-29 Thread Kay Sievers
On Mon, 2007-10-29 at 12:28 -0500, James Bottomley wrote: On Mon, 2007-10-29 at 18:27 +0100, Kay Sievers wrote: On Mon, 2007-10-29 at 11:57 -0500, James Bottomley wrote: On Mon, 2007-10-29 at 17:54 +0100, Kay Sievers wrote: On Mon, 2007-10-29 at 10:16 -0500, James Bottomley wrote

Re: [PATCH] sysfs: add filter function to groups

2007-10-29 Thread Kay Sievers
On Mon, 2007-10-29 at 11:57 -0500, James Bottomley wrote: On Mon, 2007-10-29 at 17:54 +0100, Kay Sievers wrote: On Mon, 2007-10-29 at 10:16 -0500, James Bottomley wrote: struct attribute_group { const char *name; + int (*filter_show)(struct kobject

Re: [PATCH] sysfs: add filter function to groups

2007-10-30 Thread Kay Sievers
); Actually, it returns a true/false value indicating whether the given attribute should be displayed. How about this: int (*is_visible)(...); OK, so is this latest revision acceptable to everyone? Acked-by: Kay Sievers [EMAIL PROTECTED] Best, Kay - To unsubscribe from this list: send

Re: [PATCH] sysfs: add filter function to groups

2007-10-30 Thread Kay Sievers
On Oct 31, 2007 1:40 AM, Mark M. Hoffman [EMAIL PROTECTED] wrote: * James Bottomley [EMAIL PROTECTED] [2007-10-30 13:25:43 -0500]: On Mon, 2007-10-29 at 18:58 +0100, Stefan Richter wrote: James Bottomley wrote: struct attribute_group { const char *name; +

Re: BUG in: Driver core: convert block from raw kobjects to core devices

2007-10-18 Thread Kay Sievers
On Thu, 2007-10-18 at 15:23 -0400, Alan Stern wrote: This patch (as1004) fixes a refcounting bug in the development version of the block-device core. Signed-off-by: Alan Stern [EMAIL PROTECTED] --- Kay, you have got to start testing your patches better! That leaves references around

Re: BUG in: Driver core: convert block from raw kobjects to core devices

2007-10-19 Thread Kay Sievers
On Fri, 2007-10-19 at 10:09 -0400, Alan Stern wrote: On Fri, 19 Oct 2007, Kay Sievers wrote: This accounts for everything in del_gendisk except the final put_device. Evidently it doesn't belong there. There's no matching get_device in add_disk or register_disk. Hmm, do you

Re: BUG in: Driver core: convert block from raw kobjects to core devices

2007-10-19 Thread Kay Sievers
On Fri, 2007-10-19 at 13:11 -0400, Alan Stern wrote: On Fri, 19 Oct 2007, Kay Sievers wrote: Don't you have a USB storage device? It should be easy for you to test this on your own system. Sure, I have, and tried a lot of times, and all seemed correct here with the final put. I

Re: BUG in: Driver core: convert block from raw kobjects to core devices

2007-10-18 Thread Kay Sievers
On Thu, 2007-10-18 at 16:08 -0400, Alan Stern wrote: On Thu, 18 Oct 2007, Kay Sievers wrote: On Thu, 2007-10-18 at 15:23 -0400, Alan Stern wrote: This patch (as1004) fixes a refcounting bug in the development version of the block-device core. Signed-off-by: Alan Stern [EMAIL

Re: BUG in: Driver core: convert block from raw kobjects to core devices

2007-10-21 Thread Kay Sievers
On Sat, 2007-10-20 at 21:33 -0400, Alan Stern wrote: On Sat, 20 Oct 2007, Kay Sievers wrote: Here is what I see, the error handler hangs without the final put and the kobject never gets cleaned up. Note the missing: kobject sdb: cleaning up What is your CONFIG_SYSFS_DEPRECATED

Re: BUG in: Driver core: convert block from raw kobjects to core devices

2007-10-22 Thread Kay Sievers
On Sun, 2007-10-21 at 20:26 -0400, Alan Stern wrote: On Sun, 21 Oct 2007, Kay Sievers wrote: [ 458.013133] scsi_disk_release: disk sda, kobj ce8be990, refcount before put_disk 2 [ 458.032420] scsi_device_dev_release: rq cd9b2000 Hmm, I still don't see this without the final put

Re: BUG in: Driver core: convert block from raw kobjects to core devices

2007-10-23 Thread Kay Sievers
On Tue, 2007-10-23 at 00:14 -0400, Alan Stern wrote: On Tue, 23 Oct 2007, Kay Sievers wrote: There is definitely something wrong, I tried all sorts of options now, and a second machine, and I can never get the behavior you see. I even booted with init=/bin/sh. But true, looking

Re: sysfs sys/kernel/ namespace (was Re: [PATCH 0/2] add new notifier function ,take2)

2007-10-24 Thread Kay Sievers
On 10/24/07, Nick Piggin [EMAIL PROTECTED] wrote: On Tuesday 23 October 2007 10:55, Takenori Nagano wrote: Nick Piggin wrote: One thing I'd suggest is not to use debugfs, if it is going to be a useful end-user feature. Is /sys/kernel/notifier_name/ an appropriate place? I'm curious

Re: [PATCH] printk: drop ambiguous LOG_CONT flag

2012-11-01 Thread Kay Sievers
On Mon, Oct 8, 2012 at 9:56 PM, Kay Sievers k...@vrfy.org wrote: On Mon, Oct 8, 2012 at 9:54 PM, Jan H. Schönherr Jan, any updates, did you try something else? Or should we merge the first version for now? I'm working on it, though I cannot spend as much time as I want. :) My current

  1   2   3   4   5   6   7   8   9   >