RE: linux-next: manual merge of the samsung tree with the pinctrl tree

2012-11-06 Thread Kukjin Kim
devicetree node for TMU driver for exynos4) from the samsung tree. I fixed it up (see below) and can carry the fix as necessary (no action is required). Correct, thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW Solution Development Team, Samsung Electronics

RE: [PATCH 2/4] ARM: EXYNOS: PL330 MDMA1 fix for revision 0 of Exynos4210 SOC

2012-11-07 Thread Kukjin Kim
#define EXYNOS5_PA_MDMA0 0x1080 8 Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message

RE: [PATCH V3] gpio: samsung: use pr_* instead of printk

2012-10-23 Thread Kukjin Kim
. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

ERROR: read_current_timer [fs/ext4/ext4.ko] undefined

2012-10-23 Thread Kukjin Kim
Hi all, Now, v3.7-rc2 happens following build error with s3c2410_defconfig... ERROR: read_current_timer [fs/ext4/ext4.ko] undefined! make[2]: *** [__modpost] Error 1 make[1]: *** [modules] Error 2 make[1]: *** Waiting for unfinished jobs Any idea on this? Thanks. K-Gene kg...@kernel.org

Re: [PATCH 2/4] ARM: EXYNOS: PL330 MDMA1 fix for revision 0 of Exynos4210 SOC

2012-10-29 Thread Kukjin Kim
can fix the problem you commented on EXYNOS4210 Rev0 without others?... Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line unsubscribe linux-kernel

RE: [PATCH 2/4] ARM: EXYNOS: PL330 MDMA1 fix for revision 0 of Exynos4210 SOC

2012-11-09 Thread Kukjin Kim
): [0.566245] dma-pl330 dma-pl330.2: PERIPH_ID 0x0, PCELL_ID 0x0 ! [0.566278] dma-pl330: probe of dma-pl330.2 failed with error -22 Fix it by using 'secure' mdma1 address on Exynos4210 revision 0 SOC. Reviewed-by: Tomasz Figa t.f...@samsung.com Cc: Kukjin Kim kgene@samsung.com

RE: [PATCH] ARM: s3c: mark s3c2440_clk_add as __init_refok

2012-10-15 Thread Kukjin Kim
. Signed-off-by: Arnd Bergmann a...@arndb.de Cc: Russell King li...@arm.linux.org.uk Cc: Mike Turquette mturque...@linaro.org Cc: Kukjin Kim kgene@samsung.com Acked-by: Kukjin Kim kgene@samsung.com Cc: Ben Dooks ben-li...@fluff.org --- I'll put this into arm-soc/fixes unless I

RE: [PATCH v2 v2 v2 8/8] spi/s3c64xx: use correct dma_transfer_direction type

2012-10-17 Thread Kukjin Kim
dma_transfer_direction' [- Wenum-compare] Signed-off-by: Arnd Bergmann a...@arndb.de Cc: Ben Dooks ben-li...@fluff.org Cc: Kukjin Kim kgene@samsung.com Acked-by: Kukjin Kim kgene@samsung.com BTW, don't we need following accordingly? diff --git a/drivers/spi/spi-s3c64xx.c b/drivers

RE: ARM: s3c2410: remove dead mach-s3c2410 directory

2012-07-16 Thread Kukjin Kim
. Anyway we should fix it as soon as possible... Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

RE: BAST: update MAINTAINERS entry

2012-07-16 Thread Kukjin Kim
+F: arch/arm/mach-s3c24xx/bast-irq.c TI DAVINCI MACHINE SUPPORT M: Sekhar Nori nsek...@ti.com -- 1.7.7.6 OK, looks good to me, but I'm not sure Simtec Linux Team and Vincent are still supporting BAST? Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer

RE: [PATCH v3 0/6] mmc: dw_mmc: add support for device tree based instantiation

2012-07-19 Thread Kukjin Kim
. Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

RE: linux-next: manual merge of the arm-soc tree with the pm tree

2013-04-19 Thread Kukjin Kim
Olof Johansson wrote: On Wed, Apr 10, 2013 at 05:36:49PM +0900, Kukjin Kim wrote: Stephen Rothwell wrote: Hi all, Hi, Today's linux-next merge of the arm-soc tree got a conflict in arch/arm/mach-s3c24xx/Kconfig between commit 785f40040874 (cpufreq: s3c24xx: move cpufreq

RE: [PATCH v2] usb: Document clocks in samsung,exynos4210-ehci/ohci bindings

2013-04-04 Thread Kukjin Kim
Jingoo Han wrote: On Friday, March 15, 2013 8:01 AM, Doug Anderson wrote: The exynox4210-ehci and exynos4210-ohci nodes need a clock specified using the common clock framework. Document it. Signed-off-by: Doug Anderson diand...@chromium.org It looks good. Acked-by: Jingoo Han

[PATCH 0/3] pinctrl: exynos5440: add gpio interrupt

2013-04-04 Thread Kukjin Kim
This patch updates supporting pinctrl for exynos5440 and based on top of for-next branch of samsung tree. arch/arm/boot/dts/exynos5440.dtsi|2 + drivers/pinctrl/pinctrl-exynos5440.c | 151 +- 2 files changed, 150 insertions(+), 3 deletions(-) [PATCH

[PATCH 1/3] pinctrl: exynos5440: fix probe failure due to missing pin-list in config nodes

2013-04-04 Thread Kukjin Kim
nodes. Signed-off-by: Thomas Abraham thomas...@samsung.com Cc: Linus Walleij linus.wall...@linaro.org Signed-off-by: Kukjin Kim kgene@samsung.com --- drivers/pinctrl/pinctrl-exynos5440.c |9 ++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/pinctrl/pinctrl

[PATCH 3/3] ARM: dts: list the interrupts generated by pin-controller on Exynos5440

2013-04-04 Thread Kukjin Kim
-by: Kukjin Kim kgene@samsung.com --- arch/arm/boot/dts/exynos5440.dtsi |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/arch/arm/boot/dts/exynos5440.dtsi b/arch/arm/boot/dts/exynos5440.dtsi index 25c6134..7132358 100644 --- a/arch/arm/boot/dts/exynos5440.dtsi +++ b/arch/arm

[PATCH 2/3] pinctrl: exynos5440: add gpio interrupt support

2013-04-04 Thread Kukjin Kim
Walleij linus.wall...@linaro.org Signed-off-by: Kukjin Kim kgene@samsung.com --- drivers/pinctrl/pinctrl-exynos5440.c | 142 ++ 1 files changed, 142 insertions(+), 0 deletions(-) diff --git a/drivers/pinctrl/pinctrl-exynos5440.c b/drivers/pinctrl/pinctrl

RE: [PATCH 07/18] cpufreq: s3c24xx: move cpufreq driver to drivers/cpufreq

2013-04-05 Thread Kukjin Kim
Viresh Kumar wrote: This patch moves cpufreq driver of Samsung's ARM based s3c24xx platform to drivers/cpufreq. Cc: Ben Dooks ben-li...@fluff.org Cc: Kukjin Kim kgene@samsung.com Cc: linux-samsung-...@vger.kernel.org Cc: linux-arm-ker...@lists.infradead.org Signed-off-by: Viresh

RE: linux-next: manual merge of the samsung tree with the arm-soc tree

2013-04-05 Thread Kukjin Kim
Stephen Rothwell wrote: Hi Kukjin, Hi, Today's linux-next merge of the samsung tree got a conflict in drivers/irqchip/irq-s3c24xx.c between commit de88cbb7b244 (arm: Move chained_irq_(enter|exit) to a generic file) from the arm-soc tree (where it is called arch/arm/mach-s3c24xx/irq.c)

RE: [PATCH] clk: exynos5250: Fix divider values for sclk_mmc{0,1,2,3}

2013-04-08 Thread Kukjin Kim
Mike Turquette wrote: Quoting Tushar Behera (2013-04-02 01:20:40) In legacy setup, sclk_mmc{0,1,2,3} used PRE_RATIO bit-field (8-bit wide) instead of RATIO bit-field (4-bit wide) for dividing clock rate. With current common clock setup, we are using RATIO bit-field which is creating

RE: [PATCH 07/18] cpufreq: s3c24xx: move cpufreq driver to drivers/cpufreq

2013-04-08 Thread Kukjin Kim
Rafael J. Wysocki wrote: On Friday, April 05, 2013 12:36:34 PM Viresh Kumar wrote: On 5 April 2013 12:18, Kukjin Kim kgene@samsung.com wrote: Basically, this moving looks good to me, but should be re-worked based on for-next of samsung tree because this touches too many samsung

RE: [PATCH 07/18] cpufreq: s3c24xx: move cpufreq driver to drivers/cpufreq

2013-04-08 Thread Kukjin Kim
Rafael J. Wysocki wrote: [...] Well, I'm dropping it. Please merge via the Samsung tree. OK, I will. I got patch file from Viresh, and there is a sign from Rafael, but it should be ack. So Rafael, let me use your ack on this patch when I apply. If any problems, please let me

RE: [PATCH V5 0/4] cpufreq: exynos5440: support for cpufreq driver

2013-04-08 Thread Kukjin Kim
the Viresh's comments. Thanks, Rafael Hi Rafael, I submitted the V6 version with all comments from Viresh addressed. Hi Kukjin Kim, Any suggestion on how this patch should be merged. In my opinion it should go via Rafael's tree as this patch uses some fixes present in Rafael's

RE: [PATCH 9/9] ARM: dts: Add device tree node for exynos5440 TMU controller

2013-04-08 Thread Kukjin Kim
Amit Daniel Kachhap wrote: This patch adds device node for TMU controller. There are 3 instances of the controllers so 3 nodes are created. Signed-off-by: Amit Daniel Kachhap amit.dan...@samsung.com --- arch/arm/boot/dts/exynos5440.dtsi | 43 + 1

Re: [PATCH] ARM: EXYNOS: remove config EXYNOS_DEV_DRM

2013-04-08 Thread Kukjin Kim
On 04/08/13 23:55, Paul Bolle wrote: The only user of Kconfig symbol EXYNOS_DEV_DRM was removed in commit 0a9d5ac307aefbb2c772537d3fe7f75046d563ac (ARM: EXYNOS: removing exynos-drm device registration from non-dt platforms). It is safe to remove this symbol too. Signed-off-by: Paul

Re: [PATCH] ARM: dts: fix bad merge of display timing node to exynos5250-smdk5250.dts

2013-04-08 Thread Kukjin Kim
On 04/09/13 01:51, Doug Anderson wrote: The display timing node was added: 7ed2077 ARM: dts: Add display timing node to exynos5250-smdk5250.dts ...and looks OK there. ...but it looks like we lost a }; in the merge and it no longer compiles. Fix it. Signed-off-by: Doug

Re: [PATCH] ARM: dts: Disable the RTC by default on exynos5

2013-04-08 Thread Kukjin Kim
On 04/09/13 01:58, Doug Anderson wrote: This change makes the rtc on the exynos5250 and 5440 disabled by default to match exynos4. Ever since the common clock framework came in came in, exynos5250 boards have dumped lots of warnings in the boot log. It turns out that we don't see those on

Re: [PATCH] ARM: dts: fix bad merge of display timing node to exynos5250-smdk5250.dts

2013-04-08 Thread Kukjin Kim
On 04/09/13 03:25, Doug Anderson wrote: Kukjin, On Mon, Apr 8, 2013 at 11:23 AM, Kukjin Kimkgene@samsung.com wrote: Thanks for your pointing out. But it should be fixed with re-sorting out the branch. No problem with however you want to solve it. ;) Seemed that the patch was the

Re: [PATCH 3/3] ARM: dts: list the interrupts generated by pin-controller on Exynos5440

2013-04-09 Thread Kukjin Kim
On 04/09/13 17:24, Linus Walleij wrote: On Tue, Mar 26, 2013 at 4:12 PM, Kukjin Kimkgene@samsung.com wrote: From: Thomas Abrahamthomas...@samsung.com Exynos5440 pin-controller generates eight interrupts to support gpio interrupts. List those interrupt numbers in the pin-controller node.

RE: linux-next: manual merge of the arm-soc tree with the pm tree

2013-04-10 Thread Kukjin Kim
Stephen Rothwell wrote: Hi all, Hi, Today's linux-next merge of the arm-soc tree got a conflict in arch/arm/mach-s3c24xx/Kconfig between commit 785f40040874 (cpufreq: s3c24xx: move cpufreq driver to drivers/cpufreq) from the pm tree and As I know, Rafael will drop it in his tree.

RE: [PATCH v2 0/3] ARM: S3C24XX: Add devicetree support for s3c2416

2013-04-10 Thread Kukjin Kim
Heiko Stübner wrote: This is the second installment of beginning devicetree support the Samsung S3C24xx architectures and focuses on the s3c2416 for now. Included is the devicetree support for the s3c24xx irq controller and basic support for smdk2416 boards, which can sucessfully boot.

RE: [PATCH v4 0/2] ARM: Exynos5250: Enabling samsung usb phy

2013-04-10 Thread Kukjin Kim
Vivek Gautam wrote: Based on 'for-next' of linux-samsung tree with following patches from Doug on top: usb: Document clocks in samsung, exynos4210-ehci/ohci bindings ARM: dts: add usb 2.0 clock references to exynos5250 device tree Also depending upon following patch-series for

RE: [PATCH v5 0/3] ARM: Exynos5250: Enabling dwc3-exynos driver

2013-04-10 Thread Kukjin Kim
Vivek Gautam wrote: This patch-set is in continuation with patch-series: [PATCH v4 0/4] Enable ehci, ohci and dwc3 devices on exynos5250 out of which follwowing patches have been picked up: ARM: Exynos5250: Enabling ehci-s5p driver ARM: Exynos5250: Enabling ohci-exynos driver Based on

RE: [PATCH v5 2/3] ARM: dts: Add i2c-arbitrator bus for exynos5250-snow

2013-04-10 Thread Kukjin Kim
Doug Anderson wrote: We need to use the i2c-arbitrator to talk to any of the devices on i2c bus 4 on exynos5250-snow so that we don't confuse the embedded controller (EC). Add the i2c-arbitrator to the device tree. As we add future devices (keyboard, sbs, tps65090) we'll add them on top of

Re: [PATCH v5 2/3] ARM: dts: Add i2c-arbitrator bus for exynos5250-snow

2013-04-10 Thread Kukjin Kim
On 04/10/13 20:02, Wolfram Sang wrote: On Wed, Apr 10, 2013 at 07:59:17PM +0900, Kukjin Kim wrote: Doug Anderson wrote: We need to use the i2c-arbitrator to talk to any of the devices on i2c bus 4 on exynos5250-snow so that we don't confuse the embedded controller (EC). Add the i2c

RE: [PATCH] ARM: S5P64X0: Fix typo CONFIG_S5P64X0_SETUP_SDHCI

2013-04-02 Thread Kukjin Kim
Paul Bolle wrote: Commit ebc433c2890f8ecad2da39fe2dbf2b6e7b309afa (ARM: S5P64X0: Add HSMMC setup for host Controller) added the Kconfig symbol S5P64X0_SETUP_SDHCI_GPIO. By accident it also used a macro CONFIG_S5P64X0_SETUP_SDHCI. Fix that typo. Signed-off-by: Paul Bolle pebo...@tiscali.nl

RE: [PATCH] ARM: S3C64XX: remove obsolete Makefile line

2013-04-02 Thread Kukjin Kim
Paul Bolle wrote: Commit a07613a54d700a974f3a4a657da78ef5d097315d (Merge branch 'samsung/dt' into samsung/cleanup) added this line to arch/arm/mach-s3c64xx/Makefile: obj-$(CONFIG_S3C64XX_DEV_SPI) += dev-spi.o But at that time CONFIG_S3C64XX_DEV_SPI wasn't a valid Kconfig macro

RE: [PATCH] ARM: Fix typo CONFIG_SAMSUNG_DEV_RTC

2013-04-02 Thread Kukjin Kim
Paul Bolle wrote: s3c_rtc_setname() tests for CONFIG_SAMSUNG_DEV_RTC or CONFIG_PLAT_S3C24XX. But of these two macros only CONFIG_PLAT_S3C24XX actually exists. Now we can see that s3c_device_rtc is only defined if either CONFIG_PLAT_S3C24XX or CONFIG_S3C_DEV_RTC are defined. So, apparently,

RE: [PATCH 0/9] thermal: exynos: Add thermal driver for exynos5440

2013-04-02 Thread Kukjin Kim
thermal] is a re-post of the earlier posted patch, https://patchwork.kernel.org/patch/2123131/. Looks OK to me on whole series, there is my ack only on 1st patch though. So if you want to add my ack, feel free: Acked-by: Kukjin Kim kgene@samsung.com Thanks. - Kukjin All these patches

RE: [PATCH] ARM: dts: add usb 2.0 clock references to exynos5250 device tree

2013-04-02 Thread Kukjin Kim
Vivek Gautam wrote: Hi, On Fri, Mar 15, 2013 at 7:07 AM, Jingoo Han jg1@samsung.com wrote: On Thursday, March 14, 2013 2:18 AM, Doug Anderson wrote: This is a fixup to two device tree nodes that have already landed but without clock nodes since the transition to common clock

RE: [PATCH 0/2] These two patches to s3c_pm_arch_prepare_irqs() were part of the work

2013-04-02 Thread Kukjin Kim
Doug Anderson wrote: to make suspend/resume reliable on the ARM Chromebook (exynos5250-snow). A few more details: - The first patch is not strictly needed but was a nice cleanup. Our understanding was that EINT0 was originally turned on for exynos evt0 silicon and not needed for

RE: [PATCH 0/2] These two patches to s3c_pm_arch_prepare_irqs() were part of the work

2013-04-02 Thread Kukjin Kim
Kukjin Kim wrote: Doug Anderson wrote: to make suspend/resume reliable on the ARM Chromebook (exynos5250-snow). A few more details: - The first patch is not strictly needed but was a nice cleanup. Our understanding was that EINT0 was originally turned on for exynos evt0

RE: Re: [PATCH v4 4/4] PM: Devfreq: Add Exynos5-bus devfreq driver for Exynos5250

2013-04-02 Thread Kukjin Kim
Abhilash Kesavan wrote: One concern is that I cannot apply Patch 1/4 directly as the .dts file isn't available to me. Do you intend to apply that patch to another tree and apply the other three to devfreq tree? I have been merging the devfreq tree into Kgene's tree for my testing.

RE: [PATCH v2] mfd: remove twelve unused Kconfig symbols

2013-03-24 Thread Kukjin Kim
...@tiscali.nl Acked-by: Mark Brown broo...@opensource.wolfsonmicro.com Acked-by: Kukjin Kim kgene@samsung.com Thanks. - Kukjin --- 0) This version adds Mark's ACK. It is now also sent to the ARM maintainers, as Mark suggested. 1) Still only eyeball tested. arch/arm/mach-imx/Kconfig

RE: [PATCH] ARM: SAMSUNG: Remove useless Samsung GPIO related CONFIG

2013-03-24 Thread Kukjin Kim
Paul Bolle wrote: The Kconfig entry for S3C_GPIO_CFG_S3C64XX was missed by commit 5ec7414494ed1204c9e2ed0b8232b29860d0986f (ARM: SAMSUNG: Remove useless Samsung GPIO related CONFIGs). Remove it now. Signed-off-by: Paul Bolle pebo...@tiscali.nl --- Untested.

RE: [PATCH] S3C24XX: remove unneeded config SMDK2440_CPU2442

2013-03-24 Thread Kukjin Kim
Paul Bolle wrote: The Kconfig entry for SMDK2440_CPU2442 was moved from one Kconfig file to another in commit acf2d41d8595829eb0ac7bf6891f4875a78d4d6e (ARM: S3C24XX: Move mach-s3c2440/ pll into mach-s3c24xx/). In that move it also lost its statement to select CPU_S3C2442. That was not needed

RE: [PATCH] ARM: samsung: remove config S3C_BOOT_WATCHDOG

2013-03-24 Thread Kukjin Kim
Paul Bolle wrote: All users of S3C_BOOT_WATCHDOG got removed in commit 1ff5f55a8c7b011f818434923a93afc48de0b2ee (ARM: samsung: remove unused arch_decomp_wdog() code). Remove this symbol too. Signed-off-by: Paul Bolle pebo...@tiscali.nl --- 0) Untested. 1) Commit

RE: [PATCH] clocksource: exynos_mct: Add terminating entry for exynos_mct_ids table

2013-03-24 Thread Kukjin Kim
Axel Lin wrote: The of_device_id table is supposed to be zero-terminated. Signed-off-by: Axel Lin axel@ingics.com --- drivers/clocksource/exynos_mct.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/clocksource/exynos_mct.c b/drivers/clocksource/exynos_mct.c index

RE: [PATCH v2] usb: ehci-s5p: Use devm for requesting ehci_vbus_gpio

2013-03-25 Thread Kukjin Kim
Doug Anderson wrote: The ehci_vbus_gpio is requested but never freed. This can cause problems with deferred probes and would cause problems if s5p_ehci_remove was ever called. Use devm to fix this. Signed-off-by: Doug Anderson diand...@chromium.org Acked-by: Kukjin Kim kgene

RE: [PATCH] ARM: EXYNOS: Add missing semicolons in exynos_mct.c

2013-03-25 Thread Kukjin Kim
Doug Anderson wrote: The CLOCKSOURCE_OF_DECLARE lines were added without a semicolon at the end. On my system this causes a compile-time error that looks like: .../drivers/clocksource/exynos_mct.c:557:202: warning: comparison of distinct pointer types lacks a cast [enabled by default]

RE: [PATCH] clocksource: exynos_mct: Add terminating entry for exynos_mct_ids table

2013-03-25 Thread Kukjin Kim
Axel Lin wrote: 2013/3/25 Kukjin Kim kgene@samsung.com: Axel Lin wrote: The of_device_id table is supposed to be zero-terminated. Signed-off-by: Axel Lin axel@ingics.com --- drivers/clocksource/exynos_mct.c |1 + 1 file changed, 1 insertion(+) diff --git

RE: [PATCH RESEND] gpio: samsung: Add terminating entry for exynos_pinctrl_ids

2013-03-25 Thread Kukjin Kim
Axel Lin wrote: The of_device_id table is supposed to be zero-terminated. Signed-off-by: Axel Lin axel@ingics.com Acked-by: Grant Likely grant.lik...@secretlab.ca Acked-by: Kukjin Kim kgene@samsung.com I think, would be better if this could be sent to upstream via gpio tree now

RE: [PATCH] tty: serial: fix typo ARCH_S5P6450

2013-03-10 Thread Kukjin Kim
...@tiscali.nl Acked-by: Kukjin Kim kgene@samsung.com Thanks. - Kukjin --- Bravely untested. drivers/tty/serial/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig index cf9210d..40ddbe4 100644 --- a/drivers

RE: [PATCH] ARM: S3C24XX: drop select MACH_NEO1973

2013-03-11 Thread Kukjin Kim
Paul Bolle wrote: The Kconfig entry for the Openmoko GTA02 / Freerunner phone selects MACH_NEO1973. But there is no Kconfig symbol MACH_NEO1973. The select statement for that symbol is a nop. It can safely be dropped. Signed-off-by: Paul Bolle pebo...@tiscali.nl --- 0) Tested with git

RE: [PATCH] ASoC: samsung: remove last traces of neo1973-gta01

2013-03-12 Thread Kukjin Kim
...@tiscali.nl Acked-by: Kukjin Kim kgene@samsung.com - Kukjin --- Untested. sound/soc/samsung/Kconfig | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/sound/soc/samsung/Kconfig b/sound/soc/samsung/Kconfig index 90e7e66..475fb0d 100644 --- a/sound/soc/samsung

RE: [PATCH v3 2/3] ARM: dts: Add i2c-arbitrator bus for exynos5250-snow

2013-03-13 Thread Kukjin Kim
Naveen Krishna Ch wrote: On 16 February 2013 04:46, Doug Anderson diand...@chromium.org wrote: We need to use the i2c-arbitrator to talk to any of the devices on i2c bus 4 on exynos5250-snow so that we don't confuse the embedded controller (EC). Add the i2c-arbitrator to the device tree.

RE: [PATCH 03/14] MAINTAINERS: remove arch/arm/plat-s3c24xx/

2013-03-04 Thread Kukjin Kim
Cesar Eduardo Barros wrote: This directory was removed by commit 09ec1d7 (ARM: S3C24XX: Remove plat-s3c24xx directory in arch/arm/). Cc: Kukjin Kim kgene@samsung.com Acked-by: Kukjin Kim kgene@samsung.com Thanks. - Kukjin Cc: Ben Dooks ben-li...@fluff.org Cc: Russell King rmk

RE: [PATCH 7/9] [media] s5p-fimc: fix s5pv210 build

2013-03-06 Thread Kukjin Kim
s5pv210_defconfig to build again. Applies on the Mauro's media tree. I'm fine if this can be fixed soon. Signed-off-by: Arnd Bergmann a...@arndb.de Cc: Sylwester Nawrocki s.nawro...@samsung.com Cc: Kyungmin Park kyungmin.p...@samsung.com Cc: Kukjin Kim kgene@samsung.com Acked-by: Kukjin Kim

RE: [PATCH] ARM: S3C24XX: drop select MACH_N35

2013-03-06 Thread Kukjin Kim
Paul Bolle wrote: The unused Kconfig symbol MACH_N35 was removed in commit 85fd6d63bf2927b9da7ab1b0d46723bfdb13808c (ARM: S3C2410: move mach-s3c2410/* into mach-s3c24xx/). But there is still one (pointless) select statement for that symbol. Drop it. Signed-off-by: Paul Bolle

RE: [PATCH v2 0/3] pinctrl: exynos: add support for Samsung's Exynos5250

2013-03-06 Thread Kukjin Kim
Thomas Abraham wrote: Changes since v1: - Change the compatible string from samsung,pinctrl-exynos5250 to samsung,exynos5250-pinctrl. - Rebased to v3.9-rc1 Thomas, this stuff is already in my tree for v3.10, and above changes included in there. Do you want to replace with this patches?

RE: [PATCH] ARM: drop select HAVE_SCHED_CLOCK

2013-03-06 Thread Kukjin Kim
Paul Bolle wrote: The Kconfig symbol HAVE_SCHED_CLOCK got removed in v3.4, with commit 6905a65879b51d326396e63dfea40861a30bc17f (ARM: Make the sched_clock framework mandatory). Drop the last two select statements for that symbol too. They're useless now. Signed-off-by: Paul Bolle

RE: [PATCH] ARM: S3C24XX: drop select MACH_N35

2013-03-06 Thread Kukjin Kim
Paul Bolle wrote: On Thu, 2013-03-07 at 09:02 +0900, Kukjin Kim wrote: BTW, so the machine type can be removed at arch/arm/tools/mach-types as well. Well, that file has a big comment on top, containing the line: Please do not send patches to this file; it is automatically

RE: [PATCH] ARM: EXYNOS: change HAVE_SAMSUNG_KEYPAD to KEYBOARD_SAMSUNG

2013-03-06 Thread Kukjin Kim
Paul Bolle wrote: Commit 6b5ab4f442e32f248b6fad29aafd1d5153f4dbd3 (ARM: EXYNOS: Add Exynos4 device tree enabled board file) added select HAVE_SAMSUNG_KEYPAD if INPUT_KEYBOARD to the MACH_EXYNOS4_DT Kconfig entry. But there's no Kconfig symbol HAVE_SAMSUNG_KEYPAD. Since this select

RE: [PATCH] ARM: EXYNOS: remove EXYNOS_DEV_SYSMMU entirely

2013-03-06 Thread Kukjin Kim
Paul Bolle wrote: Commit 25e9d28d927d2e1731df53f60cde53d75bcb7c36 (ARM: EXYNOS: remove system mmu initialization from exynos tree) removed the Kconfig symbol EXYNOS_DEV_SYSMMU. Remove its last traces too. Signed-off-by: Paul Bolle pebo...@tiscali.nl --- 0) Untested. 1) Please note

RE: [PATCH] ARM: S3C24XX: drop select MACH_N35

2013-03-06 Thread Kukjin Kim
Russell King - ARM Linux wrote: On Thu, Mar 07, 2013 at 09:50:17AM +0900, Kukjin Kim wrote: Paul Bolle wrote: On Thu, 2013-03-07 at 09:02 +0900, Kukjin Kim wrote: BTW, so the machine type can be removed at arch/arm/tools/mach-types as well. Well, that file has a big

RE: [PATCH v2 0/3] pinctrl: exynos: add support for Samsung's Exynos5250

2013-03-06 Thread Kukjin Kim
Thomas Abraham wrote: On 7 March 2013 05:41, Kukjin Kim kgene@samsung.com wrote: Thomas Abraham wrote: Changes since v1: - Change the compatible string from samsung,pinctrl-exynos5250 to samsung,exynos5250-pinctrl. - Rebased to v3.9-rc1 Thomas, this stuff is already

RE: [PATCH v2 1/3] pinctrl: exynos: add exynos5250 SoC specific data

2013-03-07 Thread Kukjin Kim
Linus Walleij wrote: On Wed, Mar 6, 2013 at 12:18 PM, Thomas Abraham thomas.abra...@linaro.org wrote: Add Samsung Exynos5250 SoC specific data to enable pinctrl support for all platforms based on Exynos5250. Signed-off-by: Thomas Abraham thomas.abra...@linaro.org Reviewed-by:

RE: [PATCH v4 00/12] iommu/exynos: Fixes and Enhancements of System MMU driver with DT

2012-11-30 Thread Kukjin Kim
. Hi, Kukjin Kim. I found that control bit fields of clock gating of System MMU of MFC L/R is inversed. That is reported by Prathyush Kalashwaram. I will post v5 patchset that solves this. I did not posted v5 patchset. Instead, I posted just the fix for the 03/12

RE: [PATCH] ARM: EXYNOS: Avoid early use of of_machine_is_compatible()

2012-11-30 Thread Kukjin Kim
). Thanks for your fix. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More

RE: [PATCH] pinctrl: exynos5440/samsung: Staticize pcfgs

2012-12-03 Thread Kukjin Kim
make: *** [drivers] Error 2 Signed-off-by: Axel Lin axel@ingics.com Acked-by: Thomas Abraham thomas.abra...@linaro.org Dear Mr. Kim, Could you please consider this patch in your next pull request for fixes. Sure, I will. Thanks. Best regards, Kgene. -- Kukjin Kim kgene

RE: [PATCH v5 1/4] ARM: Exynos5250: Enabling ehci-s5p driver

2013-02-08 Thread Kukjin Kim
Vivek Gautam wrote: Adding EHCI device tree node for Exynos5250 along with the device base adress and gpio line for vbus. Signed-off-by: Vivek Gautam gautam.vi...@samsung.com Acked-by: Jingoo Han jg1@samsung.com Acked-by: Grant Likely grant.lik...@secretlab.ca --- Changes from v4:

RE: [PATCH v6 05/12] iommu/exynos: support for device tree

2013-02-12 Thread Kukjin Kim
KyongHo Cho wrote: On Fri, Feb 1, 2013 at 10:51 PM, Joerg Roedel j...@8bytes.org wrote: Cho, On Wed, Jan 02, 2013 at 02:53:49PM +0900, KyongHo Cho wrote: On Tuesday, January 1, 2013, Sylwester Nawrocki sylvester.nawro...@gmail.com Cc: devicetree-disc...@lists.ozlabs.org Since

RE: [PATCH] ARM: dts: Fix MSHC property and add RTC node

2013-02-04 Thread Kukjin Kim
Dongjin Kim wrote: This fixes the property of dw-mshc-sdr-timing and dw-mshc-ddr-timing as per its current binding, it only has two cells. Yes, it should be fixed. And also RTC node is added new. Above two changes should be separated. Signed-off-by: Dongjin Kim tobet...@gmail.com ---

RE: [PATCH] ARM: dts: Fix the timing property of MSHC controller

2013-02-04 Thread Kukjin Kim
Dongjin Kim wrote: This fixes the property of dw-mshc-sdr-timing and dw-mshc-ddr-timing as per its current binding, it only has two cells. Signed-off-by: Dongjin Kim tobet...@gmail.com --- arch/arm/boot/dts/exynos4412-odroidx.dts |4 ++-- 1 file changed, 2 insertions(+), 2

RE: [PATCH] ARM: dts: Adding RTC device node

2013-02-04 Thread Kukjin Kim
Dongjin Kim wrote: This patch enables RTC device node defined in arch/arm/boot/dts/exynos4.dtsi. Signed-off-by: Dongjin Kim tobet...@gmail.com --- arch/arm/boot/dts/exynos4412-odroidx.dts |4 1 file changed, 4 insertions(+) diff --git

RE: Failure due to missing (Exynos related) pinctrl patch

2013-01-29 Thread Kukjin Kim
Sachin Kamat wrote: This patch is required along with the patch gpio: samsung: fix pinctrl condition for exynos and exynos5440 (mainline commit Id: e4a5da51) which has already made it into mainline. Without the missing patch we get the following boot up warnings and subsequent failures

RE: [PATCH v2 1/2] ARM: Exynos5250: Enabling samsung-usbphy driver

2013-01-29 Thread Kukjin Kim
Vivek Gautam wrote: Adding usbphy node for Exynos5250 along with the necessary device data to be parsed. Signed-off-by: Vivek Gautam gautam.vi...@samsung.com --- arch/arm/boot/dts/exynos5250.dtsi | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git

RE: [PATCH v2 2/2] ARM: Exynos5250: Enabling samsung-usb3-phy driver

2013-01-29 Thread Kukjin Kim
Vivek Gautam wrote: Adding usb3.0 phy node for Exynos5250 along with the necessary device data to be parsed. Signed-off-by: Vivek Gautam gautam.vi...@samsung.com --- arch/arm/boot/dts/exynos5250.dtsi | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git

RE: [PATCH v4 1/2] usb: phy: samsung: Common out the generic stuff

2013-01-29 Thread Kukjin Kim
Vivek Gautam wrote: Moving register and structure definitions to header file, and keeping the generic functions to be used across multiple PHYs in common file samsung-usbphy.c. Also renaming the usb 2.0 phy driver to samsung-usb2.c Just in my opinion, Samsung-usb2phy is more clear?...In

RE: [PATCH v4 2/2] usb: phy: samsung: Add PHY support for USB 3.0 controller

2013-01-29 Thread Kukjin Kim
Vivek Gautam wrote: Adding PHY driver support for USB 3.0 controller for Samsung's SoCs. Signed-off-by: Vivek Gautam gautam.vi...@samsung.com --- Changes from v3: - Making SAMSUNG_USB3PHY dependent on SAMSUNG_USBPHY. - Adding USB_DWC3 to dependencies of SAMSUNG_USB2PHY since

RE: [PATCH v4 3/4] ARM: Exynos5250: Add clock information for dwc3-exynos

2013-01-29 Thread Kukjin Kim
Vivek Gautam wrote: Hi Tomasz, On Wed, Jan 16, 2013 at 8:35 PM, Vivek Gautam gautamvivek1...@gmail.com wrote: Hi Tomasz, On Wed, Jan 16, 2013 at 1:19 PM, Tomasz Figa tomasz.f...@gmail.com wrote: Hi Vivek, Don't you need also some clkdev lookup entry to make the clock

RE: [PATCH v4 2/4] ARM: Exynos5250: Enabling ohci-exynos driver

2013-01-31 Thread Kukjin Kim
Tomasz Figa wrote: Hi Vivek, [...] + usb@1212 { + compatible = samsung,exynos4210-ohci; + reg = 0x1212 0x100; + interrupts = 0 71 0; For Samsung platforms we decided per board enabling of nodes and so this node should also contain:

RE: [PATCH 3/5] ARM: samsung: fix assembly syntax for new gas

2013-01-25 Thread Kukjin Kim
expected -- `ldr r2,[ r3,#(0x10)]' Signed-off-by: Arnd Bergmann a...@arndb.de Cc: Ben Dooks ben-li...@fluff.org Cc: Kukjin Kim kgene@samsung.com Acked-by: Kukjin Kim kgene@samsung.com [...] Thanks. - Kukjin -- To unsubscribe from this list: send the line unsubscribe linux-kernel

RE: [PATCH 12/19] pinctrl: exynos: don't mark probing functions as __init

2013-01-25 Thread Kukjin Kim
(). This is often because exynos5440_pinctrl_probe lacks a __init annotation or the annotation of exynos5440_gpiolib_register is wrong. Signed-off-by: Arnd Bergmann a...@arndb.de Cc: Linus Walleij linus.wall...@linaro.org Cc: Tomasz Figa t.f...@samsung.com Cc: Kukjin Kim kgene@samsung.com

RE: [PATCH v2 0/2] usb: exynos: Fix compatible strings used for device

2013-01-25 Thread Kukjin Kim
, please go ahead, if you want my ack, feel free to add: Acked-by: Kukjin Kim kgene@samsung.com Thanks. - Kukjin -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

RE: Failure due to missing (Exynos related) pinctrl patch

2013-01-28 Thread Kukjin Kim
Sachin Kamat wrote: Hi Linus, Kukjin, Patch titled pinctrl: exynos: change PINCTRL_EXYNOS option (linux-next commit Id: 7452b64d) which is present in linux-next is missing in the mainline kernel. This patch is required along with the patch gpio: samsung: fix pinctrl condition for exynos

RE: [PATCH 1/2] thermal: sysfs: Add a new sysfs node emul_temp

2013-01-21 Thread Kukjin Kim
patches: Acked-by: Kukjin Kim kgene@samsung.com Thanks. - Kukjin -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http

RE: [PATCH V2 0/3] thermal: Add support for interrupt based notification to thermal layer

2013-01-21 Thread Kukjin Kim
my ack as a maintainer of EXYNOS SoCs, feel free. Acked-by: Kukjin Kim kgene@samsung.com Thanks. - Kukjin -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

RE: [PATCH 0/2] ARM: Exynos5250: Enabling samsung usb phy

2013-01-21 Thread Kukjin Kim
Felipe Balbi wrote: On Fri, Jan 18, 2013 at 03:10:13PM +0200, Felipe Balbi wrote: Hi, On Tue, Dec 18, 2012 at 09:09:40PM +0530, Vivek Gautam wrote: This patch-set enables the samsung-usbphy driver on exynos5250, which enables the support for USB2 type and USB3 type phys. The

RE: [PATCH v6 0/4] Adding usb2.0 host-phy support for exynos5250

2013-01-21 Thread Kukjin Kim
this series anyway, feel free to add my ack: Acked-by: Kukjin Kim kgene@samsung.com Thanks. - Kukjin -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

RE: linux-next: manual merge of the samsung tree with the arm-soc tree

2013-01-16 Thread Kukjin Kim
Stephen Rothwell wrote: Hi Kukjin, Hi, On Fri, 11 Jan 2013 15:32:06 +1100 Stephen Rothwell s...@canb.auug.org.au wrote: Today's linux-next merge of the samsung tree got conflicts in many files with the arm-soc tree. I just dropped the samsung tree for today. Please have a look

RE: linux-next: manual merge of the samsung tree with the arm-soc tree

2013-01-16 Thread Kukjin Kim
Stephen Rothwell wrote: Hi Kukjin, Hi, On Fri, 11 Jan 2013 15:32:06 +1100 Stephen Rothwell s...@canb.auug.org.au wrote: Today's linux-next merge of the samsung tree got conflicts in many files with the arm-soc tree. I just dropped the samsung tree for today. Please have a look

RE: linux-next: manual merge of the samsung tree with the arm-soc tree

2013-01-16 Thread Kukjin Kim
Kukjin Kim wrote: Stephen Rothwell wrote: Hi Kukjin, Hi, On Fri, 11 Jan 2013 15:32:06 +1100 Stephen Rothwell s...@canb.auug.org.au wrote: Today's linux-next merge of the samsung tree got conflicts in many files with the arm-soc tree. I just dropped the samsung tree

RE: linux-next: manual merge of the samsung tree with the arm-soc tree

2013-01-16 Thread Kukjin Kim
Kukjin Kim wrote: [...] Hmm, updating timer patches in Samsung tree cause the merge conflicts with arm-soc, so for now I dropped them in my tree just now. And note that regarding topic branch which are including it will be re-worked soon :-) Now to merge Samsung tree for linux-next should

RE: [PATCH v7] usb: phy: samsung: Add support to set pmu isolation

2013-01-17 Thread Kukjin Kim
This looks good to me, Acked-by: Kukjin Kim kgene@samsung.com Vivek, could you please re-send following in one series? - [PATCH v9 1/2] usb: phy: samsung: Introducing usb phy driver for hsotg - [PATCH v8 2/2] usb: s3c-hsotg: Adding phy driver support As I know, this should be applied on top

RE: [PATCH] arm: mach-s3c24xx/common.c: fix uninitialized variable warning

2013-01-17 Thread Kukjin Kim
Cong Ding wrote: the use of variable tmp is uninitialized, so we fix it. Signed-off-by: Cong Ding ding...@gmail.com --- arch/arm/mach-s3c24xx/common.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-s3c24xx/common.c b/arch/arm/mach-

RE: [linux-pm] [PATCH] cpufreq: exynos: Show list of available frequencies

2013-01-17 Thread Kukjin Kim
amit kachhap wrote: On Tue, Jan 8, 2013 at 2:50 AM, Inderpal Singh inderpal.si...@linaro.org wrote: Add freq_attr attribute to show list of available frequencies. Signed-off-by: Donggeun Kim dg77@samsung.com Signed-off-by: MyungJoo Ham myungjoo@samsung.com Signed-off-by:

RE: [PATCH v3 1/4] pinctrl: add samsung pinctrl and gpiolib driver

2012-09-06 Thread Kukjin Kim
subsystem and gpiolib interface registers gpio chips with the gpiolib subsystem. The information about the pins, pin groups, pin functions and gpio chips, which are SoC specific, are parsed from device tree node. Cc: Linus Walleij linus.wall...@linaro.org Cc: Kukjin Kim kgene@samsung.com

RE: [PATCH 0/2] ARM: EXYNOS: Set the capability of pdm0 and pdm1 as DMA_PRIVATE

2012-09-06 Thread Kukjin Kim
are rebased on top of v3.6-rc3. Kukjin, if you ack them I can take thru my tree, other way round is fine with me too. Hi Vinod, Looks good to me, please pick them into your tree with my ack. Acked-by: Kukjin Kim kgene@samsung.com If any problems, please kindly let me know. Thanks. Best regards

RE: [PATCH] DMA: PL330: return ENOMEM instead of 0 from pl330_alloc_chan_resources

2012-09-17 Thread Kukjin Kim
Inderpal Singh wrote: Since 0 is not considered as error at dmaengine level, return ENOMEM from pl330_alloc_chan_resources in case of failure. Signed-off-by: Inderpal Singh inderpal.si...@linaro.org Acked-by: Kukjin Kim kgene@samsung.com Thanks. Best regards, Kgene. -- Kukjin Kim

  1   2   3   4   5   6   7   8   9   10   >