Re: [PATCH 1/3] gpio / ACPI: add ACPI support

2012-11-05 Thread Mathias Nyman
On 11/05/2012 01:53 PM, Linus Walleij wrote: On Sat, Nov 3, 2012 at 8:46 AM, Mika Westerberg mika.westerb...@linux.intel.com wrote: +/** + * acpi_get_gpio() - Translate ACPI GPIO pin to GPIO number usable with GPIO API + * @path: ACPI GPIO controller full path name, (e.g. \\_SB.GPO1) +

[RFC PATCH] gpiolib: add gpio get direction support

2012-10-22 Thread Mathias Nyman
, then gpiolib will use it for showing correct gpio direction in sysfs and debug. If not set then it will work the old way; e.g. guessing everything is input until direction is set. Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com --- drivers/gpio/gpiolib.c | 64

Re: [RFC PATCH] gpiolib: add gpio get direction support

2012-10-23 Thread Mathias Nyman
On 10/23/2012 01:23 AM, Linus Walleij wrote: On Mon, Oct 22, 2012 at 3:44 PM, Mathias Nyman mathias.ny...@linux.intel.com wrote: If the .get_direction callback is set, then gpiolib will use it for showing correct gpio direction in sysfs and debug. If not set then it will work the old way; e.g

[RFC PATCH v2] gpiolib: add gpio get direction callback support

2012-10-24 Thread Mathias Nyman
. Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com --- drivers/gpio/gpiolib.c | 38 +- include/asm-generic/gpio.h |5 - 2 files changed, 41 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index

[PATCH] gpiolib: Don't return -EPROBE_DEFER to sysfs, or for invalid gpios

2012-10-25 Thread Mathias Nyman
gpios requested with invalid numbers, or gpios requested from userspace via sysfs should not try to be deferred on failure. Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com --- drivers/gpio/gpiolib.c | 10 +++--- 1 files changed, 7 insertions(+), 3 deletions(-) diff --git

Re: [PATCH 1/3] gpio / ACPI: add ACPI support

2012-11-09 Thread Mathias Nyman
On 11/08/2012 09:38 PM, Mika Westerberg wrote: ... +#includelinux/errno.h +#includelinux/gpio.h +#includelinux/module.h +#includelinux/acpi_gpio.h +#includelinux/acpi.h + +static int acpi_gpiochip_find(struct gpio_chip *gc, void *data) +{ + acpi_handle handle = data; + acpi_handle

Re: [PATCH 1/3] gpio / ACPI: add ACPI support

2012-11-09 Thread Mathias Nyman
On 11/09/2012 04:18 PM, Grant Likely wrote: On Fri, Nov 9, 2012 at 2:11 PM, Mathias Nyman mathias.ny...@linux.intel.com wrote: On 11/08/2012 09:38 PM, Mika Westerberg wrote: ... +#includelinux/errno.h +#includelinux/gpio.h +#includelinux/module.h +#includelinux/acpi_gpio.h +#includelinux

Re: [PATCH] gpio / ACPI: Handle ACPI events in accordance with the spec

2013-04-10 Thread Mathias Nyman
On 04/10/2013 10:53 AM, Mika Westerberg wrote: On Tue, Apr 09, 2013 at 03:57:25PM +0200, Rafael J. Wysocki wrote: +void acpi_gpiochip_free_interrupts(struct gpio_chip *chip) +{ + acpi_handle handle; + acpi_status status; + struct list_head *evt_pins; + struct

[PATCH] gpio-lynxpoint: Add X86 dependency and io-port handling header.

2013-03-08 Thread Mathias Nyman
Lynxpoint gpio driver uses X86 specific io-ports to control gpios Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com --- drivers/gpio/Kconfig |2 +- drivers/gpio/gpio-lynxpoint.c |1 + 2 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/gpio/Kconfig b

[RFC PATCH] gpiolib-acpi: Add ACPI5 event model support to gpio.

2013-01-25 Thread Mathias Nyman
have acpi event methods and assigns interrupt handlers that calls the acpi event methods for those pins. Partially based on work by Rui Zhang rui.zh...@intel.com Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com --- drivers/gpio/gpiolib-acpi.c | 80

Re: [RFC PATCH] gpiolib-acpi: Add ACPI5 event model support to gpio.

2013-01-25 Thread Mathias Nyman
On 01/25/2013 02:54 PM, Linus Walleij wrote: On Fri, Jan 25, 2013 at 12:48 PM, Mathias Nyman mathias.ny...@linux.intel.com wrote: Add ability to handle ACPI events signalled by GPIO interrupts. ACPI5 platforms can use GPIO signaled ACPI events. These GPIO interrupts are handled by ACPI event

[RFC PATCH v2] gpiolib-acpi: Add ACPI5 event model support to gpio.

2013-01-28 Thread Mathias Nyman
have acpi event methods and assigns interrupt handlers that calls the acpi event methods for those pins. Partially based on work by Rui Zhang rui.zh...@intel.com Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com --- drivers/gpio/gpiolib-acpi.c | 82

Re: [PATCH] gpio: msic: Fix calculating register address in msic_gpio_to_oreg()

2012-07-24 Thread Mathias Nyman
INTEL_MSIC_GPIO1HV0CTLO + offset + 20; + return INTEL_MSIC_GPIO1HV0CTLO - offset + 20; } static int msic_gpio_direction_input(struct gpio_chip *chip, unsigned offset) Nice, good catch. The last 4 of the 24 gpios will work properly as outputs with this fix. Acked-by: Mathias Nyman mathias.ny

[PATCH 0/1] gpio: add Lynxpoint chipset gpio driver

2012-12-07 Thread Mathias Nyman
This gpio controller driver for the Intel Lynxpoint LP PCH chipset is designed to work with the new ACPI 5 enumeration model and ACPI 5 GpioIo/GpioInt resource translation recently added to linux-acpi. Mathias Nyman (1): gpio: add Lynxpoint chipset gpio driver. drivers/gpio/Kconfig

[PATCH 1/1] gpio: add Lynxpoint chipset gpio driver.

2012-12-07 Thread Mathias Nyman
Add gpio support for Intel Lynxpoint chipset. Lynxpoint supports 94 gpio pins which can generate interrupts. Driver will fail requests for pins that are marked as owned by ACPI, or set in an alternate mode (non-gpio). Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com --- drivers/gpio

Re: [PATCH 1/1] gpio: add Lynxpoint chipset gpio driver.

2012-12-10 Thread Mathias Nyman
On 12/10/2012 11:48 AM, Linus Walleij wrote: On Fri, Dec 7, 2012 at 3:01 PM, Mathias Nyman mathias.ny...@linux.intel.com wrote: Add gpio support for Intel Lynxpoint chipset. Lynxpoint supports 94 gpio pins which can generate interrupts. Driver will fail requests for pins that are marked

Re: [PATCH 1/1] gpio: add Lynxpoint chipset gpio driver.

2012-12-11 Thread Mathias Nyman
On 12/11/2012 01:07 AM, Grant Likely wrote: On Fri, 7 Dec 2012 16:01:39 +0200, Mathias Nymanmathias.ny...@linux.intel.com wrote: Add gpio support for Intel Lynxpoint chipset. Lynxpoint supports 94 gpio pins which can generate interrupts. Driver will fail requests for pins that are marked as

[PATCH v2 0/1] gpio: add Lynxpoint chipset gpio driver

2012-12-12 Thread Mathias Nyman
gpio_reg() to lp_gpio_reg() - renamed gpio variable to offset or hwirq where needed. - added comments about register layout - removed __devexit/__devinit macros - removed #ifdefs and added ACPI dependancy instead - added simple runtime pm support - added lp_gpio_free() Mathias Nyman (1): gpio: add

[PATCH v2 1/1] gpio: add Lynxpoint chipset gpio driver.

2012-12-12 Thread Mathias Nyman
Add gpio support for Intel Lynxpoint chipset. Lynxpoint supports 94 gpio pins which can generate interrupts. Driver will fail requests for pins that are marked as owned by ACPI, or set in an alternate mode (non-gpio). Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com --- drivers/gpio

[PATCH v3 1/1] pinctrl: add Intel BayTrail GPIO/pinctrl support

2013-06-18 Thread Mathias Nyman
muxing and expect firmare to set pin muxing and pullup/down properties properly. Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com --- drivers/pinctrl/Kconfig| 12 + drivers/pinctrl/Makefile |1 + drivers/pinctrl/pinctrl-baytrail.c | 543

[PATCH v3 0/1] Pinctrl/gpio driver for Intel Baytrail platforms

2013-06-18 Thread Mathias Nyman
instead of custom gpio_banks Changes since v1: - generic cleanups suggested by Andy S. - removed text about pin muxing - added missing 44:th pin to SUS controller - added level triggering option - prevent forever loop in case pin is stuck in interrupt triggered status, Mathias Nyman (1

Re: [PATCH v3 1/1] pinctrl: add Intel BayTrail GPIO/pinctrl support

2013-06-19 Thread Mathias Nyman
On 06/18/2013 06:17 PM, Linus Walleij wrote: On Tue, Jun 18, 2013 at 1:33 PM, Mathias Nyman mathias.ny...@linux.intel.com wrote: Add support for gpio on Intel BayTrail platforms. BayTrail supports 3 banks of gpios called SCORE, NCORE ans SUS with 102, 28 and 44 gpio pins. Supports gpio

Re: [PATCH] gpio/lynxpoint: check if the interrupt is enabled in IRQ handler

2013-10-02 Thread Mathias Nyman
the interrupt enable bit for the pin as well. Signed-off-by: Mika Westerberg mika.westerb...@linux.intel.com Acked-by: Mathias Nyman mathias.ny...@linux.intel.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More

[PATCH] x86: add pin control support to Intel low power subsystem

2013-09-13 Thread Mathias Nyman
are possible to add later. Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com --- arch/x86/Kconfig |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig index 30c40f0..91f72b5 100644 --- a/arch/x86/Kconfig +++ b/arch/x86/Kconfig

Re: [PATCH v2] pinctrl: baytrail: lock IRQs when starting them

2013-12-03 Thread Mathias Nyman
: Mathias Nyman mathias.ny...@linux.intel.com Signed-off-by: Linus Walleij linus.wall...@linaro.org --- ChangeLog v1-v2: - Actually make the change compile, doh. --- drivers/pinctrl/pinctrl-baytrail.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/drivers/pinctrl

[RFC PATCH v2] xhci: Prevent runtime pm from autosuspending during initialization

2014-02-24 Thread Mathias Nyman
the runtime suspend by increasing the usage count in the beginning of xhci_pci_probe, and decrease it once the usb-3 bus is ready. xhci-platform driver is not using usb_hcd_pci_probe to set up busses and should not need to have it's usage count increased during probe. Signed-off-by: Mathias Nyman

[RFCv3 0/4] xhci: re-work command queue management

2014-02-26 Thread Mathias Nyman
as ABORTED and start the ring abortion process. Functions waiting for an aborted command to finish are called after the command abortion is completed. Mathias Nyman (4): xhci: Use command structures when queuing commands on the command ring xhci: Add a global command queue xhci: Use

[RFCv3 4/4] xhci: rework command timeout and cancellation,

2014-02-26 Thread Mathias Nyman
either until the command completes normally, or until the whole command abortion is done. Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com --- drivers/usb/host/xhci-hub.c | 11 +- drivers/usb/host/xhci-mem.c | 15 +- drivers/usb/host/xhci-ring.c | 335

[RFCv3 1/4] xhci: Use command structures when queuing commands on the command ring

2014-02-26 Thread Mathias Nyman
.(Just so that we won't leak memory in the middle of the patch set) Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com --- drivers/usb/host/xhci-hub.c | 21 +++-- drivers/usb/host/xhci-ring.c | 105 --- drivers/usb/host/xhci.c | 194

[RFCv3 2/4] xhci: Add a global command queue

2014-02-26 Thread Mathias Nyman
are freed in the command completion event handler. Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com --- drivers/usb/host/xhci-mem.c | 8 drivers/usb/host/xhci-ring.c | 21 + drivers/usb/host/xhci.c | 2 -- drivers/usb/host/xhci.h | 1 + 4 files

[RFCv3 3/4] xhci: Use completion and status in global command queue

2014-02-26 Thread Mathias Nyman
Remove the per-device command list and handle_cmd_in_cmd_wait_list() and use the completion and status variables found in the command structure in the global command list. Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com --- drivers/usb/host/xhci-hub.c | 11 --- drivers/usb/host

[PATCH 0/1] xhci: fixes for 3.14

2014-03-03 Thread Mathias Nyman
Mathias Nyman (1): xhci: Prevent runtime pm from autosuspending during initialization drivers/usb/host/xhci-pci.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) -- 1.8.1.2 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message

[PATCH v3 1/1] xhci: Prevent runtime pm from autosuspending during initialization

2014-03-03 Thread Mathias Nyman
the runtime suspend by increasing the usage count in the beginning of xhci_pci_probe, and decrease it once the usb-3 bus is ready. xhci-platform driver is not using usb_hcd_pci_probe to set up busses and should not need to have it's usage count increased during probe. Signed-off-by: Mathias Nyman

Re: [PATCH v3 1/1] xhci: Prevent runtime pm from autosuspending during initialization

2014-03-04 Thread Mathias Nyman
On 03/03/2014 08:37 PM, Greg KH wrote: On Mon, Mar 03, 2014 at 07:30:17PM +0200, Mathias Nyman wrote: xHCI driver has its own pci probe function that will call usb_hcd_pci_probe to register its usb-2 bus, and then continue to manually register the usb-3 bus. usb_hcd_pci_probe does

[PATCH 2/2] Revert USBNET: ax88179_178a: enable tso if usb host supports sg dma

2014-03-07 Thread Mathias Nyman
for xHCI 1.0 hosts, but for now, revert this patch until scatter gather can be properly supported. Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com Cc: stable sta...@vger.kernel.org --- drivers/net/usb/ax88179_178a.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/net

[PATCH 0/2] xhci, usbnet: fixes for 3.14

2014-03-07 Thread Mathias Nyman
://marc.info/?l=linux-usbm=139361293103188w=2 -Mathias Mathias Nyman (2): Revert xhci 1.0: Limit arbitrarily-aligned scatter gather. Revert USBNET: ax88179_178a: enable tso if usb host supports sg dma drivers/net/usb/ax88179_178a.c | 8 drivers/usb/host/xhci.c| 14

[PATCH 1/2] Revert xhci 1.0: Limit arbitrarily-aligned scatter gather.

2014-03-07 Thread Mathias Nyman
fragment rules required, but for now this patch needs to be reverted to get USB 3.0 mass storage devices working at the level they used to. Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com Cc: stable sta...@vger.kernel.org --- drivers/usb/host/xhci.c | 14 +++--- 1 file changed, 3

Re: [PATCH] pinctrl-baytrail: add function mux checking in gpio pin request

2014-03-11 Thread Mathias Nyman
. This confirms my suspicion that you will not be able to hide the pin control interface side of this hardware forever. ;-) Hate to admit it but so it seems :) Mika/Mathias: any comments? Patch looks fine Acked-by: Mathias Nyman mathias.ny...@linux.intel.com -Mathias -- To unsubscribe from

[RFC 00/10] xhci: re-work command queue management

2014-01-13 Thread Mathias Nyman
the command abortion is completed. Mathias Nyman (10): xhci: Use command structures when calling xhci_configure_endpoint xhci: use a command structure internally in xhci_address_device() xhci: use command structures for xhci_queue_slot_control() xhci: use command structures

[RFC 04/10] xhci: use command structures for xhci_queue_stop_endpoint()

2014-01-13 Thread Mathias Nyman
Prepare for the global command ring by using command structures internally in functions calling xhci_queue_stop_endpoint() Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com --- drivers/usb/host/xhci-hub.c | 14 -- drivers/usb/host/xhci.c | 3 +++ 2 files changed, 15

[RFC 07/10] xhci: Use command structured when queuing commands

2014-01-13 Thread Mathias Nyman
handled event in a later patch. Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com --- drivers/usb/host/xhci-hub.c | 8 ++-- drivers/usb/host/xhci-ring.c | 94 ++-- drivers/usb/host/xhci.c | 47 +++--- drivers/usb/host/xhci.h

[RFC 09/10] xhci: Use completion and status in global command queue

2014-01-13 Thread Mathias Nyman
Remove the per-device command list and handle_cmd_in_cmd_wait_list() and use the completion and status variables found in the command structure in the global command list. Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com --- drivers/usb/host/xhci-hub.c | 11 -- drivers/usb/host

[RFC 10/10] xhci: rework command timeout and cancellation,

2014-01-13 Thread Mathias Nyman
either until the command completes normally, or until the whole command abortion is done. Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com --- drivers/usb/host/xhci-hub.c | 11 +- drivers/usb/host/xhci-mem.c | 15 +- drivers/usb/host/xhci-ring.c | 336

[RFC 02/10] xhci: use a command structure internally in xhci_address_device()

2014-01-13 Thread Mathias Nyman
Preparing for the global command queue by using command strucure in xhci_address_device Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com --- drivers/usb/host/xhci.c | 22 +- 1 file changed, 17 insertions(+), 5 deletions(-) diff --git a/drivers/usb/host/xhci.c b

[RFC 08/10] xhci: Add a global command queue

2014-01-13 Thread Mathias Nyman
Create a list to store command structures, add a strucure to it every time a command is submitted, and remove it from the list once we get a command completion event matching the command. Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com --- drivers/usb/host/xhci-mem.c | 8

[RFC 05/10] xhci: use command structure for xhci_queue_new_dequeue_state()

2014-01-13 Thread Mathias Nyman
Prepare for the global command ring by using command structures internally in functions calling xhci_queue_new_dequeue_state() Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com --- drivers/usb/host/xhci-ring.c | 3 +++ drivers/usb/host/xhci.c | 6 ++ 2 files changed, 9

[RFC 03/10] xhci: use command structures for xhci_queue_slot_control()

2014-01-13 Thread Mathias Nyman
Preparing for the global command queue by changing functions calling xhci_queue_slot_control() to internally use command structures Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com --- drivers/usb/host/xhci.c | 34 +- 1 file changed, 29 insertions(+), 5

[RFC 06/10] xhci: use command structures for xhci_queue_reset_ep()

2014-01-13 Thread Mathias Nyman
Prepare for the global command ring by using command structures internally in functions calling xhci_queue_reset_ep() Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com --- drivers/usb/host/xhci-ring.c | 5 + drivers/usb/host/xhci.c | 6 ++ 2 files changed, 11 insertions

[RFC 01/10] xhci: Use command structures when calling xhci_configure_endpoint

2014-01-13 Thread Mathias Nyman
) Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com --- drivers/usb/host/xhci-ring.c | 10 ++--- drivers/usb/host/xhci.c | 95 +++- 2 files changed, 54 insertions(+), 51 deletions(-) diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci

Re: [RFC 00/10] xhci: re-work command queue management

2014-01-14 Thread Mathias Nyman
IMHO the xhci driver is already far too complicated, and this probably just makes it even worse. This is an attempt to make it cleaner and less complicated. In the end this series removes far more more code than it adds: 5 files changed, 373 insertions(+), 530 deletions(-) The timers are

Re: [RFC/PATCH] usb/xhci: avoid kernel panic on xhci_suspend()

2014-02-21 Thread Mathias Nyman
On 01/08/2014 09:53 PM, David Cohen wrote: On Wed, Jan 08, 2014 at 10:48:06AM -0500, Alan Stern wrote: On Tue, 7 Jan 2014, Greg KH wrote: On Tue, Jan 07, 2014 at 05:44:26PM -0800, David Cohen wrote: From: jianqian jianqiang.t...@intel.com There is a possible kernel panic faced on

[RFC v4 0/4] xhci: re-work command queue management

2014-03-21 Thread Mathias Nyman
process. Functions waiting for an aborted command to finish are called after the command abortion is completed. Mathias Nyman (4): xhci: Use command structures when queuing commands on the command ring xhci: Add a global command queue xhci: Use completion and status in global command queue

[RFC v4 3/4] xhci: Use completion and status in global command queue

2014-03-21 Thread Mathias Nyman
Remove the per-device command list and handle_cmd_in_cmd_wait_list() and use the completion and status variables found in the command structure in the global command list. Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com --- drivers/usb/host/xhci-hub.c | 11 -- drivers/usb/host

[RFC v4 4/4] xhci: rework command timeout and cancellation,

2014-03-21 Thread Mathias Nyman
either until the command completes normally, or until the whole command abortion is done. Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com --- drivers/usb/host/xhci-hub.c | 11 +- drivers/usb/host/xhci-mem.c | 15 +- drivers/usb/host/xhci-ring.c | 337

[RFC v4 2/4] xhci: Add a global command queue

2014-03-21 Thread Mathias Nyman
are freed in the command completion event handler. Also add a check that prevents queuing commands if host is dying Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com --- drivers/usb/host/xhci-mem.c | 2 ++ drivers/usb/host/xhci-ring.c | 34 ++ drivers

[RFC v4 1/4] xhci: Use command structures when queuing commands on the command ring

2014-03-21 Thread Mathias Nyman
.(Just so that we won't leak memory in the middle of the patch set) Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com --- drivers/usb/host/xhci-hub.c | 21 +++-- drivers/usb/host/xhci-ring.c | 106 --- drivers/usb/host/xhci.c | 194

Re: [RESEND] [PATCH] xhci: Switch Intel Lynx Point ports to EHCI on shutdown.

2014-03-21 Thread Mathias Nyman
On 03/21/2014 12:01 PM, Denis Turischev wrote: The same issue like with Panther Point chipsets. If the USB ports are switched to xHCI on shutdown, the xHCI host will send a spurious interrupt, which will wake the system. Some BIOS have work around for this, but not all. One example is Compulab's

Re: [RFC v4 4/4] xhci: rework command timeout and cancellation,

2014-03-21 Thread Mathias Nyman
On 03/21/2014 11:35 AM, Mathias Nyman wrote: +void xhci_handle_command_timeout(unsigned long data) +{ + struct xhci_hcd *xhci; + int ret; + unsigned long flags; + xhci = (struct xhci_hcd *) data; + /* mark this command to be cancelled

[PATCH v2 1/1] gpio: add Intel BayTrail gpio driver

2013-06-13 Thread Mathias Nyman
Add support for gpio on Intel BayTrail platforms. BayTrail supports 3 banks of gpios called SCORE, NCORE ans SUS with 102, 28 and 44 gpio pins. Supports gpio interrupts and ACPI gpio events. Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com --- drivers/gpio/Kconfig | 12

[PATCH v2 0/1] gpio driver for Intel Baytrail platforms

2013-06-13 Thread Mathias Nyman
by Andy S. - removed text about pin muxing - added missing 44:th pin to SUS controller - added level triggering option - prevent forever loop in case pin is stuck in interrupt triggered status, Mathias Nyman (1): gpio: add Intel BayTrail gpio driver drivers/gpio/Kconfig | 12

Re: [PATCH v2 0/1] gpio driver for Intel Baytrail platforms

2013-06-14 Thread Mathias Nyman
On 06/13/2013 06:45 PM, Linus Walleij wrote: On Thu, Jun 13, 2013 at 5:06 PM, Mathias Nyman mathias.ny...@linux.intel.com wrote: After looking at the pinctrl subsystem that Linus W. suggested I think pinctrl suits platforms that don't have firmware configuring the pins before the operating

Re: [PATCH 2/7] gpio: lynxpoint: remove unnecessary platform_set_drvdata()

2013-05-06 Thread Mathias Nyman
0; } Acked-by: Mathias Nyman mathias.ny...@linux.intel.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http

[PATCH] gpio: add Intel BayTrail gpio driver

2013-05-29 Thread Mathias Nyman
firmare to set pin muxing and pullup/down properties properly. Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com --- drivers/gpio/Kconfig | 12 + drivers/gpio/Makefile|1 + drivers/gpio/gpio-baytrail.c | 539 ++ 3 files changed, 552

Re: [PATCH] gpio: add Intel BayTrail gpio driver

2013-06-03 Thread Mathias Nyman
On 05/30/2013 10:26 PM, Linus Walleij wrote: On Wed, May 29, 2013 at 10:01 AM, Mathias Nyman mathias.ny...@linux.intel.com wrote: Add support for gpio on Intel BayTrail platforms. BayTrail supports 3 banks of gpios called SCORE, NCORE ans SUS with 102, 28 and 43 gpio pins. Supports gpio

[RFC PATCH v2 3/4] usb: xhci: add USB2 Link power management BESL support

2013-05-21 Thread Mathias Nyman
USB 3.0 link PM code does. The same xhci_change_max_exit_latency() function is used as with USB3 but code is pulled out from #ifdef CONFIG_PM as USB2.0 BESL LPM funcionality does not depend on CONFIG_PM. Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com --- drivers/usb/host/xhci-ext-caps.h

[RFC PATCH v2 4/4] usb: add usb2 Link PM variables to sysfs and usb_device

2013-05-21 Thread Mathias Nyman
Adds abitilty to tune L1 timeout (inactivity timer for usb2 link sleep) and BESL (best effort service latency)via sysfs. This also adds a new usb2_lpm_parameters structure with those variables to struct usb_device. Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com --- drivers/usb/core

[RFC PATCH v2 0/4] Add usb2 link powermanagement BESL support

2013-05-21 Thread Mathias Nyman
. Changes since v1: -Use kstrto* and unsigned values in sysfs functions as Alan Stern suggested Mathias Nyman (4): usb: xhci: check usb2 port capabilities before adding hw link PM support usb: xhci: define port register names and use them instead of magic numbers usb: xhci: add

[RFC PATCH v2 1/4] usb: xhci: check usb2 port capabilities before adding hw link PM support

2013-05-21 Thread Mathias Nyman
Hardware link powermanagement in usb2 is a per-port capability. Previously support for hw lpm was enabled for all ports if any usb2 port supported it. Now instead cache the capability values and check them for each port individually Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com

[RFC PATCH v2 2/4] usb: xhci: define port register names and use them instead of magic numbers

2013-05-21 Thread Mathias Nyman
Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com --- drivers/usb/host/xhci-hub.c | 16 +++- drivers/usb/host/xhci.c |4 ++-- drivers/usb/host/xhci.h |5 + 3 files changed, 14 insertions(+), 11 deletions(-) diff --git a/drivers/usb/host/xhci-hub.c b

Re: [RFC PATCH v2 4/4] usb: add usb2 Link PM variables to sysfs and usb_device

2013-05-22 Thread Mathias Nyman
On 05/21/2013 04:48 PM, Greg KH wrote: On Tue, May 21, 2013 at 01:43:37PM +0300, Mathias Nyman wrote: Adds abitilty to tune L1 timeout (inactivity timer for usb2 link sleep) and BESL (best effort service latency)via sysfs. If you add/remove/change sysfs files, you also need to do the same

[RFC PATCH v3 1/4] usb: xhci: check usb2 port capabilities before adding hw link PM support

2013-05-23 Thread Mathias Nyman
Hardware link powermanagement in usb2 is a per-port capability. Previously support for hw lpm was enabled for all ports if any usb2 port supported it. Now instead cache the capability values and check them for each port individually Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com

[RFC PATCH v3 4/4] usb: add usb2 Link PM variables to sysfs and usb_device

2013-05-23 Thread Mathias Nyman
Adds abitilty to tune L1 timeout (inactivity timer for usb2 link sleep) and BESL (best effort service latency)via sysfs. This also adds a new usb2_lpm_parameters structure with those variables to struct usb_device. Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com --- Documentation/ABI

[RFC PATCH v3 3/4] usb: xhci: add USB2 Link power management BESL support

2013-05-23 Thread Mathias Nyman
USB 3.0 link PM code does. The same xhci_change_max_exit_latency() function is used as with USB3 but code is pulled out from #ifdef CONFIG_PM as USB2.0 BESL LPM funcionality does not depend on CONFIG_PM. Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com --- drivers/usb/host/xhci-ext-caps.h

[RFC PATCH v3 0/4] Add usb2 link powermanagement BESL support

2013-05-23 Thread Mathias Nyman
names. Changes since v1: -Use kstrto* and unsigned values in sysfs functions as Alan Stern suggested Changes since v2: - Add Documentation/ABI/testing/sysfs-bus-usb entries for new sysfs attributes - store l1_timeout value in microseconds instead of xHCI specific values Mathias Nyman (4): usb

[RFC PATCH v3 2/4] usb: xhci: define port register names and use them instead of magic numbers

2013-05-23 Thread Mathias Nyman
Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com --- drivers/usb/host/xhci-hub.c | 16 +++- drivers/usb/host/xhci.c |4 ++-- drivers/usb/host/xhci.h |5 + 3 files changed, 14 insertions(+), 11 deletions(-) diff --git a/drivers/usb/host/xhci-hub.c b

Re: [PATCH 07/10] xhci: Use command structures when queuing commands on the command ring

2014-06-06 Thread Mathias Nyman
On 06/06/2014 01:16 AM, Dan Williams wrote: Hi Mathias, hit a small issue playing with -next: On Thu, May 8, 2014 at 9:26 AM, Mathias Nyman mathias.ny...@linux.intel.com wrote: To create a global command queue we require that each command put on the command ring is submitted with a command

Re: [regression 3.15-rc3] Resume from s4 broken by 1f81b6d22a5980955b01e08cf27fb745dc9b686f

2014-05-07 Thread Mathias Nyman
On 05/06/2014 02:41 PM, Ville Syrjälä wrote: On Mon, May 05, 2014 at 12:32:22PM -0700, Julius Werner wrote: Hmmm... very odd. I unfortunately don't have a machine that can easily do S4 at hand, but I did test this on an IVB with XHCI_RESET_ON_RESUME in S3 (essentially the same code path), and I

[PATCH 00/10] xhci: features for usb-next

2014-05-08 Thread Mathias Nyman
: xhci: Use IS_ENABLED() macro Lin Wang (1): xhci: fix wrong port number reported when setting USB2.0 hardware LPM. Mathias Nyman (4): xhci: Use command structures when queuing commands on the command ring xhci: Add a global command queue xhci: Use completion and status in global command

[PATCH 01/10] xhci: fix wrong port number reported when setting USB2.0 hardware LPM.

2014-05-08 Thread Mathias Nyman
From: Lin Wang bupt.wang...@gmail.com This patch fix wrong port number reported when trying to enable/disable USB2.0 hardware LPM. Signed-off-by: Lin Wang lin.x.w...@intel.com Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com --- drivers/usb/host/xhci.c | 2 +- 1 file changed, 1

[PATCH 03/10] usb: catch attempts to submit urbs with a vmalloc'd transfer buffer

2014-05-08 Thread Mathias Nyman
for dma_mapping_error() cases. Cc: Alan Stern st...@rowland.harvard.edu Cc: Sarah Sharp sarah.a.sh...@linux.intel.com Cc: Mathias Nyman mathias.ny...@linux.intel.com Signed-off-by: Dan Williams dan.j.willi...@intel.com Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com --- drivers/usb/core

[PATCH 08/10] xhci: Add a global command queue

2014-05-08 Thread Mathias Nyman
are freed in the command completion event handler. Also add a check that prevents queuing commands if host is dying Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com --- drivers/usb/host/xhci-mem.c | 2 ++ drivers/usb/host/xhci-ring.c | 34 ++ drivers

[PATCH 07/10] xhci: Use command structures when queuing commands on the command ring

2014-05-08 Thread Mathias Nyman
.(Just so that we won't leak memory in the middle of the patch set) Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com --- drivers/usb/host/xhci-hub.c | 21 +++-- drivers/usb/host/xhci-ring.c | 107 +--- drivers/usb/host/xhci.c | 194

[PATCH 09/10] xhci: Use completion and status in global command queue

2014-05-08 Thread Mathias Nyman
Remove the per-device command list and handle_cmd_in_cmd_wait_list() and use the completion and status variables found in the command structure in the global command list. Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com --- drivers/usb/host/xhci-hub.c | 11 -- drivers/usb/host

[PATCH 10/10] xhci: rework command timeout and cancellation,

2014-05-08 Thread Mathias Nyman
away. All these changes allows us to remove the entire cancel_cmd_list code. The functions waiting for a command to finish no longer have their own timeouts. They will wait either until the command completes normally, or until the whole command abortion is done. Signed-off-by: Mathias Nyman

[PATCH 04/10] usb: xhci: Use IS_ENABLED() macro

2014-05-08 Thread Mathias Nyman
From: Fabio Estevam fabio.este...@freescale.com Using the IS_ENABLED() macro can make the code shorter and easier to read. Signed-off-by: Fabio Estevam fabio.este...@freescale.com Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com --- drivers/usb/host/xhci.h | 3 +-- 1 file changed, 1

[PATCH 06/10] xhci: Report max device limit when Enable Slot command fails.

2014-05-08 Thread Mathias Nyman
mysteriously fails when too many devices are plugged in. Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com Reported-by: Amund Hov amund@silabs.com Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com --- drivers/usb/host/xhci.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers

[PATCH 02/10] xhci: 'noxhci_port_switch' kernel parameter

2014-05-08 Thread Mathias Nyman
...@linux.intel.com Cc: Mathias Nyman mathias.ny...@linux.intel.com Cc: Holger Hans Peter Freyther hol...@moiji-mobile.com Suggested-by: Alan Stern st...@rowland.harvard.edu Signed-off-by: Dan Williams dan.j.willi...@intel.com Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com --- Documentation

[PATCH 05/10] xhci: Use pci_enable_msix_exact() instead of pci_enable_msix()

2014-05-08 Thread Mathias Nyman
() or pci_enable_msix_exact() interfaces. Signed-off-by: Alexander Gordeev agord...@redhat.com Cc: Sarah Sharp sarah.a.sh...@linux.intel.com Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Cc: linux-...@vger.kernel.org Cc: linux-...@vger.kernel.org Signed-off-by: Mathias Nyman mathias.ny

Re: [regression 3.15-rc3] Resume from s4 broken by 1f81b6d22a5980955b01e08cf27fb745dc9b686f

2014-05-09 Thread Mathias Nyman
I can't see how this relates to Julius patch though, and I'm not sure yet why it only triggers when devices are connected to SS ports. Maybe just unlucky timing? I think the non-SS ports are connected to the EHCI controllers rather than the XHCI controllers. So that explains at least one

Re: [PATCH 02/10] xhci: 'noxhci_port_switch' kernel parameter

2014-05-20 Thread Mathias Nyman
On 05/20/2014 04:01 AM, Greg KH wrote: On Thu, May 08, 2014 at 07:25:55PM +0300, Mathias Nyman wrote: From: Dan Williams dan.j.willi...@intel.com Add a command line switch for disabling ehci port switchover. Useful for working around / debugging xhci incompatibilities where ehci operation

Re: [PATCH 00/10] xhci: features for usb-next

2014-05-15 Thread Mathias Nyman
On 05/08/2014 07:25 PM, Mathias Nyman wrote: Hi Greg These following xhci patches are for usb-next and hopefully for 3.16 This patcheseries includes a bigger change in xhci command queue code, (last four patches), a task that I've been working on for a longer time. Sarah gave green light

Re: [PATCH] pinctrl: baytrail: Add pull type, strength and open drain to debugfs output

2014-05-16 Thread Mathias Nyman
On 05/16/2014 12:18 PM, Mika Westerberg wrote: In case of resolving power management or similar issues it might be useful to have these properties included in the debugfs output. Signed-off-by: Mika Westerberg mika.westerb...@linux.intel.com Looks good to me Acked-by: Mathias Nyman

Re: [PATCH] gpio: Add support for Intel SoC PMIC (Crystal Cove)

2014-05-19 Thread Mathias Nyman
On 05/19/2014 03:27 AM, Zhu, Lejun wrote: On 5/17/2014 1:33 AM, Linus Walleij wrote: On Wed, May 14, 2014 at 5:44 PM, Zhu, Lejun lejun@linux.intel.com wrote: Devices based on Intel SoC products such as Baytrail have a Power Management IC. In the PMIC there are subsystems for voltage

Re: [PATCH 03/10] usb: catch attempts to submit urbs with a vmalloc'd transfer buffer

2014-05-12 Thread Mathias Nyman
On 05/08/2014 07:21 PM, Dan Williams wrote: On Thu, May 8, 2014 at 9:25 AM, Mathias Nyman mathias.ny...@linux.intel.com wrote: From: Dan Williams dan.j.willi...@intel.com Save someone else the debug cycles of figuring out why a driver's transfer request is failing or causing undefined system

Re: [PATCH v2 1/1] xhci: clear root port wake on bits if controller isn't wake-up capable

2014-06-17 Thread Mathias Nyman
On 06/13/2014 03:06 AM, Lu Baolu wrote: When xHCI PCI host is suspended, if do_wakeup is false in xhci_pci_suspend, xhci_bus_suspend needs to clear all root port wake on bits. Otherwise some Intel platforms may get a spurious wakeup, even if PCI PME# is disabled. This patch should be

Re: [RFCv2 01/10] xhci: Use command structures when calling xhci_configure_endpoint

2014-02-05 Thread Mathias Nyman
On 02/05/2014 04:21 AM, Dan Williams wrote: Hi Mathias, comments below: s/xhci_check_bandwith/xhci_check_bandwidth/ s/strucure/structure/ s/strucure/structure/ s/requre/require/ s/strucure/structure/ Thanks I guess I need to start using a spell checker for commit messages. One cleanup we

Re: [RFC 00/10] xhci: re-work command queue management

2014-01-15 Thread Mathias Nyman
On 01/14/2014 02:37 PM, David Laight wrote: From: Mathias Nyman ... The fact that you are having to allocate memory ion an ISR ought also to be ringing alarm bells. It did. Other options are as you said to use a 'software command ring'. Either just pre-allocate a full command ring (64 trbs

[RFCv2 02/10] xhci: use a command structure internally in xhci_address_device()

2014-01-30 Thread Mathias Nyman
Preparing for the global command queue by using command strucure in xhci_address_device Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com --- drivers/usb/host/xhci.c | 22 +- 1 file changed, 17 insertions(+), 5 deletions(-) diff --git a/drivers/usb/host/xhci.c b

[RFCv2 05/10] xhci: use command structure for xhci_queue_new_dequeue_state()

2014-01-30 Thread Mathias Nyman
Prepare for the global command ring by using command structures internally in functions calling xhci_queue_new_dequeue_state() Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com --- drivers/usb/host/xhci-ring.c | 3 +++ drivers/usb/host/xhci.c | 6 ++ 2 files changed, 9

[RFCv2 09/10] xhci: Use completion and status in global command queue

2014-01-30 Thread Mathias Nyman
Remove the per-device command list and handle_cmd_in_cmd_wait_list() and use the completion and status variables found in the command structure in the global command list. Signed-off-by: Mathias Nyman mathias.ny...@linux.intel.com --- drivers/usb/host/xhci-hub.c | 11 -- drivers/usb/host

  1   2   3   4   5   6   7   8   9   10   >