Re: [RFC] TASK_KILLED

2007-08-30 Thread Matthew Wilcox
On Thu, Aug 30, 2007 at 09:11:37AM -0400, Trond Myklebust wrote: diff --git a/fs/read_write.c b/fs/read_write.c index 507ddff..29e3f21 100644 --- a/fs/read_write.c +++ b/fs/read_write.c @@ -220,7 +220,7 @@ Einval: static void wait_on_retry_sync_kiocb(struct kiocb *iocb) { -

Re: [PATCH] debloat aic7xxx and aic79xx drivers by deinlining

2007-08-30 Thread Matthew Wilcox
On Thu, Aug 30, 2007 at 08:43:24PM +0200, Jan Engelhardt wrote: On Aug 28 2007 20:55, Denys Vlasenko wrote: Fwiw I do like your debloat patch a lot; it's just only half the equation ... if you also do the namespace fixes, I bet the driver debloats even more... Yes, I know, and I am happy

Re: [PATCH 2.6.23-rc4] irq: irq and pci_ids patch for Intel Tolapai

2007-08-30 Thread Matthew Wilcox
On Thu, Aug 30, 2007 at 03:46:56PM -0700, Jason Gaston wrote: This updated patch adds the Intel Tolapai LPC and SMBus Controller DID's. +#define PCI_DEVICE_ID_INTEL_Tolapai_00x5031 +#define PCI_DEVICE_ID_INTEL_Tolapai_10x5032 NACK -- use all upper-case. -- Intel are signing

Re: [PATCH] [541/2many] MAINTAINERS - WD7000 SCSI DRIVER

2007-08-13 Thread Matthew Wilcox
On Sun, Aug 12, 2007 at 11:39:41PM -0700, [EMAIL PROTECTED] wrote: Add file pattern to MAINTAINER entry Uh, what the fuck? You're posting over *500* patches to the same file? Just post one patch and people can respond to the bits of it that concern them. -- Bill, look, we understand that

Re: Linux 2.6.23-rc3

2007-08-14 Thread Matthew Wilcox
On Tue, Aug 14, 2007 at 11:10:22AM +0200, Tore Anderson wrote: I gave it a spin, and got quite a few troubles that appears related to the lpfc driver. I don't know if these problems happened due to the recent update as the latest kernel I ran before was 2.6.20 (where I never saw problems

Re: Linux 2.6.23-rc3

2007-08-15 Thread Matthew Wilcox
On Wed, Aug 15, 2007 at 10:08:17AM -0400, Igor A. Nesterov wrote: So would it be true to say that the fix for -EEXIST problem still has not found its way to mainline kernel? I've been hit by this problem after switching to Fedora 7, and currently running on Fedora 2.6.21-1.3228 kernel patched

Re: [RFC][PATCH] introduce TASK_SIZE_OF() for all arches

2007-08-21 Thread Matthew Wilcox
On Tue, Aug 21, 2007 at 09:54:33PM +0200, Adrian Bunk wrote: We currently support 6 different stable gcc release series plus heavily modified vendor branches like 3.3-hammer. We can discuss whether it is now already the right time, and where to make the cut, but medium-term we must reduce

Re: [PATCH 2/3] dma: override dma_flags_set_dmaflush for sn-ia64

2007-08-21 Thread Matthew Wilcox
On Tue, Aug 21, 2007 at 12:35:22PM -0700, [EMAIL PROTECTED] wrote: +int +dma_flags_set_dmaflush(int dir) + +Amend dir (one of the enum dma_data_direction values), with a platform- +specific dmaflush attribute. Unless the platform supports posted DMA +this is a no-op. + +On platforms that

Re: Build failure in advansys driver - error: implicit declaration of function 'to_pci_dev'

2007-08-12 Thread Matthew Wilcox
On Sun, Aug 12, 2007 at 01:43:16AM +0200, Jesper Juhl wrote: Trying to build current Linus git tree (head at ac07860264bd2b18834d3fa3be47032115524cea) using the attached config file (generated by 'make randconfig') the build fails for me with : ... CC drivers/scsi/advansys.o

Re: [RFC][PATCH] fix for async scsi scan sysfs problem (resend)

2007-08-12 Thread Matthew Wilcox
On Sat, Aug 11, 2007 at 04:04:54PM +0100, Jurij Smakov wrote: [Please keep me on CC, as I'm not on LKML.] I've recently got a Sun Blade 1000 box with a QLA2200 controller, and I'm bumping into exact same problem with 2.6.22: Please try http://marc.info/?l=linux-scsim=118289275414202 which

[EMAIL PROTECTED]: Re: [parisc-linux] parisc arch makefile clean-up needed [Was: cleaning up make headers_install for various architectures]]

2007-10-10 Thread Matthew Wilcox
Sam mipslet 'parisc-linux' in the first mail ... so i replied to the second mail ... without checking l-k was still cc'd. - Forwarded message from Matthew Wilcox [EMAIL PROTECTED] - From: Matthew Wilcox [EMAIL PROTECTED] To: Sam Ravnborg [EMAIL PROTECTED] Cc: [EMAIL PROTECTED] Subject

Re: parisc arch makefile clean-up needed [Was: cleaning up make headers_install for various architectures]

2007-10-10 Thread Matthew Wilcox
On Wed, Oct 10, 2007 at 08:38:58PM +0200, Sam Ravnborg wrote: parisc arch Makefile needs some love and care... None of your comments actually address the thing that he was having problems with: ifneq ($(call cc-ifversion, -lt, 0303, bad),) $(error Sorry, GCC v3.3 or above is required.) endif

Re: What still uses the block layer?

2007-10-13 Thread Matthew Wilcox
On Thu, Oct 11, 2007 at 08:11:21PM -0500, Rob Landley wrote: My impression from asking questions on the linux-scsi mailing list is that the scsi upper/middle/lower layers doesn't use the block layer described in Documentation/block/*. Entirely incorrect. Instead of using the block layer,

Re: What still uses the block layer?

2007-10-15 Thread Matthew Wilcox
On Mon, Oct 15, 2007 at 04:26:04AM -0500, Rob Landley wrote: For example, usb devices are never easy to order. IDE devices (back when they had their own namespace) were trivial to order back when /dev/hda couldn't move without use of a screwdriver. Ah, but it could. If you had more than

Re: What still uses the block layer?

2007-10-15 Thread Matthew Wilcox
On Mon, Oct 15, 2007 at 10:25:13AM -0700, Greg KH wrote: Use mount-by-label instead, it's much saner and handles device name movement just fine (as does the UUID method that you seem to hate.) Look in /dev/disk/ for a wide range of options that you have in which to choose how to pick your

Re: What still uses the block layer?

2007-10-15 Thread Matthew Wilcox
On Mon, Oct 15, 2007 at 07:54:22PM -0700, [EMAIL PROTECTED] wrote: do PCI devices reorder their bus numbers spontaniously, or only if you change the hardware? The only system I've had that reordered PCI bus numbers was when I had a partitionable system and changed the partitioning. Not quite

Re: What still uses the block layer?

2007-10-16 Thread Matthew Wilcox
On Tue, Oct 16, 2007 at 12:54:58PM -0700, [EMAIL PROTECTED] wrote: On Tue, 16 Oct 2007, Alan Cox wrote: I wouldn't try dividing those by pata v sata. You'll cause all sorts of problems in the process because of PATA-SATA and SATA-PATA bridges. if you use a PATA-SATA bridge (IDE drive SATA

Re: [Pcihpd-discuss] [PATCH 1/4] Fix PCIe hotplug for non-ACPI ExpressCard slots (version 2)

2007-10-16 Thread Matthew Wilcox
On Tue, Oct 16, 2007 at 09:54:08PM -0400, Mark Lord wrote: - t_slot-hpc_ops-get_adapter_status(t_slot, value); /* Check if slot is occupied */ + /* Check if slot is occupied */ + t_slot-hpc_ops-get_adapter_status(t_slot, value); if ((POWER_CTRL(ctrl-ctrlcap)) !value) { -

Re: [Pcihpd-discuss] [PATCH 2/4] Fix PCIe hotplug for non-ACPI ExpressCard slots (version 2)

2007-10-16 Thread Matthew Wilcox
On Tue, Oct 16, 2007 at 09:54:42PM -0400, Mark Lord wrote: if (rc) goto err_out_free_ctrl_slot; - } + } else if (pciehp_force) + pciehp_enable_slot(t_slot); I find the construct if () { ... } else ...; to be a bit jarring. How about

Re: [RFC patch] fallback to no irq hack for case of no pnp_irq allocated for 8250_pnp

2007-10-16 Thread Matthew Wilcox
On Wed, Oct 17, 2007 at 10:50:53AM +0800, Luming Yu wrote: There is a ttyS1 irq is -1 problem observed on tiger4 which cause the serial port broken. It is because that there is __no__ ACPI IRQ resource assigned for the serial port. So the value of the IRQ for the port is never changed since

Re: [Pcihpd-discuss] [PATCH 1/4] Fix PCIe hotplug for non-ACPI ExpressCard slots (version 2)

2007-10-17 Thread Matthew Wilcox
On Wed, Oct 17, 2007 at 09:09:24AM -0400, Mark Lord wrote: I'd argue these comments fall under stating the bleedin' obvious, but that's Kristen's call. Hey, they're original to the file. I'm just keeping checkpatch.pl happy here. Ditto for everything else you commented on. I can see that

Re: [PATCH] drivers/scsi/advansys.c: fix advansys_board_found compile error

2007-08-01 Thread Matthew Wilcox
On Wed, Aug 01, 2007 at 09:39:12PM +0800, Eugene Teo wrote: This patch fixes the following compile error: drivers/scsi/advansys.c: In function 'advansys_board_found': drivers/scsi/advansys.c:17781: error: implicit declaration of function 'to_pci_dev' Or just remove the ifdefs around the

Re: [PATCH] drivers/scsi/advansys.c: fix advansys_board_found compile error

2007-08-01 Thread Matthew Wilcox
On Wed, Aug 01, 2007 at 04:27:15PM +0200, Gabriel C wrote: Matthew Wilcox wrote: I'd be interested in seeing the results of the randconfig trials on the driver with those 23 patches applied, but not particularly interested in the intermediate result. I can do that on weekend. Thanks

Re: [RFC][PATCH] Coding style fix drivers/scsi/mvme147.c

2007-08-01 Thread Matthew Wilcox
On Wed, Aug 01, 2007 at 05:17:15PM +0200, Michal Piotrowski wrote: -#includelinux/stat.h +#include linux/stat.h Why does this driver need stat.h at all? -- Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take

Re: [patch 2/4] Expose Power Management Policy option to users

2007-08-01 Thread Matthew Wilcox
On Tue, Jul 31, 2007 at 09:18:08AM -0500, James Bottomley wrote: The other comment is that power saving seems to be a property of the transport rather than the host. If you do it in the transport classes, then you can expose all the knobs the actual transport possesses (which is,

Re: [PATCH] Fix two potential mem leaks in MPT Fusion (mpt_attach())

2007-08-01 Thread Matthew Wilcox
On Wed, Aug 01, 2007 at 05:26:53PM -0700, Andrew Morton wrote: Why on earth is that using GFP_ATOMIC? This function later goes on to create procfs files and such things. Seems fairly common in driver initialisation code. I removed three instances of this in the advansys driver. y'know, we

Re: [PATCH] fs/fcntl.c : don't test unsigned value for less than zero

2005-04-14 Thread Matthew Wilcox
On Fri, Apr 15, 2005 at 03:07:42AM +0200, Jesper Juhl wrote: 'arg' is unsigned so it can never be less than zero, so testing for that is pointless and also generates a warning when building with gcc -W. This patch eliminates the pointless check. Didn't Linus already reject this one 6 months

Re: [PATCH] fs/fcntl.c : don't test unsigned value for less than zero

2005-04-15 Thread Matthew Wilcox
On Fri, Apr 15, 2005 at 09:21:50AM +0100, Christoph Hellwig wrote: On Fri, Apr 15, 2005 at 02:31:00AM +0100, Matthew Wilcox wrote: On Fri, Apr 15, 2005 at 03:07:42AM +0200, Jesper Juhl wrote: 'arg' is unsigned so it can never be less than zero, so testing for that is pointless and also

Re: [PATCH] fs/fcntl.c : don't test unsigned value for less than zero

2005-04-15 Thread Matthew Wilcox
On Fri, Apr 15, 2005 at 10:03:05PM +1000, Herbert Xu wrote: I suppose it could be smart and stay quiet about val 0 || val BOUND However, gcc is slow enough as it is without adding unnecessary smarts like this. It only warns with -W on, not with -Wall, so I see no compelling reason to

Re: RFC: [PATCH-2.6] Add helper function to lock multiple page cache pages.

2005-02-02 Thread Matthew Wilcox
On Wed, Feb 02, 2005 at 03:12:50PM +, Anton Altaparmakov wrote: I think the below loop would be clearer as a for loop ... err = 0; for (nr = 0; nr nr_pages; nr++, start++) { if (start == lp_idx) { pages[nr] = locked_page;

Re: M7101

2005-02-06 Thread Matthew Wilcox
On Sun, Feb 06, 2005 at 03:26:15PM +0100, Jean Delvare wrote: Maarten Deprez then converted it to the proper kernel coding-style: http://marc.theaimsgroup.com/?l=linux-kernelm=110726276414532 I invite you to test the new patch and confirm that it works for you. Any chance we could get the

NFSD needs EXPORTFS

2005-02-03 Thread Matthew Wilcox
Got this report about 2.6.11-rc3. Is this the correct solution? - Forwarded message from Joel Soete [EMAIL PROTECTED] - A short analyse, it seems that's because NFSD was builtin while EXPORTFS was a module in my previous config file. Imho EXPORTFS would be build as NFSD? Is the

Re: pci: Arch hook to determine config space size

2005-01-31 Thread Matthew Wilcox
On Mon, Jan 31, 2005 at 01:10:46PM -0600, Brian King wrote: Greg KH wrote: On Fri, Jan 28, 2005 at 06:52:34PM +, Christoph Hellwig wrote: +int __attribute__ ((weak)) pcibios_exp_cfg_space(struct pci_dev *dev) { return 1; } - prototypes belong to headers - weak linkage is the perfect

Re: [PATCH] pci_raw_ops should use unsigned args

2005-02-03 Thread Matthew Wilcox
changed, 51 insertions(+), 46 deletions(-) Signed-off-by: Bjorn Helgaas [EMAIL PROTECTED] Acked-by: Matthew Wilcox [EMAIL PROTECTED] -- Next the statesmen will invent cheap lies, putting the blame upon the nation that is attacked, and every man will be glad of those conscience-soothing falsities

[PATCH] Makefiles are not built using a Fortran compiler

2005-02-07 Thread Matthew Wilcox
with nothing to do; down from 29.1 seconds to 24.7 seconds on my K6. Signed-off-by: Matthew Wilcox [EMAIL PROTECTED] Index: Makefile === RCS file: /var/cvs/linux-2.6/Makefile,v retrieving revision 1.338 diff -u -p -r1.338 Makefile

Re: [PATCH] Makefiles are not built using a Fortran compiler

2005-02-08 Thread Matthew Wilcox
On Tue, Feb 08, 2005 at 01:23:48PM +0100, Roman Zippel wrote: Enabling the following in the Makefile should have the same effect: # For maximum performance (+ possibly random breakage, uncomment # the following) #MAKEFLAGS += -rR This reduces the debug output even further (and size of

Re: [PATCH] Makefiles are not built using a Fortran compiler

2005-02-08 Thread Matthew Wilcox
On Tue, Feb 08, 2005 at 08:20:27PM +0100, Sam Ravnborg wrote: In my inbox I have a patch that enables SCCS support for all files. Today it fails for Kconfig files at least. I guess the kconfig system needs to try to make Kconfig files before including them ... this works for me, checking a

Re: [KJ] [PATCH] drivers/char/watchdog/* : pci_request_regions

2005-02-14 Thread Matthew Wilcox
On Mon, Feb 14, 2005 at 04:01:11PM +0100, Christophe Lucas wrote: If PCI request regions fails, then someone else is using the hardware we wish to use. For that one case, calling pci_disable_device() is rather rude. See : http://www.ussg.iu.edu/hypermail/linux/kernel/0502.1/1061.html

Re: [PATCH] Consolidate compat_sys_waitid

2005-02-15 Thread Matthew Wilcox
On Tue, Feb 15, 2005 at 02:01:49PM +1100, Stephen Rothwell wrote: Parisc seemed to assume th existance of compat_sys_waitid. PA-RISC already has a compat_sys_waitid ;-P The reason it isn't in Linus' tree yet is that it depends on the is_compat_task() predicate which Andi vetoed out of Andrew's

Re: [KJ] [PATCH] drivers/char/watchdog/* : pci_request_regions

2005-02-17 Thread Matthew Wilcox
On Thu, Feb 17, 2005 at 01:49:12PM -0500, Jeff Garzik wrote: Matthew Wilcox wrote: On Mon, Feb 14, 2005 at 04:01:11PM +0100, Christophe Lucas wrote: If PCI request regions fails, then someone else is using the hardware we wish to use. For that one case, calling pci_disable_device

Re: [PATCH 22/82] remove linux/version.h from drivers/message/fus ion

2005-07-20 Thread Matthew Wilcox
On Tue, Jul 19, 2005 at 10:12:49PM -0500, Matt Domsch wrote: What you illustrated above is not going to work. If your doing #ifndef around a function, such as scsi_device_online, it's not going to compile when scsi_device_online is already implemented in the kernel tree. The routine

Re: [PATCH] sparc64: Fix copy_sigingo_to_user32()

2005-04-21 Thread Matthew Wilcox
On Wed, Apr 20, 2005 at 11:08:10PM -0700, Linux Kernel Mailing List wrote: tree 19b2c9e85dcab6df9250ba38df885d951c96e0a6 parent dadeafdfc8da8c27e5a68e0706b9856eaac89391 author Jurij Smakov [EMAIL PROTECTED] Mon, 18 Apr 2005 08:03:12 -0700 committer Linus Torvalds [EMAIL PROTECTED] Mon, 18 Apr

Re: REGRESSION in 2.6.13-rc1: Massive slowdown with Adaptec SCSI

2005-07-04 Thread Matthew Wilcox
On Tue, Jul 05, 2005 at 11:08:17AM +1000, Neil Brown wrote: On 2.6.13-rc1 the same test takes just short on 1 minute and reports slightly less than 2 M/Second. That sounds like your drives have negotiated an asynchronous transfer agreement. Could you provide your dmesg to confirm that

Re: [patch 2.6.12 (repost w/ corrected subject)] pci: restore BAR values in pci_enable_device_bars

2005-07-05 Thread Matthew Wilcox
On Sat, Jul 02, 2005 at 09:09:13AM +0100, Russell King wrote: The PCI subsystem is incomplete for 64-bit BAR support. What it does do though is ensure that 64-bit BARs will work correctly in a 32-bit system. Therefore, I think that folk who want 64-bit BAR support to work need to do some

[PATCH] Releasing resources with children

2005-03-14 Thread Matthew Wilcox
() we may get some. At the point where someone hits this BUG we can figure out what semantics we want. Signed-off-by: Matthew Wilcox [EMAIL PROTECTED] diff -urpNX dontdiff linux-2.6.11-bk10/kernel/resource.c parisc-2.6-bk/kernel/resource.c --- linux-2.6.11-bk10/kernel/resource.c 2005-03-14 06:44

Re: [Ext2-devel] Re: [PATCH] 2.6.11-mm3 patch for ext3 writeback nobh option

2005-03-15 Thread Matthew Wilcox
On Tue, Mar 15, 2005 at 05:26:36PM +0100, Arjan van de Ven wrote: I still don't get why you want a mount option. Sure during development it can be nice.. but do you still want it in the production trees?? (I understand that for small blocksizes you need to fallback code, fine, no problem, but

[PATCH] CON_BOOT

2005-03-15 Thread Matthew Wilcox
New console flag: CON_BOOT CON_BOOT is like early printk in that it allows for output really early on. It's better than early printk because it unregisters automatically when a real console is initialised. So if you don't get consoles registering in console_init, there isn't a huge delay

Re: [PATCH] CON_BOOT

2005-03-16 Thread Matthew Wilcox
On Tue, Mar 15, 2005 at 02:37:11PM -0800, Andrew Morton wrote: Matthew Wilcox [EMAIL PROTECTED] wrote: + if (console_drivers (console_drivers-flags CON_BOOT)) { + unregister_console(console_drivers); + console-flags = ~CON_PRINTBUFFER; + } + Should we

Re: [PATCH] CON_BOOT

2005-03-16 Thread Matthew Wilcox
On Wed, Mar 16, 2005 at 01:09:48PM -0800, Andrew Morton wrote: It doesn't sound terribly important - I was just curious, thanks. We can let this one be demand-driven. OK, thanks ;-) I'm surprised that more systems don't encounter this - there's potentially quite a gap between console_init()

Re: [PATCH] alpha build fixes

2005-03-23 Thread Matthew Wilcox
[I'm not subscribed, please excuse the thread-breaking] Alan Cox wrote: +static inline int pci_get_legacy_ide_irq(struct pci_dev *dev, int channel) +{ + return channel ? 15 : 14; +} The issue is bigger - it's needed for the CMD controllers on PA-RISC for example it appears - and

Re: [BUG] 2.6.11- sym53c8xx Broken on pp64

2005-03-10 Thread Matthew Wilcox
On Thu, Mar 10, 2005 at 04:59:43PM +1100, Benjamin Herrenschmidt wrote: Ok, we have it working here on a similar machine with 2.6.11 and failing in a similar way with bk which is why I asked ;) The bk problem is found fixed here tho. I'll send a patch later, it's a bug with ppc64 iounmap()

Re: [PATCH 2.6.11.2 1/1] PCI Allow OutOfRange PIRQ table address

2005-03-10 Thread Matthew Wilcox
On Thu, Mar 10, 2005 at 05:29:35AM -0800, [EMAIL PROTECTED] wrote: Nice work, I like it. You could make it even prettier: diff -uprN -X dontdiff linux-2.6.11.2-vanilla/arch/i386/pci/irq.c linux-2.6.11.2/arch/i386/pci/irq.c --- linux-2.6.11.2-vanilla/arch/i386/pci/irq.c2005-03-10

Re: [PATCH, RFC 1/3] Add sem_getcount() to arches that lack it

2005-03-11 Thread Matthew Wilcox
On Thu, Mar 10, 2005 at 09:56:52PM -0800, Andrew Morton wrote: That's a nice application of semaphores. I can see that there's also a need to be able to read the value back for reporting purposes. Dang. But I guess it's a bit hard to justify adding more infrastructure to support a single

Re: [ARM] Group device drivers together under their own menu

2005-03-26 Thread Matthew Wilcox
On Sat, Mar 05, 2005 at 11:58:51AM +, Linux Kernel Mailing List wrote: ChangeSet 1.1982.137.48, 2005/03/05 11:58:51+00:00, [EMAIL PROTECTED] [ARM] Group device drivers together under their own menu Any reason you can't merge ARM's options into the drivers/*/Kconfig (with appropriate

Re: [ARM] Group device drivers together under their own menu

2005-03-26 Thread Matthew Wilcox
On Sat, Mar 26, 2005 at 10:50:26PM +, Russell King wrote: On Sat, Mar 26, 2005 at 09:41:41PM +, Matthew Wilcox wrote: Any reason you can't merge ARM's options into the drivers/*/Kconfig (with appropriate conditionals) and use drivers/Kconfig? Dunno. Haven't gotten around

Re: [PATCH] Pageset Localization V2

2005-03-30 Thread Matthew Wilcox
On Tue, Mar 29, 2005 at 09:51:08PM -0800, Christoph Lameter wrote: + BUG_ON(process_zones(smp_processor_id())); No. Who told you this was a good idea? This is the *worst* kind of assert, calling a function with side-effects. -- Next the statesmen will invent cheap lies, putting the blame

Re: Fwd: [PATCH] Pageset Localization V2

2005-03-31 Thread Matthew Wilcox
On Thu, Mar 31, 2005 at 03:32:35PM +0100, Christoph Hellwig wrote: Which would be much nicer done using INIT_LIST_HEAD on the new head always and then calling list_replace (of which currently only a _rcu variant exists). INIT_LIST_HEAD followed by list_splice() should do the trick, I think.

Re: PCI: fix an oops in some pci devices on hotplug remove when their resources are being freed.

2005-04-01 Thread Matthew Wilcox
On Fri, Apr 01, 2005 at 03:47:50PM -0800, Greg KH wrote: PCI: fix an oops in some pci devices on hotplug remove when their resources are being freed. As reported by Prarit Bhargava [EMAIL PROTECTED] Signed-off-by: Greg Kroah-Hartman [EMAIL PROTECTED] diff -Nru a/drivers/pci/remove.c

Re: PCI: fix an oops in some pci devices on hotplug remove when their resources are being freed.

2005-04-01 Thread Matthew Wilcox
On Fri, Apr 01, 2005 at 07:31:41PM -0800, Greg KH wrote: I agree. However, SGI seems to have some majorly insert expletive here hardware and drivers that cause this line to release a already released resource. See the other part of this patch for the part where this resource is supposedly

iomapping a big endian area

2005-04-02 Thread Matthew Wilcox
On Sat, Apr 02, 2005 at 02:52:14PM -0600, James Bottomley wrote: This driver has had it's own different infrastructure for doing this for ages, but it's time it used the common one. Thanks. I'd been looking at this for a while but hadn't got round tuit yet. #ifdef CONFIG_53C700_LE_ON_BE

Re: iomapping a big endian area

2005-04-02 Thread Matthew Wilcox
On Sat, Apr 02, 2005 at 06:38:05PM -0800, David S. Miller wrote: My thought on this is that we should encode the endianness of the registers in the ioremap cookie. Some architectures (sparc, I think?) can do this in their PTEs. The rest of us can do it in our ioread/writeN methods. I've

Re: non-free firmware in kernel modules, aggregation and unclear copyright notice.

2005-04-04 Thread Matthew Wilcox
On Mon, Apr 04, 2005 at 10:51:30AM -0700, Greg KH wrote: Then let's see some acts. We (lkml) are not the ones with the percieved problem, or the ones discussing it. Actually, there are some legitimate problems with some of the files in the Linux source base. Last time this came up, the Acenic

Re: [RFC: 2.6 patch] drivers/pci/: possible cleanups

2005-02-19 Thread Matthew Wilcox
On Sat, Feb 19, 2005 at 12:54:19AM +0100, Adrian Bunk wrote: - remove the following unused functions: - pci.c: pci_find_ext_capability The pcie bridge driver ought to be using this. I haven't submitted that cleanup patch yet. -- Next the statesmen will invent cheap lies, putting the blame

Re: [patch -mm series] ia64 specific /dev/mem handlers

2005-02-22 Thread Matthew Wilcox
On Tue, Feb 22, 2005 at 09:41:04AM -0500, Jes Sorensen wrote: + if (page-flags PG_uncached) Andrew dude. That ain't gonna work ;) Pardon my lack of clue, but why not? I think you're supposed to always use test_bit() to check page flags -- Next the statesmen will invent cheap lies,

Re: [2.6 patch] drivers/scsi/sym53c8xx_2/sym_hipd.c: make a function static

2005-02-28 Thread Matthew Wilcox
On Mon, Feb 28, 2005 at 11:01:55PM +0100, Adrian Bunk wrote: This patch makes a needlessly global function static. Thanks, committed -- Next the statesmen will invent cheap lies, putting the blame upon the nation that is attacked, and every man will be glad of those conscience-soothing

Re: [PATCH/RFC] I/O-check interface for driver's error handling

2005-03-01 Thread Matthew Wilcox
On Tue, Mar 01, 2005 at 05:33:48PM +0900, Hidetoshi Seto wrote: Today's patch is 3rd one - iochk_clear/read() interface. - This also adds pair-interface, but not to sandwich only readX(). Depends on platform, starting with ioreadX(), inX(), writeX() if possible... and so on could be target

Re: [PATCH/RFC] I/O-check interface for driver's error handling

2005-03-01 Thread Matthew Wilcox
On Tue, Mar 01, 2005 at 08:49:45AM -0800, Linus Torvalds wrote: On Tue, 1 Mar 2005, Jeff Garzik wrote: A new API handles none of this. Ehh? I think what Jeff meant was this new API handles none of this. And that's true, it doesn't handle DMA errors. But I think that's just something that

[PATCH] Symlinks from devices to classes

2005-03-03 Thread Matthew Wilcox
that anyway if we want ttyS* to have sysfs attributes (and presumably we do, eventually) Signed-off-by: Matthew Wilcox [EMAIL PROTECTED] Index: ./drivers/base/class.c === RCS file: /var/lib/cvs/linux-2.6/drivers/base/class.c,v

Re: [PATCH] Problems disabling SYSCTL

2005-01-24 Thread Matthew Wilcox
On Mon, Jan 24, 2005 at 05:00:53PM +0100, Andi Kleen wrote: But seriously I wouldn't bother - the syscall interface is deprecated anyways and has been for a long time. The only sysctl that needs to be handled is (CTL_KERN,KERN_VERSION) [used by glibc], the others are not needed and I hoep to

[PATCH] Make slab use alloc_pages directly

2005-01-24 Thread Matthew Wilcox
-by: Matthew Wilcox [EMAIL PROTECTED] Index: linux-2.6/mm/slab.c === RCS file: /var/cvs/linux-2.6/mm/slab.c,v retrieving revision 1.29 diff -u -p -r1.29 slab.c --- linux-2.6/mm/slab.c 12 Jan 2005 20:18:07 - 1.29 +++ linux-2.6/mm

Re: Fwd: Patch to control VGA bus routing and active VGA device.

2005-01-24 Thread Matthew Wilcox
On Mon, Jan 24, 2005 at 02:42:57PM -0500, Jeff Garzik wrote: Jon Smirl wrote: Is this a justification for doing device drivers for bridge chips? It has been mentioned before but no one has done it. Yeah, people are usually slack and work around the problem. A bridge driver is really

Re: Fwd: Patch to control VGA bus routing and active VGA device.

2005-01-24 Thread Matthew Wilcox
On Mon, Jan 24, 2005 at 02:17:15PM -0500, Jon Smirl wrote: On Mon, 24 Jan 2005 17:51:31 +, Matthew Wilcox [EMAIL PROTECTED] wrote: Yes -- *very* platform specific. Some are even configurable as to how much they support. See http://ftp.parisc-linux.org/docs/chips/zx1-mio.pdf

[PATCH] Factor out phase 6 of journal_commit_transaction

2005-01-24 Thread Matthew Wilcox
journal_commit_transaction() is 720 lines long. This patch pulls about 55 of them out into their own function, removes a goto and cleans up the control flow a little. It does not fix akpm's little note as that requires a bit more understanding of how jbd works ... Signed-off-by: Matthew Wilcox

Re: [PATCH] Remove special case in kmem_getpages()

2005-01-24 Thread Matthew Wilcox
On Mon, Jan 24, 2005 at 07:58:03PM -0500, Brian Gerst wrote: Matthew Wilcox wrote: __get_free_pages() calls alloc_pages, finds the page_address() and throws away the struct page *. Slab then calls virt_to_page to get it back again. Much more efficient for slab to call alloc_pages itself

Re: [KJ] [PATCH] unified spinlock initialization arch/mips/kernel/irq.c

2005-01-25 Thread Matthew Wilcox
On Tue, Jan 25, 2005 at 05:04:21PM +0530, Amit Gud wrote: Unify the spinlock initialization as far as possible. Do consider applying. Actually, 'handler' and 'lock' are initialised for you (see kernel/irq/handle.c) so I think those two lines can just be deleted. 'action' is also initialised

Re: optimize __gp location

2005-01-24 Thread Matthew Wilcox
On Tue, Jan 25, 2005 at 12:22:16AM +1100, Keith Owens wrote: Unfortunately marking jiffies and similar small but high usage variables as section .sbss or .sdata requires changes to common code. It might be worth doing, but the change would have to be structured so it worked on all

Re: Fwd: Patch to control VGA bus routing and active VGA device.

2005-01-28 Thread Matthew Wilcox
On Fri, Jan 28, 2005 at 12:33:20PM -0700, Grant Grundler wrote: If it is intended to work with multiple IO Port address spaces, then it needs to use the pci_dev-resource[] and mangle that appropriately. There is no resource for some of the I/O port space that cards respond to.

Re: pci: Arch hook to determine config space size

2005-02-01 Thread Matthew Wilcox
On Mon, Jan 31, 2005 at 10:52:29PM -0600, Brian King wrote: @@ -62,8 +72,11 @@ static int rtas_read_config(struct devic return PCIBIOS_DEVICE_NOT_FOUND; if (where (size - 1)) return PCIBIOS_BAD_REGISTER_NUMBER; You should probably delete this redundant test

Re: [PATCH 1/1] pci: Block config access during BIST (resend)

2005-02-01 Thread Matthew Wilcox
On Tue, Feb 01, 2005 at 09:12:56AM -0600, Brian King wrote: Greg KH wrote: On Fri, Jan 28, 2005 at 08:35:46AM -0600, Brian King wrote: +void pci_block_user_cfg_access(struct pci_dev *dev) +{ + unsigned long flags; + + pci_save_state(dev); + spin_lock_irqsave(pci_lock, flags); +

Re: [PATCH 1/1] pci: Block config access during BIST (resend)

2005-02-01 Thread Matthew Wilcox
On Tue, Feb 01, 2005 at 11:35:05AM -0600, Brian King wrote: If we've done a write to config space while the adapter was blocked, shouldn't we replay those accesses at this point? I did not think that was necessary. We have to do *something*. We can't just throw away writes. I see a few

[PATCH] pci_proc_domain

2005-01-17 Thread Matthew Wilcox
There's no need for the architectures to know how to name busses, so replace pci_name_bus with pci_proc_domain -- a predicate to allow architectures to choose whether domains are included in /proc/bus/pci or not. I've converted all architectures but only tested ia64 and a CONFIG_PCI_DOMAINS=n

PCI patches not being reviewed

2005-01-17 Thread Matthew Wilcox
Greg, you're merging a lot of patches that aren't going through the linux-pci mailing list for review. Please redirect patches that are sent to you directly so others can also review them. -- Next the statesmen will invent cheap lies, putting the blame upon the nation that is attacked, and

Re: PCI patches not being reviewed

2005-01-18 Thread Matthew Wilcox
On Mon, Jan 17, 2005 at 10:27:22PM -0800, Greg KH wrote: On Tue, Jan 18, 2005 at 02:20:31AM +, Matthew Wilcox wrote: Greg, you're merging a lot of patches that aren't going through the linux-pci mailing list for review. Please redirect patches that are sent to you directly so others

Re: PCI patches not being reviewed

2005-01-18 Thread Matthew Wilcox
On Tue, Jan 18, 2005 at 08:29:08AM -0800, Greg KH wrote: On Tue, Jan 18, 2005 at 12:21:26PM +, Matthew Wilcox wrote: Yes, the PCI Express bridge driver is quite buggy. It was posted a number of times to lkml in December, and it was commented on by a few different people, and the patch

Re: [PATCH] Problems disabling SYSCTL

2005-01-23 Thread Matthew Wilcox
On Sun, Jan 23, 2005 at 04:01:02PM +1100, Anton Blanchard wrote: Create a cond_syscall for sys32_sysctl and make all architectures use it. Also fix the architectures that dont wrap their 32bit compat sysctl code. Is there any reason to not move the sys32_sysctl code to kernel/sysctl.c? --

Re: [PATCH 3/4] fsfreeze: manage kill signal when sb_start_pagefault is called

2013-04-06 Thread Matthew Wilcox
, PAGE_CACHE_SIZE); Does the compiler not warn that you're assigning void to 'ret'? Or was there some other SNAFU sending these patches? -- Matthew Wilcox Intel Open Source Technology Centre Bill, look, we understand that you're interested in selling us this operating system

Re: [PATCH 2/4] fsfreeze: manage kill signal when sb_start_write is called

2013-04-06 Thread Matthew Wilcox
On Sat, Apr 06, 2013 at 12:04:52PM +0200, Marco Stornelli wrote: In every place where sb_start_write was called now we must manage the error code and return -EINTR. If we must manage the error code, then these functions should be marked __must_check. -- Matthew Wilcox

Re: [parisc-linux] [PATCH 07/15] parisc: remove use of asm/segment.h

2005-08-24 Thread Matthew Wilcox
On Wed, Aug 24, 2005 at 11:55:30AM -0500, Kumar Gala wrote: Removed asm-parisc/segment.h as its not used by anything. Did you already remove all the uses outside the parisc-specific bits of the tree, eg ISDN, media/video/, sound/oss/, etc? If so, ACK, otherwise, NAK. -- Next the statesmen

Re: [PATCH 2.6.13] IOCHK interface for I/O error handling/detecting (for ia64)

2005-09-02 Thread Matthew Wilcox
On Thu, Sep 01, 2005 at 05:45:54PM -0500, Brent Casavant wrote: I am extremely concerned about the performance implications of this implementation. These changes have several deleterious effects on I/O performance. I agree. I think the iochk patches should be abandoned and the feature

Re: [Pcihpd-discuss] [PATCH] use bus_slot number for name

2005-08-10 Thread Matthew Wilcox
On Fri, Aug 05, 2005 at 12:16:06PM -0700, Kristen Accardi wrote: For systems with multiple hotplug controllers, you need to use more than just the slot number to uniquely name the slot. Without a unique slot name, the pci_hp_register() will fail. This patch adds the bus number to the name.

Re: [PATCH] add transport class symlink to device object

2005-08-14 Thread Matthew Wilcox
On Sat, Aug 13, 2005 at 02:39:56PM -0700, Greg KH wrote: Heh, I already have a patch like this pending for 2.6.14 at: http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/gregkh-01-driver/driver-link-device-and-class.patch Last time I tried to do something like this, it fell

Re: [PATCH] add transport class symlink to device object

2005-08-14 Thread Matthew Wilcox
On Sun, Aug 14, 2005 at 11:25:25PM +0100, Russell King wrote: On Sun, Aug 14, 2005 at 04:02:31PM +0100, Matthew Wilcox wrote: Last time I tried to do something like this, it fell over with multi-function serial ports. Look at this example: # ls -l /sys/class/tty/ttyS*/device | cut -c40

Re: [PATCH] IDE: don't offer IDE_GENERIC on ia64

2005-08-16 Thread Matthew Wilcox
On Tue, Aug 16, 2005 at 01:55:58PM +0100, Alan Cox wrote: On Maw, 2005-08-16 at 11:38 +0200, Bartlomiej Zolnierkiewicz wrote: * removing IDE_ARCH_OBSOLETE_INIT define has some implications, * non-functional ide-cs driver (but there is no PCMCIA on IA64?) IA64 systems can support

Re: [PATCH] add transport class symlink to device object

2005-08-18 Thread Matthew Wilcox
On Thu, Aug 18, 2005 at 12:04:42AM -0700, Greg KH wrote: Matthew, this work for you? Yep, that's fine by me. Thanks. -- Next the statesmen will invent cheap lies, putting the blame upon the nation that is attacked, and every man will be glad of those conscience-soothing falsities, and will

Re: Kernel bug: Bad page state: related to generic symlink code and mmap

2005-08-19 Thread Matthew Wilcox
On Fri, Aug 19, 2005 at 08:38:34PM +0100, Al Viro wrote: FWIW, I'd rather take page_symlink(), page_symlink_inode_operations, page_put_link(), page_follow_link_light(), page_readlink(), page_getlink(), generic_readlink() and vfs_readlink() to the same place where these guys would live. They

Re: [RFC] pci_bus conversion to struct device

2007-01-27 Thread Matthew Wilcox
On Thu, Jan 18, 2007 at 11:58:05PM -0700, Grant Grundler wrote: Other per bus attributes might be address routing, VGA routing enabled, Fast-back-to-back enabled. PCI-X bridges and PCI-e bridges might also advertise data related to MMRBC and similar onboard buffer mgt behaviors. ISTR, IBM

Re: [RFC] pci_bus conversion to struct device

2007-01-27 Thread Matthew Wilcox
On Thu, Jan 18, 2007 at 01:00:44AM -0800, Greg KH wrote: On Thu, Jan 18, 2007 at 09:14:06AM +0100, Martin Mares wrote: Hello! I recommend we just delete the pci_bus class. I don't think it serves any useful purpose. The bridge can be inferred frmo the sysfs hierarchy (not to

Re: [Ksummit-2007-discuss] Re: [Ksummit-2006-discuss] 2007 Linux Kernel Summit

2007-01-30 Thread Matthew Wilcox
On Tue, Jan 30, 2007 at 11:10:57AM -0600, James Bottomley wrote: On Tue, 2007-01-30 at 08:16 +0100, Jes Sorensen wrote: I don't have an issue with the fact there are sponsors, however I think KS is important enough and sponsors are aware of this, that selling seats to sponsors shouldn't be

Re: [parisc-linux] [RFC][PATCH] use cycle_t instead of u64 in struct time_interpolator

2007-01-02 Thread Matthew Wilcox
On Tue, Jan 02, 2007 at 10:33:25PM +0100, Helge Deller wrote: Ok, not Ok ? Um, this is still doing cmpxchg() with insufficient locking. So, not OK. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: Finding hardlinks

2007-01-03 Thread Matthew Wilcox
On Wed, Jan 03, 2007 at 01:33:31PM +0100, Miklos Szeredi wrote: High probability is all you have. Cosmic radiation hitting your computer will more likly cause problems, than colliding 64bit inode numbers ;) Some of us have machines designed to cope with cosmic rays, and would be unimpressed

<    1   2   3   4   5   6   7   8   9   10   >