Re: [PATCH] perf tools : adds support for native scripting

2014-09-06 Thread Milian Wolff
performance when parsing perf's data files and a complete access to the raw data. You'll at least need some documentation how to use it. Ping, any news on this feature? I'd welcome the ability to create native scripts to write efficient tools based on perf. Bye -- Milian Wolff m...@milianw.de

Re: [PATCH] perf script: Initialize callchain_param.record_mode

2015-08-13 Thread Milian Wolff
On Thursday, August 13, 2015 09:17:24 AM Jiri Olsa wrote: On Wed, Jul 22, 2015 at 08:48:40PM +0200, Milian Wolff wrote: Hey all, I recorded a perf data file using perf record --call-graph dwarf kwrite some large file when I report it I see backtraces pointing to the user space

Re: [PATCH] perf script: Initialize callchain_param.record_mode

2015-08-17 Thread Milian Wolff
On Monday, August 17, 2015 10:47:50 AM CEST Arnaldo Carvalho de Melo wrote: Em Thu, Aug 13, 2015 at 10:53:36AM +0200, Milian Wolff escreveu: On Thursday, August 13, 2015 09:17:24 AM Jiri Olsa wrote: right you are.. does attached patch help? snip Hey Jiri, it works a treat

Re: [PATCH 0/3] perf tools DWARF libunwind: Add callchain order support

2015-11-22 Thread Milian Wolff
tting it fixed for libdw. Much appreciated! Cheers -- Milian Wolff | milian.wo...@kdab.com | Software Engineer KDAB (Deutschland) GmbH KG, a KDAB Group company Tel: +49-30-521325470 KDAB - The Qt Experts smime.p7s Description: S/MIME cryptographic signature

Re: [PATCH 1/3] perf tools: Introduce trim function

2016-04-07 Thread Milian Wolff
one? > nope, nothing yet I'll send a working solution based on Jiri's fix later when I'm back home. In the meantime, please have a look at my other patch regarding `perf inject` merging of trace events for sys_enter/exit. Thanks -- Milian Wolff | milian.wo...@kdab.com | Software Engineer

Re: [PATCH] perf trace: Add support for printing call chains on sys_exit events.

2016-04-09 Thread Milian Wolff
On Freitag, 8. April 2016 15:18:53 CEST Arnaldo Carvalho de Melo wrote: > Em Fri, Apr 08, 2016 at 02:57:54PM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Fri, Apr 08, 2016 at 01:34:15PM +0200, Milian Wolff escreveu: > > > Now, one can print the call chain for every en

[PATCH v3] perf inject: Make it possible to merge sys_enter/exit events

2016-08-30 Thread Milian Wolff
| |--1--read | |--1--init_tls | |--1--brk Signed-off-by: Milian Wolff <milian.wo...@kdab.com> --- tools/perf/Documentation/perf-inject.txt | 5 + tools/perf/builtin-inject.c | 157 +-- 2

Re: Inlined functions in perf report

2016-12-21 Thread Milian Wolff
k frames at all? Can you try `perf record --call-graph dwarf` instead? Of course, make sure you compile your code with `-g -O2` or similar. -- Milian Wolff | milian.wo...@kdab.com | Software Engineer KDAB (Deutschland) GmbH KG, a KDAB Group company Tel: +49-30-521325470 KDAB - The Qt Experts s

Re: Inlined functions in perf report

2016-12-20 Thread Milian Wolff
On Tuesday, December 20, 2016 10:54:50 AM CET Arnaldo Carvalho de Melo wrote: > Em Tue, Dec 20, 2016 at 02:27:10PM +0100, Milian Wolff escreveu: > > On Tuesday, December 20, 2016 1:17:55 PM CET Peter Zijlstra wrote: > > > On Tue, Dec 20, 2016 at 12:59:54PM +0100, Steinar

Re: Inlined functions in perf report

2016-12-20 Thread Milian Wolff
On Tuesday, December 20, 2016 2:43:41 PM CET Steinar H. Gunderson wrote: > On Tue, Dec 20, 2016 at 02:27:10PM +0100, Milian Wolff wrote: > > It is not even possible with that, perf report is lacking the steps > > required to add inline frames - it will only add "real"

Re: Inlined functions in perf report

2016-12-20 Thread Milian Wolff
ds to be compiled with > frame pointers enabled and inlined functions, as you noticed, are > 'lost'. > > There has been talk to attempt to utilize the ELF EH frames which are > mandatory in the x86_64 ABI (even for C) to attempt a kernel based > 'DWARF' unwind, but nobody has put f

Re: [PATCH v4 0/5] perf report: Show inline stack

2017-03-15 Thread Milian Wolff
line but not a symbol name. Again, why don't you align this with the other non-inlined frames, and honor the grouping setting? Check whether we group by address (then display file/ line), or by function (then display the function name). Bye -- Milian Wolff | milian.wo...@kdab.com | Software Engi

[PATCH] perf report: enable sorting by srcline as key

2017-03-18 Thread Milian Wolff
) | /usr/include/c++/6.3.1/bits/random.h:185 (inline) ... Signed-off-by: Milian Wolff <milian.wo...@kdab.com> --- tools/perf/Documentation/perf-report.txt | 1 + tools/perf/ui/browsers/hists.c | 3 +- tools/perf/ui/stdio/hist.c | 3 +- tools/per

Re: [PATCH v5 0/5] perf report: Show inline stack

2017-03-18 Thread Milian Wolff
t, again: I think these are minor issues, and the feature itself is already extremely useful and I hope to see it finally merged. Thanks again Jin for your good work! Cheers -- Milian Wolff | milian.wo...@kdab.com | Software Engineer KDAB (Deutschland) GmbH KG, a KDAB Group company Tel: +49-30-521325470 KDAB - The Qt Experts smime.p7s Description: S/MIME cryptographic signature

Re: [PATCH v3 0/5] perf report: Show inline stack

2017-03-02 Thread Milian Wolff
l feature and I would like to see it integrated upstream. From my POV, you can add Tested-by: Milian Wolff <milian.wo...@kdab.com> to all patches in this series. Many thanks! -- Milian Wolff | milian.wo...@kdab.com | Software Engineer KDAB (Deutschland) GmbH KG, a KDAB Group company Tel: +

Re: [PATCH v2 11/14] perf report: cache srclines for callchain nodes

2017-08-11 Thread Milian Wolff
On Donnerstag, 10. August 2017 19:58:45 CEST Arnaldo Carvalho de Melo wrote: > Em Thu, Aug 10, 2017 at 11:56:24PM +0900, Namhyung Kim escreveu: > > On Thu, Aug 10, 2017 at 8:51 PM, Milian Wolff <milian.wo...@kdab.com> wrote: > > > On Donnerstag, 10. August 2017 04:13:25

Re: [PATCH v2 11/14] perf report: cache srclines for callchain nodes

2017-08-10 Thread Milian Wolff
On Donnerstag, 10. August 2017 04:13:25 CEST Namhyung Kim wrote: > Hi Milian, > > On Sun, Aug 06, 2017 at 11:24:43PM +0200, Milian Wolff wrote: > > On one hand this ensures that the memory is properly freed when > > the DSO gets freed. On the other hand this si

Re: perf report: fix off-by-one for non-activation frames

2017-07-04 Thread Milian Wolff
On Monday, June 19, 2017 8:59:39 PM CEST Arnaldo Carvalho de Melo wrote: > Em Sat, Jun 17, 2017 at 01:13:11PM +0200, Milian Wolff escreveu: > > On Samstag, 17. Juni 2017 10:04:02 CEST Jan Kratochvil wrote: > > > On Sat, 17 Jun 2017 09:56:57 +0200, Namhyung Kim wrote: > &

hotspot v1.0.0 available - a GUI for Linux perf

2017-07-06 Thread Milian Wolff
a C++/Qt/KDE guy, so I used the technologies I'm familiar with. Cheers -- Milian Wolff | milian.wo...@kdab.com | Senior Software Engineer KDAB (Deutschland) GmbH KG, a KDAB Group company Tel: +49-30-521325470 KDAB - The Qt Experts smime.p7s Description: S/MIME cryptographic signature

Re: [PATCH/RFC 2/4] perf annotate: Add new source code view to the annotate TUI browser

2017-06-28 Thread Milian Wolff
view. The 't' key support should be a separate patch, I guess. It also does not update the column header (it stays at "Percent"). -- Milian Wolff | milian.wo...@kdab.com | Senior Software Engineer KDAB (Deutschland) GmbH KG, a KDAB Group company Tel: +49-30-521325470 KDAB - The Qt Experts

Re: [PATCH/RFC 0/4] perf annotate: Add --source-only option and the new source code TUI view

2017-06-28 Thread Milian Wolff
r inlining. Right now, we only see the self cost that is directly within main, I suspect. For C++ this is usually very misleading, and basically makes the annotate view completely useless for application-level profiling. If a second column would be added with the inclusive cost with the ability

Re: [PATCH/RFC 0/4] perf annotate: Add --source-only option and the new source code TUI view

2017-06-28 Thread Milian Wolff
On Wednesday, June 28, 2017 6:27:34 PM CEST Taeung Song wrote: > On 06/28/2017 06:53 PM, Milian Wolff wrote: > > On Wednesday, June 28, 2017 5:18:08 AM CEST Taeung Song wrote: > >> Hi, > >> > >> The --source-only option and new source code TUI view can show >

[PATCH] perf report: distinguish between inliners in the same function

2017-04-27 Thread Milian Wolff
_start ... ~ Cc: Arnaldo Carvalho de Melo <a...@redhat.com> Cc: David Ahern <dsah...@gmail.com> Cc: Namhyung Kim <namhy...@kernel.org> Cc: Peter Zijlstra <a.p.zijls...@chello.nl> Cc: Yao Jin <yao@linux.intel.com> Signed-off-by: Milian W

Re: [PATCH v2 01/14] perf report: remove code to handle inline frames from browsers

2017-08-07 Thread Milian Wolff
On Montag, 7. August 2017 17:07:10 CEST Arnaldo Carvalho de Melo wrote: > Em Sun, Aug 06, 2017 at 11:24:33PM +0200, Milian Wolff escreveu: > > The follow-up commits will make inline frames first-class citizens > > in the callchain, thereby obsoleting all of this special co

[PATCH v2 09/14] perf report: properly handle branch count in match_chain

2017-08-06 Thread Milian Wolff
Namhyung Kim <namhy...@kernel.org> Cc: Peter Zijlstra <a.p.zijls...@chello.nl> Cc: Yao Jin <yao@linux.intel.com> Signed-off-by: Milian Wolff <milian.wo...@kdab.com> --- tools/perf/util/callchain.c | 115 +++- 1 file changed, 59

[PATCH v2 03/14] perf report: create real callchain entries for inlined frames

2017-08-06 Thread Milian Wolff
transparently display inlined frames without having to patch their code. Cc: Arnaldo Carvalho de Melo <a...@redhat.com> Cc: David Ahern <dsah...@gmail.com> Cc: Namhyung Kim <namhy...@kernel.org> Cc: Peter Zijlstra <a.p.zijls...@chello.nl> Cc: Yao Jin <yao@linux.intel.com&g

[PATCH v2 12/14] perf report: use srcline from callchain for hist entries

2017-08-06 Thread Milian Wolff
o Carvalho de Melo <a...@redhat.com> Cc: David Ahern <dsah...@gmail.com> Cc: Namhyung Kim <namhy...@kernel.org> Cc: Peter Zijlstra <a.p.zijls...@chello.nl> Cc: Yao Jin <yao@linux.intel.com> Signed-off-by: Milian Wolff <milian.wo...@kdab.com> --- tools/per

[PATCH v2 11/14] perf report: cache srclines for callchain nodes

2017-08-06 Thread Milian Wolff
l.com> Cc: Namhyung Kim <namhy...@kernel.org> Cc: Peter Zijlstra <a.p.zijls...@chello.nl> Cc: Yao Jin <yao@linux.intel.com> Signed-off-by: Milian Wolff <milian.wo...@kdab.com> --- tools/perf/util/dso.c | 1 + tools/perf/util/dso.h | 1 + tools/perf/util/mac

[PATCH v2 08/14] perf report: compare symbol name for inlined frames when sorting

2017-08-06 Thread Milian Wolff
[.] cabs ~ Cc: Arnaldo Carvalho de Melo <a...@redhat.com> Cc: David Ahern <dsah...@gmail.com> Cc: Namhyung Kim <namhy...@kernel.org> Cc: Peter Zijlstra <a.p.zijls...@chello.nl> Cc: Yao Jin <yao@linux.intel.com> Signed-off-by: Milian Wolff <milian.wo...@kdab.com>

[PATCH v2 06/14] perf script: mark inlined frames and do not print DSO for them

2017-08-06 Thread Milian Wolff
c: Namhyung Kim <namhy...@kernel.org> Cc: Peter Zijlstra <a.p.zijls...@chello.nl> Cc: Yao Jin <yao@linux.intel.com> Signed-off-by: Milian Wolff <milian.wo...@kdab.com> --- tools/perf/util/evsel_fprintf.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

[PATCH v2 07/14] perf report: compare symbol name for inlined frames when matching

2017-08-06 Thread Milian Wolff
std::abs (inlined) std::__complex_abs (inlined) ~ Cc: Arnaldo Carvalho de Melo <a...@redhat.com> Cc: David Ahern <dsah...@gmail.com> Cc: Namhyung Kim <namhy...@kernel.org> Cc: Peter Zijlstra <a.p.zijls...@chello.nl> Cc: Yao Jin <yao@linux.intel.com&

[PATCH v2 04/14] perf report: fall-back to function name comparison for -g srcline

2017-08-06 Thread Milian Wolff
| | | --0.85%--cabs ~ Cc: Arnaldo Carvalho de Melo <a...@redhat.com> Cc: David Ahern <dsah...@gmail.com> Cc: Namhyung Kim <namhy...@kernel.org> Cc: Peter Zijlstra <a.p.zijls...@chello.nl> Cc: Yao Jin <yao@linux.intel.com> Signed-off-by: Milian Wolff <milian.wo.

[PATCH v2 00/14] generate full callchain cursor entries for inlined frames

2017-08-06 Thread Milian Wolff
ction and srcline is shown, as well as the (inlined) suffix only the basename of the srcline is shown v2 fixes some issues reported by Namhyung or found by me in further testing, adds caching and enables inline frames by default. Milian Wolff (14): perf report: remove code to handle inline frames

[PATCH v2 02/14] perf util: take elf_name as const string in dso__demangle_sym

2017-08-06 Thread Milian Wolff
...@linux.intel.com> Signed-off-by: Milian Wolff <milian.wo...@kdab.com> --- tools/perf/util/symbol-elf.c | 2 +- tools/perf/util/symbol-minimal.c | 2 +- tools/perf/util/symbol.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/perf/util/symbol-

[PATCH v2 05/14] perf report: mark inlined frames in output by " (inlined)" suffix

2017-08-06 Thread Milian Wolff
hello.nl> Cc: Yao Jin <yao@linux.intel.com> Signed-off-by: Milian Wolff <milian.wo...@kdab.com> --- tools/perf/util/callchain.c | 10 +++--- tools/perf/util/sort.c | 3 +++ 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/tools/perf/util/callchain.c

[PATCH v2 01/14] perf report: remove code to handle inline frames from browsers

2017-08-06 Thread Milian Wolff
.p.zijls...@chello.nl> Cc: Yao Jin <yao@linux.intel.com> Signed-off-by: Milian Wolff <milian.wo...@kdab.com> --- tools/perf/ui/browsers/hists.c | 180 +++- tools/perf/ui/stdio/hist.c | 77 + tools/perf/util/evsel_fprintf.c |

[PATCH v2 13/14] perf util: do not consider empty files as valid srclines

2017-08-06 Thread Milian Wolff
<a...@redhat.com> Cc: David Ahern <dsah...@gmail.com> Cc: Namhyung Kim <namhy...@kernel.org> Cc: Peter Zijlstra <a.p.zijls...@chello.nl> Cc: Yao Jin <yao....@linux.intel.com> Signed-off-by: Milian Wolff <milian.wo...@kdab.com> --- tools/perf/util/srcline.c | 6 +++

[PATCH v2 10/14] perf report: cache failed lookups of inlined frames

2017-08-06 Thread Milian Wolff
.org> Cc: Peter Zijlstra <a.p.zijls...@chello.nl> Cc: Yao Jin <yao@linux.intel.com> Signed-off-by: Milian Wolff <milian.wo...@kdab.com> --- tools/perf/util/machine.c | 15 +++ tools/perf/util/srcline.c | 18 ++ 2 files changed, 9 insertions(+), 24 d

[PATCH v2 14/14] perf util: enable handling of inlined frames by default

2017-08-06 Thread Milian Wolff
.org> Cc: Peter Zijlstra <a.p.zijls...@chello.nl> Cc: Yao Jin <yao@linux.intel.com> Cc: Ingo Molnar <mi...@kernel.org> Suggested-by: Ingo Molnar <mi...@kernel.org> Signed-off-by: Milian Wolff <milian.wo...@kdab.com> --- tools/perf/Documentation/perf-report.txt |

Re: [PATCH v2 03/14] perf report: create real callchain entries for inlined frames

2017-08-20 Thread Milian Wolff
On Mittwoch, 16. August 2017 09:53:13 CEST Namhyung Kim wrote: > Hi Milian, > > On Sun, Aug 06, 2017 at 11:24:35PM +0200, Milian Wolff wrote: > > The inlined frames use a fake symbol that is tracked in a special > > map inside the dso, which is always sorted by name. Al

[PATCH v2] perf report: distinguish between inliners in the same function

2017-05-03 Thread Milian Wolff
an equal first inline frame "main (inline)". Cc: Arnaldo Carvalho de Melo <a...@redhat.com> Cc: David Ahern <dsah...@gmail.com> Cc: Namhyung Kim <namhy...@kernel.org> Cc: Peter Zijlstra <a.p.zijls...@chello.nl> Cc: Yao Jin <yao@linux.intel.com> Signed

Re: [PATCH v2] perf report: distinguish between inliners in the same function

2017-05-14 Thread Milian Wolff
On Freitag, 12. Mai 2017 15:01:29 CEST Namhyung Kim wrote: > On Fri, May 12, 2017 at 12:37:01PM +0200, Milian Wolff wrote: > > On Mittwoch, 10. Mai 2017 07:53:52 CEST Namhyung Kim wrote: > > > Hi, > > > > > On Wed, May 03, 2017 at 11:35:36PM +0200, Milian Wolff

Re: [PATCH] perf report: don't crash on invalid maps in `-g srcline` mode

2017-05-12 Thread Milian Wolff
On Mittwoch, 10. Mai 2017 08:04:23 CEST Namhyung Kim wrote: > On Tue, May 09, 2017 at 10:50:46PM +0200, Milian Wolff wrote: > > diff --git a/tools/perf/util/callchain.c b/tools/perf/util/callchain.c > > index 9ab68682c6d0..295f0846fd84 100644 > > --- a/tools/perf/util/

Re: [PATCH v2] perf report: distinguish between inliners in the same function

2017-05-12 Thread Milian Wolff
On Mittwoch, 10. Mai 2017 07:53:52 CEST Namhyung Kim wrote: > Hi, > > On Wed, May 03, 2017 at 11:35:36PM +0200, Milian Wolff wrote: > > +static enum match_result match_chain_srcline(struct callchain_cursor_node > > *node, +

Re: [PATCH v2] perf report: distinguish between inliners in the same function

2017-05-15 Thread Milian Wolff
On Monday, May 15, 2017 3:21:58 AM CEST Namhyung Kim wrote: > Hi Milian, > > On Sun, May 14, 2017 at 08:10:50PM +0200, Milian Wolff wrote: > > On Freitag, 12. Mai 2017 15:01:29 CEST Namhyung Kim wrote: > > > On Fri, May 12, 2017 at 12:37:01PM +0200, Milian Wolff wrote:

[PATCH] perf report: don't crash on invalid maps in `-g srcline` mode

2017-05-09 Thread Milian Wolff
hello.nl> Cc: Yao Jin <yao@linux.intel.com> Signed-off-by: Milian Wolff <milian.wo...@kdab.com> --- tools/perf/util/callchain.c | 23 --- 1 file changed, 16 insertions(+), 7 deletions(-) diff --git a/tools/perf/util/callchain.c b/tools/perf/util/callchain.c ind

Re: [PATCH v2] perf report: fix off-by-one for non-activation frames

2017-05-18 Thread Milian Wolff
On Mittwoch, 17. Mai 2017 07:12:21 CEST Namhyung Kim wrote: > On Tue, May 16, 2017 at 06:26:47PM +0200, Milian Wolff wrote: > > On Dienstag, 16. Mai 2017 18:17:26 CEST Milian Wolff wrote: > > > On Dienstag, 16. Mai 2017 16:38:29 CEST Namhyung Kim wrote: > > > > On T

[PATCH v2] perf report: always honor callchain order for inlined nodes

2017-05-18 Thread Milian Wolff
linux.intel.com> Signed-off-by: Milian Wolff <milian.wo...@kdab.com> --- tools/perf/util/srcline.c | 23 --- 1 file changed, 8 insertions(+), 15 deletions(-) v2: - directly create list in correct order as suggested by Namhyung diff --git a/tools/perf/util/srcline

[PATCH v2] perf report: do not drop last inlined frame

2017-05-18 Thread Milian Wolff
libc-2.25.so) bd9 _start (/tmp/a.out) ~ Cc: Arnaldo Carvalho de Melo <a...@redhat.com> Cc: David Ahern <dsah...@gmail.com> Cc: Namhyung Kim <namhy...@kernel.org> Cc: Peter Zijlstra <a.p.zijls...@chello.nl> Cc: Yao Jin <yao@linux.intel.com> Signed-o

[PATCH v3] perf report: fix off-by-one for non-activation frames

2017-05-18 Thread Milian Wolff
rame for any but the very first frame. Cc: Arnaldo Carvalho de Melo <a...@redhat.com> Cc: David Ahern <dsah...@gmail.com> Cc: Namhyung Kim <namhy...@kernel.org> Cc: Peter Zijlstra <a.p.zijls...@chello.nl> Cc: Yao Jin <yao@linux.intel.com> Signed-off-by: Milia

[PATCH v2] perf report: fix memory leak in addr2line when called by addr2inlines

2017-05-18 Thread Milian Wolff
<dsah...@gmail.com> Cc: Namhyung Kim <namhy...@kernel.org> Cc: Peter Zijlstra <a.p.zijls...@chello.nl> Cc: Yao Jin <yao@linux.intel.com> Signed-off-by: Milian Wolff <milian.wo...@kdab.com> --- tools/perf/util/srcline.c | 23 +-- 1 file changed, 1

Re: [PATCH v2] perf report: always honor callchain order for inlined nodes

2017-05-18 Thread Milian Wolff
On Donnerstag, 18. Mai 2017 11:48:20 CEST Namhyung Kim wrote: > On Thu, May 18, 2017 at 10:37:59AM +0200, Milian Wolff wrote: > > So far, the inlined nodes where only reversed when we built perf > > against libbfd. If that was not available, the addr2line fallback > >

Re: [PATCH v2] perf report: fix off-by-one for non-activation frames

2017-05-16 Thread Milian Wolff
On Dienstag, 16. Mai 2017 16:38:29 CEST Namhyung Kim wrote: > On Tue, May 16, 2017 at 10:59:51AM +0200, Milian Wolff wrote: > > As the documentation for dwfl_frame_pc says, frames that > > are no activation frames need to have their program counter > > decremented by

Re: [PATCH] perf report: fix memory leak in addr2line when called by addr2inlines

2017-05-17 Thread Milian Wolff
On Wednesday, May 17, 2017 6:20:49 AM CEST Namhyung Kim wrote: > On Tue, May 16, 2017 at 11:53:59PM +0200, Milian Wolff wrote: > > When a filename was found in addr2line it was duplicated via strdup > > but never freed. Now we pass NULL and handle this gracefully i

Re: [PATCH] perf report: always honor callchain order for inlined nodes

2017-05-17 Thread Milian Wolff
On Wednesday, May 17, 2017 6:26:45 AM CEST Namhyung Kim wrote: > On Tue, May 16, 2017 at 11:54:22PM +0200, Milian Wolff wrote: > > So far, the inlined nodes where only reversed when we built perf > > against libbfd. If that was not available, the addr2line fallback > >

Re: [PATCH] perf report: Fix invalid warning on callchain param

2017-05-17 Thread Milian Wolff
the token > to be a number, it's good to show the warning there. > > Cc: Milian Wolff <milian.wo...@kdab.com> > Cc: Frederic Weisbecker <fweis...@gmail.com> > Signed-off-by: Namhyung Kim <namhy...@kernel.org> Thank you, that annoyed me too. Tested and reviewed it,

Re: [PATCH v2] perf report: fix off-by-one for non-activation frames

2017-05-16 Thread Milian Wolff
On Dienstag, 16. Mai 2017 18:17:26 CEST Milian Wolff wrote: > On Dienstag, 16. Mai 2017 16:38:29 CEST Namhyung Kim wrote: > > On Tue, May 16, 2017 at 10:59:51AM +0200, Milian Wolff wrote: > > > As the documentation for dwfl_frame_pc says, frames that > > > are no act

[PATCH v2] perf report: fix off-by-one for non-activation frames

2017-05-16 Thread Milian Wolff
st frame. Cc: Arnaldo Carvalho de Melo <a...@redhat.com> Cc: David Ahern <dsah...@gmail.com> Cc: Namhyung Kim <namhy...@kernel.org> Cc: Peter Zijlstra <a.p.zijls...@chello.nl> Cc: Yao Jin <yao@linux.intel.com> Signed-off-by: Milian Wolff <milian.wo...@kdab.com>

Re: [PATCH] perf report: fix off-by-one for non-activation frames

2017-05-16 Thread Milian Wolff
On Dienstag, 16. Mai 2017 03:57:53 CEST Namhyung Kim wrote: > On Mon, May 15, 2017 at 05:13:06PM +0200, Milian Wolff wrote: > > On Monday, May 15, 2017 5:04:44 PM CEST Milian Wolff wrote: > > > As the documentation for dwfl_frame_pc says, frames that > > > are no act

[PATCH] perf report: fix off-by-one for non-activation frames

2017-05-15 Thread Milian Wolff
chello.nl> Cc: Yao Jin <yao@linux.intel.com> Signed-off-by: Milian Wolff <milian.wo...@kdab.com> --- tools/perf/util/unwind-libdw.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tools/perf/util/unwind-libdw.c b/tools/perf/util/unwind-libdw.c index f90e11

Re: [PATCH] perf report: fix off-by-one for non-activation frames

2017-05-15 Thread Milian Wolff
On Monday, May 15, 2017 5:04:44 PM CEST Milian Wolff wrote: > As the documentation for dwfl_frame_pc says, frames that > are no activation frames need to have their program counter > decremented by one to properly find the function of the caller. Note that this leaves the perf buil

Re: [PATCH] perf, tools, script: Allow adding and removing fields

2017-06-09 Thread Milian Wolff
On Freitag, 9. Juni 2017 04:52:43 CEST Andi Kleen wrote: > On Thu, Jun 08, 2017 at 02:59:58PM +0200, Milian Wolff wrote: > > But I notice that this functionality is missing in other places too. Most > > notably, I would like to be able to configure `perf stat` in a

Re: [PATCH v2] perf: libdw support for powerpc [ping]

2017-06-21 Thread Milian Wolff
On Mittwoch, 21. Juni 2017 03:07:39 CEST Arnaldo Carvalho de Melo wrote: > Em Thu, Jun 15, 2017 at 10:46:16AM +0200, Milian Wolff escreveu: > > On Tuesday, June 13, 2017 5:55:09 PM CEST Ravi Bangoria wrote: > > Just a quick question: Have you guys applied my recent patch:

Re: [PATCH v2] perf: libdw support for powerpc [ping]

2017-06-21 Thread Milian Wolff
On Mittwoch, 21. Juni 2017 14:48:29 CEST Arnaldo Carvalho de Melo wrote: > Em Wed, Jun 21, 2017 at 10:16:56AM +0200, Milian Wolff escreveu: > > On Mittwoch, 21. Juni 2017 03:07:39 CEST Arnaldo Carvalho de Melo wrote: > > > Hi Millian, can I take this as an Acked-by or Tested-b

Re: [PATCH 7/7] perf script: mark inlined frames and do not print DSO for them

2017-05-24 Thread Milian Wolff
On Monday, May 22, 2017 2:11:58 PM CEST Namhyung Kim wrote: > On Thu, May 18, 2017 at 09:34:11PM +0200, Milian Wolff wrote: > > Instead of showing the (repeated) DSO name of the non-inlined > > frame, we now show the "(inlined)" suffix instead. > > > >

Re: [PATCH 3/7] perf report: create real callchain entries for inlined frames

2017-05-24 Thread Milian Wolff
On Monday, May 22, 2017 2:19:46 PM CEST Namhyung Kim wrote: > On Thu, May 18, 2017 at 09:34:07PM +0200, Milian Wolff wrote: > > + > > + if (strcmp(funcname, base_sym->name) == 0) { > > + // reuse the real, existing symbol > > I don't know whether it's

Re: [PATCH 0/7] generate full callchain cursor entries for inlined frames

2017-05-24 Thread Milian Wolff
On Monday, May 22, 2017 11:06:43 AM CEST Namhyung Kim wrote: > Hi Milian, > > On Thu, May 18, 2017 at 10:05:36PM +0200, Milian Wolff wrote: > > On Donnerstag, 18. Mai 2017 21:34:04 CEST Milian Wolff wrote: > > > This series of patches completely reworks the way inline

Re: [PATCH 6/7] perf report: mark inlined frames in output by " (inlined)" suffix

2017-05-24 Thread Milian Wolff
On Monday, May 22, 2017 2:48:18 PM CEST Namhyung Kim wrote: > On Thu, May 18, 2017 at 09:34:10PM +0200, Milian Wolff wrote: > > The original patch that introduced inline frame output in the > > various browsers used this suffix already. The new centralized > > approach t

Re: [PATCH 0/7] generate full callchain cursor entries for inlined frames

2017-05-24 Thread Milian Wolff
On Wednesday, May 24, 2017 1:46:04 PM CEST Milian Wolff wrote: > On Monday, May 22, 2017 11:06:43 AM CEST Namhyung Kim wrote: > > Hi Milian, > > > > On Thu, May 18, 2017 at 10:05:36PM +0200, Milian Wolff wrote: > > > On Donnerstag, 18. Mai 2017 21

Re: [PATCH 0/7] generate full callchain cursor entries for inlined frames

2017-05-29 Thread Milian Wolff
On Mittwoch, 24. Mai 2017 17:02:37 CEST Namhyung Kim wrote: > On Wed, May 24, 2017 at 03:42:59PM +0200, Milian Wolff wrote: > > On Wednesday, May 24, 2017 1:46:04 PM CEST Milian Wolff wrote: > > > On Monday, May 22, 2017 11:06:43 AM CEST Namhyung Kim wrote: > > > >

[PATCH 0/7] generate full callchain cursor entries for inlined frames

2017-05-18 Thread Milian Wolff
__libc_start_main | _start ... # NOTE: the first and last entry of the inline stack have the correct symbol and srcline now both function and srcline is shown, as well as the (inlined) suffix only the basename of the srcline is shown ~ Milian Wolff (7): perf

[PATCH 1/7] perf report: remove code to handle inline frames from browsers

2017-05-18 Thread Milian Wolff
ijls...@chello.nl> Cc: Yao Jin <yao@linux.intel.com> Signed-off-by: Milian Wolff <milian.wo...@kdab.com> --- tools/perf/ui/browsers/hists.c | 183 +++- tools/perf/ui/stdio/hist.c | 80 +- tools/perf/util/evsel_fprintf.c |

[PATCH 5/7] perf report: fall-back to function name comparison for -g srcline

2017-05-18 Thread Milian Wolff
| | | --0.85%--cabs ~ Cc: Arnaldo Carvalho de Melo <a...@redhat.com> Cc: David Ahern <dsah...@gmail.com> Cc: Namhyung Kim <namhy...@kernel.org> Cc: Peter Zijlstra <a.p.zijls...@chello.nl> Cc: Yao Jin <yao@linux.intel.com> Signed-off-by: Milian Wolff <milian.wo.

[PATCH 2/7] perf util: take elf_name as const string in dso__demangle_sym

2017-05-18 Thread Milian Wolff
...@linux.intel.com> Signed-off-by: Milian Wolff <milian.wo...@kdab.com> --- tools/perf/util/symbol-elf.c | 2 +- tools/perf/util/symbol-minimal.c | 2 +- tools/perf/util/symbol.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/perf/util/symbol-

[PATCH 7/7] perf script: mark inlined frames and do not print DSO for them

2017-05-18 Thread Milian Wolff
c: Namhyung Kim <namhy...@kernel.org> Cc: Peter Zijlstra <a.p.zijls...@chello.nl> Cc: Yao Jin <yao@linux.intel.com> Signed-off-by: Milian Wolff <milian.wo...@kdab.com> --- tools/perf/util/evsel_fprintf.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

[PATCH 3/7] perf report: create real callchain entries for inlined frames

2017-05-18 Thread Milian Wolff
transparently display inlined frames without having to patch their code. Cc: Arnaldo Carvalho de Melo <a...@redhat.com> Cc: David Ahern <dsah...@gmail.com> Cc: Namhyung Kim <namhy...@kernel.org> Cc: Peter Zijlstra <a.p.zijls...@chello.nl> Cc: Yao Jin <yao@linux.intel.com&g

[PATCH 4/7] perf report: use srcline from inlined frames

2017-05-18 Thread Milian Wolff
<a...@redhat.com> Cc: David Ahern <dsah...@gmail.com> Cc: Namhyung Kim <namhy...@kernel.org> Cc: Peter Zijlstra <a.p.zijls...@chello.nl> Cc: Yao Jin <yao@linux.intel.com> Signed-off-by: Milian Wolff <milian.wo...@kdab.com> --- tools/perf/util/callchain.c | 2

[PATCH 6/7] perf report: mark inlined frames in output by " (inlined)" suffix

2017-05-18 Thread Milian Wolff
hello.nl> Cc: Yao Jin <yao@linux.intel.com> Signed-off-by: Milian Wolff <milian.wo...@kdab.com> --- tools/perf/util/callchain.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/tools/perf/util/callchain.c b/tools/perf/util/callchain.c index 211ed3713

Re: [PATCH 0/7] generate full callchain cursor entries for inlined frames

2017-05-18 Thread Milian Wolff
On Donnerstag, 18. Mai 2017 21:34:04 CEST Milian Wolff wrote: > This series of patches completely reworks the way inline frames are handled. > Instead of querying for the inline nodes on-demand in the individual tools, > we now create proper callchain nodes for inlined frames. The a

Re: [PATCH 4/7] perf script: Add --inline option

2017-05-24 Thread Milian Wolff
included. Adding a > non-debugging feature as a non-default command line option is really as if > we didn't do anything: very few if any people will use it, and it might > bitrot in the future without people noticing. > > So we need apply some thought into making it available to two

Re: [PATCH v2] perf report: distinguish between inliners in the same function

2017-05-16 Thread Milian Wolff
On Dienstag, 16. Mai 2017 02:53:32 CEST Namhyung Kim wrote: > On Mon, May 15, 2017 at 12:01:54PM +0200, Milian Wolff wrote: > > On Monday, May 15, 2017 3:21:58 AM CEST Namhyung Kim wrote: > > > Hi Milian, > > > > > > On Sun, May 14, 2017 at 08:10:50PM +0200, Mi

Re: [PATCH] perf script: Add --inline option

2017-05-16 Thread Milian Wolff
n >20511 __libc_start_main (/usr/lib/libc-2.25.so) > 8ba _start (/home/namhyung/tmp/perf/a.out) > ... > > Cc: Jin Yao <yao@linux.intel.com> > Cc: Milian Wolff <milian.wo...@kdab.com> Acked, tested and reviewed by me, too. Tha

[PATCH] perf report: do not drop last inlined frame

2017-05-16 Thread Milian Wolff
libc-2.25.so) bd9 _start (/tmp/a.out) ~ Cc: Arnaldo Carvalho de Melo <a...@redhat.com> Cc: David Ahern <dsah...@gmail.com> Cc: Namhyung Kim <namhy...@kernel.org> Cc: Peter Zijlstra <a.p.zijls...@chello.nl> Cc: Yao Jin <yao@linux.intel.com> Signed-o

[PATCH] perf report: always honor callchain order for inlined nodes

2017-05-16 Thread Milian Wolff
<a...@redhat.com> Cc: David Ahern <dsah...@gmail.com> Cc: Namhyung Kim <namhy...@kernel.org> Cc: Peter Zijlstra <a.p.zijls...@chello.nl> Cc: Yao Jin <yao@linux.intel.com> Signed-off-by: Milian Wolff <milian.wo...@kdab.com> --- tools/perf/util/srcline.c | 28

[PATCH] perf report: fix memory leak in addr2line when called by addr2inlines

2017-05-16 Thread Milian Wolff
<dsah...@gmail.com> Cc: Namhyung Kim <namhy...@kernel.org> Cc: Peter Zijlstra <a.p.zijls...@chello.nl> Cc: Yao Jin <yao@linux.intel.com> Signed-off-by: Milian Wolff <milian.wo...@kdab.com> --- tools/perf/util/srcline.c | 13 ++--- 1 file changed, 6 insertions(+)

[PATCH 2/2] perf report: report module before querying isactivation in dwfl unwind

2017-06-02 Thread Milian Wolff
<a...@redhat.com> Cc: Namhyung Kim <namhy...@kernel.org> Cc: Jiri Olsa <jo...@redhat.com> Signed-off-by: Milian Wolff <milian.wo...@kdab.com> --- tools/perf/util/unwind-libdw.c | 8 1 file changed, 8 insertions(+) diff --git a/tools/perf/util/unwind-libdw.c b/tools/perf/u

[PATCH 1/2] perf report: ensure the perf DSO mapping matches what libdw sees

2017-06-02 Thread Milian Wolff
. Cc: Arnaldo Carvalho de Melo <a...@redhat.com> Cc: Namhyung Kim <namhy...@kernel.org> Cc: Jiri Olsa <jo...@redhat.com> Signed-off-by: Milian Wolff <milian.wo...@kdab.com> --- tools/perf/util/unwind-libdw.c | 8 1 file changed, 8 insertions(+) diff --git a/tools/pe

Re: [PATCH 1/2] perf report: ensure the perf DSO mapping matches what libdw sees

2017-06-02 Thread Milian Wolff
On Freitag, 2. Juni 2017 17:23:41 CEST Arnaldo Carvalho de Melo wrote: > Em Fri, Jun 02, 2017 at 04:37:52PM +0200, Milian Wolff escreveu: > > In some situations the libdw unwinder stopped working properly. > > I.e. with libunwind we see: > > > > ~ > > >

[PATCH] perf report: include partial stacks unwound with libdw

2017-06-01 Thread Milian Wolff
cycles: ~ With this patch applied, the libdw unwinder will produce the same output as the libunwind unwinder. Cc: Arnaldo Carvalho de Melo <a...@redhat.com> Cc: Namhyung Kim <namhy...@kernel.org> Cc: Jiri Olsa <jo...@redhat.com> Signed-off-by: Milian Wolff <milian.wo...

Re: [PATCH 1/2] perf report: ensure the perf DSO mapping matches what libdw sees

2017-06-03 Thread Milian Wolff
On Freitag, 2. Juni 2017 21:49:10 CEST Arnaldo Carvalho de Melo wrote: > Em Fri, Jun 02, 2017 at 06:21:44PM +0200, Milian Wolff escreveu: > > On Freitag, 2. Juni 2017 17:23:41 CEST Arnaldo Carvalho de Melo wrote: > > > Looks ok, having both implementations matching and the

Re: [PATCH 6/7] perf report: mark inlined frames in output by " (inlined)" suffix

2017-06-03 Thread Milian Wolff
On Montag, 22. Mai 2017 14:48:18 CEST Namhyung Kim wrote: > On Thu, May 18, 2017 at 09:34:10PM +0200, Milian Wolff wrote: > > The original patch that introduced inline frame output in the > > various browsers used this suffix already. The new centralized > > approach t

Re: [GIT PULL 0/7] perf/urgent callchain fixes

2017-06-08 Thread Milian Wolff
On Thursday, June 8, 2017 3:59:31 PM CEST Arnaldo Carvalho de Melo wrote: > Em Thu, Jun 08, 2017 at 03:15:32PM +0200, Milian Wolff escreveu: > > On Wednesday, May 24, 2017 8:21:22 AM CEST Namhyung Kim wrote: > > > Hi Ingo, > > > > > > Please consider pulling th

Re: [GIT PULL 0/7] perf/urgent callchain fixes

2017-06-08 Thread Milian Wolff
it later. Hey guys, I notice that these patches are not in acme's perf/core branch. Can they be applied there too please? Thanks -- Milian Wolff | milian.wo...@kdab.com | Software Engineer KDAB (Deutschland) GmbH KG, a KDAB Group company Tel: +49-30-521325470 KDAB - The Qt Experts smime.p7s

Re: [PATCH] perf, tools, script: Allow adding and removing fields

2017-06-08 Thread Milian Wolff
_msr ([kernel.kallsyms]) > > The new syntax cannot be mixed with normal overriding. Tested-by: Milian Wolff <milian.wo...@kdab.com> Works a charm. But I notice that this functionality is missing in other places too. Most notably, I would like to be able to configure `perf stat` in a

Re: [PATCH 6/7] perf report: mark inlined frames in output by " (inlined)" suffix

2017-06-06 Thread Milian Wolff
On Tuesday, June 6, 2017 3:33:49 AM CEST Namhyung Kim wrote: > On Sat, Jun 3, 2017 at 10:51 PM, Milian Wolff <milian.wo...@kdab.com> wrote: > > On Montag, 22. Mai 2017 14:48:18 CEST Namhyung Kim wrote: > >> On Thu, May 18, 2017 at 09:34:10PM +0200, Milian Wolff wrote: &

Re: [PATCH v2] perf: libdw support for powerpc [ping]

2017-06-15 Thread Milian Wolff
zip 16699 6857.354663: 300677 cycles:u: > > zip 16699 6857.354895: 584131 cycles:u: > > zip 16699 6857.355312: 589687 cycles:u: > > zip 16699 6857.355606: 560142 cycles:u: Just a quick question: Have you guys applied my recent patch: commit 5ea0416f51cc9343

Re: perf report: fix off-by-one for non-activation frames

2017-06-16 Thread Milian Wolff
On Freitag, 16. Juni 2017 13:57:44 CEST Jan Kratochvil wrote: > On Fri, 16 Jun 2017 13:51:37 +0200, Milian Wolff wrote: > > > perf-4.12.0-0.rc5.git0.1.fc27.x86_64 > > > > > > 39e32e gdb_main (/usr/libexec/gdb) > > >

Re: perf report: fix off-by-one for non-activation frames

2017-06-17 Thread Milian Wolff
with Jan that we should mimick existing tool's behavior. I just fear that it's not trivial to do it with the current code base... -- Milian Wolff | milian.wo...@kdab.com | Senior Software Engineer KDAB (Deutschland) GmbH KG, a KDAB Group company Tel: +49-30-521325470 KDAB - The Qt Experts

Re: perf report: fix off-by-one for non-activation frames

2017-06-16 Thread Milian Wolff
On Freitag, 16. Juni 2017 08:14:56 CEST Jan Kratochvil wrote: > On Mon, 15 May 2017 17:04:44 +0200, Milian Wolff wrote: > > commit 1982ad48fc82c284a5cc55697a012d3357e84d01 > Author: Milian Wolff <milian.wo...@kdab.com> > Date: Wed May 24 15:21:25 2017 +0900 > > >

Re: [PATCH v1 2/2] perf report: Display titles in left frame of annotate browser

2017-05-04 Thread Milian Wolff
tually is. I guess it's a sample percentage? Maybe a header should be added that explains these values to newbies. I bet many people won't even know what IPC is either. Cheers -- Milian Wolff | milian.wo...@kdab.com | Software Engineer KDAB (Deutschland) GmbH KG, a KDAB Group company Tel: +49-30-521325470 KDAB - The Qt Experts

  1   2   3   4   5   6   >