[tip:perf/core] perf util: Enable handling of inlined frames by default

Commit-ID: d8a88dd243a170a226aba33e7c53704db2f82aa6 Gitweb: https://git.kernel.org/tip/d8a88dd243a170a226aba33e7c53704db2f82aa6 Author: Milian Wolff AuthorDate: Thu, 19 Oct 2017 13:38:36 +0200 Committer: Arnaldo Carvalho de Melo CommitDate: Wed, 25 Oct 2017 10:50:47 -0300 perf util

[tip:perf/core] perf report: Use srcline from callchain for hist entries

Commit-ID: 1fb7d06a509e82893e59e0f0b223e7d5d6d0ef8c Gitweb: https://git.kernel.org/tip/1fb7d06a509e82893e59e0f0b223e7d5d6d0ef8c Author: Milian Wolff <milian.wo...@kdab.com> AuthorDate: Thu, 19 Oct 2017 13:38:35 +0200 Committer: Arnaldo Carvalho de Melo <a...@redhat.com> Com

[tip:perf/core] perf report: Use srcline from callchain for hist entries

Commit-ID: 1fb7d06a509e82893e59e0f0b223e7d5d6d0ef8c Gitweb: https://git.kernel.org/tip/1fb7d06a509e82893e59e0f0b223e7d5d6d0ef8c Author: Milian Wolff AuthorDate: Thu, 19 Oct 2017 13:38:35 +0200 Committer: Arnaldo Carvalho de Melo CommitDate: Wed, 25 Oct 2017 10:50:46 -0300 perf report

[tip:perf/core] perf report: Cache srclines for callchain nodes

Commit-ID: 21ac9d547fdde79c1e8692587d9044fde549214b Gitweb: https://git.kernel.org/tip/21ac9d547fdde79c1e8692587d9044fde549214b Author: Milian Wolff <milian.wo...@kdab.com> AuthorDate: Thu, 19 Oct 2017 13:38:34 +0200 Committer: Arnaldo Carvalho de Melo <a...@redhat.com> Com

[tip:perf/core] perf report: Cache srclines for callchain nodes

Commit-ID: 21ac9d547fdde79c1e8692587d9044fde549214b Gitweb: https://git.kernel.org/tip/21ac9d547fdde79c1e8692587d9044fde549214b Author: Milian Wolff AuthorDate: Thu, 19 Oct 2017 13:38:34 +0200 Committer: Arnaldo Carvalho de Melo CommitDate: Wed, 25 Oct 2017 10:50:46 -0300 perf report

[tip:perf/core] perf report: Compare symbol name for inlined frames when sorting

Commit-ID: aa441895f7b4ff5394d4964a8e6749f3866e44d0 Gitweb: https://git.kernel.org/tip/aa441895f7b4ff5394d4964a8e6749f3866e44d0 Author: Milian Wolff <milian.wo...@kdab.com> AuthorDate: Mon, 9 Oct 2017 22:33:04 +0200 Committer: Arnaldo Carvalho de Melo <a...@redhat.com> Com

[tip:perf/core] perf report: Compare symbol name for inlined frames when sorting

Commit-ID: aa441895f7b4ff5394d4964a8e6749f3866e44d0 Gitweb: https://git.kernel.org/tip/aa441895f7b4ff5394d4964a8e6749f3866e44d0 Author: Milian Wolff AuthorDate: Mon, 9 Oct 2017 22:33:04 +0200 Committer: Arnaldo Carvalho de Melo CommitDate: Tue, 24 Oct 2017 09:59:56 -0300 perf report

[tip:perf/core] perf report: Cache failed lookups of inlined frames

Commit-ID: b38775cf7678d7715b35dded3dcfab66e244baae Gitweb: https://git.kernel.org/tip/b38775cf7678d7715b35dded3dcfab66e244baae Author: Milian Wolff <milian.wo...@kdab.com> AuthorDate: Thu, 19 Oct 2017 13:38:33 +0200 Committer: Arnaldo Carvalho de Melo <a...@redhat.com> Com

[tip:perf/core] perf report: Cache failed lookups of inlined frames

Commit-ID: b38775cf7678d7715b35dded3dcfab66e244baae Gitweb: https://git.kernel.org/tip/b38775cf7678d7715b35dded3dcfab66e244baae Author: Milian Wolff AuthorDate: Thu, 19 Oct 2017 13:38:33 +0200 Committer: Arnaldo Carvalho de Melo CommitDate: Wed, 25 Oct 2017 10:50:45 -0300 perf report

[tip:perf/core] perf report: Properly handle branch count in match_chain()

Commit-ID: bf36eb5c4b3ef0ebfb19b1a67a5fa5821e6c9fa7 Gitweb: https://git.kernel.org/tip/bf36eb5c4b3ef0ebfb19b1a67a5fa5821e6c9fa7 Author: Milian Wolff <milian.wo...@kdab.com> AuthorDate: Fri, 20 Oct 2017 12:14:47 -0300 Committer: Arnaldo Carvalho de Melo <a...@redhat.com> Com

[tip:perf/core] perf report: Properly handle branch count in match_chain()

Commit-ID: bf36eb5c4b3ef0ebfb19b1a67a5fa5821e6c9fa7 Gitweb: https://git.kernel.org/tip/bf36eb5c4b3ef0ebfb19b1a67a5fa5821e6c9fa7 Author: Milian Wolff AuthorDate: Fri, 20 Oct 2017 12:14:47 -0300 Committer: Arnaldo Carvalho de Melo CommitDate: Wed, 25 Oct 2017 10:50:37 -0300 perf report

[tip:perf/core] perf callchain: Compare symbol name for inlined frames when matching

Commit-ID: 9856240ad3269f2fdab0b2fa4400ef8aab792061 Gitweb: https://git.kernel.org/tip/9856240ad3269f2fdab0b2fa4400ef8aab792061 Author: Milian Wolff <milian.wo...@kdab.com> AuthorDate: Mon, 9 Oct 2017 22:33:03 +0200 Committer: Arnaldo Carvalho de Melo <a...@redhat.com> Com

[tip:perf/core] perf callchain: Compare symbol name for inlined frames when matching

Commit-ID: 9856240ad3269f2fdab0b2fa4400ef8aab792061 Gitweb: https://git.kernel.org/tip/9856240ad3269f2fdab0b2fa4400ef8aab792061 Author: Milian Wolff AuthorDate: Mon, 9 Oct 2017 22:33:03 +0200 Committer: Arnaldo Carvalho de Melo CommitDate: Tue, 24 Oct 2017 09:59:56 -0300 perf

[tip:perf/core] perf script: Mark inlined frames and do not print DSO for them

Commit-ID: 9628b56dc1240ce0faa3bd9b7a3390fa4451c59f Gitweb: https://git.kernel.org/tip/9628b56dc1240ce0faa3bd9b7a3390fa4451c59f Author: Milian Wolff <milian.wo...@kdab.com> AuthorDate: Mon, 9 Oct 2017 22:33:02 +0200 Committer: Arnaldo Carvalho de Melo <a...@redhat.com> Com

[tip:perf/core] perf script: Mark inlined frames and do not print DSO for them

Commit-ID: 9628b56dc1240ce0faa3bd9b7a3390fa4451c59f Gitweb: https://git.kernel.org/tip/9628b56dc1240ce0faa3bd9b7a3390fa4451c59f Author: Milian Wolff AuthorDate: Mon, 9 Oct 2017 22:33:02 +0200 Committer: Arnaldo Carvalho de Melo CommitDate: Tue, 24 Oct 2017 09:59:56 -0300 perf script

[tip:perf/core] perf report: Remove code to handle inline frames from browsers

Commit-ID: 2a704fc8db7b0080a67d9f4f4cb2a7bcaf79949d Gitweb: https://git.kernel.org/tip/2a704fc8db7b0080a67d9f4f4cb2a7bcaf79949d Author: Milian Wolff <milian.wo...@kdab.com> AuthorDate: Mon, 9 Oct 2017 22:32:55 +0200 Committer: Arnaldo Carvalho de Melo <a...@redhat.com> Com

[tip:perf/core] perf report: Remove code to handle inline frames from browsers

Commit-ID: 2a704fc8db7b0080a67d9f4f4cb2a7bcaf79949d Gitweb: https://git.kernel.org/tip/2a704fc8db7b0080a67d9f4f4cb2a7bcaf79949d Author: Milian Wolff AuthorDate: Mon, 9 Oct 2017 22:32:55 +0200 Committer: Arnaldo Carvalho de Melo CommitDate: Tue, 24 Oct 2017 09:59:55 -0300 perf report

[tip:perf/core] perf callchain: Create real callchain entries for inlined frames

Commit-ID: 11ea2515f32e783b9a7984c148e742c377383915 Gitweb: https://git.kernel.org/tip/11ea2515f32e783b9a7984c148e742c377383915 Author: Milian Wolff <milian.wo...@kdab.com> AuthorDate: Mon, 9 Oct 2017 22:32:59 +0200 Committer: Arnaldo Carvalho de Melo <a...@redhat.com> Com

[tip:perf/core] perf callchain: Create real callchain entries for inlined frames

Commit-ID: 11ea2515f32e783b9a7984c148e742c377383915 Gitweb: https://git.kernel.org/tip/11ea2515f32e783b9a7984c148e742c377383915 Author: Milian Wolff AuthorDate: Mon, 9 Oct 2017 22:32:59 +0200 Committer: Arnaldo Carvalho de Melo CommitDate: Tue, 24 Oct 2017 09:59:55 -0300 perf

[tip:perf/core] perf callchain: Mark inlined frames in output by " (inlined)" suffix

Commit-ID: 8932f8071cae8a12dfd5f49224ee176b0da4 Gitweb: https://git.kernel.org/tip/8932f8071cae8a12dfd5f49224ee176b0da4 Author: Milian Wolff <milian.wo...@kdab.com> AuthorDate: Mon, 9 Oct 2017 22:33:01 +0200 Committer: Arnaldo Carvalho de Melo <a...@redhat.com> Com

[tip:perf/core] perf callchain: Mark inlined frames in output by " (inlined)" suffix

Commit-ID: 8932f8071cae8a12dfd5f49224ee176b0da4 Gitweb: https://git.kernel.org/tip/8932f8071cae8a12dfd5f49224ee176b0da4 Author: Milian Wolff AuthorDate: Mon, 9 Oct 2017 22:33:01 +0200 Committer: Arnaldo Carvalho de Melo CommitDate: Tue, 24 Oct 2017 09:59:56 -0300 perf

[tip:perf/core] perf callchain: Store srcline in callchain_cursor_node

Commit-ID: 40a342cda2cd9bc8f7bf81c5ce1a141584760757 Gitweb: https://git.kernel.org/tip/40a342cda2cd9bc8f7bf81c5ce1a141584760757 Author: Milian Wolff <milian.wo...@kdab.com> AuthorDate: Mon, 9 Oct 2017 22:32:56 +0200 Committer: Arnaldo Carvalho de Melo <a...@redhat.com> Com

[tip:perf/core] perf report: Fall-back to function name comparison for -g srcline

Commit-ID: cbe50f61727f538f05e63186c2e0022182a3a28f Gitweb: https://git.kernel.org/tip/cbe50f61727f538f05e63186c2e0022182a3a28f Author: Milian Wolff <milian.wo...@kdab.com> AuthorDate: Mon, 9 Oct 2017 22:33:00 +0200 Committer: Arnaldo Carvalho de Melo <a...@redhat.com> Com

[tip:perf/core] perf callchain: Store srcline in callchain_cursor_node

Commit-ID: 40a342cda2cd9bc8f7bf81c5ce1a141584760757 Gitweb: https://git.kernel.org/tip/40a342cda2cd9bc8f7bf81c5ce1a141584760757 Author: Milian Wolff AuthorDate: Mon, 9 Oct 2017 22:32:56 +0200 Committer: Arnaldo Carvalho de Melo CommitDate: Tue, 24 Oct 2017 09:59:55 -0300 perf

[tip:perf/core] perf report: Fall-back to function name comparison for -g srcline

Commit-ID: cbe50f61727f538f05e63186c2e0022182a3a28f Gitweb: https://git.kernel.org/tip/cbe50f61727f538f05e63186c2e0022182a3a28f Author: Milian Wolff AuthorDate: Mon, 9 Oct 2017 22:33:00 +0200 Committer: Arnaldo Carvalho de Melo CommitDate: Tue, 24 Oct 2017 09:59:55 -0300 perf report

[tip:perf/core] perf callchain: Refactor inline_list to operate on symbols

Commit-ID: fea0cf842c7aa08950063264ab1cfbce4ba38c1b Gitweb: https://git.kernel.org/tip/fea0cf842c7aa08950063264ab1cfbce4ba38c1b Author: Milian Wolff <milian.wo...@kdab.com> AuthorDate: Mon, 9 Oct 2017 22:32:57 +0200 Committer: Arnaldo Carvalho de Melo <a...@redhat.com> Com

[tip:perf/core] perf callchain: Refactor inline_list to operate on symbols

Commit-ID: fea0cf842c7aa08950063264ab1cfbce4ba38c1b Gitweb: https://git.kernel.org/tip/fea0cf842c7aa08950063264ab1cfbce4ba38c1b Author: Milian Wolff AuthorDate: Mon, 9 Oct 2017 22:32:57 +0200 Committer: Arnaldo Carvalho de Melo CommitDate: Tue, 24 Oct 2017 09:59:55 -0300 perf

[tip:perf/core] perf callchain: Refactor inline_list to store srcline string directly

Commit-ID: 2be8832f3c51cf9e36a3e80ff57f4137505c2ba4 Gitweb: https://git.kernel.org/tip/2be8832f3c51cf9e36a3e80ff57f4137505c2ba4 Author: Milian Wolff <milian.wo...@kdab.com> AuthorDate: Mon, 9 Oct 2017 22:32:58 +0200 Committer: Arnaldo Carvalho de Melo <a...@redhat.com> Com

[tip:perf/core] perf callchain: Refactor inline_list to store srcline string directly

Commit-ID: 2be8832f3c51cf9e36a3e80ff57f4137505c2ba4 Gitweb: https://git.kernel.org/tip/2be8832f3c51cf9e36a3e80ff57f4137505c2ba4 Author: Milian Wolff AuthorDate: Mon, 9 Oct 2017 22:32:58 +0200 Committer: Arnaldo Carvalho de Melo CommitDate: Tue, 24 Oct 2017 09:59:55 -0300 perf

Re: [PATCH v6 6/6] perf util: use correct IP mapping to find srcline for hist entry

On Freitag, 20. Oktober 2017 07:15:33 CEST Namhyung Kim wrote: > Hi Milian, > > On Thu, Oct 19, 2017 at 12:54:18PM +0200, Milian Wolff wrote: > > On Mittwoch, 18. Oktober 2017 20:53:50 CEST Milian Wolff wrote: > > > When inline frame resolution is disabled, a b

Re: [PATCH v6 6/6] perf util: use correct IP mapping to find srcline for hist entry

On Freitag, 20. Oktober 2017 07:15:33 CEST Namhyung Kim wrote: > Hi Milian, > > On Thu, Oct 19, 2017 at 12:54:18PM +0200, Milian Wolff wrote: > > On Mittwoch, 18. Oktober 2017 20:53:50 CEST Milian Wolff wrote: > > > When inline frame resolution is disabled, a b

Re: [PATCH v7 0/5] generate full callchain cursor entries for inlined frames

On Montag, 23. Oktober 2017 21:04:53 CEST Arnaldo Carvalho de Melo wrote: > Em Fri, Oct 20, 2017 at 10:21:03PM +0200, Milian Wolff escreveu: > > On Freitag, 20. Oktober 2017 18:15:40 CEST Arnaldo Carvalho de Melo wrote: > > > Em Thu, Oct 19, 2017 at 01:38:31PM +0200, Mil

Re: [PATCH v7 0/5] generate full callchain cursor entries for inlined frames

On Montag, 23. Oktober 2017 21:04:53 CEST Arnaldo Carvalho de Melo wrote: > Em Fri, Oct 20, 2017 at 10:21:03PM +0200, Milian Wolff escreveu: > > On Freitag, 20. Oktober 2017 18:15:40 CEST Arnaldo Carvalho de Melo wrote: > > > Em Thu, Oct 19, 2017 at 01:38:31PM +0200, Mil

Re: [PATCH v7 0/5] generate full callchain cursor entries for inlined frames

On Montag, 23. Oktober 2017 16:29:35 CEST Arnaldo Carvalho de Melo wrote: > Em Fri, Oct 20, 2017 at 10:21:03PM +0200, Milian Wolff escreveu: > > On Freitag, 20. Oktober 2017 18:15:40 CEST Arnaldo Carvalho de Melo wrote: > > > Em Thu, Oct 19, 2017 at 01:38:31PM +0200, Mil

Re: [PATCH v7 0/5] generate full callchain cursor entries for inlined frames

On Montag, 23. Oktober 2017 16:29:35 CEST Arnaldo Carvalho de Melo wrote: > Em Fri, Oct 20, 2017 at 10:21:03PM +0200, Milian Wolff escreveu: > > On Freitag, 20. Oktober 2017 18:15:40 CEST Arnaldo Carvalho de Melo wrote: > > > Em Thu, Oct 19, 2017 at 01:38:31PM +0200, Mil

Re: [PATCH v7 1/5] perf report: properly handle branch count in match_chain

On Montag, 23. Oktober 2017 17:15:11 CEST Andi Kleen wrote: > Milian Wolff <milian.wo...@kdab.com> writes: > > perf record -b --call-graph dwarf > > perf report --branch-history --no-children --stdio > > > > I see predicted and iter values as before, so I think

Re: [PATCH v7 1/5] perf report: properly handle branch count in match_chain

On Montag, 23. Oktober 2017 17:15:11 CEST Andi Kleen wrote: > Milian Wolff writes: > > perf record -b --call-graph dwarf > > perf report --branch-history --no-children --stdio > > > > I see predicted and iter values as before, so I think nothing is breaking. >

Re: [PATCH v7 0/5] generate full callchain cursor entries for inlined frames

On Freitag, 20. Oktober 2017 18:15:40 CEST Arnaldo Carvalho de Melo wrote: > Em Thu, Oct 19, 2017 at 01:38:31PM +0200, Milian Wolff escreveu: > > This series of patches completely reworks the way inline frames are > > handled. Instead of querying for the inline

Re: [PATCH v7 0/5] generate full callchain cursor entries for inlined frames

On Freitag, 20. Oktober 2017 18:15:40 CEST Arnaldo Carvalho de Melo wrote: > Em Thu, Oct 19, 2017 at 01:38:31PM +0200, Milian Wolff escreveu: > > This series of patches completely reworks the way inline frames are > > handled. Instead of querying for the inline

Re: [PATCH v6 1/6] perf report: properly handle branch count in match_chain

On Freitag, 20. Oktober 2017 17:22:22 CEST Arnaldo Carvalho de Melo wrote: > Em Wed, Oct 18, 2017 at 08:53:45PM +0200, Milian Wolff escreveu: > > Some of the code paths I introduced before returned too early > > without running the code to handle a node's branch count. >

Re: [PATCH v6 1/6] perf report: properly handle branch count in match_chain

On Freitag, 20. Oktober 2017 17:22:22 CEST Arnaldo Carvalho de Melo wrote: > Em Wed, Oct 18, 2017 at 08:53:45PM +0200, Milian Wolff escreveu: > > Some of the code paths I introduced before returned too early > > without running the code to handle a node's branch count. >

Re: [PATCH v6 1/6] perf report: properly handle branch count in match_chain

On Freitag, 20. Oktober 2017 12:21:35 CEST Milian Wolff wrote: > On Donnerstag, 19. Oktober 2017 17:01:08 CEST Namhyung Kim wrote: > > Hi Andi, > > > > On Thu, Oct 19, 2017 at 06:55:19AM -0700, Andi Kleen wrote: > > > On Thu, Oct 19, 2017 at 12:59:

Re: [PATCH v6 1/6] perf report: properly handle branch count in match_chain

On Freitag, 20. Oktober 2017 12:21:35 CEST Milian Wolff wrote: > On Donnerstag, 19. Oktober 2017 17:01:08 CEST Namhyung Kim wrote: > > Hi Andi, > > > > On Thu, Oct 19, 2017 at 06:55:19AM -0700, Andi Kleen wrote: > > > On Thu, Oct 19, 2017 at 12:59:

Re: [PATCH v6 1/6] perf report: properly handle branch count in match_chain

On Donnerstag, 19. Oktober 2017 17:01:08 CEST Namhyung Kim wrote: > Hi Andi, > > On Thu, Oct 19, 2017 at 06:55:19AM -0700, Andi Kleen wrote: > > On Thu, Oct 19, 2017 at 12:59:14PM +0200, Milian Wolff wrote: > > > On Donnerstag, 19. Oktober 2017 00:41:04 CEST Andi Kleen wro

Re: [PATCH v6 1/6] perf report: properly handle branch count in match_chain

On Donnerstag, 19. Oktober 2017 17:01:08 CEST Namhyung Kim wrote: > Hi Andi, > > On Thu, Oct 19, 2017 at 06:55:19AM -0700, Andi Kleen wrote: > > On Thu, Oct 19, 2017 at 12:59:14PM +0200, Milian Wolff wrote: > > > On Donnerstag, 19. Oktober 2017 00:41:04 CEST Andi Kleen wro

Re: [PATCH v7 1/5] perf report: properly handle branch count in match_chain

On Donnerstag, 19. Oktober 2017 13:38:32 CEST Milian Wolff wrote: > Some of the code paths I introduced before returned too early > without running the code to handle a node's branch count. > By refactoring match_chain to only have one exit point, this > can be remedied. No

Re: [PATCH v7 1/5] perf report: properly handle branch count in match_chain

On Donnerstag, 19. Oktober 2017 13:38:32 CEST Milian Wolff wrote: > Some of the code paths I introduced before returned too early > without running the code to handle a node's branch count. > By refactoring match_chain to only have one exit point, this > can be remedied. No

[PATCH v7 1/5] perf report: properly handle branch count in match_chain

Namhyung Kim <namhy...@kernel.org> Cc: Peter Zijlstra <a.p.zijls...@chello.nl> Cc: Yao Jin <yao@linux.intel.com> Cc: Ravi Bangoria <ravi.bango...@linux.vnet.ibm.com> Signed-off-by: Milian Wolff <milian.wo...@kdab.com> --- tools/perf/util/callchain.c | 132 +

[PATCH v7 1/5] perf report: properly handle branch count in match_chain

Cc: Ravi Bangoria Signed-off-by: Milian Wolff --- tools/perf/util/callchain.c | 132 +++- 1 file changed, 70 insertions(+), 62 deletions(-) diff --git a/tools/perf/util/callchain.c b/tools/perf/util/callchain.c index 35a920f09503..8901a95f2880 100644

[PATCH v7 0/5] generate full callchain cursor entries for inlined frames

n the feedback by Namhyung. v2 fixes some issues reported by Namhyung or found by me in further testing, adds caching and enables inline frames by default. Milian Wolff (5): perf report: properly handle branch count in match_chain perf report: cache failed lookups of inlined frames perf

[PATCH v7 0/5] generate full callchain cursor entries for inlined frames

root properly. v3 splits the initial patch up into two to simplify reviewing. It also adds a comment to clarify the lifetime handling of fake symbols and aliased non-fake symbols, based on the feedback by Namhyung. v2 fixes some issues reported by Namhyung or found by me in further testing, adds

[PATCH v7 3/5] perf report: cache srclines for callchain nodes

l.com> Cc: Namhyung Kim <namhy...@kernel.org> Cc: Peter Zijlstra <a.p.zijls...@chello.nl> Cc: Yao Jin <yao@linux.intel.com> Signed-off-by: Milian Wolff <milian.wo...@kdab.com> --- tools/perf/util/dso.c | 2 ++ tools/perf/util/dso.h | 1 + tools/perf/util/mac

[PATCH v7 3/5] perf report: cache srclines for callchain nodes

: Yao Jin Signed-off-by: Milian Wolff --- tools/perf/util/dso.c | 2 ++ tools/perf/util/dso.h | 1 + tools/perf/util/machine.c | 17 +--- tools/perf/util/srcline.c | 66 +++ tools/perf/util/srcline.h | 7 + 5 files changed, 90

[PATCH v7 2/5] perf report: cache failed lookups of inlined frames

.org> Cc: Peter Zijlstra <a.p.zijls...@chello.nl> Cc: Yao Jin <yao@linux.intel.com> Signed-off-by: Milian Wolff <milian.wo...@kdab.com> --- tools/perf/util/machine.c | 15 +++ tools/perf/util/srcline.c | 16 +--- 2 files changed, 8 insertions(+), 23 deleti

[PATCH v7 2/5] perf report: cache failed lookups of inlined frames

#1.66% of all branches ( +- 0.19% ) 0.114222393 seconds time elapsed ( +- 1.19% ) ~ Cc: Arnaldo Carvalho de Melo Cc: David Ahern Cc: Namhyung Kim Cc: Peter Zijlstra Cc: Yao Jin Signed-off-by: Milian Wolff --- tools

[PATCH v7 4/5] perf report: use srcline from callchain for hist entries

o Carvalho de Melo <a...@redhat.com> Cc: David Ahern <dsah...@gmail.com> Cc: Namhyung Kim <namhy...@kernel.org> Cc: Peter Zijlstra <a.p.zijls...@chello.nl> Cc: Yao Jin <yao@linux.intel.com> Signed-off-by: Milian Wolff <milian.wo...@kdab.com> --- tools/per

[PATCH v7 5/5] perf util: enable handling of inlined frames by default

.org> Cc: Peter Zijlstra <a.p.zijls...@chello.nl> Cc: Yao Jin <yao@linux.intel.com> Cc: Ingo Molnar <mi...@kernel.org> Suggested-by: Ingo Molnar <mi...@kernel.org> Signed-off-by: Milian Wolff <milian.wo...@kdab.com> --- tools/perf/Documentation/perf-report.txt |

[PATCH v7 4/5] perf report: use srcline from callchain for hist entries

hypot_finite+163 4.13% 0.00% [.] __hypot_finite __hypot_finite+18446603487892193443 ... ~ Cc: Arnaldo Carvalho de Melo Cc: David Ahern Cc: Namhyung Kim Cc: Peter Zijlstra Cc: Yao Jin Signed-off-by: Milian Wolff --- t

[PATCH v7 5/5] perf util: enable handling of inlined frames by default

Molnar Signed-off-by: Milian Wolff --- tools/perf/Documentation/perf-report.txt | 3 ++- tools/perf/Documentation/perf-script.txt | 3 ++- tools/perf/util/symbol.c | 1 + 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/tools/perf/Documentation/perf-report.txt b

Re: [PATCH v6 1/6] perf report: properly handle branch count in match_chain

On Donnerstag, 19. Oktober 2017 00:41:04 CEST Andi Kleen wrote: > Milian Wolff <milian.wo...@kdab.com> writes: > > +static enum match_result match_address_dso(struct dso *left_dso, u64 > > left_ip, + struct dso *right_d

Re: [PATCH v6 1/6] perf report: properly handle branch count in match_chain

On Donnerstag, 19. Oktober 2017 00:41:04 CEST Andi Kleen wrote: > Milian Wolff writes: > > +static enum match_result match_address_dso(struct dso *left_dso, u64 > > left_ip, + struct dso *right_dso, u64 > > right_ip) > > +{ > &

Re: [PATCH v6 6/6] perf util: use correct IP mapping to find srcline for hist entry

On Mittwoch, 18. Oktober 2017 20:53:50 CEST Milian Wolff wrote: > When inline frame resolution is disabled, a bogus srcline is obtained > for hist entries: > > ~ > $ perf report -s sym,srcline --no-inline --stdio -g none > 95.21% 0.00% [.]

Re: [PATCH v6 6/6] perf util: use correct IP mapping to find srcline for hist entry

On Mittwoch, 18. Oktober 2017 20:53:50 CEST Milian Wolff wrote: > When inline frame resolution is disabled, a bogus srcline is obtained > for hist entries: > > ~ > $ perf report -s sym,srcline --no-inline --stdio -g none > 95.21% 0.00% [.]

[PATCH v6 2/6] perf report: cache failed lookups of inlined frames

.org> Cc: Peter Zijlstra <a.p.zijls...@chello.nl> Cc: Yao Jin <yao@linux.intel.com> Signed-off-by: Milian Wolff <milian.wo...@kdab.com> --- tools/perf/util/machine.c | 15 +++ tools/perf/util/srcline.c | 16 +--- 2 files changed, 8 insertions(+), 23 deleti

[PATCH v6 2/6] perf report: cache failed lookups of inlined frames

#1.66% of all branches ( +- 0.19% ) 0.114222393 seconds time elapsed ( +- 1.19% ) ~ Cc: Arnaldo Carvalho de Melo Cc: David Ahern Cc: Namhyung Kim Cc: Peter Zijlstra Cc: Yao Jin Signed-off-by: Milian Wolff --- tools

[PATCH v6 5/6] perf util: enable handling of inlined frames by default

.org> Cc: Peter Zijlstra <a.p.zijls...@chello.nl> Cc: Yao Jin <yao@linux.intel.com> Cc: Ingo Molnar <mi...@kernel.org> Suggested-by: Ingo Molnar <mi...@kernel.org> Signed-off-by: Milian Wolff <milian.wo...@kdab.com> --- tools/perf/Documentation/perf-report.txt |

[PATCH v6 5/6] perf util: enable handling of inlined frames by default

Molnar Signed-off-by: Milian Wolff --- tools/perf/Documentation/perf-report.txt | 3 ++- tools/perf/Documentation/perf-script.txt | 3 ++- tools/perf/util/symbol.c | 1 + 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/tools/perf/Documentation/perf-report.txt b

[PATCH v6 4/6] perf report: use srcline from callchain for hist entries

o Carvalho de Melo <a...@redhat.com> Cc: David Ahern <dsah...@gmail.com> Cc: Namhyung Kim <namhy...@kernel.org> Cc: Peter Zijlstra <a.p.zijls...@chello.nl> Cc: Yao Jin <yao@linux.intel.com> Signed-off-by: Milian Wolff <milian.wo...@kdab.com> --- tools/per

[PATCH v6 4/6] perf report: use srcline from callchain for hist entries

hypot_finite+163 4.13% 0.00% [.] __hypot_finite __hypot_finite+18446603487892193443 ... ~ Cc: Arnaldo Carvalho de Melo Cc: David Ahern Cc: Namhyung Kim Cc: Peter Zijlstra Cc: Yao Jin Signed-off-by: Milian Wolff --- t

[PATCH v6 1/6] perf report: properly handle branch count in match_chain

Namhyung Kim <namhy...@kernel.org> Cc: Peter Zijlstra <a.p.zijls...@chello.nl> Cc: Yao Jin <yao@linux.intel.com> Cc: Ravi Bangoria <ravi.bango...@linux.vnet.ibm.com> Signed-off-by: Milian Wolff <milian.wo...@kdab.com> --- tools/perf/util/callchain.c | 129 +

[PATCH v6 6/6] perf util: use correct IP mapping to find srcline for hist entry

Carvalho de Melo <a...@redhat.com> Cc: Namhyung Kim <namhy...@kernel.org> Cc: Yao Jin <yao@linux.intel.com> Cc: Jiri Olsa <jo...@redhat.com> Signed-off-by: Milian Wolff <milian.wo...@kdab.com> Note how most of the large offset values are now gone. Most notably, we g

[PATCH v6 1/6] perf report: properly handle branch count in match_chain

Cc: Ravi Bangoria Signed-off-by: Milian Wolff --- tools/perf/util/callchain.c | 129 +++- 1 file changed, 67 insertions(+), 62 deletions(-) diff --git a/tools/perf/util/callchain.c b/tools/perf/util/callchain.c index 35a920f09503..ac767957fd9c 100644

[PATCH v6 6/6] perf util: use correct IP mapping to find srcline for hist entry

: Yao Jin Cc: Jiri Olsa Signed-off-by: Milian Wolff Note how most of the large offset values are now gone. Most notably, we get proper srcline resolution for the random.h and complex headers. --- tools/perf/util/sort.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/

[PATCH v6 0/6] generate full callchain cursor entries for inlined frames

two to simplify reviewing. It also adds a comment to clarify the lifetime handling of fake symbols and aliased non-fake symbols, based on the feedback by Namhyung. v2 fixes some issues reported by Namhyung or found by me in further testing, adds caching and enables inline frames by default.

[PATCH v6 0/6] generate full callchain cursor entries for inlined frames

and aliased non-fake symbols, based on the feedback by Namhyung. v2 fixes some issues reported by Namhyung or found by me in further testing, adds caching and enables inline frames by default. Milian Wolff (6): perf report: properly handle branch count in match_chain perf report: cache failed

[PATCH v6 3/6] perf report: cache srclines for callchain nodes

l.com> Cc: Namhyung Kim <namhy...@kernel.org> Cc: Peter Zijlstra <a.p.zijls...@chello.nl> Cc: Yao Jin <yao@linux.intel.com> Signed-off-by: Milian Wolff <milian.wo...@kdab.com> --- tools/perf/util/dso.c | 2 ++ tools/perf/util/dso.h | 1 + tools/perf/util/mac

[PATCH v6 3/6] perf report: cache srclines for callchain nodes

: Yao Jin Signed-off-by: Milian Wolff --- tools/perf/util/dso.c | 2 ++ tools/perf/util/dso.h | 1 + tools/perf/util/machine.c | 17 +--- tools/perf/util/srcline.c | 66 +++ tools/perf/util/srcline.h | 7 + 5 files changed, 90

Re: [PATCH v5 11/16] perf report: properly handle branch count in match_chain

On Montag, 16. Oktober 2017 06:18:17 CEST ravi wrote: > On Friday 13 October 2017 07:38 PM, Arnaldo Carvalho de Melo wrote: > > Em Fri, Oct 13, 2017 at 10:39:03AM -0300, Arnaldo Carvalho de Melo escreveu: > >> Em Mon, Oct 09, 2017 at 10:33:05PM +0200, Milian Wolff escreveu: >

Re: [PATCH v5 11/16] perf report: properly handle branch count in match_chain

On Montag, 16. Oktober 2017 06:18:17 CEST ravi wrote: > On Friday 13 October 2017 07:38 PM, Arnaldo Carvalho de Melo wrote: > > Em Fri, Oct 13, 2017 at 10:39:03AM -0300, Arnaldo Carvalho de Melo escreveu: > >> Em Mon, Oct 09, 2017 at 10:33:05PM +0200, Milian Wolff escreveu: >

Re: [PATCH v5 11/16] perf report: properly handle branch count in match_chain

On Freitag, 13. Oktober 2017 16:08:34 CEST Arnaldo Carvalho de Melo wrote: > Em Fri, Oct 13, 2017 at 10:39:03AM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Mon, Oct 09, 2017 at 10:33:05PM +0200, Milian Wolff escreveu: > > > Some of the code paths I introduced before

Re: [PATCH v5 11/16] perf report: properly handle branch count in match_chain

On Freitag, 13. Oktober 2017 16:08:34 CEST Arnaldo Carvalho de Melo wrote: > Em Fri, Oct 13, 2017 at 10:39:03AM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Mon, Oct 09, 2017 at 10:33:05PM +0200, Milian Wolff escreveu: > > > Some of the code paths I introduced before

Re: [PATCH v5 16/16] perf util: use correct IP mapping to find srcline for hist entry

On Dienstag, 10. Oktober 2017 06:49:54 CEST Namhyung Kim wrote: > Hi Milian, > > On Mon, Oct 09, 2017 at 10:33:10PM +0200, Milian Wolff wrote: > > When inline frame resolution is disabled, a bogus srcline is obtained > > for hist entries: > > > > ~

Re: [PATCH v5 16/16] perf util: use correct IP mapping to find srcline for hist entry

On Dienstag, 10. Oktober 2017 06:49:54 CEST Namhyung Kim wrote: > Hi Milian, > > On Mon, Oct 09, 2017 at 10:33:10PM +0200, Milian Wolff wrote: > > When inline frame resolution is disabled, a bogus srcline is obtained > > for hist entries: > > > > ~

[PATCH v5 00/16] generate full callchain cursor entries for inlined frames

etime handling of fake symbols and aliased non-fake symbols, based on the feedback by Namhyung. v2 fixes some issues reported by Namhyung or found by me in further testing, adds caching and enables inline frames by default. Milian Wolff (16): perf report: remove code to handle inline frames fr

[PATCH v5 00/16] generate full callchain cursor entries for inlined frames

e issues reported by Namhyung or found by me in further testing, adds caching and enables inline frames by default. Milian Wolff (16): perf report: remove code to handle inline frames from browsers perf util: store srcline in callchain_cursor_node perf util: refactor inline_list to operate on sym

[PATCH v5 03/16] perf util: refactor inline_list to operate on symbols

inline_node__delete. Cc: Jiri Olsa <jo...@redhat.com> Cc: Arnaldo Carvalho de Melo <a...@redhat.com> Cc: David Ahern <dsah...@gmail.com> Cc: Namhyung Kim <namhy...@kernel.org> Cc: Peter Zijlstra <a.p.zijls...@chello.nl> Cc: Yao Jin <yao@linux.intel.com> Signed-off-by:

[PATCH v5 03/16] perf util: refactor inline_list to operate on symbols

inline_node__delete. Cc: Jiri Olsa Cc: Arnaldo Carvalho de Melo Cc: David Ahern Cc: Namhyung Kim Cc: Peter Zijlstra Cc: Yao Jin Signed-off-by: Milian Wolff --- tools/perf/util/srcline.c | 93 --- tools/perf/util/srcline.h | 7 +++- tools/perf/util/symbol.h

[PATCH v5 04/16] perf util: refactor inline_list to store srcline string directly

t;yao@linux.intel.com> Signed-off-by: Milian Wolff <milian.wo...@kdab.com> --- tools/perf/util/srcline.c | 54 +++ tools/perf/util/srcline.h | 3 +-- 2 files changed, 41 insertions(+), 16 deletions(-) diff --git a/tools/perf/util/s

[PATCH v5 01/16] perf report: remove code to handle inline frames from browsers

.p.zijls...@chello.nl> Cc: Yao Jin <yao@linux.intel.com> Signed-off-by: Milian Wolff <milian.wo...@kdab.com> --- tools/perf/ui/browsers/hists.c | 180 +++- tools/perf/ui/stdio/hist.c | 77 + tools/perf/util/evsel_fprintf.c |

[PATCH v5 04/16] perf util: refactor inline_list to store srcline string directly

inline node and reuse it for different callchain entries. Cc: Jiri Olsa Cc: Arnaldo Carvalho de Melo Cc: David Ahern Cc: Namhyung Kim Cc: Peter Zijlstra Cc: Yao Jin Signed-off-by: Milian Wolff --- tools/perf/util/srcline.c | 54 +++ tools/perf/util

[PATCH v5 01/16] perf report: remove code to handle inline frames from browsers

The follow-up commits will make inline frames first-class citizens in the callchain, thereby obsoleting all of this special code. Cc: Arnaldo Carvalho de Melo Cc: David Ahern Cc: Namhyung Kim Cc: Peter Zijlstra Cc: Yao Jin Signed-off-by: Milian Wolff --- tools/perf/ui/browsers/hists.c

[PATCH v5 05/16] perf report: create real callchain entries for inlined frames

h...@gmail.com> Cc: Namhyung Kim <namhy...@kernel.org> Cc: Peter Zijlstra <a.p.zijls...@chello.nl> Cc: Yao Jin <yao....@linux.intel.com> Signed-off-by: Milian Wolff <milian.wo...@kdab.com> --- tools/perf/util/dso.c | 5 + tools/perf/util/dso

[PATCH v5 08/16] perf script: mark inlined frames and do not print DSO for them

c: Namhyung Kim <namhy...@kernel.org> Cc: Peter Zijlstra <a.p.zijls...@chello.nl> Cc: Yao Jin <yao@linux.intel.com> Signed-off-by: Milian Wolff <milian.wo...@kdab.com> --- tools/perf/util/evsel_fprintf.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

[PATCH v5 05/16] perf report: create real callchain entries for inlined frames

off-by: Milian Wolff --- tools/perf/util/dso.c | 5 + tools/perf/util/dso.h | 1 + tools/perf/util/machine.c | 37 ++ tools/perf/util/srcline.c | 51 +++ tools/perf/util/srcline.h | 9 + 5 files chan

[PATCH v5 08/16] perf script: mark inlined frames and do not print DSO for them

Signed-off-by: Milian Wolff --- tools/perf/util/evsel_fprintf.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tools/perf/util/evsel_fprintf.c b/tools/perf/util/evsel_fprintf.c index f2c6c5ee11e8..5b9e89257aa7 100644 --- a/tools/perf/util/evsel_fprintf.c +++ b/tools

[PATCH v5 02/16] perf util: store srcline in callchain_cursor_node

of the srcline and handle deletion properly. Cc: Arnaldo Carvalho de Melo <a...@redhat.com> Cc: David Ahern <dsah...@gmail.com> Cc: Namhyung Kim <namhy...@kernel.org> Cc: Peter Zijlstra <a.p.zijls...@chello.nl> Cc: Yao Jin <yao@linux.intel.com> Signed-o

[PATCH v5 02/16] perf util: store srcline in callchain_cursor_node

of the srcline and handle deletion properly. Cc: Arnaldo Carvalho de Melo Cc: David Ahern Cc: Namhyung Kim Cc: Peter Zijlstra Cc: Yao Jin Signed-off-by: Milian Wolff --- tools/perf/util/callchain.c | 31 +-- tools/perf/util/callchain.h | 6 -- tools/perf

[PATCH v5 06/16] perf report: fall-back to function name comparison for -g srcline

| | | --0.85%--cabs ~ Cc: Arnaldo Carvalho de Melo <a...@redhat.com> Cc: David Ahern <dsah...@gmail.com> Cc: Namhyung Kim <namhy...@kernel.org> Cc: Peter Zijlstra <a.p.zijls...@chello.nl> Cc: Yao Jin <yao@linux.intel.com> Signed-off-by: Milian Wolff <milian.wo.

[PATCH v5 06/16] perf report: fall-back to function name comparison for -g srcline

| | | --0.85%--cabs ~ Cc: Arnaldo Carvalho de Melo Cc: David Ahern Cc: Namhyung Kim Cc: Peter Zijlstra Cc: Yao Jin Signed-off-by: Milian Wolff --- tools/perf/util/callchain.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/tools/perf/util/callchain.c b

[PATCH v5 09/16] perf report: compare symbol name for inlined frames when matching

std::abs (inlined) std::__complex_abs (inlined) ~ Cc: Arnaldo Carvalho de Melo <a...@redhat.com> Cc: David Ahern <dsah...@gmail.com> Cc: Namhyung Kim <namhy...@kernel.org> Cc: Peter Zijlstra <a.p.zijls...@chello.nl> Cc: Yao Jin <yao@linux.intel.com&

<    1   2   3   4   5   6   >