Hi Arun and Peter,
On Mon, 29 Oct 2012 14:36:01 -0700, Arun Sharma wrote:
On 10/29/12 12:08 PM, Peter Zijlstra wrote:
Right, so I tried this and I would expect the callchains to be inverted
too, so that when I expand say 'c' I would see that 'c' calls 'b' for
100% which calls 'a' for 100%.
Hi David,
On Mon, 29 Oct 2012 10:31:41 -0600, David Ahern wrote:
stdio based implementations of ui_ based functions for the python
library. Needed for patch 3 - consolidating open counters method.
How about adding ui/util.c to the python-ext-sources?
Thanks,
Namhyung
--
To unsubscribe
On Mon, 29 Oct 2012 10:31:42 -0600, David Ahern wrote:
Changes top code to use the perf_record_opts struct. Stepping stone to
consolidating the open counters code.
Maybe time to rename perf_record_opts to perf_open_opts or just perf_opts?
Thanks,
Namhyung
--
To unsubscribe from this list: send
Hi Dhaval,
On Mon, 29 Oct 2012 12:45:53 -0400, Dhaval Giani wrote:
On Mon, Oct 29, 2012 at 12:01 PM, Dhaval Giani dhaval.gi...@gmail.com wrote:
Hi,
As part of a class assignment I have to collect some performance
statistics. In order to do so I run
perf record -g the program I have to
Hi Stephane,
On Mon, 29 Oct 2012 16:15:46 +0100, Stephane Eranian wrote:
+ /*
+ * use the mapping table for bit 0-15
+ */
+ val = pebs_data_source[dse.ld_dse];
I guess you meant bit 0-3, right?
Thanks,
Namhyung
--
To unsubscribe from this list: send the line unsubscribe
On Mon, 29 Oct 2012 16:15:48 +0100, Stephane Eranian wrote:
This patch adds support for PEBS Precise Store
which is available on Intel Sandy Bridge and
Ivy Bridge processors.
To use Precise store, the proper PEBS event
must be used: mem_trans_retired:precise_stores.
For the perf tool, the
On Mon, 29 Oct 2012 16:15:49 +0100, Stephane Eranian wrote:
This patch adds the sorting and histogram support
functions to enable profiling of memory accesses.
The following sorting orders are added:
- symbol_daddr: data address symbol (or raw address)
- dso_daddr: data address shared
On Mon, 29 Oct 2012 16:15:50 +0100, Stephane Eranian wrote:
This patch adds the --mem-mode option to perf report.
This mode requires a perf.data file created with memory
access samples.
Signed-off-by: Stephane Eranian eran...@google.com
---
[snip]
+ cost = mi-cost;
+ if (!cost)
+
On Mon, 29 Oct 2012 16:15:52 +0100, Stephane Eranian wrote:
This new command is a wrapper on top of perf record and
perf report to make it easier to configure for memory
access profiling.
So this new command will be run only on speicific (PEBS 2?) Intel
machines, right? Is there anything we
On Tue, 30 Oct 2012 08:05:45 -0400, Dhaval Giani wrote:
On Tue, Oct 30, 2012 at 3:42 AM, Namhyung Kim namhy...@kernel.org wrote:
Hi Dhaval,
On Mon, 29 Oct 2012 12:45:53 -0400, Dhaval Giani wrote:
On Mon, Oct 29, 2012 at 12:01 PM, Dhaval Giani dhaval.gi...@gmail.com
wrote:
Hi,
As part
On Tue, 30 Oct 2012 08:53:38 -0700, Arnaldo Carvalho de Melo wrote:
Em Tue, Oct 30, 2012 at 08:45:28AM -0600, David Ahern escreveu:
On 10/30/12 1:24 AM, Namhyung Kim wrote:
On Mon, 29 Oct 2012 10:31:41 -0600, David Ahern wrote:
stdio based implementations of ui_ based functions
On Tue, 30 Oct 2012 10:01:10 +0100, Ingo Molnar wrote:
* Peter Zijlstra a.p.zijls...@chello.nl wrote:
On Tue, 2012-10-30 at 15:59 +0900, Namhyung Kim wrote:
Yes, the callchain part needs to be improved. Peter's idea
indeed looks good to me too.
FWIW, I think this is exactly what
to
use the x86_64 host objdump if I were doing an annotate.
Could you test the below patch? It'd great if you can do it in a
reverse situation - using x86_64 target on i686 host.
From f0a9d6303f83452c8b6f81081abae8fdf9c81778 Mon Sep 17 00:00:00 2001
From: Namhyung Kim namhyung@lge.com
Date: Fri
Hi,
On Fri, 2 Nov 2012 00:20:56 +0100, Jiri Olsa wrote:
On Thu, Nov 01, 2012 at 05:38:01PM -0300, Arnaldo Carvalho de Melo wrote:
Ah, I just pushed perf/core with this patchset, thanks!
thanks,
jirka
When using current acme/perf/core, I got this:
namhyung@sejong:perf$ ./perf test -v
Hi Jiri,
Despite its way to acme's tree, I'd like to leave a few comments. :)
On Tue, 30 Oct 2012 23:01:43 +0100, Jiri Olsa wrote:
Separating test objects into 'tests' directory.
Signed-off-by: Jiri Olsa jo...@redhat.com
Cc: Arnaldo Carvalho de Melo a...@ghostprotocols.net
Cc: Peter
On Wed, 31 Oct 2012 15:52:47 +0100, Jiri Olsa wrote:
Adding automated test to check event's perf_event_attr values.
The idea is run perf session with kidnapping sys_perf_event_open
function. For each sys_perf_event_open call we store the
perf_event_attr data to the file to be checked later
On Fri, 02 Nov 2012 10:25:18 +0900, Namhyung Kim wrote:
namhyung@sejong:perf$ cat tests/attr/test-stat-group1
[config]
command = stat
args= -e '{cycles,instructions}' kill /dev/null 21
ret = 1
[event-1:base-stat]
fd=1
group_fd=-1
[event-2:base-stat]
fd=2
group_fd=1
config=1
Hi Feng,
On Thu, 1 Nov 2012 00:00:57 +0800, Feng Tang wrote:
This is for tui browser only. This patch will check the returned
key of tui hists browser, if it's K_SWITH_INPUT_DATA, then recreate
a session for the new selected data file.
You may want to add my previous patch [1] to your patch
From: Namhyung Kim namhyung@lge.com
David reported that perf report for i686 target data on x86_64 host
failed to work because it tried to find out cross-compiled objdump.
However objdump for x86_64 is compatible to i686 so that it doesn't
need to do it at all. To prevent similar artifacts
From: Namhyung Kim namhyung@lge.com
David reported that current perf report refused to run on a data file
captured from a different machine because of objdump. Since the
objdump tools won't be used unless annotation was requested, checking
its presence at init time doens't make sense
From: Namhyung Kim namhyung@lge.com
Currently various hist browser functions receive 3 arguments for
refreshing histogram but only used from a few places. Also it's only
for perf top command so that it can be NULL for other (and probably
most) cases. Pack them into a struct in order
cleanup patches
Namhyung Kim (6):
perf header: Add struct perf_session_env
perf header: Add -process callbacks to most of features
perf header: Use pre-processed session env when printing
perf header: Remove unused @feat arg from -process callback
perf kvm: Use perf_session_env
-by: Namhyung Kim namhy...@kernel.org
---
tools/perf/util/header.c | 207 +++
1 file changed, 66 insertions(+), 141 deletions(-)
diff --git a/tools/perf/util/header.c b/tools/perf/util/header.c
index d74b58d4105d..b2929d7a3d4e 100644
--- a/tools/perf/util/header.c
From: Namhyung Kim namhyung@lge.com
The struct perf_session_env will preserve environment information at
the time of perf record. It can be accessed anytime after parsing a
perf.data file if needed.
Signed-off-by: Namhyung Kim namhy...@kernel.org
---
tools/perf/util/header.h | 24
From: Namhyung Kim namhyung@lge.com
As the @feat arg is not used anywhere, get rid of it from the signature.
Cc: Stephane Eranian eran...@google.com
Cc: Robert Richter robert.rich...@amd.com
Signed-off-by: Namhyung Kim namhy...@kernel.org
---
tools/perf/util/header.c | 70
From now on each feature information is processed and saved in perf
header so that it can be used wherever needed. The BRANCH_STACK
feature is an exception since it needs nothing to be done.
Cc: Stephane Eranian eran...@google.com
Cc: Robert Richter robert.rich...@amd.com
Signed-off-by: Namhyung
From: Namhyung Kim namhyung@lge.com
Because its only user builtin-kvm::get_cpu_isa() has gone, It can be
removed safely. In general, we have the feature information in
perf_session_env already, no need to read it again.
Cc: David Ahern dsah...@gmail.com
Cc: Xiao Guangrong xiaoguangr
From: Namhyung Kim namhyung@lge.com
We have processed and saved cpuid information to perf_session_env
so reuse it for get_cpu_isa().
Cc: David Ahern dsah...@gmail.com
Cc: Xiao Guangrong xiaoguangr...@linux.vnet.ibm.com
Cc: Dong Hao haod...@linux.vnet.ibm.com
Signed-off-by: Namhyung Kim namhy
Hi,
On Mon, 24 Sep 2012 14:56:39 +1000, NeilBrown wrote:
Hi Jens,
this patch has been sitting in my -next tree for a little while and I was
hoping for it to go in for the next merge window.
It simply allows bio_split() to be used on bios without a payload, such as
'discard'.
Are you
On Mon, 24 Sep 2012 13:02:39 -0300, Arnaldo Carvalho de Melo wrote:
Em Mon, Sep 24, 2012 at 11:24:03PM +0800, Feng Tang escreveu:
Which looks more natural
It is there to avoid dragging the hist code into the python binding :-\
Hmm... it's so hairy. Can't we do better?
Thanks,
Namhyung
--
To
Hi Feng,
On Mon, 24 Sep 2012 23:24:05 +0800, Feng Tang wrote:
As suggested by Arnaldo, many scripts have their own usages and need
capture specific events or tracepoints, so only those scripts whose
targe events match the events in current perf data file should be
listed in the script browser
On Mon, 24 Sep 2012 23:24:09 +0800, Feng Tang wrote:
[snip]
+/* Return 0 if matched */
+int check_perf_magic(u64 magic)
+{
+ if (!memcmp(magic, __perf_magic1, sizeof(magic))
+ || magic == __perf_magic2
+ || magic == __perf_magic2_sw)
+ return 0;
+
+
On Mon, 24 Sep 2012 23:24:10 +0800, Feng Tang wrote:
[snip]
+ if (!check_perf_magic(magic)) {
+ options[nr_options] = strdup(name);
+ abs_path[nr_options++] = strdup(path);
Need to check return values.
+ }
+
From: Namhyung Kim namhyung@lge.com
The commit 6a6cd11d4e57 (perf test: Add test for the sched tracepoint
format fields) added following build error:
CC builtin-test.o
builtin-test.c: In function ‘perf_evsel__test_field’:
builtin-test.c:1216:6: error: variable ‘ret’ set but not used
From: Namhyung Kim namhyung@lge.com
The perf session environment information was saved (so allocated)
during perf_session__open, but was not freed. As free(3) handles NULL
pointer input properly it won't cause a issue for writing modes -
e.g. perf record.
Signed-off-by: Namhyung Kim namhy
On Mon, 24 Sep 2012 12:59:41 -0300, Arnaldo Carvalho de Melo wrote:
From: Arnaldo Carvalho de Melo a...@redhat.com
The pevent_parse_event() routine will parse a events/sys/tp/format file
and add an event_format instance to the pevent struct.
This patch introduces a pevent_parse_format()
On Mon, 24 Sep 2012 12:59:42 -0300, Arnaldo Carvalho de Melo wrote:
From: Arnaldo Carvalho de Melo a...@redhat.com
The existing constructor receives a perf_event_attr filled with the
event type and the config.
To reduce the boilerplate for tracepoints, provide a new constructor,
On Mon, 24 Sep 2012 12:59:43 -0300, Arnaldo Carvalho de Melo wrote:
From: Arnaldo Carvalho de Melo a...@redhat.com
So that we make sure the routines that do event format parsing are
working on at least two well know scheduler tracepoints.
It caused a build error and I posted a fix, please
Ping. Any comments for this?
Arun, thanks for testing!
Namhyung
On Thu, 13 Sep 2012 16:19:56 +0900, Namhyung Kim wrote:
Hi,
This is my first attempt to implement cumulative hist period report.
This work begins from Arun's SORT_INCLUSIVE patch [1] but I completely
rewrote it from scratch
Hi Arnaldo,
It seems it's not merged into your tree as I still can see this issue.
Would you consider applying?
Thanks,
Namhyung
On Fri, 14 Sep 2012 17:35:29 +0900, Namhyung Kim wrote:
From: Namhyung Kim namhyung@lge.com
The hist_entry__sort_snprintf() can return 0 if all of the sort
Hi Dong,
On Tue, 25 Sep 2012 16:21:25 +0800, Dong Hao wrote:
From: Dong Hao haod...@linux.vnet.ibm.com
The newest branch of perf/core should have compilation error!
Error log includes:
builtin-test.c: In function ‘perf_evsel__test_field’:
builtin-test.c:1216:6: error:
variable ‘ret’ set
-off-by: Namhyung Kim namhy...@kernel.org
---
tools/lib/traceevent/event-parse.c |8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/tools/lib/traceevent/event-parse.c
b/tools/lib/traceevent/event-parse.c
index 17c922145e88..47264b4652b9 100644
--- a/tools/lib/traceevent
2012-09-25 (화), 08:05 -0300, Arnaldo Carvalho de Melo:
Em Tue, Sep 25, 2012 at 10:25:13AM +0900, Namhyung Kim escreveu:
On Mon, 24 Sep 2012 13:02:39 -0300, Arnaldo Carvalho de Melo wrote:
Em Mon, Sep 24, 2012 at 11:24:03PM +0800, Feng Tang escreveu:
Which looks more natural
Hi Irina,
2012-09-23 (일), 22:27 +0300, Irina Tirdea:
From: Irina Tirdea irina.tir...@intel.com
The default name for objdump is objdump. For cross-compiling the name of
objdump will be different (e.g. arm-eabi-objdump in Android).
Set the default objdump name in the Makefile with
2012-09-25 (화), 10:30 -0300, Arnaldo Carvalho de Melo:
Em Tue, Sep 25, 2012 at 09:59:02PM +0900, Namhyung Kim escreveu:
Now I'm thinking of making it build-time test so that it can be executed
by make when specific argument is given - e.g. make C=1 ?
I think there is room for a 'make -C
From: Namhyung Kim namhyung@lge.com
Now the event grouping viewing requires collapsing all members in a
group to the leader. Thus hists__output_resort should be called after
collapsing all entries in evlist.
Cc: Jiri Olsa jo...@redhat.com
Cc: Stephane Eranian eran...@google.com
Signed-off
From: Namhyung Kim namhyung@lge.com
The struct he_stat is for separating out statistics data of a hist
entry. It is required for later changes.
It's just a mechanical change and should have no functional
differences.
Cc: Jiri Olsa jo...@redhat.com
Cc: Arun Sharma asha...@fb.com
Cc
From: Namhyung Kim namhyung@lge.com
Add a few of group-related field in struct perf_{evlist,evsel} so that
the group information in a evlist can be known easily.
Cc: Jiri Olsa jo...@redhat.com
Cc: Stephane Eranian eran...@google.com
Signed-off-by: Namhyung Kim namhy...@kernel.org
---
tools
From: Namhyung Kim namhyung@lge.com
Add --group option to enable event grouping. When enabled, all the
group members information will be shown together with the leader.
Cc: Jiri Olsa jo...@redhat.com
Cc: Stephane Eranian eran...@google.com
Signed-off-by: Namhyung Kim namhy...@kernel.org
From: Namhyung Kim namhyung@lge.com
When using event group viewer, it's better to show the group
description rather than the leader information alone.
If a leader did not contain any member, it's a non-group event.
Cc: Jiri Olsa jo...@redhat.com
Cc: Stephane Eranian eran...@google.com
Cc
From: Namhyung Kim namhyung@lge.com
Add and use he_stat__add_{period,stat} for calculating hist entry's
stat. It will be used for accumulated stats later as well.
Cc: Jiri Olsa jo...@redhat.com
Cc: Arun Sharma asha...@fb.com
Cc: Stephane Eranian eran...@google.com
Cc: Frederic Weisbecker
From: Namhyung Kim namhyung@lge.com
Since it is set to 1 for a new hist entry, no need to set to
separately. Move it to a template entry.
Cc: Jiri Olsa jo...@redhat.com
Cc: Arun Sharma asha...@fb.com
Cc: Stephane Eranian eran...@google.com
Cc: Frederic Weisbecker fweis...@gmail.com
Signed
From: Namhyung Kim namhyung@lge.com
Since we have all necessary information in the leader events and
other members don't, bypass members. Member events will be shown
along with the leaders if event group is enabled.
Cc: Jiri Olsa jo...@redhat.com
Cc: Stephane Eranian eran...@google.com
Cc
From: Namhyung Kim namhyung@lge.com
Show group members' overhead also when showing the leader's if event
group is enabled. At this time, only implemented overhead part in
order to ease review and other parts can be added later once this
patch settled down.
Cc: Jiri Olsa jo...@redhat.com
Cc
From: Namhyung Kim namhyung@lge.com
Show group members' overhead also when showing the leader's if event
group is enabled. At this time, only implemented overhead part in
order to ease review and other parts can be added later once this
patch settled down.
Cc: Jiri Olsa jo...@redhat.com
Cc
From: Namhyung Kim namhyung@lge.com
Show group members' overhead also when showing the leader's if event
group is enabled. At this time, only implemented overhead part in
order to ease review and other parts can be added later once this
patch settled down.
Cc: Jiri Olsa jo...@redhat.com
Cc
From: Namhyung Kim namhyung@lge.com
Like group_stats in hist_entry, total periods information also need to
be known to the leader.
Cc: Jiri Olsa jo...@redhat.com
Cc: Stephane Eranian eran...@google.com
Signed-off-by: Namhyung Kim namhy...@kernel.org
---
tools/perf/util/hist.c | 25
From: Namhyung Kim namhyung@lge.com
Save group relationship information so that it can be restored when
perf report is running.
Cc: Jiri Olsa jo...@redhat.com
Cc: Stephane Eranian eran...@google.com
Signed-off-by: Namhyung Kim namhy...@kernel.org
---
tools/perf/builtin-record.c | 3
/namhyung/linux-perf.git
perf/group-v2
Any comments are welcome, thanks,
Namhyung
v1 - v2:
* save group relation to header (Jiri)
* rebase on top of current acme/perf/core
[1] https://lkml.org/lkml/2012/7/24/81
[2] https://lkml.org/lkml/2012/9/13/81
Namhyung Kim (16):
perf hists: Add
From: Namhyung Kim namhyung@lge.com
To support viewing an event group together, collapse all of members in
the group to the leader's tree. The entries in the leaders' tree will
have group_stats to store those information.
This patch introduced an additional field 'event_group
From: Namhyung Kim namhyung@lge.com
During the event parsing, perf_evlist can have leader-only groups
which has nr_members as 1. Since they has no difference than a normal
non-group event don't count them as a event group.
Add perf_evlist__recalc_nr_groups to count actual group numbers.
Cc
From: Namhyung Kim namhyung@lge.com
So that the perf report won't lost the cpu utilization information.
For example, if there're two process that have same name.
$ perf report --stdio --showcpuutilization -s pid
[SNIP]
# Overhead sysus Command: Pid
On Thu, 27 Sep 2012 03:51:07 +0300, Irina Tirdea wrote:
On Tue, Sep 25, 2012 at 4:08 PM, Namhyung Kim namhy...@kernel.org wrote:
I thought about it twice and confused.
For cross-compiling, the resulting perf binary will run on target - say
Android - but the toolchain runs on host, right? So
Hi Feng,
On Wed, 26 Sep 2012 15:57:07 +0800, Feng Tang wrote:
On Tue, Sep 25, 2012 at 08:17:03AM -0300, Arnaldo Carvalho de Melo wrote:
Em Tue, Sep 25, 2012 at 04:20:53PM +0800, Feng Tang escreveu:
On Tue, 25 Sep 2012 11:11:21 +0900
Namhyung Kim namhy...@kernel.org wrote:
Ditto. Plus
Hi Arnaldo,
I've encountered a following error when building current acme/perf/core:
CC builtin-trace.o
builtin-trace.c:7:22: fatal error: libaudit.h: No such file or directory
compilation terminated.
make: *** [builtin-trace.o] Error 1
It'd better if you post patches to the list before
On Wed, 26 Sep 2012 16:56:41 +0800, Feng Tang wrote:
On Tue, 25 Sep 2012 10:47:03 +0900
Namhyung Kim namhy...@kernel.org wrote:
It can't recognize extra spaces, multiple events connected by commas,
event groups and probably more.. So I think it'd better if we can use
parse_events() here
On Thu, 27 Sep 2012 13:45:30 +0900, Namhyung Kim wrote:
It'd not that hard. How about using below (untested) patch?
Hmm... it won't work for some cases. Please ignore this.
Thanks,
Namhyung
diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c
index bf5d033ee1b4
From: Namhyung Kim namhyung@lge.com
The newly added trace command requires an external audit library.
However it can cause a build error because it's not checked whether
the libaudit is installed on system:
CC builtin-trace.o
builtin-trace.c:7:22: fatal error: libaudit.h: No such file
.
What do you think? Could you play with it for some time? :)
Thanks,
Namhyung
From 7068a43a4b450c60fdcc8a3916ce624c1ef2c9b2 Mon Sep 17 00:00:00 2001
From: Namhyung Kim namhyung@lge.com
Date: Thu, 27 Sep 2012 21:54:33 +0900
Subject: [RFC] perf tools: Try to find cross-built objdump path
From: Namhyung Kim namhyung@lge.com
As we have architecture information of saved perf.data file, we can
try to find cross-built objdump path.
The triplets are incomplete and maybe need some regexp works.
Cc: Irina Tirdea irina.tir...@gmail.com
Signed-off-by: Namhyung Kim namhy...@kernel.org
Hi Jiri,
On Thu, 27 Sep 2012 19:03:52 +0200, Jiri Olsa wrote:
diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c
index bf5d033ee1b4..3c52d0ab9270 100644
--- a/tools/perf/util/parse-events.c
+++ b/tools/perf/util/parse-events.c
@@ -830,6 +830,7 @@ int
Hi Frederic,
On Fri, 28 Sep 2012 01:01:48 +0200, Frederic Weisbecker wrote:
When Arun was working on this, I asked him to explore if it could make sense
to reuse
the -b, --branch-stack perf report option. Because after all, this feature
is doing
about the same than -b except it's using
: Ingo Molnar mi...@elte.hu
Cc: Paul Mackerras pau...@samba.org
Cc: Corey Ashford cjash...@linux.vnet.ibm.com
Cc: Frederic Weisbecker fweis...@gmail.com
Cc: Namhyung Kim namhy...@kernel.org
Signed-off-by: Jiri Olsa jo...@redhat.com
---
[snip]
+static int hpp__color_baseline(struct perf_hpp *hpp
On Thu, 27 Sep 2012 13:09:27 +0200, Jiri Olsa wrote:
Adding perf_hpp__column_enable function to enable/disable hists
column and removing diff command specific stuff 'need_pair and
show_displacement' from hpp code.
The diff command now enables/disables columns separately according
to the user
Hi all,
On Wed, 3 Oct 2012 12:29:28 +0200, Jiri Olsa wrote:
On Tue, Oct 02, 2012 at 06:45:36PM -0300, Arnaldo Carvalho de Melo wrote:
Em Tue, Oct 02, 2012 at 03:10:49PM +0200, Jiri Olsa escreveu:
On Tue, Oct 02, 2012 at 07:39:23AM -0400, Ben Guthro wrote:
Actually - I hadn't noticed these
Hi Frederic,
On Tue, 2 Oct 2012 17:54:10 +0200, Frederic Weisbecker wrote:
On Wed, Oct 03, 2012 at 12:21:32AM +0900, Namhyung Kim wrote:
The '_get_comp_words_by_ref' function is available from the bash
completion v1.2 so that earlier version emits following warning:
$ perf
From: Namhyung Kim namhyung@lge.com
Currently tracepoint events cannot be completed because they contain a
colon (:) character. The colon is considered as a word separator when
bash completion is done - variable COMP_WORDBREAKS contains colon - so
if a word being completed contains a colon
On Thu, 27 Sep 2012 13:09:35 +0200, Jiri Olsa wrote:
Currently in 'Baseline' and 'Period Base' columns zero values are
displayed in case no pair is found for the sample. This might be
confusing, using empty space instead.
[snip]
@@ -246,8 +249,12 @@ static int hpp__entry_period_baseline(struct
diff displacement possition info
perf hists: Separate overhead and baseline columns
perf tools: Removing hists pair argument from output path
perf tool: Add hpp interface to enable/disable hpp column
perf diff: Removing the total_period argument from output code
Namhyung Kim (14):
perf hists
a.p.zijls...@chello.nl
Cc: Ingo Molnar mi...@elte.hu
Cc: Paul Mackerras pau...@samba.org
Cc: Corey Ashford cjash...@linux.vnet.ibm.com
Cc: Frederic Weisbecker fweis...@gmail.com
Cc: Namhyung Kim namhy...@kernel.org
Signed-off-by: Jiri Olsa jo...@redhat.com
Signed-off-by: Namhyung Kim namhy
Carvalho de Melo a...@ghostprotocols.net
Cc: Peter Zijlstra a.p.zijls...@chello.nl
Cc: Ingo Molnar mi...@elte.hu
Cc: Paul Mackerras pau...@samba.org
Cc: Corey Ashford cjash...@linux.vnet.ibm.com
Cc: Frederic Weisbecker fweis...@gmail.com
Cc: Namhyung Kim namhy...@kernel.org
Signed-off-by: Jiri Olsa jo
...@chello.nl
Cc: Ingo Molnar mi...@elte.hu
Cc: Paul Mackerras pau...@samba.org
Cc: Corey Ashford cjash...@linux.vnet.ibm.com
Cc: Frederic Weisbecker fweis...@gmail.com
Cc: Namhyung Kim namhy...@kernel.org
Signed-off-by: Jiri Olsa jo...@redhat.com
Signed-off-by: Namhyung Kim namhy...@kernel.org
---
tools
Weisbecker fweis...@gmail.com
Cc: Namhyung Kim namhy...@kernel.org
Signed-off-by: Jiri Olsa jo...@redhat.com
Signed-off-by: Namhyung Kim namhy...@kernel.org
---
tools/perf/builtin-diff.c | 18 +-
tools/perf/builtin-report.c|2 +-
tools/perf/ui/browsers/hists.c |2
From: Namhyung Kim namhyung@lge.com
The struct he_stat is for separating out statistics data of a hist
entry. It is required for later changes.
It's just a mechanical change and should have no functional
differences.
Cc: Jiri Olsa jo...@redhat.com
Cc: Arun Sharma asha...@fb.com
Cc
From: Namhyung Kim namhyung@lge.com
Add and use he_stat__add_{period,stat} for calculating hist entry's
stat. It will be used for accumulated stats later as well.
Cc: Jiri Olsa jo...@redhat.com
Cc: Arun Sharma asha...@fb.com
Cc: Stephane Eranian eran...@google.com
Cc: Frederic Weisbecker
From: Namhyung Kim namhyung@lge.com
Show group members' overhead also when showing the leader's if event
group is enabled. At this time, only implemented overhead part in
order to ease review and other parts can be added later once this
patch settled down.
Cc: Jiri Olsa jo...@redhat.com
Cc
From: Namhyung Kim namhyung@lge.com
When using event group viewer, it's better to show the group
description rather than the leader information alone.
If a leader did not contain any member, it's a non-group event.
Cc: Jiri Olsa jo...@redhat.com
Cc: Stephane Eranian eran...@google.com
Cc
From: Namhyung Kim namhyung@lge.com
Add a few of group-related field in struct perf_{evlist,evsel} so that
the group information in a evlist can be known easily. It only counts
groups which have more than 1 members since leader-only groups are
treated as non-group events.
Cc: Jiri Olsa jo
From: Namhyung Kim namhyung@lge.com
To support viewing an event group together, collapse all of members in
the group to the leader's tree. The entries in the leaders' tree will
have group_stats to store those information.
This patch introduced an additional field 'event_group
From: Namhyung Kim namhyung@lge.com
Now the event grouping viewing requires collapsing all members in a
group to the leader. Thus hists__output_resort should be called after
collapsing all entries in evlist.
Cc: Jiri Olsa jo...@redhat.com
Cc: Stephane Eranian eran...@google.com
Signed-off
From: Namhyung Kim namhyung@lge.com
Show group members' overhead also when showing the leader's if event
group is enabled. At this time, only implemented overhead part in
order to ease review and other parts can be added later once this
patch settled down.
Cc: Jiri Olsa jo...@redhat.com
Cc
From: Namhyung Kim namhyung@lge.com
Add --group option to enable event grouping. When enabled, all the
group members information will be shown together with the leader.
Cc: Jiri Olsa jo...@redhat.com
Cc: Stephane Eranian eran...@google.com
Signed-off-by: Namhyung Kim namhy...@kernel.org
From: Namhyung Kim namhyung@lge.com
Since we have all necessary information in the leader events and
other members don't, bypass members. Member events will be shown
along with the leaders if event group is enabled.
Cc: Jiri Olsa jo...@redhat.com
Cc: Stephane Eranian eran...@google.com
Cc
From: Namhyung Kim namhyung@lge.com
Show group members' overhead also when showing the leader's if event
group is enabled. At this time, only implemented overhead part in
order to ease review and other parts can be added later once this
patch settled down.
Cc: Jiri Olsa jo...@redhat.com
Cc
From: Namhyung Kim namhyung@lge.com
Like group_stats in hist_entry, total periods information also need to
be known to the leader.
Cc: Jiri Olsa jo...@redhat.com
Cc: Stephane Eranian eran...@google.com
Signed-off-by: Namhyung Kim namhy...@kernel.org
---
tools/perf/util/hist.c | 25
From: Namhyung Kim namhyung@lge.com
Save group relationship information so that it can be restored when
perf report is running.
Cc: Jiri Olsa jo...@redhat.com
Cc: Stephane Eranian eran...@google.com
Signed-off-by: Namhyung Kim namhy...@kernel.org
---
tools/perf/builtin-record.c |3
a...@ghostprotocols.net
Cc: Peter Zijlstra a.p.zijls...@chello.nl
Cc: Ingo Molnar mi...@elte.hu
Cc: Paul Mackerras pau...@samba.org
Cc: Corey Ashford cjash...@linux.vnet.ibm.com
Cc: Frederic Weisbecker fweis...@gmail.com
Cc: Namhyung Kim namhy...@kernel.org
Signed-off-by: Jiri Olsa jo...@redhat.com
From: Namhyung Kim namhyung@lge.com
Since it is set to 1 for a new hist entry, no need to set to
separately. Move it to a template entry.
Cc: Jiri Olsa jo...@redhat.com
Cc: Arun Sharma asha...@fb.com
Cc: Stephane Eranian eran...@google.com
Cc: Frederic Weisbecker fweis...@gmail.com
Signed
cjash...@linux.vnet.ibm.com
Cc: Frederic Weisbecker fweis...@gmail.com
Cc: Namhyung Kim namhy...@kernel.org
Signed-off-by: Jiri Olsa jo...@redhat.com
Signed-off-by: Namhyung Kim namhy...@kernel.org
---
tools/perf/ui/hist.c | 74
tools/perf/ui/stdio
From: Namhyung Kim namhyung@lge.com
Save group relationship information so that it can be restored when
perf report is running.
Cc: Jiri Olsa jo...@redhat.com
Cc: Stephane Eranian eran...@google.com
Signed-off-by: Namhyung Kim namhy...@kernel.org
---
Initialize leader to NULL in order
1 - 100 of 12633 matches
Mail list logo
