Re: [PATCH 3/3] i8k: Remove laptop specific config data (fan_mult, fan_max) from driver

2014-12-28 Thread Pali Rohár
On Saturday 27 December 2014 15:13:28 Gabriele Mazzotta wrote: On Thursday 25 December 2014 22:54:34 Gabriele Mazzotta wrote: On Thursday 18 December 2014 12:08:58 Pali Rohár wrote: On Wednesday 10 December 2014 14:32:16 Gabriele Mazzotta wrote: On Wednesday 10 December 2014 12:51:30

Re: [PATCH 3/3] i8k: Remove laptop specific config data (fan_mult, fan_max) from driver

2014-12-28 Thread Pali Rohár
* Copyright (C) 2013, 2014 Guenter Roeck li...@roeck-us.net + * Copyright (C) 2014 Pali Rohár pali.ro...@gmail.com * * This program is free software; you can redistribute it and/or modify it * under the terms of the GNU General Public License as published by the @@ -42,12 +43,14 @@ #define

Re: [PATCH 3/3] i8k: Remove laptop specific config data (fan_mult, fan_max) from driver

2014-12-28 Thread Pali Rohár
On Sunday 28 December 2014 16:25:21 Gabriele Mazzotta wrote: On Sunday 28 December 2014 09:46:19 Pali Rohár wrote: Ok, here are new patches for testing... Those you are still reading this email thread and have your Dell machines near, can you test them (ideally with disabling dmi config

Re: [PATCH 3/3] i8k: Remove laptop specific config data (fan_mult, fan_max) from driver

2014-12-28 Thread Pali Rohár
On Sunday 28 December 2014 17:02:35 Gabriele Mazzotta wrote: On Sunday 28 December 2014 16:48:54 Pali Rohár wrote: On Sunday 28 December 2014 16:25:21 Gabriele Mazzotta wrote: On Sunday 28 December 2014 09:46:19 Pali Rohár wrote: Ok, here are new patches for testing... Those you

Re: [PATCH 0/3] Dell Airplane Mode Switch driver

2014-12-29 Thread Pali Rohár
On Monday 29 December 2014 08:27:21 Alex Hung wrote: On Fri, Dec 26, 2014 at 5:55 AM, Gabriele Mazzotta gabriele@gmail.com wrote: On Thursday 25 December 2014 21:11:05 Pali Rohár wrote: I will try to recap all information which we have... *) We should not send wireless key press

Re: [PATCH 3/3] i8k: Remove laptop specific config data (fan_mult, fan_max) from driver

2014-12-29 Thread Pali Rohár
module should be lower and could not freeze system, right? -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part.

Re: Nokia n900 problems in 3.18-rc1 (was Re: USB Ethernet gadget on Nokia n900)

2014-10-31 Thread Pali Rohár
. Sometimes after reboot it working and sometimes not. It looks like Nokia Bootloader set something somewhere and then it works... I have no idea how to fix it... -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part.

Re: [PATCH] i8k: Add support for Dell Latitude E6440

2014-10-31 Thread Pali Rohár
On Friday 24 October 2014 20:44:59 Pali Rohár wrote: On Saturday 18 October 2014 12:40:56 Greg Kroah-Hartman wrote: On Sat, Oct 18, 2014 at 12:23:39AM +0200, Pali Rohár wrote: On Friday 10 October 2014 22:56:55 Guenter Roeck wrote: On 10/10/2014 02:12 AM, Pali Rohár wrote: Dell

[PATCH v3 0/4] Fixes for ALPS driver

2014-11-01 Thread Pali Rohár
to userspace. Reported bugs: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1258837 https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1320022 https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1272624 https://bugzilla.redhat.com/show_bug.cgi?id=1145954 Pali Rohár (4): input: alps: Do not try

[PATCH v3 2/4] input: alps: Allow 2 invalid packets without resetting device

2014-11-01 Thread Pali Rohár
time and when doing reset on some Dell laptops touchpad, trackstick and also keyboard do not respond. So it is better to do it only if really necessary. Signed-off-by: Pali Rohár pali.ro...@gmail.com Tested-by: Pali Rohár pali.ro...@gmail.com Cc: sta...@vger.kernel.org --- drivers/input/mouse

[PATCH v3 4/4] input: alps: Fix trackstick detection

2014-11-01 Thread Pali Rohár
properties for both input devices. Side effect of this patch is also faster alps devices initialization because function alps_identify() is called only once (from alps_init()). Signed-off-by: Pali Rohár pali.ro...@gmail.com Tested-by: Pali Rohár pali.ro...@gmail.com Cc: sta...@vger.kernel.org

[PATCH v3 3/4] input: alps: For protocol V3, do not process data when last packet's bit7 is set

2014-11-01 Thread Pali Rohár
driver does not enter to out of sync state. This patch fix problem when psmouse driver still resetting ALPS device when laptop lid is closed because of receiving invalid packets in out of sync state. Signed-off-by: Pali Rohár pali.ro...@gmail.com Tested-by: Pali Rohár pali.ro...@gmail.com Cc: sta

Re: [PATCH 1/3] input: alps: Reset mouse before identifying it

2014-11-01 Thread Pali Rohár
On Thursday 23 October 2014 17:44:04 Dmitry Torokhov wrote: On Sun, Oct 19, 2014 at 01:07:41PM +0200, Pali Rohár wrote: On Wednesday 15 October 2014 20:22:56 Dmitry Torokhov wrote: On Wed, Oct 15, 2014 at 08:10:39PM +0200, Pali Rohár wrote: On Wednesday 15 October 2014 20:00:11 Dmitry

[PATCH v3 1/4] input: alps: Do not try to parse data as 3 bytes packet when driver is out of sync

2014-11-01 Thread Pali Rohár
packets is there since first version of alps.c existence (since 2.6.9-rc2). We do not want to break some older ALPS devices. And disabling processing bare PS/2 packets when driver is out of sync should not break it. Signed-off-by: Pali Rohár pali.ro...@gmail.com Tested-by: Pali Rohár pali.ro

Re: [PATCH 0/7] Fixes for ALPS trackstick

2014-11-25 Thread Pali Rohár
On Thursday 20 November 2014 00:29:49 Pali Rohár wrote: On Monday 17 November 2014 08:39:14 Pali Rohár wrote: On Friday 14 November 2014 21:59:31 Dmitry Torokhov wrote: Hi Pali, On Friday, November 14, 2014 08:38:19 PM Pali Rohár wrote: This patch series fix detection

Re: [PATCH v3 0/4] Fixes for ALPS driver

2014-11-06 Thread Pali Rohár
On Sunday 02 November 2014 15:14:55 Hans de Goede wrote: Hi, On 11/02/2014 12:25 AM, Pali Rohár wrote: This patch series tries to fix problems with ALPS dualpoint devices on Dell Latitude laptops which are probably caused by bugs in Dell BIOS, Dell EC or in ALPS touchpad firmware

Re: N900 modem support in 3.18-rc1

2014-11-06 Thread Pali Rohár
library (communication with kernel) * pulseaudio modules which are using that library Freemangordon (Ivaylo Dimitrov, CCed) should know more about it, specially about pulseaudio modules... -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part.

Re: [PATCH v3 4/4] input: alps: Fix trackstick detection

2014-11-09 Thread Pali Rohár
On Sunday 09 November 2014 09:05:04 Dmitry Torokhov wrote: Hi Pali, On Sun, Nov 02, 2014 at 12:25:10AM +0100, Pali Rohár wrote: int alps_detect(struct psmouse *psmouse, bool set_properties) { - struct alps_data dummy; + unsigned char e6[4]; - if (alps_identify(psmouse

Re: tsc2005 touchscreen: implement disable attribute

2014-11-09 Thread Pali Rohár
). CCed Dmitry, what do you think about it? -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part.

Re: [PATCH] dell-wmi: Update code for processing WMI events

2014-11-09 Thread Pali Rohár
On Wednesday 22 October 2014 12:51:17 Pali Rohár wrote: On Tuesday 21 October 2014 23:32:12 Darren Hart wrote: On Tue, Oct 21, 2014 at 12:15:24AM +0200, Pali Rohár wrote: WMI buffer can contains more events. First value in buffer is length of event followed by data of specified length

Re: [PATCH] rtc: Disable EFI rtc for x86

2014-11-09 Thread Pali Rohár
file /sys/class/rtc/rtc*/since_epoch returns correct information. So why to disable compiling driver on machines where driver working? -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part.

Re: N900 modem support in 3.18-rc1

2014-11-14 Thread Pali Rohár
, should not it have alsa snd interface? V4L2 interface is not for video/camera/capture/tv cards? -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part.

[PATCH 6/7] input: alps: Add sanity checks for non DualPoint devices

2014-11-14 Thread Pali Rohár
dmesg so possible problems with driver (e.g received invalid data) will be visible for debugging. Signed-off-by: Pali Rohár pali.ro...@gmail.com --- drivers/input/mouse/alps.c | 22 -- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/drivers/input/mouse/alps.c b

[PATCH 2/7] input: alps: Move trackstick detection to alps_hw_init_*

2014-11-14 Thread Pali Rohár
Now when alps_identify() does not need do trackstick detection it is safe to move code init hw_init functions. This patch also fix trackstick detection in function alps_hw_init_v3() which remove ALPS_DUALPOINT flag when trackstick is not detected. Signed-off-by: Pali Rohár pali.ro...@gmail.com

[PATCH 7/7] input: alps: Do not report both trackstick and external PS/2 mouse data to one input device

2014-11-14 Thread Pali Rohár
(data will be reported to dev3 instead dev2). Signed-off-by: Pali Rohár pali.ro...@gmail.com --- drivers/input/mouse/alps.c | 163 +++- drivers/input/mouse/alps.h | 14 +++- 2 files changed, 128 insertions(+), 49 deletions(-) diff --git a/drivers/input

[PATCH 5/7] input: alps: Fix name, product and version of dev2 input device

2014-11-14 Thread Pali Rohár
This patch fix name, product and version of dev2 input device based on format used in function psmouse_switch_protocol() in file psmouse-base.c. Signed-off-by: Pali Rohár pali.ro...@gmail.com --- drivers/input/mouse/alps.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions

[PATCH 1/7] input: alps: Set correct name of psmouse device in alps_init()

2014-11-14 Thread Pali Rohár
trackstick detection in alps_detect() function. Signed-off-by: Pali Rohár pali.ro...@gmail.com --- drivers/input/mouse/alps.c | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/drivers/input/mouse/alps.c b/drivers/input/mouse/alps.c index 8d85c79..9ffa98d 100644

[PATCH 4/7] input: alps: Use NULL instead dummy argument for alps_identify

2014-11-14 Thread Pali Rohár
of alps devices. Signed-off-by: Pali Rohár pali.ro...@gmail.com --- drivers/input/mouse/alps.c | 114 +++- 1 file changed, 71 insertions(+), 43 deletions(-) diff --git a/drivers/input/mouse/alps.c b/drivers/input/mouse/alps.c index 5603870..0176425 100644

[PATCH 0/7] Fixes for ALPS trackstick

2014-11-14 Thread Pali Rohár
This patch series fix detection and identifying trackstick on machines with ALPS devices. Last patch split trackstick and bare PS/2 mouse packets between dev2 and dev3 input devices which make sure that driver will send only trackstick data to trackstick input device. Pali Rohár (7): input

[PATCH 3/7] input: alps: Move alps_dolphin_get_device_area into alps_hw_init_dolphin_v1

2014-11-14 Thread Pali Rohár
This patch moves function call alps_dolphin_get_device_area() from function alps_identify() to alps_hw_init_dolphin_v1() so alps_identify() will not call any other psmouse commands. Signed-off-by: Pali Rohár pali.ro...@gmail.com --- drivers/input/mouse/alps.c | 13 +++-- 1 file changed

Re: [PATCH v3 4/4] input: alps: Fix trackstick detection

2014-11-14 Thread Pali Rohár
On Friday 14 November 2014 12:22:33 Pali Rohár wrote: On Sunday 09 November 2014 12:30:03 Pali Rohár wrote: On Sunday 09 November 2014 09:05:04 Dmitry Torokhov wrote: Hi Pali, On Sun, Nov 02, 2014 at 12:25:10AM +0100, Pali Rohár wrote: int alps_detect(struct psmouse *psmouse

Re: [PATCH 0/7] Fixes for ALPS trackstick

2014-11-16 Thread Pali Rohár
On Friday 14 November 2014 21:59:31 Dmitry Torokhov wrote: Hi Pali, On Friday, November 14, 2014 08:38:19 PM Pali Rohár wrote: This patch series fix detection and identifying trackstick on machines with ALPS devices. Last patch split trackstick and bare PS/2 mouse packets between dev2

Re: [PATCH] i8k: Ignore temperature sensors which report invalid values

2014-11-17 Thread Pali Rohár
On Thursday 23 October 2014 18:45:07 Guenter Roeck wrote: On Thu, Oct 23, 2014 at 12:37:34PM +0200, Pali Rohár wrote: On Wednesday 22 October 2014 19:10:05 Guenter Roeck wrote: On Wed, Oct 22, 2014 at 06:35:53PM +0200, Pali Rohár wrote: On Wednesday 22 October 2014 18:19:47 Guenter Roeck

Re: [RFC] adp1653: Add device tree bindings for LED controller

2014-11-17 Thread Pali Rohár
legacy board camera code in file board-rx51-camera.c. -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part.

Re: [RFC] adp1653: Add device tree bindings for LED controller

2014-11-17 Thread Pali Rohár
On Monday 17 November 2014 11:05:19 Pavel Machek wrote: Hi! On Mon 2014-11-17 09:43:19, Pali Rohár wrote: On Sunday 16 November 2014 08:59:28 Pavel Machek wrote: For device tree people: Yes, I know I'll have to create file in documentation, but does the binding below look acceptable

Re: [RFC] adp1653: Add device tree bindings for LED controller

2014-11-17 Thread Pali Rohár
On Monday 17 November 2014 15:55:46 Tony Lindgren wrote: * Pavel Machek pa...@ucw.cz [141117 02:17]: On Mon 2014-11-17 11:09:45, Pali Rohár wrote: On Monday 17 November 2014 11:05:19 Pavel Machek wrote: Hi! On Mon 2014-11-17 09:43:19, Pali Rohár wrote: On Sunday 16 November

Re: [RFC] adp1653: Add device tree bindings for LED controller

2014-11-17 Thread Pali Rohár
On Monday 17 November 2014 16:04:07 Sakari Ailus wrote: Hi Pali, On Mon, Nov 17, 2014 at 04:01:31PM +0100, Pali Rohár wrote: On Monday 17 November 2014 15:55:46 Tony Lindgren wrote: * Pavel Machek pa...@ucw.cz [141117 02:17]: On Mon 2014-11-17 11:09:45, Pali Rohár wrote

Re: [RFC] adp1653: Add device tree bindings for LED controller

2014-11-17 Thread Pali Rohár
On Monday 17 November 2014 16:06:17 Tony Lindgren wrote: * Pali Rohár pali.ro...@gmail.com [141117 07:03]: On Monday 17 November 2014 15:55:46 Tony Lindgren wrote: There's nothing stopping us from initializing the camera code from pdata-quirks.c for now to keep it working. Certainly

Re: [PATCH 0/3] Dell Airplane Mode Switch driver

2014-12-02 Thread Pali Rohár
On Wednesday 26 November 2014 00:05:28 Darren Hart wrote: On Sun, Nov 23, 2014 at 04:09:18PM +0100, Pali Rohár wrote: This patch series add new acpi Dell Airplane Mode Switch driver (DELLABCE and DELRBTN acpi devices). It provides radio HW switch events (together with current state

Re: [PATCH] i8k: Add support for temperature sensor labels

2014-12-03 Thread Pali Rohár
(which doing some detection of more sensors, fans, ...), so what about moving hwmon interface into separate module? We just need some common code for executing SMM function. -- Jean Delvare SUSE L3 Support -- Pali Rohár pali.ro...@gmail.com -- To unsubscribe from this list: send the line

Re: [PATCH 0/7] Fixes for ALPS trackstick

2014-12-03 Thread Pali Rohár
On Thursday 27 November 2014 19:08:04 Dmitry Torokhov wrote: On November 25, 2014 3:08:31 AM PST, Pali Rohár pali.ro...@gmail.com wrote: On Thursday 20 November 2014 00:29:49 Pali Rohár wrote: On Monday 17 November 2014 08:39:14 Pali Rohár wrote: On Friday 14 November 2014 21:59:31 Dmitry

Re: Side effect of pressing special keys

2014-12-03 Thread Pali Rohár
On Wednesday 03 December 2014 13:40:42 Pavel Machek wrote: On Sun 2014-11-23 14:41:17, Pali Rohár wrote: Hello, pressing some keys on laptops could cause some side effects. Example scenario 1: Laptop has Fn key for enabling/disabling WIFI and when that key is pressed BIOS

Re: Side effect of pressing special keys

2014-12-03 Thread Pali Rohár
On Wednesday 03 December 2014 14:12:54 Henrique de Moraes Holschuh wrote: On Wed, 03 Dec 2014, Pali Rohár wrote: Ok, and what about KEY_KBDILLUMTOGGLE when bios also handle keyboard backlight level? Should be this key filtered too? IME, heck yes. If you ever make the mistake of sending

Re: Side effect of pressing special keys

2014-12-03 Thread Pali Rohár
On Wednesday 03 December 2014 14:38:15 Gabriele Mazzotta wrote: On Wednesday 03 December 2014 14:24:11 Pali Rohár wrote: On Wednesday 03 December 2014 14:12:54 Henrique de Moraes Holschuh wrote: On Wed, 03 Dec 2014, Pali Rohár wrote: Ok, and what about KEY_KBDILLUMTOGGLE when bios

Re: [PATCH 3/3] i8k: Remove laptop specific config data (fan_mult, fan_max) from driver

2014-12-18 Thread Pali Rohár
On Wednesday 10 December 2014 14:32:16 Gabriele Mazzotta wrote: On Wednesday 10 December 2014 12:51:30 Pali Rohár wrote: On Tuesday 09 December 2014 21:07:01 Pali Rohár wrote: Now we have autodetection code for fan multiplier and maximal fan speed so we do not need to have those

Re: [PATCH 3/3] i8k: Remove laptop specific config data (fan_mult, fan_max) from driver

2014-12-18 Thread Pali Rohár
On Wednesday 17 December 2014 19:20:21 Steven Honeyman wrote: On 17 December 2014 at 17:54, Pali Rohár pali.ro...@gmail.com wrote: On Wednesday 10 December 2014 12:51:30 Pali Rohár wrote: On Tuesday 09 December 2014 21:07:01 Pali Rohár wrote: Now we have autodetection code for fan

Re: [PATCH 2/3] i8k: Autodetect maximal fan speed and fan RPM multiplier

2014-12-18 Thread Pali Rohár
On Wednesday 10 December 2014 15:08:11 Guenter Roeck wrote: On 12/10/2014 03:50 AM, Pali Rohár wrote: On Tuesday 09 December 2014 23:42:08 Guenter Roeck wrote: On Tue, Dec 09, 2014 at 09:23:22PM +0100, Pali Rohár wrote: On Tuesday 09 December 2014 21:20:23 Guenter Roeck wrote: On Tue, Dec

Re: [PATCH 3/3] i8k: Remove laptop specific config data (fan_mult, fan_max) from driver

2014-12-18 Thread Pali Rohár
On Thursday 18 December 2014 16:08:51 valdis.kletni...@vt.edu wrote: On Thu, 18 Dec 2014 12:08:58 +0100, Pali Rohár said: So your BIOS cannot report nominal_rpm and because your machine=20 is not in dmi list, all 3 patches do nothing for your machine. But you need to set multiplier

[PATCH] i8k: Add support for fan labels

2014-12-19 Thread Pali Rohár
reasons. Signed-off-by: Pali Rohár pali.ro...@gmail.com Tested-by: Pali Rohár pali.ro...@gmail.com --- One thing is what is implemented in old DOS binary NBSVC.MDM and another thing what works on new Dell laptops. I tested this patch on Dell Latitude E6440 and it reports Processor Fan. Before sending

[PATCH v2 1/2] i8k: Autodetect maximal fan speed and fan RPM multiplier

2014-12-19 Thread Pali Rohár
multiplier were used). If RPM value with multiplier 30 is too high, then multiplier 1 is used. In case when SMM reports that new function is not supported we will fallback to old hardcoded values. Maximal fan speed would be 2 and RPM multiplier 30. Signed-off-by: Pali Rohár pali.ro...@gmail.com Tested

[PATCH v2 2/2] i8k: Remove DMI config data for Latitude E6x40

2014-12-19 Thread Pali Rohár
Both Dell Latitude machines were tested with new autodetection code and it is working fine. So we do not need to maintain config data for them anymore. Signed-off-by: Pali Rohár pali.ro...@gmail.com Tested-By: Pali Rohár pali.ro...@gmail.com Tested-By: Steven Honeyman stevenhoney...@gmail.com

Re: [PATCH v2 1/2] i8k: Autodetect maximal fan speed and fan RPM multiplier

2014-12-19 Thread Pali Rohár
) ? : (regs.eax 0x) * i8k_fan_mult[fan]; +} -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part.

Re: [PATCH 1/7] input: alps: Set correct name of psmouse device in alps_init()

2014-12-20 Thread Pali Rohár
On Tuesday 16 December 2014 12:58:20 Pali Rohár wrote: On Tuesday 16 December 2014 06:02:34 Dmitry Torokhov wrote: Hi Pali, On Fri, Nov 14, 2014 at 08:38:20PM +0100, Pali Rohár wrote: On some laptops after starting them from off state (not after reboot), function

Re: [PATCH v2 1/2] i8k: Autodetect maximal fan speed and fan RPM multiplier

2014-12-20 Thread Pali Rohár
On Friday 19 December 2014 20:28:08 Guenter Roeck wrote: On Fri, Dec 19, 2014 at 07:51:25PM +0100, Pali Rohár wrote: On Friday 19 December 2014 19:32:37 Guenter Roeck wrote: -static int i8k_fan_mult; -static int i8k_pwm_mult; -static int i8k_fan_max = I8K_FAN_HIGH; +static int

Re: [PATCH 0/3] dell-wmi: Don't send unneeded keypresses

2014-12-20 Thread Pali Rohár
On Wednesday 03 December 2014 19:03:37 Darren Hart wrote: On Fri, Dec 05, 2014 at 10:07:35PM +0100, Pali Rohár wrote: On Friday 05 December 2014 21:41:22 Pavel Machek wrote: On Fri 2014-12-05 21:31:34, Pali Rohár wrote: On Wednesday 03 December 2014 14:34:32 Darren Hart wrote

Re: [PATCH v2 1/2] i8k: Autodetect maximal fan speed and fan RPM multiplier

2014-12-20 Thread Pali Rohár
On Saturday 20 December 2014 13:04:03 Guenter Roeck wrote: On 12/20/2014 12:57 AM, Pali Rohár wrote: On Friday 19 December 2014 20:28:08 Guenter Roeck wrote: On Fri, Dec 19, 2014 at 07:51:25PM +0100, Pali Rohár wrote: On Friday 19 December 2014 19:32:37 Guenter Roeck wrote: -static int

Re: [PATCH v2 1/2] i8k: Autodetect maximal fan speed and fan RPM multiplier

2014-12-20 Thread Pali Rohár
On Saturday 20 December 2014 13:44:59 Guenter Roeck wrote: On 12/20/2014 04:18 AM, Pali Rohár wrote: On Saturday 20 December 2014 13:04:03 Guenter Roeck wrote: On 12/20/2014 12:57 AM, Pali Rohár wrote: On Friday 19 December 2014 20:28:08 Guenter Roeck wrote: On Fri, Dec 19, 2014 at 07:51

Re: [PATCH v2 1/2] i8k: Autodetect maximal fan speed and fan RPM multiplier

2014-12-21 Thread Pali Rohár
version of patch. -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part.

Re: [PATCH v2 1/2] i8k: Autodetect maximal fan speed and fan RPM multiplier

2014-12-21 Thread Pali Rohár
. -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part.

Re: [PATCH v2 1/2] i8k: Autodetect maximal fan speed and fan RPM multiplier

2014-12-21 Thread Pali Rohár
; + } + } I wonder if it would help to detect the maximum fan speed first. Once that is known, it should be possible to just read the nominal fan speed once, for the known maximum speed. With this, the 'val' loop here would be unnecessary. Right, good point. -- Pali Rohár pali.ro

[PATCH v3] i8k: Autodetect maximal fan speed and fan RPM multiplier

2014-12-21 Thread Pali Rohár
multiplier were used). If RPM value with multiplier 30 is too high, then multiplier 1 is used. In case when SMM reports that new function is not supported we will fallback to old hardcoded values. Maximal fan speed would be 2 and RPM multiplier 30. Signed-off-by: Pali Rohár pali.ro...@gmail.com Tested

Re: [PATCH v3] i8k: Autodetect maximal fan speed and fan RPM multiplier

2014-12-21 Thread Pali Rohár
should not propagate negative value to functions. -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part.

Re: [PATCH v3] i8k: Autodetect maximal fan speed and fan RPM multiplier

2014-12-21 Thread Pali Rohár
On Sunday 21 December 2014 13:23:32 Guenter Roeck wrote: On 12/21/2014 04:09 AM, Pali Rohár wrote: On Sunday 21 December 2014 12:57:08 Guenter Roeck wrote: -#define I8K_FAN_MULT 30 +#define I8K_FAN_MAX_RPM 3 #define I8K_MAX_TEMP 127

[PATCH] i8k: Make fan module parameters an unsigned

2014-12-21 Thread Pali Rohár
Setting negative fan multiplier or maximal fan speed does make any sense and can cause problems. So ensure that negative values will not be accepted. Signed-off-by: Pali Rohár pali.ro...@gmail.com --- drivers/char/i8k.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions

[PATCH v4] i8k: Autodetect maximal fan speed and fan RPM multiplier

2014-12-21 Thread Pali Rohár
multiplier were used). If RPM value with multiplier 30 is too high, then multiplier 1 is used. In case when SMM reports that new function is not supported we will fallback to old hardcoded values. Maximal fan speed would be 2 and RPM multiplier 30. Signed-off-by: Pali Rohár pali.ro...@gmail.com Tested

Re: [PATCH v3] i8k: Autodetect maximal fan speed and fan RPM multiplier

2014-12-21 Thread Pali Rohár
On Sunday 21 December 2014 17:55:51 Steven Honeyman wrote: On 21 December 2014 at 16:37, Pali Rohár pali.ro...@gmail.com wrote: On Sunday 21 December 2014 13:23:32 Guenter Roeck wrote: On 12/21/2014 04:09 AM, Pali Rohár wrote: On Sunday 21 December 2014 12:57:08 Guenter Roeck wrote

Re: [PATCH v4] i8k: Autodetect maximal fan speed and fan RPM multiplier

2014-12-21 Thread Pali Rohár
On Sunday 21 December 2014 19:27:34 Guenter Roeck wrote: On 12/21/2014 09:23 AM, Pali Rohár wrote: This patch adds new function i8k_get_fan_nominal_speed() for doing SMM call which will return nominal fan RPM for specified fan speed. It returns nominal RPM value at which fan operate when

[PATCH 02/10] i8k: Register only temperature sensors which have labels

2014-12-21 Thread Pali Rohár
Detect presense of sensor by calling type function instead trying to read temperature value. Type function is working also for sensors which are temporary turned off (e.g on GPU which is turned off). Dell DOS binary NBSVC.MDM is doing similar checks, so we should do that too. Signed-off-by: Pali

[PATCH 10/10] i8k: Add support for fan labels

2014-12-21 Thread Pali Rohár
reasons. Signed-off-by: Pali Rohár pali.ro...@gmail.com --- drivers/char/i8k.c | 76 ++-- 1 file changed, 62 insertions(+), 14 deletions(-) diff --git a/drivers/char/i8k.c b/drivers/char/i8k.c index 9288edb..ca4203c 100644 --- a/drivers/char/i8k.c

[PATCH 08/10] i8k: Autodetect maximal fan speed and fan RPM multiplier

2014-12-21 Thread Pali Rohár
multiplier were used). If RPM value with multiplier 30 is too high, then multiplier 1 is used. In case when SMM reports that new function is not supported we will fallback to old hardcoded values. Maximal fan speed would be 2 and RPM multiplier 30. Signed-off-by: Pali Rohár pali.ro...@gmail.com Tested

[PATCH 09/10] i8k: Remove DMI config data for Latitude E6440 and E6540

2014-12-21 Thread Pali Rohár
Rohár pali.ro...@gmail.com Tested-by: Pali Rohár pali.ro...@gmail.com Tested-by: Steven Honeyman stevenhoney...@gmail.com --- drivers/char/i8k.c | 21 - 1 file changed, 21 deletions(-) diff --git a/drivers/char/i8k.c b/drivers/char/i8k.c index 4c66788..9288edb 100644

[PATCH 05/10] i8k: Rework error retries

2014-12-21 Thread Pali Rohár
off. Drop the I8K_TEMPERATURE_BUG definition and handle the related bug unconditionally. Signed-off-by: Guenter Roeck li...@roeck-us.net Tested-by: Pali Rohár pali.ro...@gmail.com --- drivers/char/i8k.c | 47 --- 1 file changed, 24 insertions(+), 23

[PATCH 07/10] i8k: Make fan module parameters an unsigned

2014-12-21 Thread Pali Rohár
Setting negative fan multiplier or maximal fan speed does make any sense and can cause problems. So ensure that negative values will not be accepted. Signed-off-by: Pali Rohár pali.ro...@gmail.com Reviewed-by: Guenter Roeck li...@roeck-us.net --- drivers/char/i8k.c | 18 +- 1

Re: [PATCH v4] i8k: Autodetect maximal fan speed and fan RPM multiplier

2014-12-21 Thread Pali Rohár
On Sunday 21 December 2014 19:51:19 Guenter Roeck wrote: On 12/21/2014 10:40 AM, Pali Rohár wrote: On Sunday 21 December 2014 19:27:34 Guenter Roeck wrote: On 12/21/2014 09:23 AM, Pali Rohár wrote: This patch adds new function i8k_get_fan_nominal_speed() for doing SMM call which

[PATCH 04/10] MAINTAINERS: Fix up entry for Dell laptop SMM driver

2014-12-21 Thread Pali Rohár
From: Guenter Roeck li...@roeck-us.net Mark driver as maintained. Signed-off-by: Guenter Roeck li...@roeck-us.net Reviewed-by: Jean Delvare jdelv...@suse.de --- MAINTAINERS |1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index c444907..2c15f7a 100644 ---

[PATCH 01/10] i8k: Add support for temperature sensor labels

2014-12-21 Thread Pali Rohár
This patch adds labels for temperature sensors if SMM function with EAX register 0x11a3 reports it. This information was taken from DOS binary NBSVC.MDM. Signed-off-by: Pali Rohár pali.ro...@gmail.com Reviewed-by: Guenter Roeck li...@roeck-us.net Tested-by: Guenter Roeck li...@roeck-us.net Tested

[PATCH 06/10] i8k: Add support for Dell XPS 13

2014-12-21 Thread Pali Rohár
From: Guenter Roeck li...@roeck-us.net XPS 13 does not support turbo speed, so its initialization data matches that of XPS M140. Make XPS initialization data generic, and add support for XPS 13. Signed-off-by: Guenter Roeck li...@roeck-us.net Reviewed-by: Jean Delvare jdelv...@suse.de ---

[PATCH 03/10] i8k: Return -ENODATA for invalid temperature

2014-12-21 Thread Pali Rohár
Guenter Roeck suggested to return -ENODATA instead -ERANGE or -EINVAL when BIOS reports invalid temperature value. Signed-off-by: Pali Rohár pali.ro...@gmail.com Reviewed-by: Guenter Roeck li...@roeck-us.net Tested-by: Guenter Roeck li...@roeck-us.net --- drivers/char/i8k.c |4 +--- 1 file

[PATCH 00/10] i8k patches

2014-12-21 Thread Pali Rohár
This patch series contains all i8k patches which were not merged to char-misc tree yet. Guenter Roeck (3): MAINTAINERS: Fix up entry for Dell laptop SMM driver i8k: Rework error retries i8k: Add support for Dell XPS 13 Pali Rohár (7): i8k: Add support for temperature sensor labels i8k

Re: [PATCH 10/10] i8k: Add support for fan labels

2014-12-22 Thread Pali Rohár
for other values is Other Fan better than nothing. -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part.

Re: [PATCH 0/3] Dell Airplane Mode Switch driver

2014-12-22 Thread Pali Rohár
could have values changed by NetworkManager and not by kernel. And I have one question: Does Inspirion 5721 have ACPI DELRBTN device (instead DELLABCE). -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part.

Re: [PATCH v4] i8k: Autodetect maximal fan speed and fan RPM multiplier

2014-12-22 Thread Pali Rohár
On Sunday 21 December 2014 20:51:14 Guenter Roeck wrote: On 12/21/2014 09:23 AM, Pali Rohár wrote: This patch adds new function i8k_get_fan_nominal_speed() for doing SMM call which will return nominal fan RPM for specified fan speed. It returns nominal RPM value at which fan operate when

Re: [PATCH 1/7] input: alps: Set correct name of psmouse device in alps_init()

2014-12-16 Thread Pali Rohár
On Tuesday 16 December 2014 06:02:34 Dmitry Torokhov wrote: Hi Pali, On Fri, Nov 14, 2014 at 08:38:20PM +0100, Pali Rohár wrote: On some laptops after starting them from off state (not after reboot), function alps_probe_trackstick_v3() (called from function alps_identify()) does

Re: [PATCH 3/3] i8k: Remove laptop specific config data (fan_mult, fan_max) from driver

2014-12-17 Thread Pali Rohár
On Wednesday 10 December 2014 12:51:30 Pali Rohár wrote: On Tuesday 09 December 2014 21:07:01 Pali Rohár wrote: Now we have autodetection code for fan multiplier and maximal fan speed so we do not need to have those constants for each laptop in kernel driver code. Signed-off-by: Pali

[PATCH] i8k: Add support for Dell Latitude E6440

2014-10-10 Thread Pali Rohár
Dell Latitude E6440 needs same settings as E6540. Signed-off-by: Pali Rohár pali.ro...@gmail.com --- drivers/char/i8k.c |8 1 file changed, 8 insertions(+) diff --git a/drivers/char/i8k.c b/drivers/char/i8k.c index 34174d0..471f985 100644 --- a/drivers/char/i8k.c +++ b/drivers/char

Re: [PATCH] Route keyboard LEDs through the generic LEDs layer.

2014-10-12 Thread Pali Rohár
Hello, I would like to ask if something was changed and if this patch (in any way) is going to mainline kernel. -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part.

Re: [PATCH] dell-wmi: Fix access out of memory

2014-10-12 Thread Pali Rohár
On Tuesday 30 September 2014 01:16:23 Darren Hart wrote: On September 29, 2014 4:26:03 PM PDT, Rafael J. Wysocki r...@rjwysocki.net wrote: On Monday, September 29, 2014 02:30:29 PM Darren Hart wrote: On Mon, Sep 29, 2014 at 03:10:51PM +0200, Pali Rohár wrote: Without this patch driver dell

Re: N900 modem support in 3.18-rc1

2014-11-05 Thread Pali Rohár
Hello, have you enabled CONFIG_PHONET? -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part.

Re: N900 modem support in 3.18-rc1

2014-11-05 Thread Pali Rohár
ln -nsf /sys/class/gpio/gpio75 /dev/cmt/cmt_rst ln -nsf /sys/class/gpio/gpio157 /dev/cmt/cmt_bsi -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part.

wl1251: NVS firmware data

2014-11-27 Thread Pali Rohár
to use model specific data and if it fails for some reasons then fallback to reading genetic data. -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part.

dts: n900: isp1704 gpio

2014-11-27 Thread Pali Rohár
data and in DTS data? I'm sure that isp1704 worked from legacy board data without problem, so I do not understand why in DTS code is different gpio number. -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part.

Re: wl1251: NVS firmware data

2014-11-27 Thread Pali Rohár
On Thursday 27 November 2014 15:21:44 Ming Lei wrote: On Thu, Nov 27, 2014 at 10:06 PM, Pali Rohár pali.ro...@gmail.com wrote: Hello, wifi driver wl1251 needs NVS calibration data for working. These data are loaded by driver via request_firmware from userspace file: ti-connectivity

Re: wl1251: NVS firmware data

2014-11-27 Thread Pali Rohár
On Thursday 27 November 2014 16:16:55 Greg Kroah-Hartman wrote: On Thu, Nov 27, 2014 at 03:43:23PM +0100, Pali Rohár wrote: On Thursday 27 November 2014 15:21:44 Ming Lei wrote: On Thu, Nov 27, 2014 at 10:06 PM, Pali Rohár pali.ro...@gmail.com wrote: Hello, wifi driver

Re: wl1251: NVS firmware data

2014-11-27 Thread Pali Rohár
On Thursday 27 November 2014 16:14:48 Greg Kroah-Hartman wrote: On Thu, Nov 27, 2014 at 03:43:23PM +0100, Pali Rohár wrote: Which userspace helper programs for (automatic) firmware loading are used? Can be udev configured to use own program for loading firmware instead that udev integrated

Missing MODALIAS in /sys/devices/system/cpu/uevent

2014-11-27 Thread Pali Rohár
but is missing MODALIAS= line in uevent file? What userspace application should use for reading modalias string? File modalias or file uevent? -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part.

Re: Missing MODALIAS in /sys/devices/system/cpu/uevent

2014-11-27 Thread Pali Rohár
On Thursday 27 November 2014 21:39:42 Rafael J. Wysocki wrote: On Thursday, November 27, 2014 09:01:11 PM Pali Rohár wrote: --nextPart2712852.Yg3XtZvm05 Content-Type: Text/Plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello, on 3.18-rc5 I have empty

Re: Missing MODALIAS in /sys/devices/system/cpu/uevent

2014-11-27 Thread Pali Rohár
On Thursday 27 November 2014 22:00:32 Rafael J. Wysocki wrote: On Thursday, November 27, 2014 09:59:03 PM Rafael J. Wysocki wrote: On Thursday, November 27, 2014 09:56:56 PM Rafael J. Wysocki wrote: On Thursday, November 27, 2014 09:24:30 PM Pali Rohár wrote: On Thursday 27 November

Re: [PATCH 1/3] platform: x86: dell-rbtn: Dell Airplane Mode Switch driver

2014-11-28 Thread Pali Rohár
rbtn_init(void) +{ + return acpi_bus_register_driver(rbtn_driver); +} + +static void __exit rbtn_exit(void) +{ + acpi_bus_unregister_driver(rbtn_driver); +} + +module_init(rbtn_init); +module_exit(rbtn_exit); module_acpi_driver()? No, see PATCH 2/3. -- Pali Rohár

[PATCH] i8k: Add support for temperature sensor labels

2014-11-29 Thread Pali Rohár
This patch adds labels for temperature sensors if SMM function with EAX register 0x11a3 reports it. These informations was taken from DOS binary NBSVC.MDM. Signed-off-by: Pali Rohár pali.ro...@gmail.com --- drivers/char/i8k.c | 110 +--- 1 file

Re: [PATCH] i8k: Add support for temperature sensor labels

2014-11-29 Thread Pali Rohár
On Saturday 29 November 2014 17:04:07 Pali Rohár wrote: This patch adds labels for temperature sensors if SMM function with EAX register 0x11a3 reports it. These informations was taken from DOS binary NBSVC.MDM. Signed-off-by: Pali Rohár pali.ro...@gmail.com --- drivers/char/i8k.c | 110

<    1   2   3   4   5   6   7   8   9   10   >